Re: Ajax Wizard and feedback

2009-12-04 Thread Igor Vaynberg
 protected void onError(final AjaxRequestTarget target, Form form) {
   form.visit(FormComponentPanel.class, new
Visitor() {
   visitComponent(FormComponentPanel component) {
   target.addComponent(feedback);
   return CONTINUE_TRAVERSAL_BUT_DO_NOT_GO_DEEPER;
  }}}

-igor

On Fri, Dec 4, 2009 at 2:28 PM, John Armstrong  wrote:
> My problem was 4 fold (after multiple iterations of problems)
>
> 1) I was overriding onError in both AjaxButton and AjaxButtonBar so my
> AjaxButton version was ignored
> 2) I am using the default ButtonBar html which has a component called
> 'feedback' in it, this dup'd my nested "feedback" form (merely
> confusing for me)
> 4) I was showing the -wrong- feedback panel (see 2)
> 5) My signup feedback was within the RadioGroup which made its path
> unique across my wizard steps. I had to move it out of a nested
> context so it was generalized.
>
> So my final result at the button level.
>
>        protected void onError(AjaxRequestTarget target, Form form) {
>                Component feedback = form.get("view:signupfeedback");
>                target.addComponent(feedback);
>        }
>
> The form.get("view:signupfeedback") seems fragile to me but I guess in
> this case its general enough that it won't break as long as I put my
> feedback panel at the top level.
>
> Tips/suggestions welcome but its working now, thanks for the
> direction, it made my day-
>
> J
>
> On Fri, Dec 4, 2009 at 12:16 PM, Igor Vaynberg  
> wrote:
>> does your button also properly implement onerror() ?
>>
>> -igor
>>
>> On Fri, Dec 4, 2009 at 11:35 AM, John Armstrong  
>> wrote:
>>> The button itself lives in my ButtonBar class and the buttons
>>> themselves are extensions of AjaxFallbackButtons
>>>
>>> public class AjaxWizardButtonBar extends WizardButtonBar
>>>
>>> public abstract class AjaxWizardButton extends AjaxFallbackButton
>>>
>>> The buttonbar class has an onSubmit method that knows when things are
>>> good or bad (confirmed in a non-AJAX context) but when I run as AJAX
>>> enabled (enabling javascript) onSubmit never fires.
>>>
>>> John-
>>>
>>>
>>> On Fri, Dec 4, 2009 at 9:00 AM, Igor Vaynberg  
>>> wrote:
 where is the code of the ajax button that submits the step?

 -igor

 On Fri, Dec 4, 2009 at 7:08 AM, John Armstrong  
 wrote:
> Still working on this darn sign-up form in my spare time. I currently
> can not get feedback to show up. If I disable javascript it shows up
> but using ajax it does not.
>
> In my WizardStep I have the code to add the feedback panel to the
> target as a placeholder. (confirmed, its in the DOM hidden). Adding
> feedback panel to a RadioGroup:
>
> ===
> private final class SelectPlan extends WizardStep implements
> IDynamicWizardStep {
>
> group.setRequired(true);
> final FeedbackPanel feedback = new FeedbackPanel("feedback");
> feedback.setOutputMarkupId(true);
> feedback.setOutputMarkupPlaceholderTag(true);
> if(target != null){
>    target.addComponent(feedback);
> }
> group.add(feedback);
> ===
>
> But on submit I still get this in my dev log
> WARN  - WebSession                 - Component-targetted feedback
> message was left unrendered. This could be because you are missing a
> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
> 'planselection' is required.", reporter = planselection, level =
> ERROR]
>
> What simple thing am I missing?
>
> John-
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread John Armstrong
My problem was 4 fold (after multiple iterations of problems)

1) I was overriding onError in both AjaxButton and AjaxButtonBar so my
AjaxButton version was ignored
2) I am using the default ButtonBar html which has a component called
'feedback' in it, this dup'd my nested "feedback" form (merely
confusing for me)
4) I was showing the -wrong- feedback panel (see 2)
5) My signup feedback was within the RadioGroup which made its path
unique across my wizard steps. I had to move it out of a nested
context so it was generalized.

So my final result at the button level.

protected void onError(AjaxRequestTarget target, Form form) {
Component feedback = form.get("view:signupfeedback");
target.addComponent(feedback);
}

The form.get("view:signupfeedback") seems fragile to me but I guess in
this case its general enough that it won't break as long as I put my
feedback panel at the top level.

Tips/suggestions welcome but its working now, thanks for the
direction, it made my day-

J

On Fri, Dec 4, 2009 at 12:16 PM, Igor Vaynberg  wrote:
> does your button also properly implement onerror() ?
>
> -igor
>
> On Fri, Dec 4, 2009 at 11:35 AM, John Armstrong  wrote:
>> The button itself lives in my ButtonBar class and the buttons
>> themselves are extensions of AjaxFallbackButtons
>>
>> public class AjaxWizardButtonBar extends WizardButtonBar
>>
>> public abstract class AjaxWizardButton extends AjaxFallbackButton
>>
>> The buttonbar class has an onSubmit method that knows when things are
>> good or bad (confirmed in a non-AJAX context) but when I run as AJAX
>> enabled (enabling javascript) onSubmit never fires.
>>
>> John-
>>
>>
>> On Fri, Dec 4, 2009 at 9:00 AM, Igor Vaynberg  
>> wrote:
>>> where is the code of the ajax button that submits the step?
>>>
>>> -igor
>>>
>>> On Fri, Dec 4, 2009 at 7:08 AM, John Armstrong  
>>> wrote:
 Still working on this darn sign-up form in my spare time. I currently
 can not get feedback to show up. If I disable javascript it shows up
 but using ajax it does not.

 In my WizardStep I have the code to add the feedback panel to the
 target as a placeholder. (confirmed, its in the DOM hidden). Adding
 feedback panel to a RadioGroup:

 ===
 private final class SelectPlan extends WizardStep implements
 IDynamicWizardStep {

 group.setRequired(true);
 final FeedbackPanel feedback = new FeedbackPanel("feedback");
 feedback.setOutputMarkupId(true);
 feedback.setOutputMarkupPlaceholderTag(true);
 if(target != null){
    target.addComponent(feedback);
 }
 group.add(feedback);
 ===

 But on submit I still get this in my dev log
 WARN  - WebSession                 - Component-targetted feedback
 message was left unrendered. This could be because you are missing a
 FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
 'planselection' is required.", reporter = planselection, level =
 ERROR]

 What simple thing am I missing?

 John-

 -
 To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
 For additional commands, e-mail: users-h...@wicket.apache.org


>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread Igor Vaynberg
does your button also properly implement onerror() ?

-igor

On Fri, Dec 4, 2009 at 11:35 AM, John Armstrong  wrote:
> The button itself lives in my ButtonBar class and the buttons
> themselves are extensions of AjaxFallbackButtons
>
> public class AjaxWizardButtonBar extends WizardButtonBar
>
> public abstract class AjaxWizardButton extends AjaxFallbackButton
>
> The buttonbar class has an onSubmit method that knows when things are
> good or bad (confirmed in a non-AJAX context) but when I run as AJAX
> enabled (enabling javascript) onSubmit never fires.
>
> John-
>
>
> On Fri, Dec 4, 2009 at 9:00 AM, Igor Vaynberg  wrote:
>> where is the code of the ajax button that submits the step?
>>
>> -igor
>>
>> On Fri, Dec 4, 2009 at 7:08 AM, John Armstrong  wrote:
>>> Still working on this darn sign-up form in my spare time. I currently
>>> can not get feedback to show up. If I disable javascript it shows up
>>> but using ajax it does not.
>>>
>>> In my WizardStep I have the code to add the feedback panel to the
>>> target as a placeholder. (confirmed, its in the DOM hidden). Adding
>>> feedback panel to a RadioGroup:
>>>
>>> ===
>>> private final class SelectPlan extends WizardStep implements
>>> IDynamicWizardStep {
>>>
>>> group.setRequired(true);
>>> final FeedbackPanel feedback = new FeedbackPanel("feedback");
>>> feedback.setOutputMarkupId(true);
>>> feedback.setOutputMarkupPlaceholderTag(true);
>>> if(target != null){
>>>    target.addComponent(feedback);
>>> }
>>> group.add(feedback);
>>> ===
>>>
>>> But on submit I still get this in my dev log
>>> WARN  - WebSession                 - Component-targetted feedback
>>> message was left unrendered. This could be because you are missing a
>>> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
>>> 'planselection' is required.", reporter = planselection, level =
>>> ERROR]
>>>
>>> What simple thing am I missing?
>>>
>>> John-
>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread John Armstrong
The button itself lives in my ButtonBar class and the buttons
themselves are extensions of AjaxFallbackButtons

public class AjaxWizardButtonBar extends WizardButtonBar

public abstract class AjaxWizardButton extends AjaxFallbackButton

The buttonbar class has an onSubmit method that knows when things are
good or bad (confirmed in a non-AJAX context) but when I run as AJAX
enabled (enabling javascript) onSubmit never fires.

John-


On Fri, Dec 4, 2009 at 9:00 AM, Igor Vaynberg  wrote:
> where is the code of the ajax button that submits the step?
>
> -igor
>
> On Fri, Dec 4, 2009 at 7:08 AM, John Armstrong  wrote:
>> Still working on this darn sign-up form in my spare time. I currently
>> can not get feedback to show up. If I disable javascript it shows up
>> but using ajax it does not.
>>
>> In my WizardStep I have the code to add the feedback panel to the
>> target as a placeholder. (confirmed, its in the DOM hidden). Adding
>> feedback panel to a RadioGroup:
>>
>> ===
>> private final class SelectPlan extends WizardStep implements
>> IDynamicWizardStep {
>>
>> group.setRequired(true);
>> final FeedbackPanel feedback = new FeedbackPanel("feedback");
>> feedback.setOutputMarkupId(true);
>> feedback.setOutputMarkupPlaceholderTag(true);
>> if(target != null){
>>    target.addComponent(feedback);
>> }
>> group.add(feedback);
>> ===
>>
>> But on submit I still get this in my dev log
>> WARN  - WebSession                 - Component-targetted feedback
>> message was left unrendered. This could be because you are missing a
>> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
>> 'planselection' is required.", reporter = planselection, level =
>> ERROR]
>>
>> What simple thing am I missing?
>>
>> John-
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread Igor Vaynberg
where is the code of the ajax button that submits the step?

-igor

On Fri, Dec 4, 2009 at 7:08 AM, John Armstrong  wrote:
> Still working on this darn sign-up form in my spare time. I currently
> can not get feedback to show up. If I disable javascript it shows up
> but using ajax it does not.
>
> In my WizardStep I have the code to add the feedback panel to the
> target as a placeholder. (confirmed, its in the DOM hidden). Adding
> feedback panel to a RadioGroup:
>
> ===
> private final class SelectPlan extends WizardStep implements
> IDynamicWizardStep {
>
> group.setRequired(true);
> final FeedbackPanel feedback = new FeedbackPanel("feedback");
> feedback.setOutputMarkupId(true);
> feedback.setOutputMarkupPlaceholderTag(true);
> if(target != null){
>    target.addComponent(feedback);
> }
> group.add(feedback);
> ===
>
> But on submit I still get this in my dev log
> WARN  - WebSession                 - Component-targetted feedback
> message was left unrendered. This could be because you are missing a
> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
> 'planselection' is required.", reporter = planselection, level =
> ERROR]
>
> What simple thing am I missing?
>
> John-
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread Martin Makundi
Yeah..but is the feedback message invoked before adding the feedback
into the target?

**
Martin

2009/12/4 John Armstrong :
> When I click next in the wizard and have not selected an item from the
> RadioGroup.
>
> J
>
> On Fri, Dec 4, 2009 at 7:26 AM, Martin Makundi
>  wrote:
>> When does the error occur?
>>
>> **
>> Martin
>>
>> 2009/12/4 John Armstrong :
>>> Still working on this darn sign-up form in my spare time. I currently
>>> can not get feedback to show up. If I disable javascript it shows up
>>> but using ajax it does not.
>>>
>>> In my WizardStep I have the code to add the feedback panel to the
>>> target as a placeholder. (confirmed, its in the DOM hidden). Adding
>>> feedback panel to a RadioGroup:
>>>
>>> ===
>>> private final class SelectPlan extends WizardStep implements
>>> IDynamicWizardStep {
>>>
>>> group.setRequired(true);
>>> final FeedbackPanel feedback = new FeedbackPanel("feedback");
>>> feedback.setOutputMarkupId(true);
>>> feedback.setOutputMarkupPlaceholderTag(true);
>>> if(target != null){
>>>    target.addComponent(feedback);
>>> }
>>> group.add(feedback);
>>> ===
>>>
>>> But on submit I still get this in my dev log
>>> WARN  - WebSession                 - Component-targetted feedback
>>> message was left unrendered. This could be because you are missing a
>>> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
>>> 'planselection' is required.", reporter = planselection, level =
>>> ERROR]
>>>
>>> What simple thing am I missing?
>>>
>>> John-
>>>
>>> -
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>
>>>
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread John Armstrong
When I click next in the wizard and have not selected an item from the
RadioGroup.

J

On Fri, Dec 4, 2009 at 7:26 AM, Martin Makundi
 wrote:
> When does the error occur?
>
> **
> Martin
>
> 2009/12/4 John Armstrong :
>> Still working on this darn sign-up form in my spare time. I currently
>> can not get feedback to show up. If I disable javascript it shows up
>> but using ajax it does not.
>>
>> In my WizardStep I have the code to add the feedback panel to the
>> target as a placeholder. (confirmed, its in the DOM hidden). Adding
>> feedback panel to a RadioGroup:
>>
>> ===
>> private final class SelectPlan extends WizardStep implements
>> IDynamicWizardStep {
>>
>> group.setRequired(true);
>> final FeedbackPanel feedback = new FeedbackPanel("feedback");
>> feedback.setOutputMarkupId(true);
>> feedback.setOutputMarkupPlaceholderTag(true);
>> if(target != null){
>>    target.addComponent(feedback);
>> }
>> group.add(feedback);
>> ===
>>
>> But on submit I still get this in my dev log
>> WARN  - WebSession                 - Component-targetted feedback
>> message was left unrendered. This could be because you are missing a
>> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
>> 'planselection' is required.", reporter = planselection, level =
>> ERROR]
>>
>> What simple thing am I missing?
>>
>> John-
>>
>> -
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Ajax Wizard and feedback

2009-12-04 Thread Martin Makundi
When does the error occur?

**
Martin

2009/12/4 John Armstrong :
> Still working on this darn sign-up form in my spare time. I currently
> can not get feedback to show up. If I disable javascript it shows up
> but using ajax it does not.
>
> In my WizardStep I have the code to add the feedback panel to the
> target as a placeholder. (confirmed, its in the DOM hidden). Adding
> feedback panel to a RadioGroup:
>
> ===
> private final class SelectPlan extends WizardStep implements
> IDynamicWizardStep {
>
> group.setRequired(true);
> final FeedbackPanel feedback = new FeedbackPanel("feedback");
> feedback.setOutputMarkupId(true);
> feedback.setOutputMarkupPlaceholderTag(true);
> if(target != null){
>    target.addComponent(feedback);
> }
> group.add(feedback);
> ===
>
> But on submit I still get this in my dev log
> WARN  - WebSession                 - Component-targetted feedback
> message was left unrendered. This could be because you are missing a
> FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
> 'planselection' is required.", reporter = planselection, level =
> ERROR]
>
> What simple thing am I missing?
>
> John-
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Ajax Wizard and feedback

2009-12-04 Thread John Armstrong
Still working on this darn sign-up form in my spare time. I currently
can not get feedback to show up. If I disable javascript it shows up
but using ajax it does not.

In my WizardStep I have the code to add the feedback panel to the
target as a placeholder. (confirmed, its in the DOM hidden). Adding
feedback panel to a RadioGroup:

===
private final class SelectPlan extends WizardStep implements
IDynamicWizardStep {

group.setRequired(true);
final FeedbackPanel feedback = new FeedbackPanel("feedback");
feedback.setOutputMarkupId(true);
feedback.setOutputMarkupPlaceholderTag(true);
if(target != null){
target.addComponent(feedback);
}
group.add(feedback);
===

But on submit I still get this in my dev log
WARN  - WebSession - Component-targetted feedback
message was left unrendered. This could be because you are missing a
FeedbackPanel on the page.  Message: [FeedbackMessage message = "Field
'planselection' is required.", reporter = planselection, level =
ERROR]

What simple thing am I missing?

John-

-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org