Re: ModalWindow accessibility - DIV placeholder not used
On Mon, Mar 26, 2012 at 5:15 PM, lukuperman wrote: > Done. Made the requested updates to the ticket. > > Lucas > > PD: do you think i should create another ticket for the related post I > mentioned above? It is similar change - add it to this ticket. > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4506115.html > Sent from the Users forum mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow accessibility - DIV placeholder not used
Done. Made the requested updates to the ticket. Lucas PD: do you think i should create another ticket for the related post I mentioned above? -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4506115.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow accessibility - DIV placeholder not used
Thanks! I already commented there ... Just paste the old and the new (the way it how it should be) html as a comment. On Mon, Mar 26, 2012 at 4:16 PM, lukuperman wrote: > Hi Martin, ticket 4472 created > (https://issues.apache.org/jira/browse/WICKET-4472) > > But since I'm new to OSS contributions, I didn't attach a patch. Due to the > low complexity of the change I don't think my patch is a blocker for you? > I'll start setting up my env, to be ready to deliver patches in future > tickets > > Regards > Lucas > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4505952.html > Sent from the Users forum mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow accessibility - DIV placeholder not used
Hi Martin, ticket 4472 created (https://issues.apache.org/jira/browse/WICKET-4472) But since I'm new to OSS contributions, I didn't attach a patch. Due to the low complexity of the change I don't think my patch is a blocker for you? I'll start setting up my env, to be ready to deliver patches in future tickets Regards Lucas -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4505952.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow accessibility - DIV placeholder not used
Hi Lucas, On Mon, Mar 26, 2012 at 2:38 PM, lukuperman wrote: > Hi Martin, I took a look at the post you mentioned, but in that patch the div > node is still being appended to the document.body node, resulting in the > behavior i'm seeing. However I have to admit that appending the new div node > to the placeholder is just a nice to have. A more appropriate solution for > making the modal window more accessible would be the outer div element to > have a role='dialog' attribute along with an aria-labelledBy=' element id>' attribute, like showed below: > > line 1170 of modal.js: > > " id=\""+idWindow+"\" role=\"dialog\" > aria-labelledBy=\""+idCaptionText+""\" > style=\"top: 10px; left: 10px; width: 100px;\"> > > This will appropriately alert the screen readers when the modal is shown. > Following with accessibility findings, i also posted > http://apache-wicket.1842946.n4.nabble.com/adding-associated-text-to-the-close-anchor-on-modal-windows-tp4504732p4504732.html Please create a ticket in Jira. 1.4.x wont be developed any more but we can add these improvements in 1.5.x and 6.x branches. > > Regards > Lucas > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4505633.html > Sent from the Users forum mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow accessibility - DIV placeholder not used
Hi Martin, I took a look at the post you mentioned, but in that patch the div node is still being appended to the document.body node, resulting in the behavior i'm seeing. However I have to admit that appending the new div node to the placeholder is just a nice to have. A more appropriate solution for making the modal window more accessible would be the outer div element to have a role='dialog' attribute along with an aria-labelledBy='' attribute, like showed below: line 1170 of modal.js: " This will appropriately alert the screen readers when the modal is shown. Following with accessibility findings, i also posted http://apache-wicket.1842946.n4.nabble.com/adding-associated-text-to-the-close-anchor-on-modal-windows-tp4504732p4504732.html Regards Lucas -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4505633.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ModalWindow accessibility - DIV placeholder not used
Hi Lucas, This is how ModalWindow currently works. There is a ticket (https://issues.apache.org/jira/browse/WICKET-3404) that will make some changes in the way its html is generated but I'm not sure whether these changes will help you anyhow. I'm not an expert in ARIA at all so maybe you can help us making Wicket components ARIA enabled by default. We can start with ModalWindow component - explain what should be done, what attributes should be added, and on which HTML element exactly. On Sat, Mar 24, 2012 at 8:44 PM, lukuperman wrote: > Hello, I inherited an application that uses Apache Wicket 1.4.15. Everything > works fine, but because of accessibility standards I have to address some > findings we received from DQA team, which includes missing wai-aria > attributes around to the modal windows. However I noticed the DIV > placeholder I define in the markup is not where the modalwindow code ends, > but rather a new DIV element is created dynamically at the end of the page's > html. This prevents me from enclosing the modal window's DIV element. I > would have expected the placeholder to be the place where the modalwindow > code will reside. Am I getting it wrong? Either way, can anyone suggest me > how can I enclose a modal window's DIV element? > > Thank you! > Regards. > > PS: I do not include source code/error cause im not receiving any. Im just > wondering about render behavior. Also, I don't think its a code problem > cause the official modal window example at > http://www.wicket-library.com/wicket-examples/ajax/modal-window?8 behaves > the same way. > > Lucas > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4501891.html > Sent from the Users forum mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
ModalWindow accessibility - DIV placeholder not used
Hello, I inherited an application that uses Apache Wicket 1.4.15. Everything works fine, but because of accessibility standards I have to address some findings we received from DQA team, which includes missing wai-aria attributes around to the modal windows. However I noticed the DIV placeholder I define in the markup is not where the modalwindow code ends, but rather a new DIV element is created dynamically at the end of the page's html. This prevents me from enclosing the modal window's DIV element. I would have expected the placeholder to be the place where the modalwindow code will reside. Am I getting it wrong? Either way, can anyone suggest me how can I enclose a modal window's DIV element? Thank you! Regards. PS: I do not include source code/error cause im not receiving any. Im just wondering about render behavior. Also, I don't think its a code problem cause the official modal window example at http://www.wicket-library.com/wicket-examples/ajax/modal-window?8 behaves the same way. Lucas -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/ModalWindow-accessibility-DIV-placeholder-not-used-tp4501891p4501891.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
