[PATCH] Fix spin_unlock order in utrace_stop

[Ananth N Mavinakayanahalli]

From: Ananth N Mavinakayanahalli [EMAIL PROTECTED]

utrace_stop() seems to get the spin_unlock sequence inverted in one of the
unlikely branches. Fix it.

Signed-off-by: Ananth N Mavinakayanahalli [EMAIL PROTECTED]
---
 kernel/utrace.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: utrace-2sep/kernel/utrace.c
===
--- utrace-2sep.orig/kernel/utrace.c
+++ utrace-2sep/kernel/utrace.c
@@ -482,8 +482,8 @@ static bool utrace_stop(struct task_stru
spin_lock_irq(task-sighand-siglock);
 
if (unlikely(sigismember(task-pending.signal, SIGKILL))) {
-   spin_unlock(utrace-lock);
spin_unlock_irq(task-sighand-siglock);
+   spin_unlock(utrace-lock);
return true;
}
 

Re: [PATCH] Fix spin_unlock order in utrace_stop

[Roland McGrath]

Thanks!  I don't think that ever hurts anything, but it's definitely right
to fix it.  I've put the change in and updated the patches.


Thanks,
Roland