Re: [PATCH 6/7] implement utrace-ptrace

2009-12-21 Thread Ananth N Mavinakayanahalli
On Mon, Dec 21, 2009 at 07:18:37PM +0530, Ananth N Mavinakayanahalli wrote:
 On Fri, Dec 18, 2009 at 02:11:40AM +0100, Oleg Nesterov wrote:
  The patch adds the new file, kernel/ptrace-utrace.c, which contains
  the new implementation of ptrace over utrace.
  
  This file is not compiled until we have CONFIG_UTRACE option, will be
  added by the next utrace core patch.
  
  It's supposed to be an invisible implementation change, nothing should
  change to userland when CONFIG_UTRACE is enabled.
  
  Signed-off-by: Roland McGrath rol...@redhat.com
  Signed-off-by: Oleg Nesterov o...@redhat.com
  ---
 
 Oleg,
 
 ptrace/utrace performs better with the ptrace-tests [1] testsuite (1 failure
 vs. 3 with vanilla ptrace [1]). The gdb testsuite also has no
 regressions. In fact, the results on the gdb testsuite are identical.

Forgot to mention the tests were on powerpc.



Re: [PATCH 6/7] implement utrace-ptrace

2009-12-21 Thread Ananth N Mavinakayanahalli
On Fri, Dec 18, 2009 at 02:11:40AM +0100, Oleg Nesterov wrote:
 The patch adds the new file, kernel/ptrace-utrace.c, which contains
 the new implementation of ptrace over utrace.
 
 This file is not compiled until we have CONFIG_UTRACE option, will be
 added by the next utrace core patch.
 
 It's supposed to be an invisible implementation change, nothing should
 change to userland when CONFIG_UTRACE is enabled.
 
 Signed-off-by: Roland McGrath rol...@redhat.com
 Signed-off-by: Oleg Nesterov o...@redhat.com
 ---

Oleg,

ptrace/utrace performs better with the ptrace-tests [1] testsuite (1 failure
vs. 3 with vanilla ptrace [1]). The gdb testsuite also has no
regressions. In fact, the results on the gdb testsuite are identical.

Ananth

[1] http://sourceware.org/systemtap/wiki/utrace/tests
[2] detach-stopped and stopped-attach-transparency are the additional
failures. syscall-reset fails in both cases.