Re: Two test cases

2008-12-12 Thread Denys Vlasenko 
On Thu, 2008-12-11 at 12:10 -0500, Elena Zannoni wrote:
 Could you please give Wenji credit in the changelog.

Of course.

I just added this testcase under the name step-simple,
it carries the following banner:

/* Simple test whether PTRACE_SINGLESTEP stops at all.

   Based on testcase by Wenji Huang wenji.huang AT oracle.com

   This software is provided 'as-is', without any express or implied
   warranty.  In no event will the authors be held liable for any damages
   arising from the use of this software.

   Permission is granted to anyone to use this software for any purpose,
   including commercial applications, and to alter it and redistribute it
   freely.
*/

If you want it changed, plase let me know.


 Also, is there a way he could start doing checkins too?
 Of course after approval.

I guess this is a question to Roland?
--
vda

Re: Two test cases

2008-12-11 Thread Elena Zannoni 




Denys Vlasenko wrote:

  On Wed, 2008-12-10 at 16:28 -0800, Roland McGrath wrote:
  
  
You had some wacky whitespace in the posted copy of the file.

  
  
Wonders of KDE's konsole cutpaste.
[not that Gnome works better...]



  


Could you please give Wenji credit in the changelog.
Also, is there a way he could start doing checkins too?
Of course after approval.

thanks
elena

-- 
Elena Zannoni, Oracle
Senior Engineering Manager, Tools/Languages - Linux Engineering
Blog: http://blogs.oracle.com/ezannoni
Email: elena.zann...@oracle.com

Re: Two test cases

2008-12-10 Thread Roland McGrath 
The current patch has regressions on block-step, step-jump-cont,
step-jump-cont-strict, and step-to-breakpoint.  Do your tests cover
anything new that is not already tested by one or more of those?


Thanks,
Roland

Re: Two test cases

2008-12-04 Thread Roland McGrath 
Thanks for the report, Wenji.  Please work with Denys to make sure these
problems are represented in the ptrace-tests suite and update the
utrace/tests wiki page.  Note the current code has some existing
regressions in ptrace-tests.  It's possible what your tests check is
already being checked by something in the suite.  Having related similar
tests or redundancies is fine, but it's most helpful if every test in the
suite is as concise as it can be, to help focus the bug hunting.


Thanks,
Roland