[v8-dev] Re: Use full include paths everywhere (issue 304153016)
On 2014/06/02 17:24:56, tfarina wrote: What was the technical reason for doing this? Could you write it in the CL description? Is this something skia could be doing in future? dunno about skia... updated the description https://codereview.chromium.org/304153016/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Use full include paths everywhere (issue 304153016)
Committed patchset #1 manually as r21625 (presubmit successful). https://codereview.chromium.org/304153016/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Use full include paths everywhere (issue 304153016)
Now vim gf keybinding will work. I'm very happy to see that you guys made this change. :) Thanks. https://codereview.chromium.org/304153016/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Use full include paths everywhere (issue 304153016)
LGTM. Haven't reviewed everything, just a few samples. I still think it would be nice not to bloat include file paths with needless src/ prefixes; but if this approach represents the majority vote, then that's fine with me. In some cases this disturbs previously-intact alphabetical sorting of includes. Any chance you could fix that? :-) https://codereview.chromium.org/304153016/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-dev] Re: Use full include paths everywhere (issue 304153016)
What was the technical reason for doing this? Could you write it in the CL description? Is this something skia could be doing in future? https://codereview.chromium.org/304153016/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
