Re: [v8-users] Interested in helping develop
I would say that it would take almost the same exact change to optimize that. Where is the code style documentation for V8 -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [v8-users] Interested in helping develop
On Sat, Jun 14, 2014 at 11:45 AM, Isiah Meadows wrote: > Actually, a fairly similar hack appears to already be in place, and likely > more efficient as well. > Hmmm, unless I misunderstand things, we are less efficient in StringStartsWith: Using '%StringIndexOf(s, ss, start) === start' is quite bad when the string we're searching in is huge and doesn't start with the prefix. It's just like testing if a container is empty by counting all its elements and comparing this to zero, which is a bad idea, too. StringEndsWith can be improved, too. @Michael? :-) -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [v8-users] Interested in helping develop
Actually, a fairly similar hack appears to already be in place, and likely more efficient as well. -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [v8-users] Interested in helping develop
Hey Isiah, I recommend you check out the code. Parts of V8 are written in JavaScript, indeed — take a look at src/*.js for some examples. Here’s how you can submit a patch for the optimization you proposed: https://github.com/v8/v8/wiki/Proposing-a-Patch#how-to-contribute-to-the-v8-project Regards, Mathias -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-users] Interested in helping develop
Accidentally hit the "post" button... I also came up with an optimization of the algorithm for String.prototype.startsWith() that basically, after the check that the search string is longer than the instance string plus the offset, it is simpler and likely quicker to compare it to the equal length substring than to compare each character, starting at the offset, unless the check is coded in C or possibly C++. -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[v8-users] Interested in helping develop
I have some knowledge of JavaScript, and I was wondering what I could help with in the V8 project. I have no professional experience, but I'm going to start college this fall towards a bachelor's in CS. It would definitely help me in getting experience for later on. Another side question is how much of V8's standard JavaScript library is actually implemented in JavaScript? Obvious ones that could be would be Array.prototype.forEach()/every()/etc. as a `for (var i of ...)` -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
