Re: [vbox-dev] Removing suid root bit from VBoxDRMClient

2020-06-08 Thread Frank Batschulat 
Thanks Hans, but right now we have a higher priority problem with fedora  
32,
that is we cannot get our vboxsf kernel module loaded anymore when we  
install
our GAs because the Linux vboxsf kernel module is sticking and the only  
one getting loaded
even though the Fedora specific guest additions you mentioned below have  
been uninstalled.


Also the Linux kernel vboxsf kernel module is incompatible with
our userland commands, our userland cannot talk to your vboxsf kernel  
module anymore.


investigating and fixing these beauty currently has a higher priority for  
us.


On Mon, 08 Jun 2020 17:46:58 +0200, Hans de Goede   
wrote:



Hi All,

While looking into upgrading the Fedora virtualbox-guest-additions  
packages to 6.0.10
I noticed that the  "VBoxClient --vmsvga-x11" call in VBoxClient-all has  
been replaced
with "VBoxClient --vmsvga" and that that one will either behave as the  
old --vmsvga-x11
version (when running under a X11 session) or it will start  
/usr/bin/VBoxDRMClient.


I added /usr/bin/VBoxDRMClient to the Fedora packages, but after that  
resizing of
a GNOME3 as Wayland-compositor session inside the guest still did not  
work.


The issue seems to be that /usr/bin/VBoxDRMClient needs more rights, I  
guess that

the upstream version of the guest-additions installs it suid root ?

That is not necessary and since Fedora ships virtualbox-guest-additions  
as part of
the default workstation install we would like to avoid adding another  
suid root binary

to the default install.

Instead I've written a udev rule + systemd service to replace the  
"VBoxClient --vmsvga"
call inside VBoxClient-all. These config files will start  
/usr/bin/VBoxDRMClient
when running inside a VBox VM with VMSVGA graphics. Note this will now  
run independent
of the type of session (X11 or Wayland) running inside the VM. This  
means that X11
sessions now also use VBoxDRMClient rather then VBoxClient --vmsvga-x11  
for resizing.


This works fine and if upstream adopts this, then the VBoxClient  
--vmsvga-x11

can be dropped.

The udev rule and systemd file can be found here. Feel free to use these  
under the

MIT license:

https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/VirtualBox-60-vboxguest.rules
https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/vboxclient.service

Regards,

Hans

___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev



--
frankB

Oracle Virtualbox Development
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] [ PATCH] Fix crash on startup under Wayland

2020-06-08 Thread Frank Batschulat 

This is fixed in Trunk and the new released Virtualbox version 6.1.10

On Mon, 08 Jun 2020 17:17:27 +0200, Hans de Goede   
wrote:



Hi,

On 6/8/20 5:11 PM, Sérgio Basto wrote:

Hi,
 On Mon, 2020-06-08 at 10:50 +0200, Frank Batschulat wrote:

This has been fixed in the new release 6.1.10

 Can you please show me where is the code in SVN ?
 Unfortunately seems that svn source code is not updated for 2 months (
https://www.virtualbox.org/browser/vbox/ ) so it is more difficult to
follow the modifications .


There is a new RTEnvSet call in this bit:

#ifdef VBOX_WS_X11
 /* Make sure multi-threaded environment is safe: */
 if (!MakeSureMultiThreadingIsSafe())
 break;
 /* Force using Qt platform module 'xcb', we have X11 specific  
code: */

 RTEnvSet("QT_QPA_PLATFORM", "xcb");
#endif /* VBOX_WS_X11 */

of src/VBox/Frontends/VirtualBox/src/main.cpp

Regards,

Hans




On Wed, 20 May 2020 12:47:47 +0200, Frank Batschulat
 wrote:


Testbuilds with the fix can be downloaded now:

for Trunk:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.97-138092-Linux_amd64.run

for 6.1.X:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.9-138068-Linux_amd64.run

or directly from: https://www.virtualbox.org/wiki/Testbuilds
for Trunk any Linux 64-bit .run installer with build >= r138057 and
for
6.1.X any build >= r138068

On Thu, 14 May 2020 14:43:01 +0200, Frank Batschulat
 wrote:


Hans, I have filed the following bug to track this:

[Oracle VM VirtualBox] #19583: GUI crashes when using Qt on
Xwayland
sessions
https://www.virtualbox.org/ticket/19583

the possible fix for this is still being discussed internally.

On Tue, 07 Apr 2020 14:00:47 +0200, Hans de Goede <
hdego...@redhat.com>
wrote:


Hi,

I noticed that with a default Fedora 32 workstation install
(default
GNOME3 on
Wayland session) VirtualBox crashes immediately at startup.
The
problem is that
QT5 now defaults to the Wayland backend and VirtualBox assumes
the X11
backend
is used and makes a bunch of unchecked X11 calls which cause
NULL
pointer derefs.

The attached patch is a simple fix which fixes this by setting
the QT
backend
back to X11.

As usual, the patch is released under the MIT license.

Regards,

Hans








--
frankB

Oracle Virtualbox Development
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] [ PATCH] Fix crash on startup under Wayland

2020-06-08 Thread Frank Batschulat 

ah sorry, wrong response, you can find the fix in the bug itself please

https://www.virtualbox.org/ticket/19583#comment:3

On Mon, 08 Jun 2020 17:17:27 +0200, Hans de Goede   
wrote:



Hi,

On 6/8/20 5:11 PM, Sérgio Basto wrote:

Hi,
 On Mon, 2020-06-08 at 10:50 +0200, Frank Batschulat wrote:

This has been fixed in the new release 6.1.10

 Can you please show me where is the code in SVN ?
 Unfortunately seems that svn source code is not updated for 2 months (
https://www.virtualbox.org/browser/vbox/ ) so it is more difficult to
follow the modifications .


There is a new RTEnvSet call in this bit:

#ifdef VBOX_WS_X11
 /* Make sure multi-threaded environment is safe: */
 if (!MakeSureMultiThreadingIsSafe())
 break;
 /* Force using Qt platform module 'xcb', we have X11 specific  
code: */

 RTEnvSet("QT_QPA_PLATFORM", "xcb");
#endif /* VBOX_WS_X11 */

of src/VBox/Frontends/VirtualBox/src/main.cpp

Regards,

Hans




On Wed, 20 May 2020 12:47:47 +0200, Frank Batschulat
 wrote:


Testbuilds with the fix can be downloaded now:

for Trunk:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.97-138092-Linux_amd64.run

for 6.1.X:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.9-138068-Linux_amd64.run

or directly from: https://www.virtualbox.org/wiki/Testbuilds
for Trunk any Linux 64-bit .run installer with build >= r138057 and
for
6.1.X any build >= r138068

On Thu, 14 May 2020 14:43:01 +0200, Frank Batschulat
 wrote:


Hans, I have filed the following bug to track this:

[Oracle VM VirtualBox] #19583: GUI crashes when using Qt on
Xwayland
sessions
https://www.virtualbox.org/ticket/19583

the possible fix for this is still being discussed internally.

On Tue, 07 Apr 2020 14:00:47 +0200, Hans de Goede <
hdego...@redhat.com>
wrote:


Hi,

I noticed that with a default Fedora 32 workstation install
(default
GNOME3 on
Wayland session) VirtualBox crashes immediately at startup.
The
problem is that
QT5 now defaults to the Wayland backend and VirtualBox assumes
the X11
backend
is used and makes a bunch of unchecked X11 calls which cause
NULL
pointer derefs.

The attached patch is a simple fix which fixes this by setting
the QT
backend
back to X11.

As usual, the patch is released under the MIT license.

Regards,

Hans








--
frankB

Oracle Virtualbox Development
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

[vbox-dev] Removing suid root bit from VBoxDRMClient

2020-06-08 Thread Support Team 
Noted.



On Mon, Jun 08 2020, at 03:46 PM, Hans de Goede 

Hi All, While looking into upgrading the Fedora virtualbox-guest-additions
packages to 6.0.10 I noticed that the "VBoxClient --vmsvga-x11" call in
VBoxClient-all has been replaced with "VBoxClient --vmsvga" and that that
one will either behave as the old --vmsvga-x11 version (when running under
a X11 session) or it will start /usr/bin/VBoxDRMClient. I added
/usr/bin/VBoxDRMClient to the Fedora packages, but after that resizing of a
GNOME3 as Wayland-compositor session inside the guest still did not work.
The issue seems to be that /usr/bin/VBoxDRMClient needs more rights, I
guess that the upstream version of the guest-additions installs it suid
root ? That is not necessary and since Fedora ships
virtualbox-guest-additions as part of the default workstation install we
would like to avoid adding another suid root binary to the default install.
Instead I've written a udev rule + systemd service to replace the
"VBoxClient --vmsvga" call inside VBoxClient-all. These config files will
start /usr/bin/VBoxDRMClient when running inside a VBox VM with VMSVGA
graphics. Note this will now run independent of the type of session (X11 or
Wayland) running inside the VM. This means that X11 sessions now also use
VBoxDRMClient rather then VBoxClient --vmsvga-x11 for resizing. This works
fine and if upstream adopts this, then the VBoxClient --vmsvga-x11 can be
dropped. The udev rule and systemd file can be found here. Feel free to use
these under the MIT license:
https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/VirtualBox-60-vboxguest.rules
https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/vboxclient.service
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

[vbox-dev] Removing suid root bit from VBoxDRMClient

2020-06-08 Thread Hans de Goede 

Hi All,

While looking into upgrading the Fedora virtualbox-guest-additions packages to 
6.0.10
I noticed that the  "VBoxClient --vmsvga-x11" call in VBoxClient-all has been 
replaced
with "VBoxClient --vmsvga" and that that one will either behave as the old 
--vmsvga-x11
version (when running under a X11 session) or it will start 
/usr/bin/VBoxDRMClient.

I added /usr/bin/VBoxDRMClient to the Fedora packages, but after that resizing 
of
a GNOME3 as Wayland-compositor session inside the guest still did not work.

The issue seems to be that /usr/bin/VBoxDRMClient needs more rights, I guess 
that
the upstream version of the guest-additions installs it suid root ?

That is not necessary and since Fedora ships virtualbox-guest-additions as part 
of
the default workstation install we would like to avoid adding another suid root 
binary
to the default install.

Instead I've written a udev rule + systemd service to replace the "VBoxClient 
--vmsvga"
call inside VBoxClient-all. These config files will start /usr/bin/VBoxDRMClient
when running inside a VBox VM with VMSVGA graphics. Note this will now run 
independent
of the type of session (X11 or Wayland) running inside the VM. This means that 
X11
sessions now also use VBoxDRMClient rather then VBoxClient --vmsvga-x11 for 
resizing.

This works fine and if upstream adopts this, then the VBoxClient --vmsvga-x11
can be dropped.

The udev rule and systemd file can be found here. Feel free to use these under 
the
MIT license:

https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/VirtualBox-60-vboxguest.rules
https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/vboxclient.service

Regards,

Hans

___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

[vbox-dev] [PATCH][resend] Fix shortcuts like alt-tab not working under [X]wayland

2020-06-08 Thread Support Team 
Noted :)

Thank you!



On Mon, Jun 08 2020, at 03:18 PM, Hans de Goede 

Hi, Note this is a resend since my first submission was ignored. This patch
makes virtualbox work much better (things like alt+tab will work in the VM)
when run inside a Wayland session. Can we please get this merged? The
attached patch tackles a long-standing issue when running VirtualBox under
[X]wayland. By default keyboard-grabs are denied to X11 apps under
Xwayland, this causes e.g. alt-tab to not be send to the VM, but to go to
the host window-environment. The attached patch modifies VirtualBox to send
a special ClientMessage which lets mutter knows that VirtualBox works
properly with emulated grabs and that they should be allowed. As usual, the
patch is released under the MIT license.
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

[vbox-dev] [PATCH][resend] Fix shortcuts like alt-tab not working under [X]wayland

2020-06-08 Thread Hans de Goede 

Hi,

Note this is a resend since my first submission was ignored. This patch
makes virtualbox work much better (things like alt+tab will work in the VM)
when run inside a Wayland session. Can we please get this merged?

The attached patch tackles a long-standing issue when running VirtualBox
under [X]wayland. By default keyboard-grabs are denied to X11 apps under
Xwayland, this causes e.g. alt-tab to not be send to the VM, but to go
to the host window-environment.

The attached patch modifies VirtualBox to send a special ClientMessage
which lets mutter knows that VirtualBox works properly with emulated
grabs and that they should be allowed.

As usual, the patch is released under the MIT license.

Regards,

Hans

diff -up VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp~ VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
--- VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp~	2020-02-18 18:19:59.0 +0100
+++ VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp	2020-04-06 13:30:21.274027340 +0200
@@ -2203,6 +2204,17 @@ void UICommon::setWMClass(QWidget *pWidg
 XSetClassHint(QX11Info::display(), pWidget->window()->winId(), &windowClass);
 }
 
+/* static */
+void UICommon::setXwaylandMayGrabKeyboardFlag(QWidget *pWidget)
+{
+/* Tell the WM we are well behaved wrt Xwayland keyboard-grabs. This will
+ * make the WM turn our grab into a Wayland shortcut inhibition request,
+ * so that e.g. alt+tab will get send to the VM instead of moving the
+ * focus away from the VM. */
+XXSendClientMessage(QX11Info::display(), pWidget->window()->winId(),
+"_XWAYLAND_MAY_GRAB_KEYBOARD", 1);
+}
+
 #endif /* VBOX_WS_X11 */
 
 /* static */
diff -up VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h~ VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h
--- VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h~	2020-02-18 18:19:59.0 +0100
+++ VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h	2020-04-06 13:30:20.345012390 +0200
@@ -416,6 +416,8 @@ public:
 
 /** Assigns WM_CLASS property for passed @a pWidget. */
 static void setWMClass(QWidget *pWidget, const QString &strNameString, const QString &strClassString);
+/** Tell the WM the passed @a pWidget window is well behaved wrt XWayland keyboard-grabs. */
+static void setXwaylandMayGrabKeyboardFlag(QWidget *pWidget);
 #endif /* VBOX_WS_X11 */
 
 /** Assigns minimum @a pSpinBox to correspond to @a cCount digits. */
diff -up VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineWindow.cpp~ VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineWindow.cpp
--- VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineWindow.cpp~	2020-04-06 13:18:46.0 +0200
+++ VirtualBox-6.1.4/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineWindow.cpp	2020-04-06 13:25:52.235673962 +0200
@@ -135,6 +135,8 @@ void UIMachineWindow::prepare()
 strWindowName = QString("VirtualBox Machine UUID: %1").arg(uiCommon().managedVMUuid().toString());
 /* Assign WM_CLASS property: */
 UICommon::setWMClass(this, strWindowName, strWindowClass);
+/* Tell the WM we are well behaved wrt Xwayland keyboard-grabs: */
+UICommon::setXwaylandMayGrabKeyboardFlag(this);
 #endif
 }
 

___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] [ PATCH] Fix crash on startup under Wayland

2020-06-08 Thread Hans de Goede 

Hi,

On 6/8/20 5:11 PM, Sérgio Basto wrote:

Hi,

On Mon, 2020-06-08 at 10:50 +0200, Frank Batschulat wrote:

This has been fixed in the new release 6.1.10


Can you please show me where is the code in SVN ?

Unfortunately seems that svn source code is not updated for 2 months (
https://www.virtualbox.org/browser/vbox/ ) so it is more difficult to
follow the modifications .


There is a new RTEnvSet call in this bit:

#ifdef VBOX_WS_X11
/* Make sure multi-threaded environment is safe: */
if (!MakeSureMultiThreadingIsSafe())
break;
/* Force using Qt platform module 'xcb', we have X11 specific code: */
RTEnvSet("QT_QPA_PLATFORM", "xcb");
#endif /* VBOX_WS_X11 */

of src/VBox/Frontends/VirtualBox/src/main.cpp

Regards,

Hans




On Wed, 20 May 2020 12:47:47 +0200, Frank Batschulat
 wrote:


Testbuilds with the fix can be downloaded now:

for Trunk:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.97-138092-Linux_amd64.run

for 6.1.X:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.9-138068-Linux_amd64.run

or directly from: https://www.virtualbox.org/wiki/Testbuilds
for Trunk any Linux 64-bit .run installer with build >= r138057 and
for
6.1.X any build >= r138068

On Thu, 14 May 2020 14:43:01 +0200, Frank Batschulat
 wrote:


Hans, I have filed the following bug to track this:

[Oracle VM VirtualBox] #19583: GUI crashes when using Qt on
Xwayland
sessions
https://www.virtualbox.org/ticket/19583

the possible fix for this is still being discussed internally.

On Tue, 07 Apr 2020 14:00:47 +0200, Hans de Goede <
hdego...@redhat.com>
wrote:


Hi,

I noticed that with a default Fedora 32 workstation install
(default
GNOME3 on
Wayland session) VirtualBox crashes immediately at startup.
The
problem is that
QT5 now defaults to the Wayland backend and VirtualBox assumes
the X11
backend
is used and makes a bunch of unchecked X11 calls which cause
NULL
pointer derefs.

The attached patch is a simple fix which fixes this by setting
the QT
backend
back to X11.

As usual, the patch is released under the MIT license.

Regards,

Hans





___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] [ PATCH] Fix crash on startup under Wayland

2020-06-08 Thread Sérgio Basto 
Hi,

On Mon, 2020-06-08 at 10:50 +0200, Frank Batschulat wrote:
> This has been fixed in the new release 6.1.10

Can you please show me where is the code in SVN ? 

Unfortunately seems that svn source code is not updated for 2 months ( 
https://www.virtualbox.org/browser/vbox/ ) so it is more difficult to
follow the modifications .

Thank you

> On Wed, 20 May 2020 12:47:47 +0200, Frank Batschulat  
>  wrote:
> 
> > Testbuilds with the fix can be downloaded now:
> > 
> > for Trunk:
> > https://www.virtualbox.org/download/testcase/VirtualBox-6.1.97-138092-Linux_amd64.run
> > 
> > for 6.1.X:
> > https://www.virtualbox.org/download/testcase/VirtualBox-6.1.9-138068-Linux_amd64.run
> > 
> > or directly from: https://www.virtualbox.org/wiki/Testbuilds
> > for Trunk any Linux 64-bit .run installer with build >= r138057 and
> > for  
> > 6.1.X any build >= r138068
> > 
> > On Thu, 14 May 2020 14:43:01 +0200, Frank Batschulat  
> >  wrote:
> > 
> > > Hans, I have filed the following bug to track this:
> > > 
> > > [Oracle VM VirtualBox] #19583: GUI crashes when using Qt on
> > > Xwayland  
> > > sessions
> > > https://www.virtualbox.org/ticket/19583
> > > 
> > > the possible fix for this is still being discussed internally.
> > > 
> > > On Tue, 07 Apr 2020 14:00:47 +0200, Hans de Goede <
> > > hdego...@redhat.com>  
> > > wrote:
> > > 
> > > > Hi,
> > > > 
> > > > I noticed that with a default Fedora 32 workstation install
> > > > (default  
> > > > GNOME3 on
> > > > Wayland session) VirtualBox crashes immediately at startup.
> > > > The  
> > > > problem is that
> > > > QT5 now defaults to the Wayland backend and VirtualBox assumes
> > > > the X11  
> > > > backend
> > > > is used and makes a bunch of unchecked X11 calls which cause
> > > > NULL  
> > > > pointer derefs.
> > > > 
> > > > The attached patch is a simple fix which fixes this by setting
> > > > the QT  
> > > > backend
> > > > back to X11.
> > > > 
> > > > As usual, the patch is released under the MIT license.
> > > > 
> > > > Regards,
> > > > 
> > > > Hans
> 
> 
-- 
Sérgio M. B.

___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] Problem with kernel 5.8

2020-06-08 Thread Frank Batschulat 

Larry, thanks - this work will be tracked with:

Ticket #19644 (accepted defect)
Linux kernel version: 5.8 - we need changes
https://www.virtualbox.org/ticket/19644


On Fri, 05 Jun 2020 23:39:08 +0200, Larry Finger  
 wrote:


In a little over one week, Linus will release Kernel 5.8.0-rc1. Shortly  
thereafter, openSUSE Tumbleweed will start builds using that kernel.  
Unless I have patched our copy of the code for the VB kernel modules, my  
mailbox will be flooded with build failure messages.


Thus far, I have found two incompatibilities with the 5.8 APIs. The  
first was the removal of __get_vm_area(). This one can be trivially  
replaced with __get_vm_area_caller(), which has one additional argument  
that is always "__builtin_return_address(0)."


A second API change is more complicated, and above my understanding. In  
the associated patch entitled "mm: only allow page table mappings for  
built-in zsmalloc", symbols map_vm_area() and unmap_kernel_range() are  
no longer exported. The first of these are used in this snippet found in  
src/vboxdrv/r0drv/linux/alloc-r0drv-linux.c:


 if (iPage == cPages)
 {
 /*
  * Map the pages.
  *
  * Not entirely sure we really need to set nr_pages and pages  
here, but
  * they provide a very convenient place for storing something  
we need

  * in the free function, if nothing else...
  */
# if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
 struct page **papPagesIterator = papPages;
# endif
 pVmArea->nr_pages = cPages;
 pVmArea->pages= papPages;
 if (!map_vm_area(pVmArea, PAGE_KERNEL_EXEC,
# if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
  &papPagesIterator
# else
  papPages
# endif
  ))
 {
 PRTMEMLNXHDREX pHdrEx = (PRTMEMLNXHDREX)pVmArea->addr;
 pHdrEx->pVmArea = pVmArea;
 pHdrEx->pvDummy = NULL;
 return &pHdrEx->Hdr;
 }
 /* bail out */
# if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
 pVmArea->nr_pages = papPagesIterator - papPages;
# endif
 }

I think the code could use vm_map_ram() to map the papPages array  
directly, but I would appreciate any help the developers could provide.


Thanks,

Larry
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev



--
frankB

Oracle Virtualbox Development
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] [ PATCH] Fix crash on startup under Wayland

2020-06-08 Thread Frank Batschulat 

This has been fixed in the new release 6.1.10

On Wed, 20 May 2020 12:47:47 +0200, Frank Batschulat  
 wrote:



Testbuilds with the fix can be downloaded now:

for Trunk:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.97-138092-Linux_amd64.run

for 6.1.X:
https://www.virtualbox.org/download/testcase/VirtualBox-6.1.9-138068-Linux_amd64.run

or directly from: https://www.virtualbox.org/wiki/Testbuilds
for Trunk any Linux 64-bit .run installer with build >= r138057 and for  
6.1.X any build >= r138068


On Thu, 14 May 2020 14:43:01 +0200, Frank Batschulat  
 wrote:



Hans, I have filed the following bug to track this:

[Oracle VM VirtualBox] #19583: GUI crashes when using Qt on Xwayland  
sessions

https://www.virtualbox.org/ticket/19583

the possible fix for this is still being discussed internally.

On Tue, 07 Apr 2020 14:00:47 +0200, Hans de Goede   
wrote:



Hi,

I noticed that with a default Fedora 32 workstation install (default  
GNOME3 on
Wayland session) VirtualBox crashes immediately at startup. The  
problem is that
QT5 now defaults to the Wayland backend and VirtualBox assumes the X11  
backend
is used and makes a bunch of unchecked X11 calls which cause NULL  
pointer derefs.


The attached patch is a simple fix which fixes this by setting the QT  
backend

back to X11.

As usual, the patch is released under the MIT license.

Regards,

Hans









--
frankB

Oracle Virtualbox Development
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev