Re: [vchkpw] vget_assign returns only real domain

2003-12-04 Thread Jonas Pasche
Hi Tom,

 The tricky part is ezmlm (and always has been).  If you create a 
 mailing list, it will typically only work for the domain you created it 
 in, and none of the aliases.

Exactly; that's why I wanted the user to choose in which of his n
alias domains he wants to create the list instead of forcing him to use
his main domain - and the easiest way (from the user's perspective) is
to re-use the domain name from the login.

Anyway, even if my quick hack in vpopmail.c seems to work for non-MySQL
setups, I'll place a feature suggestion on the qmailadmin list.

Thanks for all your input,

Jonas




Re: [vchkpw] vget_assign returns only real domain

2003-12-02 Thread Michael Bowe

Jonas Pasche said:
 Is there any possibility to remove that functionality and let
 vget_assign return the same domain name it got from the user's input?

 Will other things break without this functionality?

From what I remember, it does need to be this way.

A particular example I can think of is when using the
MySQL backend, SQL queries are built using the domain
name returned by vget_assign, and unless the real domain
is used, the SQL is going to fail.

Michael.





Re: [vchkpw] vget_assign returns only real domain

2003-12-02 Thread X-Istence




Michael Bowe wrote:

  Jonas Pasche said:
  
  
Is there any possibility to remove that functionality and let
vget_assign return the same domain name it got from the user's input?

Will other things break without this functionality?

  
  
From what I remember, it does need to be this way.

A particular example I can think of is when using the
MySQL backend, SQL queries are built using the domain
name returned by vget_assign, and unless the real domain
is used, the SQL is going to fail.

Michael.


  


We should add another flag of some sort to vget_assign which is 0 by
default, but in programs like qmailadmin can be set to 1, to make it
return the domain the user logged in with, and not the "real" domain.
This would then no break anything, and only qmailadmin would he to be
rewritten.

X

Note: This is just an idea.




Re: [vchkpw] vget_assign returns only real domain

2003-12-02 Thread Jonas Pasche
Hi there,

 We should add another flag of some sort to vget_assign which is 0 by
 default, but in programs like qmailadmin can be set to 1, to make it
 return the domain the user logged in with, and not the real domain.
 This would then no break anything, and only qmailadmin would he to be
 rewritten.

This is an interesting idea. For now, as I don't use the SQL
functionality, this simple patch seems to work:


--- vpopmail-5.2.2.original/vpopmail.c  2003-12-03 03:36:57.0 +0100
+++ vpopmail-5.2.2/vpopmail.c   2003-12-03 02:56:24.0 +0100
@@ -1933,7 +1933,7 @@
 i = fread(tmpbuf,sizeof(char),dlen,fs);
  
 /* get the domain line */
-strcpy(domain, tmpbuf);
+/* strcpy(domain, tmpbuf); */
  
 /* get the uid */
 ptr = tmpbuf;


Again, I don't have a complete overview if this may break other things.
It will break SQL support for alias domains, thanks Michael for your
insightful comment. Anyway, it did quite some tests this night and found
no problems. After recompiling qmailadmin to link against the patched
vpopmail lib, qmailadmin works as expected, showing the domain name the
user used while logging in instead of the real domain.

Jonas




Re: [vchkpw] vget_assign returns only real domain

2003-12-02 Thread Tom Collins
On Tuesday, December 2, 2003, at 07:34  PM, X-Istence wrote:
We should add another flag of some sort to vget_assign which is 0 by 
default, but in programs like qmailadmin can be set to 1, to make it 
return the domain the user logged in with, and not the real domain. 
This would then no break anything, and only qmailadmin would he to be 
rewritten.
It would be better to change qmailadmin to keep and use the domain name 
entered, and pass a copy to vget_assign.

The tricky part is ezmlm (and always has been).  If you create a 
mailing list, it will typically only work for the domain you created it 
in, and none of the aliases.

--
Tom Collins  -  [EMAIL PROTECTED]
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/



Re: [vchkpw] vget_assign returns only real domain

2003-12-02 Thread X-Istence
Tom Collins wrote:

It would be better to change qmailadmin to keep and use the domain 
name entered, and pass a copy to vget_assign.

The tricky part is ezmlm (and always has been).  If you create a 
mailing list, it will typically only work for the domain you created 
it in, and none of the aliases. 


I guess this would be an option as well.

X