[vdsm] About code segment in vdsm/storage/image.py

2012-06-25 Thread Shu Ming

Hi,

I am reading the code of merge() function in image.py and get one 
question about the code.  I wonder why we should get the volume 
parameters from the parent of the destination volume if the parent is 
existing instead from the destination volume itself?


1101if dstParentUUID != sd.BLANK_UUID:
volParams = vols[dstParentUUID].getVolumeParams()
else:
 1105   volParams = dstVol.getVolumeParams()

--
Shu Ming shum...@linux.vnet.ibm.com
IBM China Systems and Technology Laboratory


___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel


Re: [vdsm] About code segment in vdsm/storage/image.py

2012-06-25 Thread Shu Ming

On 2012-6-25 15:21, Shu Ming wrote:

Hi,

I am reading the code of merge() function in image.py and get one 
question about the code.  I wonder why we should get the volume 
parameters from the parent of the destination volume if the parent is 
existing instead from the destination volume itself?


1101if dstParentUUID != sd.BLANK_UUID:
volParams = vols[dstParentUUID].getVolumeParams()
else:
 1105   volParams = dstVol.getVolumeParams()

In my understanding,  the volParams is different in internal volume 
merge and base volume merge(merging to a top most base without parent).  
For internal volume merge, the volParams comes from the parent of the 
destination volume.  While for base volume merge, the volParams comes 
from the destination volume.  Is it correct?


--
Shu Ming shum...@linux.vnet.ibm.com
IBM China Systems and Technology Laboratory


___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel