Change in vdsm[master]: vdsm: Load softdog if hardware watchdog is not available
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Load softdog if hardware watchdog is not available .. Patch Set 4: Code-Review+2 Thanks. -- To view, visit http://gerrit.ovirt.org/17814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17ca3dea7acd60b0ba5bb3634c06b656b41dde1d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Load softdog if hardware watchdog is not available
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Load softdog if hardware watchdog is not available .. vdsm: Load softdog if hardware watchdog is not available On Ubuntu softdog is not loaded automatically. When there is not hardware watchdog available, we have to load softdog to make wdmd and sanlock work properly. This patch detects /dev/watchdog during vdsmd startup and load softdog if /dev/watchdog does not exist. Change-Id: I17ca3dea7acd60b0ba5bb3634c06b656b41dde1d Signed-off-by: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Reviewed-on: http://gerrit.ovirt.org/17814 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/upstart/vdsmd.upstart.in M lib/vdsm/tool/load_needed_modules.py.in 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/17814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17ca3dea7acd60b0ba5bb3634c06b656b41dde1d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsProxy pass calls to undefined methods to API and return m...
Dan Kenigsberg has posted comments on this change. Change subject: vdsProxy pass calls to undefined methods to API and return msg/status .. Patch Set 4: (1 comment) File tests/functional/utils.py Line 81: Line 82: if hasattr(self.vdscli, attr): Line 83: def wrapper(*args, **kwargs): Line 84: result = getattr(self.vdscli, attr)(*args, **kwargs) Line 85: self.lastResult = result Sorry, I do not understand you answer. Why is lastResault useful? Line 86: return result['status']['code'], result['status']['message'] Line 87: return wrapper Line 88: Line 89: raise AttributeError(attr) -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d1e696a5280402725223ecc87646a75ba60061 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tests: Fixed resource manager stress test
Dan Kenigsberg has posted comments on this change. Change subject: Tests: Fixed resource manager stress test .. Patch Set 3: Code-Review-1 (3 comments) File tests/resourceManagerTests.py Line 643: resourceManager.LockType.shared] Line 644: Line 645: threads = [] Line 646: for i in range(procLimit): Line 647: t = threading.Thread(target=register) overindentation Line 648: try: Line 649: t.start() Line 650: except: Line 651: # Reached thread limit, bail out Line 646: for i in range(procLimit): Line 647: t = threading.Thread(target=register) Line 648: try: Line 649: t.start() Line 650: except: Let's be more specific, for Edu's sake. Line 651: # Reached thread limit, bail out Line 652: maxedOut = True Line 653: break Line 654: Line 657: Line 658: n = 0 Line 659: releaseThreads = [] Line 660: while n len(threads): Line 661: for i in reversed(range(len(queue))): I do not understand the test. Why is the order of I important? Only the last release thread gets release unknown? Line 662: f = None Line 663: if i 0: Line 664: f = releaseShared Line 665: else: -- To view, visit http://gerrit.ovirt.org/19252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba095724a251968c8d5b2767e6491825d79297e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 2: Thanks Dan. Mail sent. @Alon, when I do Ubuntu compatibility fix and packaging, I find Ubuntu specific knowledge is not very important, knowing how VDSM works is most important. Ubuntu packaging is easy to learn, they provide many templates, and one can start hacking after reading several pages of the tutorial. The tough problem is how to fit VDSM packaging code into Ubuntu packaging system, the prerequisite skill is that we know VDSM well enough. I think the same case can be applied to oVirt Engine. If someone is already an Engine developer, he can test it on Ubuntu easily, even write packaging scripts. If the case is reverse, someone knows Ubuntu well, but know nothing about oVirt Engine internals, he'd struggled to find the internal details of Engine. So for now I have no plan to introduce oVirt Engine to Ubuntu. Even we have not provided Ubuntu support yet, we can run oVirt Engine in Fedora VM on Ubuntu host, because Engine is a high level management entity. VDSM manages hosts directly, so it must be run on Ubuntu host directly. Once we have Ubuntu hosts, they are useless if we can not add them to Engine. That's why I think adding Ubuntu hosts to oVirt Engine should be done in the first place. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Let dummy interfaces destroied after cleaning up netw...
Mark Wu has uploaded a new change for review.
Change subject: tests: Let dummy interfaces destroied after cleaning up
networks.
..
tests: Let dummy interfaces destroied after cleaning up networks.
If dummy interfaces are destroied before cleaning up newtowrks, it
will fail to restore network with this error:
'Missing required nics for bonding device.'
Change-Id: I8dd6c75794244069b035676ea67641f8a3d3964f
Signed-off-by: Mark Wu wu...@linux.vnet.ibm.com
---
M tests/functional/dummy.py
M tests/functional/networkTests.py
M tests/functional/utils.py
3 files changed, 3 insertions(+), 58 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/19609/1
diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index f285cc4..74d8c94 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -21,6 +21,7 @@
from nose.plugins.skip import SkipTest
+from utils import restoreNetConfig
from vdsm.ipwrapper import linkAdd, linkDel, addrAdd, linkSet, IPRoute2Error
@@ -88,6 +89,7 @@
dummies = [create() for _ in range(num)]
yield dummies
except Exception:
+restoreNetConfig()
raise
finally:
for dummy in dummies:
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index beb5ae7..87ab8d0 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -28,7 +28,7 @@
import dummy
from dummy import dummyIf
-from utils import cleanupNet, restoreNetConfig, SUCCESS, VdsProxy, cleanupRules
+from utils import restoreNetConfig, SUCCESS, VdsProxy, cleanupRules
from vdsm.ipwrapper import (ruleAdd, ruleDel, routeAdd, routeDel, routeExists,
ruleExists, Route, Rule)
@@ -104,7 +104,6 @@
def setUp(self):
self.vdsm_net = VdsProxy()
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -139,7 +138,6 @@
self.vdsm_net.vlanExists(BONDING_NAME + '.' +
networks[vlan_net]['vlan']))
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -160,7 +158,6 @@
self.assertEqual(status, SUCCESS, msg)
self.assertFalse(self.vdsm_net.networkExists(NETWORK_NAME))
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -192,7 +189,6 @@
{BONDING_NAME: {'remove': True}}, {'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -211,7 +207,6 @@
self.assertEqual(status, SUCCESS, msg)
self.assertFalse(self.vdsm_net.networkExists(NETWORK_NAME))
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -229,7 +224,6 @@
self.assertEqual(status, SUCCESS, msg)
self.assertFalse(self.vdsm_net.networkExists(NETWORK_NAME))
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -244,14 +238,12 @@
bridged})
self.assertEqual(status, neterrors.ERR_BAD_BONDING, msg)
-@cleanupNet
def testFailWithInvalidBridgeName(self):
invalid_bridge_names = ('a' * 16, 'a b', 'a\tb', 'a.b', 'a:b')
for bridge_name in invalid_bridge_names:
status, msg = self.vdsm_net.addNetwork(bridge_name)
self.assertEqual(status, neterrors.ERR_BAD_BRIDGE, msg)
-@cleanupNet
def testFailWithInvalidIpConfig(self):
invalid_ip_configs = (dict(IPADDR='1.2.3.4'), dict(NETMASK='1.2.3.4'),
dict(GATEWAY='1.2.3.4'),
@@ -267,7 +259,6 @@
opts=ipconfig)
self.assertEqual(status, neterrors.ERR_BAD_ADDR, msg)
-@cleanupNet
@permutations([[True], [False]])
def testFailWithInvalidNic(self, bridged):
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
@@ -276,7 +267,6 @@
self.assertEqual(status, neterrors.ERR_BAD_NIC, msg)
-@cleanupNet
@permutations([[True], [False]])
def testFailWithInvalidParams(self, bridged):
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, VLAN_ID,
@@ -288,7 +278,6 @@
opts={'bridged': bridged})
self.assertEqual(status, neterrors.ERR_BAD_PARAMS, msg)
-@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@ValidateRunningAsRoot
@@ -319,7 +308,6 @@
self.vdsm_net.delNetwork(netVlan)
self.assertEquals(status, SUCCESS, msg)
-@cleanupNet
Change in vdsm[master]: tests: Let dummy interfaces destroied after cleaning up netw...
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Let dummy interfaces destroied after cleaning up networks. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4651/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4575/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd6c75794244069b035676ea67641f8a3d3964f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Let dummy interfaces destroied after cleaning up netw...
Mark Wu has posted comments on this change. Change subject: tests: Let dummy interfaces destroied after cleaning up networks. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd6c75794244069b035676ea67641f8a3d3964f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsProxy pass calls to undefined methods to API and return m...
Martin Polednik has posted comments on this change. Change subject: vdsProxy pass calls to undefined methods to API and return msg/status .. Patch Set 4: (1 comment) File tests/functional/utils.py Line 81: Line 82: if hasattr(self.vdscli, attr): Line 83: def wrapper(*args, **kwargs): Line 84: result = getattr(self.vdscli, attr)(*args, **kwargs) Line 85: self.lastResult = result few functions, such as getAllVmStats or getVdsStats are expected to return additional dict which is then used in tests - in order to do so, they are currently defined in vdsProxy causing API duplication lastResult allows us to get the result without duplicating the call here (the calls are currently unchaged as i'd rather do that in separate patch) current version: - define getAllVmStats in vdsProxy to return additional values - call getAllVmStats - use the returned data with this patch: - call getAllVmStats - get the needed data from lastResult Line 86: return result['status']['code'], result['status']['message'] Line 87: return wrapper Line 88: Line 89: raise AttributeError(attr) -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d1e696a5280402725223ecc87646a75ba60061 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: shared attribute backward compatibility
Dan Kenigsberg has posted comments on this change. Change subject: vm: shared attribute backward compatibility .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d377635b0687baccc69b203cb3fbe8dbf573169 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add task support
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add task support .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/10200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add task support
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add task support .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4654/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4578/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/10200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Let dummy interfaces destroied after cleaning up netw...
Dan Kenigsberg has posted comments on this change. Change subject: tests: Let dummy interfaces destroied after cleaning up networks. .. Patch Set 1: Would you explain the mode of failure? How exactly does restoreNetConfig fail if a dummy device is missing? I must admit that I am a bit unhappy with the replacement of the explicit @cleanupNet decorator with a side-effect of dummIf.. There must be a cleaner way to tie the two together (maybe just a name change?) -- To view, visit http://gerrit.ovirt.org/19609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd6c75794244069b035676ea67641f8a3d3964f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tests: Fixed resource manager stress test
Dan Kenigsberg has posted comments on this change. Change subject: Tests: Fixed resource manager stress test .. Patch Set 3: (1 comment) File tests/resourceManagerTests.py Line 658: n = 0 Line 659: releaseThreads = [] Line 660: while n len(threads): Line 661: for i in reversed(range(len(queue))): Line 662: f = None what is this asignment good for? Line 663: if i 0: Line 664: f = releaseShared Line 665: else: Line 666: f = releaseUnknown -- To view, visit http://gerrit.ovirt.org/19252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba095724a251968c8d5b2767e6491825d79297e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: Code-Review+1 Looks good to me, but should be kept out until we leave our current bugfix-only phase. -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Improve unified persistence's rollback in memory.
Mark Wu has abandoned this change. Change subject: netconf: Improve unified persistence's rollback in memory. .. Abandoned -- To view, visit http://gerrit.ovirt.org/19541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie0a7c7eb6091fa85029a1baebf10fc1ea6e22668 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modify ./vdsm/__init__.py for PEP8 compliance ./vdsm/__init_...
Dan Kenigsberg has abandoned this change. Change subject: Modify ./vdsm/__init__.py for PEP8 compliance ./vdsm/__init__.py .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifca40b37c8a4a01d30589e33d49016975ed0f53e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliy...@gmail.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modify before_vm_migrate_source.py for PEP8 compliance
Dan Kenigsberg has abandoned this change. Change subject: Modify before_vm_migrate_source.py for PEP8 compliance .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I33b157093350f0c96639836175d2b313fd684984 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao qiaoliy...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 clean vdsm/storage/securable.py
Dan Kenigsberg has abandoned this change. Change subject: pep8 clean vdsm/storage/securable.py .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie1c5b97b22ffc921e17e4cef2e79244d5ad190c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiaw...@linux.vnet.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Create AsyncProcessOperation
Dan Kenigsberg has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
Dan Kenigsberg has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 7: Code-Review-1 (1 comment) File vdsm/storage/multipath.py Line 112: supervdsm.getProxy().forceScsiScan() Line 113: Line 114: # Now let multipath daemon pick up new devices Line 115: Line 116: _runCmd(-r) ever tested? [] + -r is bound to fail. Line 117: Line 118: Line 119: def isEnabled(): Line 120: -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix problems with current implementation of forceIscsiRescan
Dan Kenigsberg has posted comments on this change. Change subject: Fix problems with current implementation of forceIscsiRescan .. Patch Set 8: Code-Review-1 (1 comment) Obsoleted by your current http://gerrit.ovirt.org/#/c/19256 I suppose? File vdsm/storage/fileUtils.py Line 22: NFS helper module Line 23: Line 24: import os Line 25: import types Line 26: import math imported in vain. Line 27: import pwd Line 28: import grp Line 29: import stat Line 30: from StringIO import StringIO -- To view, visit http://gerrit.ovirt.org/8172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e7173086ba15c7706206c5ee1473ed6d334f9e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Rami Vaknin rvaknin.redhat@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 10: Verified+1 small fix in virtTests (egd version isn't used anymore) -- verified through functional tests -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4655/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4579/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsProxy pass calls to undefined methods to API and return m...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsProxy pass calls to undefined methods to API and return msg/status .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4656/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4580/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d1e696a5280402725223ecc87646a75ba60061 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsProxy pass calls to undefined methods to API and return m...
Martin Polednik has posted comments on this change. Change subject: vdsProxy pass calls to undefined methods to API and return msg/status .. Patch Set 4: (1 comment) File tests/functional/utils.py Line 81: Line 82: if hasattr(self.vdscli, attr): Line 83: def wrapper(*args, **kwargs): Line 84: result = getattr(self.vdscli, attr)(*args, **kwargs) Line 85: self.lastResult = result done, looking back that functionality wasn't even reflected in commit message Line 86: return result['status']['code'], result['status']['message'] Line 87: return wrapper Line 88: Line 89: raise AttributeError(attr) -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d1e696a5280402725223ecc87646a75ba60061 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsProxy pass calls to undefined methods to API and return m...
Martin Polednik has posted comments on this change. Change subject: vdsProxy pass calls to undefined methods to API and return msg/status .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84d1e696a5280402725223ecc87646a75ba60061 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Sort bond's slave when objectivizing
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Sort bond's slave when objectivizing .. Patch Set 3: Code-Review-1 (1 comment) I hate to -1 on such a technicality when it is recovered code, but I'd like to keep netmodels as compliant to the style guidelines as possible. File vdsm/netmodels.py Line 389: to bonding in the same order that initscripts does it. Then it can Line 390: obtain the same master mac address by iproute2 as ifcfg. Line 391: Line 392: Line 393: nics_list = [] variable name convention is camelCase. Thus, it should be nicsList, nicsRexp, nicSre Line 394: nics_rexp = re.compile(^(\D*)(\d*)(.*)$) Line 395: Line 396: for nic_name in nics: Line 397: nic_sre = nics_rexp.match(nic_name) -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Let dummy interfaces destroied after cleaning up netw...
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: Let dummy interfaces destroied after cleaning up networks. .. Patch Set 1: Doesn't Missing required nics for bonding device. only show up when objectivizing? restore vdsm/netconf/ifcfg.py:restoreBackups is not calling it. Is this specific to iproute2 configurator's new memory rollback? -- To view, visit http://gerrit.ovirt.org/19609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd6c75794244069b035676ea67641f8a3d3964f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 8: Code-Review-1 (2 comments) NOTE: The following is a proposal, @Assaf, @Dan, @Yaniv and others, please review and if necessary I'll flip the vote. I have the sensation that instead of checking if a file exists, we should probably use dsaversion to check if the upgrade file exists and if it does, that the version it upgraded to is the one we are running. Then run would have an ordered dictionary of version number - upgrade method. It would loop running the missing upgrade methods (if any). For this to be good, installation should write to the upgrade file its version if the file does not exist. File lib/vdsm/tool/upgrade.py Line 36: self.run() Line 37: self._finished() Line 38: Line 39: def isNeeded(self): Line 40: return not os.path.exists(self.upgradeFilePath) See general comment. version checking. Line 41: Line 42: def run(self): Line 43: raise NotImplementedError Line 44: Line 42: def run(self): Line 43: raise NotImplementedError Line 44: Line 45: def _finished(self): Line 46: open(self.upgradeFilePath, 'w').close() See general comment. version writing. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
