Change in vdsm[master]: Move zombieReaper to its own package
Yaniv Bronhaim has posted comments on this change. Change subject: Move zombieReaper to its own package .. Patch Set 4: Code-Review-1 Please change to python-zombiereaper as python-cpopen, and we're good to go. About making it public argument, IMHO we should open a bz on that and continue talking about its need there. -- To view, visit http://gerrit.ovirt.org/19253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 10: Code-Review-1 You are still passing paths and I'm still not convinced it's the right things to do. Even if libvirt actively block other paths. It doesn't change the fact that passing the hardcoded path instead of something representative of what *kind* of device you are using is less portable and needlessly confusing. Giving the devices names like software\hardware would make us able to handle changes support other OSes and add new deices in the future. Also, please add verb to retrieve the list of supported RNG devices but the host. It could be hard-coded ATM. Just to be ready for the future. The fact that libvirt accept it like that doesn't -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add task support
Saggi Mizrahi has posted comments on this change.
Change subject: gluster: add task support
..
Patch Set 19: Code-Review+1
(1 comment)
Please, clean tabs if you happen to resend the patch.
Commit Message
Line 16: {TASKID: {
Line 17: volume: VOLUMENAME,
Line 18: status: TaskStatus,
Line 19: type: TaskType,
Line 20: bricks: [BRICK1,..],
runaway tabs
Line 21: data: SUMMARY
Line 22: }, ...}
Line 23:
Line 24: Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
--
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 25: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4658/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4582/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 25: Verified+1 Added a modification to the utils checks so that unified persistence is checked on all the tests. Ran all functional tests except the testSafeNetwork and testVolatileConfig, as those need parts of unified persistence that are added in follow up patches. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3774/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4583/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 12: Code-Review+1
(1 comment)
I like the new suggestion
File lib/vdsm/libvirtconnection.py
Line 131: log.debug('trying to connect libvirt')
Line 132: conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
Line 133: __connections[id(target)] = conn
Line 134:
Line 135: setattr(conn, 'pingLibvirt', getattr(conn,
'getLibVersion'))
because then its wrapped as all other conn functions (line 139) and the call to
getLibVersion will go through wrapper - we will end up with infinite loop
that calls to getLibVersion each run of the except logic
Line 136: for name in dir(libvirt.virConnect):
Line 137: method = getattr(conn, name)
Line 138: if callable(method) and name[0] != '_':
Line 139: setattr(conn, name, wrapMethod(method))
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 12: -Code-Review
(1 comment)
Until you figure the testing issue, and you must (I felt that it can be risky),
I added another minor comment to consider.
Anyhow, this change need to solve the vdsm restart occurrence. Now the
migration to unknown network won't lead to reset of vdsm, but it still won't
work until the required network will be configured properly, only appropriate
log should be shown in the log (That's what I expected to see)
File lib/vdsm/libvirtconnection.py
Line 131: log.debug('trying to connect libvirt')
Line 132: conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
Line 133: __connections[id(target)] = conn
Line 134:
Line 135: setattr(conn, 'pingLibvirt', getattr(conn,
'getLibVersion'))
You need to catch here AttributeError. If the API is wrong and getLibVersion
won't be there for any reason
Line 136: for name in dir(libvirt.virConnect):
Line 137: method = getattr(conn, name)
Line 138: if callable(method) and name[0] != '_':
Line 139: setattr(conn, name, wrapMethod(method))
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 10: Verified+1 added oVirt node comment and verified on el6. -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4660/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4584/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 25:
(2 comments)
This patch set is a very good idea Antoni!
File tests/functional/utils.py
Line 186: return bond_name in self.netinfo.bondings and \
Line 187: (not nics or set(nics) ==
Line 188: set(self.netinfo.bondings[bond_name]['slaves'])) and \
Line 189: (self.config is None or
Line 190: (bond_name in self.config.bonds and
What if nics is None?
Line 191: self.config.bonds[bond_name]['nics'] == nics))
Line 192:
Line 193: def vlanExists(self, vlan_name):
Line 194: dev, vlanid = vlan_name.split('.')
Line 190: (bond_name in self.config.bonds and
Line 191: self.config.bonds[bond_name]['nics'] == nics))
Line 192:
Line 193: def vlanExists(self, vlan_name):
Line 194: dev, vlanid = vlan_name.split('.')
To get rid of the 'found' boolean, maybe consider moving the for loop into an
inner function, then use it at the end of the return statement.
Line 195: if self.config is not None:
Line 196: found = False
Line 197: for net, attrs in self.config.networks.iteritems():
Line 198: if (vlanid == attrs.get('vlan') and
--
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 26: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4586/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3776/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4585/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Addressed Assaf's comments. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4587/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4588/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 4: Code-Review+1
(1 comment)
Check new return value Since version.
File vdsm_api/vdsmapi-schema.json
Line 3798: # @isolist: List of file names (for backward compatibility)
Line 3799: #
Line 3800: # @fileStats: Mapping with file information
Line 3801: #
Line 3802: # Since: 4.12.0
The version is probably wrong, because stable version is at 4.12.1 and it does
*not* include this api. This value can be set when we know which version will
include this patch.
Line 3803: ##
Line 3804: {'type': 'StorageDomainFileInfoMap',
Line 3805: 'data': {'isolist': ['str'], 'fileStats':
'StorageDomainFileStatsMap'}}
Line 3806:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move zombieReaper to its own package
Saggi Mizrahi has posted comments on this change. Change subject: Move zombieReaper to its own package .. Patch Set 4: As long as it's a VDSM subpackage it'll have to have the vdsm-zombiereaper prefix. -- To view, visit http://gerrit.ovirt.org/19253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix problems with current implementation of forceIscsiRescan
Saggi Mizrahi has abandoned this change. Change subject: Fix problems with current implementation of forceIscsiRescan .. Abandoned -- To view, visit http://gerrit.ovirt.org/8172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic4e7173086ba15c7706206c5ee1473ed6d334f9e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Rami Vaknin rvaknin.redhat@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Workaround to avoid password request when starting vdsmd ser...
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Workaround to avoid password request when starting vdsmd service
..
Workaround to avoid password request when starting vdsmd service
During start of vdsmd we shutdown conflicting services. As part of this
we try to stop libvirt-guests. `service libvirt-guests stop` tries to
access libvirtd which requires sasl authentication.
This patch removes libvirt-guests lockfile instead of stopping the service.
The patch should be reverted after a fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1011981 will be available
(Comment was added above the change to keep tracking the issue)
The workaround was part of vdsmd init script already in the past and was
removed by mistake.
Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1010693
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M init/sysvinit/vdsmd.init.in
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/19644/1
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 8f2c39b..2fd222d 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -55,12 +55,22 @@
local conflicting_services=$1
for srv in ${conflicting_services}; do
-if initctl status ${srv} /dev/null 21; then
-# When srv is Upstart service, status srv always returns 0
-initctl stop ${srv} || : # stop fails when already down
-initctl status ${srv} | grep -q stop/waiting
+if [ $srv == libvirt-guests ]; then
+ # `service libvirt-guests stop` tries to access libvirtd and
+ # requires sasl authentication. Instead, removing the lockfile
+ # signifies to libvirt-guests that it has stopped.
+ # TODO: This condition needs to be removed when BZ 1011981 fix will
+ # be available.
+ @RM_PATH@ -f /var/lock/subsys/libvirt-guests /dev/null 21
else
-(! service ${srv} status /dev/null 21) || service ${srv}
stop
+ if initctl status ${srv} /dev/null 21; then
+ # When srv is Upstart service, status srv always returns 0
+ initctl stop ${srv} || : # stop fails when already down
+ initctl status ${srv} | grep -q stop/waiting
+ else
+ (! service ${srv} status /dev/null 21) ||
+ service ${srv} stop
+ fi
fi
ret_val=$?
if [ ${ret_val} -ne 0 ]; then
--
To view, visit http://gerrit.ovirt.org/19644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Workaround to avoid password request when starting vdsmd ser...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Workaround to avoid password request when starting vdsmd service .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4589/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
mooli tayer has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 12:
(1 comment)
Regarding my tests problem, I assume it is not related to my patch but to the
issues with live migration disccussed on vdsm-devel.
File lib/vdsm/libvirtconnection.py
Line 131: log.debug('trying to connect libvirt')
Line 132: conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
Line 133: __connections[id(target)] = conn
Line 134:
Line 135: setattr(conn, 'pingLibvirt', getattr(conn,
'getLibVersion'))
Yaniv is right, using getLibVersion creates an infinate loop. getLibVersion is
a wrapped version at the point we need to call ping. If libvirt is down we will
keep going through the code in line 94.
Doing it this way is the best trade off I found between small fingerprint on
the wrapped class and writing code that is simple.
Regarding the AttributeError, as saggy commented, libvirt api is not expected
to change and in case it does we should any way let the exception propagate up.
Line 136: for name in dir(libvirt.virConnect):
Line 137: method = getattr(conn, name)
Line 138: if callable(method) and name[0] != '_':
Line 139: setattr(conn, name, wrapMethod(method))
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Workaround to avoid password request when starting vdsmd ser...
Dan Kenigsberg has posted comments on this change. Change subject: Workaround to avoid password request when starting vdsmd service .. Patch Set 1: Code-Review+2 We have to take it in until libvirt fixes their bug in el6.4. -- To view, visit http://gerrit.ovirt.org/19644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Naori davidnao...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Workaround to avoid password request when starting vdsmd ser...
Yaniv Bronhaim has posted comments on this change. Change subject: Workaround to avoid password request when starting vdsmd service .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Naori davidnao...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Saggi Mizrahi has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 12: Code-Review+1 I approve this as the major issue preventing people from grasping the change is that the original design of the module is backwards. The whole idea of passing target is odd and makes everything look weird. get() should just give an instance proxy object and than we use standard ways to share the proxy. This proxy, if existed, would have done these checks and invalidated the connection it proxies. The immediate next phase would be to change the design to that model so that future logic has a place to reside in. -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Workaround to avoid password request when starting vdsmd ser...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Workaround to avoid password request when starting vdsmd service .. Workaround to avoid password request when starting vdsmd service During start of vdsmd we shutdown conflicting services. As part of this we try to stop libvirt-guests. `service libvirt-guests stop` tries to access libvirtd which requires sasl authentication. This patch removes libvirt-guests lockfile instead of stopping the service. The patch should be reverted after a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1011981 will be available (Comment was added above the change to keep tracking the issue) The workaround was part of vdsmd init script already in the past and was removed by mistake. Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1010693 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19644 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/sysvinit/vdsmd.init.in 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7a3ad4db377f57a9d7fd34afc33d1add25c967f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Naori davidnao...@gmail.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make dummyIf a top decorator
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make dummyIf a top decorator .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3782/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4667/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4591/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc641796155a4df52d098821e1bcce000ab071a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4590/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make dummyIf a top decorator
Antoni Segura Puimedon has posted comments on this change. Change subject: Make dummyIf a top decorator .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc641796155a4df52d098821e1bcce000ab071a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage test dummies at the module level
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Manage test dummies at the module level
..
Manage test dummies at the module level
We can handle the dummies at the global level so that less work needs
to be done per test and the cleanupNetwork decorator doesn't miss
the dummies that were previously already destroyed at that stage.
Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M tests/functional/dummy.py
M tests/functional/networkTests.py
2 files changed, 21 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/19650/1
diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index f285cc4..c11cf9a 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -75,20 +75,3 @@
linkSet(dummyName, [state])
except IPRoute2Error:
raise SkipTest('Failed to bring %s to state %s' % (dummyName, state))
-
-
-@contextmanager
-def dummyIf(num):
-
-Manages a list of num dummy interfaces. Assumes root privileges.
-
-
-dummies = []
-try:
-dummies = [create() for _ in range(num)]
-yield dummies
-except Exception:
-raise
-finally:
-for dummy in dummies:
-remove(dummy)
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index f7071b9..21ea0da 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -27,7 +27,6 @@
from testValidation import RequireDummyMod, ValidateRunningAsRoot
import dummy
-from dummy import dummyIf
from utils import cleanupNet, restoreNetConfig, SUCCESS, VdsProxy, cleanupRules
from vdsm.ipwrapper import (ruleAdd, ruleDel, routeAdd, routeDel, routeExists,
@@ -44,19 +43,38 @@
IP_CIDR = '24'
IP_NETWORK_AND_CIDR = IP_NETWORK + '/' + IP_CIDR
IP_GATEWAY = '240.0.0.254'
-IP_TABLE = '4026531841' # Current implementation converts ip to its 32 bit int
- # representation
+# Current implementation converts ip to its 32 bit int representation
+IP_TABLE = '4026531841'
+dummyPool = []
def setupModule():
Persists network configuration.
vdsm = VdsProxy()
vdsm.save_config()
+for _ in range(5):
+dummyPool.append(dummy.create())
def tearDownModule():
Restores the network configuration previous to running tests.
restoreNetConfig()
+for nic in dummyPool:
+dummy.remove(nic)
+
+
+@contextmanager
+def dummyIf(num):
+Manages a list of num dummy interfaces. Assumes root privileges.
+dummies = []
+try:
+dummies = [dummyPool.pop() for _ in range(num)]
+yield dummies
+except Exception:
+raise
+finally:
+for nic in dummies:
+dummyPool.append(nic)
class OperStateChangedError(ValueError):
--
To view, visit http://gerrit.ovirt.org/19650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage test dummies at the module level
oVirt Jenkins CI Server has posted comments on this change. Change subject: Manage test dummies at the module level .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3784/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4669/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4593/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for ram/vram on QXL device
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: add support for ram/vram on QXL device .. Patch Set 6: (1 comment) Looks good, just a minor query File vdsm_api/vdsmapi-schema.json Line 2232: # Line 2233: # @vram: value of virtual ram in KB, for 'cirrus' the default is '9216' Line 2234: # for @qxl is the size of the secondary bar, Line 2235: # Line 2236: # @ram: size of the primary bar for @qxl in KB, why not have it be in bytes. We use bytes for everything else. We just document that we round of to the next block\sector\KB were appropriate. Line 2237: # not supported for 'cirrus' Line 2238: # Line 2239: # @heads: #optional Specify the amount of monitors that will use single Line 2240: # pci device. Currently relevant for @qxl devices only -- To view, visit http://gerrit.ovirt.org/19361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage test dummies at the module level
oVirt Jenkins CI Server has posted comments on this change. Change subject: Manage test dummies at the module level .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3785/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4670/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4594/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Eduardo has uploaded a new change for review. Change subject: Convert guids into mapper devs for extend blockSD .. Convert guids into mapper devs for extend blockSD After I1ec54147205992ac130684d01e73cd7aceccad48, which changed multipath.getMPDevNamesIter() to return full paths, HSM.extendStorageDomain() guids param should be converted accordingly. Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012944 Signed-off-by: Eduardo ewars...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/19659/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 9cfabdb..8749163 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -723,7 +723,7 @@ return dict(size=str(roundedSizeBytes)) @public -def extendStorageDomain(self, sdUUID, spUUID, devlist, +def extendStorageDomain(self, sdUUID, spUUID, guids, force=False, options=None): Extends a VG. ? @@ -741,13 +741,15 @@ vars.task.setDefaultException( se.StorageDomainActionError( -sdUUID=%s, devlist=%s % (sdUUID, devlist))) +sdUUID=%s, devlist=%s % (sdUUID, guids))) vars.task.getSharedLock(STORAGE, sdUUID) # We need to let the domain to extend itself pool = self.getPool(spUUID) pool.validatePoolSD(sdUUID) -pool.extendSD(sdUUID, devlist, force) +dmDevs = tuple(os.path.join(devicemapper.DMPATH_PREFIX, guid) for guid + in guids) +pool.extendSD(sdUUID, dmDevs, force) @public def forcedDetachStorageDomain(self, sdUUID, spUUID, options=None): -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4595/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Testing commit.
Nir Soffer has uploaded a new change for review. Change subject: Testing commit. .. Testing commit. This is a rather harmless test commit that does not break anything. You can safely +1 it. Change-Id: I649b291372152fae958c9d2a35cbfae1872708cf Signed-off-by: Nir Soffer nsof...@redhat.com --- A TEST 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/19660/1 diff --git a/TEST b/TEST new file mode 100644 index 000..a4daecf --- /dev/null +++ b/TEST @@ -0,0 +1 @@ +Testing 1 2 3... -- To view, visit http://gerrit.ovirt.org/19660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I649b291372152fae958c9d2a35cbfae1872708cf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Eduardo has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 1: Verified+1 [root@localhost ~]# vgs -o +pv_name 2a7fbb64-f64c-4139-ba79-aaf21547845f VG #PV #LV #SN Attr VSize VFree PV 2a7fbb64-f64c-4139-ba79-aaf21547845f 1 6 0 wz--n- 99.62g 95.75g /dev/mapper/1elad1213738004 [root@localhost ~]# vdsClient -s 0 extendStorageDomain 2a7fbb64-f64c-4139-ba79-aaf21547845f 0d1ef687-3b3f-4e27-89f2-69d38dc4dc22 1elad1313738004 [root@localhost ~]# echo $? 0 [root@localhost ~]# vdsClient -s 0 getStorageDomainInfo 2a7fbb64-f64c-4139-ba79-aaf21547845f uuid = 2a7fbb64-f64c-4139-ba79-aaf21547845f vguuid = fzjUA0-bfG5-UJIL-nya2-T6NI-yAOh-8w3FsC lver = 1 state = OK version = 3 role = Master pool = ['0d1ef687-3b3f-4e27-89f2-69d38dc4dc22'] spm_id = 1 type = ISCSI class = Data master_ver = 1 name = edu1 [root@localhost ~]# vgs -o +pv_name 2a7fbb64-f64c-4139-ba79-aaf21547845f VG #PV #LV #SN Attr VSize VFree PV 2a7fbb64-f64c-4139-ba79-aaf21547845f 2 6 0 wz--n- 199.25g 195.38g /dev/mapper/1elad1213738004 2a7fbb64-f64c-4139-ba79-aaf21547845f 2 6 0 wz--n- 199.25g 195.38g /dev/mapper/1elad1313738004 -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Dan Kenigsberg has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 1: Code-Review-1 (1 comment) patch seems fine, but better fix the docstring while at it. File vdsm/storage/hsm.py Line 734: :param sdUUID: The UUID of the storage domain that owns the VG. Line 735: :type sdUUID: UUID Line 736: :param spUUID: The UUID of the storage pool that owns the VG. Line 737: :type spUUID: UUID Line 738: :param devlist: The list of devices you want to extend the VG to. ? better fix the docstring too. Line 739: :type devlist: list of devices. ``[dev1, dev2]``. ? Line 740: :param options: ? Line 741: Line 742: vars.task.setDefaultException( -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Testing commit.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testing commit. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3788/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4597/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I649b291372152fae958c9d2a35cbfae1872708cf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Testing commit.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testing commit. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3789/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4598/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I649b291372152fae958c9d2a35cbfae1872708cf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3790/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4675/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4599/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Dan Kenigsberg has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage test dummies at the module level
Dan Kenigsberg has posted comments on this change. Change subject: Manage test dummies at the module level .. Patch Set 3: Code-Review-1 (3 comments) Thanks for this patch. File tests/functional/networkTests.py Line 46: # Current implementation converts ip to its 32 bit int representation Line 47: IP_TABLE = '4026531841' Line 48: dummyPool = [] Line 49: Line 50: since order does not matter, I think that a set() fits better here. Line 51: def setupModule(): Line 52: Persists network configuration. Line 53: vdsm = VdsProxy() Line 54: vdsm.save_config() Line 67: def dummyIf(num): Line 68: Manages a list of num dummy interfaces. Assumes root privileges. Line 69: dummies = [] Line 70: try: Line 71: dummies = [dummyPool.pop() for _ in range(num)] it would be cleaner to place this out of the try block. Even if the pool is exhausted (or any other exception), the finally clause would free nothing as dummies stays []. Line 72: yield dummies Line 73: except Exception: Line 74: raise Line 75: finally: Line 69: dummies = [] Line 70: try: Line 71: dummies = [dummyPool.pop() for _ in range(num)] Line 72: yield dummies Line 73: except Exception: what is the except clause good for? Line 74: raise Line 75: finally: Line 76: for nic in dummies: Line 77: dummyPool.append(nic) -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Eduardo has posted comments on this change. Change subject: Convert guids into mapper devs for extend blockSD .. Patch Set 2: Verified+1 Patchset 1 verified using vdsClient. See previous comment. -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert guids into mapper devs for extend blockSD
Dan Kenigsberg has submitted this change and it was merged. Change subject: Convert guids into mapper devs for extend blockSD .. Convert guids into mapper devs for extend blockSD After I1ec54147205992ac130684d01e73cd7aceccad48, which changed multipath.getMPDevNamesIter() to return full paths, HSM.extendStorageDomain() guids param should be converted accordingly. Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012944 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19659 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Eduardo: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6da419542d8b4ac61cc9b82c2f84dcf8ce486ced Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3793/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4602/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move zombieReaper to its own package
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move zombieReaper to its own package .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3791/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4676/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4600/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tests: Fixed resource manager stress test
oVirt Jenkins CI Server has posted comments on this change. Change subject: Tests: Fixed resource manager stress test .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3792/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4601/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ba095724a251968c8d5b2767e6491825d79297e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3795/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4680/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4603/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Create AsyncProcessOperation
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3794/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4679/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4604/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rescan FC when rescanning for new multipath devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: Rescan FC when rescanning for new multipath devices .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3796/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4681/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4605/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Saggi Mizrahi has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 4: Code-Review-1 Put the number of the version you expect this to get in. -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Saggi Mizrahi has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8: Code-Review-1
(3 comments)
You probably don't want to design this that way.
You want to have a method called Upgrade() (and UpgradeIfNeeded() if you so
choose) the hint is that Upgrade is not really a name for a class. You want to
have in implicit interface for the parameter which is obj.run() obj.isNeeded().
I will call them UpgradeTarget objects.
Since it's improbable to think that all upgrades will use a simple file to
check if they are comitted it's best to either put the check file logic in a
reusable class of it's own or implement it inside the single user which is the
UnifiedPersistence(object) class.
Python is not Java. We avoid creating needless base classes for things for no
real gain.
Favor 'object composition' over 'class inheritance'. (Gang of Four 1995:20)
https://en.wikipedia.org/wiki/Composition_over_inheritance#Benefits
File lib/vdsm/tool/upgrade.py
Line 24:
Line 25:
Line 26: class Upgrade(object):
Line 27: def __init__(self):
Line 28: self.upgradeName = self.__class__.__name__
I smell inheritance in the near future
Line 29: self.upgradeFilePath = constants.P_VDSM_LIB + upgrade/%s % \
Line 30: self.upgradeName
Line 31: self.log = logging.getLogger('vds')
Line 32:
Line 25:
Line 26: class Upgrade(object):
Line 27: def __init__(self):
Line 28: self.upgradeName = self.__class__.__name__
Line 29: self.upgradeFilePath = constants.P_VDSM_LIB + upgrade/%s % \
os.path.jon()?
Line 30: self.upgradeName
Line 31: self.log = logging.getLogger('vds')
Line 32:
Line 33: def runIfNeeded(self):
Line 39: def isNeeded(self):
Line 40: return not os.path.exists(self.upgradeFilePath)
Line 41:
Line 42: def run(self):
Line 43: raise NotImplementedError
You raise an instance not a type. NotImplementedError()
Line 44:
Line 45: def _finished(self):
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Saggi Mizrahi has posted comments on this change.
Change subject: getStorageDomainInfo: SP keys when disconnected.
..
Patch Set 2: Code-Review+1
(1 comment)
File vdsm/storage/hsm.py
Line 2738: # remove this when we can stop supporting this API.
Line 2739: if info['role'] != sd.MASTER_DOMAIN:
Line 2740: info.update({'lver': -1, 'spm_id': -1, 'master_ver': 0})
Line 2741: else:
Line 2742: pmd = sp.StoragePool._getPoolMD(dom)
Just add a comment since you are accessing a private method
Line 2743: info['lver'] = pmd[sp.PMDK_LVER]
Line 2744: info['master_ver'] = pmd[sp.PMDK_MASTER_VER]
Line 2745: info['spm_id'] = -1
Line 2746: try:
--
To view, visit http://gerrit.ovirt.org/19555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix log level for failures in execCmd
Sergey Gotliv has abandoned this change. Change subject: Fix log level for failures in execCmd .. Abandoned -- To view, visit http://gerrit.ovirt.org/13362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
