Change in vdsm[master]: Migration cancellation replies wrong message format
oVirt Jenkins CI Server has posted comments on this change. Change subject: Migration cancellation replies wrong message format .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4622/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5501/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17a2463154e9f67191a818f137a4e7158a74dbbb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 16: Added the task to the list - sorry for the noise. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5423/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5502/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf
Sandro Bonazzola has posted comments on this change. Change subject: Renaming /etc/sysctl.d/vdsm to /etc/sysctl.d/vdsm.conf .. Patch Set 1: Do we need more reviewers? -- To view, visit http://gerrit.ovirt.org/21202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ac929db854d7a5f9bd96d144e8ef36070f74126 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 16:
(1 comment)
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
FINALLY ! :)
now I can say that you can just put here:
task_lvm_deactivate_lvs(){
local vgs_info=$(/sbin/lvm vgs --noheadings -o vg_name,tags)
if [ $? -ne 0 ]; then
log_failure_msg $prog: error checking vgs
return 1
fi
$(echo $vgs_info | /bin/awk '/MDT_TYPE=FCP/ {print $1}') || return 1
[ ! lvm vgchange -a n $vdsm_vgs ] || return 1
return 0
}
its quite more simple .. and anyhow, you plan to use it only here. no?
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: refresh raw disk before live extension
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: refresh raw disk before live extension .. vm: refresh raw disk before live extension As part of the online disk extension (raw format on block domains) flow the leaf logical volume is extended by the SPM to the new size. On the HSM host (where the VM is running) we need to refresh the volume in order to update the volume segments and make the new size visible to the qemu process. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029501 Change-Id: I4fc3b578a865e25586a719f7c5120df12842d046 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21177 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/vm.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified -- To view, visit http://gerrit.ovirt.org/21177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fc3b578a865e25586a719f7c5120df12842d046 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 16:
(1 comment)
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
It is simpler because it is does not have the same functionality, not testable
and less modular. Otherwise it is fine :-)
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 16:
(1 comment)
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
Please do, and drop the complex unreadable python code.
Or at least workout the python code so it will be sane.
But for these kind of tasks there is no need for that.
task_lvm_deactivate_lvs() {
local guard=@VDSMRUNDIR@/vdsm-lvm
[ -f ${guard} ] || return 0
touch ${guard}
local line
lvm vgs --noheading --separator '|' -o name,tags | while IFS='|' read vg
tags; do
vdsmFCVG() {
local tags=$1
echo ${tags} | grep -q RHAT_storage_domain
echo ${tags} | grep -q MDT_TYPE=FCP
}
vg=$(echo ${vg}) # strip
if vdsmFCVG ${tags}; then
if ! lvm vgchange --available n ${vg}; then
lvm lvs --noheading --separator '|' -o name,attr ${vg} |
while IFS='|' read lv attr; do
lv=$(echo ${lv}) # strip
case ${attr} in
ao*|a-*)
echo Skiping ${vg}/${lv} active or open
;;
*)
lvm lvchange --available n ${vg}/${lv} || exit 1
;;
esac
done || exit 1
fi
fi
done
if [ $? != 0 ]; then
echo Failed to diactivate lvs
return 1
fi
return 0
}
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
Darshan N has posted comments on this change. Change subject: gluster: new verb to remove host using host UUID .. Patch Set 4: have created a new verb as per the suggestion. -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: new verb to remove host using host UUID .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4624/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5503/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
Aravinda VK has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 4: Verified-1
(2 comments)
Commit Message
Line 7: gluster: new verb to remove host using host UUID
Line 8:
Line 9: This patch adds a new verb glusterHostRemoveByUuid which
Line 10: retrives the host name based on uuid passed and uses it to
Line 11: remove the host.
Update verb name, possible exceptions and return type.
Line 12:
Line 13: Signed-off-by: ndarshan dnara...@redhat.com
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 943: # Success or failure
Line 944: #
Line 945: # Since: 4.14.0
Line 946: ##
Line 947: {'command': {'class': 'GlusterHost', 'name': 'remove'},
name should be removeByUuid
Line 948: 'data': {'hostUuid': 'UUID', 'force': 'bool'},
Line 949: 'returns': 'bool'}
Line 950:
Line 951: ##
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 16:
(1 comment)
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
We do not require to perform unit test to lvm program... this logic is not to
be changed unless lvm is changed.
Sorry... had misunderstanding of the python logic... a fix:
task_lvm_deactivate_lvs() {
local guard=@VDSMRUNDIR@/vdsm-lvm
[ -f ${guard} ] || return 0
touch ${guard}
local line
lvm vgs --noheading --separator '|' -o name,tags | while IFS='|' read vg
tags; do
vdsmFCVG() {
local tags=$1
echo ${tags} | grep -q RHAT_storage_domain
echo ${tags} | grep -q MDT_TYPE=FCP
}
vg=$(echo ${vg}) # strip
if vdsmFCVG ${tags}; then
if ! lvm vgchange --available n ${vg}; then
lvm lvs --noheading --separator '|' -o name,attr ${vg} |
while IFS='|' read lv attr; do
lv=$(echo ${lv}) # strip
case ${attr} in
-*);;
ao*)
echo Skiping ${vg}/${lv} active or open
;;
*)
lvm lvchange --available n ${vg}/${lv} || exit 1
;;
esac
done || exit 1
fi
fi
done
if [ $? != 0 ]; then
echo Failed to diactivate lvs
return 1
fi
return 0
}
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 16:
(1 comment)
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
The tests check the calls more than the lvm itself, like the parameters we send
to the lvm command and the guard logic.. it may be nice to have those and it
will fail if someone will decide to change it. although, if someone decides to
change the cmd parameters because lvm was changed, now he'll just need to
modify it in two locations.
it doesn't test more except the parameter you except to get and the output you
except to get if specific parameters were sent.. or am i missing something
there?
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: change network sampling interval to 15 seconds
..
vdsm: change network sampling interval to 15 seconds
Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf
Bug-Url: https://bugzilla.redhat.com/??
Signed-off-by: Martin Polednik mpole...@redhat.com
---
M lib/vdsm/config.py.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/21257/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index c0bdd53..6df76cc 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -127,7 +127,7 @@
('vm_sample_disk_latency_window', '2', None),
-('vm_sample_net_interval', '5', None),
+('vm_sample_net_interval', '15', None),
('vm_sample_net_window', '2', None),
--
To view, visit http://gerrit.ovirt.org/21257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: change network sampling interval to 15 seconds .. Patch Set 1: Code-Review-1 (2 comments) Commit Message Line 3: AuthorDate: 2013-11-14 10:54:37 +0100 Line 4: Commit: Martin Polednik mpole...@redhat.com Line 5: CommitDate: 2013-11-14 10:55:56 +0100 Line 6: Line 7: vdsm: change network sampling interval to 15 seconds I would appreciate a new paragraph with an explanation of why this is needed. Line 8: Line 9: Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Line 10: Bug-Url: https://bugzilla.redhat.com/?? Line 6: Line 7: vdsm: change network sampling interval to 15 seconds Line 8: Line 9: Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Line 10: Bug-Url: https://bugzilla.redhat.com/?? Bug ?? That doesn't seem like a valid bug number. -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: change network sampling interval to 15 seconds .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4625/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5504/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add simple mocking library
mooli tayer has posted comments on this change. Change subject: tests: Add simple mocking library .. Patch Set 1: Code-Review+1 (1 comment) Commit Message Line 11: environment for running. Line 12: Line 13: MockCallable is using the record and play aprroach; After a mock is Line 14: created, you tell it what calls to expect. If needed, you may specify Line 15: the result of each call. The result may any return value or rasing an The only thing missing for me is an ability to return something more complex then a static value - based on arguments. ( Actually I believe you've implemented a stub and not a mock, but nomenclature is always arguable... you can checkout this by martin fowler: http://martinfowler.com/articles/mocksArentStubs.html#TheDifferenceBetweenMocksAndStubs ) Line 16: exception. Line 17: Line 18: When the mock is called by the code under test, it will raise a Line 19: MockError as soon as it is called with unexpected arguments or keyword -- To view, visit http://gerrit.ovirt.org/21155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: change network sampling interval to 15 seconds .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5426/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5505/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: change network sampling interval to 15 seconds .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add an exception for wrong master version.
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Add an exception for wrong master version. .. Patch Set 3: Code-Review+1 (1 comment) File vdsm/storage/storage_exception.py Line 609: code = 330 Line 610: message = Cannot get file stats Line 611: Line 612: Line 613: class StoragePoolWrongVersion(StorageException): Maor wrote on Patch Set 1: engine new error codes will be updated properly when the solution will be accepted I agree with that. And from vdsm side I would give it +1. That's exactly the requirement in the bz Line 614: def __init__(self, spUUID, sdUUID): Line 615: self.value = SD=%s, pool=%s % (sdUUID, spUUID) Line 616: code = 331 Line 617: message = Wrong Master version -- To view, visit http://gerrit.ovirt.org/21175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7356c6ebc1aa15910725e0bd17faccd0858621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add an exception for wrong master version.
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Add an exception for wrong master version. .. Patch Set 3: -Code-Review (1 comment) File vdsm/storage/storage_exception.py Line 611: Line 612: Line 613: class StoragePoolWrongVersion(StorageException): Line 614: def __init__(self, spUUID, sdUUID): Line 615: self.value = SD=%s, pool=%s % (sdUUID, spUUID) why not adding the versions also ?.. if you already split the exceptions Line 616: code = 331 Line 617: message = Wrong Master version Line 618: Line 619: -- To view, visit http://gerrit.ovirt.org/21175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7356c6ebc1aa15910725e0bd17faccd0858621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling.ImagePathStatus: drop unused code, and only it
Petr Šebek has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code, and only it
..
Patch Set 1: Verified+1 Code-Review+1
I applied given patch to my host. In webadmin host smoothly went from
maintenance to up state. I added VM to this host and some storage. When I ran
vdsClient -s 0 getVdsStats
there is correct content in storageDomains:
storageDomains = {'3cc3dc79-c40f-49a7-aaa7-33b8158b14a7': {'acquired': True,
'code': 0,
'delay':
'0.000347731',
'lastCheck': '8.8',
'valid': True,
'version': 3}}
--
To view, visit http://gerrit.ovirt.org/21038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I530b6d83c6ab5d0cc52df797ae3e40998fb77435
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 13: I thought about it more and I prefer no to have logger at all. if you want, you can make --verbos option and use that for additional outputs to stdout or syslog. I don't understand the usage for logger in a command line tool. if you use it during run, you can catch exceptions and print them to vdsm.log near the usage. -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: prepareImage: decommission volType from gluster info
oVirt Jenkins CI Server has posted comments on this change. Change subject: prepareImage: decommission volType from gluster info .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4628/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5428/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5507/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720b4b145e63899584e601d01fd423eb016583e4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: change network sampling interval to 15 seconds .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
Martin Polednik has posted comments on this change. Change subject: vdsm: change network sampling interval to 15 seconds .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: change network sampling interval to 15 seconds
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: change network sampling interval to 15 seconds .. vdsm: change network sampling interval to 15 seconds As discussed on engine-devel, there is no reason to poll libvirt more often than engine polls vdsm. This patch will make polling in sync with cpu (vm_sample_cpu_interval) polling. Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Signed-off-by: Martin Polednik mpole...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21257 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/config.py.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/21257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c5bf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add simple mocking library
Nir Soffer has posted comments on this change. Change subject: tests: Add simple mocking library .. Patch Set 1: (1 comment) Commit Message Line 11: environment for running. Line 12: Line 13: MockCallable is using the record and play aprroach; After a mock is Line 14: created, you tell it what calls to expect. If needed, you may specify Line 15: the result of each call. The result may any return value or rasing an What you suggest, adding logic to return different output based on input, is actually to create a stub. Mocks contain no logic, and the test code control the input and output. The problem with stub is they may be more complex then the code they test, and you need to add test for each stub to make sure it work as you think :-) Line 16: exception. Line 17: Line 18: When the mock is called by the code under test, it will raise a Line 19: MockError as soon as it is called with unexpected arguments or keyword -- To view, visit http://gerrit.ovirt.org/21155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
Darshan N has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 4:
(2 comments)
Commit Message
Line 7: gluster: new verb to remove host using host UUID
Line 8:
Line 9: This patch adds a new verb glusterHostRemoveByUuid which
Line 10: retrives the host name based on uuid passed and uses it to
Line 11: remove the host.
Done
Line 12:
Line 13: Signed-off-by: ndarshan dnara...@redhat.com
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 943: # Success or failure
Line 944: #
Line 945: # Since: 4.14.0
Line 946: ##
Line 947: {'command': {'class': 'GlusterHost', 'name': 'remove'},
Done
Line 948: 'data': {'hostUuid': 'UUID', 'force': 'bool'},
Line 949: 'returns': 'bool'}
Line 950:
Line 951: ##
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new verb to remove host using host UUID
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: new verb to remove host using host UUID .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5430/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5509/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfff258ccc43c276ca7b9c0472dacac2fefce64a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: pre-defined range for spice/vnc ports .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/17058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Alex Lourie alou...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol, added unit tests
Assaf Muller has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol, added unit tests .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5432/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5511/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Alon Bar-Lev has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 17: I am out of this review. Have fun. -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Patch Set 16:
(2 comments)
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
This is very smart shell script, but I'm not sure that it is equivalent to the
python code or correct, and it is not less complex. Since we don't know yet how
to clone you, it will be easier to maintain the Python version.
Can you point to the complex or unclear code in the Python version so I can fix
them?
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: $VDSM_TOOL lvm-deactivate-lvs
Line 184: }
The tests check that lvm is called with the correct parameters, and lvm output
is handled correctly.
The only thing that we don't have to test there is parameter order;
[--noheadings, --separator, |] is the same as [--separator, |,
--noheadings]. To support that we need a much smarter mock or stub which knows
lvm semantics. I don't think it worth the effort to go in this direction, as
parameter order is unlikely to change.
Line 185: pre-start tasks end
Line 186:
Line 187:
Line 188: post-stop tasks
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: replace self.conf['devices'] by VmDeviceContainer
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmDevices: replace self.conf['devices'] by VmDeviceContainer .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4634/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5434/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5513/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bdb5c331657c1c0d1ae902eabb5d3315d45bf8b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: introduce VmDeviceContainer
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmDevices: introduce VmDeviceContainer .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4635/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5435/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5514/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Allon Mureinik has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Assaf Muller has uploaded a new change for review.
Change subject: Add unit tests for unified network persistence
..
Add unit tests for unified network persistence
Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd
Signed-off-by: Assaf Muller amul...@redhat.com
---
A tests/netconfpersistenceTests.py
1 file changed, 79 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/21269/1
diff --git a/tests/netconfpersistenceTests.py b/tests/netconfpersistenceTests.py
new file mode 100644
index 000..f9ce7e7
--- /dev/null
+++ b/tests/netconfpersistenceTests.py
@@ -0,0 +1,79 @@
+#
+# Copyright 2013 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+import json
+import os
+from shutil import rmtree
+import tempfile
+
+from testrunner import VdsmTestCase as TestCaseBase
+
+from vdsm.netconfpersistence import Config
+
+NETWORK = 'luke'
+NETWORK_ATTRIBUTES = {'bonding': 'bond0', 'bridged': 'true', 'vlan': '1'}
+BONDING = 'skywalker'
+BONDING_ATTRIBUTES = {'options': 'mode=4 miimon=100', 'nics': ['eth0', 'eth1']}
+
+
+class netConfPersistenceTests(TestCaseBase):
+def __init__(self, *args, **kwargs):
+TestCaseBase.__init__(self, *args, **kwargs)
+self.tempdir = tempfile.mkdtemp()
+os.mkdir(os.path.join(self.tempdir, 'nets'))
+os.mkdir(os.path.join(self.tempdir, 'bonds'))
+
+def __del__(self):
+rmtree(self.tempdir)
+
+def testInit(self):
+try:
+filePath = os.path.join(self.tempdir, 'nets', NETWORK)
+with open(filePath, 'w') as networkFile:
+json.dump(NETWORK_ATTRIBUTES, networkFile)
+
+persistence = Config(self.tempdir + os.sep)
+self.assertEqual(persistence.networks[NETWORK], NETWORK_ATTRIBUTES)
+finally:
+os.remove(filePath)
+
+def testSetAndRemoveNetwork(self):
+persistence = Config(self.tempdir + os.sep)
+persistence.setNetwork(NETWORK, NETWORK_ATTRIBUTES)
+self.assertEqual(persistence.networks[NETWORK], NETWORK_ATTRIBUTES)
+persistence.removeNetwork(NETWORK)
+self.assertTrue(persistence.networks.get(NETWORK) is None)
+
+def testSetAndRemoveBonding(self):
+persistence = Config(self.tempdir + os.sep)
+persistence.setBonding(BONDING, BONDING_ATTRIBUTES)
+self.assertEqual(persistence.bonds[BONDING], BONDING_ATTRIBUTES)
+persistence.removeBonding(BONDING)
+self.assertTrue(persistence.bonds.get(BONDING) is None)
+
+def testSaveAndDelete(self):
+persistence = Config(self.tempdir + os.sep)
+persistence.setNetwork(NETWORK, NETWORK_ATTRIBUTES)
+filePath = os.path.join(self.tempdir, 'nets', NETWORK)
+self.assertFalse(os.path.exists(filePath))
+persistence.save()
+self.assertTrue(os.path.exists(filePath))
+persistence.delete()
+self.assertFalse(os.path.exists(filePath))
--
To view, visit http://gerrit.ovirt.org/21269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Assaf Muller has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5437/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5516/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Antoni Segura Puimedon has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 2: Code-Review-1
(2 comments)
File tests/netconfpersistenceTests.py
Line 33: BONDING_ATTRIBUTES = {'options': 'mode=4 miimon=100', 'nics': ['eth0',
'eth1']}
Line 34:
Line 35:
Line 36: class netConfPersistenceTests(TestCaseBase):
Line 37: def __init__(self, *args, **kwargs):
Instead of __init__ and __del__ you should be using setUp and tearDown.
Line 38: TestCaseBase.__init__(self, *args, **kwargs)
Line 39: self.tempdir = tempfile.mkdtemp()
Line 40: os.mkdir(os.path.join(self.tempdir, 'nets'))
Line 41: os.mkdir(os.path.join(self.tempdir, 'bonds'))
Line 48: filePath = os.path.join(self.tempdir, 'nets', NETWORK)
Line 49: with open(filePath, 'w') as networkFile:
Line 50: json.dump(NETWORK_ATTRIBUTES, networkFile)
Line 51:
Line 52: persistence = Config(self.tempdir + os.sep)
Do we really need the os.sep? I'd be cool if Config could do without the
trailing slash.
Line 53: self.assertEqual(persistence.networks[NETWORK],
NETWORK_ATTRIBUTES)
Line 54: finally:
Line 55: os.remove(filePath)
Line 56:
--
To view, visit http://gerrit.ovirt.org/21269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.
Ayal Baron has posted comments on this change. Change subject: lvm: Ensure active LVs are refreshed before use. .. Patch Set 5: (1 comment) File vdsm/storage/lvm.py Line 1126: def activateLVs(vgName, lvNames): Line 1127: lvNames = _normalizeargs(lvNames) Line 1128: toActivate = [lvName for lvName in lvNames Line 1129: if not _isLVActive(vgName, lvName)] Line 1130: doNotRefresh = ['inbox', 'outbox', 'ids', 'metadata', 'master', 'leases'] 1. I absolutely agree about the layering problem 2. the motivation is that these LVs are actually expected to be active all the time 3. it indeed should be frozen and in fact passed from sd layer, but it would ruin the API (how would you name the parameter?) Any suggestions? Line 1131: toRefresh = [lvName for lvName in lvNames Line 1132: if lvName not in toActivate and lvName not in doNotRefresh] Line 1133: Line 1134: if toActivate: -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of mutables(lists) as default parameters
oVirt Jenkins CI Server has posted comments on this change. Change subject: Get rid of mutables(lists) as default parameters .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5439/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5518/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: refresh raw disk before live extension
Hello Ayal Baron,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21274
to review the following change.
Change subject: vm: refresh raw disk before live extension
..
vm: refresh raw disk before live extension
As part of the online disk extension (raw format on block domains) flow
the leaf logical volume is extended by the SPM to the new size.
On the HSM host (where the VM is running) we need to refresh the volume
in order to update the volume segments and make the new size visible to
the qemu process.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029501
Change-Id: I4fc3b578a865e25586a719f7c5120df12842d046
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21177
Reviewed-by: Ayal Baron aba...@redhat.com
---
M vdsm/vm.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/21274/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 1a16d53..475f6ce 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -4054,6 +4054,12 @@
return {'status': doneCode, 'size': str(sizeRoundedBytes)}
def _diskSizeExtendRaw(self, drive, newSizeBytes):
+# Picking up the volume size extension
+self.__refreshDriveVolume({
+'domainID': drive.domainID, 'poolID': drive.poolID,
+'imageID': drive.imageID, 'volumeID': drive.volumeID,
+})
+
volumeInfo = self.cif.irs.getVolumeSize(
drive.domainID, drive.poolID, drive.imageID, drive.volumeID)
--
To view, visit http://gerrit.ovirt.org/21274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fc3b578a865e25586a719f7c5120df12842d046
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: refresh raw disk before live extension
Federico Simoncelli has posted comments on this change. Change subject: vm: refresh raw disk before live extension .. Patch Set 1: Verified+1 Code-Review+2 Same as master. -- To view, visit http://gerrit.ovirt.org/21274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc3b578a865e25586a719f7c5120df12842d046 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove onboot, delay, forward_delay from setupNetworks API
Assaf Muller has posted comments on this change. Change subject: Remove onboot, delay, forward_delay from setupNetworks API .. Patch Set 2: Verified+1 Verification - Sent onboot, ONBOOT, delay, DELAY and forward_delay as options and they were ignored for vm and non-vm nets. -- To view, visit http://gerrit.ovirt.org/20967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove onboot, delay, forward_delay from setupNetworks API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove onboot, delay, forward_delay from setupNetworks API .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5440/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/803/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
Bala.FA has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/19674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 4: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4644/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5444/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5523/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix the premature selinux dependency fix
Dan Kenigsberg has uploaded a new change for review.
Change subject: fix the premature selinux dependency fix
..
fix the premature selinux dependency fix
Commit 68d44c613 explaind why fixing the selinux-policy dependency is
important but it actually did not include the semanage code that it has
promised. That's happened, most probably, by a cherry-picking from the
ovirt-3.3 branch.
Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/21284/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index ad4260a..17b77e8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -161,7 +161,7 @@
Requires: policycoreutils = 2.0.83-19.30
Requires: policycoreutils-python = 2.0.83-19.30
Requires: python-pthreading
-Requires: selinux-policy-targeted = 3.7.19-195.el6.13
+Requires: selinux-policy-targeted = 3.7.19-155
Requires: lvm2 = 2.02.95-10.el6_3.2
Requires: logrotate 3.8.0
%endif
@@ -653,6 +653,11 @@
if [ $1 -eq 1 ] ; then
/sbin/chkconfig --add vdsmd
/sbin/chkconfig --add supervdsmd
+
+# drop this ugly hack when selinux-policy-3.7.19-195.el6.13 is released
+/usr/sbin/semanage fcontext -a -s system_u -t virt_var_run_t -r s0 \
+'/var/run/vdsm(/.*)?'
+/sbin/restorecon /var/run/vdsm
fi
%else
%if 0%{?with_systemd}
--
To view, visit http://gerrit.ovirt.org/21284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix the premature selinux dependency fix
Eyal Edri has posted comments on this change. Change subject: fix the premature selinux dependency fix .. Patch Set 1: seems to work, but now fails on another pkg: --- Package vdsm-xmlrpc.noarch 0:4.13.0-133.git7e51f7b.el6 will be installed --- Package vdsm-yajsonrpc.noarch 0:4.13.0-133.git7e51f7b.el6 will be installed -- Finished Dependency Resolution Error: Package: vdsm-4.13.0-133.git7e51f7b.el6.x86_64 (/vdsm-4.13.0-133.git7e51f7b.el6.x86_64) Requires: iscsi-initiator-utils = 6.2.0.873-3 Installed: iscsi-initiator-utils-6.2.0.873-2.el6.x86_64 (@anaconda-CentOS-201303020151.x86_64/6.4) iscsi-initiator-utils = 6.2.0.873-2.el6 -- To view, visit http://gerrit.ovirt.org/21284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix the premature selinux dependency fix
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix the premature selinux dependency fix .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4645/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5445/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5524/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove onboot, delay, forward_delay from setupNetworks API
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove onboot, delay, forward_delay from setupNetworks API .. Remove onboot, delay, forward_delay from setupNetworks API The engine never sends onboot and delay so they are safe to remove. forward_delay is an undocumented API key that was deemed harmful and unneeded and is removed as well. All three keys are now blacklisted and will not be written to ifcfg files if sent via the API. Instead, onboot will always be yes and delay will always be 0. Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2 Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20967 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/configNetwork.py M vdsm/netconf/ifcfg.py M vdsm/netmodels.py M vdsm_api/vdsmapi-schema.json 5 files changed, 10 insertions(+), 27 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f3d35f13e23947c702f3573b6bb83d444356b2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status
Bala.FA has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/19597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
Bala.FA has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/19674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4646/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5446/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5525/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4648/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5527/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 5: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4647/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5447/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5526/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: interpret and use correct xml elements .. Patch Set 6: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5449/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5528/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status
Bala.FA has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 7: This patch is nothing to do with the above jenkins unit test failure -- To view, visit http://gerrit.ovirt.org/19597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: adopt xml changes of rebalance and remove-brick status
Bala.FA has posted comments on this change. Change subject: gluster: adopt xml changes of rebalance and remove-brick status .. Patch Set 7: Please note: this patch sets 'Requires: glusterfs 3.4.2' and glusterfs 3.4.2 is not available yet, but respective code is available in glusterfs 3.4 release branch. -- To view, visit http://gerrit.ovirt.org/19597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b3031b6eb796b7475bbe533fbdd0366fbaf6aea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Federico Simoncelli has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 17: (4 comments) Nice. Few minor questions. File lib/vdsm/tool/lvm_deactivate_lvs.py Line 36: Line 37: if _was_run(): Line 38: _log(already run) Line 39: return 0 Line 40: _set_was_run() What was the conclusion about this? It shouldn't be moved after deactivation? Line 41: for vg in _iter_vdsm_vgs(): Line 42: _deactivate_lvs(vg) Line 43: _log(deactivated lvs) Line 44: return 0 Line 56: def _log(msg): Line 57: sys.stderr.write(%s\n % (msg,)) Line 58: Line 59: Line 60: def _iter_vdsm_vgs(): I have the feeling that you can get rid of this entirely, check comment at line ~74. Line 61: rc, out, err = _run_lvm([vgs, --noheading, --separator, Line 62: _SEPARATOR, -o, name,tags]) Line 63: if rc != 0: Line 64: raise RuntimeError(Error finding vgs: %s % err) Line 70: Line 71: Line 72: def _iter_active_lvs(vg): Line 73: rc, out, err = _run_lvm([lvs, --noheading, --separator, Line 74: _SEPARATOR, -o, name,attr, vg]) I think that using: lvs @RHAT_storage_domain (plus the other required options) would do. I'm not sure if you can specify somehow also the MDT_TYPE=FCP. But we probably don't care so much about that one. Line 75: if rc != 0: Line 76: raise RuntimeError(Error finding lvs: %s % err) Line 77: for line in out.splitlines(): Line 78: line = line.strip() Line 103: def _deactivate_lvs(vg): Line 104: cmd = [vgchange, --available, n, vg] Line 105: rc, out, err = _run_lvm(cmd) Line 106: if rc != 0: Line 107: # Probbaly there are open lvs. lvm does not gives us any way to detect Typo Line 108: # error type. Line 109: cmd = [lvchange, --available, n] Line 110: cmd.extend(%s/%s % (vg, lv) for lv in _iter_active_lvs(vg)) Line 111: rc, out, err = _run_lvm(cmd) -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol, added unit tests
Dan Kenigsberg has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 14: Code-Review-1
(1 comment)
File tests/netinfoTests.py
Line 216: netsDir = os.path.join(tempDir, 'nets')
Line 217: os.mkdir(netsDir)
Line 218: networks = {
Line 219: 'nonVMOverNic':
Line 220: {nic: eth0, bridged: false, bootproto: dhcp},
Shouldn't the running config be filled with real attributes? I mean, the
boolean values True/False, and integral vlan ids?
As it stands, this test serves as a confusing documentation.
Line 221: 'bridgeOverNic':
Line 222: {nic: eth1, bridged: true},
Line 223: 'nonVMOverBond':
Line 224: {bonding: bond0, bridged: false, bootproto:
dhcp},
--
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
Nir Soffer has posted comments on this change. Change subject: fcp: Deactivate vdsm logical volumes .. Patch Set 17: (4 comments) File lib/vdsm/tool/lvm_deactivate_lvs.py Line 36: Line 37: if _was_run(): Line 38: _log(already run) Line 39: return 0 Line 40: _set_was_run() We want to avoid a situation where deactivation fails, we do net set the was run flag, then deactivation fails again on the next run... and so on. Line 41: for vg in _iter_vdsm_vgs(): Line 42: _deactivate_lvs(vg) Line 43: _log(deactivated lvs) Line 44: return 0 Line 56: def _log(msg): Line 57: sys.stderr.write(%s\n % (msg,)) Line 58: Line 59: Line 60: def _iter_vdsm_vgs(): This will work only if run before sanlock opens the ids lv. When running normally, ids lv is always open and vgchange will always fail. Do you know when sanlock is opening the ids lv? Line 61: rc, out, err = _run_lvm([vgs, --noheading, --separator, Line 62: _SEPARATOR, -o, name,tags]) Line 63: if rc != 0: Line 64: raise RuntimeError(Error finding vgs: %s % err) Line 70: Line 71: Line 72: def _iter_active_lvs(vg): Line 73: rc, out, err = _run_lvm([lvs, --noheading, --separator, Line 74: _SEPARATOR, -o, name,attr, vg]) Ayal thinks that we should remove the FCP check, and handle any lv active when it should not. I added check because we have a problem with FC lvs, and I did not want to change stuff which is not broken. Line 75: if rc != 0: Line 76: raise RuntimeError(Error finding lvs: %s % err) Line 77: for line in out.splitlines(): Line 78: line = line.strip() Line 103: def _deactivate_lvs(vg): Line 104: cmd = [vgchange, --available, n, vg] Line 105: rc, out, err = _run_lvm(cmd) Line 106: if rc != 0: Line 107: # Probbaly there are open lvs. lvm does not gives us any way to detect Done Line 108: # error type. Line 109: cmd = [lvchange, --available, n] Line 110: cmd.extend(%s/%s % (vg, lv) for lv in _iter_active_lvs(vg)) Line 111: rc, out, err = _run_lvm(cmd) -- To view, visit http://gerrit.ovirt.org/20720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol, added unit tests
Assaf Muller has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol, added unit tests .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol, added unit tests
Assaf Muller has posted comments on this change.
Change subject: Enhanced netinfo.getBootProtocol, added unit tests
..
Patch Set 14:
(1 comment)
File tests/netinfoTests.py
Line 216: netsDir = os.path.join(tempDir, 'nets')
Line 217: os.mkdir(netsDir)
Line 218: networks = {
Line 219: 'nonVMOverNic':
Line 220: {nic: eth0, bridged: false, bootproto: dhcp},
Done
Line 221: 'bridgeOverNic':
Line 222: {nic: eth1, bridged: true},
Line 223: 'nonVMOverBond':
Line 224: {bonding: bond0, bridged: false, bootproto:
dhcp},
--
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Code-Review-1 Don't merge yet. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 3: Code-Review-1 Please note my comment about vdsm/gluster/hostname.py: you should add the new path to there, too. -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.
mooli tayer has uploaded a new change for review.
Change subject: Avoid calling restorecon on a nonexistent dir.
..
Avoid calling restorecon on a nonexistent dir.
/var/log/core is only created when vdsm service goes up.
If vdsm never ran on the machine we might get:
restorecon: lstat(/var/log/core) failed: No such file or directory
Change-Id: Icd0d14193d9306944649d7ab0ee19edf2ca29ae7
Signed-off-by: Mooli Tayer mta...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/21290/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7730f57..0ad4a46 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -645,7 +645,7 @@
# hack until we replace core dump with abrt
/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
-/sbin/restorecon -R -v /var/log/core
+/sbin/restorecon -R -v /var/log
%if 0%{?rhel}
if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd0d14193d9306944649d7ab0ee19edf2ca29ae7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid calling restorecon on a nonexistent dir. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4652/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5452/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5531/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0d14193d9306944649d7ab0ee19edf2ca29ae7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate and refresh active lvs in bootstrap
Nir Soffer has uploaded a new change for review. Change subject: lvm: deactivate and refresh active lvs in bootstrap .. lvm: deactivate and refresh active lvs in bootstrap Experimental fix for handling auto-activated lvs on FCP storage. Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/lvm.py 2 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/21291/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index a508051..85456a8 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -374,7 +374,7 @@ self.log.warn(Failed to clean Storage Repository., exc_info=True) def storageRefresh(): -lvm._lvminfo.bootstrap() +lvm.bootstrap() sdCache.refreshStorage() fileUtils.createdir(self.tasksDir) diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index f730adc..1d098ae 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -35,6 +35,7 @@ import pprint as pp import threading from itertools import chain +from itertools import groupby from subprocess import list2cmdline from vdsm import constants @@ -650,6 +651,37 @@ _lvminfo = LVMCache() +def bootstrap(): +_lvminfo.bootstrap() + +log.debug(_lvminfo=%s, _lvminfo) + +# Active lvs may use stale meta data, which may lead to data corruption +# sooner or later. This refresh open lvs and deactivate unused lvs. + +activelvs = [(lv.vg_name, lv.opened, lv.name) + for lv in _lvminfo.getAllLvs() if lv.active] +activelvs.sort() + +for (vg, opened), group in groupby(activelvs, lambda val: val[:2]): +if opened: +for _, _, lv in group: +log.warning(Refreshing open lv: vg=%s lv=%s, vg, lv) +try: +refreshLV(vg, lv) +except se.LogicalVolumeRefreshError: +log.error(Error refreshing lv: vg=%s lv=%s, vg, lv) +else: +lvs = [val[2] for val in group] +log.warning(Deactivating unused lvs: vg=%s lvs=%s, vg, lvs) +try: +_setLVAvailability(vg, lvs, n) +except se.CannotDeactivateLogicalVolume: +log.error(Error deactivating lvs: vg=%s lvs=%s, vg, lvs) +# Some lvs may be inactive now +_lvminfo._invalidatelvs(vg, lvs) + + def invalidateCache(): _lvminfo.invalidateCache() -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate and refresh active lvs in bootstrap
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: deactivate and refresh active lvs in bootstrap .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5453/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5532/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate and refresh active lvs in bootstrap
Nir Soffer has posted comments on this change. Change subject: lvm: deactivate and refresh active lvs in bootstrap .. Patch Set 1: Alternative fix for http://gerrit.ovirt.org/#/c/20720/. Previously I tried to avoid touching the application for what looked like a temporary hack. Now that we understand that we need lot of the application logic, I moved the fix to lvm modle. Turns out that existing application logic makes the implementation much easier, and it even works on my host. Did not add yet the run-once check, not sure if we want it. Did not have time for proper commit message, will take most of that from 20720 later. -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Avoid calling restorecon on a nonexistent dir.
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Line 643: /etc/sysctl.conf
Line 644: fi
Line 645:
Line 646: # hack until we replace core dump with abrt
Line 647: /usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
semanage won't complain as well?
Line 648: /sbin/restorecon -R -v /var/log
Line 649:
Line 650: %if 0%{?rhel}
Line 651: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0d14193d9306944649d7ab0ee19edf2ca29ae7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: interpret and use correct xml elements
Timothy Asir has posted comments on this change.
Change subject: gluster: interpret and use correct xml elements
..
Patch Set 6:
(1 comment)
File vdsm/gluster/cli.py
Line 645: 'filesFailed':
el.find('failures').text,
Line 646: 'filesSkipped':
el.find('skipped').text,
Line 647: 'totalSizeMoved':
el.find('size').text,
Line 648: 'status': statusStr.upper()})
Line 649:
Remove this extra blank line
Line 650:
Line 651: return status
Line 652:
Line 653:
--
To view, visit http://gerrit.ovirt.org/19674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b90283ac2b9f4b54acfccffa02a30e38e5e9d85
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
