Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()
Nir Soffer has posted comments on this change. Change subject: storage: get currImgDir correctly in fileSD.deleteImage() .. Patch Set 4: (1 comment) Commit Message Line 3: AuthorDate: 2013-12-13 11:11:18 +0800 Line 4: Commit: huntxu Line 5: CommitDate: 2013-12-16 21:18:08 +0800 Line 6: Line 7: storage: get currImgDir correctly in fileSD.deleteImage() How about: fileSD: Fix image deletion on gluster domain Line 8: Line 9: getImagePath() does not work for glusterSD. Now we use the storage Line 10: domain's domaindir to get the image's directory correctly. Line 11: -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Hunt Xu Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set reconfigureOnForce attribute to ModuleConfigurer
Yaniv Bronhaim has posted comments on this change. Change subject: set reconfigureOnForce attribute to ModuleConfigurer .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()
Nir Soffer has posted comments on this change. Change subject: storage: get currImgDir correctly in fileSD.deleteImage() .. Patch Set 4: (1 comment) File vdsm/storage/fileSD.py Line 342: def deleteImage(self, sdUUID, imgUUID, volsImgs): Line 343: if sdUUID == self.sdUUID: Line 344: currImgDir = os.path.join(self.domaindir, 'images', imgUUID) Line 345: else: Line 346: raise se.StorageDomainLayoutError(sdUUID) The sdUUID validation is not related to creating the image path. This check should be done before creating the path: if sdUUID != self.sdUUID: raise ... I'm not sure what should we raise here - looks like caller error to me, there is no storage layout error. Even better, I don't see any reason to call a FileStorageDomain.deleteImage with a sdUUID - domain knows its UUID. This may require fixing some callers, and probably better done in a different patch. deleteImage is not the place for building the path for the image. The proper place for this is FileStorageDomain.getImagePath(imgUUID) method. def getImagePath(self, imgUUID): return os.path.join(self.domaindir, 'images', imgUUID) Finally, do we have constant for "images"? If we don't It would be nice if you add one :-) Line 347: dirName, baseName = os.path.split(currImgDir) Line 348: toDelDir = os.tempnam(dirName, sd.REMOVED_IMAGE_PREFIX + baseName) Line 349: try: Line 350: self.oop.os.rename(currImgDir, toDelDir) -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Hunt Xu Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Disable configuration overwriting if service is configured
Yaniv Bronhaim has abandoned this change. Change subject: Disable configuration overwriting if service is configured .. Abandoned Force flag meant overwriting of old configuration before adding the configurator (ovirt-3.2). although, not all configModules will require to overwrite their config on force. This patch changes the logic of force for all configurers, to avoid general change I submitted http://gerrit.ovirt.org/22492 which found out easier to maintain and to understand. -- To view, visit http://gerrit.ovirt.org/22309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6d5a652b300c9d8165f661840c49a441532e84b1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()
Hunt Xu has posted comments on this change. Change subject: storage: get currImgDir correctly in fileSD.deleteImage() .. Patch Set 4: I've tried both nfs and glusterfs and nothing abnormal observed. The problem is caused by that domaindir's base path of glusterSD and other file-based SD are not the same. For glusterSD, it's sd.storage_repository/mnt/glusterSD/, for other file-based storage domains it's sd.storage_repository/mnt/. However, using the domaindir member should work for all the file-based storage domains. The change from the last patch set is because that I realized that findDomain() is already done when we use sdCache.produce() to get the domain before we actually called this deleteImage() function in hsm.py. So we don't need to find it again. I am not strongly against moving getImagePath() into the FileStorageDomain class. However, since it's a one-liner and it has no other users, I don't see any benefit and thus any necessarity to make it an individual funtion. -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Hunt Xu Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: add --pidfile option in vdsmd.service
Hunt Xu has posted comments on this change. Change subject: init: add --pidfile option in vdsmd.service .. Patch Set 1: (1 comment) The --pidfile option would be parsed as targetOptions in the daemonAdapter script and it's already part of the vdsm script. We use the same way to call daemonAdapter in sysvinit scripts. File init/systemd/vdsmd.service.in Line 8: Type=simple Line 9: LimitCORE=infinity Line 10: EnvironmentFile=-/etc/sysconfig/vdsm Line 11: ExecStartPre=@LIBEXECDIR@/vdsmd_init_common.sh --pre-start Line 12: ExecStart=@VDSMDIR@/daemonAdapter -0 /dev/null -1 /dev/null -2 /dev/null "@VDSMDIR@/vdsm" --pidfile=@VDSMRUNDIR@/vdsmd.pid Did you try that? I doubt whether it works. Because using the option is not telling systemd to create the pidfile automatically thus it won't solve the problem. Line 13: ExecStopPost=@LIBEXECDIR@/vdsmd_init_common.sh --post-stop Line 14: Restart=always Line 15: Nice=-20 Line 16: User=@VDSMUSER@ -- To view, visit http://gerrit.ovirt.org/21222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8c5efd84d3838f54116d493ad7eac36ced68b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Hunt Xu Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add support for Guest Reboot
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1: Code-Review-1
(4 comments)
Commit Message
Line 12: backwards compatibility, the default is False.
Line 13:
Line 14: Current implementation only utilizes the guest agent for reboot and
does
Line 15: nothing in its absence. The semantics of existing shutdown should be
Line 16: unchanged by this patch.
please note that if the guest has an older agent, it would ignore the reboot
flag, and perform a shutdown with no restart.
(I believe that this is the behavior, and it's acceptable to me, but it should
be declared.)
Line 17:
Line 18: Change-Id: Ic117574365fc6f7a0dd6e69ba203b2d82d4cefa1
File vdsm/guestIF.py
Line 302: def desktopShutdown(self, timeout, msg, reboot):
Line 303: try:
Line 304: self.log.debug("desktopShutdown called")
Line 305: self._forward('shutdown', {'timeout': timeout, 'message':
msg,
Line 306:'reboot': str(reboot)})
Does the guest agent really require the string "True"? Why not the boolean,
which seems much cleaner?
Line 307: except:
Line 308: self.log.error("desktopShutdown failed", exc_info=True)
Line 309:
Line 310: def sendHcCmdToDesktop(self, cmd):
File vdsm/vm.py
Line 2519: return errCode['noVM']
Line 2520: if self.guestAgent and self.guestAgent.isResponsive():
Line 2521: self._guestEventTime = now
Line 2522: if reboot:
Line 2523: self._guestEvent = 'Machine rebooting'
I'd like to be sure that Vinzenz is happy with this added reported state.
Line 2524: self.log.debug('guestAgent reboot called')
Line 2525: else:
Line 2526: self._guestEvent = 'Powering down'
Line 2527: self.log.debug('guestAgent shutdown called')
Line 2546: except:
Line 2547: self.log.error("Shutdown failed", exc_info=True)
Line 2548: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2549: 'message': 'Failed to shutdown VM. Try Forced
Shutdown.'}}
Line 2550: message = 'Machine rebooting' if reboot else 'Machine shut
down'
Note: this string appears only in Engine logs, if I am not mistaken. GUI would
show the old text (localized) and should probably be tweaked.
Line 2551: return {'status': {'code': doneCode['code'], 'message':
message}}
Line 2552:
Line 2553: def _timedShutdown(self):
Line 2554: self.log.debug('_timedShutdown Called')
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic117574365fc6f7a0dd6e69ba203b2d82d4cefa1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Betak
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Report fake capabilities
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Report fake capabilities .. Patch Set 7: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/19396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb934eb8aff1ac0ce82ea5d5bd082afce6d9ba50 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Report fake capabilities
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Report fake capabilities .. vdsm: Report fake capabilities This patch introduces a 'fake KVM on PPC64' mode, adding a configuration parameter indicating to VDSM if it must report fake capabilities, so a x86_64 host could be used to validate PPC64-specific code. Change-Id: Ifb934eb8aff1ac0ce82ea5d5bd082afce6d9ba50 Signed-off-by: Vitor de Lima Reviewed-on: http://gerrit.ovirt.org/19396 Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M lib/vdsm/config.py.in M vdsm/caps.py 2 files changed, 24 insertions(+), 7 deletions(-) Approvals: Vitor de Lima: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb934eb8aff1ac0ce82ea5d5bd082afce6d9ba50 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Dan Kenigsberg has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: I am a bit reluctant about the patch in its current form. It is important to keep the helper processes lean, but I do not quite understand what is the charter of the new "host.py" module. Does it have any definition beyond "the part of caps which oop needs"? Its name is too general, too. I feel uncomfortable saying this, given the extraordinary outcome of my ae7fbc6d4f2. Still, I'd like to understand the planned boundary between host.py and caps.py. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: consolidate getMasterVersion in one method
Ayal Baron has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 4:
(1 comment)
File vdsm/storage/sp.py
Line 1503: self.log.error("Requested master domain %s does not
belong to pool"
Line 1504:" %s", msdUUID, self.spUUID)
Line 1505: raise se.StoragePoolWrongMaster(self.spUUID, msdUUID)
Line 1506:
Line 1507: version = self.getMasterVersion(useMasterDomain=domain)
optionally passing the domain in this call is really bugging me and it made me
think whether this version check shouldn't actually be moved into
domain.isMaster.
e.g.
if not domain.isMaster(expectedVersion = masterVersion):
self.log.error("Requested domain %s is not marked as a master domain or its
version is wrong", msdUUID).
If you think about it, master domain is a combination of role and version so I
think this makes sense.
Line 1508: if version != int(masterVersion):
Line 1509: self.log.error("Requested master domain %s does not have
expected "
Line 1510:"version %s it is version %s",
Line 1511:msdUUID, masterVersion, version)
--
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Vered Volansky
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6137/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5350/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6240/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/145/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 2: (1 comment) File lib/vdsm/tool/ovirt-node-registration.py Line 28: Line 29: if sys.version_info >= (3, 0): Line 30: import http.client as httplib Line 31: else: Line 32: import httplib as httplib No need of this as http, only import httplib. Line 33: Line 34: import tempfile Line 35: import urllib Line 36: import urllib2 -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6135/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5348/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6238/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/143/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting force to true overwrites the configuration in libvir...
Yaniv Bronhaim has posted comments on this change. Change subject: Setting force to true overwrites the configuration in libvirt configurer .. Patch Set 1: (1 comment) File lib/vdsm/tool/configurator.py Line 43: Line 44: def configure(self): Line 45: pass Line 46: Line 47: def isconfigured(self, force): having : for c in modules: if force: if c.isconfigureOnForce ... elif c.isconfigured().. is less spaghetti? I find it the same Line 48: return True Line 49: Line 50: Line 51: class LibvirtModuleConfigure(_ModuleConfigure): -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-tool: add node registration tool
..
vdsm-tool: add node registration tool
ovirt-node-registration.py is a tool to register a node into engine.
New new verb 'register' does a http request to register a node into engine.
Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c
Signed-off-by: Douglas Schilling Landgraf
---
M debian/vdsm-python.install
M lib/vdsm/tool/Makefile.am
A lib/vdsm/tool/ovirt-node-registration.py
M vdsm.spec.in
4 files changed, 417 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/22494/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 5ff4848..e3c64ac 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -16,6 +16,7 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/configurator.py
./usr/lib/python2.7/dist-packages/vdsm/tool/load_needed_modules.py
./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py
+./usr/lib/python2.7/dist-packages/vdsm/tool/ovirt-node-registration.py
./usr/lib/python2.7/dist-packages/vdsm/tool/passwd.py
./usr/lib/python2.7/dist-packages/vdsm/tool/restore_nets.py
./usr/lib/python2.7/dist-packages/vdsm/tool/seboolsetup.py
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index 0198310..0a26879 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -39,6 +39,7 @@
dummybr.py \
nwfilter.py \
configurator.py \
+ ovirt-node-registration.py \
passwd.py \
restore_nets.py \
seboolsetup.py \
diff --git a/lib/vdsm/tool/ovirt-node-registration.py
b/lib/vdsm/tool/ovirt-node-registration.py
new file mode 100644
index 000..9dbd5d5
--- /dev/null
+++ b/lib/vdsm/tool/ovirt-node-registration.py
@@ -0,0 +1,414 @@
+# Copyright (C) 2012-2013 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301, USA. A copy of the GNU General Public License is
+# also available at http://www.gnu.org/copyleft/gpl.html.
+
+import argparse
+import datetime
+import glob
+import logging
+import os
+import pwd
+import re
+import socket
+import ssl
+import sys
+
+if sys.version_info >= (3, 0):
+import http.client as httplib
+else:
+import httplib as httplib
+
+import tempfile
+import urllib
+import urllib2
+import urlparse
+
+import M2Crypto
+import selinux
+
+from . import expose
+
+try:
+from ovirtnode.ovirtfunctions import ovirt_store_config, \
+ovirt_safe_delete_config
+except ImportError:
+# Script should continue in case of a non oVirt Node distro
+pass
+
+from vdsm.ipwrapper import routeGet, Route
+from vdsm.utils import getHostUUID
+
+
+def silent_restorecon(path):
+"""Execute selinux restorecon cmd to determined file
+
+Args
+path -- full path to file
+"""
+
+try:
+if selinux.is_selinux_enabled():
+selinux.restorecon(path)
+except:
+logging.error("restorecon %s failed" % path)
+
+
+def register_node(
+url,
+node_hostname,
+node_management_address,
+node_management_port,
+node_uuid
+):
+"""Register a node to oVirt Engine
+
+Args
+url -- Engine url
+node_hostname -- Hostname to be registered
+node_management_address -- IP address of node to be registered
+node_management_port -- Communication port between node and engine
+node_uuid -- uuid of node
+
+Returns
+True (registered) or False
+"""
+ret = False
+
+params = {
+'vds_ip': node_management_address,
+'vds_name': node_hostname,
+'vds_unique_id': node_uuid,
+'port': node_management_port,
+}
+
+_ENGINE_REG_URIS = (
+'/OvirtEngineWeb/register',
+'/RHEVManagerWeb/VdsAutoRegistration.aspx'
+)
+for uri in _ENGINE_REG_URIS:
+engine_uri = uri + '?' + urllib.urlencode(params)
+reg_url = url + engine_uri
+
+try:
+logging.info("Trying to register with: %s" % reg_url)
+res = urllib2.urlopen(reg_url)
+if res.getcode() == httplib.OK:
+ret = True
+break
+except urllib2.URLError, e:
+logging.info("status: %s code: %s" % (e.reason, e.code))
+if e.code == htt
Change in vdsm[master]: set reconfigureOnForce attribute to ModuleConfigurer
oVirt Jenkins CI Server has posted comments on this change. Change subject: set reconfigureOnForce attribute to ModuleConfigurer .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6140/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5353/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6243/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 1: (1 comment) File lib/vdsm/tool/ovirt-node-registration.py Line 45: from ovirtnode.ovirtfunctions import ovirt_store_config, \ Line 46: ovirt_safe_delete_config Line 47: except ImportError: Line 48: # Script should continue in case of a non oVirt Node distro Line 49: pass removing this space... Line 50: Line 51: from vdsm.ipwrapper import routeGet, Route Line 52: from vdsm.utils import getHostUUID Line 53: -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6138/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5351/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/146/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Failure unrelated to patch. libvirtError: authentication failed: polkit: polkit\56retains_authorization_after_challenge=1 -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 2: On pyflakes-0.4.0-2.el6.noarch I see the error that jenkins is complaining on pyflakes-0.7.2-1.fc19.noarch it's gone. -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set reconfigureOnForce attribute to ModuleConfigurer
oVirt Jenkins CI Server has posted comments on this change. Change subject: set reconfigureOnForce attribute to ModuleConfigurer .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6139/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5352/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6242/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set reconfigureOnForce attribute to ModuleConfigurer
Alon Bar-Lev has posted comments on this change. Change subject: set reconfigureOnForce attribute to ModuleConfigurer .. Patch Set 2: (2 comments) File lib/vdsm/tool/configurator.py Line 47: def isconfigured(self): Line 48: return True Line 49: Line 50: def reconfigureOnForce(self): Line 51: return False I think that default should be True only special cases it is false. Line 52: Line 53: Line 54: class LibvirtModuleConfigure(_ModuleConfigure): Line 55: def __init__(self): Line 178: return ret Line 179: Line 180: def reconfigureOnForce(self): Line 181: return False Line 182: no need to override base if same Line 183: Line 184: __configurers = ( Line 185: LibvirtModuleConfigure(), Line 186: SanlockModuleConfigure(), -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting force to true overwrites the configuration in libvir...
Alon Bar-Lev has posted comments on this change. Change subject: Setting force to true overwrites the configuration in libvirt configurer .. Patch Set 1: (1 comment) File lib/vdsm/tool/configurator.py Line 43: Line 44: def configure(self): Line 45: pass Line 46: Line 47: def isconfigured(self, force): return at middle is. for c in modules: if (force and c.reconfigureOnForce) or not c.isconfigured(): configurer_to_trigger.append(c) --- at base def reconfigureOnForce(self): return True at sanlock: def reconfigureOnForce(self): return False Line 48: return True Line 49: Line 50: Line 51: class LibvirtModuleConfigure(_ModuleConfigure): -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: add node registration tool .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6136/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5349/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/144/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add node registration tool
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 4:
(4 comments)
File lib/vdsm/tool/ovirt-node-registration.py
Line 124: break
Line 125: return ret
Line 126:
Line 127:
Line 128: def get_remote_public_ssh_key(url):
private with _
Line 129: """Get public key from determined url
Line 130:
Line 131: Args
Line 132: url -- URL to download the ssh key
Line 272: help='Add ovirt engine public ssh key to node authorized
keys',
Line 273: )
Line 274:
Line 275: parser.add_argument(
Line 276: '--enable-log',
without this we don't have output at all? why not to do standard --verbose/-v
which use stdout and stderr for outputs
Line 277: action='store_true',
Line 278: help="Creates a log file during the execution"
Line 279: )
Line 280:
Line 382: node_hostname = socket.gethostname()
Line 383:
Line 384: management_port = args.node_management_port
Line 385: if management_port is None:
Line 386: management_port = 54321
put default constants
Line 387:
Line 388: node_management_address = args.node_management_address
Line 389: if node_management_address is None:
Line 390: route = routeGet([urlparse.urlparse(args.url).hostname])[0]
Line 407: management_port
Line 408: )
Line 409: )
Line 410: else:
Line 411: raise RuntimeError('Cannot complete the registration')
should return True on success
Line 412:
Line 413: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/22494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: configNetwork: Fix bridgeless broken network deletion
Yaniv Bronhaim has posted comments on this change. Change subject: configNetwork: Fix bridgeless broken network deletion .. Patch Set 3: Verified-1 the bug doesn't have rhevm-3.3 flag on it. do we need it to ovirt-3.3 ? -- To view, visit http://gerrit.ovirt.org/22436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set reconfigureOnForce attribute to ModuleConfigurer
Alon Bar-Lev has posted comments on this change. Change subject: set reconfigureOnForce attribute to ModuleConfigurer .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo.getRouteDeviceTo: return a device name
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo.getRouteDeviceTo: return a device name .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6134/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1041/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6237/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428129cc626c00fd530cec64be2a8c2b9c65e532 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused transaction in createMaster
Adam Litke has posted comments on this change. Change subject: sp: remove unused transaction in createMaster .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: _refreshDomainLinks must not change the metadata
Adam Litke has posted comments on this change. Change subject: sp: _refreshDomainLinks must not change the metadata .. Patch Set 3: Code-Review+1 My review is mainly on code style, comments, etc. I can't verify the correctness of changes wrt correctness. -- To view, visit http://gerrit.ovirt.org/22131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ecf801d58b34c1c811e311e3779887a406af5f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo.getRouteDeviceTo: return a device name
Assaf Muller has posted comments on this change. Change subject: netinfo.getRouteDeviceTo: return a device name .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428129cc626c00fd530cec64be2a8c2b9c65e532 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting force to true overwrites the configuration in libvir...
Alon Bar-Lev has posted comments on this change. Change subject: Setting force to true overwrites the configuration in libvirt configurer .. Patch Set 1: (1 comment) File lib/vdsm/tool/configurator.py Line 43: Line 44: def configure(self): Line 45: pass Line 46: Line 47: def isconfigured(self, force): why not add a new method? something like reconfigureIfForce? this will reduce the spaghetti return at middle and be more clear. Line 48: return True Line 49: Line 50: Line 51: class LibvirtModuleConfigure(_ModuleConfigure): -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting force to true overwrites the configuration in libvir...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Setting force to true overwrites the configuration in libvirt configurer .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5346/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6236/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Disable configuration overwriting if service is configured
Yaniv Bronhaim has posted comments on this change. Change subject: Disable configuration overwriting if service is configured .. Patch Set 3: the other way around sounds more right to me - specific meaning for force in libvirt configure -> http://gerrit.ovirt.org/22492 -- To view, visit http://gerrit.ovirt.org/22309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d5a652b300c9d8165f661840c49a441532e84b1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting force to true overwrites the configuration in libvir...
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Setting force to true overwrites the configuration in libvirt
configurer
..
Setting force to true overwrites the configuration in libvirt configurer
This patch adds force flag to isconfigured verb to allow different return
value of isconfigured force is required. In libvirt configure with force we
will overwrite the configuration to keep the old semantic, although in
sanlock configurer rerun of configure is not required also if force is
set.
This sanlock reconfigure caused a failure during host deploy while trying to
stop sanlock service that was already configured.
Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1035847
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/tool/configurator.py
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/22492/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 869d774..4419536 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -44,7 +44,7 @@
def configure(self):
pass
-def isconfigured(self):
+def isconfigured(self, force):
return True
@@ -93,11 +93,16 @@
except RuntimeError:
return False
-def isconfigured(self):
+def isconfigured(self, force):
"""
Check if libvirt is already configured for vdsm
+
+if force set configure needs to run libvirt configure also if
+already configured. The result of isconfigured will be False
"""
try:
+if force:
+return False
self._exec_libvirt_configure("check_if_configured")
return True
except RuntimeError:
@@ -136,10 +141,12 @@
if rc != 0:
raise RuntimeError("Failed to perform sanlock config.")
-def isconfigured(self, *args):
+def isconfigured(self, force):
"""
True if sanlock service is configured, False if sanlock service
requires a restart to reload the relevant supplementary groups.
+
+force value currently doesn't change the result
"""
ret = False
try:
@@ -191,7 +198,7 @@
raise RuntimeError(
"Configuration of %s is invalid" % c.getName()
)
-if args.force or not c.isconfigured():
+if not c.isconfigured(args.force):
configurer_to_trigger.append(c)
services = []
--
To view, visit http://gerrit.ovirt.org/22492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d3984e3cd6b866dcee6e6dc493ba78a34ff56d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add miniaml issciadm tests
Nir Soffer has abandoned this change. Change subject: tests: Add miniaml issciadm tests .. Abandoned Nobody seems interested in this. -- To view, visit http://gerrit.ovirt.org/19856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9ed21408c7b496c384053ce02cdb66d47df9a14b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images
Nir Soffer has posted comments on this change. Change subject: clientIF: Teardown volume path only for VDSM images .. Patch Set 5: Code-Review+1 I think it is time to move forward with this patch. -- To view, visit http://gerrit.ovirt.org/21973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Nir Soffer has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: The commit message is totally wrong now, and I'm not sure this it the best way to avoid the unneeded imports. This is here only because Yaniv wanted it back. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images
Nir Soffer has posted comments on this change. Change subject: clientIF: Teardown volume path only for VDSM images .. Patch Set 5: I suggest again to rebase this on http://gerrit.ovirt.org/22370, which simplify the handling of drive object in vm.isVdsmImage. Supporting string and None types can be solve either in isVdsmImage or in teardownVolumePath. Since these types are not compatible with vm.Drive or dict, I don't think we should support them in vm.isVdsmImage. The best way would be to let isVdsmImage raise TypeError when sending str or None, and catch that error in clientIF.teardownVolumePath. -- To view, visit http://gerrit.ovirt.org/21973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6132/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1040/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5345/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/142/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Unify checks for vdsm image
Sergey Gotliv has posted comments on this change. Change subject: vm: Unify checks for vdsm image .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa109a19aeec56f09ed2e6d64dee636c7779d426 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2:
(1 comment)
File vdsm/netconf/ifcfg.py
Line 612:
Line 613: def addNic(self, nic, **opts):
Line 614: """ Create ifcfg-* file with proper fields for NIC """
Line 615: _netinfo = netinfo.NetInfo()
Line 616: conf = ''
You may notice that you have convinced me: this use case is not such a remote
edge case. Thanks.
Line 617: if _hwaddr_required():
Line 618: hwaddr = (_netinfo.nics[nic.name].get('permhwaddr') or
Line 619: _netinfo.nics[nic.name]['hwaddr'])
Line 620:
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Unify checks for vdsm image
Nir Soffer has posted comments on this change. Change subject: vm: Unify checks for vdsm image .. Patch Set 3: This version remove the drive['device'] == 'disk' change. This check seems to be unneeded and wrong, and will be handled in another patch. This also fix the conflict with patch http://gerrit.ovirt.org/22363. -- To view, visit http://gerrit.ovirt.org/22370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa109a19aeec56f09ed2e6d64dee636c7779d426 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Unify checks for vdsm image
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Unify checks for vdsm image .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6234/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa109a19aeec56f09ed2e6d64dee636c7779d426 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: encapsulate spm status in StoragePool
Federico Simoncelli has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool .. Patch Set 8: Verified+1 Verified with starting and stopping the SPM (lver is incremented) and with getSpmStatus (correct values). -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: encapsulate spm status in StoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6130/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6233/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2:
(1 comment)
File vdsm/netconf/ifcfg.py
Line 612:
Line 613: def addNic(self, nic, **opts):
Line 614: """ Create ifcfg-* file with proper fields for NIC """
Line 615: _netinfo = netinfo.NetInfo()
Line 616: conf = ''
I do not care about this edge case. I'll add a clearer warning about it in the
commit message.
Line 617: if _hwaddr_required():
Line 618: hwaddr = (_netinfo.nics[nic.name].get('permhwaddr') or
Line 619: _netinfo.nics[nic.name]['hwaddr'])
Line 620:
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
Ayal Baron has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 1:
(6 comments)
File vdsm/storage/sp.py
Line 879: curmsd = sdCache.produce(sdUUID)
Line 880: newmsd = sdCache.produce(msdUUID)
Line 881: self._refreshDomainLinks(newmsd)
Line 882: curmsd.invalidateMetadata()
Line 883: self._convertDomain(newmsd, curmsd.getFormat())
is it ok to call convertDomain before acquiring the lease?
Line 884: self._copyLeaseParameters(curmsd, newmsd)
Line 885:
Line 886: # new 'master' should be in 'active' status
Line 887: domList = self.getDomains()
Line 880: newmsd = sdCache.produce(msdUUID)
Line 881: self._refreshDomainLinks(newmsd)
Line 882: curmsd.invalidateMetadata()
Line 883: self._convertDomain(newmsd, curmsd.getFormat())
Line 884: self._copyLeaseParameters(curmsd, newmsd)
doesn't switch master cover this?
Line 885:
Line 886: # new 'master' should be in 'active' status
Line 887: domList = self.getDomains()
Line 888: if msdUUID not in domList:
Line 893: raise se.StorageDomainNotActive(msdUUID)
Line 894: if newmsd.isISO():
Line 895: raise se.IsoCannotBeMasterDomain(msdUUID)
Line 896: if newmsd.isBackup():
Line 897: raise se.BackupCannotBeMasterDomain(msdUUID)
shouldn't we perform all of these checks *before* alling _convertDomain,
copyLeaseParameters, etc?
Line 898:
Line 899: # If the new master domain is using safelease (version < 3)
then
Line 900: # we can speed up the cluster lock acquirement by resetting
the
Line 901: # SPM lease.
Line 927: src = os.path.join(curmsd.domaindir, sd.MASTER_FS_DIR)
Line 928: dst = os.path.join(newmsd.domaindir, sd.MASTER_FS_DIR)
Line 929: fileUtils.tarCopy(src, dst, exclude=('./lost+found',))
Line 930:
Line 931: if not newmsd.getMDPath():
shouldn't this check be performed before call to mountMaster, together with all
the above validations? (before any change actually)
Line 932: raise se.StorageDomainLayoutError("domain", msdUUID)
Line 933:
Line 934: newmsd.changeRole(sd.MASTER_DOMAIN)
Line 935: self.switchMasterDomain(curmsd, newmsd, masterVersion)
Line 932: raise se.StorageDomainLayoutError("domain", msdUUID)
Line 933:
Line 934: newmsd.changeRole(sd.MASTER_DOMAIN)
Line 935: self.switchMasterDomain(curmsd, newmsd, masterVersion)
Line 936: except Exception:
no finally with release?
Line 937: self.log.exception('migration to new master failed')
Line 938: try:
Line 939: newmsd.unmountMaster()
Line 940: except: # logging only
Line 944: raise
Line 945:
Line 946: # From this point on we have a new master and should not fail
Line 947: try:
Line 948: self.refresh(msdUUID, masterVersion)
move all code within try...except into a separate method? (same thing above)
Line 949: self._saveReconnectInformation(
Line 950: self.id, self.scsiKey, newmsd.sdUUID, masterVersion)
Line 951:
Line 952: # From this point on there is a new master domain in the
pool
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Forbid bare except:
Nir Soffer has posted comments on this change. Change subject: build: Forbid bare except: .. Patch Set 3: Sagi: we can add smarter check, for example, parse git show output to detect the edited file, and apply this rule only to python files. But I don't think it worth the time. Yaniv: we set the rules of this project, not pep8 gods :-) -- To view, visit http://gerrit.ovirt.org/22456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add simple mocking library
Nir Soffer has abandoned this change. Change subject: tests: Add simple mocking library .. Abandoned Lets go in way Saggi suggests. This may require more code but it has some technical advantages, and it will keep Saggi happier :-) If anyone like to continue with this patch, feel free to take it. Anyway, I think for the long term, we better use an existing library instead of maintaining our own. -- To view, visit http://gerrit.ovirt.org/21155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: consolidate getMasterVersion in one method
Adam Litke has posted comments on this change. Change subject: sp: consolidate getMasterVersion in one method .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove automatic storage pool reconnection
Ayal Baron has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove automatic storage pool reconnection
Federico Simoncelli has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 11: Verified+1 connectStoragePool is successful and there's no automatic storage pool reconnection (just as before). -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove automatic storage pool reconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6129/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5342/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/141/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused transaction in createMaster
Vered Volansky has posted comments on this change. Change subject: sp: remove unused transaction in createMaster .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove automatic storage pool reconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6128/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5341/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6231/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove automatic storage pool reconnection
Federico Simoncelli has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 9: (1 comment) File vdsm/storage/sp.py Line 681 Line 682 Line 683 Line 684 Line 685 Remove this. -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: add --pidfile option in vdsmd.service
Yaniv Bronhaim has posted comments on this change. Change subject: init: add --pidfile option in vdsmd.service .. Patch Set 1: (1 comment) File init/systemd/vdsmd.service.in Line 8: Type=simple Line 9: LimitCORE=infinity Line 10: EnvironmentFile=-/etc/sysconfig/vdsm Line 11: ExecStartPre=@LIBEXECDIR@/vdsmd_init_common.sh --pre-start Line 12: ExecStart=@VDSMDIR@/daemonAdapter -0 /dev/null -1 /dev/null -2 /dev/null "@VDSMDIR@/vdsm" --pidfile=@VDSMRUNDIR@/vdsmd.pid why not to use PIDFile option: http://www.freedesktop.org/software/systemd/man/systemd.service.html Line 13: ExecStopPost=@LIBEXECDIR@/vdsmd_init_common.sh --post-stop Line 14: Restart=always Line 15: Nice=-20 Line 16: User=@VDSMUSER@ -- To view, visit http://gerrit.ovirt.org/21222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8c5efd84d3838f54116d493ad7eac36ced68b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Handling topology for ppc64 .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6127/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5340/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/140/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: add --pidfile option in vdsmd.service
Yaniv Bronhaim has posted comments on this change. Change subject: init: add --pidfile option in vdsmd.service .. Patch Set 1: Code-Review-1 we don't have --pidfile option as part of daemonAdapter, it needs to follow a patch that adds it or abandoned till full solution -- To view, visit http://gerrit.ovirt.org/21222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8c5efd84d3838f54116d493ad7eac36ced68b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8:
(2 comments)
File vdsm/ppc64HardwareInfo.py
Line 55: def getCpuTopology(capabilities):
Line 56: topology = {}
Line 57:
Line 58: if capabilities is None:
Line 59: retcode, out, err = utils.execCmd(['lscpu'], raw=True)
Ok, I will fix it soon.
Line 60: capabilities = out
Line 61:
Line 62: corePS = None
Line 63: threadsPC = None
Line 74: threadsPC = int(value)
Line 75: elif key == 'Core(s) per socket':
Line 76: corePS = int(value)
Line 77:
Line 78: if (corePS is not None
Done
Line 79: and threadsPC is not None
Line 80: and sockets is not None):
Line 81: topology['sockets'] = sockets
Line 82: topology['cores'] = corePS * sockets
--
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
Gerrit-Reviewer: Leonardo Bianconi
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: _refreshDomainLinks must not change the metadata
Vered Volansky has posted comments on this change. Change subject: sp: _refreshDomainLinks must not change the metadata .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ecf801d58b34c1c811e311e3779887a406af5f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove automatic storage pool reconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove automatic storage pool reconnection .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6126/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6229/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6125/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6228/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool
Federico Simoncelli has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 2: Verified+1 Verified running connectStoragePool on an already connected pool. -- To view, visit http://gerrit.ovirt.org/22467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8:
(1 comment)
File vdsm/ppc64HardwareInfo.py
Line 55: def getCpuTopology(capabilities):
Line 56: topology = {}
Line 57:
Line 58: if capabilities is None:
Line 59: retcode, out, err = utils.execCmd(['lscpu'], raw=True)
you don't reuse the code, you put it only here. puting it in external method
gave the possibility to reuse it. in it call you "retcode, out, err =
utils.execCmd(['lscpu'], raw=True)" and return out if there are no errors to
handle
Line 60: capabilities = out
Line 61:
Line 62: corePS = None
Line 63: threadsPC = None
--
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
Gerrit-Reviewer: Leonardo Bianconi
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade.log now owned by vdsm:kvm
Yaniv Bronhaim has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4: Code-Review+1
(1 comment)
File lib/vdsm/tool/upgrade.py
Line 61: disable_existing_loggers=False)
Line 62: chown(
Line 63: os.path.join(P_VDSM_LOG, 'upgrade.log'),
Line 64: VDSM_USER,
Line 65: VDSM_GROUP)
i know and i agree, just advised to have the if root condition
Line 66: except Exception:
Line 67:
logging.getLogger('upgrade').addHandler(SysLogHandler('/dev/log'))
Line 68: logging.exception("Could not init proper logging")
Line 69: finally:
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool
Sergey Gotliv has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add simple mocking library
Saggi Mizrahi has posted comments on this change. Change subject: tests: Add simple mocking library .. Patch Set 1: > It does need testing, the file is a black box for us as you > said previously. We can change the implementation, but the > call to lvm with those parameters *is* our interface. If you declare an interface like that you're interface is wrong. It's like defining a function sum that says "adds 2 numbers using the operator +". You never do that you just say: "a function that returns the sum of 2 numbers" You don't check how it does that. You just check that the sum is correct. To reiterate. I don't say mocking is bad. I'm saying 2 things. 1. You can't use mocking for a wrapper method. If I have a method that wraps LVM calls I can't test it with mocked objects since what you want to make sure is that the wrapper actually works. If you want to test the parsing the simple way is to split the parsing to it's own method that is defined by how it interacts with text in the format that is returned by the tool. That way you don't break semantics and you don't need to use mock objects. If the output changes it is clear that we need a new function or that the actual semantic of the parsing function has to change. If we move to using something that doesn't require parsing the parsing method and it's tests can just be removed. This makes the whole process simple and straight forward. 2. mock objects in the vain of what you library offers are needlessly confusing. In python it's easy to make mock objects. instead of using a custom syntax for defining a method like: x = mock.callabale().expect(...).returns(...) You can do: def x(...): return... function definition contain all the bits that you mock objects give you just in a different, more standard, syntax. It's simpler, cleared and more concise to use functions and lambdas to achieve the same effect. --- Tests should never break if the function interface was not broken. > Mock are programmable - the logic of which answer to > return is in the test. You don't need to write new > class for each test to simulate the specific flow. Functions and classes are programmable as well. In python, writing a class is not that bad. That goes back to my original argument about how a mock library is relevant for boilerplate heavy languages like Java\C#. -- To get back to your example. Lets take this test (http://gerrit.ovirt.org/#/c/20720/17/tests/toolLvmDeactivateLvsTests.py line:36) The only bit of actual code you test is: lvm_deactivate_lvs.lvm_deactivate_lvs() But you mock execCmd. WY down the stack. You should have mocked. _iter_vdsm_vgs() and _deactivate_lvs() Since the purpose of mocking is so that bugs in dependent code don't interfere with you testing. So what you could have done is _iter_vdsm_vgs = lambda : (vg for vg in ["a", "b", "c"] _deactivate_lvs = lambda a : pass Since you don't want errors\bugs\changes in dependent methods that don't effect the interface to break tests. again, the actual intention of mocking. As for _was_run() and _set_was_run(), this is a good example for trying to check for side effects. A correct mock object wouldn't have used a canned response. It would have used methods that actually depend on each other like the real _set_was_run() and _was_run() since what you are mocking is the "was_run" mechanism. I would have declared a bool in the method and made mock methods that change this bool instead of writing to a file. This way I actually mock the object. I can even declare the fake was_run method in the module itself and use them whenever needed. These would have made your test simpler to execute understand and would have used proper mocking. As the test stands it contains needless lvm arguments and output which is confusing and completely unrelated to what you are testing. -- To view, visit http://gerrit.ovirt.org/21155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8: -Verified
(1 comment)
File vdsm/ppc64HardwareInfo.py
Line 55: def getCpuTopology(capabilities):
Line 56: topology = {}
Line 57:
Line 58: if capabilities is None:
Line 59: retcode, out, err = utils.execCmd(['lscpu'], raw=True)
The getLsCpu() did exactly the same thing as the utils.execCmd(...), so I
thought it would be a good idea to reuse this code.
Line 60: capabilities = out
Line 61:
Line 62: corePS = None
Line 63: threadsPC = None
--
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
Gerrit-Reviewer: Leonardo Bianconi
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: refresh pool connection on connectStoragePool .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6124/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6227/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8:
(2 comments)
File vdsm/ppc64HardwareInfo.py
Line 55: def getCpuTopology(capabilities):
Line 56: topology = {}
Line 57:
Line 58: if capabilities is None:
Line 59: retcode, out, err = utils.execCmd(['lscpu'], raw=True)
why did you remove the getLsCpu() ? i preferred as it was, just recommended to
put it in utils.py
Line 60: capabilities = out
Line 61:
Line 62: corePS = None
Line 63: threadsPC = None
Line 74: threadsPC = int(value)
Line 75: elif key == 'Core(s) per socket':
Line 76: corePS = int(value)
Line 77:
Line 78: if (corePS is not None
just put-> if corePS and threadPC and socket: ...
Line 79: and threadsPC is not None
Line 80: and sockets is not None):
Line 81: topology['sockets'] = sockets
Line 82: topology['cores'] = corePS * sockets
--
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
Gerrit-Reviewer: Leonardo Bianconi
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: consolidate getMasterVersion in one method
Vered Volansky has posted comments on this change. Change subject: sp: consolidate getMasterVersion in one method .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool
Federico Simoncelli has uploaded a new change for review. Change subject: hsm: refresh pool connection on connectStoragePool .. hsm: refresh pool connection on connectStoragePool This patch ensures that connectStoragePool would trigger a refresh when the host is already connected to the same pool. Using connectStoragePool instead of refreshStoragePool is at the base of the storage pool metadata removal but it also solves an existing problem in the non-operational recovery flow where the engine sends a connectStoragePool request. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026697 Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Signed-off-by: Federico Simoncelli --- M vdsm/storage/hsm.py 1 file changed, 13 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/22467/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 622065e..7a66ab6 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1013,6 +1013,14 @@ return self._connectStoragePool(spUUID, hostID, scsiKey, msdUUID, masterVersion, options) +@staticmethod +def _updateStoragePool(pool, hostId, msdUUID, masterVersion): +if hostId != pool.id: +raise se.StoragePoolConnected( +"hostId=%s, newHostId=%s" % (pool.id, hostId)) + +pool.refresh(msdUUID, masterVersion) + def _connectStoragePool(self, spUUID, hostID, scsiKey, msdUUID, masterVersion, options=None): misc.validateUUID(spUUID, 'spUUID') @@ -1028,17 +1036,9 @@ pass # pool not connected yet else: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared): -pool = self.getPool(spUUID) -if not msdUUID or not masterVersion: -hostID, scsiKey, msdUUID, masterVersion = \ -pool.getPoolParams() -misc.validateN(hostID, 'hostID') -# getMasterDomain is called because produce is required here -# since the master domain can be changed by the SPM if it is -# the refreshPool flow. -pool.getMasterDomain(msdUUID=msdUUID, - masterVersion=masterVersion) -return +self._updateStoragePool(self.getPool(spUUID), msdUUID, +masterVersion) +return True with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive): try: @@ -1046,14 +1046,8 @@ except se.StoragePoolUnknown: pass # pool not connected yet else: -if not msdUUID or not masterVersion: -hostID, scsiKey, msdUUID, masterVersion = \ -pool.getPoolParams() -misc.validateN(hostID, 'hostID') -# Idem. See above. -pool.getMasterDomain(msdUUID=msdUUID, - masterVersion=masterVersion) -return +self._updateStoragePool(pool, msdUUID, masterVersion) +return True pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) if not hostID or not scsiKey or not msdUUID or not masterVersion: -- To view, visit http://gerrit.ovirt.org/22467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade.log now owned by vdsm:kvm
Assaf Muller has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4:
(1 comment)
File lib/vdsm/tool/upgrade.py
Line 61: disable_existing_loggers=False)
Line 62: chown(
Line 63: os.path.join(P_VDSM_LOG, 'upgrade.log'),
Line 64: VDSM_USER,
Line 65: VDSM_GROUP)
Running chown with the current user's context solves the issue, assuming
upgrade.log doesn't already exist on the system (Which it won't on deployments
that don't use nightly):
1) If VDSM boots up and runs the upgrade as a prestart task, then upgrade.log
will be created as vdsm:kvm anyway
2) If the admin installs VDSM but runs an upgrade manually using vdsm-tool as
root then the chown will succeed and the file will be owned by vdsm from that
point onwards
We can crash and burn only if someone manually messes with the file, which I'm
personally perfectly fine with.
Line 66: except Exception:
Line 67:
logging.getLogger('upgrade').addHandler(SysLogHandler('/dev/log'))
Line 68: logging.exception("Could not init proper logging")
Line 69: finally:
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade.log now owned by vdsm:kvm
Assaf Muller has posted comments on this change. Change subject: upgrade.log now owned by vdsm:kvm .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Forbid bare except:
Yaniv Bronhaim has posted comments on this change. Change subject: build: Forbid bare except: .. Patch Set 3: jenkins job with that is redundant, currently we don't check syntax during the make, that's why we have pep8 and pyflaks running on the py files..if pep8 finds it valid, we also do.. document it as a standard and -1 on it is valid as well, but we can't make it mandatory imo -- To view, visit http://gerrit.ovirt.org/22456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: consolidate getMasterVersion in one method
Maor Lipchuk has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 4: Code-Review+1
(1 comment)
File vdsm/storage/sp.py
Line 835: def masterMigrate(self, sdUUID, msdUUID, masterVersion):
Line 836: self.log.info("sdUUID=%s spUUID=%s msdUUID=%s", sdUUID,
self.spUUID,
Line 837: msdUUID)
Line 838:
Line 839: # TODO: is this check still relevant?
Maybe it's worth to also keep the comment that was in validatePoolMVerHigher
before ("Make sure the masterVersion")
Line 840: if not masterVersion > self.getMasterVersion():
Line 841: raise se.StoragePoolWrongMaster(self.spUUID,
Line 842: self.masterDomain.sdUUID)
Line 843:
--
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()
Vered Volansky has posted comments on this change. Change subject: storage: get currImgDir correctly in fileSD.deleteImage() .. Patch Set 4: -Code-Review Huntxu, did you verify against other-than-gluster Storage Domains? Do we know the removed logic isn't necessary for them? What's the reason for the logic change from the last patch, which seemed just fine logically? Also, why are you against moving getImagePath into FileStorageDomain? It is, after all, the only class using this function. -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Hunt Xu Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade.log now owned by vdsm:kvm
Yaniv Bronhaim has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4:
(1 comment)
File lib/vdsm/tool/upgrade.py
Line 61: disable_existing_loggers=False)
Line 62: chown(
Line 63: os.path.join(P_VDSM_LOG, 'upgrade.log'),
Line 64: VDSM_USER,
Line 65: VDSM_GROUP)
sorry for misleading you, but chown runs in the user's context, so if the log
is already owned by root, vdsm won't be able to chown it. usually all be fine
expect if the log was there owned by root, which I don't see many ways it can
happens.
here you can do that only if you run as root, otherwise its redundant (if
os.getuid() == 0)
Line 66: except Exception:
Line 67:
logging.getLogger('upgrade').addHandler(SysLogHandler('/dev/log'))
Line 68: logging.exception("Could not init proper logging")
Line 69: finally:
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade.log now owned by vdsm:kvm
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade.log now owned by vdsm:kvm .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6123/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6226/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/139/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remoteFileHandler: Remove harmful libvirt dependency
Saggi Mizrahi has posted comments on this change. Change subject: remoteFileHandler: Remove harmful libvirt dependency .. Patch Set 2: Code-Review+1 This is not a problem in remoteFileHandler so I wouldn't label it as such. It's a problem with having a misc module. -- To view, visit http://gerrit.ovirt.org/22316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41205675f88fdf45d0edffe1d1007ab45d174cf5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Forbid bare except:
Saggi Mizrahi has posted comments on this change. Change subject: build: Forbid bare except: .. Patch Set 3: disregarding the fact that creating false positive that breaks the build is extremely easy. Having a documentation file that says: You are allowed to do stuff except: 1. A Would break the build. Also I think you meant to use git diff and not git show. Further more since it only really works for Jenkins it should be a Jenkins job. Having it in the build would only annoy people while they are developing and create weird situations since not all is comitted and sometimes people commit broken code locally. -- To view, visit http://gerrit.ovirt.org/22456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: add support for PCI passthrough
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] vdsm: add support for PCI passthrough .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6122/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6225/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Handling topology for ppc64
Vitor de Lima has posted comments on this change. Change subject: vdsm: Handling topology for ppc64 .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/19875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: add support for PCI passthrough
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsm: add support for PCI passthrough
..
[WIP] vdsm: add support for PCI passthrough
required functionality:
* report PCI devices available on host [x]
* handle createVm xml generation [x]
* hotplugHostdev [ ] (required for after-migration)
* hotpunlugHostdev [ ] (required for migration)
Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Signed-off-by: Martin Polednik
---
M lib/vdsm/define.py
M vdsm/caps.py
M vdsm/vm.py
3 files changed, 83 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/22462/1
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index eb78633..9605f93 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -132,6 +132,12 @@
'transientErr': {'status': {
'code': 59,
'message': 'Action not permitted on a VM with transient disks'}},
+'hotplugHostdev': {'status': {
+'code': 60,
+'message': 'Failed to hotplug hostdev'}},
+'hotunplugHostdev': {'status': {
+'code': 61,
+'message': 'Failed to hotunplug hostdev'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 3839134..d6af375 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -308,6 +308,38 @@
return dict(release=release, version=version, name=osname)
+def hostdevList():
+devices = []
+for device in libvirtconnection.get().listAllDevices():
+devXML = minidom.parseString(device.XMLDesc())
+dev = {}
+
+# we have to grab attributes that will most likely not only
+# uniquely identify device, but also serve as human readable
+# representation of the device
+try:
+dev['name'] = devXML.getElementsByTagName('name')[0].\
+childNodes[0].data
+capability = devXML.getElementsByTagName('capability')[0]
+try:
+dev['product'] = capability.getElementsByTagName('product')[0]\
+.childNodes[0].data
+dev['vendor'] = capability.getElementsByTagName('vendor')[0].\
+childNodes[0].data
+except IndexError:
+# althought the retrieval of product/vendor was not successful,
+# we can still report back the name
+pass
+except IndexError:
+# should device not have a name, there is nothing engine could send
+# back that we could use to uniquely identify and initiate a device
+continue
+
+devices.append(dev)
+
+return devices
+
+
def get():
targetArch = platform.machine()
@@ -360,6 +392,7 @@
config.getint('vars', 'extra_mem_reserve'))
caps['guestOverhead'] = config.get('vars', 'guest_ram_overhead')
caps['rngSources'] = _getRngSources()
+caps['hostDevices'] = hostdevList()
return caps
diff --git a/vdsm/vm.py b/vdsm/vm.py
index a5d923b..a477bc9 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -78,6 +78,7 @@
WATCHDOG_DEVICES = 'watchdog'
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES = 'smartcard'
+HOSTDEV_DEVICES = 'hostdev'
def isVdsmImage(drive):
@@ -1656,6 +1657,27 @@
return m
+class HostDevice(VmDevice):
+def getXML(self):
+"""
+Create domxml for a hostdev device.
+
+
+
+
+
+
+
+
+
+
+"""
+# libvirt gives us direct api call to construct the XML
+return xml.dom.minidom.parseString(libvirtconnection.get().
+ nodeDeviceLookupByName(self.name).
+ XMLDesc())
+
+
class WatchdogDevice(VmDevice):
def __init__(self, *args, **kwargs):
super(WatchdogDevice, self).__init__(*args, **kwargs)
@@ -1769,7 +1791,8 @@
(CONSOLE_DEVICES, ConsoleDevice),
(REDIR_DEVICES, RedirDevice),
(RNG_DEVICES, RngDevice),
- (SMARTCARD_DEVICES, SmartCardDevice))
+ (SMARTCARD_DEVICES, SmartCardDevice),
+ (HOSTDEV_DEVICES, HostDevice))
def _makeDeviceDict(self):
return dict((dev, []) for dev, _ in self.DeviceMapping)
@@ -3127,6 +3150,26 @@
break
+def hotplugHostdev(self, params):
+hostdev = HostDevice(self.conf, self.log, **params)
+self._devices[HOSTDEV_DEVICES].append(hostdev)
+hostdevXML = hostdev.getXML().toprettyxml(encoding='utf-8')
+hostdev._deviceXML = hostdevXML
+self.log.debug("Hotplug hostdev xml: %s", hostdevXML)
+
+try:
+self._dom.attachDevice(hostdevXML)
+except libvirt.libvirtError
Change in vdsm[master]: vdsm: Report fake capabilities
Vitor de Lima has posted comments on this change. Change subject: vdsm: Report fake capabilities .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/19396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb934eb8aff1ac0ce82ea5d5bd082afce6d9ba50 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Forbid bare except:
Antoni Segura Puimedon has posted comments on this change. Change subject: build: Forbid bare except: .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: prepareVolumePath correct path handling for cdrom
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm: prepareVolumePath correct path handling for cdrom
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. vdsm: prepareVolumePath correct path handling for cdrom prepareVolumePath looked for 'path' key in specParams without looking at path in device itself, causing empty path in specParams to override device path. This patch adds device.path to checking mechanism to avoid overriding valid path Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009469 Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Signed-off-by: Martin Polednik Reviewed-on: http://gerrit.ovirt.org/20074 Reviewed-by: Michal Skrivanek Reviewed-by: Federico Simoncelli Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/22324 Reviewed-by: Yaniv Bronhaim Tested-by: Yaniv Bronhaim --- M vdsm/clientIF.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Forbid bare except:
Nir Soffer has posted comments on this change. Change subject: build: Forbid bare except: .. Patch Set 3: Smarten the check so it breaks only when you add forbidden code. -- To view, visit http://gerrit.ovirt.org/22456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Forbid bare except:
oVirt Jenkins CI Server has posted comments on this change. Change subject: build: Forbid bare except: .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6121/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6224/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b7f33b6eb1c90610b3a5d053ba65ce3fc6b74fa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: configNetwork: Fix bridgeless broken network deletion
Yaniv Bronhaim has posted comments on this change. Change subject: configNetwork: Fix bridgeless broken network deletion .. Patch Set 3: Code-Review+2 please take care of ack on https://bugzilla.redhat.com/show_bug.cgi?id=1020356 -- To view, visit http://gerrit.ovirt.org/22436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add support for Guest Reboot
Michal Skrivanek has posted comments on this change. Change subject: vdsm: Add support for Guest Reboot .. Patch Set 1: Code-Review+1 ACPI can trigger a reboot too, but we can keep that for later…no need to change now -- To view, visit http://gerrit.ovirt.org/22440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic117574365fc6f7a0dd6e69ba203b2d82d4cefa1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: avoid masking uuid in StoragePool methods
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: avoid masking uuid in StoragePool methods .. sp: avoid masking uuid in StoragePool methods For some unknown reason during an unrelated refactoring these methods began to trigger pep8 errors related to the uuid variable masking the module with the same name. Change-Id: I4d108e9daa42290c46faa1de3d43e8883487e83c Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/21873 Reviewed-by: Dan Kenigsberg --- M vdsm/storage/sp.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d108e9daa42290c46faa1de3d43e8883487e83c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
