Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
Yaniv Bronhaim has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: please verify on that branch -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: cleanup post-libvirt merge code
Francesco Romani has posted comments on this change. Change subject: vm: cleanup post-libvirt merge code .. Patch Set 3: Verified+1 (1 comment) marking as verified because: * _monitorDependentInit seems never called from anywhere (verified with git grep) * the other change add just comments. http://gerrit.ovirt.org/#/c/24744/3/vdsm/vm.py File vdsm/vm.py: Line 3716: AFAIK this is no longer called anywhere. git grep confirms. -- To view, visit http://gerrit.ovirt.org/24744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG Commit Message: Line 16: methods are used only on Python 2.6. Python 2.7 already include these Line 17: changes. Then the protocol_version is set to HTTP/1.1, enabling Line 18: automatic keep-alive. Line 19: Line 20: A new configuration option "xmlrpc_http11" can be used to disbale this > Configuration options are evil. I'm being over-dramatic, but they put the b Using HTTP/1.1, the server threads are long living, and each thread handle multiple requests (1000's), instead of one. This means that bugs in the old code that were hidden by death of the single thread per request, may be revealed now. If we have such bug, having an option to disable long living threads and means that a user have quick way to fix things, until we fix the real bug. I think this is a more careful way to introduce new features. Line 21: feature and use HTTP/1.0 as used before. Line 22: Line 23: We can see in the logs that only few threads are created now for service Line 24: XMLRPC requests, and most requests are handled by the same thread. -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection
Yaniv Bronhaim has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 5: no need for relates-to title. only one Bug-Url targeted to 3.3 (relates can be shown in the origin bz). and its neither of the attached . please clone the 3.4 bug for that. -- To view, visit http://gerrit.ovirt.org/24822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection
Francesco Romani has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 5: Just cloned the 3.4 bz into https://bugzilla.redhat.com/1069095. Will drop the relates-to. -- To view, visit http://gerrit.ovirt.org/24822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Disable needless and slow dns lookup
Yaniv Bronhaim has posted comments on this change. Change subject: xmlrpc: Disable needless and slow dns lookup .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b62d4a5b6765d3539c92b72e821b9029b043941 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Ayal Baron has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG Commit Message: Line 16: methods are used only on Python 2.6. Python 2.7 already include these Line 17: changes. Then the protocol_version is set to HTTP/1.1, enabling Line 18: automatic keep-alive. Line 19: Line 20: A new configuration option "xmlrpc_http11" can be used to disbale this > Using HTTP/1.1, the server threads are long living, and each thread handle The default value should be the one we want to go with (i.e. 1.1). However, I agree with Nir that in the field, having the ability to disable something allows us to deal with emergencies easily (change to 1.0, fix issue in background, relatively at our own leisure, then upgrade and change back). Since this changes the transport protocol, we cannot predict where we will hit issues (what flows). So imo it makes sense. Note that this does not mean that we support the 1.0 configuration or that users should be changing it. Line 21: feature and use HTTP/1.0 as used before. Line 22: Line 23: We can see in the logs that only few threads are created now for service Line 24: XMLRPC requests, and most requests are handled by the same thread. -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Collect numa information
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 6: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6466/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7250/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7368/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Xiaolei Shi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6465/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7249/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7367/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: cleanup post-libvirt merge code
Dan Kenigsberg has posted comments on this change.
Change subject: vm: cleanup post-libvirt merge code
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24744/3/vdsm/vm.py
File vdsm/vm.py:
Line 3714: # we need a way to
Line 3715: # 1. detect ENOSPC when connected to a VM.
Line 3716: # 2. detect a VM was paused to ENOSPC when reconnecting after
Line 3717: #a VDSM restart.
Line 3718: # upstream libvirt unfortunately lacks both features.
Would you open a libvirt RFE on this on bugzilla, and mention it here?
Otherwise, we may wait forever for this feature.
I have a vague memory of such an RFE having existed, but I am really not sure.
Line 3719: self.log.warning('_readPauseCode unsupported by libvirt vm')
Line 3720: return 'NOERR'
Line 3721:
Line 3722: def _timeoutExperienced(self, timeout):
--
To view, visit http://gerrit.ovirt.org/24744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: cleanup post-libvirt merge code
Francesco Romani has posted comments on this change.
Change subject: vm: cleanup post-libvirt merge code
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/24744/3/vdsm/vm.py
File vdsm/vm.py:
Line 3714: # we need a way to
Line 3715: # 1. detect ENOSPC when connected to a VM.
Line 3716: # 2. detect a VM was paused to ENOSPC when reconnecting after
Line 3717: #a VDSM restart.
Line 3718: # upstream libvirt unfortunately lacks both features.
> Would you open a libvirt RFE on this on bugzilla, and mention it here? Othe
Already done: https://bugzilla.redhat.com/show_bug.cgi?id=1067414
I was not sure it was OK to mention the BZ in the comment, but I'll add.
Also, I was not sure this should be a RFE because the code is present but
currently disabled. The mandatory search before to open the bug did not
produced any duplicate.
Line 3719: self.log.warning('_readPauseCode unsupported by libvirt vm')
Line 3720: return 'NOERR'
Line 3721:
Line 3722: def _timeoutExperienced(self, timeout):
--
To view, visit http://gerrit.ovirt.org/24744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use same constants for configuring and check configure of sa...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6467/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7369/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6468/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7252/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7370/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fixing ssl config validation
Yaniv Bronhaim has posted comments on this change. Change subject: Fixing ssl config validation .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d9ada1b81d275b8cac9391c15ab903ec9552184 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: add mechanism to persist vmDevice defaults
Federico Simoncelli has posted comments on this change. Change subject: vmDevices: add mechanism to persist vmDevice defaults .. Patch Set 3: Code-Review+1 (1 comment) I'd like to see _defaults being renamed. http://gerrit.ovirt.org/#/c/21066/3/vdsm/vm.py File vdsm/vm.py: Line 1249: pass Line 1250: self.conf = conf Line 1251: self.log = log Line 1252: self._deviceXML = None Line 1253: self._defaults() Can we rename this to something like: _initializeDefaults(...) or something better. Line 1254: Line 1255: def _defaults(self): Line 1256: pass Line 1257: -- To view, visit http://gerrit.ovirt.org/21066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8383cbce78490c8dfab1c253883a06459f1547 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: introduce VmDeviceContainer
Federico Simoncelli has posted comments on this change. Change subject: vmDevices: introduce VmDeviceContainer .. Patch Set 7: Code-Review-1 We probably want to squash this with http://gerrit.ovirt.org/#/c/21162/ -- To view, visit http://gerrit.ovirt.org/21138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/24733/8/client/vdsClient.py
File client/vdsClient.py:
Line 66: path
if the username is not part of the auth parameter why is it called auth? if it
would called pass you can omit the long explanation and leave only the options:
pass=[file:path | env:varname | plain:password]
Line 133: getPassword
parseComplexParameter or parseMethodParam or something.. if you want it to be
reusable. and don't set auth= as default .. it brakes all the generic goal
Line 131:
Line 132:
Line 133: def getPassword(location, param_name='auth='):
Line 134: (method, value) = location.replace(param_name, '').split(':', 1)
Line 135: if 'file' == method:
why not method == 'file' ? its odd the opposite way. not use to it, as you did
with key == 'auth' in line 749
Line 136: password_line = None
Line 137: with open(value) as f:
Line 138: password_line = f.readline()
Line 139: return password_line
Line 133: def getPassword(location, param_name='auth='):
Line 134: (method, value) = location.replace(param_name, '').split(':', 1)
Line 135: if 'file' == method:
Line 136: password_line = None
Line 137: with open(value) as f:
why setting to None? if open fails you'll raise an error anyway.
Line 138: password_line = f.readline()
Line 139: return password_line
Line 140: elif 'env' == method:
Line 141: try:
Line 144: return
you can't assume that if the environment variable does not exist the password
is empty. please report to user that the varibale 'value' does not exist in
os.environ dict by let the error raise as you do with the file
Line 148: RuntimeError
aren't we generic? should be "unknown method %s for parameter %s" % (method,
param_name)
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8:
(1 comment)
why don't you use the parse function I provided to parse password with special
characters and avoid bugs?
http://gerrit.ovirt.org/#/c/24733/8/client/vdsClient.py
File client/vdsClient.py:
Line 2008: 'setVmTicket': (serv.do_setVmTicket,
Line 2009: ('
[disconnect|keep|fail], '
Line 2010: '[params={}]',
Line 2011: 'Set the password to the vm display for the
next '
Line 2012: ' seconds.', PASSWORD_HELP +
space
Line 2013: 'Optional argument instructs spice
regarding '
Line 2014: 'currently-connected client.',
Line 2015: 'Optional additional parameters in
dictionary format,'
Line 2016: ' name:value,name:value'
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/7/client/vdsClient.py
File client/vdsClient.py:
Line 380: params = {}
Line 381:
Line 382: if (len(args) > 5):
Line 383: params = self._parseDriveSpec(args[5])
Line 384: else:
> The indexes are different. I will check and remove duplication.
?
Line 385: if len(args) == 3:
Line 386: vmId, otp64, secs = args[:3]
Line 387: connAct = 'disconnect'
Line 388: params = {}
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: add mechanism to persist vmDevice defaults
Francesco Romani has posted comments on this change. Change subject: vmDevices: add mechanism to persist vmDevice defaults .. Patch Set 3: I agree with Federico's remark. +1 for me once the _defaults() name is improved. -- To view, visit http://gerrit.ovirt.org/21066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8383cbce78490c8dfab1c253883a06459f1547 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/6/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 195: self.assertTrue('hostDevices' in stats,
Line 196: 'Host devices are not reported in
vdsCapabilities!')
Line 197: # element 0 should be 'computer' - this device should not
cause
Line 198: # any security concerns and works without iommu support
Line 199: hostdev = stats['hostDevices'][0]
On my machine the first device is not "computer", I think you just should use a
static string here "computer".
Line 200: hostdev['type'] = 'hostdev'
Line 201:
Line 202: customization = {'vmId':
'----',
Line 203: 'vmName': 'testVmWithHostdev', 'devices':
http://gerrit.ovirt.org/#/c/22462/6/vdsm/vm.py
File vdsm/vm.py:
Line 2896: if drive.transientDisk:
Line 2897: return True
Line 2898: return False
Line 2899:
Line 2900: def migrate(self, params):
What about live migration? Is it supported with host devices attached? I am
fine if we want to rely on libvirt for failures but could you test what is
actually happening and if we need to catch any special failure? Please also add
your findings in the commit message.
Line 2901: self._acquireCpuLockWithTimeout()
Line 2902: try:
Line 2903: if self.isMigrating():
Line 2904: self.log.warning('vm already migrating')
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
Federico Simoncelli has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 5: (8 comments) http://gerrit.ovirt.org/#/c/24603/5/lib/vdsm/netlink.py File lib/vdsm/netlink.py: Line 82: 'rtnl_scope2str', LIBNL)) Line 83: Line 84: Line 85: class NLSocketPoolError(Exception): Line 86: pass > Looks like unused class - kill it? Done Line 87: Line 88: Line 89: class NLSocketPool(object): Line 90: """Pool of netlink sockets.""" Line 88: Line 89: class NLSocketPool(object): Line 90: """Pool of netlink sockets.""" Line 91: def __init__(self, size): Line 92: assert size > 0 > It will little nicer to raise here ValueError: Done Line 93: self._size = size Line 94: self._sockets = set() Line 95: self._semaphore = BoundedSemaphore(size) Line 96: Line 89: class NLSocketPool(object): Line 90: """Pool of netlink sockets.""" Line 91: def __init__(self, size): Line 92: assert size > 0 Line 93: self._size = size > We can get rid of _size Done Line 94: self._sockets = set() Line 95: self._semaphore = BoundedSemaphore(size) Line 96: Line 97: @contextmanager Line 91: def __init__(self, size): Line 92: assert size > 0 Line 93: self._size = size Line 94: self._sockets = set() Line 95: self._semaphore = BoundedSemaphore(size) > And lets initialize the _semphore before the _sockets, since it is more imp Done Line 96: Line 97: @contextmanager Line 98: def socket(self): Line 99: """Takes a netlink socket from the pool and returns it afterwards.""" Line 95: self._semaphore = BoundedSemaphore(size) Line 96: Line 97: @contextmanager Line 98: def socket(self): Line 99: """Takes a netlink socket from the pool and returns it afterwards.""" > More correct docstring would describe that this return a socket from the po Done Line 100: with self._semaphore: Line 101: try: Line 102: sock = self._sockets.pop() Line 103: except KeyError: Line 100: with self._semaphore: Line 101: try: Line 102: sock = self._sockets.pop() Line 103: except KeyError: Line 104: sock = _open_socket() > A queue would be nicer. Done Line 105: try: Line 106: yield sock Line 107: finally: Line 108: self._sockets.add(sock) Line 118: if _pool is None: Line 119: with _pool_lock: Line 120: if _pool is None: Line 121: _pool = NLSocketPool(_POOL_SIZE) Line 122: return _pool > Now that sockets are created lazily, we create create the pool during impor Done Line 123: Line 124: Line 125: def _open_socket(): Line 126: """Returns an open netlink socket.""" Line 129: raise IOError(get_errno(), 'Failed to allocate netlink handle') Line 130: Line 131: err = _nl_connect(handle, NETLINK_ROUTE) Line 132: if err: Line 133: _close_socket(handle) > Here using _nl_handle_destroy is more correct, since here you are in libnl Done Line 134: raise IOError(-err, _nl_geterror()) Line 135: return handle Line 136: Line 137: -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: spice support to clipboard copypaste disable
Federico Simoncelli has posted comments on this change.
Change subject: vm: spice support to clipboard copypaste disable
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/22646/3/vdsm/vm.py
File vdsm/vm.py:
Line 1134: if self.conf.get('spiceSecureChannels'):
Line 1135: for channel in
self.conf['spiceSecureChannels'].split(','):
Line 1136: graphics.appendChildWithArgs('channel',
name=channel[1:],
Line 1137: mode='secure')
Line 1138: if not utils.tobool(self.conf.get('copyPasteEnable',
True)):
After __slots__ being merged I was expecting to see this appearing there too.
Is it because the patch is not rebased or is it because we don't have __slots__
for these special devices?
Line 1139: clipboard = XMLElement('clipboard', copypaste='no')
Line 1140: graphics.appendChild(clipboard)
Line 1141:
Line 1142: vmc = XMLElement('channel', type='spicevmc')
--
To view, visit http://gerrit.ovirt.org/22646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8195da0c3ba2663027b77ea8a858e5ba17c48e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Federico Simoncelli has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 8:
(3 comments)
no reason to keep reviewing this if you ignore the proper parsing of password.
ping me when you do.
see comment for patch#6
http://gerrit.ovirt.org/#/c/24733/8/client/vdsClient.py
File client/vdsClient.py:
Line 62: LEAF_VOL = 8
Line 63:
Line 64: PASSWORD_HELP = ('Password can be provided as command line argument,
path to'
Line 65: 'file with password or environment variable by
providing'
Line 66: 'auth=file:path or auth=env:name or
auth=pass:password')
> Alon what do you think? You wanted to have auth.
if we use pass we cannot keep backward compatibility.
Line 67:
Line 68: def validateArgTypes(args, conv, requiredArgsNumber=0):
Line 69: if len(args) > len(conv) or len(args) < requiredArgsNumber:
Line 70: raise ValueError("Wrong number of arguments provided, "
Line 129: for conf in list:
Line 130: printConf(conf)
Line 131:
Line 132:
Line 133: def getPassword(location, param_name='auth='):
> Interesting... Alon suggested to have it in single method.
it is not param_name, it is optional prefix to remove, it should be '' per
default as I wrote in my many comments.
Line 134: (method, value) = location.replace(param_name, '').split(':', 1)
Line 135: if 'file' == method:
Line 136: password_line = None
Line 137: with open(value) as f:
Line 131:
Line 132:
Line 133: def getPassword(location, param_name='auth='):
Line 134: (method, value) = location.replace(param_name, '').split(':', 1)
Line 135: if 'file' == method:
> Done
no... it is file: it is good.
Line 136: password_line = None
Line 137: with open(value) as f:
Line 138: password_line = f.readline()
Line 139: return password_line
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: spice support to clipboard copypaste disable
Francesco Romani has posted comments on this change.
Change subject: vm: spice support to clipboard copypaste disable
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/22646/3/vdsm/vm.py
File vdsm/vm.py:
Line 1134: if self.conf.get('spiceSecureChannels'):
Line 1135: for channel in
self.conf['spiceSecureChannels'].split(','):
Line 1136: graphics.appendChildWithArgs('channel',
name=channel[1:],
Line 1137: mode='secure')
Line 1138: if not utils.tobool(self.conf.get('copyPasteEnable',
True)):
> After __slots__ being merged I was expecting to see this appearing there to
Well the patch was not rebased yet. Will address after rebase.
Line 1139: clipboard = XMLElement('clipboard', copypaste='no')
Line 1140: graphics.appendChild(clipboard)
Line 1141:
Line 1142: vmc = XMLElement('channel', type='spicevmc')
--
To view, visit http://gerrit.ovirt.org/22646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8195da0c3ba2663027b77ea8a858e5ba17c48e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding vdsm.conf.example to rhel build
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding vdsm.conf.example to rhel build
..
Adding vdsm.conf.example to rhel build
The file was not installed to avoid putting it on RHEV-H installation,
which should be small as possible. The sample file was requested by users
and should be located for reference after manual installation (without
host-deploy process. If host installed by host-deploy process, this file will
be overrided by the required config)
Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023941
Signed-off-by: Yaniv Bronhaim
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/24945/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 71a54dd..25069e0 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -667,11 +667,8 @@
install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
%endif
-%if !0%{?rhel}
-# Install the configuration sample
install -Dm 0644 lib/vdsm/vdsm.conf.sample \
%{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
-%endif
# Install the polkit for libvirt
%if 0%{?fedora} >= 18 || 0%{?rhel} >= 7
--
To view, visit http://gerrit.ovirt.org/24945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6469/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7253/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7371/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: report migration progress in VmStats
Michal Skrivanek has posted comments on this change. Change subject: vm: report migration progress in VmStats .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35e40663921b2d73a9b49727c61b8b1f4dacdb9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding vdsm.conf.example to rhel build
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding vdsm.conf.example to rhel build .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6470/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/354/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7254/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7372/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2606c571cd6de06eee811bbd340a790f98d11907 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 9: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24733/9/client/vdsClient.py
File client/vdsClient.py:
Line 143: except KeyError:
Line 144: raise RuntimeError('Env variable %s not found in
os.environ' %
Line 145:(value))
Line 146: elif method == 'pass':
Line 147: return value.decode('string_escape')
this does not solve the issue as the split happens before this function.
Line 148: else:
Line 149: raise RuntimeError("unknown method %s for parameter %s" %
Line 150:(method, param_name))
Line 151:
Line 381: connAct = 'disconnect'
Line 382: params = {}
Line 383: else:
Line 384: vmId, secs, connAct = args[:3]
Line 385: params = {}
this is still duplicated
Line 386: else:
Line 387: if len(args) == 3:
Line 388: vmId, otp64, secs = args[:3]
Line 389: connAct = 'disconnect'
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6471/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7373/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Nir Soffer has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 7: Code-Review+1 (1 comment) Other then easier to debug put_nowait() when returning a socket to the queue, looks good. http://gerrit.ovirt.org/#/c/24603/7/lib/vdsm/netlink.py File lib/vdsm/netlink.py: Line 101: sock = _open_socket() Line 102: try: Line 103: yield sock Line 104: finally: Line 105: self._sockets.put(sock) If we have a bug in the code limiting the number of threads, this will block silently until some other thread will take a socket from the queue. Better use put_nowait() so which will raise Queue.Full in this impossible case. Line 106: Line 107: Line 108: _pool = NLSocketPool(_POOL_SIZE) Line 109: -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Disable needless and slow dns lookup
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Disable needless and slow dns lookup .. Patch Set 1: Code-Review+2 (3 comments) http://gerrit.ovirt.org/#/c/24871/1//COMMIT_MSG Commit Message: Line 6: Line 7: xmlrpc: Disable needless and slow dns lookup Line 8: Line 9: BaseHTTPServer.BaseRequestHandler is invoking socket.getfqdn() after Line 10: each request, to log the client fully qualified hostname. If dns is not I did not find where address_string() is actually being called. Could you help me here? Line 11: configured properly, this cause needless delay after each request. Line 12: Line 13: This patch override address_string to return client address, avoiding Line 14: the dns lookup. Line 7: xmlrpc: Disable needless and slow dns lookup Line 8: Line 9: BaseHTTPServer.BaseRequestHandler is invoking socket.getfqdn() after Line 10: each request, to log the client fully qualified hostname. If dns is not Line 11: configured properly, this cause needless delay after each request. .. this causes Line 12: Line 13: This patch override address_string to return client address, avoiding Line 14: the dns lookup. Line 15: Line 9: BaseHTTPServer.BaseRequestHandler is invoking socket.getfqdn() after Line 10: each request, to log the client fully qualified hostname. If dns is not Line 11: configured properly, this cause needless delay after each request. Line 12: Line 13: This patch override address_string to return client address, avoiding This patch overrides Line 14: the dns lookup. Line 15: Line 16: Change-Id: I6b62d4a5b6765d3539c92b72e821b9029b043941 -- To view, visit http://gerrit.ovirt.org/24871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b62d4a5b6765d3539c92b72e821b9029b043941 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: pre-validate disks for snapshot
Dan Kenigsberg has posted comments on this change. Change subject: vm: pre-validate disks for snapshot .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/9/client/vdsClient.py
File client/vdsClient.py:
Line 143: except KeyError:
Line 144: raise RuntimeError('Env variable %s not found in
os.environ' %
Line 145:(value))
Line 146: elif method == 'pass':
Line 147: return value.decode('string_escape')
> I do not understand what you mean.
xxx=yyy,auth=pass:"my long, pass\"word",zzz=aaa
Line 148: else:
Line 149: raise RuntimeError("unknown method %s for parameter %s" %
Line 150:(method, param_name))
Line 151:
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6472/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/355/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7374/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: cleanup post-libvirt merge code
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: cleanup post-libvirt merge code .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6473/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7257/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7375/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: report migration progress in VmStats
Vinzenz Feenstra has posted comments on this change. Change subject: vm: report migration progress in VmStats .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35e40663921b2d73a9b49727c61b8b1f4dacdb9a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/24733/9/client/vdsClient.py
File client/vdsClient.py:
Line 143: except KeyError:
Line 144: raise RuntimeError('Env variable %s not found in
os.environ' %
Line 145:(value))
Line 146: elif method == 'pass':
Line 147: return value.decode('string_escape')
> Agree. This comma would break most of the command processing from this file
please see my parse function at patch#6 and merge it into this code, I usually
do not write code for nothing.
Line 148: else:
Line 149: raise RuntimeError("unknown method %s for parameter %s" %
Line 150:(method, param_name))
Line 151:
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Disable needless and slow dns lookup
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Disable needless and slow dns lookup .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24871/1//COMMIT_MSG Commit Message: Line 6: Line 7: xmlrpc: Disable needless and slow dns lookup Line 8: Line 9: BaseHTTPServer.BaseRequestHandler is invoking socket.getfqdn() after Line 10: each request, to log the client fully qualified hostname. If dns is not > I did not find where address_string() is actually being called. Could you h /usr/lib64/python2.6/BaseHTTPServer.py line 445 Turns out that finally Python devs fixed this in 2.7 by not calling address_string. I'll update the commit message. Line 11: configured properly, this cause needless delay after each request. Line 12: Line 13: This patch override address_string to return client address, avoiding Line 14: the dns lookup. -- To view, visit http://gerrit.ovirt.org/24871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b62d4a5b6765d3539c92b72e821b9029b043941 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: export mininum kernel via caps
Itamar Heim has posted comments on this change. Change subject: vdsm: export mininum kernel via caps .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/19792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16c496e1a77639c39fae733e3a34c974b6f10b5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yair Zaslavsky Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: refresh on mda permission mismatch
Itamar Heim has posted comments on this change. Change subject: lvm: refresh on mda permission mismatch .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/20121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More precise exception when multipath failed.
Itamar Heim has posted comments on this change. Change subject: More precise exception when multipath failed. .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/17145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b87e8e91b838db2c8a98c9afbbc998e8f4c792a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Get underlying device info moved to Device classes
Itamar Heim has posted comments on this change. Change subject: vdsm: Get underlying device info moved to Device classes .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/19732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f797baece3601b88584f611b420523828f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Reassign mount specification in case of backup option
Itamar Heim has posted comments on this change. Change subject: mount: Reassign mount specification in case of backup option .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/16534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3166c6863dffa297bc0adcdeb4c22f810d18de8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor StoragePool.getPoolParams()
Itamar Heim has posted comments on this change. Change subject: Refactor StoragePool.getPoolParams() .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/19232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Gadi Ickowicz Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Meital Bourvine Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid hsm image deletions.
Itamar Heim has posted comments on this change. Change subject: Avoid hsm image deletions. .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/17193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ec2ea8793a4ad63453559bc5f663b65f9b9336 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring of retrieving device info from xml
Itamar Heim has posted comments on this change. Change subject: vdsm: Refactoring of retrieving device info from xml .. Patch Set 7: ping? -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Adding monitorDomains.
Itamar Heim has posted comments on this change. Change subject: [WIP] Adding monitorDomains. .. Patch Set 8: ping? -- To view, visit http://gerrit.ovirt.org/14674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f148764ac030730c93bfd9c8da25a7ea434dc33 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Remove unused 'deduceType' and MIXED_DEV
Itamar Heim has posted comments on this change. Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV .. Patch Set 6: ping? -- To view, visit http://gerrit.ovirt.org/13363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: geo replication status and status detail
Itamar Heim has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/18414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring of retrieving device info from xml
Francesco Romani has posted comments on this change. Change subject: vdsm: Refactoring of retrieving device info from xml .. Patch Set 7: Code-Review+1 I like the idea. -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring of retrieving device info from xml
Francesco Romani has posted comments on this change. Change subject: vdsm: Refactoring of retrieving device info from xml .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/17694/7/vdsm/vm.py File vdsm/vm.py: Line 2794: self._getUnderlyingBalloonDeviceInfo(devicesXml=devicesXml) Line 2795: self._getUnderlyingWatchdogDeviceInfo(devicesXml=devicesXml) Line 2796: self._getUnderlyingSmartcardDeviceInfo(devicesXml=devicesXml) Line 2797: self._getUnderlyingConsoleDeviceInfo(devicesXml=devicesXml) Line 2798: self._updateAgentChannels(devicesXml=devicesXml) Probably better to save this for another patch. Line 2799: # Obtain info of all unknown devices. Must be last! Line 2800: self._getUnderlyingUnknownDeviceInfo(devicesXml=devicesXml) Line 2801: Line 2802: def _updateAgentChannels(self, devicesXml): -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
Douglas Schilling Landgraf has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.
Yeela Kaplan has posted comments on this change. Change subject: [WIP] Towards a more (block) secure HSM. .. Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 310: Line 311: def validateSPM(self, spUUID): Line 312: pool = self.getPool(spUUID) Line 313: if pool.spmRole != sp.SPM_ACQUIRED: Line 314: lvm.setLvmROMD() > redundant Done Line 315: raise se.SpmStatusError(spUUID) Line 316: Line 317: def validateNotSPM(self, spUUID): Line 318: pool = self.getPool(spUUID) Line 601: :raises: :exc:`storage_exception.TaskInProgress` Line 602: if there are tasks running for this pool. Line 603: Line 604: """ Line 605: lvm.setLvmROMD() > should be in stopSpm inside sp Done Line 606: vars.task.setDefaultException(se.SpmStopError(spUUID)) Line 607: vars.task.getExclusiveLock(STORAGE, spUUID) Line 608: Line 609: pool = self.getPool(spUUID) http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 267: Line 268: try: Line 269: self.lver = int(oldlver) + 1 Line 270: Line 271: blockSD.lvm.setLvmRWMD() # Do it later > 1. do it later where? why? I guess that the intention is to where the next comment is, but it's irrelevant now so I'm removing it Line 272: Line 273: self._backend.setSpmStatus(self.lver, self.id, Line 274:__securityOverride=True) Line 275: self._maxHostID = maxHostID -- To view, visit http://gerrit.ovirt.org/2218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password .. Patch Set 10: completely untested, but attempting to reduce ping-pong, I wrote the implementation I would like to see. take this as a base and make it work. it should add additional args fields to command and parse them using same method we agreed. previous implementation tries to fuzzy match auth= anywhere, which is wrong. thanks! -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6474/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7258/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7376/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/24603/7/lib/vdsm/netlink.py File lib/vdsm/netlink.py: Line 101: sock = _open_socket() Line 102: try: Line 103: yield sock Line 104: finally: Line 105: self._sockets.put(sock) > If we have a bug in the code limiting the number of threads, this will bloc Done Line 106: Line 107: Line 108: _pool = NLSocketPool(_POOL_SIZE) Line 109: -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Nir Soffer has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 8: Code-Review+1 Elegant -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6475/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7259/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7377/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Add an option to replace locking type 4
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Add an option to replace locking type 4 .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6479/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7380/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6476/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7378/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Towards a more (block) secure HSM. .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6478/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7263/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7381/ : FAILURE -- To view, visit http://gerrit.ovirt.org/2218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] destroy storage pool using command type 1
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6477/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7379/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Create storage pool using command type 1
oVirt Jenkins CI Server has posted comments on this change. Change subject: Create storage pool using command type 1 .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6481/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7265/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7383/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64f6dd2df38d2968f03ce66094f3ba7b4343503 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Create storage domain using command type 1
oVirt Jenkins CI Server has posted comments on this change. Change subject: Create storage domain using command type 1 .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6480/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7382/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: destroy storage pool using command type 1
oVirt Jenkins CI Server has posted comments on this change. Change subject: destroy storage pool using command type 1 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7266/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7384/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Towards a more (block) secure HSM.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Towards a more (block) secure HSM. .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6483/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7267/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7385/ : FAILURE -- To view, visit http://gerrit.ovirt.org/2218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Add an option to replace locking type 4
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Add an option to replace locking type 4 .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6484/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7268/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7386/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Create storage domain using command type 1
oVirt Jenkins CI Server has posted comments on this change. Change subject: Create storage domain using command type 1 .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6485/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7269/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7387/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Create storage pool using command type 1
oVirt Jenkins CI Server has posted comments on this change. Change subject: Create storage pool using command type 1 .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6486/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7270/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7388/ : FAILURE -- To view, visit http://gerrit.ovirt.org/23647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64f6dd2df38d2968f03ce66094f3ba7b4343503 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Eduardo Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Nir Soffer has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 9: Code-Review+1 I liked that line but never mind. -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password .. Patch Set 10: no, did not run anything, I just wanted to move us to closure track. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: Introduce socket pool .. netlink: Introduce socket pool If a lot of netlink requests happened _nl_connect would fail at the C level, more concretely when doing bind, which would return EADDRINUSE. This patch addresses that issue as well as reduces the the resource consumption of the module by reusing the netlink sockets. The reusing is done by a semaphore protected socket pool. Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/24603 Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M lib/vdsm/netlink.py 1 file changed, 76 insertions(+), 42 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Dan Kenigsberg has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 9: Code-Review+2 > I liked that line but never mind. ;-) -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Schema: Typemap changes
Saggi Mizrahi has posted comments on this change. Change subject: Schema: Typemap changes .. Patch Set 1: Code-Review-2 Since we no longer do code generation I think we need to wait until after we get past the discussion on the future of the schema in the upcoming VDSM week. -- To view, visit http://gerrit.ovirt.org/23375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7af8f07e07450fda97819f64fd120536cb318717 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: Introduce socket pool
Douglas Schilling Landgraf has posted comments on this change. Change subject: netlink: Introduce socket pool .. Patch Set 10: Toni, did you send it to 3.4 branch too? -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Disable needless and slow dns lookup
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Disable needless and slow dns lookup .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24871/1//COMMIT_MSG Commit Message: Line 6: Line 7: xmlrpc: Disable needless and slow dns lookup Line 8: Line 9: BaseHTTPServer.BaseRequestHandler is invoking socket.getfqdn() after Line 10: each request, to log the client fully qualified hostname. If dns is not > /usr/lib64/python2.6/BaseHTTPServer.py line 445 Better than changing the message, change the code, so it's clear that we need this only for <= (2, 6). Line 11: configured properly, this cause needless delay after each request. Line 12: Line 13: This patch override address_string to return client address, avoiding Line 14: the dns lookup. -- To view, visit http://gerrit.ovirt.org/24871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b62d4a5b6765d3539c92b72e821b9029b043941 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
Dan Kenigsberg has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_scale: Don't instantiate NetInfo needlessly
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_scale: Don't instantiate NetInfo needlessly .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6488/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7272/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7390/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I729c522396095a8114fefbc600dab00b46cea2bb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_scale: Allow NetInfo update just the devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_scale: Allow NetInfo update just the devices .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6487/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7271/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7389/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia32b0333052c05c92475bddcc5e9ce805fb82c94 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net_scale: Allow NetInfo update just the devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_scale: Allow NetInfo update just the devices .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7391/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia32b0333052c05c92475bddcc5e9ce805fb82c94 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for multiple iSCSI interfaces
Itamar Heim has posted comments on this change. Change subject: vdsm: add support for multiple iSCSI interfaces .. Patch Set 1: ping? still relevnat? -- To view, visit http://gerrit.ovirt.org/20981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ea11855623a9fa8398a1027b55ba7ac335998b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Goldstone Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: file based mechanism to provide password
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password
..
Patch Set 10:
(4 comments)
http://gerrit.ovirt.org/#/c/24733/10/client/vdsClient.py
File client/vdsClient.py:
Line 102: print
Line 103: print "Password can be provided as command line argument, path to"
Line 104: print "file with password or environment variable by providing"
Line 105: print "auth=file:path or auth=env:name or auth=pass:password"
Line 106:
currently the vdsClient shows all the commands' info in its usage print, so the
above part ^ almost disappear (you may check that). so we can't assume that the
user will read this part and understand how to use Password parameter. it
should be printed as before in each command that requires password.
Line 107:
Line 108: def printConf(conf):
Line 109: try:
Line 110: print "\n" + conf['vmId']
Line 162: return ret, length
Line 163:
Line 164:
Line 165: def parseArgs(args):
Line 166: con, length = parseOptions(args[2])
what does 'con' stand for?
Line 167: if 'auth' in con:
Line 168: con['password'] = getPassword(con['auth'])
Line 169: return con
Line 170:
Line 168: con['password'] = getPassword(con['auth'])
Line 169: return con
Line 170:
Line 171:
Line 172: def getPassword(string, prefix=''):
the function can get only the value without the prefix, you already splitted
it. with that implementation nothing calls it , but it shouldn't contain the
prefix that you remove at the beginning
Line 173: ret = None
Line 174: (method, value) = string[len(prefix):].split(':', 1)
Line 175: if method == 'file':
Line 176: with open(value) as f:
Line 2015:'Sends reset signal to the vm'
Line 2016:)),
Line 2017: 'setVmTicket': (serv.do_setVmTicket,
Line 2018: ('
[disconnect|keep|fail], '
Line 2019: '[params={}] [args]',
you need to explain args somehow
Line 2020: 'Set the password to the vm display for the
next '
Line 2021: ' seconds.',
Line 2022: 'Optional argument instructs spice
regarding '
Line 2023: 'currently-connected client.',
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yedidyah Bar David
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
Yaniv Bronhaim has submitted this change and it was merged. Change subject: packaging: update python-cpopen requirement to 1.3 .. packaging: update python-cpopen requirement to 1.3 update both dependencies and build dependencies to python-cpopen 1.3. Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1068786 Reviewed-on: http://gerrit.ovirt.org/#/c/23468/ Signed-off-by: Francesco Romani Signed-off-by: Douglas Schilling Landgraf Reviewed-on: http://gerrit.ovirt.org/24874 Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M debian/control M vdsm.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection
Yaniv Bronhaim has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection
Yaniv Bronhaim has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/24822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/363/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection
Yaniv Bronhaim has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 7: -Verified -- To view, visit http://gerrit.ovirt.org/24822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
