Change in vdsm[master]: iscsi.py: cleanup - remove temp variable
Sergey Gotliv has posted comments on this change. Change subject: iscsi.py: cleanup - remove temp variable .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb581010fab9f56de22c34b67b91b88f8ca3612f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Use tpgt when login, update or remove iscsi node
Sergey Gotliv has posted comments on this change. Change subject: iscsi: Use tpgt when login, update or remove iscsi node .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25706/1/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 144: Line 145: def addIscsiNode(iface, target, credentials=None): Line 146: targetName = target.iqn Line 147: portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port, Line 148: target.portal.group if target.portal.group else 1) > Hello, What about a constant instead of '1' ? It was a dirty quick try. Engine already sends tgtp as 1 to the VDSM as far as I remember I just need to follow the flow and find it so the constant is won't be needed :-). Sorry for noise. Line 149: with _iscsiadmTransactionLock: Line 150: iscsiadm.node_new(iface.name, portalStr, targetName) Line 151: try: Line 152: if credentials is not None: -- To view, visit http://gerrit.ovirt.org/25706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi.py: cleanup - remove temp variable
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsi.py: cleanup - remove temp variable .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7452/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6660/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7561/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb581010fab9f56de22c34b67b91b88f8ca3612f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi.py: cleanup - remove temp variable
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: iscsi.py: cleanup - remove temp variable .. iscsi.py: cleanup - remove temp variable Don't need to assign new variable to use target.iqn Change-Id: Ieb581010fab9f56de22c34b67b91b88f8ca3612f Signed-off-by: Douglas Schilling Landgraf --- M vdsm/storage/iscsi.py 1 file changed, 6 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/25710/1 diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py index f4fdceb..2adbd01 100644 --- a/vdsm/storage/iscsi.py +++ b/vdsm/storage/iscsi.py @@ -143,20 +143,19 @@ def addIscsiNode(iface, target, credentials=None): -targetName = target.iqn portalStr = "%s:%d" % (target.portal.hostname, target.portal.port) with _iscsiadmTransactionLock: -iscsiadm.node_new(iface.name, portalStr, targetName) +iscsiadm.node_new(iface.name, portalStr, target.iqn) try: if credentials is not None: for key, value in credentials.getIscsiadmOptions(): key = "node.session." + key -iscsiadm.node_update(iface.name, portalStr, targetName, +iscsiadm.node_update(iface.name, portalStr, target.iqn, key, value, hideValue=True) -iscsiadm.node_login(iface.name, portalStr, targetName) +iscsiadm.node_login(iface.name, portalStr, target.iqn) -iscsiadm.node_update(iface.name, portalStr, targetName, +iscsiadm.node_update(iface.name, portalStr, target.iqn, "node.startup", "manual") except: removeIscsiNode(iface, target) @@ -164,15 +163,14 @@ def removeIscsiNode(iface, target): -targetName = target.iqn portalStr = "%s:%d" % (target.portal.hostname, target.portal.port) with _iscsiadmTransactionLock: try: -iscsiadm.node_disconnect(iface.name, portalStr, targetName) +iscsiadm.node_disconnect(iface.name, portalStr, target.iqn) except iscsiadm.IscsiSessionNotFound: pass -iscsiadm.node_delete(iface.name, portalStr, targetName) +iscsiadm.node_delete(iface.name, portalStr, target.iqn) def addIscsiPortal(iface, portal, credentials=None): -- To view, visit http://gerrit.ovirt.org/25710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb581010fab9f56de22c34b67b91b88f8ca3612f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Use tpgt when login, update or remove iscsi node
Douglas Schilling Landgraf has posted comments on this change. Change subject: iscsi: Use tpgt when login, update or remove iscsi node .. Patch Set 1: Verified-1 (1 comment) -1 for pep8 ./vdsm/storage/iscsi.py:148:80: E501 line too long (80 > 79 characters) ./vdsm/storage/iscsi.py:170:80: E501 line too long (80 > 79 characters) http://gerrit.ovirt.org/#/c/25706/1/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 144: Line 145: def addIscsiNode(iface, target, credentials=None): Line 146: targetName = target.iqn Line 147: portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port, Line 148: target.portal.group if target.portal.group else 1) Hello, What about a constant instead of '1' ? Line 149: with _iscsiadmTransactionLock: Line 150: iscsiadm.node_new(iface.name, portalStr, targetName) Line 151: try: Line 152: if credentials is not None: -- To view, visit http://gerrit.ovirt.org/25706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Use tpgt when login, update or remove iscsi node
Douglas Schilling Landgraf has posted comments on this change. Change subject: iscsi: Use tpgt when login, update or remove iscsi node .. Patch Set 1: -Verified Code-Review-1 -- To view, visit http://gerrit.ovirt.org/25706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25700/2/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 305:
Line 306: # unpersist cmd is remove_config on ovirt-functions
Line 307: if isOvirtNode; then
Line 308: . /usr/libexec/ovirt-functions
Line 309: remove_config "${llogr}"
> you only remove here the old config, which seems redundant to me
remove? remove_config is unpersist cmd, we do not remove.
Line 310: fi
Line 311: @MV_PATH@ "${stanza}" "${llogr}"
Line 312:
Line 313: if [ -n "${oldmod}" ]; then
--
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25700/2/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 305:
Line 306: # unpersist cmd is remove_config on ovirt-functions
Line 307: if isOvirtNode; then
Line 308: . /usr/libexec/ovirt-functions
Line 309: remove_config "${llogr}"
> You meant, unpersist? On rhev-h you cannot rename a file without unpersit i
you only remove here the old config, which seems redundant to me
Line 310: fi
Line 311: @MV_PATH@ "${stanza}" "${llogr}"
Line 312:
Line 313: if [ -n "${oldmod}" ]; then
--
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25700/2/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 305:
Line 306: # unpersist cmd is remove_config on ovirt-functions
Line 307: if isOvirtNode; then
Line 308: . /usr/libexec/ovirt-functions
Line 309: remove_config "${llogr}"
> why do you need this part?
You meant, unpersist? On rhev-h you cannot rename a file without unpersit it.
Line 310: fi
Line 311: @MV_PATH@ "${stanza}" "${llogr}"
Line 312:
Line 313: if [ -n "${oldmod}" ]; then
--
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: Do not take bond/nic down when removing one of their ...
Yaniv Bronhaim has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Use tpgt when login, update or remove iscsi node
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsi: Use tpgt when login, update or remove iscsi node .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7451/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6659/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7560/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Use tpgt when login, update or remove iscsi node
Sergey Gotliv has uploaded a new change for review. Change subject: iscsi: Use tpgt when login, update or remove iscsi node .. iscsi: Use tpgt when login, update or remove iscsi node According to iscsi documentation http://www.open-iscsi.org/docs/README: Tpgt, is the portal group tag of the portal, and is not used in iscsiadm commands except for static record creation and iface name is the name of the iscsi interface defined in /etc/iscsi/ifaces. If no interface is defined in /etc/iscsi/ifaces or passed in, the default behavior is used. Default here is iscsi_tcp/tcp to be used over which ever NIC the network layer decides is best. The bottom line is that without tpgt iscsi node is connected to host only via one iface and can't perform failover when this interface lost connection to the target. Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Signed-off-by: Sergey Gotliv --- M vdsm/storage/iscsi.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/25706/1 diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py index f4fdceb..dd5b822 100644 --- a/vdsm/storage/iscsi.py +++ b/vdsm/storage/iscsi.py @@ -144,7 +144,8 @@ def addIscsiNode(iface, target, credentials=None): targetName = target.iqn -portalStr = "%s:%d" % (target.portal.hostname, target.portal.port) +portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port, + target.portal.group if target.portal.group else 1) with _iscsiadmTransactionLock: iscsiadm.node_new(iface.name, portalStr, targetName) try: @@ -165,7 +166,8 @@ def removeIscsiNode(iface, target): targetName = target.iqn -portalStr = "%s:%d" % (target.portal.hostname, target.portal.port) +portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port, + target.portal.group if target.portal.group else 1) with _iscsiadmTransactionLock: try: iscsiadm.node_disconnect(iface.name, portalStr, targetName) -- To view, visit http://gerrit.ovirt.org/25706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: Do not take bond/nic down when removing one of their ...
Yaniv Bronhaim has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 1: no bug for 3.4? -- To view, visit http://gerrit.ovirt.org/25680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: ifcfg: Do not take bond/nic down when removing one of their ...
Yaniv Bronhaim has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
Patch Set 2: Code-Review-1
(1 comment)
just a question ..
http://gerrit.ovirt.org/#/c/25700/2/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 305:
Line 306: # unpersist cmd is remove_config on ovirt-functions
Line 307: if isOvirtNode; then
Line 308: . /usr/libexec/ovirt-functions
Line 309: remove_config "${llogr}"
why do you need this part?
Line 310: fi
Line 311: @MV_PATH@ "${stanza}" "${llogr}"
Line 312:
Line 313: if [ -n "${oldmod}" ]; then
--
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirt_configure: unpersist logrotate.d/libvirt .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7450/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6658/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7559/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
Douglas Schilling Landgraf has posted comments on this change. Change subject: libvirt_configure: unpersist logrotate.d/libvirt .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/25700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rename _BCInitiatorNameResolve function
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Rename _BCInitiatorNameResolve function .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7449/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6657/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7558/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sometimes the FD number can be reused in the child process
Dan Kenigsberg has abandoned this change. Change subject: Sometimes the FD number can be reused in the child process .. Abandoned betterPopen forked out of Vdsm. -- To view, visit http://gerrit.ovirt.org/9591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7044936fba8923297c76d9a2123215ec2b793548 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6656/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7557/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: use multiline blacklist
Yaniv Bronhaim has posted comments on this change.
Change subject: pep8: use multiline blacklist
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25416/2/Makefile.am
File Makefile.am:
Line 71:$(PEP8) --version
Line 72:for x in $(PEP8_BLACKLIST); do \
Line 73:exclude="$${exclude},$${x}" ; \
Line 74:done ; \
Line 75:$(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' .
i didn't think about that... good point for not having the list
Line 76:@if test -f .gitignore; then \
Line 77: for i in `git ls-files \*.in`; do \
Line 78:if ! grep -q -x $${i%%.in} .gitignore; then \
Line 79: echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \
--
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rename _BCInitiatorNameResolve function
Sergey Gotliv has uploaded a new change for review.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
hsm: Rename _BCInitiatorNameResolve function
Function _BCInitiatorNameResolve actually resolves the iface name not
the initiator name so new name emphasizes that.
Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7
Signed-off-by: Sergey Gotliv
---
M vdsm/storage/hsm.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/25701/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 021e65e..f7f9cdd 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -148,7 +148,7 @@
sd.GLUSTERFS_DOMAIN: 'glusterfs'}
-def _BCInitiatorNameResolve(ifaceName, initiatorName):
+def _resolveIscsiIface(ifaceName, initiatorName):
if not ifaceName:
return iscsi.IscsiInterface('default')
@@ -230,8 +230,8 @@
target = iscsi.IscsiTarget(portal, tpgt, conDict.get('iqn', None))
-iface = _BCInitiatorNameResolve(conDict.get('ifaceName', None),
-conDict.get('initiatorName', None))
+iface = _resolveIscsiIface(conDict.get('ifaceName', None),
+ conDict.get('initiatorName', None))
cred = None
username = conDict.get('user', None)
--
To view, visit http://gerrit.ovirt.org/25701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: ifcfg: Do not take bond/nic down when removing one of their ...
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: Do not take bond/nic down when removing one of their ...
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: Do not take bond/nic down when removing one of their multiple nets .. Patch Set 1: Code-Review+2 Same as master, and equally important here. -- To view, visit http://gerrit.ovirt.org/25680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirt_configure: unpersist logrotate.d/libvirt .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7447/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6655/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7556/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.
Itamar Heim has posted comments on this change. Change subject: Avoid to recompile namedtuple ATTR classes in lvm. .. Patch Set 1: can you please elaborate in the commit message about the purpose of the change - i.e., how/what does it improve? thanks -- To view, visit http://gerrit.ovirt.org/25678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Meital Bourvine Gerrit-Reviewer: Meital bourvine Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: libvirt_configure: unpersist logrotate.d/libvirt
..
libvirt_configure: unpersist logrotate.d/libvirt
On commit 247a76e7 we moved the libvirt settings to libvirt_configure.sh.in and
now
vdsm cannot rename /etc/logrotate.d/libvirtd on ovirt-node system at the stage
we
execute vdsm-tool configure --force. This patch will add the command unpersist
before renaming the file, otherwise ovirt-node will complain with
"Device or resource busy" and vdsm won't start.
Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1074257
Signed-off-by: Douglas Schilling Landgraf
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/25700/1
diff --git a/lib/vdsm/tool/libvirt_configure.sh.in
b/lib/vdsm/tool/libvirt_configure.sh.in
index 88b4080..eacb37c 100755
--- a/lib/vdsm/tool/libvirt_configure.sh.in
+++ b/lib/vdsm/tool/libvirt_configure.sh.in
@@ -302,12 +302,20 @@
@SED_PATH@ -i 's/^/# VDSM backup/' "$llogr"
@SED_PATH@ -e "/# vdsm/,/# end vdsm/d" "${llogr}" >> "${stanza}"
local oldmod=`/usr/bin/stat --format=%a "${llogr}"`
+
+# unpersist cmd is remove_config on ovirt-functions
+if isOvirtNode; then
+. /usr/libexec/ovirt-functions
+remove_config "${llogr}"
+fi
@MV_PATH@ "${stanza}" "${llogr}"
+
if [ -n "${oldmod}" ]; then
@CHMOD_PATH@ "${oldmod}" "${llogr}"
fi
restorecon "${llogr}"
+# persist cmd is ovirt_store_config on ovirt-functions
if isOvirtNode; then
. /usr/libexec/ovirt-functions
ovirt_store_config "${lconf}" "${qconf}" "${ldconf}" "${llogr}"
--
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.
Antoni Segura Puimedon has posted comments on this change. Change subject: Avoid to recompile namedtuple ATTR classes in lvm. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Meital Bourvine Gerrit-Reviewer: Meital bourvine Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: ifcfg: Do not take bond/nic down when removing one of their ...
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25681
to review the following change.
Change subject: ifcfg: Do not take bond/nic down when removing one of their
multiple nets
..
ifcfg: Do not take bond/nic down when removing one of their multiple nets
When taking removing one of the multiple networks that sit on top of
a bond/nic, it is necessary to adjust the mtu of the devices to the
new maximum required by the remaining networks that use the devices.
Example
netA has mtu 2500 and is set over bond5.10
netB has mtu 2000 and is set over bond5.10
when both are set, bond5.10, bond5 and its link devices will
have mtu 2500. When netA is removed that should be adjusted
to 2000.
For ifcfg to apply the adjustment, it was necessary to ifdown
the nic/bond and up it again so it would read the new configuration.
The problem is that the netB of the example would see a loss of
connectivity which could affect the users. This patch addresses that
by using the ipwrapper to make the mtu adjustment and only take
down the device when no remaining networks use it.
Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a
Bug-Url: https://bugzilla.redhat.com/1060781
Signed-off-by: Antoni S. Puimedon
Reviewed-on: http://gerrit.ovirt.org/25003
Reviewed-by: Dan Kenigsberg
---
M tests/functional/networkTests.py
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
3 files changed, 73 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/25681/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 57fe97e..6b2441c 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -125,6 +125,10 @@
def setUp(self):
self.vdsm_net = VdsProxy()
+def assertMtu(self, mtu, *elems):
+for elem in elems:
+self.assertEquals(mtu, self.vdsm_net.getMtu(elem))
+
@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@@ -215,6 +219,43 @@
status, msg = self.vdsm_net.setupNetworks(
{},
{BONDING_NAME: {'remove': True}}, {'connectivityCheck': False})
+self.assertEqual(status, SUCCESS, msg)
+
+@cleanupNet
+@RequireDummyMod
+@ValidateRunningAsRoot
+def testSetupNetworksDelOneOfBondNets(self):
+NETA_NAME = NETWORK_NAME + 'A'
+NETB_NAME = NETWORK_NAME + 'B'
+NETA_DICT = {'bonding': BONDING_NAME, 'bridged': False, 'mtu': '1600',
+ 'vlan': '4090'}
+NETB_DICT = {'bonding': BONDING_NAME, 'bridged': False, 'mtu': '2000',
+ 'vlan': '4091'}
+with dummyIf(2) as nics:
+status, msg = self.vdsm_net.setupNetworks(
+{NETA_NAME: NETA_DICT,
+ NETB_NAME: NETB_DICT},
+{BONDING_NAME: {'nics': nics}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkExists(NETA_NAME)
+self.assertNetworkExists(NETB_NAME)
+self.assertBondExists(BONDING_NAME, nics)
+self.assertMtu(NETB_DICT['mtu'], BONDING_NAME)
+
+with nonChangingOperstate(BONDING_NAME):
+status, msg = self.vdsm_net.setupNetworks(
+{NETB_NAME: {'remove': True}}, {}, NOCHK)
+
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkExists(NETA_NAME)
+self.assertNetworkDoesntExist(NETB_NAME)
+# Check that the mtu of the bond has been adjusted to the smaller
+# NETA value
+self.assertMtu(NETA_DICT['mtu'], BONDING_NAME)
+
+status, msg = self.vdsm_net.setupNetworks(
+{NETA_NAME: {'remove': True}},
+{BONDING_NAME: {'remove': True}}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
@cleanupNet
@@ -909,10 +950,6 @@
JUMBO = '9000'
MIDI = '4000'
-def assertMtu(mtu, *elems):
-for elem in elems:
-self.assertEquals(mtu, self.vdsm_net.getMtu(elem))
-
with dummyIf(3) as nics:
with self.vdsm_net.pinger():
networks = {NETWORK_NAME + '1':
@@ -928,8 +965,8 @@
self.assertEquals(status, SUCCESS, msg)
-assertMtu(MIDI, NETWORK_NAME + '2', BONDING_NAME, nics[0],
- nics[1])
+self.assertMtu(MIDI, NETWORK_NAME + '2', BONDING_NAME, nics[0],
+ nics[1])
network = {NETWORK_NAME + '3':
dict(bonding=BONDING_NAME, vlan='300', mtu=JUMBO,
@@ -940,8 +977,8 @@
self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME + '3',
bridged=bridged))
-assertMtu(JUMBO, NETW
Change in vdsm[ovirt-3.4]: ifcfg: Do not take bond/nic down when removing one of their ...
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/25680
to review the following change.
Change subject: ifcfg: Do not take bond/nic down when removing one of their
multiple nets
..
ifcfg: Do not take bond/nic down when removing one of their multiple nets
When taking removing one of the multiple networks that sit on top of
a bond/nic, it is necessary to adjust the mtu of the devices to the
new maximum required by the remaining networks that use the devices.
Example
netA has mtu 2500 and is set over bond5.10
netB has mtu 2000 and is set over bond5.10
when both are set, bond5.10, bond5 and its link devices will
have mtu 2500. When netA is removed that should be adjusted
to 2000.
For ifcfg to apply the adjustment, it was necessary to ifdown
the nic/bond and up it again so it would read the new configuration.
The problem is that the netB of the example would see a loss of
connectivity which could affect the users. This patch addresses that
by using the ipwrapper to make the mtu adjustment and only take
down the device when no remaining networks use it.
Change-Id: Ifffad45193ccd047acdefed7412bc9ce6303874a
Bug-Url: https://bugzilla.redhat.com/1060781
Signed-off-by: Antoni S. Puimedon
Reviewed-on: http://gerrit.ovirt.org/25003
Reviewed-by: Dan Kenigsberg
---
M tests/functional/networkTests.py
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
3 files changed, 73 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/25680/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index bdfbb9f..4bc5fcf 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -232,6 +232,10 @@
self.vdsm_net._vlanInRunningConfig(devName, vlanId),
'%s found unexpectedly in running config' % vlanName)
+def assertMtu(self, mtu, *elems):
+for elem in elems:
+self.assertEquals(mtu, self.vdsm_net.getMtu(elem))
+
@cleanupNet
@permutations([[True], [False]])
@RequireDummyMod
@@ -321,6 +325,43 @@
status, msg = self.vdsm_net.setupNetworks(
{},
{BONDING_NAME: {'remove': True}}, {'connectivityCheck': False})
+self.assertEqual(status, SUCCESS, msg)
+
+@cleanupNet
+@RequireDummyMod
+@ValidateRunningAsRoot
+def testSetupNetworksDelOneOfBondNets(self):
+NETA_NAME = NETWORK_NAME + 'A'
+NETB_NAME = NETWORK_NAME + 'B'
+NETA_DICT = {'bonding': BONDING_NAME, 'bridged': False, 'mtu': '1600',
+ 'vlan': '4090'}
+NETB_DICT = {'bonding': BONDING_NAME, 'bridged': False, 'mtu': '2000',
+ 'vlan': '4091'}
+with dummyIf(2) as nics:
+status, msg = self.vdsm_net.setupNetworks(
+{NETA_NAME: NETA_DICT,
+ NETB_NAME: NETB_DICT},
+{BONDING_NAME: {'nics': nics}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkExists(NETA_NAME)
+self.assertNetworkExists(NETB_NAME)
+self.assertBondExists(BONDING_NAME, nics)
+self.assertMtu(NETB_DICT['mtu'], BONDING_NAME)
+
+with nonChangingOperstate(BONDING_NAME):
+status, msg = self.vdsm_net.setupNetworks(
+{NETB_NAME: {'remove': True}}, {}, NOCHK)
+
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkExists(NETA_NAME)
+self.assertNetworkDoesntExist(NETB_NAME)
+# Check that the mtu of the bond has been adjusted to the smaller
+# NETA value
+self.assertMtu(NETA_DICT['mtu'], BONDING_NAME)
+
+status, msg = self.vdsm_net.setupNetworks(
+{NETA_NAME: {'remove': True}},
+{BONDING_NAME: {'remove': True}}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
@cleanupNet
@@ -1005,10 +1046,6 @@
JUMBO = '9000'
MIDI = '4000'
-def assertMtu(mtu, *elems):
-for elem in elems:
-self.assertEquals(mtu, self.vdsm_net.getMtu(elem))
-
with dummyIf(3) as nics:
with self.vdsm_net.pinger():
networks = {NETWORK_NAME + '1':
@@ -1024,8 +1061,8 @@
self.assertEquals(status, SUCCESS, msg)
-assertMtu(MIDI, NETWORK_NAME + '2', BONDING_NAME, nics[0],
- nics[1])
+self.assertMtu(MIDI, NETWORK_NAME + '2', BONDING_NAME, nics[0],
+ nics[1])
network = {NETWORK_NAME + '3':
dict(bonding=BONDING_NAME, vlan='300', mtu=JUMBO,
@@ -1035,8 +1072,8 @@
self.assertEquals(status, SUCCESS, msg)
self.assertNetworkExists(NETWORK_NA
Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid to recompile namedtuple ATTR classes in lvm. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7446/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6654/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7555/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Meital Bourvine Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.
Eduardo has uploaded a new change for review.
Change subject: Avoid to recompile namedtuple ATTR classes in lvm.
..
Avoid to recompile namedtuple ATTR classes in lvm.
Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Signed-off-by: Eduardo
---
M vdsm/storage/lvm.py
1 file changed, 9 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/25678/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 0fbed29..d963736 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -61,7 +61,9 @@
PV = namedtuple("PV", PV_FIELDS + ",guid")
VG = namedtuple("VG", VG_FIELDS + ",writeable,partial")
+VG_ATTR = namedtuple("VG_ATTR", VG_ATTR_BITS)
LV = namedtuple("LV", LV_FIELDS + ",writeable,opened,active")
+LV_ATTR = namedtuple("LV_ATTR", LV_ATTR_BITS)
Stub = namedtuple("Stub", "name, stale")
@@ -185,19 +187,6 @@
return tuple(sTags.split(",")) if sTags else tuple()
-def _attr2NamedTuple(sAttr, attrMask, label):
-"""
-Converts a attr string into a named tuple.
-
-Fields are named as in attrMask.
-"""
-Attrs = namedtuple(label, attrMask)
-# tuple("wz--n-") = ('w', 'z', '-', '-', 'n', '-')
-values = tuple(sAttr[:len(attrMask)])
-attrs = Attrs(*values)
-return attrs
-
-
def makePV(*args):
guid = os.path.basename(args[1])
args += (guid,)
@@ -210,8 +199,10 @@
tags = _tags2Tuple(args[VG._fields.index("tags")])
args[VG._fields.index("tags")] = tags
# Convert attr string into named tuple fields.
-attrs = _attr2NamedTuple(args[VG._fields.index("attr")], VG_ATTR_BITS,
- "VG_ATTR")
+# tuple("wz--n-") = ('w', 'z', '-', '-', 'n', '-')
+sAttr = args[VG._fields.index("attr")]
+attr_values = tuple(sAttr[:len(VG_ATTR._fields)])
+attrs = VG_ATTR(*attr_values)
args[VG._fields.index("attr")] = attrs
# Convert pv_names list to tuple.
args[VG._fields.index("pv_name")] = \
@@ -228,8 +219,9 @@
tags = _tags2Tuple(args[LV._fields.index("tags")])
args[LV._fields.index("tags")] = tags
# Convert attr string into named tuple fields.
-attrs = _attr2NamedTuple(args[LV._fields.index("attr")], LV_ATTR_BITS,
- "LV_ATTR")
+sAttr = args[LV._fields.index("attr")]
+attr_values = tuple(sAttr[:len(LV_ATTR._fields)])
+attrs = LV_ATTR(*attr_values)
args[LV._fields.index("attr")] = attrs
# Add properties. Should be ordered as VG_PROPERTIES.
args.append(attrs.permission == "w") # writable
--
To view, visit http://gerrit.ovirt.org/25678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add boot menu support
Dan Kenigsberg has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a845097294603bbb11e7941995cb1729f388109 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25628/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 147: sd.POSIXFS_DOMAIN: 'posixfs',
Line 148: sd.GLUSTERFS_DOMAIN: 'glusterfs'}
Line 149:
Line 150:
Line 151: def _resolveIscsiIface(ifaceName, initiatorName):
> Renaming this function is not related to this fix. Can you split it to sepa
Sure
Line 152: if not ifaceName:
Line 153: return iscsi.IscsiInterface('default')
Line 154:
Line 155: for iface in iscsi.iterateIscsiInterfaces():
--
To view, visit http://gerrit.ovirt.org/25628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: cleanup post-libvirt merge code
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: cleanup post-libvirt merge code .. vm: cleanup post-libvirt merge code after the libvirt.py merge a couple of methods remained dangling and with out-to-date comment. This tiny patch drop unused code, and improve the documentation of the still useful code with the current state and the feature gap still open with libvirt. Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678 Signed-off-by: Francesco Romani Reviewed-on: http://gerrit.ovirt.org/24744 Reviewed-by: Dan Kenigsberg --- M vdsm/vm.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/24744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: cleanup post-libvirt merge code
Dan Kenigsberg has posted comments on this change. Change subject: vm: cleanup post-libvirt merge code .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e8a888d124fccd878a2ecac30734e58b355678 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hot(un)plug of pci-passthrough devices
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices .. Patch Set 3: waiting for http://gerrit.ovirt.org/#/c/22462/ in case of changes -- To view, visit http://gerrit.ovirt.org/22523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fbf4a1d62789d9404e5977eb7eb01b17a1a43fb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
