Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 30: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9701/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8768/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9554/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1072/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/643/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Hello Federico Simoncelli, Dan Kenigsberg, Kevin Wolf, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/28382 to review the following change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. blockVolume: prepare volumes for shrinkToOptimalSize The qemu-img check command needs the entire volume chain in order to be able to open the image. Up until now shrinkToOptimalSize worked only for base volumes, in the other cases it was failing with: QImgError: ecode=1, stdout=[], stderr=[ Could not open '(image path)': No such file or directory] Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097819 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28009 Reviewed-by: Kevin Wolf kwolf%redhat@gtempaccount.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/blockVolume.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/28382/1 diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index 81881a8..99b0de1 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -289,12 +289,12 @@ volParams = self.getVolumeParams() if volParams['volFormat'] == volume.COW_FORMAT: -self.prepare(justme=True) +self.prepare() try: check = qemuImg.check(self.getVolumePath(), qemuImg.FORMAT.QCOW2) finally: -self.teardown(self.sdUUID, self.volUUID, justme=True) +self.teardown(self.sdUUID, self.volUUID) volActualSize = check['offset'] volExtendSizeMB = int(config.get( irs, volume_utilization_chunk_mb)) -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9702/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8769/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9555/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1073/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
Yeela Kaplan has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/26576/15/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 68: class _ModuleWrapper(types.ModuleType): Line 69: def __init__(self, modName, procPool, ioproc, timeout, subModNames=()): Line 70: self._modName = modName Line 71: self._procPool = procPool Line 72: self._iop = ioproc This is not used (not even in the following patches). True. You are correct. But it is also being removed in the following patches. To fix this would just be wasting time on an unnecessary rebase. cause as it is this patch won't get in without the others. So I'd appreciate if we could skip this fix, unless you feel it's really important. Line 73: self._timeout = timeout Line 74: Line 75: for subModName in subModNames: Line 76: subSubModNames = [] -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement rest of os and os.path functionality
Yeela Kaplan has posted comments on this change. Change subject: Implement rest of os and os.path functionality .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/27482/10/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 184: self.glob = _IOProcessGlob(ioproc) Line 185: self.fileUtils.validateAccess = \ Line 186: _IOProcessFileUtils(ioproc).validateAccess Line 187: self.fileUtils.pathExists = \ Line 188: _IOProcessFileUtils(ioproc).pathExists What about fsyncPath? Same here, Indeed fsyncPath is missing, but this is fixed in following patches. So would just be a time consuming rebase. Up to you... Line 189: self.os.chmod = _IOProcessOs(ioproc).chmod Line 190: self.os.statvfs = _IOProcessOs(ioproc).statvfs Line 191: self.os.rename = _IOProcessOs(ioproc).rename Line 192: self.os.unlink = _IOProcessOs(ioproc).unlink -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: glob.glob ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: glob.glob ioprocess implementation .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9703/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8770/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9556/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1074/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: refactor: open a new connection in specia...
mooli tayer has posted comments on this change. Change subject: libvirtconnection: refactor: open a new connection in special function .. Patch Set 1: (1 comment) One nit, Other than that looks equivalent to old code. http://gerrit.ovirt.org/#/c/28348/1/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 77: __connectionLock = threading.Lock() Line 78: Line 79: Line 80: def _open_qemu_connection(): Line 81: def req(credentials, user_data): _ before? or is it obvious from being inside a func? Line 82: passwd = file(constants.P_VDSM_LIBVIRT_PASSWD).readline().rstrip(\n) Line 83: for cred in credentials: Line 84: if cred[0] == libvirt.VIR_CRED_AUTHNAME: Line 85: cred[4] = constants.SASL_USERNAME -- To view, visit http://gerrit.ovirt.org/28348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33f83d20d1906dcba7b3652abaeddcba14bec6c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Additional oop functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9704/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8771/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1075/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert file metadata to use ioprocess for read/writes .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9705/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8772/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1076/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86beb53885dc935ad473498208e486895eab8315 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 30: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27258/30/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2602:exc_info=True) Line 2603: Line 2604: stats['balloonInfo'] = self._getBalloonInfo() Line 2605: stats.update(self._getGraphicsStats()) Line 2606: stats['userCpuTuneInfo'] = self._getUserCpuTuneInfo() You have to rebase your patch on top of http://gerrit.ovirt.org/27696. Please note that the suggested code has the same problem fixed by that patch. If libvirt somehow blocks, _getUserCpuTuneInfo() would block, and Vdsm's getAllVmStats would block. Line 2607: stats['cpuTuneInfo'] = self._getCpuTuneInfo() Line 2608: stats['cpu_count'] = self._getCpuCount() Line 2609: return stats Line 2610: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoStats implementation using ioprocess instead of RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: repoStats implementation using ioprocess instead of RFH .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9706/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8773/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9559/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1077/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I225b8914801628c625716f58cdca19884081b4b6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: must unpersist files for remove
Hello mooli tayer,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28383
to review the following change.
Change subject: utils: must unpersist files for remove
..
utils: must unpersist files for remove
In rmFile() we must unpersist the file that will be removed
before removing it if the OS is oVirt Node.
Change-Id: I0507fcbc5338aaf76fecb08ca4e6d84138347ec9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1104035
Signed-off-by: Mooli Tayer mta...@redhat.com
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M lib/vdsm/utils.py
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/28383/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index edb715e..836cd3d 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -57,6 +57,12 @@
from .config import config
from . import constants
+try:
+from ovirt.node.utils.fs import Config
+except ImportError:
+# We should continue on non ovirt-node
+pass
+
# Buffsize is 1K because I tested it on some use cases and 1K was fastest. If
# you find this number to be a bottleneck in any way you are welcome to change
# it
@@ -121,6 +127,9 @@
If the file doesn't exist it's assumed that it was already removed.
+if isOvirtNode():
+Config().unpersist(fileToRemove)
+
try:
os.unlink(fileToRemove)
except OSError as e:
@@ -1105,6 +1114,14 @@
sys.exit(-3)
+@memoized
+def isOvirtNode():
+return (
+os.path.exists('/etc/rhev-hypervisor-release') or
+glob.glob('/etc/ovirt-node-*-release')
+)
+
+
# Copied from
# http://docs.python.org/2.6/library/itertools.html?highlight=grouper#recipes
def grouper(iterable, n, fillvalue=None):
--
To view, visit http://gerrit.ovirt.org/28383
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0507fcbc5338aaf76fecb08ca4e6d84138347ec9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9707/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8774/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1078/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add createdir, cleanupdir, simplewalk functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add createdir, cleanupdir, simplewalk functionality .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9708/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8775/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9561/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1079/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica6cb0fee5802c664548011c38e358529b155333 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: must unpersist files for remove
mooli tayer has posted comments on this change. Change subject: utils: must unpersist files for remove .. Patch Set 1: Is there no need to call persist afterwards in such cases? To prevent the file from re appearing after reboot? -- To view, visit http://gerrit.ovirt.org/28383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0507fcbc5338aaf76fecb08ca4e6d84138347ec9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9709/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8776/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/679/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9562/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1080/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement rest of os and os.path functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Implement rest of os and os.path functionality .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9710/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8777/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9563/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1081/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: must unpersist files for remove
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: must unpersist files for remove .. Patch Set 1: Hi Mooli, We do unpersist to be able to remove and do not appear next reboot. -- To view, visit http://gerrit.ovirt.org/28383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0507fcbc5338aaf76fecb08ca4e6d84138347ec9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change file permissions using ioprocess
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change file permissions using ioprocess .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9711/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8778/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9564/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1082/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71ebd4172e53fe0a9c530d29584603b9d2eef5c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit_tests - Build # 3043 - Failure!
- Original Message - From: Francesco Romani from...@redhat.com To: Dan Kenigsberg dan...@redhat.com Cc: smizr...@redhat.com, ybron...@redhat.com, ee...@redhat.com, aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, dc...@redhat.com, lara...@redhat.com, fsimo...@redhat.com Sent: Friday, May 30, 2014 4:15:17 PM Subject: Re: [oVirt Jenkins] vdsm_master_unit_tests - Build # 3043 - Failure! - Original Message - From: Dan Kenigsberg dan...@redhat.com To: from...@redhat.com, smizr...@redhat.com, ybron...@redhat.com Cc: ee...@redhat.com, aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, dc...@redhat.com, lara...@redhat.com, fsimo...@redhat.com Sent: Friday, May 30, 2014 3:00:26 PM Subject: Re: [oVirt Jenkins] vdsm_master_unit_tests - Build # 3043 - Failure! Francesco, Yaniv, Have you found the time to dig into the coredump of these Segmentation faults? (It is unrelated to Liron's new patches) No much progress since last report. I'm very annoyed by this issue but I'm having hard time wrapping my head around it. Let me summarize what I currently know: * the segfault should be reproduceable on any box running nose = 1.3.0, just using $ cd vdsm $ ./configure make $ NOSE_WITH_XUNIT=1 make check or at least I can reproduce the issue on all the boxes I tried locally (vanilla F20, F19) * if we run each testunit separately, we do NOT observe the failure. This triggers the segfault: $ cd tests $ ./run_tests_local.sh ./*.py This does not: $ cd tests $ for TEST in `ls ./*.py`; do ./run_tests_local.sh $TEST; done * the stack traces I observed are huge, more than 750 levels deep. This suggests the stack exausted, and this in turn probably triggered by some kind of recursion gone wild. I think I have that DVD Note the offending stack trace is just on one thread; all the others are quiet. * I tried to reproduce the issue with a simpler use case with no luck so far. At the moment I don't have better suggestions than bite the bullet and dig in the huge stack trace looking for repetitive patterns or some sort of hint. Can't seem to reproduce with 1.3.0 and f20. Where can I get the core dump? Suggestions welcome! -- Francesco Romani RedHat Engineering Virtualization R D Phone: 8261328 IRC: fromani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: must unpersist files for remove
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: must unpersist files for remove .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9565/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1083/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0507fcbc5338aaf76fecb08ca4e6d84138347ec9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: ignore LVs with special tag
Nir Soffer has posted comments on this change. Change subject: lvm: ignore LVs with special tag .. Patch Set 8: Code-Review+1 Should be harmless to current vdsm code, and may be useful even if hosted engine do use vdsm api to create and activate volumes. -- To view, visit http://gerrit.ovirt.org/27880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850bf500e8eabfe414a6d6920155ac0697fe5604 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Daniel Erez has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for hostdev passthrough .. Patch Set 11: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9713/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9566/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/644/ : The patch does not pass the virt functional tests -- To view, visit http://gerrit.ovirt.org/22462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit_tests - Build # 3043 - Failure!
- Original Message - From: Saggi Mizrahi smizr...@redhat.com To: Francesco Romani from...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com, ybron...@redhat.com, ee...@redhat.com, aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, dc...@redhat.com, lara...@redhat.com, fsimo...@redhat.com Sent: Thursday, June 5, 2014 11:24:27 AM Subject: Re: [oVirt Jenkins] vdsm_master_unit_tests - Build # 3043 - Failure! At the moment I don't have better suggestions than bite the bullet and dig in the huge stack trace looking for repetitive patterns or some sort of hint. Can't seem to reproduce with 1.3.0 and f20. Where can I get the core dump? Strange :\ However, here it is another core from my main dev box, which is a F20 with few updates (mostly from virt-preview and few other places - full list, if relevant, provided as pkgs.txt.gz in the folder below) here https://drive.google.com/folderview?id=0B9ZpeH8QzH5rY1NEZUpwZUw2bzQusp=drive_web core.20626.1000.gz is the fresh new core, core.20626.1000.md5 is its checksum. Let me know if I can provide further assistence -- Francesco Romani RedHat Engineering Virtualization R D Phone: 8261328 IRC: fromani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _findLiveSnapshotSupport: do not assume that guest features...
Dan Kenigsberg has posted comments on this change. Change subject: _findLiveSnapshotSupport: do not assume that guest features exist .. Patch Set 1: Francesco, please share your beatification suggestions! -- To view, visit http://gerrit.ovirt.org/28349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e6d1ae6d020bedcfa8f2986fce628714e877765 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utilsTests: Styling of RollbackContextTests
Federico Simoncelli has posted comments on this change.
Change subject: utilsTests: Styling of RollbackContextTests
..
Patch Set 6: Code-Review-1
(1 comment)
Marking -1 for visibility.
http://gerrit.ovirt.org/#/c/22886/6/tests/utilsTests.py
File tests/utilsTests.py:
Line 411: self.fail(Wrong exception was raised)
Line 412:
Line 413: self.fail(Exception was not raised)
Line 414:
Line 415: def testKeyError(self):
What about:
def testKeyError(self):
KeyError is raised as a tuple and not expection. Re-raising it
should be aware of this fact and handled carfully.
def _test():
with utils.RollbackContext():
{}['aKey']
self.assertRaises(KeyError, _test)
or something niftier. Same comment for the other ones.
Line 416:
Line 417: KeyError is raised as a tuple and not expection. Re-raising it
Line 418: should be aware of this fact and handled carfully.
Line 419:
--
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tests: log actual exceptions in RollbackContext
Federico Simoncelli has posted comments on this change. Change subject: Tests: log actual exceptions in RollbackContext .. Patch Set 1: Code-Review-1 This is now useless if in http://gerrit.ovirt.org/22886 we use the standard assertRaises. Marking -1 for visibility. -- To view, visit http://gerrit.ovirt.org/28175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e8244f2b6ede47967025eb35e54ee2401fec30b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: simplify string conversion methods
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9714/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9567/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cdd56cd243095d75a37c66d79e13c2715642d97 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove obsolete volume prepare and teardown
Federico Simoncelli has uploaded a new change for review. Change subject: api: remove obsolete volume prepare and teardown .. api: remove obsolete volume prepare and teardown Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092166 Change-Id: Ic101ebc6e62e83b06b268c52e146cf0740fab887 Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm_api/vdsmapi-schema.json 4 files changed, 0 insertions(+), 142 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/28390/1 diff --git a/vdsm/API.py b/vdsm/API.py index 8b1032d..c43c1d0 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -766,10 +766,6 @@ return self._irs.setVolumeSize(self._sdUUID, self._spUUID, self._imgUUID, self._UUID, newSize) -def prepare(self, rw): -return self._irs.prepareVolume(self._sdUUID, self._spUUID, - self._imgUUID, self._UUID, rw) - def refresh(self): return self._irs.refreshVolume(self._sdUUID, self._spUUID, self._imgUUID, self._UUID) @@ -782,10 +778,6 @@ def setLegality(self, legality): return self._irs.setVolumeLegality(self._sdUUID, self._spUUID, self._imgUUID, self._UUID, legality) - -def tearDown(self): -return self._irs.teardownVolume(self._sdUUID, self._spUUID, -self._imgUUID, self._UUID) class Image(APIBase): diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py index 87ce86f..08a818d 100644 --- a/vdsm/BindingXMLRPC.py +++ b/vdsm/BindingXMLRPC.py @@ -850,10 +850,6 @@ volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) return volume.setSize(newSize) -def volumePrepare(self, sdUUID, spUUID, imgUUID, volUUID, rw=True): -volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) -return volume.prepare(rw) - def volumeRefresh(self, sdUUID, spUUID, imgUUID, volUUID): volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) return volume.refresh() @@ -866,10 +862,6 @@ def volumeSetLegality(self, sdUUID, spUUID, imgUUID, volUUID, legality): volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) return volume.setLegality(legality) - -def volumeTearDown(self, sdUUID, spUUID, imgUUID, volUUID): -volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID) -return volume.tearDown() def taskClear(self, taskId): task = API.Task(taskId) @@ -1079,11 +1071,9 @@ (self.volumeGetPath, 'getVolumePath'), (self.volumeGetSize, 'getVolumeSize'), (self.volumeSetSize, 'volumeSetSize'), -(self.volumePrepare, 'prepareVolume'), (self.volumeRefresh, 'refreshVolume'), (self.volumeSetDescription, 'setVolumeDescription'), (self.volumeSetLegality, 'setVolumeLegality'), -(self.volumeTearDown, 'teardownVolume'), (self.tasksGetAllInfo, 'getAllTasksInfo'), (self.tasksGetAllStatuses, 'getAllTasksStatuses'), (self.tasksGetAll, 'getAllTasks'), diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index e874c23..afc5c0a 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -65,7 +65,6 @@ from threadLocal import vars from vdsm import constants from storageConstants import STORAGE -from resourceFactories import IMAGE_NAMESPACE import resourceManager as rm import devicemapper import logUtils @@ -3127,88 +3126,6 @@ fails = supervdsm.getProxy().rmAppropriateRules(thiefId) if fails: self.log.error(Failed to remove the following rules: %s, fails) - -@public -def prepareVolume(self, sdUUID, spUUID, imgUUID, volUUID, rw=True, - options=None): - -Prepares a volume (used in SAN). -Activates LV and rebuilds 'images' subtree. - -.. warning:: -This method is obsolete and is kept only for testing purposes; -use prepareImage instead. - -:param sdUUID: The UUID of the storage domain that owns the volume. -:type sdUUID: UUID -:param spUUID: The UUID of the storage pool that owns the volume. -:type spUUID: UUID -:param imgUUID: The UUID of the image contained on the volume. -:type imgUUID: UUID -:param volUUID: The UUID of the volume you want to prepare. -:type volUUID: UUID -:param rw: Should the volume be set as RW. ? -:type rw: bool -:param options: ? - -vars.task.getSharedLock(STORAGE, sdUUID) -imageResourcesNamespace = sd.getNamespace(sdUUID, IMAGE_NAMESPACE) -lockType = rm.LockType.exclusive if rw else rm.LockType.shared -
Change in vdsm[master]: api: expose prepare and teardown image
Federico Simoncelli has uploaded a new change for review.
Change subject: api: expose prepare and teardown image
..
api: expose prepare and teardown image
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092166
Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm_api/vdsmapi-schema.json
4 files changed, 75 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/28389/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 0235837..80b8a0b 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1340,6 +1340,18 @@
return 0, image['uuid']
+def prepareImage(self, args):
+if len(args) 3 or len(args) 4:
+raise ValueError('Wrong number of parameters')
+ret = self.s.prepareImage(*args)
+return ret['status']['code'], ret['status']['message']
+
+def teardownImage(self, args):
+if len(args) 3 or len(args) 4:
+raise ValueError('Wrong number of parameters')
+ret = self.s.teardownImage(*args)
+return ret['status']['code'], ret['status']['message']
+
def moveMultiImage(self, args):
spUUID = args[0]
srcDomUUID = args[1]
@@ -2423,6 +2435,14 @@
'Download an image from a remote endpoint using the specified',
'methodArgs.'
)),
+'prepareImage': (serv.prepareImage, (
+'spUUID sdUUID imgUUID [volUUID]',
+'Prepare an image, making the needed volumes available.'
+)),
+'teardownImage': (serv.teardownImage, (
+'spUUID sdUUID imgUUID [volUUID]',
+'Teardown an image, releasing the prepared volumes.'
+)),
'moveMultiImage': (serv.moveMultiImage,
('spUUID srcDomUUID dstDomUUID '
'imgList({imgUUID=postzero,'
diff --git a/vdsm/API.py b/vdsm/API.py
index 3ed1a0c..8b1032d 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -848,6 +848,14 @@
return self._irs.downloadImage(
methodArgs, self._spUUID, self._sdUUID, self._UUID, volUUID)
+def prepare(self, volUUID=None):
+return self._irs.prepareImage(
+self._sdUUID, self._spUUID, self._UUID, volUUID)
+
+def teardown(self, volUUID=None):
+return self._irs.teardownImage(
+self._sdUUID, self._spUUID, self._UUID, volUUID)
+
def uploadToStream(self, methodArgs, callback, startEvent, volUUID=None):
return self._irs.uploadImageToStream(
methodArgs, callback, startEvent, self._spUUID, self._sdUUID,
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 3cb4af7..87ce86f 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -686,6 +686,14 @@
image = API.Image(imgUUID, spUUID, sdUUID)
return image.download(methodArgs, volUUID)
+def imagePrepare(self, spUUID, sdUUID, imgUUID, volUUID=None):
+image = API.Image(imgUUID, spUUID, sdUUID)
+return image.prepare(volUUID)
+
+def imageTeardown(self, spUUID, sdUUID, imgUUID, volUUID=None):
+image = API.Image(imgUUID, spUUID, sdUUID)
+return image.teardown(volUUID)
+
def poolConnect(self, spUUID, hostID, scsiKey, msdUUID, masterVersion,
domainsMap=None, options=None):
pool = API.StoragePool(spUUID)
@@ -1032,6 +1040,8 @@
(self.imageSyncData, 'syncImageData'),
(self.imageUpload, 'uploadImage'),
(self.imageDownload, 'downloadImage'),
+(self.imagePrepare, 'prepareImage'),
+(self.imageTeardown, 'teardownImage'),
(self.poolConnect, 'connectStoragePool'),
(self.poolConnectStorageServer, 'connectStorageServer'),
(self.poolCreate, 'createStoragePool'),
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 993c7f4..1d094b8 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -4162,6 +4162,43 @@
'storagedomainID': 'UUID', 'imageID': 'UUID', '*volumeID': 'UUID'},
'returns': 'UUID'}
+##
+# @Image.prepare:
+#
+# Prepare an image, making the needed volumes available.
+#
+# @storagepoolID:The UUID of the Storage Pool associated with the Image
+#
+# @storagedomainID: The UUID of the Storage Domain associated with the Image
+#
+# @imageID: The UUID of the Image
+#
+# @volumeID: #optional The UUID of the Volume (optional)
+#
+# Since: 4.15.0
+##
+{'command': {'class': 'Image', 'name': 'prepare'},
+ 'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID',
+ 'imageID': 'UUID', '*volumeID': 'UUID'}}
+
+##
+# @Image.teardown:
+#
+# Teardown an image, releasing the prepared volumes.
+#
+# @storagepoolID:
Change in vdsm[master]: netlink: move netlink into a lib vdsm subpackage
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: move netlink into a lib vdsm subpackage .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9715/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8782/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/680/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1441/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9568/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b393588ccb3ac0c4529446c285570f49cdb1e28 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock
Federico Simoncelli has posted comments on this change. Change subject: hsm: unify vm ovf management lock .. Patch Set 1: Verified+1 Same as master. -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: expose prepare and teardown image
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: expose prepare and teardown image .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9716/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8783/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9569/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1084/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Saggi Mizrahi has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 32: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/26300/32/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 229: self.end_headers() Line 230: self.wfile.write(response) Line 231: Line 232: Line 233: class ConnectedTCPServer(SocketServer.TCPServer, object): Why are you also inheriting from object? Line 234: Line 235: def __init__(self, RequestHandlerClass): Line 236: super(ConnectedTCPServer, self).__init__(None, RequestHandlerClass, Line 237: False) http://gerrit.ovirt.org/#/c/26300/32/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 488: res = True if res is None else res Line 489: Line 490: ctx.requestDone(JsonRpcResponse(res, None, req.id)) Line 491: Line 492: @traceback(on=log.name) I don't know who added that traceback function to the code but I don't like it. Please just use plain old try\except. This kind of code makes things needlessly complex and it makes the log errors confusingly similar. Whenever you log an error you need to give context in addition to the traceback. Line 493: def serve_requests(self): Line 494: while True: Line 495: self.log.debug(Waiting for request) Line 496: obj = self._workQueue.get() http://gerrit.ovirt.org/#/c/26300/32/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 136: Line 137: def wakeup(self): Line 138: try: Line 139: os.write(self._write_fd, '1') Line 140: except OSError as e: You would never get to the second condition since if e.errno == errno.EINTR it is necessarily not in (errno.EAGAIN, errno.EWOULDBLOCK). Switch the order of conditions. Line 141: if e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK): Line 142: raise Line 143: elif e.errno == errno.EINTR: Line 144: self.wakeup() Line 174: try: Line 175: data = client_socket.recv(self._required_size, socket.MSG_PEEK) Line 176: except socket.error as e: Line 177: if e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK): Line 178: self.log.warning(Not able to read data) s/Not Able/Unable/ Line 179: self._remove_connection(client_socket) Line 180: client_socket.close() Line 181: return Line 182: -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove obsolete volume prepare and teardown
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: remove obsolete volume prepare and teardown .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9717/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8784/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9570/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1085/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic101ebc6e62e83b06b268c52e146cf0740fab887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
Saggi Mizrahi has posted comments on this change. Change subject: utils: Decrease cpu usage when executing commands .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9718/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8785/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmapi-schema: fix typo in tpm device
Martin Polednik has uploaded a new change for review. Change subject: vdsmapi-schema: fix typo in tpm device .. vdsmapi-schema: fix typo in tpm device Small typo in documentation, VmTpmDeviceType is in no way related to smartcard. Change-Id: I38c616af488f0861e9357249c00c47271e033832 Signed-off-by: Martin Polednik mpole...@redhat.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/28393/1 diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 993c7f4..c7d499d 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2957,7 +2957,7 @@ ## # @VmTpmDeviceType: # -# An enumeration of VM smartcard device types. +# An enumeration of VM tpm device types. # # @tpm: A tpm # -- To view, visit http://gerrit.ovirt.org/28393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I38c616af488f0861e9357249c00c47271e033832 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
Line 36: if arch == 'x86_64':
I think ht efirst version was better - I don't particularly like magic numbers
in the code. Why not put 20480 as the default of the config value? That's
preserving the current behavior on x86_64. And for ppc I think changing it is
fine as there are still very few users (if any)
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
Line 40:
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9719/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9572/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmapi-schema: fix typo in tpm device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsmapi-schema: fix typo in tpm device .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8787/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9573/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38c616af488f0861e9357249c00c47271e033832 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
Line 36: if arch == 'x86_64':
I think ht efirst version was better - I don't particularly like magic numb
Config keys are commented by default, making them more of an indication rather
than setting. This way, x86 and ppc is preserved, allowing for setting upper
memory limit / using direct vmCreate memory limit.
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
Line 40:
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: expose prepare and teardown image
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: expose prepare and teardown image .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9721/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8788/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1086/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Rescan also FC devices
Nir Soffer has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27122/4/vdsm/storage/hba.py File vdsm/storage/hba.py: Line 48: Bear in mind that issue_lip is an asynchronous operation. The command may Line 49: complete before the entire scan has completed. Line 50: Line 51: Note: Must be executed as root. Line 52: TODO: Some drivers do not support this operation. What will happen with such drivers? Will it silently be skipped? It depends on the driver: - If the driver does not expose /issue_lip, we skip this silently We can improve logging in this case, but since we just invested 3 qe days in verification, I think it will not be wise to change this and verify again. So maybe in a separate patch. - If the driver does expose /issue_lip and ignore the write, it will be skipped sliently - If the driver does expose /issue_lip and fail the write, the error will be logged. Line 53: Line 54: log.info(Rescanning HBAs) Line 55: for path in glob.glob(FC_HOST_MASK + '/issue_lip'): Line 56: log.debug(Issuing lip %s, path) -- To view, visit http://gerrit.ovirt.org/27122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7699504f9771232ee0b880f9c83a51fd5b90f40e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove obsolete volume prepare and teardown
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: remove obsolete volume prepare and teardown .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9722/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8789/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9575/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1087/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic101ebc6e62e83b06b268c52e146cf0740fab887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Stomp support
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Stomp support .. Patch Set 23: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Saggi Mizrahi has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 33: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 33: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9723/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8790/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/681/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9576/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1088/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Stomp support
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Stomp support .. Patch Set 23: Code-Review+2 raising score as this does not affect current workflows. -- To view, visit http://gerrit.ovirt.org/26750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Stomp support
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: Stomp support .. jsonrpc: Stomp support The mini broker turned up to be much more work than I expected. This is an intermediate solution. VDSM will accept broker like message but will ignore most of them and not enforce policy. This is so that we can get the engine talking in the correct way and work on the mini broker stress free. This also means that we can release VDSM without the mini broker using a message format that is future ready. It is expected from the engine to send the CONNECT and SUBSCRIBE frames even though VDSM doesn't yet enforce them because future VDSM's probably will. Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Signed-off-by: Saggi Mizrahi smizr...@redhat.com Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Signed-off-by: Saggi Mizrahi smizr...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26750 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm-yajsonrpc.install M lib/yajsonrpc/Makefile.am M lib/yajsonrpc/__init__.py M lib/yajsonrpc/betterAsyncore.py A lib/yajsonrpc/stomp.py A lib/yajsonrpc/stompReactor.py M tests/jsonRpcTests.py M tests/jsonRpcUtils.py M vdsm.spec.in M vdsm/clientIF.py M vdsm_api/BindingJsonRpc.py 11 files changed, 949 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utilsTests: Styling of RollbackContextTests
Nir Soffer has posted comments on this change. Change subject: utilsTests: Styling of RollbackContextTests .. Patch Set 6: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/22886/6/tests/utilsTests.py File tests/utilsTests.py: Line 411: self.fail(Wrong exception was raised) Line 412: Line 413: self.fail(Exception was not raised) Line 414: Line 415: def testKeyError(self): What about: +1 for converting everything here to assertRaises. Line 416: Line 417: KeyError is raised as a tuple and not expection. Re-raising it Line 418: should be aware of this fact and handled carfully. Line 419: -- To view, visit http://gerrit.ovirt.org/22886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Stomp support
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Stomp support .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/682/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1388/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22bcae1e150dea7bc7d9fecefb6847c48bfe8949 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Tests: log actual exceptions in RollbackContext
Nir Soffer has posted comments on this change. Change subject: Tests: log actual exceptions in RollbackContext .. Patch Set 1: -Code-Review Right - both patches should be replaced with one patch using assertRaises. -- To view, visit http://gerrit.ovirt.org/28175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e8244f2b6ede47967025eb35e54ee2401fec30b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Yaniv Bronhaim has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 33: Code-Review+1 please move BindingXMLRPC.py to rpc dir in another patch (this already tested) -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Allon Mureinik has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Allon Mureinik has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28382/1//COMMIT_MSG Commit Message: Line 14: QImgError: ecode=1, stdout=[], stderr=[ Line 15:Could not open '(image path)': No such file or directory] Line 16: Line 17: Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Line 18: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097819 BZ should be cloned to 3.4.z Line 19: Signed-off-by: Federico Simoncelli fsimo...@redhat.com Line 20: Reviewed-on: http://gerrit.ovirt.org/28009 Line 21: Reviewed-by: Kevin Wolf kwolf%redhat@gtempaccount.com -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Kevin Wolf kwolf%redhat@gtempaccount.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock
Allon Mureinik has posted comments on this change. Change subject: hsm: unify vm ovf management lock .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 32: (1 comment) http://gerrit.ovirt.org/#/c/26300/32/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 488: res = True if res is None else res Line 489: Line 490: ctx.requestDone(JsonRpcResponse(res, None, req.id)) Line 491: Line 492: @traceback(on=log.name) Nir suggested to use it. I was suggesting this on the protocol detector, not here, because I did not review this file. This decorator makes code simpler because you don't need to add try blocks around the body of threads target function, and it will not break when your error handling code is broken. This does not replace proper error handling in the thread, but a last resort error handler, ensuring that when the thread dies in the field (because error handling was broken), it will be logged. So instead of: def mainloop(self): try: do stuff and other stuff even more except Exception: logging.exception(thread foo died) You can do: @traceback(on=log.name, msg=thread foo died) def mainloop(self): do stuff and other stuff even more Looking in function body, there is no error handling in the while loop, so any unexpected failure in one of statements will cause the thread to abort silently, which makes it impossible to support this code in the field. Line 493: def serve_requests(self): Line 494: while True: Line 495: self.log.debug(Waiting for request) Line 496: obj = self._workQueue.get() -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding removeConf to sanlock module
Yaniv Bronhaim has posted comments on this change. Change subject: Adding removeConf to sanlock module .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26055/5//COMMIT_MSG Commit Message: Line 7: Adding removeConf to sanlock module Line 8: Line 9: Adding removal of sanlock group for admin users. This will be used in Line 10: vdsm spec file to remove vdsm configuration after uninstall. Line 11: currently we don't do that ,but i guess we should Line 12: Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding removeConf to sanlock module
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding removeConf to sanlock module .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9724/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8791/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: expose prepare and teardown image
Jiří Moskovčák has posted comments on this change. Change subject: api: expose prepare and teardown image .. Patch Set 2: Verified+1 Code-Review+1 Works for my use case. -- To view, visit http://gerrit.ovirt.org/28389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: add qdisc information retrieval
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netlink: add qdisc information retrieval
..
netlink: add qdisc information retrieval
libnl-3 has support for reporting and creating some traffic control
entities. This patch adds support for iterating over queuing
disciplines. E.g:
tc cli output:
~/c/l/l/r/qdisc ❯❯❯ tc qdisc show
qdisc pfifo_fast 8002: dev em1 root refcnt 2 bands 3 priomap 1 2 2 2 1 2 0
0 1 1 1 1 1 1 1 1
qdisc mq 0: dev wlp3s0 root
qdisc pfifo_fast 0: dev tun0 root refcnt 2 bands 3 priomap 1 2 2 2 1 2 0 0
1 1 1 1 1 1 1 1
~/c/l/l/r/qdisc ❯❯❯
would be:
[{'handle': '8001:0',
'index': 3,
'kind': 'hfsc',
'label': 'em1',
'mtu': 1500,
'parent': ':'},
{'handle': '0:0',
'index': 4,
'kind': 'mq',
'label': 'wlp3s0',
'mtu': 1500,
'parent': ':'},
{'handle': '0:0',
'index': 7,
'kind': 'pfifo_fast',
'label': 'tun0',
'mtu': 1500,
'parent': ':'}]
Change-Id: If71aae9de70bd708897dc24db849f6ab73ed3e21
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M configure.ac
M debian/vdsm-python.install
M lib/vdsm/netlink/Makefile.am
A lib/vdsm/netlink/tc/Makefile.am
A lib/vdsm/netlink/tc/__init__.py
A lib/vdsm/netlink/tc/qdisc.py
M vdsm.spec.in
7 files changed, 150 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/28404/1
diff --git a/configure.ac b/configure.ac
index 04ee756..a70c730 100644
--- a/configure.ac
+++ b/configure.ac
@@ -264,6 +264,7 @@
lib/Makefile
lib/vdsm/Makefile
lib/vdsm/netlink/Makefile
+ lib/vdsm/netlink/tc/Makefile
lib/vdsm/tool/Makefile
lib/yajsonrpc/Makefile
lib/zombiereaper/Makefile
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index bb7339e..ab6adff 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -14,6 +14,8 @@
./usr/lib/python2.7/dist-packages/vdsm/netlink/__init__.py
./usr/lib/python2.7/dist-packages/vdsm/netlink/addr.py
./usr/lib/python2.7/dist-packages/vdsm/netlink/link.py
+./usr/lib/python2.7/dist-packages/vdsm/netlink/tc/__init__.py
+./usr/lib/python2.7/dist-packages/vdsm/netlink/tc/qdisc.py
./usr/lib/python2.7/dist-packages/vdsm/profile.py
./usr/lib/python2.7/dist-packages/vdsm/qemuimg.py
./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py
diff --git a/lib/vdsm/netlink/Makefile.am b/lib/vdsm/netlink/Makefile.am
index d947a91..08476b0 100644
--- a/lib/vdsm/netlink/Makefile.am
+++ b/lib/vdsm/netlink/Makefile.am
@@ -18,6 +18,8 @@
#
include $(top_srcdir)/build-aux/Makefile.subs
+SUBDIRS = tc
+
vdsmnetlinkdir = $(vdsmpylibdir)/netlink
dist_vdsmnetlink_PYTHON = \
__init__.py \
diff --git a/lib/vdsm/netlink/tc/Makefile.am b/lib/vdsm/netlink/tc/Makefile.am
new file mode 100644
index 000..0c43f23
--- /dev/null
+++ b/lib/vdsm/netlink/tc/Makefile.am
@@ -0,0 +1,25 @@
+# Copyright 2014 Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+include $(top_srcdir)/build-aux/Makefile.subs
+
+vdsmnetlinktcdir = $(vdsmpylibdir)/netlink/tc
+dist_vdsmnetlink_PYTHON = \
+ __init__.py \
+ qdisc.py \
+ $(NULL)
diff --git a/lib/vdsm/netlink/tc/__init__.py b/lib/vdsm/netlink/tc/__init__.py
new file mode 100644
index 000..c4f0d74
--- /dev/null
+++ b/lib/vdsm/netlink/tc/__init__.py
@@ -0,0 +1,55 @@
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
Change in vdsm[master]: Remove redundant print
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove redundant print
..
Remove redundant print
This print add usage explanation of vdsm-tool command on error. There is
no need for such print. Unless UsageError refers actually to the verb
usage, but currently we use it for any usage error.
Change-Id: I6df376664ffcda66ea19f66e28edc0521566c091
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm-tool/vdsm-tool
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/28406/1
diff --git a/vdsm-tool/vdsm-tool b/vdsm-tool/vdsm-tool
index 21e378f..365ff3c 100755
--- a/vdsm-tool/vdsm-tool
+++ b/vdsm-tool/vdsm-tool
@@ -154,7 +154,6 @@
return tool_command[cmd][command](*args)
except vdsm.tool.UsageError as e:
print('Error: ', e, '\n', file=sys.stderr)
-print_command_usage(tool_command[cmd][command], sys.stderr)
return 1
except Exception:
traceback.print_exc(file=sys.stderr)
--
To view, visit http://gerrit.ovirt.org/28406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6df376664ffcda66ea19f66e28edc0521566c091
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting enum for isconfigured return value and change overri...
Yaniv Bronhaim has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/28007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
Yaniv Bronhaim has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 22: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
Yaniv Bronhaim has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/27298/21/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 597: ) Line 598: sys.stdout.write(out) Line 599: sys.stderr.write(err) Line 600: if rc != 0: Line 601: raise RuntimeError(Failed to perform sanlock config.) Should this not be invalidRun too? yes.. but you don't want to change anything that doesn't relate to your change. so leave it for now Line 602: Line 603: def isconfigured(self): Line 604: Line 605: True if sanlock service is configured, False if sanlock service -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove obsolete volume prepare and teardown
Nir Soffer has posted comments on this change. Change subject: api: remove obsolete volume prepare and teardown .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28390/2//COMMIT_MSG Commit Message: Line 4: Commit: Federico Simoncelli fsimo...@redhat.com Line 5: CommitDate: 2014-06-05 07:57:25 -0400 Line 6: Line 7: api: remove obsolete volume prepare and teardown Line 8: Please explain why these are obsolete and since when. Isn't this the api suggested by Dan to be used by hosted engine? https://bugzilla.redhat.com/show_bug.cgi?id=1094657#c7 Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092166 Line 10: Change-Id: Ic101ebc6e62e83b06b268c52e146cf0740fab887 -- To view, visit http://gerrit.ovirt.org/28390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic101ebc6e62e83b06b268c52e146cf0740fab887 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
Yaniv Bronhaim has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 22: just verify again. the code looks complete from my prospective -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: expose prepare and teardown image
Dan Kenigsberg has submitted this change and it was merged. Change subject: api: expose prepare and teardown image .. api: expose prepare and teardown image Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092166 Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28389 Reviewed-by: Jiří Moskovčák jmosk...@redhat.com Tested-by: Jiří Moskovčák jmosk...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm_api/vdsmapi-schema.json 4 files changed, 85 insertions(+), 0 deletions(-) Approvals: Jiří Moskovčák: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: expose prepare and teardown image
Dan Kenigsberg has posted comments on this change. Change subject: api: expose prepare and teardown image .. Patch Set 2: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/28389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: expose prepare and teardown image
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: expose prepare and teardown image .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1389/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4e21513a2a888ff5ee4bc085a3da9a8bf8980b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Setting enum for isconfigured return value and change overri...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9725/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8792/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9578/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: This commit adds a man page for the vdsm-tool command line u...
Dan Kenigsberg has posted comments on this change. Change subject: This commit adds a man page for the vdsm-tool command line utility. .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28196/1/vdsm-tool/vdsm-tool.1.in File vdsm-tool/vdsm-tool.1.in: Line 186: Author list Line 187: .SH BUGS Line 188: Report bugs to http://bugzilla.redhat.com Line 189: .SH COPYRIGHT Line 190: Copyright 2011 Red Hat, Inc. License GPLv2: GNU GPL Version 2 http://gnu.org/licenses/gpl.html. shouldn't be 2014? that's the copyright of the code (not of the docs) so the years should be 2011-2014, I suppose. -- To view, visit http://gerrit.ovirt.org/28196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Decrease cpu usage when executing commands .. utils: Decrease cpu usage when executing commands After optimizing list2cmdline, we can see that the profile is dominated by utils.execCmd() and related functions such as AsyncProc._processStreams(). This code is quite complex, using fancy classes such as AsyncProc and _streamWrapper, and using epoll to poll for 3 file descriptors. These are useful when reading asynchronously from multiple streams without risk of deadlock. However, for invoking commands synchronously, polling 2 file descriptors, CPopen.communicate, using poll, is safe and much more efficient. This patch avoids wrapping of the CPopen object with AsyncProc when executing commands in sync mode. I tested this on two identical RHEL 6.5 machines connected to 32 storage domains. Each one run 5 minutes as spm, and 5 minutes as hsm during 10 minutes profiling session. The first system was running the previous patch in this branch: Tue May 13 09:47:10 2014/var/run/vdsm/vdsmd.prof 8410533 function calls (8466483 primitive calls) in 70.879 CPU seconds Ordered by: internal time List reduced from 1872 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 12818873.4040.0006.0380.000 utils.py:557(AsyncProc._processStreams) 1316702.1620.0002.1740.000 pthread.py:98(Lock.unlock) 248982.1340.000 10.0160.000 utils.py:466(_streamWrapper._readNonBlock) 1144371.9920.0002.0180.000 pthread.py:95(Lock.lock) 179961.9160.000 21.2930.001 io.py:492(BufferedReader.readline) 98/1361.9120.020 23.9860.176 threading.py:481(Thread.run) 59181.8290.0006.4380.001 misc.py:125(findCaller) 576581.7380.0001.8210.000 genericpath.py:85(_splitext) 100051.6440.0003.4790.000 __init__.py:226(LogRecord.__init__) 24521.4970.0018.3570.003 utils.py:623(AsyncProc.wait) Ordered by: cumulative time List reduced from 1872 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 34/360.0070.000 68.2141.895 utils.py:770(wrapper) 320.0690.002 67.9692.124 domainMonitor.py:163(DomainMonitorThread._monitorLoop) 985/20400.7280.001 67.4710.033 domainMonitor.py:186(DomainMonitorThread._monitorDomain) 24500.4470.000 53.6690.022 utils.py:666(execCmd) 20400.0930.000 46.1610.023 blockSD.py:594(BlockStorageDomain.getReadDelay) 20400.1310.000 45.8450.022 misc.py:222(readspeed) 20400.3100.000 45.6960.022 misc.py:192(_readfile) 24470.1330.000 33.0600.014 utils.py:633(AsyncProc.communicate) 98/1361.9120.020 23.9860.176 threading.py:481(Thread.run) 17994/179960.2500.000 21.5440.001 io.py:532(BufferedReader.next) The seconds system was running with this patch: Tue May 13 09:47:04 2014/var/run/vdsm/vdsmd.prof 1988663 function calls (2044070 primitive calls) in 36.675 CPU seconds Ordered by: internal time List reduced from 1871 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 98/1366.6430.068 19.0590.140 threading.py:481(Thread.run) 95081.5660.0002.8010.000 __init__.py:226(LogRecord.__init__) 57951.5110.0004.9480.001 misc.py:125(findCaller) 562501.3120.0001.4050.000 genericpath.py:85(_splitext) 23611.3060.0012.0840.001 subprocess.py:1344(CPopen._communicate_with_poll) 389150.8810.0002.7660.000 misc.py:110(_shouldLogSkip) 56233/562500.8270.0002.2390.000 posixpath.py:94(splitext) 95080.7130.0005.6440.001 __init__.py:1204(Logger.callHandlers) 320830.5980.0000.5980.000 misc.py:84(checkForSkip) 6953/69650.5910.0000.6270.000 pthread.py:133(Cond.timedwait) Ordered by: cumulative time List reduced from 1871 to 10 due to restriction 10 ncalls tottime percall cumtime percall filename:lineno(function) 34/360.0010.000 27.9570.777 utils.py:770(wrapper) 320.0410.001 27.7670.868 domainMonitor.py:163(DomainMonitorThread._monitorLoop) 840/19570.4040.000 27.4540.014 domainMonitor.py:186(DomainMonitorThread._monitorDomain) 98/1366.6430.068 19.0590.140 threading.py:481(Thread.run) 2365
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Decrease cpu usage when executing commands .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1390/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9726/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8793/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9579/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1089/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: This commit adds a man page for the vdsm-tool command line u...
Dan Kenigsberg has submitted this change and it was merged. Change subject: This commit adds a man page for the vdsm-tool command line utility. .. This commit adds a man page for the vdsm-tool command line utility. This commit adds the file vdsm-tool.1.in to the vdsm-tool directory, updates the vdsm-tool make file and the vdsm spec file to include and install the new man page for vdsm-tool to the /usr/share/man/man1 directory. Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Signed-off-by: Andrew Dahms andrewjda...@gmail.com Reviewed-on: http://gerrit.ovirt.org/28196 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm-tool/Makefile.am A vdsm-tool/vdsm-tool.1.in M vdsm.spec.in 3 files changed, 198 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: This commit adds a man page for the vdsm-tool command line u...
Dan Kenigsberg has posted comments on this change. Change subject: This commit adds a man page for the vdsm-tool command line utility. .. Patch Set 2: Verified+1 Code-Review+2 Copying score, only a minor text change. -- To view, visit http://gerrit.ovirt.org/28196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: glob.glob ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: glob.glob ioprocess implementation .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9727/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8794/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9580/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1090/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Additional oop functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9728/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8795/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9581/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1091/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 16:
(1 comment)
http://gerrit.ovirt.org/#/c/25976/16/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 409: self._lowmark = None
Line 410:
Line 411: while not self._stop.isSet():
Line 412: self._stop.wait(MonitorThread._MONITOR_TICK)
Line 413: if self.enabled:
self.enabled is a constant - why is it tested repeatedly within the thread? Why
wake up every second to do nothing?
Line 414: self.monitor_migration(step)
Line 415: step += 1
Line 416:
Line 417: self._vm.log.debug('migration monitor thread exiting')
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert file metadata to use ioprocess for read/writes .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9729/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8796/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9582/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1092/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86beb53885dc935ad473498208e486895eab8315 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoStats implementation using ioprocess instead of RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: repoStats implementation using ioprocess instead of RFH .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9730/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8797/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9583/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1093/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I225b8914801628c625716f58cdca19884081b4b6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9731/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8798/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9584/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1094/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add createdir, cleanupdir, simplewalk functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add createdir, cleanupdir, simplewalk functionality .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9732/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8799/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9585/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1095/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica6cb0fee5802c664548011c38e358529b155333 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 30: (1 comment) http://gerrit.ovirt.org/#/c/27258/30/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2602:exc_info=True) Line 2603: Line 2604: stats['balloonInfo'] = self._getBalloonInfo() Line 2605: stats.update(self._getGraphicsStats()) Line 2606: stats['userCpuTuneInfo'] = self._getUserCpuTuneInfo() You have to rebase your patch on top of http://gerrit.ovirt.org/27696. Plea Done Line 2607: stats['cpuTuneInfo'] = self._getCpuTuneInfo() Line 2608: stats['cpu_count'] = self._getCpuCount() Line 2609: return stats Line 2610: -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 31: Not verified yet -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 7: -Code-Review -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9733/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8800/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/683/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9586/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1096/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement rest of os and os.path functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Implement rest of os and os.path functionality .. Patch Set 13: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9734/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8801/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9588/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1098/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: Protocol detection
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 33: (6 comments) protocol detection and xmlrpc looks fine, expect two issues: - This patch exposes a bug we had in the non-secure xmlprc version, where http 1.1 is not used. This causes a regression in the secure xmlrpc version. Trivial fix, but requires some testing with ssl=false. - None return value from SSLSocket.recv is not handled - trivial fix. http://gerrit.ovirt.org/#/c/26300/33/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 90: HTTP_HEADER_FLOWID = FlowID Line 91: Line 92: threadLocal = self.cif.threadLocal Line 93: Line 94: basehandler = SimpleXMLRPCServer.SimpleXMLRPCRequestHandler This change expose a bug in the non-secure xmlrpc version. SecureXMLRPCServer.SecureXMLRPCRequestHandler used before this patch is actually utils.IPXMLRPCRequestHandler, which is modified to support HTTP/1.1 since ovirt-3.4. So the correct code here would to remove the basehandler variable and replace its usage with utils.IPXMLRPCRequestHandler. This requires testing vdsm with ssl=false in vdsm.conf. Line 95: Line 96: class RequestHandler(basehandler): Line 97: Line 98: # Timeout for the request socket Line 92: threadLocal = self.cif.threadLocal Line 93: Line 94: basehandler = SimpleXMLRPCServer.SimpleXMLRPCRequestHandler Line 95: Line 96: class RequestHandler(basehandler): basehandler - utils.IPXMLRPCRequestHandler Line 97: Line 98: # Timeout for the request socket Line 99: timeout = 60 Line 100: log = logging.getLogger(BindingXMLRPC.RequestHandler) Line 115: Line 116: def setup(self): Line 117: threadLocal.client = self.client_address[0] Line 118: threadLocal.server = self.request.getsockname()[0] Line 119: return basehandler.setup(self) basehandler - utils.IPXMLRPCRequestHandler Line 120: Line 121: def do_GET(self): Line 122: try: Line 123: length = self._getIntHeader(self.HEADER_SIZE, Line 258: self.end_headers() Line 259: self.wfile.write(json_response) Line 260: Line 261: def parse_request(self): Line 262: r = basehandler.parse_request(self) basehandler - utils.IPXMLRPCRequestHandler Line 263: threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID) Line 264: return r Line 265: Line 266: def finish(self): Line 263: threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID) Line 264: return r Line 265: Line 266: def finish(self): Line 267: basehandler.finish(self) basehandler - utils.IPXMLRPCRequestHandler Line 268: threadLocal.client = None Line 269: threadLocal.server = None Line 270: threadLocal.flowID = None Line 271: http://gerrit.ovirt.org/#/c/26300/33/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 178: self.log.warning(Unable to read data) Line 179: self._remove_connection(client_socket) Line 180: client_socket.close() Line 181: return Line 182: Looking in the betterAsyncore.py, we should handle here the case where data is None. This happens when using M2Crypto, if the SSLSocket want to read more data from the other side before it can return data. I would add this for now: if data is None: # SSLSocket wants to read more data from the peer return Line 183: self._remove_connection(client_socket) Line 184: try: Line 185: handler = self.detect_protocol(data) Line 186: except _CannotDetectProtocol: -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes
Change in vdsm[master]: Change file permissions using ioprocess
oVirt Jenkins CI Server has posted comments on this change. Change subject: Change file permissions using ioprocess .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9735/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8802/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9587/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1097/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71ebd4172e53fe0a9c530d29584603b9d2eef5c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: simplify string conversion methods
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: simplify string conversion methods .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8803/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9589/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cdd56cd243095d75a37c66d79e13c2715642d97 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: This commit adds a man page for the vdsm-tool command line u...
oVirt Jenkins CI Server has posted comments on this change. Change subject: This commit adds a man page for the vdsm-tool command line utility. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/687/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1391/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: add qdisc information retrieval
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: add qdisc information retrieval .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9738/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8805/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/685/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9591/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71aae9de70bd708897dc24db849f6ab73ed3e21 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: move netlink into a lib vdsm subpackage
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: move netlink into a lib vdsm subpackage .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9737/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8804/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/684/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1442/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9590/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b393588ccb3ac0c4529446c285570f49cdb1e28 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9739/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8806/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9592/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6df376664ffcda66ea19f66e28edc0521566c091 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: This commit adds a man page for the vdsm-tool command line u...
oVirt Jenkins CI Server has posted comments on this change. Change subject: This commit adds a man page for the vdsm-tool command line utility. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9740/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8807/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9593/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 31: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9741/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8808/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9594/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1099/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/645/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
