Change in vdsm[master]: virt: add support to cancel the core dump of a VM.
Francesco Romani has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM.
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py
File vdsm/virt/coredump.py:
Line 49: if postAction:
Line 50: self.flags |= CoreDumpThread.postActionFlags[postAction]
Line 51: if bypassCache:
Line 52: self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE
Line 53: self.memoryOnly = memoryOnly
What is this needed for?
Looks like is no longer needed. Will remove.
Line 54: if memoryOnly:
Line 55: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY
Line 56:
Line 57: self.status = {'code': CoreDumpThread.Status.NONE,
--
To view, visit http://gerrit.ovirt.org/11130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add support to dump the core of a VM
Francesco Romani has posted comments on this change.
Change subject: vm: add support to dump the core of a VM
..
Patch Set 20:
(1 comment)
http://gerrit.ovirt.org/#/c/7329/20/client/vdsClient.py
File client/vdsClient.py:
Line 1806:
Line 1807: def coreDump(self, args):
Line 1808: vmId = args[0]
Line 1809: coreFile = args[1]
Line 1810: postAction = None
Should this be:
Thanks, fixed.
Line 1811: bypassCache = False
Line 1812: memoryOnly = False
Line 1813: params = {}
Line 1814: if len(args) 2:
--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support to cancel the core dump of a VM.
Francesco Romani has posted comments on this change.
Change subject: virt: add support to cancel the core dump of a VM.
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py
File vdsm/virt/coredump.py:
Line 49: if postAction:
Line 50: self.flags |= CoreDumpThread.postActionFlags[postAction]
Line 51: if bypassCache:
Line 52: self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE
Line 53: self.memoryOnly = memoryOnly
Looks like is no longer needed. Will remove.
Sorry, talked too early. It is used in vm.py in coreDumpCancel as part of the
early checks.
Line 54: if memoryOnly:
Line 55: self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY
Line 56:
Line 57: self.status = {'code': CoreDumpThread.Status.NONE,
--
To view, visit http://gerrit.ovirt.org/11130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add assertNotRaises assertion
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add assertNotRaises assertion
..
tests: Add assertNotRaises assertion
Typically we like failing assertions to cause a test failure, and any
other error to cause a test error. However, in some case we like any
error to be considered as test failure. For example, if I'm testing
code writing a file, and the test is verifying the code by parsing the
file, we can have many possible errors that mean test failure - missing
file, parsing error, and sometimes just any error. In this case, we may
get a test error instead of a failure, and waste time suspecting error
free test code.
This patch add a new assertNotRaises assertion, making it easy to get a
test failure in such cases.
This assertion can be used inline:
self.assertNotRaises(func, foo, bar=2)
Or as a context manager:
with self.assertNotRaises():
that_func('foo')
other_func(bar=2)
The test will fail if any error was raised.
Change-Id: I33c96ca855753a75ffe2f82bdecab2e1612da08a
Signed-off-by: Nir Soffer nsof...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/28177
Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M tests/Makefile.am
M tests/testrunner.py
A tests/testrunnerTests.py
3 files changed, 63 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33c96ca855753a75ffe2f82bdecab2e1612da08a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add assertNotRaises assertion
Martin Sivák has posted comments on this change. Change subject: tests: Add assertNotRaises assertion .. Patch Set 3: I understand the reasoning, unfortunately your code will also report SyntaxError and ImportError as test failures. But I was not strongly opposed so I gave it no score (as it already had +2 from Dan). -- To view, visit http://gerrit.ovirt.org/28177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33c96ca855753a75ffe2f82bdecab2e1612da08a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add assertNotRaises assertion
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add assertNotRaises assertion .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1463/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33c96ca855753a75ffe2f82bdecab2e1612da08a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Introduce cancellation points
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10127/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10283/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5209/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1304/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Stop domain monitors concurrently .. Patch Set 5: Changes: - Ensure that a monitor invokes its finish callback even if exceptions are raised - Remove redundant removal of monitors in waitForMonitor - Log warning if monitor does not exits when removed - Fix incorrect error handling when stopping monitoring - previous code could hide KeyError inside DomainMonitor.stop() - Fix incorrect error handling when waiting for monit - previous code could hide KeyError inside DomainMonitor.wait() - Fix ugliness calling waitForMonitor in stopMonitoring, now simply invoke monitor.wait() -- To view, visit http://gerrit.ovirt.org/27573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Extract domain monitoring methods
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Extract domain monitoring methods .. Patch Set 4: Rebase on http://gerrit.ovirt.org/27573 -- To view, visit http://gerrit.ovirt.org/27714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Extract domain monitoring methods
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Extract domain monitoring methods .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10128/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5210/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3368/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1305/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Extract domain monitoring methods
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Extract domain monitoring methods .. Patch Set 4: This version unify methods for producing domain and setting iso info, so the function have no logic, and they are called only if needed, like all other functions. This make these functions candicates for cancellation point (see next patch). Since the logic for these function is having uninitialized instance variable, I did not create _shouldProduceDomain and _shouldSetIsoInfo methods, as it seems to obscure the code, and it is not expected the change. -- To view, visit http://gerrit.ovirt.org/27714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Introduce cancellation points
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 4: This version mark more methods that may block as cancellation points. -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: command to create and delete a geo-replication session
Darshan N has restored this change. Change subject: gluster: command to create and delete a geo-replication session .. Restored -- To view, visit http://gerrit.ovirt.org/17644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support to dump the core of a VM
Francesco Romani has posted comments on this change. Change subject: virt: add support to dump the core of a VM .. Patch Set 21: changes: - fixes vdsClient as Adam pointed out - since coredump.py is a new module, make it compliant with http://wiki.ovirt.org/Vdsm_Coding_Guidelines -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support to cancel the core dump of a VM.
Francesco Romani has posted comments on this change. Change subject: virt: add support to cancel the core dump of a VM. .. Patch Set 16: changes: - move checks from vm.py to coredump.py to reduce the load in vm.py and to show clearly what the field memory_only is for. -- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support to get the status of core dump
Francesco Romani has posted comments on this change. Change subject: virt: add support to get the status of core dump .. Patch Set 15: rebased; pep8/stile fixes. -- To view, visit http://gerrit.ovirt.org/11131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d552db4dbd88762950ec5a113a25c13b73319c8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Stop domain monitors concurrently .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9345/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10129/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5211/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1306/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 51: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1307/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding removeConf to sanlock module
Yaniv Bronhaim has posted comments on this change. Change subject: Adding removeConf to sanlock module .. Patch Set 6: (1 comment) did you test configure sanlock module on ovirt node? where do we persist /etc/groups after the spec configure call that you added? http://gerrit.ovirt.org/#/c/26055/6/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 639: raw=True, Line 640: ) Line 641: sys.stdout.write(out) Line 642: sys.stderr.write(err) Line 643: What about include: if isOvirt: persist /etc/group we need to add it both here and in configure as you said. please post a patch for that and rebase it on this one (I don't familiar with the node semantics enough) Line 644: if rc != 0: Line 645: raise InvalidRun(Failed to remove sanlock groups.) Line 646: Line 647: def isconfigured(self): -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support to dump the core of a VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: add support to dump the core of a VM .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9346/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10130/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/885/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5212/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3370/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1308/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
Francesco Romani has posted comments on this change. Change subject: profile: Test profile decorator format .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
Francesco Romani has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 7: Code-Review+1 maybe permutations() may be of some help, but good enough already. -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/25978/21/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 342: runnable.start() Line 343: try: Line 344: yield runnable Line 345: finally: Line 346: runnable.stop() Now when this generic utility, why not move it to lib/vdsm/utils.py? Done Line 347: Line 348: Line 349: class MonitorThread(threading.Thread): Line 350: _MONITOR_TICK = 1.0 # unit: seconds -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 20: rebased -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 19: rebased -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 21: moved running() into utils; rebased -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support to get the status of core dump
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: add support to get the status of core dump .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/886/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10287/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5213/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3371/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1309/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/11131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d552db4dbd88762950ec5a113a25c13b73319c8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 10: rebased -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
Francesco Romani has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 4: rebased -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
Nir Soffer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 3: Douglas, isn't your patch conflict with Mooly next patch? http://gerrit.ovirt.org/28821 -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mounts: Optimize mount loop device resolution
Yaniv Bronhaim has posted comments on this change. Change subject: mounts: Optimize mount loop device resolution .. Patch Set 5: he didn't. please open for followup -- To view, visit http://gerrit.ovirt.org/28586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f11786b45782cedd994d52e1e506292132fa47 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
Francesco Romani has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 4: rebased -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
Nir Soffer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 3: Douglas, any reason to rebase on http://gerrit.ovirt.org/28821 instead of 28821 rebased on this patch? If it does not matter, could you remove your -1? Or do you have other concerns about this? -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Nir Soffer has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 22: Code-Review+1 Nice! -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: ignore html schema output
Francesco Romani has uploaded a new change for review. Change subject: janitorial: ignore html schema output .. janitorial: ignore html schema output update the ouput path of the schema html. Change-Id: I5193a381f70b8ef9293ac7c6ba5e235d05822dc7 Signed-off-by: Francesco Romani from...@redhat.com --- M .gitignore 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/28836/1 diff --git a/.gitignore b/.gitignore index 72155dc..5e8b53f 100644 --- a/.gitignore +++ b/.gitignore @@ -70,7 +70,7 @@ vdsm/vdsmd.8 vdsm/gluster/hostname.py vdsm-tool/vdsm-tool.1 -vdsm_api/vdsm-api.html +vdsm/rpc/vdsm-api.html vdsm_hooks/openstacknet/sudoers vdsm_hooks/persist-vdsm-hooks vdsm_reg/config.py -- To view, visit http://gerrit.ovirt.org/28836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5193a381f70b8ef9293ac7c6ba5e235d05822dc7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move Vm._reportError into utils
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: move Vm._reportError into utils
..
janitorial: move Vm._reportError into utils
this function has nothing vm-specific and it is
general purpose.
This patch just moves code around with no
functional changes.
Change-Id: I01e822429b360bd0973d05b4831ba1b42b93a27f
Signed-off-by: Francesco Romani from...@redhat.com
---
M lib/vdsm/utils.py
M vdsm/virt/vm.py
2 files changed, 19 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/28835/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 343d7ea..f241f17 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -55,6 +55,7 @@
from cpopen import CPopen
from .config import config
+from .define import errCode
from . import constants
# Buffsize is 1K because I tested it on some use cases and 1K was fastest. If
@@ -1285,3 +1286,15 @@
def prependDefer(self, func, *args, **kwargs):
self._finally.insert(0, (func, args, kwargs))
+
+
+def reportError(self, key, msg=None):
+
+Produce an error status.
+
+if msg is None:
+error = errCode[key]
+else:
+error = {'status': {'code': errCode[key]
+['status']['code'], 'message': msg}}
+return error
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 344af86..7dfc11b 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3662,7 +3662,7 @@
if not params:
self.log.error(updateVmPolicy got an empty policy.)
-return self._reportError(key='MissParam',
+return utils.reportError(key='MissParam',
msg=updateVmPolicy got an empty policy.)
#
@@ -3680,7 +3680,7 @@
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
return errCode['noVM']
else:
-return self._reportError(key='updateVmPolicyErr',
+return utils.reportError(key='updateVmPolicyErr',
msg=e.message)
else:
del params['vcpuLimit']
@@ -4778,7 +4778,7 @@
def setBalloonTarget(self, target):
if self._dom is None:
-return self._reportError(key='balloonErr')
+return utils.reportError(key='balloonErr')
try:
target = int(target)
self._dom.setMemory(target)
@@ -4802,7 +4802,7 @@
try:
self._dom.setSchedulerParameters({'vcpu_quota': int(quota)})
except ValueError:
-return self._reportError(key='cpuTuneErr',
+return utils.reportError(key='cpuTuneErr',
msg='an integer is required for period')
except libvirt.libvirtError as e:
return self._reportException(key='cpuTuneErr', msg=e.message)
@@ -4812,22 +4812,11 @@
try:
self._dom.setSchedulerParameters({'vcpu_period': int(period)})
except ValueError:
-return self._reportError(key='cpuTuneErr',
+return utils.reportError(key='cpuTuneErr',
msg='an integer is required for period')
except libvirt.libvirtError as e:
return self._reportException(key='cpuTuneErr', msg=e.message)
return {'status': doneCode}
-
-def _reportError(self, key, msg=None):
-
-Produce an error status.
-
-if msg is None:
-error = errCode[key]
-else:
-error = {'status': {'code': errCode[key]
-['status']['code'], 'message': msg}}
-return error
def _reportException(self, key, msg=None):
@@ -4835,7 +4824,7 @@
This method should be called only within exception-handling context.
self.log.exception(Operation failed)
-return self._reportError(key, msg)
+return utils.reportError(key, msg)
def _getUnderlyingDeviceAddress(self, devXml):
--
To view, visit http://gerrit.ovirt.org/28835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01e822429b360bd0973d05b4831ba1b42b93a27f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9350/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10134/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/888/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10289/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5215/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3373/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
Nir Soffer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28782/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 322: try: Line 323: os.unlink(content['path']) Line 324: Line 325: if utils.isOvirtNode(): Line 326: NodeCfg().unpersist(content['path']) Does it raise OSError? If NodeCfg().unpersist(content['path']) has its own error handling, and does not need the ENOENT check, please move it outside the try block. Line 327: except OSError as e: Line 328: if e.errno != errno.ENOENT: Line 329: raise InvalidRun(Removing file: %s failed, content['path']) Line 330: -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: ignore html schema output
Francesco Romani has posted comments on this change. Change subject: janitorial: ignore html schema output .. Patch Set 1: Verified+1 verified by running `git status' before and after this patch -- To view, visit http://gerrit.ovirt.org/28836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5193a381f70b8ef9293ac7c6ba5e235d05822dc7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Introduce cancellation points
Yaniv Bronhaim has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28721/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 816: @functools.wraps(meth) Line 817: def wrapper(self, *a, **kw): Line 818: if self.__canceled__(): Line 819: raise Canceled() Line 820: return meth(self, *a, **kw) meth because it is a method and the first argument is self - needed for a I got it that meth refers to method, just saying that i never saw meth in decorators, commonly people use func for everything. but ANYWAY, only DomainMonitor uses it right now. put it near it (shouldn't be on misc either imo). that's my preference, you don't have to follow and i didn't nack or ack it Line 821: return wrapper Line 822: Line 823: Line 824: def tobool(s): -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28560/1/vdsm/API.py File vdsm/API.py: Line 983: self._UUID = UUID Line 984: Line 985: def connect(self, hostID, scsiKey, masterSdUUID, masterVersion, Line 986: domainsMap=None): Line 987: # scsiKey is deprecated. it is retained here so as not to break the API The comment is good but it repeats 3 times, which is little annoying. Since Done Line 988: return self._irs.connectStoragePool( Line 989: self._UUID, hostID, masterSdUUID, masterVersion, domainsMap) Line 990: Line 991: def connectStorageServer(self, domainType, connectionParams): -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: tests: add missing 'display' parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: tests: add missing 'display' parameter .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9355/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10139/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5221/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3379/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d725de480036a0c8b88f03897fba8c16a692fb8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9349/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/889/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10290/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5216/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3374/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1310/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
Nir Soffer has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 2: Nice idea but I find it hard to understand how it works. I think we need more generic solution that can help to check all the api, not only the api you check. -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 51: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1313/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9351/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10135/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/890/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10291/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5217/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3375/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
oVirt Jenkins CI Server has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9358/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10142/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10298/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5224/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3382/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1312/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Introduce cancellation points
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28721/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 816: @functools.wraps(meth) Line 817: def wrapper(self, *a, **kw): Line 818: if self.__canceled__(): Line 819: raise Canceled() Line 820: return meth(self, *a, **kw) I got it that meth refers to method, just saying that i never saw meth in People should improve :-) . This decorator does *not* work with functions so using func is wrong. Waiting for other review for the location - This was in vdsm/storage/domainMonitor.py and was moved here on Federico request. Line 821: return wrapper Line 822: Line 823: Line 824: def tobool(s): -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: disable virtio-rng on rhel 7.1
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel 7.1 .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9359/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10143/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10299/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5225/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3383/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3493fec50d5d0e055a09f3393c86ff76f2a1ce5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Nir Soffer has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 4: Code-Review+1 Nicely done! -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9353/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10136/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/891/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10292/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5218/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3376/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Vered Volansky has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 4: Code-Review-1 Just fix the typo, after all, it is API doc... -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
Saggi Mizrahi has posted comments on this change. Change subject: profile: Test profile decorator format .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
Saggi Mizrahi has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
Nir Soffer has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28817/1//COMMIT_MSG Commit Message: Line 12: We can not modify API.py to provide this information in common place Line 13: because it is not needed by mom thread which is calling this verb as Line 14: well. Line 15: Line 16: The threading model of request processing has changed so we can not use When you do it in the acceptor you do it once for both protocols. As I unde Why do we need the last connected client? Maybe we can kill this instead of adding new code? Line 17: thread local. Instead we use dictionary which is updated in Line 18: MultiProtocolAcceptor and is read in Bridge.py and xml binding. Line 19: Line 20: -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Allow disabling threads when using the decorator
Saggi Mizrahi has posted comments on this change. Change subject: profile: Allow disabling threads when using the decorator .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6608a831e0ac2d347d9b2f00458e570da31fdafd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi clock types
Saggi Mizrahi has posted comments on this change. Change subject: profile: Support yappi clock types .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64069de315a0bad5cb19365b43edf79aceeedca1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clarify that scsiKey parameter is not passed on
Nir Soffer has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28560/4/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 4695: # @storagepoolID: The UUID of the Storage Pool Line 4696: # Line 4697: # @hostID: A host ID number unique across all hosts in the same cluster Line 4698: # Line 4699: # @scsiKey:Deprecated. Retaited here to support older versions Retaited -Retained? Line 4700: # Line 4701: # @masterSdUUID: The UUID of a Storage Domain to use as the master domain Line 4702: # Line 4703: # @masterVersion: The Storage Domain version of the master domain -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9352/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10137/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/892/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10293/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5219/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3377/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: move getBalloonInfo in the stats thread
Francesco Romani has posted comments on this change. Change subject: vm: move getBalloonInfo in the stats thread .. Patch Set 1: Verified+1 verification (against vdsm 4.14.9 (last ovirt-3.4)) verified on a VM with and without balloon enabled that the balloon_* fields are present in the getVmStats output; cursory look in the vdsm logs shown no errors/exceptions. -- To view, visit http://gerrit.ovirt.org/28686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: move getBalloonInfo in the stats thread
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: move getBalloonInfo in the stats thread .. vm: move getBalloonInfo in the stats thread To gather the ballon stats, we used to make a direct libvirt call in the getStats() body. This is dangerous, because getStats() should not contain costly calls, and should just gather data. This patch reimplements the balloon information getter as a sampling function, and moves it into the VmStatsThread to make things more robust. As remainder to avoid to sneak costly calls in getStats, this patch also adds a docstring in getStatsInternal. This is a backport of the patch from master/3.5.0, given the performance benefits also observed from this patch. Bug-Url: https://bugzilla.redhat.com/1102147 Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27696 Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28686 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/config.py.in M tests/vmTests.py M vdsm/vm.py 3 files changed, 51 insertions(+), 25 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
Darshan N has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 18: Verified+1 -- To view, visit http://gerrit.ovirt.org/17644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding updateVmPolicy api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 51: Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1315/ : The patch does not pass the storage functional tests -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9354/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10138/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/893/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5220/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3378/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: move getBalloonInfo in the stats thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move getBalloonInfo in the stats thread .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/231/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9361/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10145/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10301/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5227/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3385/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
Dan Kenigsberg has submitted this change and it was merged. Change subject: profile: Support yappi builtins option .. profile: Support yappi builtins option yappi support profiling also builtin python functions. This patch adds a new configuration value to enable profiling builtins in an application wide profile, and a new builtins kwarg to the profile decorator. This option can be handy when trying to understand why code is expensive. Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27787 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com --- M lib/vdsm/config.py.in M lib/vdsm/profile.py M tests/profileTests.py 3 files changed, 70 insertions(+), 9 deletions(-) Approvals: Nir Soffer: Verified Saggi Mizrahi: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi clock types
Dan Kenigsberg has submitted this change and it was merged. Change subject: profile: Support yappi clock types .. profile: Support yappi clock types yappi supports both cpu clock and wall clcok. The default cpu clock is handy when you want to see when time is spent running code. The wall clock is handy when you want to understand when time is spent running or sleeping. See test_cpu_clock and test_wall_clock if the difference between the clock is not clear. Change-Id: I64069de315a0bad5cb19365b43edf79aceeedca1 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27816 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com --- M lib/vdsm/config.py.in M lib/vdsm/profile.py M tests/profileTests.py 3 files changed, 77 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Verified Saggi Mizrahi: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64069de315a0bad5cb19365b43edf79aceeedca1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Allow disabling threads when using the decorator
Dan Kenigsberg has submitted this change and it was merged. Change subject: profile: Allow disabling threads when using the decorator .. profile: Allow disabling threads when using the decorator yappi supports profiling all threads (default) or only the thread where the profiler was started from. This patch add this option to the profile decorator. This is is probably not going to be used very much, but useful when you need it. New threading tests verify that yappi indeed work correctly with other threads, even those that started before yappi was started. Change-Id: I6608a831e0ac2d347d9b2f00458e570da31fdafd Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27894 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com --- M lib/vdsm/profile.py M tests/profileTests.py 2 files changed, 84 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Nir Soffer: Verified Saggi Mizrahi: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6608a831e0ac2d347d9b2f00458e570da31fdafd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
Dan Kenigsberg has submitted this change and it was merged. Change subject: profile: Test profile decorator format .. profile: Test profile decorator format The option to set profile format using a profile decorator was not tested. Lets test it before we add new options to this decorator. Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/27786 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com --- M tests/profileTests.py 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Saggi Mizrahi: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Test profile decorator format .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1464/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move Vm._reportError into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move Vm._reportError into utils .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9356/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10140/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/894/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10296/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5222/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3380/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1311/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01e822429b360bd0973d05b4831ba1b42b93a27f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Query interface for all VM fields
oVirt Jenkins CI Server has posted comments on this change. Change subject: Query interface for all VM fields .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9360/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10144/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/895/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10300/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3384/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1314/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1465/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 3: (1 comment) Douglas: Why rebase in reverse order than now? These are two separate issues. http://gerrit.ovirt.org/#/c/28782/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 322: try: Line 323: os.unlink(content['path']) Line 324: Line 325: if utils.isOvirtNode(): Line 326: NodeCfg().unpersist(content['path']) Does it raise OSError? Right, will do. thanks. Line 327: except OSError as e: Line 328: if e.errno != errno.ENOENT: Line 329: raise InvalidRun(Removing file: %s failed, content['path']) Line 330: -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi clock types
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi clock types .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1466/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64069de315a0bad5cb19365b43edf79aceeedca1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove last dependency on ifcfg persistence
Antoni Segura Puimedon has posted comments on this change.
Change subject: net: remove last dependency on ifcfg persistence
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28530/2/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 205: nic = network.get('nic')
Line 206: bond = network.get('bonding')
Line 207: vlan = network.get('vlan', '')
Line 208: if bond:
Line 209: return [bond + vlan]
make sure that vlan is not an int here.
Line 210: elif nic:
Line 211: return [nic + vlan]
Line 212: else: # isolated bridged network
http://gerrit.ovirt.org/#/c/28530/2/vdsm/network/api.py
File vdsm/network/api.py:
Line 380: if config.get('vars', 'net_persistence') == 'unified':
Line 381: return persistence.configuredPorts(
Line 382: configurator.runningConfig.networks[bridge])
Line 383: else:
Line 384: return persistence.configuredPorts(bridge)
unify this so that persistence modules have both the same interface. This way
this function won't be needed.
Line 385:
Line 386:
Line 387: def _delBrokenNetwork(network, netAttr, configurator):
Line 388: '''Adapts the network information of broken networks so that they
can be
--
To view, visit http://gerrit.ovirt.org/28530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5d682eaf93b488fac0391bf4b84394d73d7f485
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Allow disabling threads when using the decorator
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Allow disabling threads when using the decorator .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1467/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6608a831e0ac2d347d9b2f00458e570da31fdafd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 15: Code-Review-1
(5 comments)
Looking good, just a few final touches and it is OK for me. -1 only for
visibility.
http://gerrit.ovirt.org/#/c/22462/15/vdsm/caps.py
File vdsm/caps.py:
Line 478:
Line 479:
Line 480: def _getHostdev():
Line 481: devices = []
Line 482: supportedDevices = ('pci',)
this seems to be used only in the for loop at line 512; if that's the case,
please remove this variable
Line 483:
Line 484: for device in libvirtconnection.get().listAllDevices(0):
Line 485: devXML = minidom.parseString(device.XMLDesc(0))
Line 486: dev = {}
Line 505: # we can still report back the name
Line 506: pass
Line 507: except IndexError:
Line 508: # should device not have a name, there is nothing engine
could send
Line 509: # back that we could use to uniquely identify and
initiate a device
Then please consider to add a warning here.
Line 510: continue
Line 511:
Line 512: if capability in supportedDevices:
Line 513: devices.append(dev)
http://gerrit.ovirt.org/#/c/22462/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1486:
Line 1487: def __init__(self, *args, **kwargs):
Line 1488: super(HostDevice, self).__init__(*args, **kwargs)
Line 1489:
Line 1490: self._nodeptr =
self._connection.nodeDeviceLookupByName(self.name)
silly nit: why nodeptr? I'd just use self._node
Line 1491:
Line 1492: # the device needs to be detached from the host
Line 1493: self.log.debug('Detaching hostdev %s', self.name)
Line 1494: self._nodeptr.dettach()
Line 1488: super(HostDevice, self).__init__(*args, **kwargs)
Line 1489:
Line 1490: self._nodeptr =
self._connection.nodeDeviceLookupByName(self.name)
Line 1491:
Line 1492: # the device needs to be detached from the host
Please add another line in this comment explaining why the device needs to be
detached (just a link to e.g. libvirt docs is fine)
Line 1493: self.log.debug('Detaching hostdev %s', self.name)
Line 1494: self._nodeptr.dettach()
Line 1495:
Line 1496: def getPciAddr(self):
Line 4569:
Line 4570: # we have to manually reattach passthrough devices
Line 4571: for dev in self._devices[HOSTDEV_DEVICES]:
Line 4572: self.log.debug('Retaching device %s', dev.name)
Line 4573: dev._nodeptr.reAttach()
We have the same snippet twice, so we reached the threshold for moving this
code into an helper method, with possibly the comment converting in a docstring
and with and added explanation/link/remainder of why we need this
deattach/reattach dance.
Line 4574:
Line 4575: hooks.before_vm_destroy(self._lastXMLDesc, self.conf)
Line 4576: self.destroyed = True
Line 4577:
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 5: Douglas: I did the rebase you asked. Maybe it's better I'm not sure... -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: Node unpersist must be called before removi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: Node unpersist must be called before removing a file. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9363/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10147/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5229/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3387/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9364/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10148/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10304/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5230/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3388/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: unify validateCreateVolumeParams
Dan Kenigsberg has submitted this change and it was merged. Change subject: sd: unify validateCreateVolumeParams .. sd: unify validateCreateVolumeParams One validateCreateVolumeParams is enough, there's no real need to have it both in the domain and volume object. Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28128 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py M vdsm/storage/fileSD.py M vdsm/storage/sd.py M vdsm/storage/volume.py 5 files changed, 19 insertions(+), 55 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: unify validateCreateVolumeParams
Dan Kenigsberg has posted comments on this change. Change subject: sd: unify validateCreateVolumeParams .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: make preallocate optional in volume validation
Dan Kenigsberg has posted comments on this change. Change subject: sd: make preallocate optional in volume validation .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: make preallocate optional in volume validation
Dan Kenigsberg has submitted this change and it was merged. Change subject: sd: make preallocate optional in volume validation .. sd: make preallocate optional in volume validation In the current effort to move to the new storage API the preallocate option may be omitted and therefore should not be validated. Relates-To: http://bugzilla.redhat.com/show_bug.cgi?id=1097843 Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28129 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/blockSD.py M vdsm/storage/hsm.py M vdsm/storage/sd.py M vdsm/storage/volume.py 4 files changed, 13 insertions(+), 9 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: unify validateCreateVolumeParams
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: unify validateCreateVolumeParams .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1468/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: jsonrpc reboot issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: jsonrpc reboot issue .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9365/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10149/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5231/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3389/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1316/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7be1c00c35f4c2b4c99ed01081020198c7a566d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: IncorrectFormat cannot be decoded
Dan Kenigsberg has posted comments on this change. Change subject: sd: IncorrectFormat cannot be decoded .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic03271be3f58b8a68421b4736c9fe403b2448265 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: make preallocate optional in volume validation
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: make preallocate optional in volume validation .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1469/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9362/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10146/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10302/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5228/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3386/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: jsonrpc reboot issue
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: jsonrpc reboot issue .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7be1c00c35f4c2b4c99ed01081020198c7a566d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix FakeGuestAgent field
Vinzenz Feenstra has posted comments on this change. Change subject: tests: fix FakeGuestAgent field .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
Vinzenz Feenstra has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
Vinzenz Feenstra has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28802/2/tests/vmApiTests.py File tests/vmApiTests.py: Line 63: isinstance I think that rather should check for basestring, some values can be unicode. -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Query interface for all VM fields
oVirt Jenkins CI Server has posted comments on this change. Change subject: Query interface for all VM fields .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9366/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10150/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/896/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10306/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5232/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3390/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1317/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: type checking for primitive types
Vinzenz Feenstra has posted comments on this change. Change subject: tests: type checking for primitive types .. Patch Set 2: @Nir: This is just a beginning. You need to setup a fake environment to make this work. In the unittests there's no real good way to do so at the moment. And I think it's good as a start and we can build on top of it. -- To view, visit http://gerrit.ovirt.org/28802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Report bonding options as a dictionary of strings
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Report bonding options as a dictionary of strings
..
netinfo: Report bonding options as a dictionary of strings
The values of bonding options are read from the kernel
as one or two strings. If there is only one string,
the value is actually numeric. If there are two,
the value is an enumeration, with a symbolic name in
the first string, a numeric code in the second string.
To simplify the API from the current state (reporting
the options as raw arrays of one or two strings),
the only value reported now is the number in both cases,
left in its textual representation.
A bond info dictionary is thus changed to (abriged):
'bond4': {
'cfg': {'BONDING_OPTS': 'miimon=150 mode=3'},
'options': {'miimon': '150', 'mode': '3'}
}
Change-Id: I1d29618c6d19d8c7f36fa674043488480dc346fb
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M lib/vdsm/netinfo.py
M tests/netinfoTests.py
M vdsm/rpc/vdsmapi-schema.json
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/28845/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 812771a..9cf985a 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -589,7 +589,7 @@
mode = opts['mode'][-1] if 'mode' in opts else None
defaults = _getDefaultBondingOptions(mode)
-return dict(((opt, val) for (opt, val) in opts.iteritems()
+return dict(((opt, val[-1]) for (opt, val) in opts.iteritems()
if val and val != defaults.get(opt)))
@@ -599,7 +599,7 @@
the order symbolic name, numeric value, e.g. 'balance-rr 0'.
Choose the numeric value from a list given by bondOpts().
-return ' '.join((opt + '=' + val[-1] for (opt, val)
+return ' '.join((opt + '=' + val for (opt, val)
in sorted(opts.iteritems(
diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index ff6e90e..dd90613 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -343,7 +343,7 @@
opt.write(INTERVAL)
self.assertEqual(_getBondingOptions(bondName),
- {'miimon': [INTERVAL]})
+ {'miimon': INTERVAL})
finally:
bonds.write('-' + bondName)
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index dd97594..2ccf963 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -600,7 +600,7 @@
#
# @qosOutbound: #optional BandwidthParams for outgoing traffic.
#
-# @opts: A map containing information about the bridge specific options.
+# @opts:A map containing information about the bridge specific options.
# (new in version 4.15.0)
#
# Since: 4.10.0
@@ -696,12 +696,15 @@
#
# @mtu: The Maximum Transmission Unit size for the nic
#
+# @opts:A map of options; the values are numeric, but reported as
+# strings (new in version 4.16.0)
+#
# Since: 4.10.0
##
{'type': 'NetInfoBond',
'data': {'slaves': ['str'], 'addr': 'str', 'netmask': 'str',
'ipv4addrs': ['str'], 'ipv6addrs': ['str'], 'hwaddr': 'str',
- 'cfg': 'StringMap', 'mtu': 'uint'}}
+ 'cfg': 'StringMap', 'mtu': 'uint', 'opts': 'StringMap'}}
##
# @NetInfoVlan:
--
To view, visit http://gerrit.ovirt.org/28845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d29618c6d19d8c7f36fa674043488480dc346fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for hostdev passthrough
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/15/vdsm/caps.py
File vdsm/caps.py:
Line 505: # we can still report back the name
Line 506: pass
Line 507: except IndexError:
Line 508: # should device not have a name, there is nothing engine
could send
Line 509: # back that we could use to uniquely identify and
initiate a device
Then please consider to add a warning here.
This is in the should not ever happen class, and it's occurrence would
probably be spotted way sooner - in this case the warning would be irrelevant
Line 510: continue
Line 511:
Line 512: if capability in supportedDevices:
Line 513: devices.append(dev)
http://gerrit.ovirt.org/#/c/22462/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4569:
Line 4570: # we have to manually reattach passthrough devices
Line 4571: for dev in self._devices[HOSTDEV_DEVICES]:
Line 4572: self.log.debug('Retaching device %s', dev.name)
Line 4573: dev._nodeptr.reAttach()
We have the same snippet twice, so we reached the threshold for moving this
You have actually spotted a code that happened by mistake, it only belongs here.
Line 4574:
Line 4575: hooks.before_vm_destroy(self._lastXMLDesc, self.conf)
Line 4576: self.destroyed = True
Line 4577:
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
