Change in vdsm[master]: Configure iSCSI iface.net_ifacename
oVirt Jenkins CI Server has posted comments on this change. Change subject: Configure iSCSI iface.net_ifacename .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11584/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12528/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12373/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure iSCSI iface.net_ifacename
Amador Pahim has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 149:
Line 150: def _resolveIscsiIface(ifaceName, initiatorName, netIfacename):
Line 151: if not ifaceName:
Line 152: iface = iscsi.IscsiInterface('default')
Line 153: iface.netIfacename = netIfacename
> Sorry, I do not understand your answer; nor why you set the iface.netIfacen
Set iface.netIfacename is not needed in fact. Removing.
Line 154: return iface
Line 155:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
Line 158: iface.netIfacename = netIfacename
Line 159: if netIfacename:
Line 160: iface.update()
> But why change and existing interface? Isn't it dangerous, in case it is al
I was wondering in solve a case where user could change a non-bridged network
to a bridged, or the opposite. Currently, once created, iface will never be
removed, recreated or updated, even if the net_ifacename changes. But seems
like this is subject for another bz/discussion. Implementing this here may be
dangerous indeed.
Line 161: return iface
Line 162:
Line 163: iface = iscsi.IscsiInterface(ifaceName,
initiatorName=initiatorName,
Line 164: netIfacename=netIfacename)
--
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Dan Kenigsberg has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33045/1//COMMIT_MSG Commit Message: Line 6: Line 7: utils: Add changehash function for change detection Line 8: Line 9: We use Python built-in hash to detect changes in vm state without sending Line 10: the state in each response. This function is not suitable for this Could you explain why the lightweight hash() is not good enough for our use case, and why an expensive crypto hash is favorable? Line 11: usage. Now we use generic utils.changehash(), implemented using md5 Line 12: hexdigest. Line 13: Line 14: Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Dan Kenigsberg has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Dan Kenigsberg has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not reference qemu hook on RHEL 6 in spec file
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not reference qemu hook on RHEL 6 in spec file .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1873/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5847/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4006/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/11/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/11/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/6/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure iSCSI iface.net_ifacename
Dan Kenigsberg has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 13:
(3 comments)
http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 149:
Line 150: def _resolveIscsiIface(ifaceName, initiatorName, netIfacename):
Line 151: if not ifaceName:
Line 152: iface = iscsi.IscsiInterface('default')
Line 153: iface.netIfacename = netIfacename
> "default" means not using iscsi bond feature. So, no netIfacename will arri
Sorry, I do not understand your answer; nor why you set the iface.netIfacename
here.
Line 154: return iface
Line 155:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
Line 158: iface.netIfacename = netIfacename
Line 159: if netIfacename:
Line 160: iface.update()
> I'm trying here to existing iface with modified netIfacename will be update
But why change and existing interface? Isn't it dangerous, in case it is
already used?
Line 161: return iface
Line 162:
Line 163: iface = iscsi.IscsiInterface(ifaceName,
initiatorName=initiatorName,
Line 164: netIfacename=netIfacename)
http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line 152: username = None
Line 153: if password in ["", "(null)"]:
Line 154: password = None
Line 155:
Line 156: if netdev in ["", "(null)"]:
> Ok, keeping for now.
Fine. But the general rule should be - if and object does not need to change,
it should be immutable.
Since we no longer support el5, this code can be simplified; in any case, its
repetitiveness and need of a comment suggest that a helper function is in place.
Line 157: netdev = None
Line 158:
Line 159: iface = IscsiInterface(iface, netIfacename=netdev)
Line 160: portal = IscsiPortal(ip, port)
--
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not reference qemu hook on RHEL 6 in spec file
Dan Kenigsberg has submitted this change and it was merged. Change subject: Do not reference qemu hook on RHEL 6 in spec file .. Do not reference qemu hook on RHEL 6 in spec file The previous patch skips the qemu hook installation on RHEL 6, but still references it in the %files section. This fixes that. Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/33061 Tested-by: Martin Sivák Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not reference qemu hook on RHEL 6 in spec file
Dan Kenigsberg has posted comments on this change. Change subject: Do not reference qemu hook on RHEL 6 in spec file .. Patch Set 1: Code-Review+2 thanks for unbreaking el6. -- To view, visit http://gerrit.ovirt.org/33061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
Nir Soffer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32713/1/tests/toolTests.py File tests/toolTests.py: Line 313: "rt") as fin: Line 314: for line in fin: Line 315: fout.write(line.replace( Line 316: 'CONF_VERSION', Line 317: Libvirt.CONF_VERSION)) > OK, will change. This is the syntax of python standard templating - see the example in multipath.py Line 318: Line 319: def testValidatePositive(self): Line 320: libvirtConfigure = Libvirt() Line 321: -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: RHEL7 works with systemd and requires systemd macros and tmp...
oVirt Jenkins CI Server has posted comments on this change. Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/72/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el6-x86_64_merged/2/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el7-x86_64_merged/3/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc19-x86_64_merged/2/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc20-x86_64_merged/2/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: RHEL7 works with systemd and requires systemd macros and tmp...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf .. RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122198 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/30820 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/33021 Reviewed-by: Douglas Schilling Landgraf Tested-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit http://gerrit.ovirt.org/33021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: RHEL7 works with systemd and requires systemd macros and tmp...
Yaniv Bronhaim has posted comments on this change. Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure iSCSI iface.net_ifacename
Amador Pahim has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 13:
(6 comments)
http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 149:
Line 150: def _resolveIscsiIface(ifaceName, initiatorName, netIfacename):
Line 151: if not ifaceName:
Line 152: iface = iscsi.IscsiInterface('default')
Line 153: iface.netIfacename = netIfacename
> in iscsi.py you modified the initiator to accept netIfacename. so why don'
"default" means not using iscsi bond feature. So, no netIfacename will arrive
from engine in this case.
Line 154: return iface
Line 155:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
Line 156: for iface in iscsi.iterateIscsiInterfaces():
Line 157: if iface.name == ifaceName:
Line 158: iface.netIfacename = netIfacename
Line 159: if netIfacename:
Line 160: iface.update()
> this is a no-op, since nothing has change iface._conf.
I'm trying here to existing iface with modified netIfacename will be updated.
But, yes, you're right. I will use a better approach.
Line 161: return iface
Line 162:
Line 163: iface = iscsi.IscsiInterface(ifaceName,
initiatorName=initiatorName,
Line 164: netIfacename=netIfacename)
http://gerrit.ovirt.org/#/c/31534/13/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line 106: - iSCSI host path - e.g. '/sys/class/iscsi_host/host17/'
Line 107: """
Line 108:
Line 109: pattern = '/sys/devices/platform/host*/session%s' % sessionID
Line 110: for path in glob.glob(pattern):
> It does not matter in this case, there will be only one value - otherwise t
I will use iglob anyway. I've got 2 requests for it and I do like to make the
reviewers happy.
Line 111: host = os.path.basename(os.path.dirname(path))
Line 112: return '/sys/class/iscsi_host/' + host
Line 113:
Line 114: raise OSError(errno.ENOENT, "No iscsi_host for session [%s]" %
sessionID)
Line 152: username = None
Line 153: if password in ["", "(null)"]:
Line 154: password = None
Line 155:
Line 156: if netdev in ["", "(null)"]:
> Better to keep this code as is in this patch, in another patch we can conve
Ok, keeping for now.
Line 157: netdev = None
Line 158:
Line 159: iface = IscsiInterface(iface, netIfacename=netdev)
Line 160: portal = IscsiPortal(ip, port)
Line 345: def __init__(self, name, hardwareAddress=None, ipAddress=None,
Line 346: initiatorName=None, netIfacename=None):
Line 347: self._conf = {}
Line 348: # Only new tcp interfaces are supported for now
Line 349: self._conf['iface.transport_name'] = 'tcp'
> there is no functional change in these 3 lines - no need to touch them in t
Done
Line 350:
Line 351: self._loaded = False
Line 352:
Line 353: self.name = name
Line 401: self._conf = conf
Line 402:
Line 403: def __repr__(self):
Line 404: return "" \
Line 405: % (self.name, self.transport, self.netIfacename)
> Considering the other names in the class and the names of the configuration
Done
Line 406:
Line 407:
Line 408: def iterateIscsiInterfaces():
Line 409: names = iscsiadm.iface_list()
--
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not reference qemu hook on RHEL 6 in spec file
oVirt Jenkins CI Server has posted comments on this change. Change subject: Do not reference qemu hook on RHEL 6 in spec file .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/363/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/380/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11583/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12527/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12372/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 2: Verified+1 The logic is still the same, this revision only fixed the packaging. The files are still at proper places and CentOS 6 package build was fixed. -- To view, visit http://gerrit.ovirt.org/33050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 2: Verified+1 The logic did not change since the last version. Just the packaging and it builds and installs properly. -- To view, visit http://gerrit.ovirt.org/33051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not reference qemu hook on RHEL 6 in spec file
Martin Sivák has posted comments on this change. Change subject: Do not reference qemu hook on RHEL 6 in spec file .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Do not reference qemu hook on RHEL 6 in spec file
Martin Sivák has uploaded a new change for review.
Change subject: Do not reference qemu hook on RHEL 6 in spec file
..
Do not reference qemu hook on RHEL 6 in spec file
The previous patch skips the qemu hook installation on RHEL 6,
but still references it in the %files section.
This fixes that.
Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Signed-off-by: Martin Sivak
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/33061/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index a0b7ebc..8438df7 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -992,7 +992,9 @@
%{_sysconfdir}/sudoers.d/50_vdsm
%{_sysconfdir}/cron.hourly/vdsm-logrotate
%{_sysconfdir}/cron.d/vdsm-libvirt-logrotate
+%if 0%{?fedora} || 0%{?rhel} >= 7
%{_sysconfdir}/libvirt/hooks/qemu
+%endif
%{_datadir}/%{vdsm_name}/logUtils.py*
%{_datadir}/%{vdsm_name}/dsaversion.py*
%{_libexecdir}/%{vdsm_name}/curl-img-wrap
--
To view, visit http://gerrit.ovirt.org/33061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic167e5651960519206d9b8cb3a933a2e238d4321
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 2: Should be resolved now. I totally missed it in the first patch. -- To view, visit http://gerrit.ovirt.org/33050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/71/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33051/1/vdsm.spec.in
File vdsm.spec.in:
Line 955: %{_sysconfdir}/dhcp/dhclient.d/sourceRoute.sh
Line 956: %{_sysconfdir}/sudoers.d/50_vdsm
Line 957: %{_sysconfdir}/cron.hourly/vdsm-logrotate
Line 958: %{_sysconfdir}/cron.d/vdsm-libvirt-logrotate
Line 959: %{_sysconfdir}/libvirt/hooks/qemu
> ...also here.
Uh you are right.. let me fix that really quick
Line 960: %{_datadir}/%{vdsm_name}/guestIF.py*
Line 961: %{_datadir}/%{vdsm_name}/logUtils.py*
Line 962: %{_datadir}/%{vdsm_name}/dsaversion.py*
Line 963: %{_libexecdir}/%{vdsm_name}/curl-img-wrap
--
To view, visit http://gerrit.ovirt.org/33051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Francesco Romani has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/33051/1/vdsm.spec.in
File vdsm.spec.in:
Line 663: %{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.pkla
Line 664: %endif
Line 665:
Line 666: # Install the libvirt hook for cleaning up the XML
Line 667: %if 0%{?fedora} || 0%{?rhel} >= 7
shoul be enough to add this if block...
Line 668: install -Dm 0755 vdsm/libvirt-hook.sh \
Line 669: %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
Line 670: %endif
Line 671:
Line 955: %{_sysconfdir}/dhcp/dhclient.d/sourceRoute.sh
Line 956: %{_sysconfdir}/sudoers.d/50_vdsm
Line 957: %{_sysconfdir}/cron.hourly/vdsm-logrotate
Line 958: %{_sysconfdir}/cron.d/vdsm-libvirt-logrotate
Line 959: %{_sysconfdir}/libvirt/hooks/qemu
...also here.
Sorry for not noticing before :(
Line 960: %{_datadir}/%{vdsm_name}/guestIF.py*
Line 961: %{_datadir}/%{vdsm_name}/logUtils.py*
Line 962: %{_datadir}/%{vdsm_name}/dsaversion.py*
Line 963: %{_libexecdir}/%{vdsm_name}/curl-img-wrap
--
To view, visit http://gerrit.ovirt.org/33051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Francesco Romani has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 1: Code-Review-1 please check http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/70/label=centos6/console -1 for visibility only -- To view, visit http://gerrit.ovirt.org/33051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Francesco Romani has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 1: Code-Review-1 please take a look at this: http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos6/1872/console 15:31:06 RPM build errors: 15:31:06 File not found: /home/jenkins/workspace/vdsm_master_create-rpms_merged/label/centos6/rpmbuild/BUILDROOT/vdsm-4.16.0-341.gitaab9f1f.el6.x86_64/etc/libvirt/hooks/qemu if relevant -1 for visibility only -- To view, visit http://gerrit.ovirt.org/33050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Dan Kenigsberg has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/70/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: event monitor
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 13: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32626/13/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 21: import threading
Line 22: import time
Line 23:
Line 24: from . import (
Line 25:_KNOWN_GROUPS,
Please silence the silly pep8 errors:
/usr/bin/pep8 --version
1.5.6
for x in config.py constants.py crossImportsTests.py vdsm.py ; do \
exclude="${exclude},${x}" ; \
done ; \
/usr/bin/pep8 --exclude="${exclude}" --filename '*.py,*.py.in' .
./lib/vdsm/netlink/monitor.py:25:16: E126 continuation line over-indented for
hanging indent
./lib/vdsm/netlink/monitor.py:38:15: E126 continuation line over-indented for
hanging indent
Line 26:_NL_ROUTE_ADDR_NAME,
Line 27:_NL_ROUTE_LINK_NAME,
Line 28:_NL_ROUTE_NAME,
Line 29:_NL_STOP,
--
To view, visit http://gerrit.ovirt.org/32626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Add a libvirt migration hook to filter out min_guarantee ele...
Hello Nir Soffer, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33051
to review the following change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Add a libvirt migration hook to filter out min_guarantee element
libvirt removed the silent support for min_guarantee element.
That will break migrations of long running machines and
resume of machines that were paused with the element still
in their XML.
VDSM was updated and new machines won't contain the offending
element. This fix will remove it when a running machine is migrated
or resumed.
Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Signed-off-by: Martin Sivak
Reviewed-on: http://gerrit.ovirt.org/32928
Reviewed-by: Nir Soffer
Reviewed-by: Francesco Romani
Reviewed-by: Dan Kenigsberg
Tested-by: Francesco Romani
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/libvirt-hook.sh
3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/33051/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7af6d59..c126148 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -663,6 +663,12 @@
%{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.pkla
%endif
+# Install the libvirt hook for cleaning up the XML
+%if 0%{?fedora} || 0%{?rhel} >= 7
+install -Dm 0755 vdsm/libvirt-hook.sh \
+ %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
+%endif
+
%check
make check PEP8=true PYFLAKES=true
@@ -950,6 +956,7 @@
%{_sysconfdir}/sudoers.d/50_vdsm
%{_sysconfdir}/cron.hourly/vdsm-logrotate
%{_sysconfdir}/cron.d/vdsm-libvirt-logrotate
+%{_sysconfdir}/libvirt/hooks/qemu
%{_datadir}/%{vdsm_name}/guestIF.py*
%{_datadir}/%{vdsm_name}/logUtils.py*
%{_datadir}/%{vdsm_name}/dsaversion.py*
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index c052a74..2966992 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -106,6 +106,7 @@
EXTRA_DIST = \
dsaversion.py.in \
dumpStorageTable.py.in \
+ libvirt-hook.sh \
libvirt_password \
limits.conf \
logger.conf.in \
diff --git a/vdsm/libvirt-hook.sh b/vdsm/libvirt-hook.sh
new file mode 100644
index 000..963ba02
--- /dev/null
+++ b/vdsm/libvirt-hook.sh
@@ -0,0 +1,21 @@
+#!/bin/sh
+DOMAIN=$1
+EVENT=$2
+PHASE=$3
+
+# This condition depends on a feature that will be included in
+# libvirt once https://bugzilla.redhat.com/show_bug.cgi?id=1142684
+# is resolved. It will work only for migrations before that.
+if [ "x$EVENT" != "xmigrate" -a "x$EVENT" != "xrestore" ]; then
+ # Return 0 and empty output for events that are not handled
+ # by this hook.
+ #
+ # libvirt will use input XML without change and consider
+ # it a success run according to the documentation.
+ exit 0
+fi
+
+# Fix VMs migrating to host with libvirt >= 1.2.8
+# See https://bugzilla.redhat.com/show_bug.cgi?id=1138340
+exec sed -e 's|]*>[0-9 ]*||g'
+
--
To view, visit http://gerrit.ovirt.org/33051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Martin Sivák
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: ppc: fully fake arch for recovery tests
Dan Kenigsberg has posted comments on this change. Change subject: tests: ppc: fully fake arch for recovery tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d6e8ccd9a6fb4dec16c547ab2eaa7d33287ba0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Dan Kenigsberg has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 1: Verified+1 Verified by Francesco on master. -- To view, visit http://gerrit.ovirt.org/33050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has uploaded a new change for review.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Add a libvirt migration hook to filter out min_guarantee element
libvirt removed the silent support for min_guarantee element.
That will break migrations of long running machines and
resume of machines that were paused with the element still
in their XML.
VDSM was updated and new machines won't contain the offending
element. This fix will remove it when a running machine is migrated
or resumed.
Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340
Signed-off-by: Martin Sivak
Reviewed-on: http://gerrit.ovirt.org/32928
Reviewed-by: Nir Soffer
Reviewed-by: Francesco Romani
Reviewed-by: Dan Kenigsberg
Tested-by: Francesco Romani
(cherry picked from commit ef7b9647cb6b9c3f46ba81f8238dd5ce0ffa5b87)
---
M vdsm.spec.in
M vdsm/virt/Makefile.am
A vdsm/virt/libvirt-hook.sh
3 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/33050/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 350811e..3809099 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -690,6 +690,12 @@
%{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.pkla
%endif
+# Install the libvirt hook for cleaning up the XML
+%if 0%{?fedora} || 0%{?rhel} >= 7
+install -Dm 0755 vdsm/virt/libvirt-hook.sh \
+ %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
+%endif
+
%check
make check
@@ -970,6 +976,7 @@
%{_sysconfdir}/sudoers.d/50_vdsm
%{_sysconfdir}/cron.hourly/vdsm-logrotate
%{_sysconfdir}/cron.d/vdsm-libvirt-logrotate
+%{_sysconfdir}/libvirt/hooks/qemu
%{_datadir}/%{vdsm_name}/logUtils.py*
%{_datadir}/%{vdsm_name}/dsaversion.py*
%{_libexecdir}/%{vdsm_name}/curl-img-wrap
diff --git a/vdsm/virt/Makefile.am b/vdsm/virt/Makefile.am
index c3262a1..8965c77 100644
--- a/vdsm/virt/Makefile.am
+++ b/vdsm/virt/Makefile.am
@@ -32,3 +32,7 @@
vmpowerdown.py \
vmstatus.py \
$(NULL)
+
+EXTRA_DIST = \
+ libvirt-hook.sh \
+ $(NULL)
diff --git a/vdsm/virt/libvirt-hook.sh b/vdsm/virt/libvirt-hook.sh
new file mode 100644
index 000..963ba02
--- /dev/null
+++ b/vdsm/virt/libvirt-hook.sh
@@ -0,0 +1,21 @@
+#!/bin/sh
+DOMAIN=$1
+EVENT=$2
+PHASE=$3
+
+# This condition depends on a feature that will be included in
+# libvirt once https://bugzilla.redhat.com/show_bug.cgi?id=1142684
+# is resolved. It will work only for migrations before that.
+if [ "x$EVENT" != "xmigrate" -a "x$EVENT" != "xrestore" ]; then
+ # Return 0 and empty output for events that are not handled
+ # by this hook.
+ #
+ # libvirt will use input XML without change and consider
+ # it a success run according to the documentation.
+ exit 0
+fi
+
+# Fix VMs migrating to host with libvirt >= 1.2.8
+# See https://bugzilla.redhat.com/show_bug.cgi?id=1138340
+exec sed -e 's|]*>[0-9 ]*||g'
+
--
To view, visit http://gerrit.ovirt.org/33050
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop dead ksmtuned-related code
oVirt Jenkins CI Server has posted comments on this change. Change subject: drop dead ksmtuned-related code .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1872/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4005/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/7/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/3/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/2/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I511fa1754e55076084529834fa9758c2fd139761 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32713/1/tests/toolTests.py File tests/toolTests.py: Line 313: "rt") as fin: Line 314: for line in fin: Line 315: fout.write(line.replace( Line 316: 'CONF_VERSION', Line 317: Libvirt.CONF_VERSION)) > Use Python standard templating: OK, will change. I also think CONF_VERSION better be LATEST_CONF_VERSION (Since that's what the tests mean) Can you please explain what you meant by: "vdsm-%(CONF_VERSION)s" Thanks Line 318: Line 319: def testValidatePositive(self): Line 320: libvirtConfigure = Libvirt() Line 321: -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm, guestagent: return hash should include also the disk map...
Dan Kenigsberg has posted comments on this change. Change subject: vm, guestagent: return hash should include also the disk mapping .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: return diskMapping on status()
Dan Kenigsberg has posted comments on this change. Change subject: vm: return diskMapping on status() .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop dead ksmtuned-related code
Dan Kenigsberg has posted comments on this change. Change subject: drop dead ksmtuned-related code .. Patch Set 4: Code-Review+2 Thank you very much for dropping this dead code! -- To view, visit http://gerrit.ovirt.org/27026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I511fa1754e55076084529834fa9758c2fd139761 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop dead ksmtuned-related code
Dan Kenigsberg has submitted this change and it was merged. Change subject: drop dead ksmtuned-related code .. drop dead ksmtuned-related code mom has replaced ksmtuned completely, and is expected to be running whenever Vdsm is. We can safely remove the unused ksm module. Change-Id: I511fa1754e55076084529834fa9758c2fd139761 Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/27026 Tested-by: Francesco Romani --- M debian/vdsm.install M lib/vdsm/config.py.in M tests/Makefile.am D tests/ksmTests.py M vdsm.spec.in M vdsm/API.py M vdsm/Makefile.am M vdsm/clientIF.py D vdsm/ksm.py M vdsm/momIF.py M vdsm/sudoers.vdsm.in M vdsm/supervdsmServer M vdsm/virt/vm.py 13 files changed, 15 insertions(+), 218 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/27026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511fa1754e55076084529834fa9758c2fd139761 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: drop dead ksmtuned-related code
Francesco Romani has posted comments on this change. Change subject: drop dead ksmtuned-related code .. Patch Set 4: Verified+1 Verified using a patched VDSM against master. Cluster was configured to * enable KSM * desktop optimization (share 200%) Run 64 empty tiny (16 MB ram each) VM on the host, verified that relevant fields are present in the vdsClient output, that they are meaningful (e.g. ksmState = True) and that they change over time. Also verified that the tunables under /sys change over time - when meaningful of course. From all the above I think is safe to infer that KSM is working through MOM as expected. Some sample output: [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 0 ksmPages = 100 ksmState = False [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 0 ksmPages = 100 ksmState = False [root@kenji ~]# systemctl restart vdsmd [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 0 ksmPages = 100 ksmState = False [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 0 ksmPages = 100 ksmState = False [root@kenji ~]# vdsClient 0 getVdsCaps | less [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 7 ksmPages = 64 ksmState = True [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 2 ksmPages = 64 ksmState = True [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 2 ksmPages = 64 ksmState = True [root@kenji ~]# cat /sys/kernel/ config/ fscache/iommu_groups/ kexec_crash_size mm/ profiling security/ uevent_helper vmcoreinfo debug/ fscaps kexec_crash_loaded kexec_loaded notes rcu_expedited slab/ uevent_seqnum [root@kenji ~]# cat /sys/kernel/ config/ fscache/iommu_groups/ kexec_crash_size mm/ profiling security/ uevent_helper vmcoreinfo debug/ fscaps kexec_crash_loaded kexec_loaded notes rcu_expedited slab/ uevent_seqnum [root@kenji ~]# cat /sys/kernel/mm/ hugepages/ksm/ transparent_hugepage/ [root@kenji ~]# cat /sys/kernel/mm/ksm/ full_scans merge_across_nodes pages_sharedpages_sharing pages_to_scan pages_unshared pages_volatile run sleep_millisecs [root@kenji ~]# cat /sys/kernel/mm/ksm/ full_scans merge_across_nodes pages_sharedpages_sharing pages_to_scan pages_unshared pages_volatile run sleep_millisecs [root@kenji ~]# cat /sys/kernel/mm/ksm/run 1 [root@kenji ~]# cat /sys/kernel/mm/ksm/pages_shar cat: /sys/kernel/mm/ksm/pages_shar: No such file or directory [root@kenji ~]# cat /sys/kernel/mm/ksm/pages_sharing 133031 [root@kenji ~]# cat /sys/kernel/mm/ksm/pages_to_scan 64 [root@kenji ~]# cat /sys/kernel/mm/ksm/pages_shared 91 [root@kenji ~]# cat /sys/kernel/mm/ksm/pages_shared 90 [root@kenji ~]# cat /sys/kernel/mm/ksm/pages_shared 90 [root@kenji ~]# vdsClient 0 getVdsStats | grep ksm ksmCpu = 0 ksmPages = 64 ksmState = True [root@kenji ~]# -- To view, visit http://gerrit.ovirt.org/27026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I511fa1754e55076084529834fa9758c2fd139761 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Fix for json-rpc issue wrt gluster commands.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/166/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/165/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: when None is set as default value Bridge.py fails
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: when None is set as default value Bridge.py fails .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/164/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a1cea87e62952f9675cba3b9d8e891985c8333 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/163/ : ABORTED -- To view, visit http://gerrit.ovirt.org/32980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1871/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5845/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4004/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/5/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Add a libvirt migration hook to filter out min_guarantee element libvirt removed the silent support for min_guarantee element. That will break migrations of long running machines and resume of machines that were paused with the element still in their XML. VDSM was updated and new machines won't contain the offending element. This fix will remove it when a running machine is migrated or resumed. Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Signed-off-by: Martin Sivak Reviewed-on: http://gerrit.ovirt.org/32928 Reviewed-by: Nir Soffer Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Tested-by: Francesco Romani --- M vdsm.spec.in M vdsm/virt/Makefile.am A vdsm/virt/libvirt-hook.sh 3 files changed, 32 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Francesco Romani has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: Verified+1 Worked on my testcase, the VM migrated succesfully on a destination VM with libvirt 1.2.9-git and the hook installed: 2014-09-18 12:54:11.965+: 1288: debug : virDomainMigratePrepare3Params:6925 : params["destination_xml"]=(string) KXS_C0 50af01bb-29bd-4263-82af-4d49d53260ba 16384 16384 16384 160 1020 /machine oVirt oVirt Node 7-0.1406.el7.centos.2.5 46E8615B-820D-4F59-A5EC-40167EB0817D_40:16:7e:b0:81:7d 50af01bb-29bd-4263-82af-4d49d53260ba hvm Opteron_G3 destroy restart destroy /usr/libexec/qemu-kvm 0780c420-558a-4ac6-9d45-262597906528 system_u:system_r:svirt_t:s0:c134,c269 system_u:object_r:svirt_image_t:s0:c134,c269 2014-09-18 12:54:11.965+: 1288: debug : virDomainMigratePrepare3Params:6925 : params["migrate_uri"]=(string)tcp://192.168.1.51 2014-09-18 12:54:11.965+: 1288: debug : virDomainMigratePrepare3Params:6925 : params["bandwidth"]=(ullong)32 2014-09-18 12:54:11.965+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd72014d5c0 2014-09-18 12:54:11.965+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd71c001280 2014-09-18 12:54:11.980+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd72014d5c0 2014-09-18 12:54:11.981+: 1288: debug : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fd72014d5c0 2014-09-18 12:54:11.981+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd72014d5c0 2014-09-18 12:54:11.981+: 1288: debug : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fd72014d5c0 2014-09-18 12:54:11.981+: 1288: debug : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fd71c001280 2014-09-18 12:54:11.981+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd73fb26eb0 2014-09-18 12:54:11.981+: 1288: debug : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fd73fb26eb0 2014-09-18 12:54:11.981+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd72014d5c0 2014-09-18 12:54:11.981+: 1288: debug : qemuMigrationPrepareDirect:2833 : driver=0x7fd7200df220, dconn=0x7fd70c0036e0, cookiein= KXS_C0 50af01bb-29bd-4263-82af-4d49d53260ba goji.rokugan.lan 2cb1c505-60d3-4b5c-84b5-6c0783689424 , cookieinlen=240, cookieout=0x7fd72e99eb68, cookieoutlen=0x7fd72e99eb64, uri_in=tcp://192.168.1.51, uri_out=0x7fd71c004040, def=0x7fd71c01e4e0, origname=(null), listenAddress=, flags=3 2014-09-18 12:54:11.982+: 1288: debug : virFileClose:99 : Closed fd 25 2014-09-18 12:54:11.982+: 1288: debug : virFileClose:99 : Closed fd 25 2014-09-18 12:54:11.982+: 1288: debug : qemuMigrationPrepareDirect:2936 : Generated uri_out=tcp://192.168.1.51:49152 2014-09-18 12:54:11.982+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd71c001280 2014-09-18 12:54:11.982+: 1288: debug : virObjectRef:296 : OBJECT_REF: obj=0x7fd71c001280 2014-09-18 12:54:11.982+: 1288: debug : qemuDomainDefFormatBuf:1720 : Removing default USB controller from domain 'KXS_C0' for migration compatibility 2014-09-18 12:54:11.982+: 1288: debug : qemuDomainDefFormatBuf:1741 : Removing default pci-root from domain 'KXS_C0' for migration compatibility 2014-09-18 12:54:11.983+: 1288: debug : virObjectUnref:259 : OBJECT_UNREF: obj=0x7fd71c001280 2014-09-18 12:54:11.983+: 1288: debug : virHookCall:287 : Calling hook opstr=migrate subopstr=begin extra=- 2014-09-18 12:54:11.983+: 1288: debug : virCommandRunAsync:2409 : About to run LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin /etc/libvirt/hooks/qemu KXS_C0 migrate begin - 2014-09-18 12:54:11.987+: 1288: debug : virFileClose:99 : Closed fd 28 2014-09-18 12:54:11.987+: 1288: debug : virFileClose:99 : Closed fd 30 2014-09-18 12:54:11.987+: 1288: debug : virCommandRunAsync:2412 : Command result 0, with PID 11620 2014-09-18 12:54:11.987+: 1288: debug : virFileClose:99 : Closed fd 25 2014-09-18 12:54:11.987+: 1288: debug : virFileClose:99 : Closed fd 26 2014-09-18 12:54:12.002+: 1288: debug : virCommandRun:2260 : Result status 0, stdout: ' KXS_C0 50af01bb-29bd-4263-82af-4d49d53260ba 16384 16384 160 1020 /machine oVirt oVir
Change in vdsm[master]: utils: Add changehash function for change detection
Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: I hope that engine treat this as opaque string, hopefully one of the reviewers can confirm that. -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Francesco Romani has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: neat! The only thing that worries me is how Engine is supposed to use this value. I mean, it is considered just as an opaque string that it is stored and checked for equality? If so it doesn't really matter how long it is and how it looks like, and we can happily go ahead. As for the change itself solid +1. -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11582/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1690/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12371/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Nir Soffer has uploaded a new change for review.
Change subject: utils: Add changehash function for change detection
..
utils: Add changehash function for change detection
We use Python built-in hash to detect changes in vm state without sending
the state in each response. This function is not suitable for this
usage. Now we use generic utils.changehash(), implemented using md5
hexdigest.
Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0
Signed-off-by: Nir Soffer
---
M lib/vdsm/utils.py
M vdsm/virt/vm.py
2 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/33045/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 23c63e8..1b4a9d5 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -37,6 +37,7 @@
import glob
import io
import itertools
+import hashlib
import logging
import re
import sys
@@ -1133,3 +1134,13 @@
flags = fcntl.fcntl(fd, fcntl.F_GETFL)
flags |= os.O_NONBLOCK
fcntl.fcntl(fd, fcntl.F_SETFL, flags)
+
+
+def changehash(s):
+"""
+Returns a hash of string s, suitable for change detection.
+
+Tipically changehash(s) is sent to client frequently. When a client detect
+that changehash(s) changed, it ask for s itself, which may be much bigger.
+"""
+return hashlib.md5(s).hexdigest()
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 941f283..b1567f9 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1500,7 +1500,7 @@
self.guestAgent = guestagent.GuestAgent(
self._guestSocketFile, self.cif.channelListener, self.log)
self._lastXMLDesc = '%s' % self.id
-self._devXmlHash = '0'
+self._devXmlHash = utils.changehash('')
self._released = False
self._releaseLock = threading.Lock()
self.saveState()
@@ -4495,7 +4495,7 @@
self._lastXMLDesc = self._dom.XMLDesc(0)
devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
getElementsByTagName('devices')[0]
-self._devXmlHash = str(hash(devxml.toxml()))
+self._devXmlHash = utils.changehash(devxml.toxml())
return self._lastXMLDesc
--
To view, visit http://gerrit.ovirt.org/33045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: qemuimg: Create qcow2 compat 0.10 images
Dan Kenigsberg has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33022/1/lib/vdsm/qemuImg.py File lib/vdsm/qemuImg.py: Line 118: if rc != 0: Line 119: raise QImgError(rc, out, err) Line 120: Line 121: Line 122: def _supports_qcow2_compat(): > no because if qemu-img is updated you're in trouble. I don't expect a qemu-0.10 -> qemu-1.1 upgrade while Vdsm is running. But we can live with this repetitive check for a while. Line 123: """ Line 124: TODO: Remove this when qemu versions providing the "compat" option are Line 125: available on all platforms. Line 126: """ -- To view, visit http://gerrit.ovirt.org/33022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Dan Kenigsberg has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/32928/6/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 16: fi Line 17: Line 18: # Fix VMs migrating to host with libvirt >= 1.2.8 Line 19: # See https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Line 20: exec sed -e 's|]*>[0-9 ]*||g' > if it returns 1 and fail? From http://www.libvirt.org/hooks.html#qemu """ In case the script returns failure or the output XML is not valid, incoming migration will be canceled. """ which is what we want. -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pyroute2: IPv6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: pyroute2: IPv6 support .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4003/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pyroute2: IPv6 support
Dan Kenigsberg has submitted this change and it was merged. Change subject: pyroute2: IPv6 support .. pyroute2: IPv6 support IPv6 support added to pyroute2 configurator. Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583 Signed-off-by: Petr Horáček Reviewed-on: http://gerrit.ovirt.org/32033 Reviewed-by: Ondřej Svoboda Reviewed-by: Antoni Segura Puimedon Reviewed-by: Dan Kenigsberg --- M vdsm/network/configurators/pyroute_two.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Ondřej Svoboda: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pyroute2: IPv6 support
Dan Kenigsberg has posted comments on this change. Change subject: pyroute2: IPv6 support .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: qemuimg: Create qcow2 compat 0.10 images
Allon Mureinik has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: Code-Review+1 Nir, can you verify? -- To view, visit http://gerrit.ovirt.org/33022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Yaniv Bronhaim has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/32928/6/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 16: fi Line 17: Line 18: # Fix VMs migrating to host with libvirt >= 1.2.8 Line 19: # See https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Line 20: exec sed -e 's|]*>[0-9 ]*||g' if it returns 1 and fail? -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Fix for json-rpc issue wrt gluster commands.
Yaniv Bronhaim has submitted this change and it was merged. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. gluster: Fix for json-rpc issue wrt gluster commands. This patch adds spec file entry for missing apiwrapper module and moved vdsmapi-gluster-schema.json from vdsm/gluster/ to vdsm/rpc/. Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124481 Signed-off-by: ndarshan Reviewed-on: http://gerrit.ovirt.org/33007 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/33036 Reviewed-by: Yaniv Bronhaim --- M vdsm.spec.in M vdsm/gluster/Makefile.am M vdsm/rpc/Makefile.am R vdsm/rpc/vdsmapi-gluster-schema.json M vdsm/rpc/vdsmapi.py 5 files changed, 5 insertions(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Darshan N: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Fix for json-rpc issue wrt gluster commands.
Yaniv Bronhaim has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pyroute2: IPv6 support
Antoni Segura Puimedon has posted comments on this change.
Change subject: pyroute2: IPv6 support
..
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/32033/4/vdsm/network/configurators/pyroute_two.py
File vdsm/network/configurators/pyroute_two.py:
Line 69: with self.ip.interfaces[iface.name] as i:
Line 70: i.add_ip(ipConfig.ipv6addr)
Line 71: if ipConfig.ipv6gateway:
Line 72: self.ip.routes.add({'dst': 'default',
Line 73: 'gateway':
ipConfig.ipv6gateway}).commit()
I would have preferred explicit family setting, but pyroute2 autodetects, so it
is fine.
Line 74: if ipConfig.ipv6autoconf is not None:
Line 75: with open('/proc/sys/net/ipv6/conf/%s/autoconf' %
iface.name,
Line 76: 'w') as ipv6_autoconf:
Line 77: ipv6_autoconf.write('1' if ipConfig.ipv6autoconf else
'0')
--
To view, visit http://gerrit.ovirt.org/32033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Fix for json-rpc issue wrt gluster commands.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fence: Fix description of result and JSONRPC marshalling
Dan Kenigsberg has posted comments on this change. Change subject: fence: Fix description of result and JSONRPC marshalling .. Patch Set 2: Code-Review+2 Yet another quick backport for ovirt-3.5 -- To view, visit http://gerrit.ovirt.org/33034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib39744828d56de2ec0bc6406d7dcfa116a7ec8d8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fence: Fix description of result and JSONRPC marshalling
Yaniv Bronhaim has posted comments on this change. Change subject: fence: Fix description of result and JSONRPC marshalling .. Patch Set 2: Code-Review+1 (1 comment) it looks ok to me http://gerrit.ovirt.org/#/c/33034/2//COMMIT_MSG Commit Message: Line 7: JSONRPC add: .. for fenceNode API -- To view, visit http://gerrit.ovirt.org/33034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib39744828d56de2ec0bc6406d7dcfa116a7ec8d8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pyroute2: IPv6 support
Antoni Segura Puimedon has posted comments on this change. Change subject: pyroute2: IPv6 support .. Patch Set 4: -Code-Review -- To view, visit http://gerrit.ovirt.org/32033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Francesco Romani has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/361/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/378/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11581/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1689/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12370/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Fix for json-rpc issue wrt gluster commands.
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33036
to review the following change.
Change subject: gluster: Fix for json-rpc issue wrt gluster commands.
..
gluster: Fix for json-rpc issue wrt gluster commands.
This patch adds spec file entry for missing apiwrapper
module and moved vdsmapi-gluster-schema.json from
vdsm/gluster/ to vdsm/rpc/.
Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124481
Signed-off-by: ndarshan
Reviewed-on: http://gerrit.ovirt.org/33007
Reviewed-by: Dan Kenigsberg
---
M vdsm.spec.in
M vdsm/gluster/Makefile.am
M vdsm/rpc/Makefile.am
R vdsm/rpc/vdsmapi-gluster-schema.json
M vdsm/rpc/vdsmapi.py
5 files changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/33036/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index c864ef0..350811e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1480,7 +1480,8 @@
%dir %{_datadir}/%{vdsm_name}/gluster
%doc COPYING
%{_datadir}/%{vdsm_name}/gluster/api.py*
-%{_datadir}/%{vdsm_name}/gluster/vdsmapi-gluster-schema.json
+%{_datadir}/%{vdsm_name}/gluster/apiwrapper.py*
+%{_datadir}/%{vdsm_name}/rpc/vdsmapi-gluster-schema.json
%{_datadir}/%{vdsm_name}/gluster/gfapi.py*
%{_datadir}/%{vdsm_name}/gluster/hooks.py*
%{_datadir}/%{vdsm_name}/gluster/services.py*
diff --git a/vdsm/gluster/Makefile.am b/vdsm/gluster/Makefile.am
index 3c307aa..d1d3ebf 100644
--- a/vdsm/gluster/Makefile.am
+++ b/vdsm/gluster/Makefile.am
@@ -29,16 +29,13 @@
dist_vdsmgluster_PYTHON = \
__init__.py \
api.py \
+ apiwrapper.py \
cli.py \
exception.py \
gfapi.py \
hooks.py \
services.py \
tasks.py \
- $(NULL)
-
-dist_vdsmgluster_DATA = \
- vdsmapi-gluster-schema.json \
$(NULL)
EXTRA_DIST = \
diff --git a/vdsm/rpc/Makefile.am b/vdsm/rpc/Makefile.am
index 082ea81..6b10dc1 100644
--- a/vdsm/rpc/Makefile.am
+++ b/vdsm/rpc/Makefile.am
@@ -16,6 +16,7 @@
$(NULL)
dist_vdsmrpc_DATA = \
+ vdsmapi-gluster-schema.json \
vdsmapi-schema.json \
$(NULL)
diff --git a/vdsm/gluster/vdsmapi-gluster-schema.json
b/vdsm/rpc/vdsmapi-gluster-schema.json
similarity index 100%
rename from vdsm/gluster/vdsmapi-gluster-schema.json
rename to vdsm/rpc/vdsmapi-gluster-schema.json
diff --git a/vdsm/rpc/vdsmapi.py b/vdsm/rpc/vdsmapi.py
index 9e4de3e..2f13ef2 100644
--- a/vdsm/rpc/vdsmapi.py
+++ b/vdsm/rpc/vdsmapi.py
@@ -190,7 +190,7 @@
info_key = schema
if schema is None:
schema = find_schema()
-gluster_schema = find_schema(schema_name='gluster/vdsmapi-gluster',
+gluster_schema = find_schema(schema_name='vdsmapi-gluster',
raiseOnError=False)
with open(schema) as f:
--
To view, visit http://gerrit.ovirt.org/33036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Fix for json-rpc issue wrt gluster commands.
Darshan N has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32928/5/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 6: # This condition depends on a feature that will be included in Line 7: # libvirt once https://bugzilla.redhat.com/show_bug.cgi?id=1142684 Line 8: # is resolved. It will work only for migrations before that. Line 9: if [ "x$EVENT" != "xmigrate" -a "x$EVENT" != "xrestore" ]; then Line 10: exit 0 This is confusing, since this script is run like a filter, and in this flow we do not output anything. Libvirt handles empty output as "no change needed", but the next reader do not know this. Lets document our intent. Line 11: fi Line 12: Line 13: # Fix VMs migrating to host with libvirt >= 1.2.8 Line 14: # See https://bugzilla.redhat.com/show_bug.cgi?id=1138340 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: -Code-Review -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32928/5/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 5: Line 6: # This condition depends on a feature that will be included in Line 7: # libvirt once https://bugzilla.redhat.com/show_bug.cgi?id=1142684 Line 8: # is resolved. It will work only for migrations before that. Line 9: if [ "x$EVENT" != "xmigrate" -a "x$EVENT" != "xrestore" ]; then We could use: if [ "migrate" != "$EVENT" -a "restore" != "$EVENT" ]; then Which cannot break if $EVENT expand to "-n". Line 10: exit 0 Line 11: fi Line 12: Line 13: # Fix VMs migrating to host with libvirt >= 1.2.8 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Nir Soffer has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
Martin Sivák has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32928/4/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 5: Line 6: # This condition depends on a feature that will be included in Line 7: # libvirt once https://bugzilla.redhat.com/show_bug.cgi?id=1142684 Line 8: # is resolved. It will work only for migrations before that. Line 9: if [ "x$EVENT" != "xmigrate" -a "x$EVENT" != "xrestore" ]; then > Why do you need the "x"? If we rely on libvirt implementation, then I probably don't. Otherwise it prevents test from being confused by input with - at the beginning that could be evaluated as an option (-n, -z, -a, ...) instead of a value. And it works on old shells with broken test command.. but those are not really relevant for us anymore. It is just hardwired to my brain, I have used it for about 15 years now. Line 10: exit 0 Line 11: fi Line 12: Line 13: # Fix VMs migrating to host with libvirt >= 1.2.8 -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add a libvirt migration hook to filter out min_guarantee ele...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/360/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/377/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11580/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1688/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12369/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fence: Fix description of result and JSONRPC marshalling
oVirt Jenkins CI Server has posted comments on this change. Change subject: fence: Fix description of result and JSONRPC marshalling .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11579/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12523/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12368/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib39744828d56de2ec0bc6406d7dcfa116a7ec8d8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fence: Fix description of result and JSONRPC marshalling
oVirt Jenkins CI Server has posted comments on this change. Change subject: fence: Fix description of result and JSONRPC marshalling .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11578/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12522/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12367/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib39744828d56de2ec0bc6406d7dcfa116a7ec8d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images
Yaniv Bronhaim has submitted this change and it was merged. Change subject: qemuimg: Create qcow2 compat 0.10 images .. qemuimg: Create qcow2 compat 0.10 images Recent qemu versions introduced a new default qcow2 format (1.1), which is not compatible with older versions of qemu. For example, EL6 host cannot create snapshots if an image was created on EL7 host. This patch uses the "compat" option to create images in the older format (0.10), which are are compatible with different versions of qemu. The "compat" option is not available on older qemu-img, so we have to use the "-o ?" option to detect the availability of the "compat" option before creating an image. This is the same method used by libvirt. When all supported platforms provide the "compat" option, we can remove the "compat" detection code. Chanding the compat version will require a new storage domain format. Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Bug-Url: https://bugzilla.redhat.com/1139707 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/32836 Reviewed-by: Allon Mureinik Reviewed-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/33020 Reviewed-by: Dan Kenigsberg Reviewed-by: Yaniv Bronhaim --- M lib/vdsm/qemuimg.py M tests/qemuimgTests.py 2 files changed, 86 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, approved Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemuimg: Create qcow2 compat 0.10 images
Yaniv Bronhaim has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix for json-rpc issue wrt gluster commands.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1869/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4002/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix for json-rpc issue wrt gluster commands.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 2: Code-Review+2 Please backport to 3.5! -- To view, visit http://gerrit.ovirt.org/33007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix for json-rpc issue wrt gluster commands.
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. gluster: Fix for json-rpc issue wrt gluster commands. This patch adds spec file entry for missing apiwrapper module and moved vdsmapi-gluster-schema.json from vdsm/gluster/ to vdsm/rpc/. Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124481 Signed-off-by: ndarshan Reviewed-on: http://gerrit.ovirt.org/33007 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in M vdsm/gluster/Makefile.am M vdsm/rpc/Makefile.am R vdsm/rpc/vdsmapi-gluster-schema.json M vdsm/rpc/vdsmapi.py 5 files changed, 5 insertions(+), 6 deletions(-) Approvals: Darshan N: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fence: Fix description of result and JSONRPC marshalling
Martin Peřina has uploaded a new change for review.
Change subject: fence: Fix description of result and JSONRPC marshalling
..
fence: Fix description of result and JSONRPC marshalling
1) Fixes description of fenceNode return value
2) Fixes marshalling of fenceNode return value for JSONRPC
Change-Id: Ib39744828d56de2ec0bc6406d7dcfa116a7ec8d8
Signed-off-by: Martin Perina
---
M tests/bridgeTests.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
3 files changed, 42 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/33034/1
diff --git a/tests/bridgeTests.py b/tests/bridgeTests.py
index 195478b..c1eebf1 100644
--- a/tests/bridgeTests.py
+++ b/tests/bridgeTests.py
@@ -90,7 +90,7 @@
params = obj.get('params', [])
method = getattr(bridge, mangledMethod)
-self.assertEquals(method(**params), 'on')
+self.assertEquals(method(**params), {'power': 'on'})
def testMethodWithNoParams(self):
createFakeAPI()
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index b6dfefa..73970e0 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -284,6 +284,19 @@
return self._fixupRet(className, methodName, ret)
+def Host_fenceNode_Ret(ret):
+"""
+Only 'power' and 'operationStatus' should be part of return value if they
+are not None
+"""
+result = {}
+for key in ('power', 'operationStatus'):
+val = ret.get(key)
+if val is not None:
+result[key] = val
+return result
+
+
def Host_getCapabilities_Ret(server_address, ret):
"""
We need to add additional information to getCaps as it is done for xmlrpc.
@@ -375,7 +388,7 @@
'ConnectionRefs_acquire': {'ret': 'results'},
'ConnectionRefs_release': {'ret': 'results'},
'ConnectionRefs_statuses': {'ret': 'connectionslist'},
-'Host_fenceNode': {'ret': 'power'},
+'Host_fenceNode': {'ret': Host_fenceNode_Ret},
'Host_getAllTasksInfo': {'ret': 'allTasksInfo'},
'Host_getAllTasksStatuses': {'ret': 'allTasksStatus'},
'Host_getCapabilities': {'ret': Host_getCapabilities_Ret},
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 426d28e..19dc5d1 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -271,9 +271,9 @@
{'enum': 'FenceNodeAction', 'data': ['status', 'on', 'off', 'reboot']}
##
-# @FenceNodeResult:
+# @FenceNodePowerStatusResult:
#
-# For 'status' action, the result is the power status of the host
+# The host power status as a result of 'status' action.
#
# @on: The remote host is powered on
#
@@ -282,8 +282,14 @@
# @unknown: The power status is not known
#
# Since: 4.10.0
+##
+{'enum': 'FenceNodePowerStatusResult', 'data': ['on', 'off', 'unknown']}
+
+##
+# @FenceNodeOperationStatusResult:
#
-# For 'on', 'off' and 'reboot', the result is status of fence script execution
+# Status of fence script execution as a result of 'on', 'off' and 'reboot'
+# actions.
#
# @initiated: Fence script was executed
#
@@ -291,8 +297,24 @@
#
# Since: 4.16.0
##
-{'enum': 'FenceNodeResult', 'data': ['on', 'off', 'unknown', 'initiated',
- 'skipped']}
+{'enum': 'FenceNodeOperationStatusResult', 'data': ['initiated', 'skipped']}
+
+##
+# @FenceNodeResult:
+#
+# Result of fenceNode command.
+#
+# @power: #optional power status of host as a result of 'status'
+# action
+# Since: 4.10.0
+#
+# @operationStatus: #optional status of fence action executions for 'on',
+# 'off' and 'reboot' actions
+# Since: 4.16.0
+##
+{'type': 'FenceNodeResult',
+ 'data': {'*power': 'FenceNodePowerStatusResult',
+ '*operationStatus': 'FenceNodeOperationStatusResult'}}
##
# @HostIdMap:
--
To view, visit http://gerrit.ovirt.org/33034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib39744828d56de2ec0bc6406d7dcfa116a7ec8d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: when None is set as default value Bridge.py fails
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: when None is set as default value Bridge.py fails .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a1cea87e62952f9675cba3b9d8e891985c8333 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: when None is set as default value Bridge.py fails
Yaniv Bronhaim has submitted this change and it was merged. Change subject: jsonrpc: when None is set as default value Bridge.py fails .. jsonrpc: when None is set as default value Bridge.py fails When None is set as default value for parameter which uses custom type Bridge.py fails. Bug-Url: https://bugzilla.redhat.com/1143854 Change-Id: Ia1a1cea87e62952f9675cba3b9d8e891985c8333 Signed-off-by: pkliczewski Reviewed-on: http://gerrit.ovirt.org/33033 Reviewed-by: Oved Ourfali Reviewed-by: Yaniv Bronhaim --- M vdsm/rpc/Bridge.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1a1cea87e62952f9675cba3b9d8e891985c8333 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: when None is set as default value Bridge.py fails
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: when None is set as default value Bridge.py fails .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a1cea87e62952f9675cba3b9d8e891985c8333 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use running() for downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use running() for downtime thread .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11577/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1687/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12366/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5418b610fc1746751b717ad7d3c746a548559566 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix for json-rpc issue wrt gluster commands.
Darshan N has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename cancel->stop method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename cancel->stop method .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11576/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1686/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12365/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia938ae0fa5bf3ddd16ffc992299566b618ea4677 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: avoid implicit thread start
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: avoid implicit thread start .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11575/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1685/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12364/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6859be9ce73c618f824e9f5cc0da8fcfe550ac2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix for json-rpc issue wrt gluster commands.
Darshan N has posted comments on this change. Change subject: gluster: Fix for json-rpc issue wrt gluster commands. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33007/1/vdsm/rpc/vdsmapi.py File vdsm/rpc/vdsmapi.py: Line 123: Line 124: localpath = os.path.dirname(__file__) Line 125: Line 126: if schema_name == 'vdsmapi-gluster': Line 127: installedpath = constants.P_VDSM_GLUSTER > it seems so much cleaner to place vdsmapi-gluster-schema.json under /usr/sh ya, Will move it to vdsm/rpc/ . Line 128: else: Line 129: installedpath = constants.P_VDSM_RPC Line 130: Line 131: for directory in localpath, installedpath: -- To view, visit http://gerrit.ovirt.org/33007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cf744813f7bbfbf6e2bf073b28b88e0d3f304f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1684/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12363/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
