Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Run configure during post install when upgrading from
vdsm-4.10.x
..
Run configure during post install when upgrading from vdsm-4.10.x
In ovirt-3.2 (vdsm 4.10.x) we didn't perform vdsm-tool configure call
during uninstall. This causes failure on first vdsm run if configure is
required. This patch adds simple external script for the configure
and execute it during post upgraded version is vdsm-4.10.x.
Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=935
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M lib/vdsm/tool/Makefile.am
A lib/vdsm/tool/upgrade_320_conf.sh.in
M vdsm.spec.in
3 files changed, 297 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/33450/1
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index 0198310..19d32cc 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -23,6 +23,7 @@
load_needed_modules.py.in \
libvirt_configure.sh.in \
validate_ovirt_certs.py.in \
+ upgrade_320_conf.sh.in \
$(NULL)
nodist_vdsmtool_PYTHON = \
@@ -32,6 +33,7 @@
nodist_vdsmexec_SCRIPTS = \
libvirt_configure.sh \
+ upgrade_320_conf.sh \
$(NULL)
dist_vdsmtool_PYTHON = \
diff --git a/lib/vdsm/tool/upgrade_320_conf.sh.in
b/lib/vdsm/tool/upgrade_320_conf.sh.in
new file mode 100755
index 000..4dce061
--- /dev/null
+++ b/lib/vdsm/tool/upgrade_320_conf.sh.in
@@ -0,0 +1,283 @@
+#! /bin/sh
+# Copyright 2013 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+. @LIBEXECDIR@/ovirt_functions.sh
+
+ENABLE_LIBVIRT_SANLOCK=@ENABLE_LIBVIRT_SANLOCK@
+ENABLE_LIBVIRT_SELINUX=@ENABLE_LIBVIRT_SELINUX@
+
+GETCONFITEM=@VDSMDIR@/get-conf-item
+VDSM_CONF_FILE=@CONFDIR@/vdsm.conf
+QEMU_DUMP_PATH=/var/log/core
+LCONF=@sysconfdir@/libvirt/libvirtd.conf
+QCONF=@sysconfdir@/libvirt/qemu.conf
+LDCONF=@LIBVIRT_SERVICE_DEFAULT@
+QLCONF=@sysconfdir@/libvirt/qemu-sanlock.conf
+
+# The PACKAGE_VERSION define is not used here because we do not want to
+# update the libvirt configure file every time we change vdsm package
+# version. In fact the configure generated here is almost unrelated to the
+# package version, so anything meaningful can be used here. Since a hard
+# coded version string has been already used, for compatibility we will
+# continue to use this string.
+BY_VDSM_VERS=4.13.0
+
+[ ${ENABLE_LIBVIRT_SANLOCK} = yes ] || QLCONF=/dev/null
+
+# trigger for reconfiguration
+FORCE_RECONFIGURE=@VDSMLIBDIR@/reconfigure
+
+get_libvirt_conf_item() {
+local cfile=$1
+local key=$2
+@GREP_PATH@ -E ^\s*${key}\s*= ${cfile} | \
+tail -1 | @SED_PATH@ s/\s*$key\s*=\s*//;s/\s*\(#.*\)\?$//
+}
+
+libvirtd_sysv2upstart() {
+# On RHEL 6, libvirtd can be started by either SysV init or Upstart.
+# We prefer upstart because it respawns libvirtd if when libvirtd crashed.
+
+if ! [ -x /sbin/initctl ]; then
+# We don't have Upstart, still use system default init mechanism
+return 0
+fi
+
+local packaged=$(@RPM_PATH@ -ql libvirt libvirt-daemon | \
+ @GREP_PATH@ libvirtd.upstart | tail -1)
+local target=/etc/init/libvirtd.conf
+
+if ! [ -f ${packaged} ]; then
+# libvirtd package does not provide libvirtd.upstart,
+# this could happen in Ubuntu or other distro,
+# so continue to use system default init mechanism
+return 0
+fi
+
+# Shutoff libvirt SysV service before configure upstart
+if [ ! -f ${target} ]; then
+@CHKCONFIG_PATH@ libvirtd off
+fi
+
+if ! diff -q ${packaged} ${target} /dev/null 21; then
+@CP_PATH@ -p ${packaged} ${target} || return 1
+/sbin/initctl reload-configuration
+fi
+}
+
+# Remove configuration created by vdsm (old # by vdsm and the new format)
+# Argument: configuration file that will be inspected
+remove_vdsm_conf() {
+local confFile
+for confFile in $@ ; do
+# ed considers empty address ranges as error and exits on error.
+# If there is no old #
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
Yaniv Bronhaim has posted comments on this change. Change subject: Run configure during post install when upgrading from vdsm-4.10.x .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33450/1/lib/vdsm/tool/upgrade_320_conf.sh.in File lib/vdsm/tool/upgrade_320_conf.sh.in: Line 1: #! /bin/sh Line 2: # Copyright 2013 Red Hat, Inc. 2014 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/33450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Run configure during post install when upgrading from vdsm-4...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run configure during post install when upgrading from vdsm-4.10.x .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/77/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fix typo in filename - ibm_powerkvm-release
..
Fix typo in filename - ibm_powerkvm-release
Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131965
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm/caps.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/33451/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 0f3bffd..b8488b4 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -536,7 +536,7 @@
return OSName.RHEL
elif os.path.exists('/etc/debian_version'):
return OSName.DEBIAN
-elif os.path.exists('/etc/ibm-powerkvm-release'):
+elif os.path.exists('/etc/ibm_powerkvm-release'):
return OSName.POWERKVM
else:
return OSName.UNKNOWN
--
To view, visit http://gerrit.ovirt.org/33451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fix typo in filename - ibm_powerkvm-release
..
Fix typo in filename - ibm_powerkvm-release
Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131965
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm/caps.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/33452/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 1d35d7c..2016a6a 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -497,7 +497,7 @@
return OSName.RHEL
elif os.path.exists('/etc/debian_version'):
return OSName.DEBIAN
-elif os.path.exists('/etc/ibm-powerkvm-release'):
+elif os.path.exists('/etc/ibm_powerkvm-release'):
return OSName.POWERKVM
else:
return OSName.UNKNOWN
--
To view, visit http://gerrit.ovirt.org/33452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix typo in filename - ibm_powerkvm-release
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12633/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12478/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Run configure during pre install when upgrading from vdsm-4....
Yaniv Bronhaim has abandoned this change. Change subject: Run configure during pre install when upgrading from vdsm-4.10.x .. Abandoned will be specific fix for 3.4 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rounding up swap usage
Yaniv Bronhaim has abandoned this change. Change subject: Rounding up swap usage .. Abandoned handled in engine's side -- To view, visit http://gerrit.ovirt.org/32911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7eb33f0f003f7442efb103f43bbc60c5faa6a439 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Francesco Romani has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Francesco Romani has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Francesco Romani has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33045/1//COMMIT_MSG Commit Message: Line 6: Line 7: utils: Add changehash function for change detection Line 8: Line 9: We use Python built-in hash to detect changes in vm state without sending Line 10: the state in each response. This function is not suitable for this Using the built-in hash may be good enough, specially on 64 bit systems. Th I suggest to augment the commit message with this comment to make it obvious at first glance why this change is good. Line 11: usage. Now we use generic utils.changehash(), implemented using md5 Line 12: hexdigest. Line 13: Line 14: Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix typo in filename - ibm_powerkvm-release
Michal Skrivanek has posted comments on this change.
Change subject: Fix typo in filename - ibm_powerkvm-release
..
Patch Set 1: Code-Review+1 Verified+1
before:
operatingSystem = {'name': 'unknown', 'release': '', 'version': ''}
after:
operatingSystem = {'name': 'PowerKVM', 'release': '3.4.2.30.0.pkvm2_1',
'version': '19_0'
--
To view, visit http://gerrit.ovirt.org/33451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Degrading epoll errors in vmchannels to log level INFO
Vinzenz Feenstra has uploaded a new change for review. Change subject: Degrading epoll errors in vmchannels to log level INFO .. Degrading epoll errors in vmchannels to log level INFO Error events from epoll are quite common due to lost connections on shutdown, migrations or suspension of VMs, since this is not a critical error the message gets degraded to INFO. Change-Id: I0099fb39a6261e2339c12ae25ea16f32bff1a55f Bug-Url: https://bugzilla.redhat.com/1102549 Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: http://gerrit.ovirt.org/30141 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Martin Polednik mpoled...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com (cherry picked from commit 0fa65b1c8b2829473e8b9424c61986f34cc4bda3) --- M vdsm/virt/vmchannels.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/33454/1 diff --git a/vdsm/virt/vmchannels.py b/vdsm/virt/vmchannels.py index 896878b..fe6da09 100644 --- a/vdsm/virt/vmchannels.py +++ b/vdsm/virt/vmchannels.py @@ -51,7 +51,7 @@ Handle an epoll event occurred on a specific file descriptor. reconnect = False if (event (select.EPOLLHUP | select.EPOLLERR)): -self.log.error(Received %.08X on fileno %d, event, fileno) +self.log.info(Received %.08X on fileno %d, event, fileno) if fileno in self._channels: reconnect = True else: -- To view, visit http://gerrit.ovirt.org/33454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0099fb39a6261e2339c12ae25ea16f32bff1a55f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Degrading epoll errors in vmchannels to log level INFO
Vinzenz Feenstra has posted comments on this change. Change subject: Degrading epoll errors in vmchannels to log level INFO .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0099fb39a6261e2339c12ae25ea16f32bff1a55f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
Yaniv Bronhaim has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: put value in AUTHOR tool manual page
mooli tayer has uploaded a new change for review. Change subject: tool: put value in AUTHOR tool manual page .. tool: put value in AUTHOR tool manual page Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Signed-off-by: Mooli Tayer mta...@redhat.com --- M vdsm-tool/vdsm-tool.1.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/33455/1 diff --git a/vdsm-tool/vdsm-tool.1.in b/vdsm-tool/vdsm-tool.1.in index f64025b..faa803d 100644 --- a/vdsm-tool/vdsm-tool.1.in +++ b/vdsm-tool/vdsm-tool.1.in @@ -183,7 +183,7 @@ Prints the host UUID. .RE .SH AUTHOR -Author list +This manual page was written by Andrew Dahms for the oVirt project. .SH BUGS Report bugs to http://bugzilla.redhat.com .SH COPYRIGHT -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: fill AUTHOR at vdsm-tool manual page.
mooli tayer has posted comments on this change. Change subject: tool: fill AUTHOR at vdsm-tool manual page. .. Patch Set 2: Verified+1 If There is agreement I will add the author as well. AUTHOR This manual page was written by Andrew Dahms for the oVirt project. -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: fill AUTHOR at vdsm-tool manual page.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: fill AUTHOR at vdsm-tool manual page. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12634/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12479/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: fill AUTHOR at vdsm-tool manual page.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: fill AUTHOR at vdsm-tool manual page. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12635/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12480/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: fill AUTHOR at vdsm-tool manual page.
Nir Soffer has posted comments on this change. Change subject: tool: fill AUTHOR at vdsm-tool manual page. .. Patch Set 2: Looks ok, but note that I know nothing about man formatting :-) -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Federico Simoncelli has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Move private functions to end of module
Federico Simoncelli has posted comments on this change. Change subject: qemuimg: Move private functions to end of module .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I060d3bb817ee543dabaf401756a909984cca9f8e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for qcow2 comapt option when converting images
Federico Simoncelli has posted comments on this change. Change subject: tests: Add tests for qcow2 comapt option when converting images .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d19b59bf4880e20f53369c79ae34386d274915d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 7: Verified+1 Verified after manually applied JSON patch http://gerrit.ovirt.org/#/c/33424/ -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/395/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2001/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12481/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: making PM 'on' and 'off' sync .. vdsm: making PM 'on' and 'off' sync Consider the following scenario: DC1 with H1 (with PM) and H2 on cluster C1 another host H3 on DC1 cluster C2 When we are blocking the communication with iptables from H2 to H1 PM card and use the default proxy preferences (cluster, dc) a Restart operation will always fail. VDSM should perform start/stop sync and return the correct script returned code in order that engine will know that H2 fails to perform the operation and will try to use H3 as a proxy for the failed operation This patch changes the fenceNode function to be sync when 'on' 'off' operation are used in the same manner of 'status' operation and return the correct exit code of the invoked fencing script to the caller. Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139643 Signed-off-by: Eli Mesika emes...@redhat.com Reviewed-on: http://gerrit.ovirt.org/32695 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py 1 file changed, 16 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for qcow2 comapt option when converting images
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Add tests for qcow2 comapt option when converting images .. tests: Add tests for qcow2 comapt option when converting images Since qemuimg.convert() uses utils.watchCmd instead of utils.execCmd, FakeExecCmd was modified so it can patch both functions. This patch is separate from the actual fix, to allow easy backporting of the actual fix, without backporing the testing infrastructure, which is missing in older versions. Change-Id: I0d19b59bf4880e20f53369c79ae34386d274915d Relates-To: https://bugzilla.redhat.com/1139707 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33350 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M tests/qemuimgTests.py 1 file changed, 83 insertions(+), 33 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d19b59bf4880e20f53369c79ae34386d274915d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Move private functions to end of module
Dan Kenigsberg has submitted this change and it was merged. Change subject: qemuimg: Move private functions to end of module .. qemuimg: Move private functions to end of module _supports_qcow_compat() is a private helper and should be after public functions. Change-Id: I060d3bb817ee543dabaf401756a909984cca9f8e Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33366 Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M lib/vdsm/qemuimg.py 1 file changed, 30 insertions(+), 30 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I060d3bb817ee543dabaf401756a909984cca9f8e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
Dan Kenigsberg has submitted this change and it was merged. Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images .. qemuimg: Create qcow2 compat 0.10 images when converting existing images Commit 1f7c3ac2c handled only creation of new images. This patch adds the required -o compat=0.10 option when converting existing images. _supports_qcow2_compat() accepts a command argument and invokes the specific command to detect if the compat option is supported. Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Bug-Url: https://bugzilla.redhat.com/1139707 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33349 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M lib/vdsm/qemuimg.py 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
Yeela Kaplan has uploaded a new change for review. Change subject: utils: Use ovirt node for persist files .. utils: Use ovirt node for persist files Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Signed-off-by: Yeela Kaplan ykap...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/33468/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index e08ec3c..d619e98 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -53,6 +53,15 @@ from cpopen import CPopen from . import constants +try: +from ovirt.node.utils.fs import Config +cfg = Config() +persistFile = cfg.persist +del cfg +except ImportError: +persistFile = lambda name: None + + # Buffsize is 1K because I tested it on some use cases and 1K was fastest. If # you find this number to be a bottleneck in any way you are welcome to change # it @@ -141,11 +150,6 @@ logging.warning(Directory: %s already removed, directoryToRemove) else: raise - - -def persistFile(name): -if isOvirtNode(): -execCmd([constants.EXT_PERSIST, name], sudo=True) def _parseMemInfo(lines): -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 12: Verified+1
Prettified the JSON for easier comparison, referred to the ' NetworkManager
ifups VDSM's reference bond' bug.
Only unit testMirroringWithDistraction failed with
CalledProcessError: Command '['/usr/sbin/brctl', 'delbr', 'vdsmtest-wSe0P']'
returned non-zero exit status 1
this time (the bridge was still up).
Functional testSetupNetworksOverDhcpIface failed on
ipv4addr, prefix = addr['address'].split('/')
with ValueError: need more than 1 value to unpack. I believe this is unrelated
and will try to find out the source of this test failure.
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Move functionality from storage.misc
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Move functionality from storage.misc .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12484/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c547e3ac2ecf19359c32f7e717ad7b098bfbca4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync
Eli Mesika has uploaded a new change for review.
Change subject: vdsm: making PM 'on' and 'off' sync
..
vdsm: making PM 'on' and 'off' sync
Consider the following scenario:
DC1 with H1 (with PM) and H2 on cluster C1
another host H3 on DC1 cluster C2
When we are blocking the communication with iptables from H2 to H1 PM
card and use the default proxy preferences (cluster, dc) a Restart
operation will always fail.
VDSM should perform start/stop sync and return the correct script
returned code in order that engine will know that H2 fails to perform
the operation and will try to use H3 as a proxy for the failed operation
This patch changes the fenceNode function to be sync when 'on' 'off'
operation are used in the same manner of 'status' operation and return
the correct exit code of the invoked fencing script to the caller.
Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139643
Signed-off-by: Eli Mesika emes...@redhat.com
---
M vdsm/API.py
1 file changed, 16 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/33469/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 6378f2c..5d948f8 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1205,19 +1205,19 @@
inp += 'secure=yes\n'
inp += options
+try:
+rc, out, err = fence(script, inp)
+except OSError as e:
+if e.errno == os.errno.ENOENT:
+return errCode['fenceAgent']
+raise
+self.log.debug('rc %s in %s out %s err %s', rc,
+ hidePasswd(inp), out, err)
+if not 0 = rc = 2:
+return {'status': {'code': 1,
+ 'message': out + err}}
+message = doneCode['message']
if action == 'status':
-try:
-rc, out, err = fence(script, inp)
-except OSError as e:
-if e.errno == os.errno.ENOENT:
-return errCode['fenceAgent']
-raise
-self.log.debug('rc %s in %s out %s err %s', rc,
- hidePasswd(inp), out, err)
-if not 0 = rc = 2:
-return {'status': {'code': 1,
- 'message': out + err}}
-message = doneCode['message']
if rc == 0:
power = 'on'
elif rc == 2:
@@ -1227,9 +1227,10 @@
message = out + err
return {'status': {'code': 0, 'message': message},
'power': power}
-threading.Thread(target=fence, args=(script, inp)).start()
-return {'status': doneCode, 'power': 'unknown',
-'operationStatus': 'initiated'}
+if rc != 0:
+message = out + err
+return {'status': {'code': rc, 'message': message},
+'power': 'unknown', 'operationStatus': 'initiated'}
def ping(self):
Ping the server. Useful for tests
--
To view, visit http://gerrit.ovirt.org/33469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Eli Mesika emes...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Use ovirt node for persist files
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11696/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12485/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice245d54497862f9fb86cb32acd13b8a790026b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync
Eli Mesika has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/229/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5862/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4022/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/32/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/28/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/34/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/8/ : FAILURE -- To view, visit http://gerrit.ovirt.org/32695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/396/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/413/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12482/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/30909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 12: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 408: Return default options per mode, in a dictionary of dictionaries.
All keys
Line 409: are numeric modes stored as strings for coherence with 'mode'
option value.
Line 410:
Line 411: with open(BONDING_DEFAULTS) as defaults:
Line 412: return json.loads(defaults.read())
I wonder if we should catch for ENOENT and then run vdsm-tool to create the
file. What do you think?
Line 413:
Line 414:
Line 415: @memoized
Line 416: def _getDefaultBondingOptions(mode=None):
http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:
Line 1: #! /usr/bin/python
/usr/bin/env python
Line 2: # Copyright 2014 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 81:
Line 82: with open(BONDING_DEFAULTS, 'w') as defaults:
Line 83: defaults.write(json.dumps(_get_default_bonding_options(),
Line 84: sort_keys=True, indent=4,
Line 85: separators=(',', ': ')) + '\n')
doing write of dumps is an extra step from doing:
json.dump(_get_default_bonding_options(), defaults, etc...)
Line 86:
Line 87: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 12:
(3 comments)
Changes on the way.
http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 408: Return default options per mode, in a dictionary of dictionaries.
All keys
Line 409: are numeric modes stored as strings for coherence with 'mode'
option value.
Line 410:
Line 411: with open(BONDING_DEFAULTS) as defaults:
Line 412: return json.loads(defaults.read())
I wonder if we should catch for ENOENT and then run vdsm-tool to create the
The file is preinstalled on purpose. If it is missing for any reason we must
crash.
Line 413:
Line 414:
Line 415: @memoized
Line 416: def _getDefaultBondingOptions(mode=None):
http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:
Line 1: #! /usr/bin/python
/usr/bin/env python
Done
Line 2: # Copyright 2014 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 81:
Line 82: with open(BONDING_DEFAULTS, 'w') as defaults:
Line 83: defaults.write(json.dumps(_get_default_bonding_options(),
Line 84: sort_keys=True, indent=4,
Line 85: separators=(',', ': ')) + '\n')
doing write of dumps is an extra step from doing:
If the extra options are supported I'll switch to json.dump
Line 86:
Line 87: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 408: Return default options per mode, in a dictionary of dictionaries. All keys Line 409: are numeric modes stored as strings for coherence with 'mode' option value. Line 410: Line 411: with open(BONDING_DEFAULTS) as defaults: Line 412: return json.loads(defaults.read()) I wonder if we should catch for ENOENT and then run vdsm-tool to create the vdsm-tool needs to be run as root. we could add it to sudoers, but one of the benefits of this patch's approach is that no sudo backdoors are needed. I'd rather collect this data on service startup, and assume that it's there during runtime. Line 413: Line 414: Line 415: @memoized Line 416: def _getDefaultBondingOptions(mode=None): -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/33403/12/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:
Line 81:
Line 82: with open(BONDING_DEFAULTS, 'w') as defaults:
Line 83: defaults.write(json.dumps(_get_default_bonding_options(),
Line 84: sort_keys=True, indent=4,
Line 85: separators=(',', ': ')) + '\n')
If the extra options are supported I'll switch to json.dump
Thanks
Line 86:
Line 87: if __name__ == '__main__':
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images when converting exi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemuimg: Create qcow2 compat 0.10 images when converting existing images .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4023/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/33/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/29/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/35/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/9/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733fdd8c0e50a98627794c19c61b1d9bf6d6d6b1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert 'Create default multipath.conf during install'
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert 'Create default multipath.conf during install' .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/397/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/414/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12483/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/30978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2da0442bbcc5e33123c47d0a9f1e825fe47d1cf Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 13: Verified+1 No fundamental change except the missing newline if /var/lib/vdsm/bonding-defaults.json is regenerated. -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/398/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/415/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11697/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12641/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2002/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12486/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for qcow2 comapt option when converting images
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add tests for qcow2 comapt option when converting images .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5864/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4024/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/34/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/30/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/36/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/10/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d19b59bf4880e20f53369c79ae34386d274915d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Yaniv Bronhaim has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 13:
(3 comments)
http://gerrit.ovirt.org/#/c/33403/13/debian/vdsm.install
File debian/vdsm.install:
Line 155: ./usr/share/vdsm/virt/vmstatus.py
Line 156: ./usr/share/vdsm/virt/vmxml.py
Line 157: ./usr/share/vdsm/virt/utils.py
Line 158:
./var/lib/polkit-1/localauthority/10-vendor.d/10-vdsm-libvirt-access.pkla
Line 159: ./var/lib/vdsm/bonding-defaults.json
put that in line 26. later on we'll move 158 also near the /var/lib files
http://gerrit.ovirt.org/#/c/33403/13/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 235: --pre-start)
Line 236: # If dump_bonding_defaults is desired (for the uneliminable
possibility
Line 237: # of added bonding options or tweaked kernel defaults) it has
to be run
Line 238: # after load_needed_modules (modprobe bonding).
Line 239: # NetworkManager must not crash on nmcli conn delete.
in the commit message you say that you call it, but you didn't add it to the
list..
Line 240: run_tasks \
Line 241: mkdirs \
Line 242: configure_coredump \
Line 243: configure_vdsm_logs \
http://gerrit.ovirt.org/#/c/33403/13/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:
Line 84: indent=4, separators=(',', ': '))
Line 85:
Line 86: if __name__ == '__main__':
Line 87: main()
Line 88
do you run it as script or a module? if as a module please remove that and the
Hash-Bang
--
To view, visit http://gerrit.ovirt.org/33403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm: making PM 'on' and 'off' sync .. vdsm: making PM 'on' and 'off' sync Consider the following scenario: DC1 with H1 (with PM) and H2 on cluster C1 another host H3 on DC1 cluster C2 When we are blocking the communication with iptables from H2 to H1 PM card and use the default proxy preferences (cluster, dc) a Restart operation will always fail. VDSM should perform start/stop sync and return the correct script returned code in order that engine will know that H2 fails to perform the operation and will try to use H3 as a proxy for the failed operation This patch changes the fenceNode function to be sync when 'on' 'off' operation are used in the same manner of 'status' operation and return the correct exit code of the invoked fencing script to the caller. Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139643 Signed-off-by: Eli Mesika emes...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33469 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/API.py 1 file changed, 16 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/33403/13/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 235: --pre-start) Line 236: # If dump_bonding_defaults is desired (for the uneliminable possibility Line 237: # of added bonding options or tweaked kernel defaults) it has to be run Line 238: # after load_needed_modules (modprobe bonding). Line 239: # NetworkManager must not crash on nmcli conn delete. in the commit message you say that you call it, but you didn't add it to th Actually, the commit message says that we are NOT advised to run it on startup. It is currently not advised to run the tool on startup because NetworkManager may ifup the reference bond, making the tool unable to determine all options. Line 240: run_tasks \ Line 241: mkdirs \ Line 242: configure_coredump \ Line 243: configure_vdsm_logs \ -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 13: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33403/13/lib/vdsm/tool/dump_bonding_defaults.py File lib/vdsm/tool/dump_bonding_defaults.py: Line 1: #! /usr/bin/env python Yaniv is right - the #! line is not needed. Line 2: # Copyright 2014 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Move private functions to end of module
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemuimg: Move private functions to end of module .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5865/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4025/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/35/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/31/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/37/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/11/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I060d3bb817ee543dabaf401756a909984cca9f8e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix typo in filename - ibm_powerkvm-release
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix typo in filename - ibm_powerkvm-release .. Fix typo in filename - ibm_powerkvm-release Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131965 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33451 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Tested-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/caps.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix typo in filename - ibm_powerkvm-release
Dan Kenigsberg has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Temporary fix for supervdsm memory leak.
Antoni Segura Puimedon has posted comments on this change. Change subject: gluster: Temporary fix for supervdsm memory leak. .. Patch Set 6: Code-Review+1 The imports look good now -- To view, visit http://gerrit.ovirt.org/33312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7079426178ce47008d9a3b83635afce98536ca34 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm: making PM 'on' and 'off' sync
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: making PM 'on' and 'off' sync .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/20/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/16/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/15/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/20/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eli Mesika emes...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix typo in filename - ibm_powerkvm-release
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5866/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4026/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/36/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/32/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/38/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/12/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Temporary fix for supervdsm memory leak.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Temporary fix for supervdsm memory leak. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7079426178ce47008d9a3b83635afce98536ca34 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Temporary fix for supervdsm memory leak.
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Temporary fix for supervdsm memory leak. .. gluster: Temporary fix for supervdsm memory leak. Supervdsm memory leak is caused by memory leak in libgfapi (BZ:1093594) which is used by verb glusterVolumeStatsInfoGet to retrive the volume statistics. The libgfapi method glfs_fini() is not cleaning up the memory, so everytime the verb is invoked memory gets added up(~20-30MiB). This verb is invoked by engine every 5 minutes for volume capacity feature. So supervdsm memory usage shoots up when gluster is enabled. This patch provides a temporary fix until libgfapi issue is resolved. In this patch libgfapi method calls are executed as script using execCmd(), by this libgfapi invocation is not part of supervdsm process. Change-Id: I7079426178ce47008d9a3b83635afce98536ca34 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142647 Signed-off-by: ndarshan dnara...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33312 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/gluster/gfapi.py 1 file changed, 78 insertions(+), 3 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Darshan N: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7079426178ce47008d9a3b83635afce98536ca34 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 13: (3 comments) http://gerrit.ovirt.org/#/c/33403/13/debian/vdsm.install File debian/vdsm.install: Line 155: ./usr/share/vdsm/virt/vmstatus.py Line 156: ./usr/share/vdsm/virt/vmxml.py Line 157: ./usr/share/vdsm/virt/utils.py Line 158: ./var/lib/polkit-1/localauthority/10-vendor.d/10-vdsm-libvirt-access.pkla Line 159: ./var/lib/vdsm/bonding-defaults.json put that in line 26. later on we'll move 158 also near the /var/lib files Done http://gerrit.ovirt.org/#/c/33403/13/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 235: --pre-start) Line 236: # If dump_bonding_defaults is desired (for the uneliminable possibility Line 237: # of added bonding options or tweaked kernel defaults) it has to be run Line 238: # after load_needed_modules (modprobe bonding). Line 239: # NetworkManager must not crash on nmcli conn delete. Actually, the commit message says that we are NOT advised to run it on star This is just a note on the required ordering if we ever run dump_bonding_defaults on startup. Line 240: run_tasks \ Line 241: mkdirs \ Line 242: configure_coredump \ Line 243: configure_vdsm_logs \ http://gerrit.ovirt.org/#/c/33403/13/lib/vdsm/tool/dump_bonding_defaults.py File lib/vdsm/tool/dump_bonding_defaults.py: Line 1: #! /usr/bin/env python Yaniv is right - the #! line is not needed. dummybr had it, plus the invocation of the main() function. As I documented in the commit message, 'vdsm-tool dump-bonding-defaults' is the preferred way of running the tool so I will get rid of the if __name__ == '__main__' too. Line 2: # Copyright 2014 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 14: Verified+1 Moved a line in debian/, removed the hasbang and __name__ == '__main__', removed a trailing newline from the JSON file. -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: fill AUTHOR at vdsm-tool manual page.
Dan Kenigsberg has posted comments on this change. Change subject: tool: fill AUTHOR at vdsm-tool manual page. .. Patch Set 2: Can we simply drop the AUTHORS line? according to man-pages(7): AUTHORS lists authors of the documentation or program. Use of an AUTHORS section is strongly discouraged. Generally, it is better not to clutter every page with a list of (over time potentially numer‐ ous) authors; if you write or significantly amend a page, add a copyright notice as a comment in the source file. If you are the author of a device driver and want to include an address for reporting bugs, place this under the BUGS section. -- To view, visit http://gerrit.ovirt.org/33455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a0fadec63c6643ae8d3678b611bbf15710142a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Andrew Dahms andrewjda...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Temporary fix for supervdsm memory leak.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Temporary fix for supervdsm memory leak. .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/234/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5867/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4027/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/37/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/33/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/39/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/13/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7079426178ce47008d9a3b83635afce98536ca34 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/399/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12642/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2003/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12487/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Yaniv Bronhaim has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Fix typo in filename - ibm_powerkvm-release .. Fix typo in filename - ibm_powerkvm-release Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131965 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33452 --- M vdsm/caps.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/33452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Fix typo in filename - ibm_powerkvm-release
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/21/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/17/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/16/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/21/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf
Vitor de Lima has uploaded a new change for review.
Change subject: vm: Fix error with missing cdrom in conf
..
vm: Fix error with missing cdrom in conf
Avoids referencing the cdrom parameter in conf in case it is missing.
Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728
Signed-off-by: Vitor de Lima vdel...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/33472/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0f9e4ce..120681d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4709,7 +4709,9 @@
return {'status': {'code': errCode['changeDisk']['status']['code'],
'message': errCode['changeDisk']['status']
['message']}}
-self.cif.teardownVolumePath(self.conf.get(vmDev))
+if vmDev in self.conf:
+self.cif.teardownVolumePath(self.conf.get(vmDev))
+
self.conf[vmDev] = path
return {'status': doneCode, 'vmList': self.status()}
--
To view, visit http://gerrit.ovirt.org/33472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vitor de Lima vdel...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fix typo in filename - ibm_powerkvm-release
..
Fix typo in filename - ibm_powerkvm-release
Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131965
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/33452
---
M vdsm/caps.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/33473/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 4be83a8..88c645b 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -288,7 +288,7 @@
return OSName.RHEL
elif os.path.exists('/etc/debian_version'):
return OSName.DEBIAN
-elif os.path.exists('/etc/ibm-powerkvm-release'):
+elif os.path.exists('/etc/ibm_powerkvm-release'):
return OSName.POWERKVM
else:
return OSName.UNKNOWN
--
To view, visit http://gerrit.ovirt.org/33473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fix typo in filename - ibm_powerkvm-release
Dan Kenigsberg has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fix typo in filename - ibm_powerkvm-release
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Fix typo in filename - ibm_powerkvm-release .. Fix typo in filename - ibm_powerkvm-release Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1147502 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33452 Reviewed-on: http://gerrit.ovirt.org/33473 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/caps.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Fix typo in filename - ibm_powerkvm-release
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix typo in filename - ibm_powerkvm-release .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el6-x86_64_merged/9/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el7-x86_64_merged/11/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc19-x86_64_merged/11/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc20-x86_64_merged/9/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6c3fde0f9216982b85185ab9d12380528187b1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf
Dan Kenigsberg has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33472/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-09-29 09:04:08 -0300 Line 6: Line 7: vm: Fix error with missing cdrom in conf Line 8: Line 9: Avoids referencing the cdrom parameter in conf in case it is missing. Could you explain the issue, and why did it suddenly pop up? Any reason why it is not posted to master branch, first? If so, please explain when. Line 10: Line 11: Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728 -- To view, visit http://gerrit.ovirt.org/33472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vitor de Lima vdel...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. netinfo, tool: Add a vdsm-tool to determine bonding defaults offline dump-bonding-defaults reads bonding option defaults (per mode) and saves them to /var/lib/vdsm/bonding-defaults.json. VDSM loads the file once at runtime and refers to this static information of defaults when reporting bonding options of bonds in the system. As the bonding defaults are bound to the used kernel it is the responsibility of the packager (or the sysadmin in customized setups) to regenerate the file by running (during the build, or installation, respectively): vdsm-tool dump-bonding-defaults It is currently not advised to run the tool on startup because NetworkManager may ifup the reference bond, making the tool unable to determine all options. Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142701 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33403 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm-python.install M debian/vdsm.install M init/vdsmd_init_common.sh.in M lib/vdsm/netinfo.py M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/dump_bonding_defaults.py M tests/netinfoTests.py M vdsm.spec.in M vdsm/Makefile.am A vdsm/bonding-defaults.json M vdsm/sudoers.vdsm.in 11 files changed, 543 insertions(+), 52 deletions(-) Approvals: Ondřej Svoboda: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11699/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12643/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12488/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Francesco Romani has uploaded a new change for review. Change subject: virt: sampling: more cautious disk stats check .. virt: sampling: more cautious disk stats check In commit d6d0eb763e623 we changed the disk stats collection to deal with the benign case of known-missing disk stats samples, to avoid add bogus error on the logs. Unfortunately a case was missing in the live storage migration flow, which causes TypeError: argument of type 'NoneType' is not iterable in the logs defeating the purposes of the originating change. This patch fixes this issue by adding the missing check. Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Signed-off-by: Francesco Romani from...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/33482/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index ad8cb0e..0f8845e 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -539,7 +539,7 @@ dStats['imageID'] = vmDrive.imageID elif GUID in vmDrive: dStats['lunGUID'] = vmDrive.GUID -if sInfo is not None and ( +if sInfo is not None and eInfo is not None and ( vmDrive.name in sInfo and vmDrive.name in eInfo): # will be None if sampled during recovery dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo, @@ -594,7 +594,8 @@ 'writeLatency': '0', 'flushLatency': '0'} -if sInfo is not None and (dName in sInfo and dName in eInfo): +if sInfo is not None and eInfo is not None and ( +dName in sInfo and dName in eInfo): # will be None if sampled during recovery # in case of hotplugged disk, start samples will # be missed until the sampling code catches up. -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...
Amador Pahim has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 15: (5 comments) http://gerrit.ovirt.org/#/c/31529/15/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1134: flags |= os.O_NONBLOCK Line 1135: fcntl.fcntl(fd, fcntl.F_SETFL, flags) Line 1136: Line 1137: Line 1138: def setRpFilter(dev, mode): Please use new-style function names for new functions in this module. Done Line 1139: try: Line 1140: path = '/proc/sys/net/ipv4/conf/%s/rp_filter' % dev Line 1141: with open(path, 'w') as rp_filter: Line 1142: rp_filter.write(mode) Line 1139: try: Line 1140: path = '/proc/sys/net/ipv4/conf/%s/rp_filter' % dev Line 1141: with open(path, 'w') as rp_filter: Line 1142: rp_filter.write(mode) Line 1143: except OSError as e: why do we need this error handling? Why do we want to ignore ENOENT? This f Done Line 1144: if e.errno == errno.ENOENT: Line 1145: logging.warning(Device %s does not exist, dev) Line 1146: else: Line 1147: logging.error(Error setting rp_filter mode [%s] for device [%s], http://gerrit.ovirt.org/#/c/31529/15/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 545: Line 546: return 0 Line 547: Line 548: Line 549: def _unsetRpFilter(sessionID): The name of this function is misleading since Done Line 550: sessionInfo = getSessionInfo(sessionID) Line 551: Line 552: if sessionInfo.iface.netIfacename: Line 553: for session in iterateIscsiSessions(): Line 559:session.id)) Line 560: return Line 561: Line 562: supervdsm.getProxy().setRpFilter(sessionInfo.iface.netIfacename, Line 563: _SYSCTL_RPFILTER_STRICT) I suggest to save the origin rp_filter value before it is changed by setRpF The problem with this approach is the fact we may have several sessions using the same netIfacename. So, to do what you're suggesting, we need to save the value for rp_filter before the first session touch it and keep this value until no session is using the netIfacename anymore. I'd prefer to keep the current approach, since users can set the value they want in net.ipv4.conf.all.rp_filter (kernel will use the MAX between all and eth*) http://gerrit.ovirt.org/#/c/31529/15/vdsm/vdsm-sysctl.conf File vdsm/vdsm-sysctl.conf: Line 8: # accomodate this case: Line 9: # For the ARP flux problem, where the machine may respond to ARP requests Line 10: # from all Ethernet interfaces, we are setting arp_ignore=1 and Line 11: # arp_announce=2 Line 12: net.ipv4.conf.default.arp_ignore = 1 Dan, some patch sets ago we changed this from *all* to *default*. Reading now about the difference between it, I've found *default* gets copied to newly created interfaces only once, while *all* allways gets applied in addition to the current specific device setting (for arp_ignore and arp_announce, kernel will pick MAX up). Using *default*: - Newly created devices will copy the value from *default*. - Changes in *all* will only have effect if the number is greater than the used by device. - Existent devices will not copy the value from *default*. So, to assure this will work, we should use *all* or control it the same way we are going to do with rp_filter. Could you comment? -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: jian wang wjia...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Fix error with missing cdrom in conf
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33472/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4709: return {'status': {'code':
errCode['changeDisk']['status']['code'],
Line 4710:'message':
errCode['changeDisk']['status']
Line 4711: ['message']}}
Line 4712: if vmDev in self.conf:
Line 4713: self.cif.teardownVolumePath(self.conf.get(vmDev))
Since we now know that vmDev is in conf, we'd better use
self.conf[vmDev]
Line 4714:
Line 4715: self.conf[vmDev] = path
Line 4716: return {'status': doneCode, 'vmList': self.status()}
Line 4717:
--
To view, visit http://gerrit.ovirt.org/33472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vitor de Lima vdel...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11700/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12644/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1695/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12489/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5868/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4028/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/38/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/34/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/40/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/14/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b907ba80f23f417d5e481db9350247445ab772 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Report properly response None type
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Report properly response None type .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12645/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12490/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
mooli tayer has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 2: tested on fe20 and rhel6.5 -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33411/1//COMMIT_MSG Commit Message: Line 21: Line 22: In order to solve this issue, the best course of action is to Line 23: persist RunningConfig as PersistentConfig as soon as the management Line 24: network has been created by vdsm-reg (and strictly before the Line 25: registration request is sent to the engine). Since vdsm-reg edits vdsm.conf, your worries are well-placed. But with your /usr/share/vdsm/get-conf-item Line 26: Line 27: Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Line 28: Bug-Url: https://bugzilla.redhat.com/1144639 -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool-tests: use variable from conf version in template files.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool-tests: use variable from conf version in template files. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12646/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12491/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f322cc647f81358febbcb89b8ec67fd2a2b2270 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Report properly response None type
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Report properly response None type .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33484/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 282: ret = dict([(key, value) for key, value in result.items() Line 283: if key is not 'status']) Line 284: else: Line 285: ret = self._getResult(result, retfield) Line 286: if ret is None: does all other value of ret are valid? why single-out the None value? Logging the value of ret in case of _fixupRet() error is a good idea, but I am not sure what is the benefit of this specific new exception. Line 287: raise yajsonrpc.JsonRpcInvalidResponseType() Line 288: return self._fixupRet(className, methodName, ret) Line 289: Line 290: -- To view, visit http://gerrit.ovirt.org/33484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic95a94da36ca3a6dc005c8cf0cd705b4cf87b81a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12647/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12492/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
netinfo, tool: Add a vdsm-tool to determine bonding defaults offline
dump-bonding-defaults reads bonding option defaults (per mode) and saves them
to /var/lib/vdsm/bonding-defaults.json. VDSM loads the file once at runtime
and refers to this static information of defaults when reporting bonding
options of bonds in the system.
As the bonding defaults are bound to the used kernel it is the responsibility
of the packager (or the sysadmin in customized setups) to regenerate the file
by running (during the build, or installation, respectively):
vdsm-tool dump-bonding-defaults
It is currently not advised to run the tool on startup because NetworkManager
may ifup the reference bond, making the tool unable to determine all options.
Change-Id: I92bcf62a4ae1756b0d2857cc0c7387c128f9b8a0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142701
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M debian/vdsm-python.install
M debian/vdsm.install
M init/vdsmd_init_common.sh.in
M lib/vdsm/netinfo.py
M lib/vdsm/tool/Makefile.am
A lib/vdsm/tool/dump_bonding_defaults.py
M tests/netinfoTests.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/bonding-defaults.json
M vdsm/sudoers.vdsm.in
11 files changed, 545 insertions(+), 48 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/33489/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 0294be8..42f08c2 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -17,6 +17,7 @@
./usr/lib/python2.7/dist-packages/vdsm/sslutils.py
./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py
./usr/lib/python2.7/dist-packages/vdsm/tool/dummybr.py
+./usr/lib/python2.7/dist-packages/vdsm/tool/dump_bonding_defaults.py
./usr/lib/python2.7/dist-packages/vdsm/tool/configurator.py
./usr/lib/python2.7/dist-packages/vdsm/tool/load_needed_modules.py
./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index c97b8dd..4a0b976 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -23,6 +23,7 @@
./lib/udev/rules.d/61-vdsm-lvm.rules
./usr/lib/python2.7/dist-packages/sos/plugins/vdsm.py
./usr/lib/python2.7/dist-packages/vdsmapi.py
+./var/lib/vdsm/bonding-defaults.json
./usr/libexec/vdsm/curl-img-wrap
./usr/libexec/vdsm/ovirt_functions.sh
./usr/libexec/vdsm/persist-vdsm-hooks
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 298b658..49e9f19 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -100,6 +100,11 @@
}
+task_dump_bonding_defaults(){
+${VDSM_TOOL} dump-bonding-defaults
+}
+
+
task_tune_system(){
@SYSCTL_PATH@ -q -p /etc/sysctl.d/vdsm.conf
}
@@ -228,6 +233,10 @@
case $1 in
--pre-start)
+# If dump_bonding_defaults is desired (for the uneliminable possibility
+# of added bonding options or tweaked kernel defaults) it has to be run
+# after load_needed_modules (modprobe bonding).
+# NetworkManager must not crash on nmcli conn delete.
run_tasks \
mkdirs \
configure_coredump \
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 5dc2cd6..f98dcea 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -24,12 +24,11 @@
from datetime import datetime
from functools import partial
from itertools import chain
+import json
import logging
import os
-import random
import shlex
import socket
-import string
import struct
from xml.dom import minidom
@@ -47,7 +46,7 @@
from . import libvirtconnection
from .netconfpersistence import RunningConfig
from .netlink import iter_addrs, iter_links
-from .utils import execCmd, memoized, CommandPath
+from .utils import memoized
NET_CONF_DIR = '/etc/sysconfig/network-scripts/'
@@ -69,6 +68,7 @@
BONDING_MASTERS = '/sys/class/net/bonding_masters'
BONDING_SLAVES = '/sys/class/net/%s/bonding/slaves'
BONDING_OPT = '/sys/class/net/%s/bonding/%s'
+BONDING_DEFAULTS = constants.P_VDSM_LIB + 'bonding-defaults.json'
BRIDGING_OPT = '/sys/class/net/%s/bridge/%s'
_BONDING_FAILOVER_MODES = frozenset(('1', '3'))
_BONDING_LOADBALANCE_MODES = frozenset(('0', '2', '4', '5', '6'))
@@ -78,7 +78,6 @@
))
_IFCFG_ZERO_SUFFIXED = frozenset(
('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
-_TEE_BINARY = CommandPath('tee', constants.EXT_TEE)
LIBVIRT_NET_PREFIX = 'vdsm-'
DEFAULT_MTU = '1500'
@@ -187,7 +186,7 @@
return opts
-def _realBondOpts(bond):
+def realBondOpts(bond):
Return a dictionary in the same format as bondOpts(). Exclude entries that
are not bonding options, e.g. 'ad_num_ports' or 'slaves'.
@@ -522,47 +521,14 @@
return paddr
-def _randomIfaceName():
-MAX_LENGTH = 15
-CHARS = string.ascii_lowercase +
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 3: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_reg: Make vdsm-reg persist the management bridge it cre...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_reg: Make vdsm-reg persist the management bridge it creates .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12494/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d35da853df485a9196ad0657f832b77ae65d24e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/400/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/417/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12648/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2004/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12493/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92bcf62a4ae1756b0d2857cc0c7387c128f9b8a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor has_channel using etree
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: refactor has_channel using etree .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11707/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12651/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1697/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12496/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor has_channel using etree
Martin Polednik has posted comments on this change. Change subject: vdsm: refactor has_channel using etree .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/32402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
