Change in vdsm[master]: clean dhclient processes that are left after functional tests
Nir Soffer has posted comments on this change. Change subject: clean dhclient processes that are left after functional tests .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I458aa38415c697d3863e173444ff921d759166a2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clean dhclient processes that are left after functional tests
Ido Barkan has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/34366/7/tests/functional/dhcp.py
File tests/functional/dhcp.py:
Line 132:
Line 133: def _is_running(self):
Line 134: try:
Line 135: return os.readlink('/proc/{0}/exe'.format(self.pid)) == \
Line 136: _DHCLIENT_BINARY.cmd
> This is hard to read, doing too much in the same line, and includes code th
Done
Line 137: except OSError as err:
Line 138: if err.errno != ENOENT:
Line 139: raise
Line 140: return False # no such pid
--
To view, visit http://gerrit.ovirt.org/34366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458aa38415c697d3863e173444ff921d759166a2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...
Ondřej Svoboda has posted comments on this change. Change subject: hooks: Add a hook to configure IPv6 networking through custom properties .. Patch Set 2: (2 comments) Comments have been addressed in patchset 4. http://gerrit.ovirt.org/#/c/34571/2/vdsm_hooks/ipv6/README File vdsm_hooks/ipv6/README: Line 5: Requirements: Line 6: * oVirt-3.5 (?started supporting custom properties?) Line 7: Line 8: Usage: Line 9: In the oVirt UI edit custom network properties and, for the keys 'ipv6addr' > Please explain how to make this work in Engine. Give explicit names for cus I chose to use setupNetworks' names for now to make the hook not surprising. Line 10: and 'ipv6gateway' Line 11: set the command line parameters that one would pass to the *** command http://gerrit.ovirt.org/#/c/34571/2/vdsm_hooks/ipv6/ipv6.py File vdsm_hooks/ipv6/ipv6.py: Line 28: for network, attrs in setup_nets_config['request']['networks'].items(): Line 29: if 'remove' in attrs: Line 30: continue Line 31: elif 'custom' in attrs: Line 32: _process_network(network, attrs) > you should finish with Totally forgot that when coding "in theory" :-) Line 33: Line 34: Line 35: def _process_network(network, attrs): Line 36: """Add an IPv6 address and a gateway to the network.""" -- To view, visit http://gerrit.ovirt.org/34571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e427b182a1742999eeb14e004209b511668ba2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 2: This version is rebased and supports hashing of multiple values. -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add changehash function for change detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13268/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13108/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12318/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1869/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guestagent: Simpler and safer disk mapping hash
oVirt Jenkins CI Server has posted comments on this change. Change subject: guestagent: Simpler and safer disk mapping hash .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13267/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13107/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12317/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1868/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia914cf9860cef019b3040a3f034e479e6a93ed97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guestagent: Use new style class
oVirt Jenkins CI Server has posted comments on this change. Change subject: guestagent: Use new style class .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13266/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13106/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12316/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1867/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138ded6cb33d7927b2701606698aaf95ebf39742 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: More careful falsy check
oVirt Jenkins CI Server has posted comments on this change. Change subject: domain_descriptor: More careful falsy check .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13265/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13105/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12315/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1866/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id805237342b3e00334e0e540ce8f4e919cf0107e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value
oVirt Jenkins CI Server has posted comments on this change. Change subject: domain_descriptor: Eliminate magic hash init value .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13104/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12314/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1865/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36767eafbef3dbebef5a1d04417f18e0cc4898c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: Use stable devices hash
Nir Soffer has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 1: The tests pass now, but I want to do minimal system tests. -- To view, visit http://gerrit.ovirt.org/34621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6190722653267ab45baec2302819c8995c468b1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Mark netowrk test as broken
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Mark netowrk test as broken .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12311/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffe0eb95d762cc30c13d0d060950bd06f526c6aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Start DomainDescriptor tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Start DomainDescriptor tests .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12313/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3502d0db927abbc8a8fdd90f74db07eeb517e457 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: Use stable devices hash
oVirt Jenkins CI Server has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13263/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13102/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12312/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1864/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6190722653267ab45baec2302819c8995c468b1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Start DomainDescriptor tests
Nir Soffer has posted comments on this change. Change subject: tests: Start DomainDescriptor tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3502d0db927abbc8a8fdd90f74db07eeb517e457 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Mark netowrk test as broken
Nir Soffer has posted comments on this change. Change subject: tests: Mark netowrk test as broken .. Patch Set 1: Code-Review-1 Don't merge before network folks look at it. This is just to prevent unrelated failures on my patches. -- To view, visit http://gerrit.ovirt.org/34619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffe0eb95d762cc30c13d0d060950bd06f526c6aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: More careful falsy check
Nir Soffer has uploaded a new change for review.
Change subject: domain_descriptor: More careful falsy check
..
domain_descriptor: More careful falsy check
Using "if self._devices" works with xml.minidom, but if we switch our xml
library to xml.etree, empty element is considered falsy, which will
create same hash for different xml.
While this may be a non-issue, using "if self._devices is not None" is
more correct and predictable.
Change-Id: Id805237342b3e00334e0e540ce8f4e919cf0107e
Signed-off-by: Nir Soffer
---
M vdsm/virt/domain_descriptor.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/34623/1
diff --git a/vdsm/virt/domain_descriptor.py b/vdsm/virt/domain_descriptor.py
index 3e567ab..dbd6dca 100644
--- a/vdsm/virt/domain_descriptor.py
+++ b/vdsm/virt/domain_descriptor.py
@@ -27,7 +27,7 @@
self._dom = xml.dom.minidom.parseString(xmlStr)
self._devices = self._firstElementByTagName('devices')
self._devicesHash = hash(self._devices.toxml()
- if self._devices else '')
+ if self._devices is not None else '')
@classmethod
def fromId(cls, uuid):
--
To view, visit http://gerrit.ovirt.org/34623
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id805237342b3e00334e0e540ce8f4e919cf0107e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value
Nir Soffer has uploaded a new change for review.
Change subject: domain_descriptor: Eliminate magic hash init value
..
domain_descriptor: Eliminate magic hash init value
We used to initialize devices hash to 0 when there are no devices. There
is no need for using this magic value. Hashing an empty string does not
require additional comments and is more general.
The magic "0" hash value was exposed in the past in the stats xml, and
could be used for detecting a fresh domain without any devices, but this
value is not exposed any more since we introduced the guest agent disk
mapping hash.
Change-Id: I36767eafbef3dbebef5a1d04417f18e0cc4898c2
Signed-off-by: Nir Soffer
---
M vdsm/virt/domain_descriptor.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/34622/1
diff --git a/vdsm/virt/domain_descriptor.py b/vdsm/virt/domain_descriptor.py
index baca905..3e567ab 100644
--- a/vdsm/virt/domain_descriptor.py
+++ b/vdsm/virt/domain_descriptor.py
@@ -26,9 +26,8 @@
self._xml = xmlStr
self._dom = xml.dom.minidom.parseString(xmlStr)
self._devices = self._firstElementByTagName('devices')
-# VDSM by default reports '0' as hash when it has no device list yet
-self._devicesHash = (hash(self._devices.toxml()) if self._devices
- else 0)
+self._devicesHash = hash(self._devices.toxml()
+ if self._devices else '')
@classmethod
def fromId(cls, uuid):
--
To view, visit http://gerrit.ovirt.org/34622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36767eafbef3dbebef5a1d04417f18e0cc4898c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guestagent: Use new style class
Nir Soffer has uploaded a new change for review. Change subject: guestagent: Use new style class .. guestagent: Use new style class Using old style class is a trap for innocent developers. They do not support properties in a nasty way, and should be forbidden in vdsm code. Change-Id: I138ded6cb33d7927b2701606698aaf95ebf39742 Signed-off-by: Nir Soffer --- M vdsm/virt/guestagent.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/34624/1 diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py index 0be7e6b..a403b0d 100644 --- a/vdsm/virt/guestagent.py +++ b/vdsm/virt/guestagent.py @@ -109,7 +109,7 @@ Exception.__init__(self, message) -class GuestAgent (): +class GuestAgent(object): MAX_MESSAGE_SIZE = 2 ** 20 # 1 MiB for now def __init__(self, socketName, channelListener, log, user='Unknown', -- To view, visit http://gerrit.ovirt.org/34624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I138ded6cb33d7927b2701606698aaf95ebf39742 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Mark netowrk test as broken
Nir Soffer has uploaded a new change for review.
Change subject: tests: Mark netowrk test as broken
..
tests: Mark netowrk test as broken
The add network test fails consistently on Fedora 20. This may be bad
tests or real failure, I don't have any idea. Marking the test as broken
until the network team will handle it, since it breaks the build.
Change-Id: Iffe0eb95d762cc30c13d0d060950bd06f526c6aa
Signed-off-by: Nir Soffer
---
M tests/configNetworkTests.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/34619/1
diff --git a/tests/configNetworkTests.py b/tests/configNetworkTests.py
index 83a4b73..2fd3f1b 100644
--- a/tests/configNetworkTests.py
+++ b/tests/configNetworkTests.py
@@ -23,6 +23,7 @@
from vdsm import netinfo
from testlib import VdsmTestCase as TestCaseBase
+from testValidation import brokentest
from monkeypatch import MonkeyPatch
from network import api, configurators
@@ -47,6 +48,7 @@
api.addNetwork(netName, **opts)
self.assertEqual(cneContext.exception.errCode, errCode)
+@brokentest("breaks on Fedora 20")
# Monkey patch the real network detection from the netinfo module.
@MonkeyPatch(netinfo, 'networks', _fakeNetworks)
@MonkeyPatch(netinfo, 'getMaxMtu', lambda *x: 1500)
--
To view, visit http://gerrit.ovirt.org/34619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffe0eb95d762cc30c13d0d060950bd06f526c6aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guestagent: Simpler and safer disk mapping hash
Nir Soffer has uploaded a new change for review.
Change subject: guestagent: Simpler and safer disk mapping hash
..
guestagent: Simpler and safer disk mapping hash
Previously diskMapingHash was initialized to the magic value 0, or to
hash of a sorted json dump of the diskMapping dict. Now diskMappingHash
is always a real hash, and is read only.
The hash is computed automatically when the value of guestDiskMapping is
changed, and there is no way to forget to update the hash.
Change-Id: Ia914cf9860cef019b3040a3f034e479e6a93ed97
Signed-off-by: Nir Soffer
---
M tests/guestagentTests.py
M vdsm/virt/guestagent.py
2 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/34625/1
diff --git a/tests/guestagentTests.py b/tests/guestagentTests.py
index f4f1a35..d9684ae 100644
--- a/tests/guestagentTests.py
+++ b/tests/guestagentTests.py
@@ -193,3 +193,18 @@
# If the message size was within the allowed range
# the message should have been put into the guestInfo dict
self.assertEqual(self.fakeGuestAgent.guestInfo[k], v)
+
+
+class DiskMappingTests(TestCaseBase):
+
+def setUp(self):
+self.agent = guestagent.GuestAgent(None, None, None)
+
+def test_init(self):
+self.assertEqual(self.agent.guestDiskMapping, {})
+self.assertTrue(isinstance(self.agent.diskMappingHash, int))
+
+def test_change_disk_mapping(self):
+old_hash = self.agent.diskMappingHash
+self.agent.guestDiskMapping = {'/dev/vda': 'xxx'}
+self.assertNotEqual(self.agent.diskMappingHash, old_hash)
diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py
index a403b0d..dbada69 100644
--- a/vdsm/virt/guestagent.py
+++ b/vdsm/virt/guestagent.py
@@ -121,7 +121,6 @@
self._stopped = True
self.guestStatus = None
self.guestDiskMapping = {}
-self.diskMappingHash = 0
self.guestInfo = {
'username': user,
'memUsage': 0,
@@ -136,6 +135,19 @@
self._agentTimestamp = 0
self._channelListener = channelListener
self._messageState = MessageState.NORMAL
+
+@property
+def guestDiskMapping(self):
+return self._guestDiskMapping
+
+@guestDiskMapping.setter
+def guestDiskMapping(self, value):
+self._guestDiskMapping = value
+self._diskMappingHash = hash(json.dumps(value, sort_keys=True))
+
+@property
+def diskMappingHash(self):
+return self._diskMappingHash
def connect(self):
self._prepare_socket()
@@ -303,8 +315,6 @@
disks.append(disk)
self.guestInfo['disksUsage'] = disks
self.guestDiskMapping = args.get('mapping', {})
-self.diskMappingHash = hash(json.dumps(self.guestDiskMapping,
- sort_keys=True))
elif message == 'number-of-cpus':
self.guestInfo['guestCPUCount'] = int(args['count'])
else:
--
To view, visit http://gerrit.ovirt.org/34625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia914cf9860cef019b3040a3f034e479e6a93ed97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domain_descriptor: Use stable devices hash
Nir Soffer has uploaded a new change for review.
Change subject: domain_descriptor: Use stable devices hash
..
domain_descriptor: Use stable devices hash
Commit af09a3ff50 changed the way we compute the devices hash. Before
this commit, we used:
hash(devxml.toxml())
And now we use:
hash(devxml)
Hashing minidom xml element returns a different hash for objects with
same xml content. It is possible that another libary will compute a
correct hash from parsed xml, but we should not depend on this.
Change-Id: I6190722653267ab45baec2302819c8995c468b1f
Signed-off-by: Nir Soffer
---
M tests/domainDescriptorTests.py
M vdsm/virt/domain_descriptor.py
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/34621/1
diff --git a/tests/domainDescriptorTests.py b/tests/domainDescriptorTests.py
index b426e1e..f04a02b 100644
--- a/tests/domainDescriptorTests.py
+++ b/tests/domainDescriptorTests.py
@@ -21,7 +21,6 @@
from virt.domain_descriptor import DomainDescriptor
from testlib import VdsmTestCase
-from testValidation import brokentest
NO_DEVICES = """
@@ -74,7 +73,6 @@
desc2 = DomainDescriptor(REORDERED_DEVICES)
self.assertNotEqual(desc1.devicesHash, desc2.devicesHash)
-@brokentest("hashing is not stable")
def test_stable_hash(self):
desc1 = DomainDescriptor(SOME_DEVICES)
desc2 = DomainDescriptor(SOME_DEVICES)
diff --git a/vdsm/virt/domain_descriptor.py b/vdsm/virt/domain_descriptor.py
index 3100a25..baca905 100644
--- a/vdsm/virt/domain_descriptor.py
+++ b/vdsm/virt/domain_descriptor.py
@@ -27,7 +27,8 @@
self._dom = xml.dom.minidom.parseString(xmlStr)
self._devices = self._firstElementByTagName('devices')
# VDSM by default reports '0' as hash when it has no device list yet
-self._devicesHash = hash(self._devices) if self._devices else 0
+self._devicesHash = (hash(self._devices.toxml()) if self._devices
+ else 0)
@classmethod
def fromId(cls, uuid):
--
To view, visit http://gerrit.ovirt.org/34621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6190722653267ab45baec2302819c8995c468b1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Start DomainDescriptor tests
Nir Soffer has uploaded a new change for review.
Change subject: tests: Start DomainDescriptor tests
..
tests: Start DomainDescriptor tests
Adding some tests before fixing hashing implementation.
Change-Id: I3502d0db927abbc8a8fdd90f74db07eeb517e457
Signed-off-by: Nir Soffer
---
M tests/Makefile.am
A tests/domainDescriptorTests.py
2 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/34620/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 78b538b..36a1cdd 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -31,6 +31,7 @@
clientifTests.py \
configNetworkTests.py \
domainMonitorTests.py \
+ domainDescriptorTests.py \
fileVolumeTests.py \
fileUtilTests.py \
fuserTests.py \
diff --git a/tests/domainDescriptorTests.py b/tests/domainDescriptorTests.py
new file mode 100644
index 000..b426e1e
--- /dev/null
+++ b/tests/domainDescriptorTests.py
@@ -0,0 +1,81 @@
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from virt.domain_descriptor import DomainDescriptor
+from testlib import VdsmTestCase
+from testValidation import brokentest
+
+NO_DEVICES = """
+
+xyz
+
+"""
+
+EMPTY_DEVICES = """
+
+xyz
+
+
+"""
+
+SOME_DEVICES = """
+
+xyz
+
+
+
+
+
+"""
+
+REORDERED_DEVICES = """
+
+xyz
+
+
+
+
+
+"""
+
+
+class DevicesHashTests(VdsmTestCase):
+
+def test_no_devices(self):
+desc1 = DomainDescriptor(NO_DEVICES)
+desc2 = DomainDescriptor(EMPTY_DEVICES)
+self.assertNotEqual(desc1.devicesHash, desc2.devicesHash)
+
+def test_different_devices(self):
+desc1 = DomainDescriptor(EMPTY_DEVICES)
+desc2 = DomainDescriptor(SOME_DEVICES)
+self.assertNotEqual(desc1.devicesHash, desc2.devicesHash)
+
+def test_different_order(self):
+desc1 = DomainDescriptor(SOME_DEVICES)
+desc2 = DomainDescriptor(REORDERED_DEVICES)
+self.assertNotEqual(desc1.devicesHash, desc2.devicesHash)
+
+@brokentest("hashing is not stable")
+def test_stable_hash(self):
+desc1 = DomainDescriptor(SOME_DEVICES)
+desc2 = DomainDescriptor(SOME_DEVICES)
+self.assertEqual(desc1.devicesHash, desc2.devicesHash)
--
To view, visit http://gerrit.ovirt.org/34620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3502d0db927abbc8a8fdd90f74db07eeb517e457
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information
Hello Antoni Segura Puimedon, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34617
to review the following change.
Change subject: caps: Additional ppc64 hardware information
..
caps: Additional ppc64 hardware information
Includes extra information (manufacturer and product name) about ppc64
hosts in the getVdsHardwareInfo command. This extra information is
obtained from the device tree and skipped in case it is missing.
Change-Id: I8f67a830740b64bc246f680f2c7a18a4293f4cc2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149262
Signed-off-by: Vitor de Lima
Reviewed-on: http://gerrit.ovirt.org/33857
Reviewed-by: Antoni Segura Puimedon
Reviewed-by: Dan Kenigsberg
---
M vdsm/ppc64HardwareInfo.py
1 file changed, 16 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/34617/1
diff --git a/vdsm/ppc64HardwareInfo.py b/vdsm/ppc64HardwareInfo.py
index 1a4b30e..029eaa4 100644
--- a/vdsm/ppc64HardwareInfo.py
+++ b/vdsm/ppc64HardwareInfo.py
@@ -21,14 +21,21 @@
import os
+def _getFromDeviceTree(treeProperty):
+path = '/proc/device-tree/%s' % treeProperty
+if os.path.exists(path):
+with open(path) as f:
+value = f.readline().rstrip('\0').replace(',', '')
+return value
+else:
+return 'unavailable'
+
+
@utils.memoized
def getHardwareInfoStructure():
-infoStructure = {'systemProductName': 'unavailable',
- 'systemSerialNumber': 'unavailable',
+infoStructure = {'systemSerialNumber': 'unavailable',
'systemFamily': 'unavailable',
- 'systemVersion': 'unavailable',
- 'systemUUID': 'unavailable',
- 'systemManufacturer': 'unavailable'}
+ 'systemVersion': 'unavailable'}
for line in file('/proc/cpuinfo'):
if line.strip() == '':
@@ -42,11 +49,11 @@
elif key == 'machine':
infoStructure['systemVersion'] = value
-if os.path.exists('/proc/device-tree/system-id'):
-with open('/proc/device-tree/system-id') as f:
-vdsmId = f.readline().rstrip('\0').replace(',', '')
+infoStructure['systemUUID'] = _getFromDeviceTree('system-id')
-infoStructure['systemUUID'] = vdsmId
+infoStructure['systemProductName'] = _getFromDeviceTree('model-name')
+
+infoStructure['systemManufacturer'] = _getFromDeviceTree('vendor')
return infoStructure
--
To view, visit http://gerrit.ovirt.org/34617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f67a830740b64bc246f680f2c7a18a4293f4cc2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vitor de Lima
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.config, vdscli: use function-like print statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.config, vdscli: use function-like print statements .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4149/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/141/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/157/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba31dd389815c192231c535f8a729d1781a27fff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop needless configurable
Dan Kenigsberg has abandoned this change. Change subject: virt: drop needless configurable .. Abandoned see Francesco's comment. -- To view, visit http://gerrit.ovirt.org/28808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6e66f18706761ada045799f0f6d488a2c9ef6553 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.config, vdscli: use function-like print statements
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.config, vdscli: use function-like print statements .. vdsm.config, vdscli: use function-like print statements Get ready for python3 support, some day. Change-Id: Iba31dd389815c192231c535f8a729d1781a27fff Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/34072 Reviewed-by: Antoni Segura Puimedon Reviewed-by: Piotr Kliczewski --- M lib/vdsm/config.py.in M lib/vdsm/vdscli.py 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba31dd389815c192231c535f8a729d1781a27fff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.config, vdscli: use function-like print statements
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.config, vdscli: use function-like print statements .. Patch Set 1: Verified+1 Code-Review+2 # python -m vdsm.config # python -m vdsm.vdscli work just fine. -- To view, visit http://gerrit.ovirt.org/34072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba31dd389815c192231c535f8a729d1781a27fff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Do not memoize CPU topology
Vitor de Lima has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 3: Verified+1 Used the vdsClient getVdsCaps command to check if the counts were correct, then disabled some logical CPUs and checked both the online CPU list and the total counts. An automated test was also used to test it. -- To view, visit http://gerrit.ovirt.org/34189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e87b50d4fe882240c93a0a1600e3a0cb98d443 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix typo in test name
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix typo in test name .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4148/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/140/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/163/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/356/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5988/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/161/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/156/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib06f87efd3771c91af1edb8a76ea5e16db47c720 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: log xml from/to libvirt at 'info' level
Nir Soffer has posted comments on this change. Change subject: vm: log xml from/to libvirt at 'info' level .. Patch Set 3: Code-Review+1 Thanks -- To view, visit http://gerrit.ovirt.org/34358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07823512a8cdf5f05789b29bf3d4daa1a8ccb07 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clean dhclient processes that are left after functional tests
Nir Soffer has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/34366/7/tests/functional/dhcp.py
File tests/functional/dhcp.py:
Line 132:
Line 133: def _is_running(self):
Line 134: try:
Line 135: return os.readlink('/proc/{0}/exe'.format(self.pid)) == \
Line 136: _DHCLIENT_BINARY.cmd
This is hard to read, doing too much in the same line, and includes code that
cannot raise OSError in the try block. We like to have minimal try blocks.
I think this is more clear:
executable_link = '/proc/{0}/exe'.format(self.pid)
try:
executable = os.readlink(executable_link)
except ...
handle errors...
return executable == _DHCLIENT_BINARY.cmd
Line 137: except OSError as err:
Line 138: if err.errno != ENOENT:
Line 139: raise
Line 140: return False # no such pid
--
To view, visit http://gerrit.ovirt.org/34366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458aa38415c697d3863e173444ff921d759166a2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix typo in test name
Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix typo in test name .. Patch Set 1: Code-Review+2 harmless, taken. -- To view, visit http://gerrit.ovirt.org/34574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib06f87efd3771c91af1edb8a76ea5e16db47c720 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix typo in test name
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Fix typo in test name .. tests: Fix typo in test name Change-Id: Ib06f87efd3771c91af1edb8a76ea5e16db47c720 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/34574 Reviewed-by: Dan Kenigsberg --- M tests/protocoldetectorTests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib06f87efd3771c91af1edb8a76ea5e16db47c720 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Add a hook to configure IPv6 networking through custom properties .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/34571/2/vdsm_hooks/ipv6/README File vdsm_hooks/ipv6/README: Line 5: Requirements: Line 6: * oVirt-3.5 (?started supporting custom properties?) Line 7: Line 8: Usage: Line 9: In the oVirt UI edit custom network properties and, for the keys 'ipv6addr' Please explain how to make this work in Engine. Give explicit names for custom properties. Compare to http://gerrit.ovirt.org/#/c/34114/8/vdsm_hooks/allocate_net/README Line 10: and 'ipv6gateway' Line 11: set the command line parameters that one would pass to the *** command http://gerrit.ovirt.org/#/c/34571/2/vdsm_hooks/ipv6/ipv6.py File vdsm_hooks/ipv6/ipv6.py: Line 28: for network, attrs in setup_nets_config['request']['networks'].items(): Line 29: if 'remove' in attrs: Line 30: continue Line 31: elif 'custom' in attrs: Line 32: _process_network(network, attrs) you should finish with hooking.write_json() Line 33: Line 34: Line 35: def _process_network(network, attrs): Line 36: """Add an IPv6 address and a gateway to the network.""" -- To view, visit http://gerrit.ovirt.org/34571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e427b182a1742999eeb14e004209b511668ba2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47
Dan Kenigsberg has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33771/5/vdsm.spec.in File vdsm.spec.in: Line 260 Line 261 Line 262 Line 263 Line 264 this removal does not seem related to this patch. Could you explain it (better in another patch)? -- To view, visit http://gerrit.ovirt.org/33771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/535/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13096/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12306/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: sync device update during creation of a vm
Francesco Romani has posted comments on this change. Change subject: vm: sync device update during creation of a vm .. Patch Set 2: Code-Review-1 Verified+1 This is definitely a great step in the right direction. I verified it doing 500 startups in four batches and now RuntimeError is gone. Most importantly, this matches our reasoning about Vm.conf being uncarefully extended. That said, I'm not 100% happy with this patch because it moves the path preparation on the sync call. We are already suffering from slow startup since long time (https://bugzilla.redhat.com/show_bug.cgi?id=861918) so I'd really like to try to improve things. I believe we can achieve both goals -safety and to not slowdown startup, but this will require Vm flow deentangling and more articulate patch(es). For these reasons, V+1 and -1. The -1 will go away if we are in great hurry and/or if I can't find something better. -- To view, visit http://gerrit.ovirt.org/34599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I477551500ccc2297eb0c05d6562710bc420363a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: remove redundant check.
mooli tayer has uploaded a new change for review.
Change subject: spec: remove redundant check.
..
spec: remove redundant check.
if not fedora 0%{?fedora} evaluates to 0.
Change-Id: I50e1706e7f8c9b07b6788fbbabf61b40306801c3
Signed-off-by: Mooli Tayer
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/34610/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 68c757a..d7394ad 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -256,7 +256,7 @@
Requires(post): /usr/sbin/saslpasswd2
-%if 0%{?fedora} && 0%{?fedora} >= 21
+%if 0%{?fedora} >= 21
Requires(post): hostname
%else
Requires(post): /bin/hostname
--
To view, visit http://gerrit.ovirt.org/34610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50e1706e7f8c9b07b6788fbbabf61b40306801c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Use a single instance of IOProcess per SD
Dima Kuznetsov has posted comments on this change. Change subject: oop: Use a single instance of IOProcess per SD .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: sync device update during creation of a vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: sync device update during creation of a vm .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13255/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13095/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12305/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1863/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I477551500ccc2297eb0c05d6562710bc420363a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: sync device update during creation of a vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: sync device update during creation of a vm .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13254/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12304/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1862/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I477551500ccc2297eb0c05d6562710bc420363a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/33771/4/vdsm.spec.in
File vdsm.spec.in:
Line 80: BuildRequires: libselinux-python
Line 81: BuildRequires: libvirt-python
Line 82: BuildRequires: m2crypto
Line 83: BuildRequires: openssl
Line 84: BuildRequires: policycoreutils-python
we added also buildRequires for that.. i think we should add the restriction
also here
Line 85: BuildRequires: psmisc
Line 86: BuildRequires: python-cpopen >= 1.3
Line 87: BuildRequires: python-inotify
Line 88: BuildRequires: python-ioprocess >= 0.12
Line 260: %else
Line 261: Requires(post): /bin/hostname
Line 262: %endif
Line 263:
Line 264: %if 0%{?rhel} && 0%{?rhel} < 7
isn't its enough to check rhel < 7?
Line 265: Requires(post): policycoreutils-python > 2.0.83-19.47
Line 266: Requires(preun): policycoreutils-python > 2.0.83-19.47
Line 267: %else
Line 268: Requires(post): policycoreutils-python
Line 266: Requires(preun): policycoreutils-python > 2.0.83-19.47
Line 267: %else
Line 268: Requires(post): policycoreutils-python
Line 269: Requires(preun): policycoreutils-python
Line 270: %endif
why don't the Requires in lines 196 and 186 enough here?
Line 271:
Line 272: %description
Line 273: The VDSM service is required by a Virtualization Manager to manage the
Line 274: Linux hosts. VDSM manages and monitors the host's storage, memory and
--
To view, visit http://gerrit.ovirt.org/33771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Ohad Basan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47
Dan Kenigsberg has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/33771/4/vdsm.spec.in
File vdsm.spec.in:
Line 192: Requires: fence-agents
Line 193: Requires: kernel >= 2.6.32-279.9.1
Line 194: Requires: initscripts >= 9.03.31-2.el6_3.1
Line 195: Requires: policycoreutils >= 2.0.83-19.30
Line 196: Requires: policycoreutils-python > 2.0.83-19.47
checked that
http://mirror.centos.org/centos-6/6.6/updates/x86_64/Packages/policycoreutils-2.0.83-19.47.el6_6.1.x86_64.rpm
exists.
Line 197: Requires: selinux-policy-targeted >= 3.7.19-195.el6_4.13
Line 198: Requires: lvm2 >= 2.02.100-5
Line 199: Requires: logrotate < 3.8.0
Line 200: %endif
Line 254: Requires: pyparted
Line 255:
Line 256: Requires(post): /usr/sbin/saslpasswd2
Line 257:
Line 258: %if 0%{?fedora} && 0%{?fedora} >= 21
yeah, not your fault, but the first 0%{?fedora} should be cleaned in a future
patch.
Line 259: Requires(post): hostname
Line 260: %else
Line 261: Requires(post): /bin/hostname
Line 262: %endif
Line 260: %else
Line 261: Requires(post): /bin/hostname
Line 262: %endif
Line 263:
Line 264: %if 0%{?rhel} && 0%{?rhel} < 7
there's no need for the first '0%{?rhel}'. if rhel is undefined, it evaluates
to '0' which is less than 7.
Since we do not support anything but rhel 6 and 7,
%if 0%{?rhel} = 6
is more appropriate
Line 265: Requires(post): policycoreutils-python > 2.0.83-19.47
Line 266: Requires(preun): policycoreutils-python > 2.0.83-19.47
Line 267: %else
Line 268: Requires(post): policycoreutils-python
--
To view, visit http://gerrit.ovirt.org/33771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Ohad Basan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix attribute error on sebool is-configure .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4147/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/139/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/162/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/355/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/160/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/155/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/64/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/71/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/69/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/69/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: moving setup booleans verb to be part of the configura...
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: moving setup booleans verb to be part of the configurators .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/63/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/70/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/68/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/68/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47
mooli tayer has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 4: Verified+1 # cat /etc/redhat-release CentOS release 6.6 (Final) # rpm -qv vdsm vdsm-4.16.0-478.gitbbda5ab.el6.x86_64 # rpm -qv policycoreutils-python policycoreutils-python-2.0.83-19.47.el6_6.1.x86_64 # vdsm-tool configure --force Checking configuration status... libvirt is not configured for vdsm yet Running configure... Reconfiguration of sebool is done. Reconfiguration of libvirt is done. Done configuring modules to VDSM. # semanage boolean -l| grep virt_use_samba virt_use_samba (on , on) Allow virt to manage cifs files # vdsm-tool remove-config removed configuration of module certificates successfully removed configuration of module sanlock successfully removed configuration of module sebool successfully removed configuration of module libvirt successfully # semanage boolean -l| grep virt_use_samba virt_use_samba (off , off) Allow virt to manage cifs files -- To view, visit http://gerrit.ovirt.org/33771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Ohad Basan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix attribute error on sebool is-configure .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13253/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13093/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12303/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
Dan Kenigsberg has posted comments on this change. Change subject: Fix attribute error on sebool is-configure .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix attribute error on sebool is-configure .. Fix attribute error on sebool is-configure The indentation was added wrongly in previous patch Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/34596 Reviewed-by: mooli tayer Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/configurators/sebool.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yaniv Bronhaim: Verified mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
mooli tayer has posted comments on this change. Change subject: Fix attribute error on sebool is-configure .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: relax the validation multiple networks on the same interface
oVirt Jenkins CI Server has posted comments on this change. Change subject: relax the validation multiple networks on the same interface .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13252/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13092/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12302/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2107/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/34538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
Yaniv Bronhaim has posted comments on this change. Change subject: Fix attribute error on sebool is-configure .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
Yaniv Bronhaim has posted comments on this change. Change subject: Fix attribute error on sebool is-configure .. Patch Set 1: this time with disable and enable (not only disable :/ ) -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix attribute error on sebool is-configure
Yaniv Bronhaim has uploaded a new change for review. Change subject: Fix attribute error on sebool is-configure .. Fix attribute error on sebool is-configure The indentation was added wrongly in previous patch Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Signed-off-by: Yaniv Bronhaim --- M lib/vdsm/tool/configurators/sebool.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/34596/1 diff --git a/lib/vdsm/tool/configurators/sebool.py b/lib/vdsm/tool/configurators/sebool.py index 4da2eb6..6a6be11 100644 --- a/lib/vdsm/tool/configurators/sebool.py +++ b/lib/vdsm/tool/configurators/sebool.py @@ -78,9 +78,9 @@ sebool_obj = seobject.booleanRecords() sebool_status = sebool_obj.get_all() -for sebool_variable in VDSM_SEBOOL_LIST: -if not all(sebool_status[sebool_variable]): -ret = NO +for sebool_variable in VDSM_SEBOOL_LIST: +if not all(sebool_status[sebool_variable]): +ret = NO return ret -- To view, visit http://gerrit.ovirt.org/34596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I02bbb725c32d75ae952f8636bfbb56d449dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Yaniv Bronhaim has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/34585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: sebool is-configured when selinux is disabled will always
be MAYBE
..
tool: sebool is-configured when selinux is disabled will always be MAYBE
Otherwise if selinux is disabled, we get an exception[1]
[1]:
>>> sebool_obj = seobject.booleanRecords()
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib64/python2.6/site-packages/seobject.py", line 2032, in __init__
semanageRecords.__init__(self, store)
File "/usr/lib64/python2.6/site-packages/seobject.py", line 240, in __init__
self.sh = self.get_handle(store)
File "/usr/lib64/python2.6/site-packages/seobject.py", line 267, in get_handle
raise ValueError(_("SELinux policy is not managed or store cannot be
accessed."))
ValueError: SELinux policy is not managed or store cannot be accessed.
Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4
Signed-off-by: Mooli Tayer
Signed-off-by: Yaniv Bronhaim
Reviewed-on: http://gerrit.ovirt.org/34516
Reviewed-by: Dan Kenigsberg
Reviewed-on: http://gerrit.ovirt.org/34585
---
M lib/vdsm/tool/configurators/sebool.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Yaniv Bronhaim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Yaniv Bronhaim has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 2: Code-Review+2 Verified+1 copy score -- To view, visit http://gerrit.ovirt.org/34585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: moving setup booleans verb to be part of the configura...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: tool: moving setup booleans verb to be part of the configurators .. tool: moving setup booleans verb to be part of the configurators Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157185 Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/34445 Reviewed-by: Dan Kenigsberg Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/34463 Reviewed-by: mooli tayer --- M debian/vdsm-python.install M debian/vdsm.postinst M debian/vdsm.prerm M lib/vdsm/tool/Makefile.am M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/Makefile.am A lib/vdsm/tool/configurators/sebool.py D lib/vdsm/tool/seboolsetup.py M vdsm-tool/vdsm-tool.1.in M vdsm.spec.in 10 files changed, 101 insertions(+), 96 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: relax the validation multiple networks on the same interface
oVirt Jenkins CI Server has posted comments on this change. Change subject: relax the validation multiple networks on the same interface .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4146/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/138/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/161/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/354/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/159/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/154/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: move Graphics Device utility functions
Martin Polednik has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 1: Code-Review-1 I'm ok with the idea, but I'd rather see those as ) classmethod ) method and not as a "laying around" functions -- To view, visit http://gerrit.ovirt.org/34558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd345f8f0eb477f6bda417c418f79900aeee53a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: relax the validation multiple networks on the same interface
Dan Kenigsberg has submitted this change and it was merged. Change subject: relax the validation multiple networks on the same interface .. relax the validation multiple networks on the same interface the only validation that is now left on the vdsm side is that there are no 2 networks using the same vlan tag that are connected to the same interface concurrently. Also, no 2 untagged networks can be connected to the same interface. Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Bug-Url: https://bugzilla.redhat.com/1049476 Signed-off-by: ibarkan Reviewed-on: http://gerrit.ovirt.org/34538 Reviewed-by: Antoni Segura Puimedon Reviewed-by: Dan Kenigsberg --- M lib/vdsm/netinfo.py M tests/functional/networkTests.py M vdsm/network/api.py 3 files changed, 73 insertions(+), 273 deletions(-) Approvals: Ido Barkan: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: relax the validation multiple networks on the same interface
Dan Kenigsberg has posted comments on this change. Change subject: relax the validation multiple networks on the same interface .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: relax the validation multiple networks on the same interface
Ido Barkan has posted comments on this change. Change subject: relax the validation multiple networks on the same interface .. Patch Set 5: Verified+1 verified by running all functional tests -- To view, visit http://gerrit.ovirt.org/34538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: moving setup booleans verb to be part of the configura...
mooli tayer has posted comments on this change. Change subject: tool: moving setup booleans verb to be part of the configurators .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Yaniv Bronhaim has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix random failures on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix random failures on el6 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4145/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/137/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/160/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/353/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5985/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/158/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/153/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6ad16bc2659318be3bb8dde4df5fee07af3417 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: moving setup booleans verb to be part of the configura...
Yaniv Bronhaim has posted comments on this change. Change subject: tool: moving setup booleans verb to be part of the configurators .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix random failures on el6
Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix random failures on el6 .. Patch Set 1: Code-Review+2 Raising score -- To view, visit http://gerrit.ovirt.org/34573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6ad16bc2659318be3bb8dde4df5fee07af3417 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Fix random failures on el6
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Fix random failures on el6 .. tests: Fix random failures on el6 The reject tests were relaying on the behavior in Fedora 20, but on el6 the concurrent reject tests sometimes behaves differently. On Fedora 20, recv() was always returning an empty string, but on el6, sometimes socket.error "connection reset by peer" was raised. Now both results are considered as disconnection. Change-Id: I7f6ad16bc2659318be3bb8dde4df5fee07af3417 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/34573 Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M tests/protocoldetectorTests.py 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f6ad16bc2659318be3bb8dde4df5fee07af3417 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Dan Kenigsberg has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: moving setup booleans verb to be part of the configura...
Dan Kenigsberg has posted comments on this change. Change subject: tool: moving setup booleans verb to be part of the configurators .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: sebool is-configured when selinux is disabled will alw...
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/157/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4144/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/136/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/159/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/352/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/152/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: assertIsNone is not available on Python 2.6
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: assertIsNone is not available on Python 2.6 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/67/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/62/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/69/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/67/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f68576ebb295af2dbd567da785d97eb06fd8a55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: relax the validation multiple networks on the same interface
Antoni Segura Puimedon has posted comments on this change. Change subject: relax the validation multiple networks on the same interface .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Yaniv Bronhaim has posted comments on this change. Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: moving setup booleans verb to be part of the configura...
Yaniv Bronhaim has posted comments on this change. Change subject: tool: moving setup booleans verb to be part of the configurators .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/34463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc97ba04c3b3463ae353815cdcf77b2212644e99 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: assertIsNone is not available on Python 2.6
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: assertIsNone is not available on Python 2.6 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/61/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/68/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/66/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/66/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f68576ebb295af2dbd567da785d97eb06fd8a55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: bump policycoreutils-python version to 2.0.83-19.47
Yaniv Bronhaim has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tool: sebool is-configured when selinux is disabled will alw...
Hello mooli tayer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34585
to review the following change.
Change subject: tool: sebool is-configured when selinux is disabled will always
be MAYBE
..
tool: sebool is-configured when selinux is disabled will always be MAYBE
Otherwise if selinux is disabled, we get an exception[1]
[1]:
>>> sebool_obj = seobject.booleanRecords()
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib64/python2.6/site-packages/seobject.py", line 2032, in __init__
semanageRecords.__init__(self, store)
File "/usr/lib64/python2.6/site-packages/seobject.py", line 240, in __init__
self.sh = self.get_handle(store)
File "/usr/lib64/python2.6/site-packages/seobject.py", line 267, in get_handle
raise ValueError(_("SELinux policy is not managed or store cannot be
accessed."))
ValueError: SELinux policy is not managed or store cannot be accessed.
Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4
Signed-off-by: Mooli Tayer
Signed-off-by: Yaniv Bronhaim
Reviewed-on: http://gerrit.ovirt.org/34516
Reviewed-by: Dan Kenigsberg
---
M lib/vdsm/tool/configurators/sebool.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/34585/1
diff --git a/lib/vdsm/tool/configurators/sebool.py
b/lib/vdsm/tool/configurators/sebool.py
index 427c7e3..becb41e 100644
--- a/lib/vdsm/tool/configurators/sebool.py
+++ b/lib/vdsm/tool/configurators/sebool.py
@@ -20,7 +20,8 @@
from .import \
CONFIGURED, \
ModuleConfigure, \
-NOT_CONFIGURED
+NOT_CONFIGURED, \
+NOT_SURE
from ... import utils
@@ -69,7 +70,9 @@
True all selinux booleans in the list above are set properly
"""
ret = CONFIGURED
-if utils.get_selinux_enforce_mode() > -1:
+if utils.get_selinux_enforce_mode() == -1:
+ret = NOT_SURE
+else:
import seobject
sebool_obj = seobject.booleanRecords()
sebool_status = sebool_obj.get_all()
--
To view, visit http://gerrit.ovirt.org/34585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: assertIsNone is not available on Python 2.6
Yaniv Bronhaim has submitted this change and it was merged. Change subject: tests: assertIsNone is not available on Python 2.6 .. tests: assertIsNone is not available on Python 2.6 This patch fixes the build on jenkins EL6 slaves. Change-Id: I4f68576ebb295af2dbd567da785d97eb06fd8a55 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33911 Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg (cherry picked from commit be7c990cc2878672b14f117ceb0dc534a737cc76) Reviewed-on: http://gerrit.ovirt.org/34497 Tested-by: Piotr Kliczewski Reviewed-by: Liron Aravot --- M tests/bridgeTests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f68576ebb295af2dbd567da785d97eb06fd8a55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm, guestagent: return hash should include also the disk map...
Yaniv Bronhaim has posted comments on this change. Change subject: vm, guestagent: return hash should include also the disk mapping .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I148196ccf353613f9cffed7753e7100bd1dd30de Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revised the format of output from the vdsm-tool vdsm-id comm...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revised the format of output from the vdsm-tool vdsm-id command. .. Patch Set 1: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13251/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13091/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12301/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/34583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7379e969881931aaa4745dedf85ddfb61487f4a4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Change method names in vmtune.py to the PEP8 style
Martin Sivák has restored this change. Change subject: Change method names in vmtune.py to the PEP8 style .. Restored -- To view, visit http://gerrit.ovirt.org/30078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ib5e9dcaf393ebafe56f6bc78cc9cb02d37a257ae Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add API.VM.getIoTunePolicy
Martin Sivák has restored this change. Change subject: Add API.VM.getIoTunePolicy .. Restored -- To view, visit http://gerrit.ovirt.org/30077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ib7983d91fe4b90c5b85c986c2b5a9a1931cfdc42 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: fix pep8 errors
Martin Sivák has restored this change. Change subject: tests: fix pep8 errors .. Restored -- To view, visit http://gerrit.ovirt.org/30073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ieefeb049d295ed89cdfedc7ccc9daee05b7de712 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add API.VM.setIoTune
Martin Sivák has restored this change. Change subject: Add API.VM.setIoTune .. Restored -- To view, visit http://gerrit.ovirt.org/30076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: janitorial: move isVdsmImage into utils
Martin Sivák has restored this change. Change subject: janitorial: move isVdsmImage into utils .. Restored -- To view, visit http://gerrit.ovirt.org/30099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add setIoTune and getIoTunePolicy to the xml-rpc API
Martin Sivák has restored this change. Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API .. Restored -- To view, visit http://gerrit.ovirt.org/30075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I1cac66eb93b3702b6274b3dfd0816158532effc3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Add IO tunables support to updateVmPolicy
Martin Sivák has restored this change. Change subject: Add IO tunables support to updateVmPolicy .. Restored -- To view, visit http://gerrit.ovirt.org/30074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Collect current QoS settings for IO devices and report throu...
Martin Sivák has restored this change. Change subject: Collect current QoS settings for IO devices and report through RunningVmStats .. Restored -- To view, visit http://gerrit.ovirt.org/30175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: fix getVmPolicy return type.
Martin Sivák has restored this change. Change subject: vm: fix getVmPolicy return type. .. Restored -- To view, visit http://gerrit.ovirt.org/30072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I4c1d79283ee2de4a5dcf54f3544ec346c68837e1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Refactor updateVmPolicy to use DOM manipulation
Martin Sivák has restored this change. Change subject: Refactor updateVmPolicy to use DOM manipulation .. Restored -- To view, visit http://gerrit.ovirt.org/30070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I475a70269c1f32e10f379b0743cfeefe642d4afd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Refactor XMLElement to virt.utils
Martin Sivák has restored this change. Change subject: Refactor XMLElement to virt.utils .. Restored -- To view, visit http://gerrit.ovirt.org/30071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I74528a597ace8148adbb0295a810ba7972b1270c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Improve the _validateIoTuneParams so the params are passed a...
Martin Sivák has restored this change. Change subject: Improve the _validateIoTuneParams so the params are passed as argument .. Restored -- To view, visit http://gerrit.ovirt.org/30069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Fix the API definition for cpu tune methods
Martin Sivák has restored this change. Change subject: Fix the API definition for cpu tune methods .. Restored -- To view, visit http://gerrit.ovirt.org/30068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I236af8141e0981a9af680e35860183579f916609 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: make api check support falsey values
Martin Sivák has restored this change. Change subject: tests: make api check support falsey values .. Restored -- To view, visit http://gerrit.ovirt.org/30067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I4f974b08589a077dedba3006b29f6bb29aee05ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Extract the DOM to Drive name, alias and path logic to reusa...
Martin Sivák has restored this change. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Restored -- To view, visit http://gerrit.ovirt.org/30066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Support ioTune values >2^31 in getStats over xml-rpc
Martin Sivák has restored this change. Change subject: Support ioTune values >2^31 in getStats over xml-rpc .. Restored -- To view, visit http://gerrit.ovirt.org/30233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: If5005d7fdc5397df2480fa8d0c15b003a52e8626 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Add a hook to configure IPv6 networking through custom properties .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/534/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/516/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13090/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12300/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e427b182a1742999eeb14e004209b511668ba2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
