Change in vdsm[master]: storage: Add multipath-resize command line tool
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/611/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1170/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16949/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1152/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/38467/7/vdsm/storage/multipath-resize
File vdsm/storage/multipath-resize:
Line 143:
Line 144:
Line 145: def resize_map(name):
Line 146: log.debug("Resizing map %s", name)
Line 147: cmd = [MULTIPATHD.cmd, "-kresize map %s" % name]
This was previously quoted by mistake.
Line 148: start = utils.monotonic_time()
Line 149: rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log)
Line 150: if rc != 0:
Line 151: raise Error("Resizing map %s failed: %s" % (name, err))
--
To view, visit https://gerrit.ovirt.org/38467
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
Nir Soffer has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 7: Example run with verbose logging: # /usr/libexec/vdsm/multipath-resize -v 360060160f4a030008b5463fdf56fe411 multipath-resize: Resizing device 360060160f4a030008b5463fdf56fe411 multipath-resize: Rescanning path sda multipath-resize: Rescanning path sdc multipath-resize: Rescanning path sdo multipath-resize: Rescanning path sdq multipath-resize: Scanned path sda in 0.00 seconds multipath-resize: Scanned path sdo in 0.00 seconds multipath-resize: Scanned path sdc in 0.00 seconds multipath-resize: Scanned path sdq in 0.00 seconds multipath-resize: Resizing map dm-3 multipath-resize: /sbin/multipathd '-kresize map dm-3' (cwd None) multipath-resize: SUCCESS: = ''; = 0 multipath-resize: Resized map dm-3 in 0.02 seconds -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
Nir Soffer has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 7: Changes in this version: - Address Dan concern about exotic characters in lun names by using device name (dm-*) instead of the lun name. This is poorly documented but checking multipathd code reveal that it supports both. - Improve some minor details, such as building path with os.path.join instead of using string manipulation Verified on fedora 21 and rhel 6.5. -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
Nir Soffer has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
automat...@ovirt.org has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require MOM aware of 'onlyUUID'
Dan Kenigsberg has posted comments on this change. Change subject: spec: require MOM aware of 'onlyUUID' .. Patch Set 4: Old mom is unbroken with https://gerrit.ovirt.org/#/c/38805 right ? so this patch can be abandoned? -- To view, visit https://gerrit.ovirt.org/38711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eed58fbacfc9168414c080b0e682d2711cb7d49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Dan Kenigsberg has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review+2 Wow, so no need in mom updates and conflicts! -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmTests: unbreak tests on el6
Yaniv Bronhaim has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402731fcf8376aa98ab4c6b26ab26fc2447438d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/344/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/721/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/349/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/750/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/348/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/754/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmTests: unbreak tests on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16776/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16948/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402731fcf8376aa98ab4c6b26ab26fc2447438d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16947/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require MOM aware of 'onlyUUID'
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: require MOM aware of 'onlyUUID' .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/610/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/602/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16774/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1169/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16946/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1151/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eed58fbacfc9168414c080b0e682d2711cb7d49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmTests: unbreak tests on el6
Dan Kenigsberg has uploaded a new change for review.
Change subject: vmTests: unbreak tests on el6
..
vmTests: unbreak tests on el6
test_change_cd_failure and testReadPauseCodeDomainPausedCrash have been
failing since they used too-new libvirt error codes.
Change-Id: I402731fcf8376aa98ab4c6b26ab26fc2447438d9
Signed-off-by: Dan Kenigsberg
---
M tests/vmTests.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/38809/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index d3e5beb..da22fe7 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -26,6 +26,7 @@
import uuid
import libvirt
+from nose.plugins.skip import SkipTest
from virt import vm
from virt import vmdevices
@@ -1014,6 +1015,10 @@
self.assertEqual(testvm._readPauseCode(), 'NOERR')
def testReadPauseCodeDomainPausedCrash(self):
+# REQUIRED_FOR: el6
+if not hasattr(libvirt, 'VIR_DOMAIN_PAUSED_CRASHED'):
+raise SkipTest('libvirt.VIR_DOMAIN_PAUSED_CRASHED undefined')
+
with fake.VM() as testvm:
# if paused for different reason we must not extend the disk
# so anything else is ok
@@ -1369,7 +1374,7 @@
with fake.VM(cif=cif) as fakevm:
# no specific meaning, actually any error != None is good
fakevm._dom = fake.Domain(
-virtError=libvirt.VIR_ERR_ACCESS_DENIED)
+virtError=libvirt.VIR_ERR_GET_FAILED)
res = fakevm.changeCD({})
--
To view, visit https://gerrit.ovirt.org/38809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I402731fcf8376aa98ab4c6b26ab26fc2447438d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmTests: unbreak tests on el6
automat...@ovirt.org has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402731fcf8376aa98ab4c6b26ab26fc2447438d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16945/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
Nir Soffer has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38754/4/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 87: If the return code is not 0, an error is raised.
Line 88: TODO: move to supervdsm when zombiereaper is functional there.
Line 89: """
Line 90: timeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 91: log.debug("Starting multipath resize")
Lets add the guid to all logs.
Line 92: proc = utils.execCmd([constants.EXT_MULTIPATH_RESIZE, guid],
sudo=True,
Line 93: sync=False, execCmdLogger=log)
Line 94: try:
Line 95: proc.wait(timeout)
--
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16944/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
Dan Kenigsberg has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38806/1/tests/vdsClientTests.py File tests/vdsClientTests.py: Line 524: Line 525: class ConnectTest(TestCaseBase): Line 526: Line 527: @ValidateRunningAsRoot Line 528: def testTimeout(self): indeed - it should be moved to the "functional" subdir. Line 529: c = vdscli.connect(useSSL=True, Line 530:tsPath='/etc/pki/vdsm', Line 531:timeout=0.01) Line 532: self.assertRaises(SSLError, c.getVdsStats) Line 525: class ConnectTest(TestCaseBase): Line 526: Line 527: @ValidateRunningAsRoot Line 528: def testTimeout(self): Line 529: c = vdscli.connect(useSSL=True, why specific useSSL explicitly? the currently-running vdsmd may use plaintext. Line 530:tsPath='/etc/pki/vdsm', Line 531:timeout=0.01) Line 532: self.assertRaises(SSLError, c.getVdsStats) Line 533: -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16943/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 4: The score is copied because you did not add any change (such as a unit test for the new functionality) or explained why this kind of test is not required. -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16941/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require MOM aware of 'onlyUUID'
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: require MOM aware of 'onlyUUID' .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/609/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/601/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1168/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16942/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1150/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eed58fbacfc9168414c080b0e682d2711cb7d49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
Nir Soffer has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/38754/4/client/vdsClient.py
File client/vdsClient.py:
Line 722: pp.pprint(devices['devList'])
Line 723: return 0, ''
Line 724:
Line 725: def refreshDevice(self, args):
Line 726: validateArgTypes(args, [str], requiredArgsNumber=1)
Nice! I forgot about this utility.
Line 727: guid = args[0]
Line 728: res = self.s.refreshDevice(guid)
Line 729: if res['status']['code']:
Line 730: return res['status']['code'], res['status']['message']
Line 728: res = self.s.refreshDevice(guid)
Line 729: if res['status']['code']:
Line 730: return res['status']['code'], res['status']['message']
Line 731: del res['status']
Line 732: printDict(res, self.pretty)
Returning the size as is is probably more useful since we have only one value,
but this is consistent with other code like getVolumeSize.
Line 733: return 0, ''
Line 734:
Line 735: def getDevicesVisibility(self, args):
Line 736: devList = args[0].split(',')
Line 2220:'storageType).'
Line 2221:)),
Line : 'refreshDevice': (serv.refreshDevice,
Line 2223: ('',
Line 2224:'Refresh Multipath device'
Multipath -> multipath.
I think we need little more documentation here, what does this refresh mean -
updating the device size after it was resized on the storage server.
Line 2225:)),
Line 2226: 'getDevicesVisibility': (serv.getDevicesVisibility,
Line 2227: ('',
Line 2228: 'Get visibility of each device
listed'
--
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16940/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16939/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16938/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16937/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16936/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
automat...@ovirt.org has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Dan Kenigsberg has submitted this change and it was merged. Change subject: asyncore: Move generic reactor functionality .. asyncore: Move generic reactor functionality This is part of a larger move to unify the protocol detector and the stomp reactor. In this phase we move all the functionality not specific to stomp to a generic Reactor class. This patch still keeps the original StompReactor to minimize changes outside of yajsonrpc. Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Signed-off-by: Saggi Mizrahi Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/37055 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M lib/yajsonrpc/betterAsyncore.py M lib/yajsonrpc/stompReactor.py 2 files changed, 53 insertions(+), 24 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: use the atomic dict.setdefault() instead for check an...
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: use the atomic dict.setdefault() instead for check and set .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16935/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28e4925a78328c4ac6cd0b9fc8659d6a3ee27a8f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Stomp encoder\decoder improvements
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Stomp encoder\decoder improvements .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16934/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Dan Kenigsberg has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Properly log and return an error if the threadFacto...
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Properly log and return an error if the threadFactory fails .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16933/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b579fa0e95397f1dc3b3e939a9040dc5bdef36d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: add ability to get dictionary directly from JsonRpc...
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: add ability to get dictionary directly from JsonRpcRequest .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16932/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb7edc48aa7d773b54db9d43e9f5460920e8ea50 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Remove redundant code
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Remove redundant code .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16931/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b9fb4b4b4c5286733f8f4435ec6dcea04f96233 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Remove JsonRpcClientPool
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Remove JsonRpcClientPool .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16930/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b67ee2ccb3acfac17a538ad2177f53c0007656 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16929/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Make sure the \0 is a last char in the buffer
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Make sure the \0 is a last char in the buffer .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16928/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16755/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16927/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16926/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Have the protocol detector use the Reactor
oVirt Jenkins CI Server has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16925/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Properly initialize RuntimeError for JsonRpcError
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16924/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16923/ : FAILURE -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16922/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16749/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16921/ : FAILURE -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16920/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16919/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Stop using tempnam in deleteImage
Nir Soffer has posted comments on this change. Change subject: storage: Stop using tempnam in deleteImage .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ff87e735c12c94d704391286d1bfc451b442956 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16746/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16918/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: remove unwanted 'response' aliasing
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: remove unwanted 'response' aliasing .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16745/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16917/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53f91af7e6d28aaf033bfb589216c0422bd4a311 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: use response.error() with custom message
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: use response.error() with custom message .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16916/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c75970111bcc93308919a928a90afd2c44ec18c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Report info needed for refreshing devices
Nir Soffer has posted comments on this change. Change subject: hsm: Report info needed for refreshing devices .. Patch Set 2: Freddy, can you verify this? -- To view, visit https://gerrit.ovirt.org/38675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfa5cf4321202362f5a00dad7c9a0347ba52ec71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
Daniel Erez has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 3: Verified+1 Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Daniel Erez has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 4: Verified+1 Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add more tests for custom error responses
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add more tests for custom error responses .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16915/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf3d03f125f9c53339d9ad7fef8c31482bab0bfb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: virt: add the response.success() helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: virt: add the response.success() helper .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16914/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove _reportError
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: remove _reportError .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16913/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: introduce the 'response' module
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: introduce the 'response' module .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/608/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/600/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1167/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16912/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1149/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: switch to response.error() .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16911/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: janitorial: use the response module
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: janitorial: use the response module .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16910/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678e764a2895e7c34df6852759b1d43baeb687a1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: call named arguments with their name
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: call named arguments with their name .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16909/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bc4358522dfaafa9a91ca58b4b18ecd04065f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16908/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16735/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16907/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
Yaniv Bronhaim has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 1: Code-Review-1 We should move it to be as part of infra functional tests. It requires running vdsm -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Add refresh device verb .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16906/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
Yaniv Bronhaim has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 4: Why does it copy the score? Dan, can you please reconsider ? -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 29: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16905/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: acquire image ns in copy task
oVirt Jenkins CI Server has posted comments on this change. Change subject: acquire image ns in copy task .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16904/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93aa381fb6c17c3a71f832f2dd51975a250159f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Stop using tempnam in deleteImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Stop using tempnam in deleteImage .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16731/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16903/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ff87e735c12c94d704391286d1bfc451b442956 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: SDM: removeVolume command and volume garbage collection
oVirt Jenkins CI Server has posted comments on this change. Change subject: SDM: removeVolume command and volume garbage collection .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16902/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66f846171bcc9920f05d38dc37d2f30a0443e209 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: introduce the new createVolumeContainer command
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: introduce the new createVolumeContainer command .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/607/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/599/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16901/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1148/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3ea624f81a04a830cdcbcfe2f777cdd7bd26c08 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clusterLock: Acquire, release, and inquire volume leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Acquire, release, and inquire volume leases .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16728/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16900/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca901ccd27358767c023cd55b7a3823531d2a5a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce storage domain version 4
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introduce storage domain version 4 .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16899/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie889802d8b6aabdd2d03228ee2c36dfa1c77c5d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: export volume lease state in getVolumeInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16898/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55f062a4be15593fdc98518fd0a113976cbe0ae7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: SDM: add the copyVolumeData command
oVirt Jenkins CI Server has posted comments on this change. Change subject: SDM: add the copyVolumeData command .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16897/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30e44a6332ec343f64793b0fedaf9ef75a872cac Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clusterLock: Make inquire retval consistent
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16896/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4b9227773e44d48b21aa4eaba7c7fe1ab599931 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change. Change subject: block: convert getVolumeMetadataSlot into a contexmanager .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16723/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16895/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/25988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network: Flush all configurators before restoring networks
oVirt Jenkins CI Server has posted comments on this change. Change subject: Network: Flush all configurators before restoring networks .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/606/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/598/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16722/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1165/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16894/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1147/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2803/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit https://gerrit.ovirt.org/38767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3d0fb35d608a8b019ad80f7e40f4399e7db479 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split network restoration from vdsmd.service
oVirt Jenkins CI Server has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 15: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/605/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/597/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16721/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16893/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1146/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2802/ : The patch does not pass the network functional tests -- To view, visit https://gerrit.ovirt.org/29441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4728/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/720/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/348/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/749/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/753/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
oVirt Jenkins CI Server has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16892/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/604/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/596/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16719/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1163/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16891/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1145/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16718/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16890/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: models: tag non-VDSM devices used by VDSM
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16717/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16889/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2801/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Martin Sivák has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Martin Sivák has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 Yep I like this approach much better. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
Nir Soffer has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 4:
(5 comments)
Very nice!
https://gerrit.ovirt.org/#/c/38754/4/client/vdsClient.py
File client/vdsClient.py:
Line 729: if res['status']['code']:
Line 730: return res['status']['code'], res['status']['message']
Line 731: del res['status']
Line 732: printDict(res, self.pretty)
Line 733: return 0, ''
Can you show the output of successful and failed operations?
You can copy and paste the text from the shell as a comment.
Line 734:
Line 735: def getDevicesVisibility(self, args):
Line 736: devList = args[0].split(',')
Line 737: res = self.s.getDevicesVisibility(devList, {})
https://gerrit.ovirt.org/#/c/38754/4/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 31:
Line 32: from vdsm import constants
Line 33: from vdsm import utils
Line 34: from vdsm.infra import zombiereaper
Line 35: from vdsm.config import config
vdsm.config should be before vdsm.infra - right?
Line 36: import hba
Line 37: import misc
Line 38: import iscsi
Line 39: import supervdsm
Line 75:
Line 76: def resize(guid):
Line 77: """
Line 78: In case the LUN was increased on storage server, in order to see
the
Line 79: changes it is needed to rescan the device path and resize the
multipath.
resize the multipath -> resize the multipath map
Line 80:
Line 81: This method calls script multipath-resize which will perform the
following:
Line 82: - Perform scsi scan of the device paths
Line 83: - Resize the multipath map
Line 77: """
Line 78: In case the LUN was increased on storage server, in order to see
the
Line 79: changes it is needed to rescan the device path and resize the
multipath.
Line 80:
Line 81: This method calls script multipath-resize which will perform the
following:
script multipath-reisze -> multipath-resize tool
(we don't care how it is implemented)
Line 82: - Perform scsi scan of the device paths
Line 83: - Resize the multipath map
Line 84: SCSI scan is a blocking operation, so it is needed to run in
external tool.
Line 85: The call to the script is blocking up to 30 seconds.
Line 79: changes it is needed to rescan the device path and resize the
multipath.
Line 80:
Line 81: This method calls script multipath-resize which will perform the
following:
Line 82: - Perform scsi scan of the device paths
Line 83: - Resize the multipath map
Please separate paragraphs with empty line.
Line 84: SCSI scan is a blocking operation, so it is needed to run in
external tool.
Line 85: The call to the script is blocking up to 30 seconds.
Line 86: If the operation times out, an error is raised.
Line 87: If the return code is not 0, an error is raised.
--
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Add multipath-resize command line tool
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/38467/6/vdsm/storage/multipath-resize
File vdsm/storage/multipath-resize:
Line 81: args.remove("-v")
Line 82: else:
Line 83: loglevel = logging.INFO
Line 84:
Line 85: logging.basicConfig(level=loglevel, format="%(name)s: %(message)s")
> To debug timeouts and other time-related issues, could be useful to add tim
I log explicit elapsed time for actions that may block.
Line 86:
Line 87: if not args:
Line 88: log.error("No device name specified")
Line 89: return 2
Line 101: log.error("Resizing device %s failed: %s", guid, e)
Line 102: return 1
Line 103: except Exception:
Line 104: log.exception("Unexpected error")
Line 105: return 1
> Maybe add different return code?
I can use 1 for general errors (what you get when exception is unhandled), and
2 for usage error, and 3 for expected errors (rescan failed, resize map
failed). I'm not sure if this will be useful.
Line 106:
Line 107: return 0
Line 108:
Line 109:
--
To view, visit https://gerrit.ovirt.org/38467
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I229ef5fa757989329939a9267041785f2c0f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: models: tag non-VDSM devices used by VDSM
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16716/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16888/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2800/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-scan: Use utilities from vdsm library.
Nir Soffer has posted comments on this change. Change subject: fc-scan: Use utilities from vdsm library. .. Patch Set 2: Since this is part of vdsm, it seems wasteful to avoid using vdsm infrastructure. If we like to make this more general tool separate from vdsm, we will probably rewrite this in C, so sharing code with vdsm will not be an option :-) -- To view, visit https://gerrit.ovirt.org/38466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48748d6a43d41e034e16cb4f636ebe627881590 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: janitorial: use the response module
Francesco Romani has posted comments on this change. Change subject: v2v: janitorial: use the response module .. Patch Set 6: rebased -- To view, visit https://gerrit.ovirt.org/38447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678e764a2895e7c34df6852759b1d43baeb687a1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove _reportError
Francesco Romani has posted comments on this change. Change subject: vm: remove _reportError .. Patch Set 12: rebased -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: misc: Support zero-time in getReadDelay()
Nir Soffer has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58ae0ec5f3f88a1738ef1b95688534c8c8022362 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shirly Radco Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: call named arguments with their name
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: call named arguments with their name .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/746/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/342/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/719/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/748/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/346/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/752/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bc4358522dfaafa9a91ca58b4b18ecd04065f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: introduce the 'response' module
Francesco Romani has posted comments on this change. Change subject: lib: introduce the 'response' module .. Patch Set 13: Verified+1 version 13 drops the vmTests.py (they were moved into a different patch), so ticking V+1 again. -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: Simplify and generalize concurrent.tmap()
Nir Soffer has posted comments on this change. Change subject: lib: Simplify and generalize concurrent.tmap() .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38465/2/lib/vdsm/concurrent.py File lib/vdsm/concurrent.py: Line 36: results[i] = Result(False, e) Line 37: Line 38: threads = [] Line 39: for i, arg in enumerate(args): Line 40: t = threading.Thread(target=worker, args=(i, func, arg)) > let me stress again that I'm ok with this patch. This is just a general obs I think the long term is using concurrent.futures package from Python 3 or the backport for Python 2. This is the minimal solution I need now to avoid duplicating code in fc-scan and multipath-resize (see next patches). Line 41: t.daemon = True Line 42: t.start() Line 43: threads.append(t) Line 44: -- To view, visit https://gerrit.ovirt.org/38465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4337db65fe1b326157507b1424a8b4924b91210f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: virt: add the response.success() helper
Francesco Romani has posted comments on this change. Change subject: lib: virt: add the response.success() helper .. Patch Set 11: rebased -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
