Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17459/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
Darshan N has posted comments on this change. Change subject: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps. .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17459/ -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
Darshan N has uploaded a new change for review.
Change subject: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
..
gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
This patch adds a new flag 'gluster3_7Support' to getVdsCaps.
This flag specifies if the host has support for gluster-3.7
features like Geo-replication, Snapshot and Brick provisoning.
This is an optional flag, this flag is returned only if
gluster is enabled.
Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Signed-off-by: Darshan N
---
M vdsm/caps.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/39324/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 57c5b7e..f9b0193 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -57,6 +57,7 @@
try:
from gluster.api import GLUSTER_RPM_PACKAGES
from gluster.api import GLUSTER_DEB_PACKAGES
+from gluster.api import GlusterApi
_glusterEnabled = True
except ImportError:
_glusterEnabled = False
@@ -599,6 +600,23 @@
return False
+def _getGluster3_7FeatureSupport():
+# Check if gluster 3.7 features are supported by this Vdsm.
+# This Check is done by seeing if sample verbs for supporting
+# gluster 3.7 features are available in gluster api.
+if _glusterEnabled:
+gluster3_7featureSampleVerbs = ('volumeSnapshotCreate',
+'volumeGeoRepSessionCreate',
+'storageDevicesList')
+for feature in gluster3_7featureSampleVerbs:
+if feature not in dir(GlusterApi):
+return False
+else:
+return True
+else:
+return None
+
+
def get():
targetArch = getTargetArch()
@@ -693,6 +711,10 @@
caps['hostdevPassthrough'] = str(_getHostdevPassthorughSupport()).lower()
+gluster3_7FeatureSupport = _getGluster3_7FeatureSupport()
+if gluster3_7FeatureSupport is not None:
+caps['gluster3_7Support'] = str(gluster3_7FeatureSupport).lower()
+
return caps
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 477f712..0cf2702 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -1269,6 +1269,10 @@
# @directedPassthrough: Indicates status of Intel VT-d or AMD-vi
# (new in version 4.17.0)
#
+# @gluster3_7Support: #optional Indicates if glusterfs-3.7 features are
+# supported in this host.
+# (new in version 4.17.0)
+#
# Since: 4.15.0
#
# Notes: Since ovirt-engine cannot parse software versions in 'x.y.z' format,
@@ -1295,7 +1299,7 @@
'autoNumaBalancing': 'AutoNumaBalancingStatus',
'selinux': 'SELinuxStatus', '*liveSnapshot': 'bool',
'kdumpStatus': 'int', '*liveMerge': 'bool',
- 'directedPassthrough': 'bool'}}
+ 'directedPassthrough': 'bool', '*gluster3_7Support': 'bool'}}
##
# @Host.getCapabilities:
--
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps. .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17285/ -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds a new flag 'gluster3_7Support' to getVdsCaps. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Wait for udev events after rescan
Nir Soffer has posted comments on this change.
Change subject: multipath: Wait for udev events after rescan
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/39288/1//COMMIT_MSG
Commit Message:
Line 14: may not been handled yet when iscsiadm existed.
Line 15:
Line 16: This patch replaces the minimal scsi timeout with udevadm.settle(),
Line 17: waiting until current udev events are handled. Since we perform both
FC
Line 18: and iSCSI scan, the correct place for waiting is in multipath.rescan()
> I'm not sure I understand the logical inference here. Do you make only mult
Previously we "waited" after iscsi scan, so I could replace the time.sleep()
in iscsi.rescan() with udevadm.settle(). Since we do also fc scan, we should
wait also there. Instead of waiting twice, we wait in the single place calling
both.
Line 19: and not in iscsi.rescan().
Line 20:
Line 21: A new configuration was introduced, allowing fine tuning of settle
Line 22: timeout in the field.
https://gerrit.ovirt.org/#/c/39288/1/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line 412
Line 413
Line 414
Line 415
Line 416
> can you refer to this FIXME removal?
I don't think this is broken from the core and the suggested fix is complex and
does not cover the main use case.
When trying to detect new devices, you don't know yet the new devices, so we
cannot wait for specific devices.
When we know what we are looking for, we can wait until iscsiadm finish
(typically it is very fast), and then wait for a specific device (e.g, in
getDevicesVisibility).
Async scan can help when one host is very slow, and we are looking for a device
on a different host, and can finish the scan quickly without being blocked by
the slow host.
To support this negative flow, we will have to create a much more complex code
(maybe a thread dedicated to scanning). This can be lot of fun but is not our
roadmap.
If you like I can improve the comment so it document the limits of the current
code.
https://gerrit.ovirt.org/#/c/39288/1/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 72: # Scanning SCSI interconnects starts a storm of udev events. Wait
until all
Line 73: # events are processed, ensuring detection of new devices and
creation or
Line 74: # update of multipath devices.
Line 75: timeout = config.getint('irs', 'scsi_settle_timeout')
Line 76: udevadm.settle(timeout)
> does `udevadm settle` give any indeication if the timeout was enough? it wo
No
Line 77:
Line 78:
Line 79: def deduceType(a, b):
Line 80: if a == b:
--
To view, visit https://gerrit.ovirt.org/39288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Candace Sheremeta
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/37509/14/vdsm/v2v.py File vdsm/v2v.py: Line 487: class OutputParser(object): Line 488: COPY_DISK_RE = re.compile(r'.*(Copying disk (\d+)/(\d+)).*') Line 489: DISK_PROGRESS_RE = re.compile(r'\s+\((\d+).*') Line 490: Line 491: def parse(self, stream): it would be simpler to review the code if you introduce this parsing functions (and their tests) in a separate patch. There we can discuss whether to keep this OutputParser namespace. Line 492: for line in stream: Line 493: if 'Copying disk' in line: Line 494: description, current_disk, disk_count = self._parse_line(line) Line 495: yield ImportProgress(int(current_disk), int(disk_count), -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Wait for udev events after rescan
Dan Kenigsberg has posted comments on this change.
Change subject: multipath: Wait for udev events after rescan
..
Patch Set 1: Code-Review+1
(3 comments)
https://gerrit.ovirt.org/#/c/39288/1//COMMIT_MSG
Commit Message:
Line 14: may not been handled yet when iscsiadm existed.
Line 15:
Line 16: This patch replaces the minimal scsi timeout with udevadm.settle(),
Line 17: waiting until current udev events are handled. Since we perform both
FC
Line 18: and iSCSI scan, the correct place for waiting is in multipath.rescan()
I'm not sure I understand the logical inference here. Do you make only
multipath.rescan() wait for device files because it is called last? (it makes
sense to wait only once; I just don't understand the "sunce").
Line 19: and not in iscsi.rescan().
Line 20:
Line 21: A new configuration was introduced, allowing fine tuning of settle
Line 22: timeout in the field.
https://gerrit.ovirt.org/#/c/39288/1/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line 412
Line 413
Line 414
Line 415
Line 416
can you refer to this FIXME removal?
https://gerrit.ovirt.org/#/c/39288/1/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 72: # Scanning SCSI interconnects starts a storm of udev events. Wait
until all
Line 73: # events are processed, ensuring detection of new devices and
creation or
Line 74: # update of multipath devices.
Line 75: timeout = config.getint('irs', 'scsi_settle_timeout')
Line 76: udevadm.settle(timeout)
does `udevadm settle` give any indeication if the timeout was enough? it would
be beneficial to learn if 5 seconds were enough.
Line 77:
Line 78:
Line 79: def deduceType(a, b):
Line 80: if a == b:
--
To view, visit https://gerrit.ovirt.org/39288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Candace Sheremeta
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
Darshan N has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Rebased patch set 1 -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
Darshan N has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17458/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17458/ -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17284/ -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
Moti Asayag has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17283/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17457/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 9: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17457/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 9: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17283/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
automat...@ovirt.org has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 14:
(4 comments)
https://gerrit.ovirt.org/#/c/37509/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 325: self._status_msg = ex.message
Line 326: self._abort()
Line 327: raise
Line 328: finally:
Line 329: self._delete_passwd_file()
If this raises OSError that we don't handle, prepared voluems will not be tear
down.
The best way to fix this would be to catch and log such failures here to keep
_delete_passwd_file more general.
We must do this since raising in finally will hide errors from the except
block, which is very bad thing to do, since these errors are the real errors
that we must keep.
So:
try:
self._delete_passwd_file():
except Excepiton:
logging.exception("Error deleting passwd file: %r", self._passwd_file)
Line 330: self._teardown_volumes()
Line 331:
Line 332: def _import(self):
Line 333: # TODO: use the process handling
http://gerrit.ovirt.org/#/c/33909/
Line 338: env={'LIBGUESTFS_BACKEND': 'direct'})
Line 339:
Line 340: self._proc.blocking = True
Line 341: self._watch_process_output()
Line 342:
You should wait for the process before checking the return code:
logging.debug("Job %r waiting for virt-v2v process", self._id)
self._proc.wait(timeout)
We should abort and fail if it does not finish within reasonable timeout.
Since parsing was finished without an error (stdout was closed), this should
not take too much time, but this requires testing with v2v.
Line 343: if self._proc.returncode != 0:
Line 344: raise V2VProcessError('Process failed exit-code: %r,
stderr: %s' %
Line 345: (self._proc.returncode,
Line 346:self._proc.stderr.read(1024)))
Line 339:
Line 340: self._proc.blocking = True
Line 341: self._watch_process_output()
Line 342:
Line 343: if self._proc.returncode != 0:
returncode may be None if the process did not exit yet. This is unlikely but
possible. In such case, we would drop good vm we just imported successfully.
Line 344: raise V2VProcessError('Process failed exit-code: %r,
stderr: %s' %
Line 345: (self._proc.returncode,
Line 346:self._proc.stderr.read(1024)))
Line 347: logging.info('Importing VM finish, JobId:', self._id)
Line 464: self._prepared_volumes.append([drive])
Line 465:
Line 466: return
self._extract_storage_path(self._prepared_volumes[0]['path'])
Line 467:
Line 468: def _extract_storage_path(self, path):
> Rename to _get_storage_domain_path() and access self._prepared_volumes[0] i
You can also move it out of the class and make it a module function, accepting
a volume path and returning the storage domain path.
Such function can be moved later to storage/volume.py
Line 469: '''
Line 470: prepareImage returns /prefix/sdUUID/images/imgUUID/volUUID
Line 471: we need storage domain absolute path so we go up 3 levels
Line 472: '''
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/37509/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 329: self._delete_passwd_file()
Line 330: self._teardown_volumes()
Line 331:
Line 332: def _import(self):
Line 333: # TODO: use the process handling
http://gerrit.ovirt.org/#/c/33909/
This is a good place to prepare the volumes.
Line 334: cmd = self._create_command()
Line 335: logging.info('Import vm, (job_id %s) started, cmd: %s',
self._id, cmd)
Line 336:
Line 337: self._proc = execCmd(cmd, sync=False, deathSignal=15,
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
Nir Soffer has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38281/9/lib/vdsm/tool/vdsm_dump_chains.py File lib/vdsm/tool/vdsm_dump_chains.py: Line 54: pass Line 55: Line 56: Line 57: class ChainError(DumpChainsError): Line 58: def __init__(self, volumes_children): Add img_uuid='' argument and set self.img_uuid Line 59: self.volumes_children = volumes_children Line 60: self.img_uuid = '' # can be optionally set Line 61: Line 62: def __str__(self): -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
Nir Soffer has posted comments on this change. Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool) .. Patch Set 9: (4 comments) https://gerrit.ovirt.org/#/c/38281/9/lib/vdsm/tool/vdsm_dump_chains.py File lib/vdsm/tool/vdsm_dump_chains.py: > please rename. it doesn't really matter but more appropriate. and why do we This is leftover from the version were this was a standalone tool Line 1: # Copyright 2015 Red Hat, Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 88: e.g: (BLANK_UUID<-a), (a<-b), (c<-d)""" Line 89: Line 90: Line 91: @expose(_NAME) Line 92: def main(*args): Do we get args from vdsm-tool in this argument? If not, remove args. Line 93: """ Line 94: dump-volume-chains Line 95: Query VDSM about the existing structure of image volumes and prints Line 96: them in an ordered fashion with optional additional info per volume. Line 93: """ Line 94: dump-volume-chains Line 95: Query VDSM about the existing structure of image volumes and prints Line 96: them in an ordered fashion with optional additional info per volume. Line 97: """ > you can validate if vdsmd is up before trying to connect Better try to connect and fail, less racy (assuming that this fails fast). Line 98: try: Line 99: options, args = _parse_args() Line 100: sd_uuid, = args Line 101: server = _connect_to_server(options) Line 95: Query VDSM about the existing structure of image volumes and prints Line 96: them in an ordered fashion with optional additional info per volume. Line 97: """ Line 98: try: Line 99: options, args = _parse_args() If we get args using *args, you should use them to parse the arguments, instead of sys.argv. Line 100: sd_uuid, = args Line 101: server = _connect_to_server(options) Line 102: image_chains, volumes_info = _get_volumes_chains(server, sd_uuid) Line 103: -- To view, visit https://gerrit.ovirt.org/38281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vladik Romanovsky Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Dary Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 14:
(16 comments)
https://gerrit.ovirt.org/#/c/37509/14/vdsm/v2v.py
File vdsm/v2v.py:
Line 78: class InvalidVMConfiguration(ValueError):
Line 79: ''' Unexpected error while parsing libvirt domain xml '''
Line 80:
Line 81:
Line 82: class JobOutputParsing(ValueError):
Lets rename to OutputParserError
Line 83: ''' Error while parsing virt-v2v output '''
Line 84:
Line 85:
Line 86: class V2VJobError(ValueError):
Line 88:
Line 89:
Line 90: class NoSuchJob(V2VJobError):
Line 91: ''' Job not exists in _jobs collection '''
Line 92: err_name = 'invalidV2VJob'
Lets be consistent - V2VNoSuchJob
Line 93:
Line 94:
Line 95: class JobExists(V2VJobError):
Line 96: ''' Job already exists in _jobs collection '''
Line 93:
Line 94:
Line 95: class JobExists(V2VJobError):
Line 96: ''' Job already exists in _jobs collection '''
Line 97: err_name = 'v2vJobExists'
Lets be consistent - V2VJobExists
Line 98:
Line 99:
Line 100: class JobNotDone(V2VJobError):
Line 101: ''' Import process still in progress '''
Line 107: err_name = 'V2VNoSuchOvf'
Line 108:
Line 109:
Line 110: class VolumeError(RuntimeError):
Line 111: ''' Bad volume specification '''
A better description would be:
Error preparing volume
Why these error do not have an error name? Why not have error name and code for
all errors?
Line 112:
Line 113:
Line 114: class V2VProcessError(ValueError):
Line 115: ''' virt-v2v process had error in execution '''
Line 119: ''' Error parsing virt-v2v progress output '''
Line 120:
Line 121:
Line 122: class InvalidParsingEvent(ValueError):
Line 123: ''' Unknown parsing event caught '''
Can we use one error for output parsing? we have:
- JobProgressError
- JobOutputparsing
- InvalidParsingEvent
Line 124:
Line 125:
Line 126: class InvalidInput(ValueError):
Line 127: ''' Invalid input received '''
Line 123: ''' Unknown parsing event caught '''
Line 124:
Line 125:
Line 126: class InvalidInput(ValueError):
Line 127: ''' Invalid input received '''
This certainly need to be a public error - it mean that engine passed invalid
data to a v2v verb.
Line 128:
Line 129:
Line 130: def supported():
Line 131: return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)
Line 177: try:
Line 178: job = _get_job(job_id)
Line 179: _validate_job_done(job)
Line 180: ovf = _read_ovf(job_id)
Line 181: except V2VJobError as e:
This does not handle all the errors inheriting from ValueError.
All the errors in this module should inherit instead from v2v.Error, and then
you can handle only v2v.Error here.
v2v.Error should inherit from Exception, as it is not always a value error.
This is good example why inheriting from stdlib exceptions (such as ValueError)
is bad idea. This was requested in an older review, but as we can see this was
bad advice.
Same for other try top level exception handlers.
Line 182: logging.warning('Converted VM error %s', e)
Line 183: return errCode[e.err_name]
Line 184: return {'status': doneCode, 'ovf': ovf}
Line 185:
Line 351: parser = OutputParser()
Line 352: for event in parser.parse(self._proc.stdout):
Line 353: if isinstance(event, ImportProgress):
Line 354: self._status = STATUS.COPYING_DISK
Line 355: logging.info('Copying disk, JobId: %s', self._id)
We like to see the disk number/total
logging.info("Job %r copying disk %d/%d",
self._id, event.current_disk, event.disk_count)
Line 356: self._disk_progress = 0
Line 357: self._current_disk = event.current_disk
Line 358: self._disk_count = event.disk_count
Line 359: self._status_msg = event.description
Line 361: self._disk_progress = event.progress
Line 362: if event.progress % 10 == 0:
Line 363: logging.debug('Copying disk progress %n, JobId:
%s',
Line 364: event.progress,
Line 365: self._id)
Lets use same format:
logging.info("Job %r copy disk %d progress %d/100",
self._id, self._current_disk, event.progress)
Line 366: else:
Line 367: raise InvalidParsingEvent(event)
Line 368:
Line 369: def _create_command(self):
Line 376: '--vdsm-ovf-output',
Line 377: _V2V_DIR,
Line 378: '--machine-readable',
Line 379: '-os',
Line 380: self._prepare_volumes(),
You are hiding major step - preparing volumes - in the create command
boilerplate.
You do this because this is the current way to get the storage domain path, but
it is
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/703/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1262/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17456/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1244/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1244/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17282/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/703/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1262/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17456/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Shahar Havivi has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 13:
(13 comments)
https://gerrit.ovirt.org/#/c/37509/13/vdsm/v2v.py
File vdsm/v2v.py:
Line 61:
Line 62:
Line 63: class STATUS:
Line 64: '''
Line 65: STARTING: request granted and string the import process
> string -> starting
Done
Line 66: COPYING_DISK: copying disk in progress
Line 67: ABORTED: user initiated aborted
Line 68: FAILED: error during import process
Line 69: DONE: convert process successfully finished
Line 266: self._uri = uri
Line 267: self._username = username
Line 268: self._password = password
Line 269: self._vm_properties = vm_properties
Line 270: self.id = job_id
> Why public? This should be readonly right? Keep in self._id an ad an id() p
Done
Line 271: self._cif = cif
Line 272: self._status = STATUS.STARTING
Line 273: self._disk_progress = 0
Line 274: self._disk_count = 1
Line 313: self._import()
Line 314: except Exception as ex:
Line 315: self._status = STATUS.FAILED
Line 316: self._status_msg = ex.message
Line 317: self._abort()
> All this is correct only when we fail. If the process was aborted, and the
Done
Line 318: raise
Line 319: finally:
Line 320: self._delete_passwd_file()
Line 321: self._teardown_volumes()
Line 332: _V2V_DIR,
Line 333: '--machine-readable',
Line 334: '-os',
Line 335: self._prepare_volumes(),
Line 336: self._vm_properties['vmName']])
> I would move this part, creating the command, to single helper - _create_co
Done
Line 337:
Line 338: logging.info('Import vm, (job_id %s) started, cmd: %s',
self.id, cmd)
Line 339:
Line 340: self._proc = execCmd(cmd, sync=False, deathSignal=15,
Line 344: self._watch_process_output()
Line 345:
Line 346: if self._proc.returncode != 0:
Line 347: raise V2VProcessError("Process failed: %s" %
Line 348: self._proc.stderr.read(1024))
> Add the process returncode to the error message.
Done
Line 349: self._status = STATUS.DONE
Line 350:
Line 351: def _watch_process_output(self):
Line 352: parser = OutputParser()
Line 345:
Line 346: if self._proc.returncode != 0:
Line 347: raise V2VProcessError("Process failed: %s" %
Line 348: self._proc.stderr.read(1024))
Line 349: self._status = STATUS.DONE
> We need here another logging.info reporting the successful conversion.
Done
Line 350:
Line 351: def _watch_process_output(self):
Line 352: parser = OutputParser()
Line 353: for event in parser.parse(self._proc.stdout):
Line 350:
Line 351: def _watch_process_output(self):
Line 352: parser = OutputParser()
Line 353: for event in parser.parse(self._proc.stdout):
Line 354: if isinstance(event, ImportProgress):
> We need logging.info here when starting to copy new disk.
Done
Line 355: self._status = STATUS.COPYING_DISK
Line 356: self._disk_progress = 0
Line 357: self._current_disk = event.current_disk
Line 358: self._disk_count = event.disk_count
Line 356: self._disk_progress = 0
Line 357: self._current_disk = event.current_disk
Line 358: self._disk_count = event.disk_count
Line 359: self._status_msg = event.description
Line 360: elif isinstance(event, DiskProgress):
> Maybe loggging.debug during progress? if not for every event, maybe every 1
Done
Line 361: self._disk_progress = event.progress
Line 362: else:
Line 363: raise InvalidParsingEvent(event)
Line 364:
Line 418: for disk in self._vm_properties['disks']:
Line 419: parameters.append('--vdsm-image-uuid')
Line 420: parameters.append(disk['imageID'])
Line 421: parameters.append('--vdsm-vol-uuid')
Line 422: parameters.append(disk['volumeID'])
> If imageID or volumeID is missing your request will fail with KeyError.
Done
Line 423: return parameters
Line 424:
Line 425: def _prepare_volumes(self):
Line 426: '''
Line 419: parameters.append('--vdsm-image-uuid')
Line 420: parameters.append(disk['imageID'])
Line 421: parameters.append('--vdsm-vol-uuid')
Line 422: parameters.append(disk['volumeID'])
Line 423: return parameters
> This will process only the first disk - move the return out of th e loop.
Done
Line 424:
Line 425: def _prepare_volumes(self):
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 14: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/695/ -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/201/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/25/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/201/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/193/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17454/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1243/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Wait for udev events after connect
Nir Soffer has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 1: Here is udevadm settle invocations during various storage flows on el7. - activating host: http://pastebin.com/nqRZsEX8 - discovering and logging to 7 targets: http://pastebin.com/xpP2t6mx - create domain: http://pastebin.com/tdKXrFGn - deactivate domain: http://pastebin.com/ZXvnALSi - activate-domain: http://pastebin.com/t8hPJGxu - remove domain: http://pastebin.com/hHxM3kCz - maintenance host: http://pastebin.com/6TN3Rm1F We can see that typically we have very small delays, but sometimes we delays up to 500 milliseconds. -- To view, visit https://gerrit.ovirt.org/39289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add some logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: add some logging .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17455/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebd6f9773d31e2da66edfcb3cf6e636ef9a62187 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1243/ -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add some logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: add some logging .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17281/ -- To view, visit https://gerrit.ovirt.org/39314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebd6f9773d31e2da66edfcb3cf6e636ef9a62187 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add some logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: add some logging .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17455/ -- To view, visit https://gerrit.ovirt.org/39314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebd6f9773d31e2da66edfcb3cf6e636ef9a62187 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/702/ -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add some logging
automat...@ovirt.org has posted comments on this change. Change subject: add some logging .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebd6f9773d31e2da66edfcb3cf6e636ef9a62187 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1261/ -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/694/ -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
automat...@ovirt.org has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17280/ -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network split network restoration from vdsmd, also on el6
oVirt Jenkins CI Server has posted comments on this change. Change subject: network split network restoration from vdsmd, also on el6 .. Patch Set 1: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17454/ -- To view, visit https://gerrit.ovirt.org/39313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8cfaecc3f1457aa928599473e589c8975ad4277 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
Yaniv Bronhaim has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
..
Patch Set 9:
(7 comments)
https://gerrit.ovirt.org/#/c/38281/9/lib/vdsm/tool/vdsm_dump_chains.py
File lib/vdsm/tool/vdsm_dump_chains.py:
> This should be named dump_volume_chains.py - same name exposed in vdsm-tool
please rename. it doesn't really matter but more appropriate. and why do we
need the vdsm prefix anyway?
Line 1: # Copyright 2015 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 27: from vdsm import vdscli
Line 28:
Line 29: # BLANK_UUID is re-declared here since it cannot be imported properly.
this
Line 30: # constant should be introduced under lib publically available
Line 31: _BLANK_UUID = '----'
move it to constants
Line 32: _NAME = 'dump-volume-chains'
Line 33: _USAGE = "usage: %s [options] " % (_NAME,)
Line 34:
Line 35:
Line 88: e.g: (BLANK_UUID<-a), (a<-b), (c<-d)"""
Line 89:
Line 90:
Line 91: @expose(_NAME)
Line 92: def main(*args):
function name can be dump_volume_chains
Line 93: """
Line 94: dump-volume-chains
Line 95: Query VDSM about the existing structure of image volumes and prints
Line 96: them in an ordered fashion with optional additional info per
volume.
Line 93: """
Line 94: dump-volume-chains
Line 95: Query VDSM about the existing structure of image volumes and prints
Line 96: them in an ordered fashion with optional additional info per
volume.
Line 97: """
you can validate if vdsmd is up before trying to connect
Line 98: try:
Line 99: options, args = _parse_args()
Line 100: sd_uuid, = args
Line 101: server = _connect_to_server(options)
Line 119:
Line 120:
Line 121: def _fail(error_msg):
Line 122: sys.stderr.write("vdsm-dump-chains: %s\n" % (error_msg,))
Line 123: sys.exit(1)
vdsm tool doesn't return exit code - it throws exception or return with 0
Line 124:
Line 125:
Line 126: def _parse_args():
Line 127: parser = optparse.OptionParser(_USAGE)
Line 136: args = sys.argv[2:] if 'vdsm-tool' in sys.argv[0] else
sys.argv[1:]
Line 137: options, args = parser.parse_args(args=args)
Line 138: if len(args) != 1:
Line 139: parser.error('sd_UUID is the only argument required.')
Line 140: return options, args
please use argparse instead. we use it everywhere under tool/
Line 141:
Line 142:
Line 143: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 144: res = _call_server(server.getVolumeInfo, sd_uuid, sp_uuid,
img_uuid,
Line 236: for vol in vol_chain:
Line 237: print('\t\t' + vol)
Line 238: if verbose:
Line 239: print("\t\tstatus: %(status)s, voltype:
%(voltype)s, "
Line 240: "format: %(format)s, legality:
%(legality)s, "
use sys.stdout.write instead of print
Line 241: "type: %(type)s" % (volumes_info[vol]))
Line 242:
Line 243:
Line 244: def _call_server(method, *args):
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vladik Romanovsky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Dary
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Pep8ize function name
Freddy Rolland has posted comments on this change. Change subject: hsm: Pep8ize function name .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54715971378319a8501a49cb89b24f27e50a07f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Restart supervdsmd service always and not only on-abort
Hello Yeela Kaplan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/39312 to review the following change. Change subject: Restart supervdsmd service always and not only on-abort .. Restart supervdsmd service always and not only on-abort Currently we restart the service only after SIGKILL (on-abort) but the desire behaviour should be always restarts when the process goes down. Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3 Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/39104 Reviewed-by: Yeela Kaplan Reviewed-by: Dan Kenigsberg --- M init/systemd/supervdsmd.service.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/39312/1 diff --git a/init/systemd/supervdsmd.service.in b/init/systemd/supervdsmd.service.in index 9d3fa7d..7a5e871 100644 --- a/init/systemd/supervdsmd.service.in +++ b/init/systemd/supervdsmd.service.in @@ -7,4 +7,4 @@ LimitCORE=infinity EnvironmentFile=-/etc/sysconfig/supervdsmd ExecStart=@VDSMDIR@/daemonAdapter "@VDSMDIR@/supervdsmServer" --sockfile "@VDSMRUNDIR@/svdsm.sock" -Restart=on-abort +Restart=always -- To view, visit https://gerrit.ovirt.org/39312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Restart supervdsmd service always and not only on-abort
Yaniv Bronhaim has posted comments on this change. Change subject: Restart supervdsmd service always and not only on-abort .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Restart supervdsmd service always and not only on-abort
automat...@ovirt.org has posted comments on this change. Change subject: Restart supervdsmd service always and not only on-abort .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28c01aab440d0af38cd6b2012e596e16a0a0ae3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Prevent systemd to kill dhclient once vdsm-network service is stopped When upgrading VDSM or for that matter, stopping vdsm-network process, systemd would kill all the descendants of the service (including dhclient). When vdsm-network starts again, it discovers /var/run/vdsm/nets_restored and does not restore any network, possibly leaving the system with interfaces that have an IP with a timer but no dhclient to renew it. Adding KillMode=Process tells systemd to only kill the service main process and nothing more. Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Bug-Url: https://bugzilla.redhat.com/1204782 Signed-off-by: Ido Barkan Reviewed-on: https://gerrit.ovirt.org/39137 Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39213 --- M init/systemd/vdsm-network.service.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
automat...@ovirt.org has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 2: * Update tracker::#1204782::OK * Set MODIFIED::bug 1204782#1204782IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 2: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/201/ -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 2: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/193/ -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 2: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/25/ -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Prevent systemd to kill dhclient once vdsm-network service i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Prevent systemd to kill dhclient once vdsm-network service is stopped .. Patch Set 2: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/201/ -- To view, visit https://gerrit.ovirt.org/39213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77d3448c2144b94194ccbe37995fcca008430dc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Wait for udev events after connect
Nir Soffer has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 1: I tested udev settle behavior again on el6 and el7, using tgt scsi server with 7 targets, each with different number of vgs and lvs test script: http://pastebin.com/yKcyB1Gf el6 results: http://pastebin.com/QvaUd11v el7 results: http://pastebin.com/JSTb7u2K Summary: connect: - el6 settle: 50-160 milliseconds - el7 settle: 100-320 milliseconds deactivate lvs: - el6 settle: 0-10 milliseconds - el7 settle: < 10 milliseconds disconnect: - el6 settle: 0-10 milliseconds - el7 settle: < 10 milliseconds I expected the settle time to be related to the lv count, but it seems unpredictable in practice. -- To view, visit https://gerrit.ovirt.org/39289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17279/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17453/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
Dima Kuznetsov has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 8: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17279/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 8: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17453/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
automat...@ovirt.org has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
Dima Kuznetsov has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Pep8ize function name
Ala Hino has posted comments on this change. Change subject: hsm: Pep8ize function name .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54715971378319a8501a49cb89b24f27e50a07f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/701/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17278/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17452/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1242/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17451/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 7: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17277/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/701/ -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17452/ -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1242/ -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/693/ -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 7: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17451/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17278/ -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1260/ -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
automat...@ovirt.org has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding Vdsm cron job check for available packages update
automat...@ovirt.org has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
