Change in vdsm[master]: functional tests: add basic device verification
Ido Barkan has posted comments on this change. Change subject: functional tests: add basic device verification .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38980/7/tests/verify.py File tests/verify.py: Line 20: Line 21: from virt.vmdevices import hwclass Line 22: Line 23: Line 24: class DeviceMixin(object): this class as it is now (simple and clean) can be reduced into a single verifyDevicesConf method that is a member of TestVmDevicesXmlParsing. Line 25: """ Line 26: Mixin that extends *TestCase class with method to verify device parsing Line 27: from libvirt XML. Line 28: """ -- To view, visit https://gerrit.ovirt.org/38980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ca6630ad047fbc1d9b036e1112bf5db41dc24d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual
Allon Mureinik has posted comments on this change. Change subject: monitor: return whether the reported status is actual .. Patch Set 4: ping? -- To view, visit https://gerrit.ovirt.org/38874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17659/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 13: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17830/ -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: ovirt-node: persist all ifcfg files created by vdsm
Francesco Romani has posted comments on this change. Change subject: network: ovirt-node: persist all ifcfg files created by vdsm .. Patch Set 1: I'm not familiar with this part of codebase, but I vividly remember that we're burned pretty badly by subtle differences between branches in the (even recent) past. When veryfing, please do separate ad independent verification on each branch. -- To view, visit https://gerrit.ovirt.org/39775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I658250a1ab430682209a9ee7f91e7c1ec2a9f43e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: ovirt-node: persist all ifcfg files created by vdsm
Francesco Romani has posted comments on this change.
Change subject: network: ovirt-node: persist all ifcfg files created by vdsm
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39772/2/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:
Line 543:
Line 544: # make sure that ifcfg files are always persisted by the node
Line 545: if self.unifiedPersistence and utils.isOvirtNode():
Line 546: node_fs.Config().persist(fileName)
Line 547:
So, in https://gerrit.ovirt.org/#/c/36985/ we had inconsisten data, and we
resolved the inconsistency by making sure everythin UN-persisted. That fixed
the inconsistency.
I see why you want to persist the config, but is this safe consistency-wise?
How can we make sure of that?
Line 548: logging.debug('Writing to file %s configuration:\n%s',
fileName,
Line 549: configuration)
Line 550: with open(fileName, 'w') as confFile:
Line 551: confFile.write(configuration)
--
To view, visit https://gerrit.ovirt.org/39772
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I658250a1ab430682209a9ee7f91e7c1ec2a9f43e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Lior Vernia
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Ido Barkan has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 13: let's merge this one as is and then fix the bug on device reporting based on getUnderlying* unit tests patch. -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
automat...@ovirt.org has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. .. Patch Set 13: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17659/ -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Ido Barkan has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/38249/12/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 111: vlan.appendChildWithArgs('tag', id=str(self.vlanId))
Line 112:
Line 113: return interface
Line 114:
Line 115: def _add_source_pci_address(self, parent_element, type=None):
> This is a lie: we're adding source address, nothing says that it is PCI. Re
Done
Line 116: parent_element.appendChildWithArgs('address', type=type,
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: better logging on network restoration.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: better logging on network restoration. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2860/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17658/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0241e7379f799e65bbeba3e13a288e52e5dbc734 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rename variables to be consistent in vdsm-restore-net-config
oVirt Jenkins CI Server has posted comments on this change. Change subject: rename variables to be consistent in vdsm-restore-net-config .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2859/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17657/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fcd57818ecf75a502d56f2e76e7edd0350a656f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: better logging on network restoration.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: better logging on network restoration. .. Patch Set 2: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2860/ -- To view, visit https://gerrit.ovirt.org/39214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0241e7379f799e65bbeba3e13a288e52e5dbc734 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: better logging on network restoration.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: better logging on network restoration. .. Patch Set 2: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17658/ -- To view, visit https://gerrit.ovirt.org/39214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0241e7379f799e65bbeba3e13a288e52e5dbc734 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rename variables to be consistent in vdsm-restore-net-config
oVirt Jenkins CI Server has posted comments on this change. Change subject: rename variables to be consistent in vdsm-restore-net-config .. Patch Set 2: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17828/ -- To view, visit https://gerrit.ovirt.org/39215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fcd57818ecf75a502d56f2e76e7edd0350a656f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: better logging on network restoration.
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: better logging on network restoration. .. Patch Set 2: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17829/ -- To view, visit https://gerrit.ovirt.org/39214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0241e7379f799e65bbeba3e13a288e52e5dbc734 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rename variables to be consistent in vdsm-restore-net-config
oVirt Jenkins CI Server has posted comments on this change. Change subject: rename variables to be consistent in vdsm-restore-net-config .. Patch Set 2: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2859/ -- To view, visit https://gerrit.ovirt.org/39215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fcd57818ecf75a502d56f2e76e7edd0350a656f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rename variables to be consistent in vdsm-restore-net-config
oVirt Jenkins CI Server has posted comments on this change. Change subject: rename variables to be consistent in vdsm-restore-net-config .. Patch Set 2: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17657/ -- To view, visit https://gerrit.ovirt.org/39215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fcd57818ecf75a502d56f2e76e7edd0350a656f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rename variables to be consistent in vdsm-restore-net-config
automat...@ovirt.org has posted comments on this change. Change subject: rename variables to be consistent in vdsm-restore-net-config .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fcd57818ecf75a502d56f2e76e7edd0350a656f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: better logging on network restoration.
automat...@ovirt.org has posted comments on this change. Change subject: network: better logging on network restoration. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0241e7379f799e65bbeba3e13a288e52e5dbc734 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Handle gluster exceptions in json rpc mode.
Darshan N has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Handle gluster exceptions in json rpc mode.
Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/39788 to review the following change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. gluster: Handle gluster exceptions in json rpc mode. This patch adds code to handle gluster exceptions in JSON rpc mode. Earlier gluster exceptions were not propagated properly in json rpc mode. Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Bug-Url: https://bugzilla.redhat.com/1207150 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/39573 Reviewed-by: Piotr Kliczewski Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg --- M vdsm/rpc/Bridge.py 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/39788/1 diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py index c964741..746df7c 100644 --- a/vdsm/rpc/Bridge.py +++ b/vdsm/rpc/Bridge.py @@ -27,6 +27,7 @@ try: import gluster.apiwrapper as gapi +import gluster.exception as ge _glusterEnabled = True except ImportError: _glusterEnabled = False @@ -261,7 +262,13 @@ else: fn = getattr(api, methodName) try: -result = fn(*methodArgs) +if _glusterEnabled: +try: +result = fn(*methodArgs) +except ge.GlusterException as e: +result = e.response() +else: +result = fn(*methodArgs) except TypeError as e: raise InvalidCall(fn, methodArgs, e) -- To view, visit https://gerrit.ovirt.org/39788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Handle gluster exceptions in json rpc mode.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 1: * Update tracker::#1207150::OK * Check Bug-Url::OK * Check Public Bug::#1207150::OK, public bug * Check Product::#1207150::OK, Correct product oVirt * Check TR::#1207150::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/39788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak crossImportsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak crossImportsTests .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17656/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak crossImportsTests
Ido Barkan has posted comments on this change. Change subject: unbreak crossImportsTests .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak crossImportsTests
Ido Barkan has uploaded a new change for review. Change subject: unbreak crossImportsTests .. unbreak crossImportsTests get_python_lib(plat_specific=True) returns /usr/lib64/python2.7/site-packages which is no longer true for vdsm installations. Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Signed-off-by: Ido Barkan --- M tests/crossImportsTests.py.in 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/39784/1 diff --git a/tests/crossImportsTests.py.in b/tests/crossImportsTests.py.in index 0cca887..a3e1d81 100644 --- a/tests/crossImportsTests.py.in +++ b/tests/crossImportsTests.py.in @@ -49,7 +49,6 @@ if os.path.exists(src_dir): mods = get_mods(src_dir) else: -mods = get_mods(os.path.join( -get_python_lib(plat_specific=True), pkg_name)) +mods = get_mods(os.path.join(get_python_lib(), pkg_name)) __import__(pkg_name, fromlist=mods) -- To view, visit https://gerrit.ovirt.org/39784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak crossImportsTests
automat...@ovirt.org has posted comments on this change. Change subject: unbreak crossImportsTests .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak crossImportsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak crossImportsTests .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17827/ -- To view, visit https://gerrit.ovirt.org/39784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak crossImportsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak crossImportsTests .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17656/ -- To view, visit https://gerrit.ovirt.org/39784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic879e605a3328d0d69f397d79b28bb2508ec44b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/42/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/212/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 5: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/212/ -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/41/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/211/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
Ido Barkan has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 2: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/39779/2/contrib/shell_helper File contrib/shell_helper: Line 83 Line 84 Line 85 Line 86 Line 87 > Maybe it is worth dropping the NOSE_EXCLUDE too? building RPMs without runn generally true. but those are just developers tools used to speed up dev-test cycle, nothing more. I can maybe add a vdsm_build_test() function later. -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
oVirt Jenkins CI Server has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/40/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/210/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 6: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/211/ -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/39/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/209/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
oVirt Jenkins CI Server has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 6: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/210/ -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 5: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/42/ -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 5: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/218/ -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 5: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/217/ -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 6: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/41/ -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 5: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/209/ -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/38/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/208/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 6: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/217/ -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 6: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/216/ -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
oVirt Jenkins CI Server has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 6: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/40/ -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
oVirt Jenkins CI Server has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 6: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/216/ -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
oVirt Jenkins CI Server has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 6: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/215/ -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/37/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/207/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 5: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/39/ -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 5: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/208/ -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 5: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/215/ -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
oVirt Jenkins CI Server has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 5: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/214/ -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 5: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/214/ -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 5: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/38/ -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 5: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/213/ -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
Yaniv Bronhaim has submitted this change and it was merged. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. udevadm: Handle errors and timeouts in udevadm.settle() In commit 4c10d3d10c (multipath: Wait for udev events after rescan) we started to invoke udevadm.settle() during multipath.rescan(). Since rescan is performed in the storageRefresh thread, and we did not handle exceptions, a timeout in udevadm.settle() will cause HSM initialization to fail and leave vdsm in "initializing" state. udev timeout behavior is undocumented. Looking into the code, we found two types of logic: - On el6, el7 and f20, if timeout occurs, rc=1 and timeout info printed to stdout - On f21, timeout is ignored. We opened bz for udev to fix this: https://bugzilla.redhat.com/1209474 Handling the errors in settle() rather than propagating them seems more useful because we do not want to fail the entire operation only because udev fails to wait for events. This is the same behavior implemented in hba.rescan. Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Bug-Url: https://bugzilla.redhat.com/1209028 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/39594 Reviewed-by: Allon Mureinik Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland Reviewed-by: Federico Simoncelli Reviewed-on: https://gerrit.ovirt.org/39630 Reviewed-by: Yaniv Bronhaim --- M vdsm/storage/udevadm.py 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
automat...@ovirt.org has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 5: * Update tracker::#1209028::OK * Set MODIFIED::bug 1209028#1209028IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Handle errors and timeouts in udevadm.settle()
Yaniv Bronhaim has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 6: * Update tracker::#1209028::OK * Set MODIFIED::bug 1209028#1209028IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
Yaniv Bronhaim has posted comments on this change. Change subject: tests: Fix RescanTimeoutsTests .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix RescanTimeoutsTests
Yaniv Bronhaim has submitted this change and it was merged. Change subject: tests: Fix RescanTimeoutsTests .. tests: Fix RescanTimeoutsTests In commit 4c10d3d10c (multipath: Wait for udev events after rescan) I removed unneeded and badly implemented minimal timeout, and the unneeded optional arguments in iscsi.rescan() but forgot to update the tests. In this patch: - remove the now unneeded and broken test for minimal timeout (the test was passing while the code was broken) - simplify the testing infrastructure - instead of passing arguments to rescan, monkey-patch the config. - use safe monkey-patching. - use monotonic_time - use real process so we get SIGCHLD when the scan is finished; otherwise, the tests may pass while the code is broken - add test for normal operation make_config and monotonic_time defined locally in the test because they don't exist on ovirt 3.5 branch. Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Bug-Url: https://bugzilla.redhat.com/1209028 Signed-off-by: Nir Soffer Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/39422 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39609 Reviewed-by: Allon Mureinik Reviewed-by: Yaniv Bronhaim --- M tests/iscsiTests.py 1 file changed, 30 insertions(+), 56 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/39609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I308c73eb7059053aa91bf15957cf9029234b37d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
Yaniv Bronhaim has submitted this change and it was merged. Change subject: drop needless import to make pylakes happy .. drop needless import to make pylakes happy should have been part of commit 4c10d3d10. iscsiTests.RescanTimeoutTests is to be fixed in another patch. Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Bug-Url: https://bugzilla.redhat.com/1209028 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39405 Reviewed-on: https://gerrit.ovirt.org/39608 Reviewed-by: Allon Mureinik Reviewed-by: Nir Soffer Tested-by: Ala Hino Reviewed-by: Yaniv Bronhaim --- M vdsm/storage/iscsi.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
automat...@ovirt.org has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 6: * Update tracker::#1209028::OK * Set MODIFIED::bug 1209028#1209028IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: drop needless import to make pylakes happy
Yaniv Bronhaim has posted comments on this change. Change subject: drop needless import to make pylakes happy .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0d48642c86e2452485e161428fc88c16002e78 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
Yaniv Bronhaim has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 5: * Update tracker::#1209028::OK * Set MODIFIED::bug 1209028#1209028IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
Yaniv Bronhaim has submitted this change and it was merged. Change subject: multipath: Wait for udev events after rescan .. multipath: Wait for udev events after rescan Previously we were using time.sleep(2) for waiting at least 2 seconds after starting iSCSI sessions rescan. This wait was useless for two reasons: - The sleep was interrupted as soon as iscsiadm process terminated - Udev events generated by the SCSI scan and by processing udev rules may not been handled yet when iscsiadm existed. This patch replaces the minimal scsi timeout with udevadm.settle(), waiting until current udev events are handled. Since we perform both FC and iSCSI scan, the correct place for waiting is in multipath.rescan() and not in iscsi.rescan(). A new configuration was introduced, allowing fine tuning of settle timeout in the field. [irs] scsi_settle_timeout = 5 Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Bug-Url: https://bugzilla.redhat.com/1209028 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/39288 Reviewed-by: Douglas Schilling Landgraf Tested-by: Douglas Schilling Landgraf Reviewed-by: Allon Mureinik Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39606 Tested-by: Ala Hino Reviewed-by: Yaniv Bronhaim --- M lib/vdsm/config.py.in M vdsm/storage/iscsi.py M vdsm/storage/multipath.py 3 files changed, 17 insertions(+), 25 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
automat...@ovirt.org has posted comments on this change. Change subject: storageServer: Wait for udev events after connect .. Patch Set 5: * Update tracker::#1209028::OK * Set MODIFIED::bug 1209028#1209028IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 5: Build Started (3/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/213/ -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
Yaniv Bronhaim has submitted this change and it was merged. Change subject: udevadm: Add udevadm wrapper .. udevadm: Add udevadm wrapper Add udevadm wrapper for running udevadm tool. In the current version the wrapper implement only the settle() command, which should be used to wait for events after modifying scsi connections. Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Bug-Url: https://bugzilla.redhat.com/1209028 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/39287 Reviewed-by: Douglas Schilling Landgraf Tested-by: Douglas Schilling Landgraf Reviewed-by: Allon Mureinik Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39605 Tested-by: Ala Hino Reviewed-by: Yaniv Bronhaim --- M debian/vdsm.install M vdsm.spec.in M vdsm/storage/Makefile.am A vdsm/storage/udevadm.py 4 files changed, 67 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 5: Build Started (2/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/37/ -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: storageServer: Wait for udev events after connect
Yaniv Bronhaim has submitted this change and it was merged. Change subject: storageServer: Wait for udev events after connect .. storageServer: Wait for udev events after connect Connecting to iSCSI target starts a storm of udev events, that may not be handled yet when iscsiadm terminates. This may lead to missing devices and failures when creating storage domain. Now we wait until current udev events are handled after connecting, using new udevadm.settle(). The timeout can be configured using the new irs:scsi_settle_timeout option. Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Bug-Url: https://bugzilla.redhat.com/1209028 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/39289 Reviewed-by: Douglas Schilling Landgraf Tested-by: Douglas Schilling Landgraf Reviewed-by: Allon Mureinik Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39607 Tested-by: Ala Hino Reviewed-by: Yaniv Bronhaim --- M vdsm/storage/storageServer.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/39607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b2043dc4ac410cf08c7b49b6435a818f20d995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 5: Build Started (4/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/207/ -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan
Yaniv Bronhaim has posted comments on this change. Change subject: multipath: Wait for udev events after rescan .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
automat...@ovirt.org has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 5: * Update tracker::#1209028::OK * Set MODIFIED::bug 1209028#1209028IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 5: Build Started (1/4) -> http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/212/ -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: udevadm: Add udevadm wrapper
Yaniv Bronhaim has posted comments on this change. Change subject: udevadm: Add udevadm wrapper .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb83b2ff4dd6aeffd20db0697a4983bc1e949232 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clusterLock: Acquire, release, and inquire volume leases
Nir Soffer has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases
..
Patch Set 8:
(2 comments)
Mostly ok, but if we add new api, we need to rename to old api so both of them
make sense. Since this not public api, there is no reason to keep the old names.
I think we should have:
- acquireClusterLock
- releaseClusterLock
- inquireClusterLock
- acquireResource
- releaseResource
- inquireResource
What do you think?
https://gerrit.ovirt.org/#/c/38622/8/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:
Line 297: # timestamp, sanlock will return HOST_UNKNOWN and then
HOST_LIVE or
Line 298: # HOST_FAIL.
Line 299: return HOST_STATUS_FREE
Line 300:
Line 301: def _acquire(self, resource, lockDisk, shared=False):
Please move _private method to the end of the class, or to the end of the
section using the private method. It should be easy to understand what is the
public interface of the class by reading the code from top to bottom.
Line 302: with nested(self._lock, SANLock._sanlock_lock):
Line 303: self.log.info("Acquiring resource %s, shared=%s",
resource, shared)
Line 304:
Line 305: while True:
Line 337:"(id: %s)", self._sdUUID, hostId)
Line 338:
Line 339: def acquireResource(self, resource, lockDisk, shared=False):
Line 340: self._acquire(resource, lockDisk, shared)
Line 341: res, owners = self._inquire(resource, lockDisk)
Why do we need to call _inquire() here?
Add same logging as in acquire before and after the operation.
Line 342:
Line 343: def _inquire(self, resource, lockDisk):
Line 344: res = sanlock.read_resource(*lockDisk[0])
Line 345: owners = sanlock.read_resource_owners(self._sdUUID, resource,
lockDisk)
--
To view, visit https://gerrit.ovirt.org/38622
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca901ccd27358767c023cd55b7a3823531d2a5a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
Allon Mureinik has posted comments on this change.
Change subject: spec: clean up selinux requirement
..
Patch Set 1:
The Jenkins failure seems to be an environmental issue accessing gluster RPMS:
DEBUG util.py:518: child environment: None
DEBUG util.py:452: Executing command: ['/usr/bin/yum', '--installroot',
'/home/jenkins/workspace/vdsm_master_install-rpm-sanity-fc22_created/mock/fedora-22-x86_64-ovirt-snapshot/root/',
'--releasever', '22', 'install', '@buildsys-build',
'--setopt=tsflags=nocontexts'] with env {'LANG': 'en_US.UTF-8', 'TERM':
'vt100', 'SHELL': '/bin/bash', 'LC_MESSAGES': 'C', 'HOSTNAME': 'mock', 'PATH':
'/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf
"\x1b]0;\x07"', 'HOME': '/builddir', 'CCACHE_DIR':
'/tmp/ccache', 'CCACHE_UMASK': '002'} and shell False
DEBUG util.py:388:
http://download.gluster.org/pub/gluster//glusterfs/nightly/glusterfs/fedora-22-x86_64/repodata/repomd.xml:
[Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:388: Trying other mirror.
DEBUG util.py:388: One of the configured repositories failed
(glusterfs-fedora-nightly),
DEBUG util.py:388: and yum doesn't have enough cached data to continue. At
this point the only
DEBUG util.py:388: safe thing yum can do is fail. There are a few ways to
work "fix" this:
DEBUG util.py:388: 1. Contact the upstream for the repository and get
them to fix the problem.
DEBUG util.py:388: 2. Reconfigure the baseurl/etc. for the repository, to
point to a working
DEBUG util.py:388: upstream. This is most often useful if you are
using a newer
DEBUG util.py:388: distribution release than is supported by the
repository (and the
DEBUG util.py:388: packages for the previous distribution release
still work).
DEBUG util.py:388: 3. Disable the repository, so yum won't use it by
default. Yum will then
DEBUG util.py:388: just ignore the repository until you permanently
enable it again or use
DEBUG util.py:388: --enablerepo for temporary usage:
DEBUG util.py:388: yum-config-manager --disable
glusterfs-fedora-nightly
DEBUG util.py:388: 4. Configure the failing repository to be skipped, if
it is unavailable.
DEBUG util.py:388: Note that yum will try to contact the repo. when it
runs most commands,
DEBUG util.py:388: so will have to try and fail each time (and thus.
yum will be be much
DEBUG util.py:388: slower). If it is a very temporary problem though,
this is often a nice
DEBUG util.py:388: compromise:
DEBUG util.py:388: yum-config-manager --save
--setopt=glusterfs-fedora-nightly.skip_if_unavailable=true
DEBUG util.py:388: failure: repodata/repomd.xml from glusterfs-fedora-nightly:
[Errno 256] No more mirrors to try.
DEBUG util.py:388:
http://download.gluster.org/pub/gluster//glusterfs/nightly/glusterfs/fedora-22-x86_64/repodata/repomd.xml:
[Errno 14] HTTP Error 404 - Not Found
DEBUG util.py:499: Child return code was: 1
DEBUG util.py:183: kill orphans
DEBUG util.py:518: child environment: None
Please ignore.
--
To view, visit https://gerrit.ovirt.org/39771
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cover all vdsm external hooks under with_hooks flag
Yaniv Bronhaim has abandoned this change. Change subject: Cover all vdsm external hooks under with_hooks flag .. Abandoned -- To view, visit https://gerrit.ovirt.org/37964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id5a844d221c94936e89737d9ab496c307b20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Cover all vdsm external hooks under with_hooks flag
automat...@ovirt.org has posted comments on this change. Change subject: Cover all vdsm external hooks under with_hooks flag .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/37964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5a844d221c94936e89737d9ab496c307b20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/38559/12/vdsm/API.py
File vdsm/API.py:
Line 1316: for pkgInfo in updates:
Line 1317: if packages is None or pkgInfo['name'] in
frozenset(packages):
Line 1318: info['updates'].append(pkgInfo)
Line 1319:
Line 1320: info['last-check'] = datetime.datetime.fromtimestamp(
the only problem with that is that I don't know how to add it into the schema
.. couldn't find anything like that. almost all verbs we return a list with one
type
Line 1321: os.path.getmtime(update_file))
Line 1322: return {'status': doneCode, 'info': info}
Line 1323: except:
Line 1324: self.log.error("failed to read update info",
exc_info=True)
--
To view, visit https://gerrit.ovirt.org/38559
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Moti Asayag
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: export volume lease state in getVolumeInfo
Freddy Rolland has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 8: Code-Review+1 (2 comments) Minor comments in schema https://gerrit.ovirt.org/#/c/38623/8/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 7945: 4.10.0 Should it be 4.17.0 ? Line 7990: lease Add : (new in version 4.17) -- To view, visit https://gerrit.ovirt.org/38623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55f062a4be15593fdc98518fd0a113976cbe0ae7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17826/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17655/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 12: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17655/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 12: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17826/ -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
automat...@ovirt.org has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Michal Skrivanek has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/36701/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 132: client_socket = self._createSocket(port)
Line 133: self._destServer = jsonrpcvdscli.connect(self._vm.cif,
Line 134: client_socket)
Line 135: self.log.debug('Initiating connection with destination')
Line 136: self._destServer.ping()
just please confirm that the jsonrpcvdscli.connect() doesn't actually connect
to the other side. If yes then we can drop the ping(), if not and this is the
only way how to figure out the connection is established then we can keep the
ping()
Line 137:
Line 138: except Exception:
Line 139: if config.getboolean('vars', 'ssl'):
Line 140: self._destServer = vdscli.connect(
--
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17654/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17824/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17653/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17825/ -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: change destServer attribute to private
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: change destServer attribute to private .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17823/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17652/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a12439ec15110909706038d31f2a2900fe8c17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 6: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17824/ -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17651/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: change destServer attribute to private
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: change destServer attribute to private .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17823/ -- To view, visit https://gerrit.ovirt.org/39204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a12439ec15110909706038d31f2a2900fe8c17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17650/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
oVirt Jenkins CI Server has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17822/ -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17820/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17649/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
oVirt Jenkins CI Server has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17821/ -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
