Change in vdsm[master]: [wip] Move passwd (set saslpassword for libvirt) to vdsm-tool
automat...@ovirt.org has posted comments on this change. Change subject: [wip] Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 1: * Update tracker::#1169338::OK * Check Bug-Url::OK * Check Public Bug::#1169338::OK, public bug * Check Product::#1169338::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] Move passwd (set saslpassword for libvirt) to vdsm-tool
Yaniv Bronhaim has uploaded a new change for review.
Change subject: [wip] Move passwd (set saslpassword for libvirt) to vdsm-tool
..
[wip] Move passwd (set saslpassword for libvirt) to vdsm-tool
- still wip - check isconfigure status using sasldblistusers2
- fix all calls
- was not verified
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1169338
Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/tool/Makefile.am
M lib/vdsm/tool/configurators/Makefile.am
R lib/vdsm/tool/configurators/passwd.py
M vdsm.spec.in
4 files changed, 5 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/39823/1
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index 434a064..1e85ac4 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -45,7 +45,6 @@
nwfilter.py \
configfile.py \
configurator.py \
- passwd.py \
restore_nets.py \
service.py \
transient.py \
diff --git a/lib/vdsm/tool/configurators/Makefile.am
b/lib/vdsm/tool/configurators/Makefile.am
index b4fad1d..9fc7e57 100644
--- a/lib/vdsm/tool/configurators/Makefile.am
+++ b/lib/vdsm/tool/configurators/Makefile.am
@@ -24,6 +24,7 @@
certificates.py \
libvirt.py \
multipath.py \
+ passwd.py \
sanlock.py \
sebool.py \
$(NULL)
diff --git a/lib/vdsm/tool/passwd.py b/lib/vdsm/tool/configurators/passwd.py
similarity index 87%
rename from lib/vdsm/tool/passwd.py
rename to lib/vdsm/tool/configurators/passwd.py
index d490197..249ed47 100644
--- a/lib/vdsm/tool/passwd.py
+++ b/lib/vdsm/tool/configurators/passwd.py
@@ -22,19 +22,14 @@
from .. import constants
from .. import utils
-from . import expose, ExtraArgsError
+def isconfigured():
-@expose("set-saslpasswd")
-def set_saslpasswd(*args):
+def configure():
"""
set-saslpasswd
Set vdsm password for libvirt connection
"""
-
-if len(args) > 1:
-raise ExtraArgsError()
-
script = [constants.EXT_SASLPASSWD2, '-p', '-a', 'libvirt',
constants.SASL_USERNAME]
@@ -53,15 +48,10 @@
raise RuntimeError("Set password failed: %s" % (err,))
-@expose("remove-saslpasswd")
-def remove_saslpasswd(*args):
+def removeConf():
"""
Remove vdsm password for libvirt connection
"""
-
-if args[1:]:
-raise ExtraArgsError()
-
rc, out, err = utils.execCmd(
(
constants.EXT_SASLPASSWD2,
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 873c30a..7da7fd0 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1373,11 +1373,11 @@
%{python_sitelib}/%{vdsm_name}/tool/configurators/__init__*
%{python_sitelib}/%{vdsm_name}/tool/configurators/certificates.py*
%{python_sitelib}/%{vdsm_name}/tool/configurators/libvirt.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/passwd.py*
%{python_sitelib}/%{vdsm_name}/tool/configurators/sanlock.py*
%{python_sitelib}/%{vdsm_name}/tool/configurators/sebool.py*
%{python_sitelib}/%{vdsm_name}/tool/configurators/multipath.py*
%{python_sitelib}/%{vdsm_name}/tool/dump_volume_chains.py*
-%{python_sitelib}/%{vdsm_name}/tool/passwd.py*
%{python_sitelib}/%{vdsm_name}/tool/restore_nets.py*
%{python_sitelib}/%{vdsm_name}/tool/service.py*
%{python_sitelib}/%{vdsm_name}/tool/transient.py*
--
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Handle gluster exceptions in json rpc mode.
Yaniv Bronhaim has submitted this change and it was merged. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. gluster: Handle gluster exceptions in json rpc mode. This patch adds code to handle gluster exceptions in JSON rpc mode. Earlier gluster exceptions were not propagated properly in json rpc mode. Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Bug-Url: https://bugzilla.redhat.com/1207150 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/39573 Reviewed-by: Piotr Kliczewski Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/39788 Reviewed-by: Yaniv Bronhaim --- M vdsm/rpc/Bridge.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/39788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Handle gluster exceptions in json rpc mode.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 2: * Update tracker::#1207150::OK * Check TR::#1207150::OK * Set MODIFIED::bug 1207150#1207150OK -- To view, visit https://gerrit.ovirt.org/39788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gluster: Handle gluster exceptions in json rpc mode.
Yaniv Bronhaim has posted comments on this change. Change subject: gluster: Handle gluster exceptions in json rpc mode. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215a716369bac8d31a5d208b13f1dd73bd3bf7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: functional tests: add basic device verification
Ido Barkan has posted comments on this change. Change subject: functional tests: add basic device verification .. Patch Set 7: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/38980/7/tests/verify.py File tests/verify.py: Line 20: Line 21: from virt.vmdevices import hwclass Line 22: Line 23: Line 24: class DeviceMixin(object): > Since this method is meant to be used by XML and non-xml tests, I don't bel ok Line 25: """ Line 26: Mixin that extends *TestCase class with method to verify device parsing Line 27: from libvirt XML. Line 28: """ -- To view, visit https://gerrit.ovirt.org/38980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ca6630ad047fbc1d9b036e1112bf5db41dc24d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
Ido Barkan has posted comments on this change. Change subject: dump-volume-chains: Nicer output when no volumes found .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (9/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/14/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (10/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/869/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (8/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/873/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/867/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/458/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/835/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/453/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/869/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/467/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/12/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/12/ : SUCCESS http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_merged/31/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (12/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/868/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (7/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/460/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (6/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/837/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (11/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/13/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (5/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/469/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (4/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/455/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (3/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/871/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (10/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/872/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (9/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/459/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (8/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/13/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (7/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/464/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (6/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/836/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (5/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/468/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (4/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/454/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (3/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/870/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (2/12) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_merged/33/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
automat...@ovirt.org has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
Dan Kenigsberg has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 1: Code-Review+2 Doh! -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: clean up selinux requirement .. spec: clean up selinux requirement While spec files support the syntax of package_name >= package_name-version, it's ugly and doesn't follow the standards of vdsm's spec file. This patch cleans up the bad form used for selinux's requirement. Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Signed-off-by: Allon Mureinik Reviewed-on: https://gerrit.ovirt.org/39771 Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: clean up selinux requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Build Started (1/12) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4846/ -- To view, visit https://gerrit.ovirt.org/39771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id063a6bed3e8c2198c1f68473fa6d1282f94d54f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (2/12) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_merged/32/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
automat...@ovirt.org has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
oVirt Jenkins CI Server has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 3: Build Started (1/12) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4845/ -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
Dan Kenigsberg has submitted this change and it was merged. Change subject: shell_helper: remove unneeded build statements .. shell_helper: remove unneeded build statements Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Signed-off-by: Ido Barkan Reviewed-on: https://gerrit.ovirt.org/39779 Reviewed-by: Dima Kuznetsov Reviewed-by: Dan Kenigsberg --- M contrib/shell_helper 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ido Barkan: Verified Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: remove unneeded build statements
Dan Kenigsberg has posted comments on this change. Change subject: shell_helper: remove unneeded build statements .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7953c9eefe5e2fb8dfd01450ff52368a83a9c77d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (7/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/467/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (12/12) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_merged/31/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (6/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/869/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (11/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/12/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (9/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/12/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (1/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/458/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (2/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/867/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (8/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/835/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (10/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/453/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (5/12) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/463/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
automat...@ovirt.org has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (4/12) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/871/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. Patch Set 4: Build Started (3/12) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4844/ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm_hooks: always build vmfex_dev (regardless of --enable-h...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) .. vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) This makes the hook shipped by default with VDSM rpm. Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Signed-off-by: Ondřej Svoboda Reviewed-on: https://gerrit.ovirt.org/39387 Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in M vdsm_hooks/Makefile.am 2 files changed, 15 insertions(+), 8 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 21:
(2 comments)
https://gerrit.ovirt.org/#/c/37509/21/vdsm/v2v.py
File vdsm/v2v.py:
Line 337: try:
Line 338: self._proc.kill()
Line 339: except OSError as e:
Line 340: if e.errno != errno.ESRCH:
Line 341: raise
If we raise here...
Line 342: logging.debug('Job %r virt-v2v process is not running'
Line 343: ' (pid: %d)', self._id, self._proc.pid)
Line 344: finally:
Line 345: if not
self._proc.wait(timeout=self.PROC_WAIT_TIMEOUT):
Line 341: raise
Line 342: logging.debug('Job %r virt-v2v process is not running'
Line 343: ' (pid: %d)', self._id, self._proc.pid)
Line 344: finally:
Line 345: if not
self._proc.wait(timeout=self.PROC_WAIT_TIMEOUT):
There is no point in waiting here.
Lets remove the wait - kill the process and pass it to zombiereaper which will
wait for us. The finally block is here to ensure that we never leave zombies
after an import.
Line 346: logging.warn('Job %r wait timeout (pid=%d),'
Line 347: ' moving to zombie reaper',
Line 348: self._id, self._proc.pid)
Line 349: zombiereaper.autoReapPID(self._proc.pid)
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
Nir Soffer has posted comments on this change. Change subject: dump-volume-chains: Nicer output when no volumes found .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
oVirt Jenkins CI Server has posted comments on this change. Change subject: dump-volume-chains: Nicer output when no volumes found .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17675/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
Nir Soffer has uploaded a new change for review.
Change subject: dump-volume-chains: Nicer output when no volumes found
..
dump-volume-chains: Nicer output when no volumes found
When no volumes found, print clear message instead of title and no
output:
$ vdsm-tool dump-volume-chains ce362d37-ba2f-47c4-b46c-d71ee24019a8
(no images found)
Change-Id: I65cc0def2b17155e361271c80050cd098678c392
Signed-off-by: Nir Soffer
---
M lib/vdsm/tool/dump_volume_chains.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/39813/1
diff --git a/lib/vdsm/tool/dump_volume_chains.py
b/lib/vdsm/tool/dump_volume_chains.py
index 6c5b8d4..25dd34f 100644
--- a/lib/vdsm/tool/dump_volume_chains.py
+++ b/lib/vdsm/tool/dump_volume_chains.py
@@ -202,6 +202,11 @@
def _print_volume_chains(image_chains, volumes_info):
+if not image_chains:
+print()
+_print_line("(no images found)")
+print()
+return
print()
print('Images volume chains (base volume first)')
for img_uuid, vol_chain in image_chains.iteritems():
--
To view, visit https://gerrit.ovirt.org/39813
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
oVirt Jenkins CI Server has posted comments on this change. Change subject: dump-volume-chains: Nicer output when no volumes found .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17675/ -- To view, visit https://gerrit.ovirt.org/39813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
automat...@ovirt.org has posted comments on this change. Change subject: dump-volume-chains: Nicer output when no volumes found .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump-volume-chains: Nicer output when no volumes found
oVirt Jenkins CI Server has posted comments on this change. Change subject: dump-volume-chains: Nicer output when no volumes found .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17846/ -- To view, visit https://gerrit.ovirt.org/39813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65cc0def2b17155e361271c80050cd098678c392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17845/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17674/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17845/ -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17674/ -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 2: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17840/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17669/ : UNSTABLE -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17673/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17844/ -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: add support for scsi devices
..
hostdev: add support for scsi devices
In order to support SCSI passthrough, we only have to pass SCSI hostdev
compilant XML. This patch parses device info to construct correct XML.
Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0
Signed-off-by: Martin Polednik
---
M vdsm/hostdev.py
M vdsm/virt/vmdevices/hostdevice.py
2 files changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/39809/1
diff --git a/vdsm/hostdev.py b/vdsm/hostdev.py
index 80312dd..298c795 100644
--- a/vdsm/hostdev.py
+++ b/vdsm/hostdev.py
@@ -29,6 +29,15 @@
'usb_device': 'usb'}
+def _scsi_address_to_xml_compatible(address):
+return {'bus': address['bus'], 'unit': address['lun'],
+'target': address['target']}
+
+ADDRESS_TO_XML = {'pci': lambda x: x,
+ 'usb_device': lambda x: x,
+ 'scsi': _scsi_address_to_xml_compatible}
+
+
def _name_to_pci_path(device_name):
return device_name[4:].replace('_', '.').replace('.', ':', 2)
diff --git a/vdsm/virt/vmdevices/hostdevice.py
b/vdsm/virt/vmdevices/hostdevice.py
index eb43d6e..f293423 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -19,7 +19,7 @@
#
from hostdev import get_device_params, detach_detachable, \
-CAPABILITY_TO_XML_ATTR
+CAPABILITY_TO_XML_ATTR, ADDRESS_TO_XML
from . import core
from . import hwclass
@@ -54,18 +54,25 @@
"""
+capability = CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']]
+
hostdev = self.createXmlElem(hwclass.HOSTDEV, None)
hostdev.setAttrs(
-managed='no', mode='subsystem',
-type=CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']])
+managed='no', mode='subsystem', type=capability)
source = hostdev.appendChildWithArgs('source')
if hasattr(self, 'bootOrder'):
hostdev.appendChildWithArgs(
'boot', order=self.bootOrder)
-source.appendChildWithArgs('address', None,
-**self._deviceParams['address'])
+source.appendChildWithArgs(
+'address', None,
+**ADDRESS_TO_XML[capability](self._deviceParams['address']))
+
+if capability == 'scsi':
+source.appendChildWithArgs(
+'adapter', None, name='scsi_host{}'.format(
+self._deviceParams['address']['host']))
if hasattr(self, 'address'):
hostdev.appendChildWithArgs('address', None, **self.address)
--
To view, visit https://gerrit.ovirt.org/39809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17673/ -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for scsi devices
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add support for scsi devices .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ac40dfcdccf666bfbe0df5c1fbe5c64aabcdf0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: only detect IOMMU group for PCI devices
Martin Polednik has posted comments on this change. Change subject: hostdev: only detect IOMMU group for PCI devices .. Patch Set 1: Verified+1 Corrects possible KeyErrors, no change in functionality otherwise. -- To view, visit https://gerrit.ovirt.org/39807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 3: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17672/ : UNSTABLE -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: remove usb detach/reattach calls
Martin Polednik has posted comments on this change. Change subject: hostdev: remove usb detach/reattach calls .. Patch Set 1: Verified+1 Only detaches/reattaches PCI devices. -- To view, visit https://gerrit.ovirt.org/39806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17843/ -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: only detect IOMMU group for PCI devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: only detect IOMMU group for PCI devices .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17671/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17672/ -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: only detect IOMMU group for PCI devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: only detect IOMMU group for PCI devices .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17842/ -- To view, visit https://gerrit.ovirt.org/39807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: only detect IOMMU group for PCI devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: only detect IOMMU group for PCI devices .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17671/ -- To view, visit https://gerrit.ovirt.org/39807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: remove usb detach/reattach calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: remove usb detach/reattach calls .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17670/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: only detect IOMMU group for PCI devices
Martin Polednik has uploaded a new change for review. Change subject: hostdev: only detect IOMMU group for PCI devices .. hostdev: only detect IOMMU group for PCI devices When assigning USB and/or SCSI devices, the detach function is called to fetch attributes of the device. Assigning IOMMU group caused KeyError in this case as there are no IOMMU groups on usb/scsi buses. Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Signed-off-by: Martin Polednik --- M vdsm/hostdev.py 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/39807/1 diff --git a/vdsm/hostdev.py b/vdsm/hostdev.py index 08d4974..675e381 100644 --- a/vdsm/hostdev.py +++ b/vdsm/hostdev.py @@ -170,9 +170,8 @@ def detach_detachable(device_name): libvirt_device, device_params = _get_device_ref_and_params(device_name) -iommu_group = device_params['iommu_group'] - if CAPABILITY_TO_XML_ATTR[device_params['capability']] == 'pci': +iommu_group = device_params['iommu_group'] supervdsm.getProxy().appropriateIommuGroup(iommu_group) libvirt_device.detachFlags(None) @@ -182,9 +181,8 @@ def reattach_detachable(device_name): libvirt_device, device_params = _get_device_ref_and_params(device_name) -iommu_group = device_params['iommu_group'] - if CAPABILITY_TO_XML_ATTR[device_params['capability']] == 'pci': +iommu_group = device_params['iommu_group'] supervdsm.getProxy().rmAppropriateIommuGroup(iommu_group) libvirt_device.reAttach() -- To view, visit https://gerrit.ovirt.org/39807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: only detect IOMMU group for PCI devices
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: only detect IOMMU group for PCI devices .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa14738c52013c4f0247544c2d81d1bebaced4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: remove usb detach/reattach calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: remove usb detach/reattach calls .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17841/ -- To view, visit https://gerrit.ovirt.org/39806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: remove usb detach/reattach calls
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: remove usb detach/reattach calls
..
hostdev: remove usb detach/reattach calls
These calls were introduced to allow behaviour as stated by libvirt
documentation, which was wrong in regard to USB. There is no need for
any kind of detach/reattach calls to be made.
Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c
Signed-off-by: Martin Polednik
---
M vdsm/hostdev.py
1 file changed, 5 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/39806/1
diff --git a/vdsm/hostdev.py b/vdsm/hostdev.py
index 7713346..08d4974 100644
--- a/vdsm/hostdev.py
+++ b/vdsm/hostdev.py
@@ -24,8 +24,9 @@
from vdsm import libvirtconnection
import supervdsm
-_DETACH_REQUIRING_CAPS = ('usb_device', 'pci')
-_UDEV_REQUIRING_CAPS = ('pci')
+CAPABILITY_TO_XML_ATTR = {'pci': 'pci',
+ 'scsi': 'scsi',
+ 'usb_device': 'usb'}
def _name_to_pci_path(device_name):
@@ -171,10 +172,8 @@
iommu_group = device_params['iommu_group']
-if device_params['capability'] in _UDEV_REQUIRING_CAPS:
+if CAPABILITY_TO_XML_ATTR[device_params['capability']] == 'pci':
supervdsm.getProxy().appropriateIommuGroup(iommu_group)
-
-if device_params['capability'] in _DETACH_REQUIRING_CAPS:
libvirt_device.detachFlags(None)
return device_params
@@ -185,10 +184,8 @@
iommu_group = device_params['iommu_group']
-if device_params['capability'] in _UDEV_REQUIRING_CAPS:
+if CAPABILITY_TO_XML_ATTR[device_params['capability']] == 'pci':
supervdsm.getProxy().rmAppropriateIommuGroup(iommu_group)
-
-if device_params['capability'] in _DETACH_REQUIRING_CAPS:
libvirt_device.reAttach()
--
To view, visit https://gerrit.ovirt.org/39806
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: remove usb detach/reattach calls
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: remove usb detach/reattach calls .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: remove usb detach/reattach calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: remove usb detach/reattach calls .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17670/ -- To view, visit https://gerrit.ovirt.org/39806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b2af5123c8b70fdd9105574bd3781f039df4b2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17840/ -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 827: # the numOfIoThreads has to be passed to the specific disks
Line 828: # so they can set the pinning up
Line 829: if 'numOfIoThreads' in self.conf:
Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads']
> Indeed the root issue here is the (fragile and convoluted) assignement of i
I don't think this should concern us since typically (by default) you will have
only one ioThread anyway :) And after restart it will get distributed properly
anyway.
So, what about this:
- make a method like "setupPinToIoThread" this will expect the index to be
already set up for the drv and will set the pin to iothread properly (e.g. will
remove this logic from the Drive class)
- now either be careful to call it everywhere the updateDriveIndex is called (2
places) or to create a new method like "updateDrivePositionalParams" which will
first call the updateDriveIndex and than the setupPinToIoThread (and of course
replace the call to updateDriveIndex by this new method)
what do you think?
Line 832:
Line 833: def __legacyDrives(self):
Line 834: """
Line 835: Backward compatibility for qa scripts that specify direct
paths.
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
> it is fine and also considered good style to break lines inside parenthesis
ok, I will break it up
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Make socket blocking after detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Make socket blocking after detection .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17668/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8183aacfaf743b90f0f819830ab5a37e6a40dde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17669/ -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for usb devices
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: add support for usb devices .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Make socket blocking after detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Make socket blocking after detection .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17839/ -- To view, visit https://gerrit.ovirt.org/39731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8183aacfaf743b90f0f819830ab5a37e6a40dde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Pass socket in blocking mode
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Pass socket in blocking mode .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17838/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17667/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b1bc6aa8e06cbda63b2ba2a113e7db7b245f2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Make socket blocking after detection
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Make socket blocking after detection .. Patch Set 2: Piotr, please take a look again, and tell me if you think we need another change in this topic. -- To view, visit https://gerrit.ovirt.org/39731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8183aacfaf743b90f0f819830ab5a37e6a40dde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Pass socket in blocking mode
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Pass socket in blocking mode .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17838/ -- To view, visit https://gerrit.ovirt.org/39746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b1bc6aa8e06cbda63b2ba2a113e7db7b245f2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Do not expose internals
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Do not expose internals .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17837/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17666/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Pass socket in blocking mode
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Pass socket in blocking mode .. Patch Set 2: Piotr, I don't follow - how can I rebase this on master and keep only the protocol detector changes? I must based this change on the previous patch, make this change safe and clean. -- To view, visit https://gerrit.ovirt.org/39746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b1bc6aa8e06cbda63b2ba2a113e7db7b245f2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Do not expose internals
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Do not expose internals .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17837/ -- To view, visit https://gerrit.ovirt.org/39732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Do not expose internals
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Do not expose internals .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17666/ -- To view, visit https://gerrit.ovirt.org/39732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Make socket blocking after detection
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Make socket blocking after detection .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17668/ -- To view, visit https://gerrit.ovirt.org/39731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8183aacfaf743b90f0f819830ab5a37e6a40dde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Pass socket in blocking mode
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocoldetector: Pass socket in blocking mode .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17667/ -- To view, visit https://gerrit.ovirt.org/39746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b1bc6aa8e06cbda63b2ba2a113e7db7b245f2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocoldetector: Pass socket in blocking mode
automat...@ovirt.org has posted comments on this change. Change subject: protocoldetector: Pass socket in blocking mode .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b1bc6aa8e06cbda63b2ba2a113e7db7b245f2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
