Change in vdsm[master]: v2v: handle exception on probing external VMs
automat...@ovirt.org has posted comments on this change. Change subject: v2v: handle exception on probing external VMs .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: handle exception on probing external VMs
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: handle exception on probing external VMs
..
v2v: handle exception on probing external VMs
XMLDesc of libvirt domain can throw error,
We don't want to fail all the process of fetching external VMs if we
fail to read one VM xml.
Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02
Signed-off-by: Shahar Havivi shah...@redhat.com
---
M vdsm/v2v.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/43259/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index b6763da..307c005 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -139,7 +139,11 @@
with closing(conn):
vms = []
for vm in conn.listAllDomains():
-root = ET.fromstring(vm.XMLDesc(0))
+try:
+root = ET.fromstring(vm.XMLDesc(0))
+except libvirt.libvirtError as e:
+logging.error('error reading domain xml, msg: %s', e.message)
+continue
params = {}
_add_vm_info(vm, params)
try:
--
To view, visit https://gerrit.ovirt.org/43259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: enable to use external virtio drivers for virtio
automat...@ovirt.org has posted comments on this change. Change subject: v2v: enable to use external virtio drivers for virtio .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74326b880960c21185cd4ce007852bf0c703d192 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: enable to use external virtio drivers for virtio
Shahar Havivi has posted comments on this change. Change subject: v2v: enable to use external virtio drivers for virtio .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/42996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74326b880960c21185cd4ce007852bf0c703d192 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: handle exception on probing external VMs
Shahar Havivi has posted comments on this change. Change subject: v2v: handle exception on probing external VMs .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 3: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::#1203422::OK, correct target release 3.5.4 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 2: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 6: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add logic for POWER cpu xml element
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/42736/4//COMMIT_MSG
Commit Message:
Line 7: virt: add logic for POWER cpu xml element
Line 8:
Line 9: Current flow in appendCpu caused ppc to be skipped, generating empty
Line 10: element (cpu/). In order to specify cpu model on ppc, we have to use
Line 11: libvirt's host-model element and power8 model.
can you point to the libvirt-side discussion about this compulsory use of
host-model?
At the very least, state the limitation that this puts on migration: migration
from a new host to and older one can fail in unexpected ways inside the guest.
Line 12:
Line 13: This is currently the only way of safely adding CPU to ppc64le host.
Line 14:
Line 15: Change-Id: I9303b76904ef1344508136343104b37c09d2a370
https://gerrit.ovirt.org/#/c/42736/4/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 366: elif feature[0] == '-':
Line 367: featureAttrs['policy'] = 'disable'
Line 368: cpu.appendChildWithArgs('feature', **featureAttrs)
Line 369: elif self.arch in (caps.Architecture.POWER,):
Line 370: cpu.setAttrs(mode='host-model')
I think that it is safer to send model=hostModel from Engine, instead of
ignoring Engine's request in Vdsm.
In the future, when we have a more stable definition of guest CPU models, we
can use them without a change.
Line 371:
Line 372: features = self.conf.get('cpuType', 'power8').split(',')
Line 373: model = features[0]
Line 374:
--
To view, visit https://gerrit.ovirt.org/42736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: ignore bondingOptions in persistent networks. .. net: ignore bondingOptions in persistent networks. Up until https://gerrit.ovirt.org/#/c/42146/ bondingOptions were mistakenly part of persistent network attributes. So, if we are upgrading from an older enough version, we should drop this entry from the copied persistent networks. If we don't, the comparison between persisted and kernel config would needlessly fail. Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Signed-off-by: Ido Barkan ibar...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43233 Reviewed-by: Dan Kenigsberg dan...@redhat.com Continuous-Integration: Jenkins CI --- M lib/vdsm/netconfpersistence.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Objections: Petr Horáček: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make status attribute private
automat...@ovirt.org has posted comments on this change. Change subject: migration: make status attribute private .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33884c0e4942f9e2d7ef93b939f33b2e6147ca62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: migration: add response.is_failure helper
automat...@ovirt.org has posted comments on this change. Change subject: lib: migration: add response.is_failure helper .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Allow pickling of protected password
Dan Kenigsberg has posted comments on this change. Change subject: password: Allow pickling of protected password .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: migration: add response.is_failure helper
Francesco Romani has posted comments on this change. Change subject: lib: migration: add response.is_failure helper .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/42795/4/lib/vdsm/response.py File lib/vdsm/response.py: Line 23: from vdsm.define import doneCode Line 24: from vdsm.define import errCode Line 25: Line 26: Line 27: class Malformed(Exception): Why is the common Error suffix a bad idea? It's almost a standard. Let's move forward: I'll change to MalformedResponse, after that we can reevaluate the state of the patch and how it will look. Line 28: Line 29: Malformed response value Line 30: Line 31: Line 60: def is_success(res): Line 61: try: Line 62: code = res[status][code] Line 63: except KeyError: Line 64: raise Malformed We should include the response in the exception, so the traceback will incl good point, will do. Line 65: else: Line 66: return code == doneCode[code] Line 67: Line 68: Line 66: return code == doneCode[code] Line 67: Line 68: Line 69: def is_error(res): Line 70: return not is_success(res) I think that we need only is_error - most code is doing: I need one between is_error and is_success, and I can happily drop the other. I'll add is_error as you suggest. Having response raise on error is a good change, but it is quite invasive, so I'll save for another patch. -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: move progress update into an helper
automat...@ovirt.org has posted comments on this change. Change subject: migration: move progress update into an helper .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9707fcc492a394f8d7aebd57482c44b7b5a703d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: replace boolean with proper Events
automat...@ovirt.org has posted comments on this change. Change subject: migration: replace boolean with proper Events .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02639749ab884c3542c4d29715756044d777f738 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: do not use status after getStat()
automat...@ovirt.org has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f1d330376590d0c4060baa9b13e5496c8b7f9ee Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: de-entangle migration stat reporting
automat...@ovirt.org has posted comments on this change. Change subject: migration: de-entangle migration stat reporting .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d745bacddf80c54354a2f7ec2d290dfd3b12d03 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: return plain response on error
automat...@ovirt.org has posted comments on this change. Change subject: migration: return plain response on error .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafa5de4db317ed0e2f735eca6d944042e19c4e1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()
automat...@ovirt.org has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ab50fc789dde969b2fb9ab969241ed4ad12545c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: add helper to add status field
automat...@ovirt.org has posted comments on this change. Change subject: migration: add helper to add status field .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047705e2f45221ad3a7527ca6b018dc6d0f3368e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: build new reason on success
automat...@ovirt.org has posted comments on this change. Change subject: migration: build new reason on success .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic42b70be6f5a5406e23916e16a678dd8caf0f500 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 4: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::#1203422::OK, correct target release 3.5.4 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Improve error handling when Vm._dom is None
Vinzenz Feenstra has posted comments on this change. Change subject: vm: Improve error handling when Vm._dom is None .. Patch Set 1: Code-Review+1 Nice, I like this one :-) -- To view, visit https://gerrit.ovirt.org/43225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5349ec51c7accf3b417b3bc9489c7eed5bfd8733 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: jsonrpc: add a creation method for client
Yeela Kaplan has posted comments on this change. Change subject: vdscli: jsonrpc: add a creation method for client .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43092/4/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 106: def connect(requestQueue, stompClient=None, Line 107: host=None, port=None, Line 108: useSSL=None, Line 109: responseQueue=None): Line 110: if not stompClient: Why do we want to use standalone client to build StompRpcClient or build it because in the case of migration we'd like to use the vdsm reactor and not use a separate one... and then we supply our own client. Line 111: client = _create(requestQueue, Line 112: host, port, useSSL, Line 113: responseQueue) Line 114: else: -- To view, visit https://gerrit.ovirt.org/43092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia99533227b0c3241d7951a2f39af2ff3a6210b5b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() verbs
Vinzenz Feenstra has posted comments on this change. Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: snapshot: Add Vm.freeze() and Vm.thaw() methods
Vinzenz Feenstra has posted comments on this change. Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43018 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Allow pickling of protected password
Piotr Kliczewski has posted comments on this change. Change subject: password: Allow pickling of protected password .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: clock: always use rtc timer
Michal Skrivanek has posted comments on this change. Change subject: vm: clock: always use rtc timer .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9c3996e95ac0848f9b0a6c7c77b1aeb6da860d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: clock: always use rtc timer
Martin Polednik has posted comments on this change. Change subject: vm: clock: always use rtc timer .. Patch Set 1: Code-Review+1 I'm starting to feel uneasy about timer changes, is this somewhat final for now? Also, could you add (comment is enough) link to the invalid doc? -- To view, visit https://gerrit.ovirt.org/43195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9c3996e95ac0848f9b0a6c7c77b1aeb6da860d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: response: insert results into 'info'
Yeela Kaplan has posted comments on this change. Change subject: response: insert results into 'info' .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5284969585e55a230be31bde56956fc966e46c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: snapshot: Add vdsClient freeze() and thaw() APIs
Vinzenz Feenstra has posted comments on this change. Change subject: snapshot: Add vdsClient freeze() and thaw() APIs .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98872132767f3edd6d028cd9545e282e89f12777 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: use deque for incoming requests .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/42915/8//COMMIT_MSG Commit Message: Line 6: Line 7: xmlrpc: use deque for incoming requests Line 8: Line 9: This patch changes how we manage queued requests when stopping the server. When Line 10: we stop we drop all other requests and add sentinel to stop the server. could you provide here the motivation for this change? Done Line 11: Line 12: Line 13: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
automat...@ovirt.org has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: * Update tracker::#1222564::OK * Check Bug-Url::OK * Check Public Bug::#1222564::OK, public bug * Check Product::#1222564::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: rename glusterCreateBrick to glusterBrickCreate
Hello Piotr Kliczewski, Timothy Asir, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/43263
to review the following change.
Change subject: gluster: rename glusterCreateBrick to glusterBrickCreate
..
gluster: rename glusterCreateBrick to glusterBrickCreate
To make consistency in function names in supervdsm and verb names in
vdsm, this patch renames verb glusterCreateBrick to glusterBrickCreate
Change-Id: I367a864bc9bf4aa9b6a0d36b64f541fa89c61c0d
Signed-off-by: Bala.FA barum...@redhat.com
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/storagedev.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/43263/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index a4bce63..76b91e1 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -633,7 +633,7 @@
pp.pprint(status)
return status['status']['code'], status['status']['message']
-def do_glusterCreateBrick(self, args):
+def do_glusterBrickCreate(self, args):
params = self._eqSplit(args)
devList = params.get('devices', '').split(',')
brickName = params.get('brickName', '')
@@ -646,7 +646,7 @@
raidParams['stripeSize'] = int(params.get('stripeSize', 0))
raidParams['pdCount'] = int(params.get('pdCount', 0))
-status = self.s.glusterCreateBrick(brickName, mountPoint,
+status = self.s.glusterBrickCreate(brickName, mountPoint,
devList, fsType, raidParams)
pp.pprint(status)
return status['status']['code'], status['status']['message']
@@ -1172,8 +1172,8 @@
('[volumeName=volume_name]',
'snapshot list for given volume'
)),
- 'glusterCreateBrick': (
- serv.do_glusterCreateBrick,
+ 'glusterBrickCreate': (
+ serv.do_glusterBrickCreate,
('brickName=brick_name mountPoint=mountPoint '
'devices=device[,device, ...] '
'[raidType=raid_type] [stripeSize=stripe_size] '
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 0c5829f..361e0c5 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -677,9 +677,9 @@
return {'snapshotList': status}
@exportAsVerb
-def createBrick(self, name, mountPoint, devList, fsType=None,
+def brickCreate(self, name, mountPoint, devList, fsType=None,
raidParams={}, options=None):
-status = self.svdsmProxy.glusterCreateBrick(name,
+status = self.svdsmProxy.glusterBrickCreate(name,
mountPoint,
devList,
fsType,
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 4768a86..f607dd4 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -81,9 +81,9 @@
def storageDevicesList(self, options=None):
return self._gluster.storageDevicesList()
-def createBrick(self, name, mountPoint, devList, fsType=None,
+def brickCreate(self, name, mountPoint, devList, fsType=None,
raidParams={}):
-return self._gluster.createBrick(name, mountPoint,
+return self._gluster.brickCreate(name, mountPoint,
devList, fsType, raidParams)
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index eb8b103..4fffef8 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -129,7 +129,7 @@
@makePublic
-def createBrick(brickName, mountPoint, devNameList, fsType=DEFAULT_FS_TYPE,
+def brickCreate(brickName, mountPoint, devNameList, fsType=DEFAULT_FS_TYPE,
raidParams={}):
def _getDeviceList(devNameList):
return [blivetEnv.devicetree.getDeviceByName(devName.split(/)[-1])
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json
b/vdsm/rpc/vdsmapi-gluster-schema.json
index d83344c..51dd699 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1271,7 +1271,7 @@
'data': {'type': 'str', 'stripeSize': 'int', 'diskCnt': 'int'}}
##
-# @GlusterHost.createBrick:
+# @GlusterHost.brickCreate:
#
# Create a brick for the gluster volume
#
@@ -1290,7 +1290,7 @@
#
# Since: 4.17.0
##
-{'command': {'class': 'GlusterHost', 'name': 'createBrick'},
+{'command': {'class': 'GlusterHost', 'name': 'brickCreate'},
'data': {'name': 'str', 'mountPoint': 'str', 'devList': ['str'],
'*fsType': 'str', '*raidParams': 'RaidDevice'},
'returns': 'bool'}
--
To view, visit https://gerrit.ovirt.org/43263
To unsubscribe, visit
Change in vdsm[ovirt-3.5-gluster]: gluster: rename glusterCreateBrick to glusterBrickCreate
automat...@ovirt.org has posted comments on this change. Change subject: gluster: rename glusterCreateBrick to glusterBrickCreate .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367a864bc9bf4aa9b6a0d36b64f541fa89c61c0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 7: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Yaniv Bronhaim has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 77: echodo $SYSTEMCTL restart vdsmd.service Line 78: ) Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service I think this will be good replacement for the kill commands above. Nir, I think you just afraid of regressions and try to avoid verification for that change - Any solution we choose will require verification and testing for the fencing flow. send SIGTERM, sleep 2 seconds, send SIGKILL is the exact way systemd does systemctl restart so there is NO different and waiting 7seconds should be enough. I don't see why your rejection is correct here - please explain from what you are worried from more specifically. Line 82: Line 83: rm -fr $RENEWDIR Line 84: trap EXIT Line 85: exit 3 -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: clock: always use rtc timer
Francesco Romani has posted comments on this change. Change subject: vm: clock: always use rtc timer .. Patch Set 1: Martin, I share your concerns and I really feed sad (and dumb :( ) about the issue here, but the problem is exactly I can't find a comprehensive and authoritative source (wiki page, doc, whatever) on this topic. We discovered this issue, and the needed fix, like this: https://bugzilla.redhat.com/show_bug.cgi?id=1215610#c35 and https://bugzilla.redhat.com/show_bug.cgi?id=1215610#c37 -- To view, visit https://gerrit.ovirt.org/43195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9c3996e95ac0848f9b0a6c7c77b1aeb6da860d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove _reportError
Vinzenz Feenstra has posted comments on this change. Change subject: vm: remove _reportError .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: switch to response.error()
Vinzenz Feenstra has posted comments on this change. Change subject: vm: switch to response.error() .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: logging: remove log messages which give little or no value
Piotr Kliczewski has uploaded a new change for review. Change subject: logging: remove log messages which give little or no value .. logging: remove log messages which give little or no value Some of the messages logged during jsonrpc request processing give no or little value when diagnosing the issues but are logged quite often. This patch removes those messages. Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Bug-Url: https://bugzilla.redhat.com/1239062 --- M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stompReactor.py 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/43262/1 diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 5b476a2..53b4e2f 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -527,7 +527,6 @@ @traceback(on=log.name) def serve_requests(self): while True: -self.log.debug(Waiting for request) obj = self._workQueue.get() if obj is None: break diff --git a/lib/yajsonrpc/stompReactor.py b/lib/yajsonrpc/stompReactor.py index 78b274b..3f003c6 100644 --- a/lib/yajsonrpc/stompReactor.py +++ b/lib/yajsonrpc/stompReactor.py @@ -95,7 +95,6 @@ self._messageHandler(self, frame.body) def handle_frame(self, dispatcher, frame): -self.log.debug(Handling message %s, frame) try: self._commands[frame.command](dispatcher, frame) except KeyError: -- To view, visit https://gerrit.ovirt.org/43262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: logging: remove log messages which give little or no value
Piotr Kliczewski has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: Verified+1 Verified by running local build. -- To view, visit https://gerrit.ovirt.org/43262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: logging: remove log messages which give little or no value
automat...@ovirt.org has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: * Update tracker::#1239062::OK * Check Bug-Url::OK * Check Public Bug::#1239062::OK, public bug * Check Product::#1239062::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1239062::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: disable IPv6 via sysctl if no IPv6 functionality wa...
Dan Kenigsberg has posted comments on this change. Change subject: network: disable IPv6 via sysctl if no IPv6 functionality was requested .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43252/1/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 95: self._addSourceRoute(bridge) Line 96: _ifup(bridge) Line 97: if not bridge.ipv6.address and not bridge.ipv6.ipv6autoconf and ( Line 98: not bridge.ipv6.dhcpv6): Line 99: # disallow IPv6 traffic on the bridge if IPv6 is not requested the comment only translate Python into English (which is not really useful). You could write: # disable ipv6 (unless explictly requested) to avoid # guest-host communication over ipv6 but atucally, this should go into the commit message. Line 100: sysctl.disable_ipv6(bridge.name) Line 101: Line 102: def configureVlan(self, vlan, **opts): Line 103: self.configApplier.addVlan(vlan, **opts) -- To view, visit https://gerrit.ovirt.org/43252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2314d4bc120c15af44ff9e20c9281ab69c84ad0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: use socket.getfqdn instead of 'hostname' binary
Dan Kenigsberg has posted comments on this change. Change subject: gluster: use socket.getfqdn instead of 'hostname' binary .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: use socket.getfqdn instead of 'hostname' binary
automat...@ovirt.org has posted comments on this change. Change subject: gluster: use socket.getfqdn instead of 'hostname' binary .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/37621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: use socket.getfqdn instead of 'hostname' binary
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: use socket.getfqdn instead of 'hostname' binary .. gluster: use socket.getfqdn instead of 'hostname' binary VDSM still requires the binary though, it is called in e.g. vdsm/vdsm-gencerts.sh.in Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: https://gerrit.ovirt.org/37621 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M .gitignore M configure.ac M debian/vdsm.install M vdsm.spec.in M vdsm/gluster/Makefile.am M vdsm/gluster/cli.py D vdsm/gluster/hostname.py.in 7 files changed, 7 insertions(+), 62 deletions(-) Approvals: Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Allow pickling of protected password
Nir Soffer has posted comments on this change. Change subject: password: Allow pickling of protected password .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: migration: add response.is_failure helper
Nir Soffer has posted comments on this change. Change subject: lib: migration: add response.is_failure helper .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/42795/4/lib/vdsm/response.py File lib/vdsm/response.py: Line 23: from vdsm.define import doneCode Line 24: from vdsm.define import errCode Line 25: Line 26: Line 27: class Malformed(Exception): Why is the common Error suffix a bad idea? It's almost a standard. I find code more readable without obvious suffixes. They make names longer without adding value to the reader. Line 28: Line 29: Malformed response value Line 30: Line 31: -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add logic for POWER cpu xml element
Martin Polednik has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/42736/4//COMMIT_MSG Commit Message: Line 7: virt: add logic for POWER cpu xml element Line 8: Line 9: Current flow in appendCpu caused ppc to be skipped, generating empty Line 10: element (cpu/). In order to specify cpu model on ppc, we have to use Line 11: libvirt's host-model element and power8 model. can you point to the libvirt-side discussion about this compulsory use of h This was discussed in person, but will try. Migration: I don't understand. According to D. Gibson, it is possible to run the guest workarounds on both POWER8 and POWER8e guests and therefore, the migration will be safe in this case. Line 12: Line 13: This is currently the only way of safely adding CPU to ppc64le host. Line 14: Line 15: Change-Id: I9303b76904ef1344508136343104b37c09d2a370 -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: migration: add response.is_failure helper
Nir Soffer has posted comments on this change. Change subject: lib: migration: add response.is_failure helper .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/42795/6/lib/vdsm/response.py File lib/vdsm/response.py: Line 26: Line 27: class MalformedResponse(Exception): Line 28: Line 29: Malformed response value Line 30: This does not add much value, just repeating the class name. I think the name clear enough. Line 31: Line 32: def __init__(self, res): Line 33: super(MalformedResponse, self).__init__( Line 34: Malformed response: %s % str(res)) Line 30: Line 31: Line 32: def __init__(self, res): Line 33: super(MalformedResponse, self).__init__( Line 34: Malformed response: %s % str(res)) We don't need to repeat the name of the class in the message. If you try to raise this exception, we will get: MalformedResponse: Malformed response: foo Also initializing Exception for formatting the error string is little clumsy. Better use this pattern used elsewhere in vdsm: class MalformedResponse(Exception): def __init__(self, response): self.response = response def __str__(self): return Missing required key %r % self.response Line 35: self.response = res Line 36: Line 37: Line 38: def success(message=None, **kwargs): -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: variable name change to avoid naming conflict
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: variable name change to avoid naming conflict .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dce6b9e84edc347e64981b053d53de4091b7f6f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
Nir Soffer has posted comments on this change. Change subject: vdsm: removed optional markers for volUUID .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 echodo $REBOOTCMD) Line 74: disown Line 75: (sleep 7 Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service Why run killl just to get the signal number? This code run on linux, the signal numbers are not going to change soon. Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: ) Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
Adam Litke has posted comments on this change. Change subject: vdsm: removed optional markers for volUUID .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Avoid unneeded freeze during snapshot
Nir Soffer has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43293/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3123 Line 3124 Line 3125 Line 3126 Line 3127 This is not needed since we have same cleanup code in the finally in line 3153 -- To view, visit https://gerrit.ovirt.org/43293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328470f700ab74daeed5375c0ade83628d16c387 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Avoid unneeded freeze during snapshot
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328470f700ab74daeed5375c0ade83628d16c387 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: migration: add response.is_failure helper
automat...@ovirt.org has posted comments on this change. Change subject: lib: migration: add response.is_failure helper .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: report hook stderr to Engine if it fails an action
automat...@ovirt.org has posted comments on this change. Change subject: vdsm hooks: report hook stderr to Engine if it fails an action .. Patch Set 16: * Update tracker::#1219630::OK * Check Bug-Url::OK * Check Public Bug::#1219630::OK, public bug * Check Product::#1219630::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2d5eb52cf2c8855d9d7d5e0ff1628a6cf1dc51 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Feng Yang yangf...@cloud-times.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 echodo $REBOOTCMD) Line 74: disown Line 75: (sleep 7 Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service Why run killl just to get the signal number? This code run on linux, the si Also systemctl supports signal names, just like kill: systemctl kill -s KILL vdsmd systemctl kill -s USR1 vdsmd Tested on rhel 7.1. Does this fail any other platforms? Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: ) Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: migration: add response.is_failure helper
Nir Soffer has posted comments on this change. Change subject: lib: migration: add response.is_failure helper .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42795/7/lib/vdsm/response.py File lib/vdsm/response.py: Line 49: } Line 50: } Line 51: Line 52: def is_failure(res): Line 53: return res[status][code] != doneCode[code] Why we don't need now the MalformedResponse class? and why is_failure is better then is_error? We have success() and error() - is_error() is a very good name to detect an error response. is_failure() is rather confusing - is this an error response, or something different? Bad rebase? -- To view, visit https://gerrit.ovirt.org/42795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki mmire...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support OVF_STORE upload for ceph.
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Support OVF_STORE upload for ceph. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffcc1af9861a5580786340c2e5a325d1663b3a5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support OVF_STORE upload for ceph.
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Support OVF_STORE upload for ceph. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffcc1af9861a5580786340c2e5a325d1663b3a5e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Remove unrelevant sdCache.produce for downloadImage
Maor Lipchuk has uploaded a new change for review. Change subject: hsm: Remove unrelevant sdCache.produce for downloadImage .. hsm: Remove unrelevant sdCache.produce for downloadImage Remove sdCache produce when calling download image from stream. Change-Id: I7cceef3400e5ce4781d9722c7d2f7817fef8 Signed-off-by: Maor Lipchuk mlipc...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/43294/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 1b9de05..c997a34 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1733,7 +1733,6 @@ Warning: Internal use only. -sdCache.produce(sdUUID) pool = self.getPool(spUUID) # NOTE: this could become an hsm task, in such case the LV extension # required to prepare the destination should go through the mailbox. -- To view, visit https://gerrit.ovirt.org/43294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7cceef3400e5ce4781d9722c7d2f7817fef8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Remove unrelevant sdCache.produce for downloadImage
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Remove unrelevant sdCache.produce for downloadImage .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cceef3400e5ce4781d9722c7d2f7817fef8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: remove unrelevant sdCache.produce for uploadImage
automat...@ovirt.org has posted comments on this change. Change subject: hsm: remove unrelevant sdCache.produce for uploadImage .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916e79a31b27c346e2c72a0d152a01d890a38162 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: remove unrelevant sdCache.produce for uploadImage
Maor Lipchuk has uploaded a new change for review. Change subject: hsm: remove unrelevant sdCache.produce for uploadImage .. hsm: remove unrelevant sdCache.produce for uploadImage Remove sdCache produce when calling upload image to stream. Change-Id: I916e79a31b27c346e2c72a0d152a01d890a38162 Signed-off-by: Maor Lipchuk mlipc...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/43295/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index c997a34..cbfed5c 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1718,7 +1718,6 @@ Warning: Internal use only. -sdCache.produce(sdUUID) pool = self.getPool(spUUID) # NOTE: this could become an hsm task self._spmSchedule(spUUID, uploadImageToStream, -- To view, visit https://gerrit.ovirt.org/43295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I916e79a31b27c346e2c72a0d152a01d890a38162 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: SetupNetworks small cleanups
Petr Horáček has posted comments on this change. Change subject: net: SetupNetworks small cleanups .. Patch Set 27: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42022/27/vdsm/network/api.py File vdsm/network/api.py: Line 715: Line 716: def _update_add_network_arguments(attrs, bondings, _netinfo): Line 717: update a specific network attributes with relevant bonding/nic Line 718: info. Line 719: args = dict(attrs) i know it was this way in original file, but this dict(attrs) returns a deepcopy of attrs (which is already a dict) right? imho it would make more sense to explicitly deepcopy it Line 720: if 'bonding' in args: Line 721: args.update(_build_bond_options( Line 722: args['bonding'], bondings, _netinfo)) Line 723: else: -- To view, visit https://gerrit.ovirt.org/42022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: emit event when domDependentInit is done
automat...@ovirt.org has posted comments on this change. Change subject: vm: emit event when domDependentInit is done .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie379911a374a9ba3e82658592c295f7a9a0ac8a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: report minimal running vm stats
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: report minimal running vm stats .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a1b10d3cc3dd33664ea9f0842cbc7f1eb07b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: introduce _send_event helper
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: introduce _send_event helper .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c25ba9f520e6409cc06e99a2450d2c0d98c26fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: events: extract function to make event info
automat...@ovirt.org has posted comments on this change. Change subject: virt: events: extract function to make event info .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If60e8422d06fb1ff45a846858856ad68d52fd6ce Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: emit event on setDownStatus
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: emit event on setDownStatus .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a99d074461bcc2b61d15dd46f7d020abbe48afe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: emit event on guest status change
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: emit event on guest status change .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib98d64a250a6d2de70f7fe5206e5a0ad648c151d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: factor out the vm hashes
automat...@ovirt.org has posted comments on this change. Change subject: vm: factor out the vm hashes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05143021d505e815abbd227f58f460cf9b45210 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: do not send status event on startup
automat...@ovirt.org has posted comments on this change. Change subject: vm: event: do not send status event on startup .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d2c1b1d1132e1d3792b1a8c8f9241b6e6eb3164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: simplify Vm._getVmStatus method
automat...@ovirt.org has posted comments on this change. Change subject: vm: simplify Vm._getVmStatus method .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f02efa1001aff5fbf01d127b333250500de9d54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: extract subset of running vm stats
automat...@ovirt.org has posted comments on this change. Change subject: vm: extract subset of running vm stats .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e2c19d0b69e78f463976478ded12f306e2f2c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add logic for POWER cpu xml element
automat...@ovirt.org has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: use deque for incoming requests .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
automat...@ovirt.org has posted comments on this change. Change subject: xmlrpc: use deque for incoming requests .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
Dan Kenigsberg has submitted this change and it was merged. Change subject: xmlrpc: use deque for incoming requests .. xmlrpc: use deque for incoming requests This patch changes how we manage queued requests. We suspect that there could be more queued requests so before stopping the server we want to drop all other requests and add sentinel to stop it. Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: https://gerrit.ovirt.org/42915 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/executor.py M lib/vdsm/xmlrpc.py 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Allow pickling of protected password
automat...@ovirt.org has posted comments on this change. Change subject: password: Allow pickling of protected password .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: removed optional markers for volUUID .. vdsm: removed optional markers for volUUID after examining the code, it's clear that the volUUID parameter for vdsClient's prepareImage command is NOT optional. therefore, I have removed any comments marking it as optional in the vdsClient documentation and in vdsmapi-schema.json Bug-Url: https://bugzilla.redhat.com/1115556 Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Signed-off-by: Candace Sheremeta csher...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38440 Tested-by: Allon Mureinik amure...@redhat.com Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com --- M client/vdsClient.py M vdsm/API.py M vdsm/rpc/bindingxmlrpc.py M vdsm/rpc/vdsmapi-schema.json 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/38440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: removed optional markers for volUUID .. Patch Set 3: * Update tracker::#1115556::OK * Check TR::#1115556::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/38440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Cleanup snapshot using freeze() and thaw()
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Cleanup snapshot using freeze() and thaw() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice74b5619246c979f24909f4ffc3688b3adef6cb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Avoid unneeded freeze during snapshot
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328470f700ab74daeed5375c0ade83628d16c387 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Freeze guest even when creating memory snapshot
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Freeze guest even when creating memory snapshot .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aa7ac0dea8690ca33df8067f84734d788da8bf8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Cleanup snapshot using freeze() and thaw()
Nir Soffer has uploaded a new change for review.
Change subject: freeze: Cleanup snapshot using freeze() and thaw()
..
freeze: Cleanup snapshot using freeze() and thaw()
Snapshot code was written before libvirt.virDomain.fsFreeze() and
libvirt.virDomain.fsThaw() were available. We used the quiesce flag
(VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE) to request freezing of guest
filesystems during the snapshot.
Because libvirt error reporting was not good enough, the code assumed
that *any* exception raised from snapshotCreateXML() means failure to
freeze the guest filesystems, and tried to take a snapshot again without
the quiesce flag. This error handling is evil and wrong, and requesting
snapshot twice after a failure sounds like a bad idea.
This patches cleans up the code using the new freeze() and thaw()
methods. We freeze() the guest before the snapshot, and thaw()
afterwards, invoking snapshot exactly once.
We handle only libvirtError around snapshotCreateXML(). Any other error
is not expected and will fail loudly.
When taking a memory snapshot, we are not freezing the guest, because
qemu is pausing the vm in this case. We keep this behavior for now.
Change-Id: Ice74b5619246c979f24909f4ffc3688b3adef6cb
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 16 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/43298/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 1ec03d4..3263733 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3092,7 +3092,9 @@
snap.appendChild(_memorySnapshot(memoryVolPath))
else:
snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
-snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
+
+# When creating memory snapshot libvirt will pause the vm
+should_freeze = not memoryParams
snapxml = snap.toprettyxml()
# TODO: this is debug information. For 3.6.x we still need to
@@ -3107,25 +3109,19 @@
self.stopDisksStatsCollection()
try:
+if should_freeze:
+freezed = self.freeze()
try:
self._dom.snapshotCreateXML(snapxml, snapFlags)
-except Exception as e:
-# Trying again without VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE.
-# At the moment libvirt is returning two generic errors
-# (INTERNAL_ERROR, ARGUMENT_UNSUPPORTED) which are too broad
-# to be caught (BZ#845635).
-snapFlags = (~libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE)
-# Here we don't need a full stacktrace (exc_info) but it's
-# still interesting knowing what was the error
-self.log.debug(Snapshot failed using the quiesce flag,
- trying again without it (%s), e)
-try:
-self._dom.snapshotCreateXML(snapxml, snapFlags)
-except Exception as e:
-self.log.exception(Unable to take snapshot)
-if memoryParams:
-self.cif.teardownVolumePath(memoryVol)
-return errCode['snapshotErr']
+except libvirt.libvirtError:
+self.log.exception(Unable to take snapshot)
+return errCode['snapshotErr']
+finally:
+# Must always thaw, even if freeze failed; in case the guest
+# did freeze the filesystems, but failed to reply in time.
+# Libvirt is using same logic (see src/qemu/qemu_driver.c).
+if should_freeze:
+self.thaw()
# We are padding the memory volume with block size of zeroes
# because qemu-img truncates files such that their size is
@@ -3151,9 +3147,8 @@
# Returning quiesce to notify the manager whether the guest agent
# froze and flushed the filesystems or not.
-return {'status': doneCode, 'quiesce':
-(snapFlags libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
-== libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE)}
+return {'status': doneCode,
+'quiesce': should_freeze and freezed[status][code] == 0}
def diskReplicateStart(self, srcDisk, dstDisk):
try:
--
To view, visit https://gerrit.ovirt.org/43298
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice74b5619246c979f24909f4ffc3688b3adef6cb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Freeze guest even when creating memory snapshot
Nir Soffer has uploaded a new change for review.
Change subject: freeze: Freeze guest even when creating memory snapshot
..
freeze: Freeze guest even when creating memory snapshot
We used to skip freezing the guest if creating memory snapshot. This was
probably done because qemu is pausing the vm for creating memory
snapshot.
However, this is not consistent with snapshots of external disks such as
network disks, where we always freeze the vm before taking the snapshot.
Also, it is probably safer to freeze even when creating memory snapshot,
giving applications on the guest chance to pause in consistent state.
This patch removes the check for memory snapshot, and freeze the guest
unless it is already frozen.
Change-Id: I8aa7ac0dea8690ca33df8067f84734d788da8bf8
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/43299/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 332281b..ecbbe1d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3093,9 +3093,6 @@
else:
snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
-# When creating memory snapshot libvirt will pause the vm
-should_freeze = not (memoryParams or frozen)
-
snapxml = snap.toprettyxml()
# TODO: this is debug information. For 3.6.x we still need to
# see the XML even with 'info' as default level.
@@ -3109,7 +3106,7 @@
self.stopDisksStatsCollection()
try:
-if should_freeze:
+if not frozen:
freezed = self.freeze()
try:
self._dom.snapshotCreateXML(snapxml, snapFlags)
@@ -3120,7 +3117,7 @@
# Must always thaw, even if freeze failed; in case the guest
# did freeze the filesystems, but failed to reply in time.
# Libvirt is using same logic (see src/qemu/qemu_driver.c).
-if should_freeze:
+if not frozen:
self.thaw()
# We are padding the memory volume with block size of zeroes
@@ -3148,7 +3145,7 @@
# Returning quiesce to notify the manager whether the guest agent
# froze and flushed the filesystems or not.
return {'status': doneCode,
-'quiesce': should_freeze and freezed[status][code] == 0}
+'quiesce': not frozen and freezed[status][code] == 0}
def diskReplicateStart(self, srcDisk, dstDisk):
try:
--
To view, visit https://gerrit.ovirt.org/43299
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8aa7ac0dea8690ca33df8067f84734d788da8bf8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Support per-host iscsi credentials database
Nir Soffer has posted comments on this change. Change subject: iscsicred: Support per-host iscsi credentials database .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43179/1/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 167: def readSessionInfo(self, sessionID): Line 168: return _readSessionInfo(sessionID) Line 169: Line 170: @logDecorator Line 171: def readTargetCredfile(self, target): vdsm hooks runs under vdsm username and permissions. as such, an evil hook Why not sudo? sudo -u vdsm vim cred-files Line 172: data = iscsicred._read_credfile(target) Line 173: return password.ProtectedPassword(data) Line 174: Line 175: @logDecorator -- To view, visit https://gerrit.ovirt.org/43179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6a838f6b8e132d6b0c1a8135f2c28ef1e7f847 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Freeze guest even when creating memory snapshot
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Freeze guest even when creating memory snapshot .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aa7ac0dea8690ca33df8067f84734d788da8bf8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: freeze: Avoid unneeded freeze during snapshot
automat...@ovirt.org has posted comments on this change. Change subject: freeze: Avoid unneeded freeze during snapshot .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328470f700ab74daeed5375c0ade83628d16c387 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move BlockSD.getVSize
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
