Change in vdsm[ovirt-3.5]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 2: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::#1203422::OK, correct target release 3.5.4 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 5: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 4: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 3: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
Dan Kenigsberg has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43684/2/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 898: Line 899: return set( Line 900: netinfo.NET_CONF_DIR + ifcfg Line 901: if (ifcfg.startswith(ROUTE_PREFIX) or ifcfg.startswith(RULE_PREFIX)) Line 902: else netinfo.NET_CONF_PREF + ifcfg > not sure if this is exactly what you meant but string formatting can make i what i meant is that (ROUTE_PREFIX + '%s') % top_level_device) is very different tnan other ifcfgs, and can be added to the set much later. but it is not a big deal, anyway. -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: logging: rename vm logger
Dan Kenigsberg has abandoned this change. Change subject: virt: logging: rename vm logger .. Abandoned already squashed into 70222813234e4fa42d0c7f792903fd162ec64353 -- To view, visit https://gerrit.ovirt.org/42688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4d6e56fc34dc28467b3777aed9b4112506dd6ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: logging: rename vm logger
automat...@ovirt.org has posted comments on this change. Change subject: virt: logging: rename vm logger .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/42688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d6e56fc34dc28467b3777aed9b4112506dd6ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 6: * Update tracker::#1227793::OK * Check Bug-Url::OK * Check Public Bug::#1227793::OK, public bug * Check Product::#1227793::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: rename 'nic' function
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: rename 'nic' function
..
vmstats: rename 'nic' function
The vmstats module exports a 'nic' function, which
produces the stats per-nic, in the format Engine expects.
The problem here is that 'nic' is a too nice name, so there
are other legitimate uses for it in other flows.
To reduce the possibility of name clash, we just rename
the function to the little less nice but little more revealing
'nic_traffic'.
This is also a little lie because 'nic_traffic' adds fields
which aren't strictly related to traffic proper. Future patch
will clean this further and remove the little lie.
Rename only.
Change-Id: I4b9290843c9dc7adc9709a66a0bb97238437bd37
Signed-off-by: Francesco Romani
---
M tests/vmTests.py
M vdsm/virt/vmstats.py
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/43694/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index c6bd8d0..ae31c09 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1265,7 +1265,7 @@
GBPS = 10 ** 9 / 8
MAC = '52:54:00:59:F5:3F'
pretime = utils.monotonic_time()
-res = vmstats.nic(
+res = vmstats.nic_traffic(
name='vnettest', model='virtio', mac=MAC,
start_sample={'rx.bytes': 2 ** 64 - 15 * GBPS,
'rx.pkts': 1,
diff --git a/vdsm/virt/vmstats.py b/vdsm/virt/vmstats.py
index b9caeac..5416f94 100644
--- a/vdsm/virt/vmstats.py
+++ b/vdsm/virt/vmstats.py
@@ -136,7 +136,7 @@
logging.error('Failed to get VM cpu count')
-def nic(name, model, mac, start_sample, end_sample, interval):
+def nic_traffic(name, model, mac, start_sample, end_sample, interval):
ifSpeed = [100, 1000][model in ('e1000', 'virtio')]
ifStats = {'macAddr': mac,
@@ -185,7 +185,7 @@
# may happen if nic is a new hot-plugged one
if not first_nic or not last_nic:
continue
-stats['network'][nic.name] = nic(
+stats['network'][nic.name] = nic_traffic(
nic.name, nic.nicModel, nic.macAddr,
first_nic, last_nic, interval)
--
To view, visit https://gerrit.ovirt.org/43694
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b9290843c9dc7adc9709a66a0bb97238437bd37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (disk) .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: rename 'nic' function
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: rename 'nic' function .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9290843c9dc7adc9709a66a0bb97238437bd37 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: factor disk iops stats into an helper
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: factor disk iops stats into an helper .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5b1c44d1de50d1a1a4078fe01d837920294711 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move extend and extendVolume
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move extend and extendVolume .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ad1769d7e4db6fc0883b37a67d071c278b96c8b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: deleteImage and deps
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: deleteImage and deps .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e418262d70ed50b45fdddf2fc77eb80a03a3811 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move image and volume enumeration
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move image and volume enumeration .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56214a7024b1f894b8e4e0b951faf0567a1606c9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: simplify hasVolumeLeases
automat...@ovirt.org has posted comments on this change. Change subject: storage: simplify hasVolumeLeases .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0c1cf341e7d028b5d4e30a27e9a045b43470e4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: Move getRepoPath and other metadata g...
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: Move getRepoPath and other metadata getters .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I571437a10a53d5aa20c83438350476d03111a704 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Create storagetestutils module
automat...@ovirt.org has posted comments on this change. Change subject: tests: Create storagetestutils module .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I713e19473b45bc05da5a1c888a034306144228c5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 5: * Update tracker::#1227793::OK * Check Bug-Url::OK * Check Public Bug::#1227793::OK, public bug * Check Product::#1227793::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: factor disk iops stats into an helper
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: factor disk iops stats into an helper .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5b1c44d1de50d1a1a4078fe01d837920294711 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (disk) .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: simplify hasVolumeLeases
Adam Litke has posted comments on this change.
Change subject: storage: simplify hasVolumeLeases
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43548/1/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:
Line 78:
Line 79: lockUtilPath = config.get('irs', 'lock_util_path')
Line 80: lockCmd = config.get('irs', 'lock_cmd')
Line 81: freeLockCmd = config.get('irs', 'free_lock_cmd')
Line 82: volumeLeasesSupported = False
> We are using supports_xxx in some others places (see git grep supports). Wo
Done
Line 83:
Line 84: def __init__(self, sdUUID, idsPath, leasesPath,
lockRenewalIntervalSec,
Line 85: leaseTimeSec, leaseFailRetry, ioOpTimeoutSec):
Line 86: self._lock = threading.Lock()
--
To view, visit https://gerrit.ovirt.org/43548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0c1cf341e7d028b5d4e30a27e9a045b43470e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Create storagetestutils module
Nir Soffer has posted comments on this change. Change subject: tests: Create storagetestutils module .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43547/2/tests/storagetestlib.py File tests/storagetestlib.py: Line 63: return vg_name Line 64: Line 65: Line 66: def get_metafile_path(domaindir): Line 67: return os.path.join(domaindir, sd.DOMAIN_META_DATA, sd.METADATA) > It's not trivial enough to be worth it. The proper path is built up after ok Line 68: Line 69: Line 70: def make_filesd_manifest(tmpdir, metadata=None): Line 71: sduuid = str(uuid.uuid4()) -- To view, visit https://gerrit.ovirt.org/43547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I713e19473b45bc05da5a1c888a034306144228c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: removing naming confilct in vmstats.py
Francesco Romani has posted comments on this change.
Change subject: virt: removing naming confilct in vmstats.py
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43657/1/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 184: last_nic = last_sample.get('net', {}).get(vm_nic.name, {})
Line 185: # may happen if nic is a new hot-plugged one
Line 186: if not first_nic or not last_nic:
Line 187: continue
Line 188: stats['network'][vm_nic.name] = nic(
in another patch, I will rename nic() as well.
Line 189: vm_nic.name, vm_nic.nicModel, vm_nic.macAddr,
Line 190: first_nic, last_nic, interval)
Line 191:
Line 192:
--
To view, visit https://gerrit.ovirt.org/43657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77307af135e0f6c3d8c5554e0f3fb4093e36ed0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Create storagetestutils module
Adam Litke has posted comments on this change.
Change subject: tests: Create storagetestutils module
..
Patch Set 2:
(10 comments)
https://gerrit.ovirt.org/#/c/43547/2/tests/storagetestlib.py
File tests/storagetestlib.py:
Line 22:
Line 23: from storage import sd, blockSD, fileSD
Line 24:
Line 25:
Line 26: NR_PVS = 5 # The number of fake PVs we use to make a fake VG
> Why do we need this? I think an optional parameter in make vg is nicer.
We already have a way to override it. You specify the device list yourself.
Line 27: MDSIZE = 524288 # The size (in bytes) of fake metadata files
Line 28:
Line 29:
Line 30: class FakeMetadata(dict):
Line 32: def transaction(self):
Line 33: yield
Line 34:
Line 35:
Line 36: def make_blocksd_manifest(tmpdir=None, metadata=None):
> Lets add the uuid as optional parameter, so code that like to create sds wi
Done
Line 37: sduuid = str(uuid.uuid4())
Line 38: if metadata is None:
Line 39: metadata = FakeMetadata()
Line 40: manifest = blockSD.BlockStorageDomainManifest(sduuid, metadata)
Line 43: os.makedirs(os.path.join(manifest.domaindir, sduuid,
sd.DOMAIN_IMAGES))
Line 44: return manifest
Line 45:
Line 46:
Line 47: def get_device_list(count):
> Rename to get_random_devices?
Done
Line 48: return ['/dev/mapper/{0}'.format(os.urandom(16).encode('hex'))
Line 49: for _ in range(count)]
Line 50:
Line 51:
Line 51:
Line 52: def make_vg(fake_lvm, manifest, devices=None):
Line 53: vg_name = manifest.sdUUID
Line 54: if devices is None:
Line 55: devices = get_device_list(NR_PVS)
> Lets add NR_PVS as optional parameter - pv_count=5
Done
Line 56: fake_lvm.createVG(vg_name, devices,
blockSD.STORAGE_UNREADY_DOMAIN_TAG,
Line 57: blockSD.VG_METADATASIZE)
Line 58: fake_lvm.createLV(vg_name, sd.METADATA, blockSD.SD_METADATA_SIZE)
Line 59:
Line 63: return vg_name
Line 64:
Line 65:
Line 66: def get_metafile_path(domaindir):
Line 67: return os.path.join(domaindir, sd.DOMAIN_META_DATA, sd.METADATA)
> Can we move this into the real code? sd.py? fileSD.py?
It's not trivial enough to be worth it. The proper path is built up after
initializing the manifest but we need to fake this file in place before we can
construct the manifest object.
Line 68:
Line 69:
Line 70: def make_filesd_manifest(tmpdir, metadata=None):
Line 71: sduuid = str(uuid.uuid4())
Line 77: os.makedirs(os.path.join(manifest.domaindir, sduuid,
sd.DOMAIN_IMAGES))
Line 78: return manifest
Line 79:
Line 80:
Line 81: def make_fake_metafile(metafile):
> This seems like a generic utility that belong in testlib.py, named make_fil
Done
Line 82: os.makedirs(os.path.dirname(metafile))
Line 83: with open(metafile, "w") as f:
Line 84: f.truncate(0)
Line 85:
Line 78: return manifest
Line 79:
Line 80:
Line 81: def make_fake_metafile(metafile):
Line 82: os.makedirs(os.path.dirname(metafile))
> This should handle the case where the directory exists, to make it more gen
Done
Line 83: with open(metafile, "w") as f:
Line 84: f.truncate(0)
Line 85:
Line 86:
Line 80:
Line 81: def make_fake_metafile(metafile):
Line 82: os.makedirs(os.path.dirname(metafile))
Line 83: with open(metafile, "w") as f:
Line 84: f.truncate(0)
> Better truncate to given size, default to 0?
Done
Line 85:
Line 86:
Line 87: def make_file_volume(domaindir, size, imguuid=None, voluuid=None):
Line 88: imguuid = imguuid or str(uuid.uuid4())
Line 92: mdfiles = [volpath + '.meta', volpath + '.lease']
Line 93: if not os.path.exists(imgpath):
Line 94: os.makedirs(imgpath)
Line 95: with open(volpath, "w") as f:
Line 96: f.truncate(size)
> This is same as make_fake_metafaile - lets reuse our utilities.
Done
Line 97: for mdfile in mdfiles:
Line 98: with open(mdfile, "w") as f:
Line 99: f.truncate(0)
Line 100: return imguuid, voluuid
Line 95: with open(volpath, "w") as f:
Line 96: f.truncate(size)
Line 97: for mdfile in mdfiles:
Line 98: with open(mdfile, "w") as f:
Line 99: f.truncate(0)
> This is same as make_fake_metafaile - lets reuse our utilities.
Done
Line 100: return imguuid, voluuid
--
To view, visit https://gerrit.ovirt.org/43547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I713e19473b45bc05da5a1c888a034306144228c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add ResourceLocker
Nir Soffer has posted comments on this change. Change subject: Add ResourceLocker .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43554/2/vdsm/storage/resourceLocker.py File vdsm/storage/resourceLocker.py: Line 40: if len(self._resources) >= LOCK_CACHE_SIZE: Line 41: self._drop_cached_lock() Line 42: if res not in self._resources: Line 43: self._resources[res] = RWLock() Line 44: self._resources[res].acquire(exclusive) > If this blocks, nobody can acquire any resource. This must be out of the lo To support timed acquire, we can use the new rwlock that support timeouts (https://gerrit.ovirt.org/42909). When an underlying lock times out, it may be caused by a deadlock. we can catch the rwlock.Timeout error here, and dump the internals of all locks, or detect if a possible deadlock (other thread holding the lock that timed out, waiting for a lock we are holding). Line 45: Line 46: def releaseResource(self, res): Line 47: with self._lock: Line 48: self._resources[res].release() -- To view, visit https://gerrit.ovirt.org/43554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29589889efd39920d72979e89405ff6cf36b803b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Move spm validation methods to StoragePool
Adam Litke has posted comments on this change. Change subject: sp: Move spm validation methods to StoragePool .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I115896cc67634741d7227fc00d8b294b3fe48ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
Ido Barkan has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/43684/2/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:
Line 882: if network_bonding:
Line 883: top_level_device = network_bonding
Line 884:
Line 885: vlan_id = network_attr.get('vlan', '')
Line 886: if vlan_id:
> I'd like to be more prudent in the future, and make sure vlan_id variables
Done
Line 887: underlying_device = network_bonding or
network_attr.get('nic', '')
Line 888: vlan_device = '.'.join([underlying_device, str(vlan_id)])
Line 889: top_level_device = vlan_device
Line 890: ifcfgs.add(vlan_device)
Line 896: ifcfgs.add((ROUTE_PREFIX + '%s') % top_level_device)
Line 897: ifcfgs.add((RULE_PREFIX + '%s') % top_level_device)
Line 898:
Line 899: return set(
Line 900: netinfo.NET_CONF_DIR + ifcfg
> we've had painful bugs due to trailing slashes. Use os.path.join() when pos
Done
Line 901: if (ifcfg.startswith(ROUTE_PREFIX) or
ifcfg.startswith(RULE_PREFIX))
Line 902: else netinfo.NET_CONF_PREF + ifcfg
Line 898:
Line 899: return set(
Line 900: netinfo.NET_CONF_DIR + ifcfg
Line 901: if (ifcfg.startswith(ROUTE_PREFIX) or
ifcfg.startswith(RULE_PREFIX))
Line 902: else netinfo.NET_CONF_PREF + ifcfg
> I think that adding ROUTE/RULE files into ifcfgs only adds complexity. Inst
not sure if this is exactly what you meant but string formatting can make it
simpler.
--
To view, visit https://gerrit.ovirt.org/43684
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spbackends: Move backend functions to spbackends
Adam Litke has posted comments on this change. Change subject: spbackends: Move backend functions to spbackends .. Patch Set 1: Code-Review+1 Seems like a common sense change to me. -- To view, visit https://gerrit.ovirt.org/43463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibde69dda90de62dea222a5ca5badca913749e75e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: make irs usage compatible with all others
Dan Kenigsberg has submitted this change and it was merged. Change subject: API: make irs usage compatible with all others .. API: make irs usage compatible with all others Change-Id: If993471c81dab1716af98a7a729fe498d93abb5d Signed-off-by: Yeela Kaplan Reviewed-on: https://gerrit.ovirt.org/43601 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/API.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Yeela Kaplan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If993471c81dab1716af98a7a729fe498d93abb5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: make irs usage compatible with all others
automat...@ovirt.org has posted comments on this change. Change subject: API: make irs usage compatible with all others .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If993471c81dab1716af98a7a729fe498d93abb5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
Dan Kenigsberg has posted comments on this change.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/43684/2/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:
Line 882: if network_bonding:
Line 883: top_level_device = network_bonding
Line 884:
Line 885: vlan_id = network_attr.get('vlan', '')
Line 886: if vlan_id:
I'd like to be more prudent in the future, and make sure vlan_id variables are
always integers (where vlan_id==0 kinda-make sense).
vlan_id = network_attr.get('vlan', None)
if vlan_id not None:
would be more prudent
Line 887: underlying_device = network_bonding or
network_attr.get('nic', '')
Line 888: vlan_device = '.'.join([underlying_device, str(vlan_id)])
Line 889: top_level_device = vlan_device
Line 890: ifcfgs.add(vlan_device)
Line 896: ifcfgs.add((ROUTE_PREFIX + '%s') % top_level_device)
Line 897: ifcfgs.add((RULE_PREFIX + '%s') % top_level_device)
Line 898:
Line 899: return set(
Line 900: netinfo.NET_CONF_DIR + ifcfg
we've had painful bugs due to trailing slashes. Use os.path.join() when
possible.
Line 901: if (ifcfg.startswith(ROUTE_PREFIX) or
ifcfg.startswith(RULE_PREFIX))
Line 902: else netinfo.NET_CONF_PREF + ifcfg
Line 898:
Line 899: return set(
Line 900: netinfo.NET_CONF_DIR + ifcfg
Line 901: if (ifcfg.startswith(ROUTE_PREFIX) or
ifcfg.startswith(RULE_PREFIX))
Line 902: else netinfo.NET_CONF_PREF + ifcfg
I think that adding ROUTE/RULE files into ifcfgs only adds complexity. Instead,
you can add their full path only now, right before returning the set.
fullpath = set(netinfo.NET_CONF_PREF + ifcfg
for ifcfg in ifcfgs)
fullpath.add(full_path_of_rule % top_level_device)
fullpath.add(full_path_of_route % top_level_device)
return fullpath
--
To view, visit https://gerrit.ovirt.org/43684
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add ResourceLocker
Nir Soffer has posted comments on this change. Change subject: Add ResourceLocker .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43554/2/vdsm/storage/resourceLocker.py File vdsm/storage/resourceLocker.py: Line 34: def __init__(self): Line 35: self._lock = threading.Lock() Line 36: self._resources = OrderedDict() Line 37: Line 38: def acquireResource(self, res, exclusive): > This make the caller calls much less clear: Another issue - to prevent locking of arbitrary strings, which may lead to in correct locking (e.g. on thread lock "domain_uuid", the other lock "domain_uuid" + "-" + "image_uuid", both thinking they locked the domain), how about renaming "res" to "uuid", and validating that the string is a uuid? This change means that anything you lock must have a uuid, so we may need to add uuids to some objects (e.g. domain monitor). And last, add a description optional parameter, so for each lock, we can log the thread id, name, the locked uuid, and the description of the lock (e.g. "locking source volume for live merge") Line 39: with self._lock: Line 40: if len(self._resources) >= LOCK_CACHE_SIZE: Line 41: self._drop_cached_lock() Line 42: if res not in self._resources: -- To view, visit https://gerrit.ovirt.org/43554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29589889efd39920d72979e89405ff6cf36b803b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spmprotect: Switch from fencing by pid to fencing using syst...
Nir Soffer has posted comments on this change. Change subject: spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/43211/7/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=TERM vdsmd.service Does kill and systemctl kill fail in the same way? For example, if systemctl kill may fail because connection to systemd daemon is broken, or systemd daemon is too busy or something, the operation may fail or take too much time, breaking the fencing logic. When running kill, we just need to do a syscall, it is less likely to fail. Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=KILL vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
Ido Barkan has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add new manifest_tests and storagefakelib to Makefile
automat...@ovirt.org has posted comments on this change. Change subject: tests: Add new manifest_tests and storagefakelib to Makefile .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5e756f5c067032cc488aea4fba1e6c42c5bf965 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add new manifest_tests and storagefakelib to Makefile
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add new manifest_tests and storagefakelib to Makefile .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5e756f5c067032cc488aea4fba1e6c42c5bf965 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add new manifest_tests and storagefakelib to Makefile
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Add new manifest_tests and storagefakelib to Makefile .. tests: Add new manifest_tests and storagefakelib to Makefile As an oversight in earlier patches, manifest_tests.py and storagefakelib.py were not properly added to Makefile.am. This meant that these files were not included in the vdsm-tests package. Fix this. Change-Id: If5e756f5c067032cc488aea4fba1e6c42c5bf965 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/43546 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5e756f5c067032cc488aea4fba1e6c42c5bf965 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: make irs usage compatible with all others
Yeela Kaplan has posted comments on this change. Change subject: API: make irs usage compatible with all others .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If993471c81dab1716af98a7a729fe498d93abb5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 1: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::#1203422::OK, correct target release 3.5.4 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: only backup ifcfg files if they are not already persisted.
Ido Barkan has uploaded a new change for review.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
net: only backup ifcfg files if they are not already persisted.
5fc7217 introduced backing up of ifcfg files that were not owned by
vdsm before the current call. Now, after selective restoration was
introduced, when a network is restored because it is different
from it's persistence, it is edited. This is done by removing it
(and it's ifcfg files) an re-add it. The result is that ifcfgs get
backed up also because they were just deleted by the current call,
and are now re-added. We end up with file placeholders that make vdsm
ifdown them during restoration. This defeats the whole selective
restoration feature.
In order to preserve the original meaning of _backup, we now
compute all the possible ifcfg files that are part of unified
persistence and backup only the ones that are not.
Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9
Signed-off-by: Ido Barkan
Bug-Url: https://bugzilla.redhat.com/1203422
---
M tests/functional/networkTests.py
M vdsm/network/configurators/ifcfg.py
2 files changed, 96 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/43685/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 03e3afd..6562eff 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -48,7 +48,7 @@
from vdsm.utils import RollbackContext, execCmd
from vdsm.netinfo import (bridges, operstate, prefix2netmask, getRouteDeviceTo,
getDhclientIfaces, BONDING_SLAVES, BONDING_MASTERS,
- NET_CONF_PREF)
+ NET_CONF_PREF, NET_CONF_BACK_DIR)
from vdsm import ipwrapper
from vdsm.utils import pgrep
@@ -1597,6 +1597,15 @@
self.vdsm_net.restoreNetConfig()
_assert_all_nets_exist()
+# no ifcfg backups should be left now that all ifcfgs are owned
+# by vdsm
+self.assertEqual([], os.listdir(NET_CONF_BACK_DIR))
+# another 'boot' should restore nothing
+RunningConfig().delete()
+with nonChangingOperstate(NET_UNCHANGED):
+with nonChangingOperstate(NET_CHANGED):
+with nonChangingOperstate(NET_MISSING):
+self.vdsm_net.restoreNetConfig()
finally:
self.setupNetworks(
{NET_UNCHANGED: {'remove': True},
@@ -1657,24 +1666,33 @@
self.assertBondExists(BOND_UNCHANGED, [nic_b])
self.assertBondExists(BOND_CHANGED, [nic_c], options='mode=4')
-def _simulate_boot_after_upgrade():
-# all non-management devices are down and have ONBOOT=no from older
-# vdsm versions.
+def _simulate_boot(change_bond=False, after_upgrade=False):
device_names = (NET_UNCHANGED, BOND_UNCHANGED, nic_b, NET_CHANGED,
BOND_CHANGED, nic_c)
-stop_devices((NET_CONF_PREF + name for name in device_names))
+if after_upgrade:
+stop_devices((NET_CONF_PREF + name for name in device_names))
for dev in device_names:
with open(NET_CONF_PREF + dev) as f:
content = f.read()
-# also test the case that a bond is different from it's
-# backup
-content = re.sub('ONBOOT=yes', 'ONBOOT=no', content)
-if dev == BOND_CHANGED:
+if after_upgrade:
+# all non-management devices are down and have ONBOOT=no
+# from older vdsm versions.
+content = re.sub('ONBOOT=yes', 'ONBOOT=no', content)
+if change_bond and dev == BOND_CHANGED:
+# also test the case that a bond is different from it's
+# backup
content = re.sub('mode=4', 'mode=0', content)
with open(NET_CONF_PREF + dev, 'w') as f:
f.write(content)
# we don't have running config during boot
RunningConfig().delete()
+
+def _verify_running_config_intact():
+self.assertEqual(set([NET_MGMT, NET_CHANGED, NET_UNCHANGED,
+ NET_ADDITIONAL]),
+ set(self.vdsm_net.config.networks.keys()))
+self.assertEqual(set([BOND_CHANGED, BOND_UNCHANGED]),
+ set(self.vdsm_net.config.bonds.keys()))
with dummyIf(4) as nics:
nic_a, nic_b, nic_c, nic_d = nics
@@ -1689,21 +1707,32 @@
try:
self.vdsm_net.save_config()
-_simulate_boot_after_upgrade()
+_simulate_boot(change_b
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
Francesco Romani has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (disk) .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43682/2/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 270: def _disk_latency(first_sample, first_index, last_sample, last_index): Line 271: def compute_latency(ltype): Line 272: operations = ( Line 273: last_sample['block.%d.%s.ops' % (last_index, ltype)] - Line 274: first_sample['block.%d.%s.ops' % (first_index, ltype)] s/ops/reqs/ Line 275: ) Line 276: if not operations: Line 277: return 0 Line 278: elapsed_time = ( -- To view, visit https://gerrit.ovirt.org/43682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 2: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: functional tests: virt: fix devices verification
Yeela Kaplan has posted comments on this change. Change subject: functional tests: virt: fix devices verification .. Patch Set 1: -Verified (1 comment) https://gerrit.ovirt.org/#/c/43600/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-14 18:06:14 +0300 Line 4: Commit: Yeela Kaplan Line 5: CommitDate: 2015-07-14 18:06:14 +0300 Line 6: Line 7: functional tests: virt: fix devices verification > getVmList returns Looks like it's an issue introduced by the jsonrpc bridge translation. I will investigate this further. It's behaving differently there. Line 8: Line 9: Change-Id: I774dfdb3f0bde3822df383c54060b41ba7a2cda6 -- To view, visit https://gerrit.ovirt.org/43600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I774dfdb3f0bde3822df383c54060b41ba7a2cda6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
Francesco Romani has posted comments on this change.
Change subject: vmstats: fix bulk stats misinterpretation (net)
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/43679/4/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 137: else:
Line 138: logging.error('Failed to get VM cpu count')
Line 139:
Line 140:
Line 141: def nic(name, model, mac,
let's add one unit test for this, to make sure this will not happen again
Line 142: start_sample, start_index,
Line 143: end_sample, end_index, interval):
Line 144: ifSpeed = [100, 1000][model in ('e1000', 'virtio')]
Line 145:
Line 282: def _usage_percentage(val, interval):
Line 283: return 100 * val / interval / 1000 ** 3
Line 284:
Line 285:
Line 286: def _find_bulk_stat_index(stats, group, value, attr='name'):
this deserves a test as well
Line 287: if stats:
Line 288: for idx in six.moves.xrange(stats['%s.count' % group]):
Line 289: if stats['%s.%d.%s' % (group, idx, attr)] == value:
Line 290: return idx
--
To view, visit https://gerrit.ovirt.org/43679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
Ido Barkan has uploaded a new change for review.
Change subject: net: only backup ifcfg files if they are not already persisted.
..
net: only backup ifcfg files if they are not already persisted.
d6454e introduced backing up of ifcfg files that were not owned by
vdsm before the current call. Now, after selective restoration was
introduced, when a network is restored because it is different
from it's persistence, it is edited. This is done by removing it
(and it's ifcfg files) an re-add it. The result is that ifcfgs get
backed up also because they were just deleted by the current call,
and are now re-added. We end up with file placeholders that make vdsm
ifdown them during restoration. This defeats the whole selective
restoration feature.
In order to preserve the original meaning of _backup, we now
compute all the possible ifcfg files that are part of unified
persistence and backup only the ones that are not.
Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9
Signed-off-by: Ido Barkan
---
M tests/functional/networkTests.py
M vdsm/network/configurators/ifcfg.py
2 files changed, 96 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/43684/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 6ccd114..efbc54b 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -35,7 +35,7 @@
from vdsm.netinfo import (bridges, operstate, getRouteDeviceTo,
_get_dhclient_ifaces, BONDING_SLAVES,
BONDING_MASTERS, NET_CONF_PREF, OPERSTATE_UNKNOWN,
- OPERSTATE_UP)
+ OPERSTATE_UP, NET_CONF_BACK_DIR)
from vdsm.netlink import monitor
from vdsm import sysctl
from vdsm.utils import CommandPath, RollbackContext, execCmd, pgrep, running
@@ -1565,6 +1565,15 @@
self.vdsm_net.restoreNetConfig()
_assert_all_nets_exist()
+# no ifcfg backups should be left now that all ifcfgs are owned
+# by vdsm
+self.assertEqual([], os.listdir(NET_CONF_BACK_DIR))
+# another 'boot' should restore nothing
+RunningConfig().delete()
+with nonChangingOperstate(NET_UNCHANGED):
+with nonChangingOperstate(NET_CHANGED):
+with nonChangingOperstate(NET_MISSING):
+self.vdsm_net.restoreNetConfig()
finally:
self.setupNetworks(
{NET_UNCHANGED: {'remove': True},
@@ -1623,24 +1632,33 @@
self.assertBondExists(BOND_UNCHANGED, [nic_b])
self.assertBondExists(BOND_CHANGED, [nic_c], options='mode=4')
-def _simulate_boot_after_upgrade():
-# all non-management devices are down and have ONBOOT=no from older
-# vdsm versions.
+def _simulate_boot(change_bond=False, after_upgrade=False):
device_names = (NET_UNCHANGED, BOND_UNCHANGED, nic_b, NET_CHANGED,
BOND_CHANGED, nic_c)
-stop_devices((NET_CONF_PREF + name for name in device_names))
+if after_upgrade:
+stop_devices((NET_CONF_PREF + name for name in device_names))
for dev in device_names:
with open(NET_CONF_PREF + dev) as f:
content = f.read()
-# also test the case that a bond is different from it's
-# backup
-content = re.sub('ONBOOT=yes', 'ONBOOT=no', content)
-if dev == BOND_CHANGED:
+if after_upgrade:
+# all non-management devices are down and have ONBOOT=no
+# from older vdsm versions.
+content = re.sub('ONBOOT=yes', 'ONBOOT=no', content)
+if change_bond and dev == BOND_CHANGED:
+# also test the case that a bond is different from it's
+# backup
content = re.sub('mode=4', 'mode=0', content)
with open(NET_CONF_PREF + dev, 'w') as f:
f.write(content)
# we don't have running config during boot
RunningConfig().delete()
+
+def _verify_running_config_intact():
+self.assertEqual({NET_MGMT, NET_CHANGED, NET_UNCHANGED,
+ NET_ADDITIONAL},
+ set(self.vdsm_net.config.networks.keys()))
+self.assertEqual({BOND_CHANGED, BOND_UNCHANGED},
+ set(self.vdsm_net.config.bonds.keys()))
with dummyIf(4) as nics:
nic_a, nic_b, nic_c, nic_d = nics
@@ -1655,21 +1673,32 @@
try:
self.vdsm_net.save_config()
-_simulate_boot_after_upgrade()
+_simu
Change in vdsm[master]: net: only backup ifcfg files if they are not already persisted.
automat...@ovirt.org has posted comments on this change. Change subject: net: only backup ifcfg files if they are not already persisted. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d99efb8141cf7c6409050170c24714899c64be9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: factor disk iops stats into an helper
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: factor disk iops stats into an helper .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5b1c44d1de50d1a1a4078fe01d837920294711 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 4: * Update tracker::#1227793::OK * Check Bug-Url::OK * Check Public Bug::#1227793::OK, public bug * Check Product::#1227793::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (disk) .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
Francesco Romani has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43679/3//COMMIT_MSG Commit Message: Line 8: Line 9: The current vmstats code is assuming that the bulk stats samples Line 10: are in a different format than they really are. Line 11: This mistake dates back to the lastest iterations of bulk stats Line 12: development, when various approaches to fecth and store bulk stats > fetch Done Line 13: samples were experimented, while looking for good performances. Line 14: Line 15: In the end, we settled for the simplest approach, for the sake of Line 16: performance. Somehow, the translation patch was lost, most likely in -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: total rx/tx stats not send to engine
Francesco Romani has posted comments on this change.
Change subject: virt: total rx/tx stats not send to engine
..
Patch Set 1: Code-Review-1
(1 comment)
thanks for fixing this embarassing mistake of mine.
The problem here is the unneeded of the translation of samples, which I'd like
to avoid, bacause seems wasteful and pointless. Instead I'd just construct and
use the right keys, like I did in https://gerrit.ovirt.org/#/c/43679/ to fix
this and the disk misinterpretation.
So, I think it is easier if you just abandon this and review 43679.
https://gerrit.ovirt.org/#/c/43672/1/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 189: vm_nic.name, vm_nic.nicModel, vm_nic.macAddr,
Line 190: first_nic, last_nic, interval)
Line 191:
Line 192:
Line 193: def nic_sample(stats, vm_nic_name):
no need to translate the samples. We should use direcly the right keys instead,
like this:
https://gerrit.ovirt.org/#/c/43679/
Line 194: sample = {}
Line 195: ifc_count = -1
Line 196: while True:
Line 197: ifc_count += 1
--
To view, visit https://gerrit.ovirt.org/43672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I702a80f19553372e01ba022afaa07d766258062f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
Martin Polednik has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43679/3//COMMIT_MSG Commit Message: Line 8: Line 9: The current vmstats code is assuming that the bulk stats samples Line 10: are in a different format than they really are. Line 11: This mistake dates back to the lastest iterations of bulk stats Line 12: development, when various approaches to fecth and store bulk stats fetch Line 13: samples were experimented, while looking for good performances. Line 14: Line 15: In the end, we settled for the simplest approach, for the sake of Line 16: performance. Somehow, the translation patch was lost, most likely in -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (net) .. Patch Set 3: * Update tracker::#1227793::OK * Check Bug-Url::OK * Check Public Bug::#1227793::OK, public bug * Check Product::#1227793::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: fix bulk stats misinterpretation (disk)
..
vmstats: fix bulk stats misinterpretation (disk)
The current vmstats code is assuming that the bulk stats samples
are in a different format than they really are.
This mistake dates back to the lastest iterations of bulk stats
development, when various approaches to fecth and store bulk stats
samples were experimented, while looking for good performances.
In the end, we settled for the simplest approach, for the sake of
performance. Somehow, the translation patch was lost, most likely in
one bad rebase.
The effect of this mistake is that some disk stats
were lost, while others are still correctly reported.
This could explaain why it took so long to notice this failure: some
data was still present and correctly reported.
This patch recovers and reimplements the translation strategy,
and makes sure that we access the bulk stats samples using
the right keys.
Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300
Signed-off-by: Francesco Romani
---
M vdsm/virt/vmstats.py
1 file changed, 33 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/43682/1
diff --git a/vdsm/virt/vmstats.py b/vdsm/virt/vmstats.py
index 842fa11..3ea8497 100644
--- a/vdsm/virt/vmstats.py
+++ b/vdsm/virt/vmstats.py
@@ -222,15 +222,22 @@
drive_stats['imageID'] = vm_drive.imageID
elif "GUID" in vm_drive:
drive_stats['lunGUID'] = vm_drive.GUID
-first_disk = first_sample.get('block', {}).get(vm_drive.name, {})
-last_disk = last_sample.get('block', {}).get(vm_drive.name, {})
-if first_disk and last_disk:
+
+first_index = _find_bulk_stat_index(
+first_sample, 'block', vm_drive.name)
+last_index = _find_bulk_stat_index(
+last_sample, 'block', vm_drive.name)
+
+if first_index is not None and last_index is not None:
# will be None if sampled during recovery
if interval > 0:
drive_stats.update(
-_disk_rate(first_disk, last_disk, interval))
+_disk_rate(first_sample, first_index,
+ last_sample, last_index,
+ interval))
drive_stats.update(
-_disk_latency(first_disk, last_disk))
+_disk_latency(first_sample, first_index,
+ last_sample, last_index))
else:
logging.warning(
'invalid interval %i when calculating '
@@ -238,7 +245,8 @@
interval, vm.id, vm_drive.name)
drive_stats.update(
-_disk_iops_bytes(last_sample[vm_drive.name]))
+_disk_iops_bytes(first_sample, first_index,
+ last_sample, last_index))
except AttributeError:
logging.exception("Disk %s stats not available",
@@ -247,24 +255,30 @@
stats[vm_drive.name] = drive_stats
-def _disk_rate(first_sample, last_sample, interval):
+def _disk_rate(first_sample, first_index, last_sample, last_index, interval):
return {
'readRate': (
-(last_sample['rd.bytes'] - first_sample['rd.bytes'])
+(last_sample['block.%d.rd.bytes' % last_index] -
+ first_sample['block.%d.rd.bytes' % first_index])
/ interval),
'writeRate': (
-(last_sample['wr.bytes'] - first_sample['wr.bytes'])
+(last_sample['block.%d.wr.bytes' % last_index] -
+ first_sample['block.%d.wr.bytes' % first_index])
/ interval)}
-def _disk_latency(first_sample, last_sample):
+def _disk_latency(first_sample, first_index, last_sample, last_index):
def compute_latency(ltype):
-ops = ltype + '.reqs'
-operations = last_sample[ops] - first_sample[ops]
+operations = (
+last_sample['block.%d.%s.ops' % (last_index, ltype)] -
+first_sample['block.%d.%s.ops' % (first_index, ltype)]
+)
if not operations:
return 0
-times = ltype + '.times'
-elapsed_time = last_sample[times] - first_sample[times]
+elapsed_time = (
+last_sample['block.%d.%s.times' % (last_index, ltype)] -
+first_sample['block.%d.%s.times' % (first_index, ltype)]
+)
return elapsed_time / operations
return {'readLatency': str(compute_latency('rd')),
@@ -272,12 +286,12 @@
'flushLatency': str(compute_latency('fl'))}
-def _disk_iops_bytes(drive_info):
+def _disk_iops_bytes(first_sample, first_index, last_sample, last_index):
return {
-'rea
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation (disk) .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: factor disk iops stats into an helper
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: factor disk iops stats into an helper .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5b1c44d1de50d1a1a4078fe01d837920294711 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: factor disk iops stats into an helper
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: factor disk iops stats into an helper
..
vmstats: factor disk iops stats into an helper
Move the code with fetches the per-disk ops
and data transferred in a little, separate helper.
Only code move.
Change-Id: I1f5b1c44d1de50d1a1a4078fe01d837920294711
Signed-off-by: Francesco Romani
---
M vdsm/virt/vmstats.py
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/43681/1
diff --git a/vdsm/virt/vmstats.py b/vdsm/virt/vmstats.py
index 390cf37..842fa11 100644
--- a/vdsm/virt/vmstats.py
+++ b/vdsm/virt/vmstats.py
@@ -237,11 +237,8 @@
'stats for vm %s disk %s',
interval, vm.id, vm_drive.name)
-drive_info = last_sample[vm_drive.name]
-drive_stats['readOps'] = str(drive_info['rd.reqs'])
-drive_stats['writeOps'] = str(drive_info['wr.reqs'])
-drive_stats['readBytes'] = str(drive_info['rd.bytes'])
-drive_stats['writtenBytes'] = str(drive_info['wr.bytes'])
+drive_stats.update(
+_disk_iops_bytes(last_sample[vm_drive.name]))
except AttributeError:
logging.exception("Disk %s stats not available",
@@ -275,6 +272,15 @@
'flushLatency': str(compute_latency('fl'))}
+def _disk_iops_bytes(drive_info):
+return {
+'readOps': str(drive_info['rd.reqs']),
+'writeOps': str(drive_info['wr.reqs']),
+'readBytes': str(drive_info['rd.bytes']),
+'writtenBytes': str(drive_info['wr.bytes']),
+}
+
+
def _diff(prev, curr, val):
return prev[val] - curr[val]
--
To view, visit https://gerrit.ovirt.org/43681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f5b1c44d1de50d1a1a4078fe01d837920294711
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation
Francesco Romani has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation .. Patch Set 2: Code-Review-1 splitting as Marcin requested -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix name clash
Francesco Romani has abandoned this change. Change subject: vmstats: fix name clash .. Abandoned let's take https://gerrit.ovirt.org/#/c/43657/1/vdsm/virt/vmstats.py instead -- To view, visit https://gerrit.ovirt.org/43680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id157910d1425f88d50e86d248c2f42e2f55e26c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix name clash
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix name clash .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id157910d1425f88d50e86d248c2f42e2f55e26c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: removing naming confilct in vmstats.py
Francesco Romani has posted comments on this change. Change subject: virt: removing naming confilct in vmstats.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77307af135e0f6c3d8c5554e0f3fb4093e36ed0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation
Marcin Mirecki has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation .. Patch Set 1: Can you split the changes for the discs and network into different patches? -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix name clash
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: fix name clash
..
vmstats: fix name clash
inside the network() function, we iterate over the VM nic devices,
using the 'nic' loop variable.
Later in the same loop, we want to grab the per-nic stats using the
'nic' function.
This cannot possibly work ('nic' interface variable is not callable, and
even if it was, it wouldn't do what code wanted to do), so
we rename the vmstats.nic() function to restore the network statistics.
Change-Id: Id157910d1425f88d50e86d248c2f42e2f55e26c0
Signed-off-by: Francesco Romani
---
M vdsm/virt/vmstats.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/43680/1
diff --git a/vdsm/virt/vmstats.py b/vdsm/virt/vmstats.py
index b9caeac..cc0b4bc 100644
--- a/vdsm/virt/vmstats.py
+++ b/vdsm/virt/vmstats.py
@@ -136,7 +136,7 @@
logging.error('Failed to get VM cpu count')
-def nic(name, model, mac, start_sample, end_sample, interval):
+def _nic_traffic(name, model, mac, start_sample, end_sample, interval):
ifSpeed = [100, 1000][model in ('e1000', 'virtio')]
ifStats = {'macAddr': mac,
@@ -185,7 +185,7 @@
# may happen if nic is a new hot-plugged one
if not first_nic or not last_nic:
continue
-stats['network'][nic.name] = nic(
+stats['network'][nic.name] = _nic_traffic(
nic.name, nic.nicModel, nic.macAddr,
first_nic, last_nic, interval)
--
To view, visit https://gerrit.ovirt.org/43680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id157910d1425f88d50e86d248c2f42e2f55e26c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix name clash
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix name clash .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id157910d1425f88d50e86d248c2f42e2f55e26c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs with periodic false negative
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs with periodic false negative .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f0f5a46bcb8ed1197fe389a0b2904fa6939659d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: executor: allow caller to resize TaskQueue
automat...@ovirt.org has posted comments on this change. Change subject: executor: allow caller to resize TaskQueue .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df4d8bbc599fa2de1dc17de8fbd2726809f5de3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs if sampling hollow VMs
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs if sampling hollow VMs .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation .. Patch Set 2: * Update tracker::#1227793::OK * Check Bug-Url::OK * Check Public Bug::#1227793::OK, public bug * Check Product::#1227793::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: virt: do not poll storage in migrations
automat...@ovirt.org has posted comments on this change. Change subject: periodic: virt: do not poll storage in migrations .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: stats: remove try/except for KeyError
automat...@ovirt.org has posted comments on this change. Change subject: sampling: stats: remove try/except for KeyError .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40120e3f89a812126b9dd74495be6a1fad461b17 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: executor: allow caller to resize TaskQueue
automat...@ovirt.org has posted comments on this change. Change subject: executor: allow caller to resize TaskQueue .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df4d8bbc599fa2de1dc17de8fbd2726809f5de3 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs with periodic false negative
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs with periodic false negative .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f0f5a46bcb8ed1197fe389a0b2904fa6939659d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: fix bulk stats misinterpretation .. Patch Set 1: * Update tracker::#1227793::OK * Check Bug-Url::OK * Check Public Bug::#1227793::OK, public bug * Check Product::#1227793::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs if sampling hollow VMs
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs if sampling hollow VMs .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: virt: do not poll storage in migrations
automat...@ovirt.org has posted comments on this change. Change subject: periodic: virt: do not poll storage in migrations .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: fix bulk stats misinterpretation
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: fix bulk stats misinterpretation
..
vmstats: fix bulk stats misinterpretation
The current vmstats code is assuming that the bulk stats samples
are in a different format than they really are.
This mistake probably dates back to the lastest days of bulk stats
development, when various approaches to fecth and store bulk stats
samples were experimented.
In the end, we settled for the simplest one, for the sake of
performance. Somehow, the translation patch was lost, probably in
one failed rebase.
The stats which are lost are the one which deals with multiple devices.
The bug is that we try to access the samples using wrong keys,
mistakenly assuming a nested namespace, while the samples are flat.
The effect of this mistake is that SOME network and SOME disk stats
were lost, while others are still correctly reported.
This probably explain why it took so long to notice this failure.
This patch recovers and reimplements the translation
strategy, and make sure that we access the bulk stats samples using
the right keys.
Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1227793
Signed-off-by: Francesco Romani
---
M vdsm/virt/vmstats.py
1 file changed, 79 insertions(+), 35 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/43679/1
diff --git a/vdsm/virt/vmstats.py b/vdsm/virt/vmstats.py
index b9caeac..78e2bd8 100644
--- a/vdsm/virt/vmstats.py
+++ b/vdsm/virt/vmstats.py
@@ -20,6 +20,8 @@
import logging
+import six
+
from vdsm.utils import monotonic_time
from .utils import isVdsmImage
@@ -136,26 +138,34 @@
logging.error('Failed to get VM cpu count')
-def nic(name, model, mac, start_sample, end_sample, interval):
+def nic(name, model, mac,
+start_sample, start_index,
+end_sample, end_index, interval):
ifSpeed = [100, 1000][model in ('e1000', 'virtio')]
-ifStats = {'macAddr': mac,
- 'name': name,
- 'speed': str(ifSpeed),
- 'state': 'unknown'}
+ifStats = {
+'macAddr': mac,
+'name': name,
+'speed': str(ifSpeed),
+'state': 'unknown'
+}
-ifStats['rxErrors'] = str(end_sample['rx.errs'])
-ifStats['rxDropped'] = str(end_sample['rx.drop'])
-ifStats['txErrors'] = str(end_sample['tx.errs'])
-ifStats['txDropped'] = str(end_sample['tx.drop'])
+ifStats['rxErrors'] = str(end_sample['net.%d.rx.errs' % end_index])
+ifStats['rxDropped'] = str(end_sample['net.%d.rx.drop' % end_index])
+ifStats['txErrors'] = str(end_sample['net.%d.tx.errs' % end_index])
+ifStats['txDropped'] = str(end_sample['net.%d.tx.drop' % end_index])
rxDelta = (
-end_sample['rx.bytes'] - start_sample['rx.bytes'])
+end_sample['net.%d.rx.bytes' % end_index] -
+start_sample['net.%d.rx.bytes' % start_index]
+)
ifRxBytes = (100.0 *
(rxDelta % 2 ** 32) /
interval / ifSpeed / _MBPS_TO_BPS)
txDelta = (
-end_sample['tx.bytes'] - start_sample['tx.bytes'])
+end_sample['net.%d.tx.bytes' % end_index] -
+start_sample['net.%d.tx.bytes' % start_index]
+)
ifTxBytes = (100.0 *
(txDelta % 2 ** 32) /
interval / ifSpeed / _MBPS_TO_BPS)
@@ -163,8 +173,8 @@
ifStats['rxRate'] = '%.1f' % ifRxBytes
ifStats['txRate'] = '%.1f' % ifTxBytes
-ifStats['rx'] = str(end_sample['rx.bytes'])
-ifStats['tx'] = str(end_sample['tx.bytes'])
+ifStats['rx'] = str(end_sample['net.%d.rx.bytes' % end_index])
+ifStats['tx'] = str(end_sample['net.%d.tx.bytes' % end_index])
ifStats['sampleTime'] = monotonic_time()
return ifStats
@@ -180,14 +190,20 @@
if nic.name.startswith('hostdev'):
continue
-first_nic = first_sample.get('net', {}).get(nic.name, {})
-last_nic = last_sample.get('net', {}).get(nic.name, {})
+first_index = _find_bulk_stat_index(
+first_sample, 'net', nic.name)
+last_index = _find_bulk_stat_index(
+last_sample, 'net', nic.name)
+
# may happen if nic is a new hot-plugged one
-if not first_nic or not last_nic:
+if first_index is None or last_index is None:
continue
+
stats['network'][nic.name] = nic(
nic.name, nic.nicModel, nic.macAddr,
-first_nic, last_nic, interval)
+first_sample, first_index,
+last_sample, last_index,
+interval)
def disks(vm, stats, first_sample, last_sample, interval):
@@ -208,26 +224,31 @@
drive_stats['imageID'] = vm_drive.imageID
elif "GUID" in vm_drive:
drive_stats['lunGUID'] = vm_drive.GUID
-first_disk = first_sample.get('block', {}).get(vm_drive.
Change in vdsm[master]: sampling: stats: remove try/except for KeyError
automat...@ovirt.org has posted comments on this change. Change subject: sampling: stats: remove try/except for KeyError .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40120e3f89a812126b9dd74495be6a1fad461b17 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: make irs usage compatible with all others
Dan Kenigsberg has posted comments on this change. Change subject: API: make irs usage compatible with all others .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If993471c81dab1716af98a7a729fe498d93abb5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add new manifest_tests and storagefakelib to Makefile
Adam Litke has posted comments on this change. Change subject: tests: Add new manifest_tests and storagefakelib to Makefile .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5e756f5c067032cc488aea4fba1e6c42c5bf965 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add test for SR-IOV guest addressing
Martin Polednik has posted comments on this change. Change subject: hostdev: add test for SR-IOV guest addressing .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c204101290294d5b8b9819b9acca871a9976322 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev tests: fake totalvfs
Martin Polednik has posted comments on this change. Change subject: hostdev tests: fake totalvfs .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b7097b0e89ca79848c9e56f526692322e759f6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev tests: refactor common PCI addresses
Martin Polednik has posted comments on this change. Change subject: hostdev tests: refactor common PCI addresses .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id396f92a8f0454bb9b0abc36932fde1b67f6c9d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add test for SR-IOV VF
Martin Polednik has posted comments on this change. Change subject: hostdev: add test for SR-IOV VF .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43094 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bf2e07f492508757be2691417c706219ded54af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: total rx/tx stats not send to engine
Francesco Romani has posted comments on this change. Change subject: virt: total rx/tx stats not send to engine .. Patch Set 1: ouch. This means that it was a mistake (of mine) to abandon mine https://gerrit.ovirt.org/#/c/36731/ -- To view, visit https://gerrit.ovirt.org/43672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I702a80f19553372e01ba022afaa07d766258062f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: functional tests: virt: fix devices verification
Martin Polednik has posted comments on this change.
Change subject: functional tests: virt: fix devices verification
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43600/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-07-14 18:06:14 +0300
Line 4: Commit: Yeela Kaplan
Line 5: CommitDate: 2015-07-14 18:06:14 +0300
Line 6:
Line 7: functional tests: virt: fix devices verification
> getVmList returns a list of UUIDs, so you can't use it to access devices ke
getVmList returns
{'status': 'Up', 'kernel': '/boot/vmlinuz-3.10.0-229.4.2.el7.x86_64',
'displayIp': '0', 'kvmEnable': 'true', 'nicModel': 'rtl8139,pv', 'smp': '1',
'vmId': '----', 'pid': '24535', 'devices':
[{'device': 'memballoon', 'specParams': {'model': 'none'}, 'type': 'balloon',
'alias': 'balloon0'}, {'device': 'virtio-serial', 'alias': 'virtio-serial0',
'type': 'controller', 'address': {'slot': '0x03', 'bus': '0x00', 'domain':
'0x', 'type': 'pci', 'function': '0x0'}}, {'device': 'qxl', 'specParams':
{'vram': '65536'}, 'alias': 'video0', 'type': 'video', 'address': {'slot':
'0x02', 'bus': '0x00', 'domain': '0x', 'type': 'pci', 'function': '0x0'}},
{'device': 'spice', 'specParams': {'displayIp': '0'}, 'type': 'graphics',
'port': '5900', 'tlsPort': '5901'}, {'index': 2, 'iface': 'ide', 'name': 'hdc',
'format': 'raw', 'alias': 'ide0-1-0', 'readonly': 'True', 'propagateErrors':
'off', 'address': {'bus': '1', 'controller': '0', 'type': 'drive', 'target!
': '0', 'unit': '0'}, 'device': 'cdrom', 'shared': False, 'path': '',
'truesize': 0, 'type': 'disk'}, {'device': 'usb', 'alias': 'usb0', 'type':
'controller', 'address': {'slot': '0x01', 'bus': '0x00', 'domain': '0x',
'type': 'pci', 'function': '0x2'}}, {'device': 'ide', 'alias': 'ide0', 'type':
'controller', 'address': {'slot': '0x01', 'bus': '0x00', 'domain': '0x',
'type': 'pci', 'function': '0x1'}}, {'device': 'unix', 'alias': 'channel0',
'type': 'channel', 'address': {'bus': '0', 'controller': '0', 'type':
'virtio-serial', 'port': '1'}}, {'device': 'unix', 'alias': 'channel1', 'type':
'channel', 'address': {'bus': '0', 'controller': '0', 'type': 'virtio-serial',
'port': '2'}}, {'device': 'spicevmc', 'alias': 'channel2', 'type': 'channel',
'address': {'bus': '0', 'controller': '0', 'type': 'virtio-serial', 'port':
'3'}}], 'guestDiskMapping': {}, 'pauseCode': 'NOERR', 'vmType': 'kvm',
'initrd': '/boot/initramfs-3.10.0-229.4.2.el7.x86_64.img', 'displaySecurePort':
!
'5901', 'memSize': 256, 'displayPort': '5900', 'clientIp': '', 'statusTime':
'4389053540', 'vmName': 'testSimpleVm', 'display': 'qxl', 'kernelArgs':
'rd.break=cmdline rd.shell rd.skipfsck'}
in current implementation of functional tests
Line 8:
Line 9: Change-Id: I774dfdb3f0bde3822df383c54060b41ba7a2cda6
--
To view, visit https://gerrit.ovirt.org/43600
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I774dfdb3f0bde3822df383c54060b41ba7a2cda6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: remove unrelevant sdCache.produce for uploadImage
automat...@ovirt.org has posted comments on this change. Change subject: hsm: remove unrelevant sdCache.produce for uploadImage .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916e79a31b27c346e2c72a0d152a01d890a38162 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: remove unrelevant sdCache.produce for uploadImage
Maor Lipchuk has abandoned this change. Change subject: hsm: remove unrelevant sdCache.produce for uploadImage .. Abandoned squashing the patches as Nir suggested -- To view, visit https://gerrit.ovirt.org/43295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I916e79a31b27c346e2c72a0d152a01d890a38162 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Remove unrelevant sdCache.produce
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Remove unrelevant sdCache.produce .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cceef3400e5ce4781d9722c7d2f7817fef8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make vm events callback public
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: make vm events callback public .. virt: make vm events callback public The Vm class has a few methods which are meant to be called when libvirt reports events. Examples: Vm._onLibvirtLifecycleEvent Vm._onWatchdogEvent Vm._rtcUpdate So they should be public, and they should be named such that it is obvious they are meant to be callbacks. This patch only renames without code changes. Change-Id: Ib17737a3e4acb99bc67fae67919d71fe17ee771d Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/43308 Reviewed-by: Michal Skrivanek Reviewed-by: Martin Polednik Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg --- M tests/vmTests.py M vdsm/clientIF.py M vdsm/virt/vm.py 3 files changed, 18 insertions(+), 18 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib17737a3e4acb99bc67fae67919d71fe17ee771d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make vm events callback public
automat...@ovirt.org has posted comments on this change. Change subject: virt: make vm events callback public .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib17737a3e4acb99bc67fae67919d71fe17ee771d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Rescan fiber channel devices
Dan Kenigsberg has submitted this change and it was merged. Change subject: resize-lun: Rescan fiber channel devices .. resize-lun: Rescan fiber channel devices The fc-scan utility currently scans in order to find new LUNs. In order to detect a resize of fiber channel LUNs, rescan of existing devices is needed. Change-Id: I201312c44fec30d11ad62823558aa10ad7f7991b Bug-Url: https://bugzilla.redhat.com/609689 Signed-off-by: Fred Rolland Reviewed-on: https://gerrit.ovirt.org/43388 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Allon Mureinik Reviewed-by: Adam Litke --- M vdsm/storage/fc-scan 1 file changed, 48 insertions(+), 6 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I201312c44fec30d11ad62823558aa10ad7f7991b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
