Change in vdsm[master]: network: fix parameters to ConfigNetworkError
Ido Barkan has posted comments on this change. Change subject: network: fix parameters to ConfigNetworkError .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2358521cbe8c39cb2208c8a3f9f96313dd693c7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
Nir Soffer has abandoned this change. Change subject: Experiment with delay after running tc .. Abandoned Does not work -- To view, visit https://gerrit.ovirt.org/44375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with delay after running tc .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/44375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Replace brctl with ip
Nir Soffer has posted comments on this change. Change subject: nettestlib: Replace brctl with ip .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/44379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netestlib: Remove code for 2.x kernels
Nir Soffer has posted comments on this change. Change subject: netestlib: Remove code for 2.x kernels .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/44380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c1ea072398791173aeb3fe7f931933d0388651 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netestlib: Remove code for 2.x kernels
Nir Soffer has uploaded a new change for review.
Change subject: netestlib: Remove code for 2.x kernels
..
netestlib: Remove code for 2.x kernels
We support now 3.x or 4.x kernels only.
Change-Id: I98c1ea072398791173aeb3fe7f931933d0388651
Signed-off-by: Nir Soffer
---
M tests/nettestlib.py
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/44380/1
diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 0010379..21f71d5 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -74,11 +74,6 @@
def addDevice(self):
check_call([EXT_BRCTL, 'addbr', self.devName])
-# learning interval is different on different kernels, so set it
-# explicit for 2.x kernels
-if os.uname()[2].startswith("2"):
-check_call([EXT_BRCTL, 'setfd', self.devName, '0'])
-check_call([EXT_BRCTL, 'setageing', self.devName, '0'])
self._ifUp()
def delDevice(self):
--
To view, visit https://gerrit.ovirt.org/44380
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98c1ea072398791173aeb3fe7f931933d0388651
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Replace brctl with ip
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Replace brctl with ip .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netestlib: Remove code for 2.x kernels
automat...@ovirt.org has posted comments on this change. Change subject: netestlib: Remove code for 2.x kernels .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c1ea072398791173aeb3fe7f931933d0388651 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with replacing brctl with ip
Nir Soffer has posted comments on this change. Change subject: Experiment with replacing brctl with ip .. Patch Set 2: This version fixes pep8 violation. -- To view, visit https://gerrit.ovirt.org/44379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with replacing brctl with ip
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with replacing brctl with ip .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
Nir Soffer has posted comments on this change. Change subject: nettestlib: Fix string formatting .. Patch Set 2: Tested manually that str(Interface) works now. -- To view, visit https://gerrit.ovirt.org/44378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
Nir Soffer has posted comments on this change. Change subject: nettestlib: Fix string formatting .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with replacing brctl with ip
Nir Soffer has uploaded a new change for review.
Change subject: Experiment with replacing brctl with ip
..
Experiment with replacing brctl with ip
According to Antoni, we should get better error messages from ip. Lets
see it this fix the random failures when removing bridges, or at least
give more information about these failures.
Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951
Signed-off-by: Nir Soffer
---
M tests/nettestlib.py
1 file changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/44379/1
diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 0010379..ddc68f4 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -73,20 +73,15 @@
class Bridge(Interface):
def addDevice(self):
-check_call([EXT_BRCTL, 'addbr', self.devName])
-# learning interval is different on different kernels, so set it
-# explicit for 2.x kernels
-if os.uname()[2].startswith("2"):
-check_call([EXT_BRCTL, 'setfd', self.devName, '0'])
-check_call([EXT_BRCTL, 'setageing', self.devName, '0'])
+check_call([EXT_IP, 'link', 'add', 'dev', self.devName, 'type',
'bridge'])
self._ifUp()
def delDevice(self):
self._ifDown()
-check_call([EXT_BRCTL, 'delbr', self.devName])
+check_call([EXT_IP, 'link', 'del', self.devName])
def addIf(self, dev):
-check_call([EXT_BRCTL, 'addif', self.devName, dev])
+check_call([EXT_IP, 'link', 'set', 'dev', dev, 'master', self.devName])
def _listenOnDevice(fd, icmp):
@@ -163,14 +158,7 @@
def check_tc():
dev = Bridge()
-try:
-dev.addDevice()
-except OSError as e:
-if e.errno == errno.ENOENT:
-raise SkipTest("Cannot run %r: %s\nDo you have bridge-utils "
- "installed?" % (EXT_BRCTL, e))
-raise
-
+dev.addDevice()
try:
check_call([EXT_TC, 'qdisc', 'add', 'dev', dev.devName, 'ingress'])
except ExecError as e:
--
To view, visit https://gerrit.ovirt.org/44379
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with replacing brctl with ip
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with replacing brctl with ip .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Add requires_brctl and requries_tc decorators
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Add requires_brctl and requries_tc decorators .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9211cb491b1b6f5e7a8880559ec1e1ca3804e92a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Remove unneeded hack for improving randomness
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Remove unneeded hack for improving randomness .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Fix string formatting .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with delay after running tc .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
Nir Soffer has posted comments on this change.
Change subject: nettestlib: Fix string formatting
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44378/1/tests/nettestlib.py
File tests/nettestlib.py:
Line 66: event.get('state') == 'down'):
Line 67: return
Line 68:
Line 69: def __str__(self):
Line 70: return "<{0} {1!r}>".format(self.__class__.__name__,
self.devname)
> why is the change to lowercase? it seems like an AttributeError
Looks like AuthorError, I will fix in next version :-)
Line 71:
Line 72:
Line 73: class Bridge(Interface):
Line 74:
--
To view, visit https://gerrit.ovirt.org/44378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
Dan Kenigsberg has posted comments on this change. Change subject: nettestlib: Fix string formatting .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44378/1/tests/nettestlib.py File tests/nettestlib.py: Line 70: devname why is the change to lowercase? it seems like an AttributeError -- To view, visit https://gerrit.ovirt.org/44378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
automat...@ovirt.org has posted comments on this change. Change subject: register: general improvements .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/44369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
Dan Kenigsberg has submitted this change and it was merged. Change subject: register: general improvements .. register: general improvements - replace --node-fqdn to --node-address for a better naming fit - remove unused socket library - improvement in docstring Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Signed-off-by: Douglas Schilling Landgraf Reviewed-on: https://gerrit.ovirt.org/44369 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/register.py 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
Dan Kenigsberg has posted comments on this change. Change subject: register: general improvements .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Remove unneeded hack for improving randomness
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Remove unneeded hack for improving randomness .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
Nir Soffer has uploaded a new change for review.
Change subject: nettestlib: Fix string formatting
..
nettestlib: Fix string formatting
Format string was using one-based indexing, causing IndexError when
formating an object, hiding the real error from tc binary.
Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e
Signed-off-by: Nir Soffer
---
M tests/nettestlib.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/44378/1
diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 44a831d..a6c87dc 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -67,7 +67,7 @@
return
def __str__(self):
-return "<{1} {2!r}>".format(self.__class__.__name__, self.devName)
+return "<{0} {1!r}>".format(self.__class__.__name__, self.devname)
class Bridge(Interface):
--
To view, visit https://gerrit.ovirt.org/44378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Add requires_brctl and requries_tc decorators
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Add requires_brctl and requries_tc decorators .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9211cb491b1b6f5e7a8880559ec1e1ca3804e92a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: remove legacy code for uuid
Dan Kenigsberg has posted comments on this change. Change subject: utils: remove legacy code for uuid .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1834eba15c7e5517a7aa62e1f32874244375036e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with delay after running tc .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Fix string formatting
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Fix string formatting .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7759cf8a75e82e0dc40fe69a545f214379d9dc4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with delay after running tc .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
Nir Soffer has uploaded a new change for review.
Change subject: Experiment with delay after running tc
..
Experiment with delay after running tc
Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5
Signed-off-by: Nir Soffer
---
M tests/nettestlib.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/44375/1
diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 51bafc4..8e62cab 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -24,6 +24,7 @@
import platform
import signal
import struct
+import time
from multiprocessing import Process
from nose.plugins.skip import SkipTest
@@ -176,6 +177,11 @@
except ExecError as e:
raise SkipTest("%r has failed: %s\nDo you have Traffic Control kernel "
"modules installed?" % (EXT_TC, e.err))
+# FIXME: Deleting a bridge fails randomally becasue the bridge is up,
+# altough we bring the interface down before deleting it. We probably
+# need to wait for tc events, but monitoring 'tc' cause a segfault.
+# Hopefully this delay will avoid the failures.
+time.sleep(0.1)
finally:
dev.delDevice()
--
To view, visit https://gerrit.ovirt.org/44375
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Experiment with delay after running tc
automat...@ovirt.org has posted comments on this change. Change subject: Experiment with delay after running tc .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c7928d5e57c3555bd3467ec60293705bbc2ac5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
Nir Soffer has restored this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Restored Testing again -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Move call to refreshStorage
Nir Soffer has posted comments on this change. Change subject: fc-connect-server: Move call to refreshStorage .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8ac84cc2bfd3490f3da41f0bc79fc372495a5a7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Delete qdisc if it was added
Nir Soffer has posted comments on this change. Change subject: nettestlib: Delete qdisc if it was added .. Patch Set 1: Verified-1 Does not help -- To view, visit https://gerrit.ovirt.org/44368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2db2b307350c4c8131f393b89fa5e9a78eafc3a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
Nir Soffer has abandoned this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Abandoned Test not ready yet -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable vhostmd on non-koji Fedora builds
Dima Kuznetsov has posted comments on this change. Change subject: spec: Enable vhostmd on non-koji Fedora builds .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
automat...@ovirt.org has posted comments on this change. Change subject: tests: Abuse permutations for running the tests multipe times .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Abuse permutations for running the tests multipe times
Nir Soffer has uploaded a new change for review.
Change subject: tests: Abuse permutations for running the tests multipe times
..
tests: Abuse permutations for running the tests multipe times
This change run the randomly-failing tests multiple times for verifying
the previous patch.
Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65
Signed-off-by: Nir Soffer
---
M tests/tcTests.py
1 file changed, 17 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/44371/1
diff --git a/tests/tcTests.py b/tests/tcTests.py
index e84d96c..8eb3118 100644
--- a/tests/tcTests.py
+++ b/tests/tcTests.py
@@ -29,6 +29,7 @@
from subprocess import Popen, PIPE
from testlib import VdsmTestCase as TestCaseBase
+from testlib import expandPermutations, permutations
from testValidation import ValidateRunningAsRoot
from nettestlib import Bridge, Tap, requires_brctl, requires_tc
@@ -36,6 +37,11 @@
from network import tc
+def repeat():
+return permutations([["%02d" % i] for i in range(20)])
+
+
+@expandPermutations
class TestQdisc(TestCaseBase):
@ValidateRunningAsRoot
@@ -56,22 +62,26 @@
tc._qdisc_replace_ingress(self._bridge.devName)
self.assertIn("qdisc ingress", self._showQdisc())
-def testToggleIngress(self):
+@repeat()
+def testToggleIngress(self, run):
self._addIngress()
tc._qdisc_del(self._bridge.devName, 'ingress')
self.assertNotIn("qdisc ingress", self._showQdisc())
-def testQdiscsOfDevice(self):
+@repeat()
+def testQdiscsOfDevice(self, run):
self._addIngress()
self.assertEquals((":", ),
tuple(tc._qdiscs_of_device(self._bridge.devName)))
-def testReplacePrio(self):
+@repeat()
+def testReplacePrio(self, run):
self._addIngress()
tc.qdisc.replace(self._bridge.devName, 'prio', parent=None)
self.assertIn("root", self._showQdisc())
-def testException(self):
+@repeat()
+def testException(self, run):
self.assertRaises(tc.TrafficControlException, tc._qdisc_del,
"__nosuchiface__", 'ingress')
@@ -240,6 +250,7 @@
self.assertEqual(parsed, correct)
+@expandPermutations
class TestPortMirror(TestCaseBase):
"""
@@ -347,7 +358,8 @@
self.assertFalse(self._sendPing(), "Bridge received mirrored ping "
"requests, but mirroring is unset.")
-def testMirroringWithDistraction(self):
+@repeat()
+def testMirroringWithDistraction(self, run):
"setting another mirror action should not obstract the first one"
tc.setPortMirroring(self._bridge0.devName, self._bridge2.devName)
self.testMirroring()
--
To view, visit https://gerrit.ovirt.org/44371
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2405850c9f985f1bd8cf1b2bd5f2190619e7db65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: simplify check fqdn
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: simplify check fqdn .. Patch Set 2: Dan, should I abandon this one ? -- To view, visit https://gerrit.ovirt.org/44220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I106ee53d2b29c32f872e379bc535e10f616733c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: remove legacy code for uuid
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: remove legacy code for uuid .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1834eba15c7e5517a7aa62e1f32874244375036e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: general improvements .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
automat...@ovirt.org has posted comments on this change. Change subject: register: general improvements .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
automat...@ovirt.org has posted comments on this change. Change subject: register: general improvements .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: general improvements
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: general improvements
..
register: general improvements
- replace --node-fqdn to --node-address for a better naming fit
- remove unused socket library
- improvement in docstring
Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370
Signed-off-by: Douglas Schilling Landgraf
---
M lib/vdsm/tool/register.py
1 file changed, 11 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/44369/1
diff --git a/lib/vdsm/tool/register.py b/lib/vdsm/tool/register.py
index b5c2654..c170316 100644
--- a/lib/vdsm/tool/register.py
+++ b/lib/vdsm/tool/register.py
@@ -21,7 +21,6 @@
import logging
import os
import pwd
-import socket
import ssl
import sys
import tempfile
@@ -40,13 +39,13 @@
def __init__(self, engine_fqdn, engine_https_port=None,
fingerprint=None, ssh_port=None,
ssh_user=None, check_fqdn=True,
- vdsm_port=None, node_fqdn=None,
+ vdsm_port=None, node_address=None,
node_name=None):
"""
Attributes:
-engine_fqdn - Engine FQDN
-engine_https_port - Engine http port
+engine_fqdn - Engine FQDN or IP address
+engine_https_port - Engine https port
fingeprint- Fingerprint to be validated
ssh_user - SSH user that will establish the connection
from Engine
@@ -54,7 +53,7 @@
check_fqdn- Validate Engine FQDN against CA (True or False)
Default is TRUE
vdsm_port - VDSM listen port
-node_fqdn - Specify node FQDN
+node_address - Specify node address or FQDN
node_name - Specify node name
"""
self.logger = self._set_logger()
@@ -87,8 +86,8 @@
self.fprint = fingerprint
self.logger.debug("Fingerprint: {fp}".format(fp=self.fprint))
-self.node_fqdn = node_fqdn
-self.logger.debug("Node FQDN: {nf}".format(nf=self.node_fqdn))
+self.node_address = node_address
+self.logger.debug("Node address: {nf}".format(nf=self.node_address))
self.node_name = node_name
self.logger.debug("Node name: {na}".format(na=self.node_name))
@@ -151,8 +150,8 @@
if self.node_name is not None:
ureg += "&name={name}".format(name=self.node_name)
-if self.node_fqdn is not None:
-ureg += "&address={fqdn}".format(fqdn=self.node_fqdn)
+if self.node_address is not None:
+ureg += "&address={fqdn}".format(fqdn=self.node_address)
self.url_reg = "{e}{u}".format(e=self.engine_url, u=ureg)
@@ -378,7 +377,7 @@
)
parser.add_argument(
-'--node-fqdn',
+'--node-address',
help="Define node FQDN or IP address."
" If not provided, will be used system host name",
)
@@ -392,7 +391,7 @@
parser.add_argument(
'--engine-fqdn',
-help="Engine FQDN (See also: --check-fqdn)",
+help="Engine FQDN or IP address (See also: --check-fqdn)",
required=True
)
@@ -441,7 +440,7 @@
reg = Register(engine_fqdn=args.engine_fqdn,
engine_https_port=args.engine_https_port,
vdsm_port=args.vdsm_port,
- node_fqdn=args.node_fqdn,
+ node_address=args.node_address,
node_name=args.node_name,
ssh_user=args.ssh_user,
ssh_port=args.ssh_port,
--
To view, visit https://gerrit.ovirt.org/44369
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5182c32e927e45da18e15e6a0f8fb2c6632de370
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Delete qdisc if it was added
Nir Soffer has uploaded a new change for review.
Change subject: nettestlib: Delete qdisc if it was added
..
nettestlib: Delete qdisc if it was added
After we cleanup up the networking tests, we have now one issue left:
17:05:43 root: DEBUG: /usr/sbin/brctl addbr vdsm-fboHCFgRN0 (cwd None)
17:05:43 root: DEBUG: SUCCESS: = ''; = 0
17:05:43 root: DEBUG: /sbin/ip link set vdsm-fboHCFgRN0 up (cwd None)
17:05:43 root: DEBUG: SUCCESS: = ''; = 0
17:05:43 root: DEBUG: /usr/sbin/tc qdisc add dev vdsm-fboHCFgRN0 ingress (cwd
None)
17:05:43 root: DEBUG: SUCCESS: = ''; = 0
17:05:43 root: DEBUG: /sbin/ip link set vdsm-fboHCFgRN0 down (cwd None)
17:05:43 root: DEBUG: SUCCESS: = ''; = 0
17:05:43 root: DEBUG: /usr/sbin/brctl delbr vdsm-fboHCFgRN0 (cwd None)
17:05:43 root: DEBUG: FAILED: = "bridge vdsm-fboHCFgRN0 is still up;
can't delete it\n"; = 1
This failure effect now on the tcTests, using @reqire_tc.
I suspect that adding a qdisc is asynchronous, causing the bridge state
to change after bringing the device down and waiting for netlink "down"
event.
Trying to delete the qdisc before bringing the device down.
Change-Id: Ia2db2b307350c4c8131f393b89fa5e9a78eafc3a
Signed-off-by: Nir Soffer
---
M tests/nettestlib.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/44368/1
diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 51bafc4..c3457d9 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -176,6 +176,8 @@
except ExecError as e:
raise SkipTest("%r has failed: %s\nDo you have Traffic Control kernel "
"modules installed?" % (EXT_TC, e.err))
+else:
+check_call([EXT_TC, 'qdisc', 'delete', 'dev', dev.devName, 'ingress'])
finally:
dev.delDevice()
--
To view, visit https://gerrit.ovirt.org/44368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2db2b307350c4c8131f393b89fa5e9a78eafc3a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Delete qdisc if it was added
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Delete qdisc if it was added .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2db2b307350c4c8131f393b89fa5e9a78eafc3a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip hosted engine stats processing when it is not configured
Martin Sivák has posted comments on this change. Change subject: Skip hosted engine stats processing when it is not configured .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/44354/2//COMMIT_MSG Commit Message: Line 6: Line 7: Skip hosted engine stats processing when it is not configured Line 8: Line 9: This changes the data collecting to ignore hosted engine when Line 10: the host id is reported as None or 0. > Seems ok, but to be sure, and for better documentation, could you please ad It is one piece of the fix. The second piece is in hosted engine client which handles missing configuration by returning None (instead of IOError). Line 11: Line 12: Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248539 -- To view, visit https://gerrit.ovirt.org/44354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test randomness when running under mock
automat...@ovirt.org has posted comments on this change. Change subject: Test randomness when running under mock .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/44356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90fbc6cbc6ef9a9acbdc2964b92f1c4eb72df97d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test randomness when running under mock
Nir Soffer has abandoned this change. Change subject: Test randomness when running under mock .. Abandoned random works as expected -- To view, visit https://gerrit.ovirt.org/44356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I90fbc6cbc6ef9a9acbdc2964b92f1c4eb72df97d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Add requires_brctl and requries_tc decorators
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Add requires_brctl and requries_tc decorators .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9211cb491b1b6f5e7a8880559ec1e1ca3804e92a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Remove unneeded hack for improving randomness
Nir Soffer has posted comments on this change. Change subject: nettestlib: Remove unneeded hack for improving randomness .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/44216/2//COMMIT_MSG Commit Message: Line 7: nettestlib: Remove unneeded hack for improving randomness Line 8: Line 9: Python seed the random number generator from os.urandom() on startup, so Line 10: different processes do not use the same seed, and produce different Line 11: sequences of pseudo random numbers by default. > Do you suspect that mock is using fake /dev/urandom producing same sequence Here are some results showing that we get different pseudo random values on each run: http://pastebin.com/bUrtbZkK Line 12: Line 13: Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b -- To view, visit https://gerrit.ovirt.org/44216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip hosted engine stats processing when it is not configured
Francesco Romani has posted comments on this change. Change subject: Skip hosted engine stats processing when it is not configured .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/44354/2//COMMIT_MSG Commit Message: Line 6: Line 7: Skip hosted engine stats processing when it is not configured Line 8: Line 9: This changes the data collecting to ignore hosted engine when Line 10: the host id is reported as None or 0. Seems ok, but to be sure, and for better documentation, could you please add more context here in the commit message, to document why this change fixes the referenced BZ? I feel like I'm missing one step here. Line 11: Line 12: Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248539 -- To view, visit https://gerrit.ovirt.org/44354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Add missing ChapCredentials.__ne__
Freddy Rolland has posted comments on this change. Change subject: iscsi: Add missing ChapCredentials.__ne__ .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf79724404b3ac46955ead046a6d092a1b1ac1ca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Fix ChapCredentials.__eq__
Freddy Rolland has posted comments on this change. Change subject: iscsi: Fix ChapCredentials.__eq__ .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35eb0c33b72cf3ec3b5e54a159515b94f98f2d55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Improve ChapCredentials.__hash__
Freddy Rolland has posted comments on this change. Change subject: iscsi: Improve ChapCredentials.__hash__ .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c05a07098fa75fe292e67cf5e62b996f20d9751 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Move call to refreshStorage
Freddy Rolland has posted comments on this change. Change subject: fc-connect-server: Move call to refreshStorage .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/44009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8ac84cc2bfd3490f3da41f0bc79fc372495a5a7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Move call to refreshStorage
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Move call to refreshStorage .. Patch Set 3: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8ac84cc2bfd3490f3da41f0bc79fc372495a5a7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Add FcpConnection class
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Add FcpConnection class .. Patch Set 4: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Support FCP on connect server
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Support FCP on connect server .. Patch Set 4: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test randomness when running under mock
Nir Soffer has posted comments on this change. Change subject: Test randomness when running under mock .. Patch Set 1: This is temporary patch that must always fail. Comparing failures on different runs should prove if we random values are actually random as we expect. -- To view, visit https://gerrit.ovirt.org/44356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90fbc6cbc6ef9a9acbdc2964b92f1c4eb72df97d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Remove unneeded hack for improving randomness
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Remove unneeded hack for improving randomness .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test randomness when running under mock
Nir Soffer has uploaded a new change for review.
Change subject: Test randomness when running under mock
..
Test randomness when running under mock
Add two tests that will always fail, showing random values generated by
random.randint() and os.urandom().
If we get different random values on each run, this it shows that we
don't need the randomness hack added in https://gerrit.ovirt.org/41079
Change-Id: I90fbc6cbc6ef9a9acbdc2964b92f1c4eb72df97d
Signed-off-by: Nir Soffer
---
M tests/testlibTests.py
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/44356/1
diff --git a/tests/testlibTests.py b/tests/testlibTests.py
index d631aaf..b2a6489 100644
--- a/tests/testlibTests.py
+++ b/tests/testlibTests.py
@@ -149,3 +149,12 @@
def test_expanded_attributes(self):
fn = getattr(self._Permutations, 'fn(False)')
self.assertNotIn(PERMUTATION_ATTR, dir(fn))
+
+
+class TestRandomness(VdsmTestCase):
+def test_randint(self):
+import random
+self.assertEqual([0] * 10, [random.randint(0, 1000) for _ in
range(10)])
+def test_urandom(self):
+import os
+self.assertEqual("0" * 20, os.urandom(10).encode('hex'))
--
To view, visit https://gerrit.ovirt.org/44356
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90fbc6cbc6ef9a9acbdc2964b92f1c4eb72df97d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test randomness when running under mock
automat...@ovirt.org has posted comments on this change. Change subject: Test randomness when running under mock .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90fbc6cbc6ef9a9acbdc2964b92f1c4eb72df97d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Add requires_brctl and requries_tc decorators
automat...@ovirt.org has posted comments on this change. Change subject: nettestlib: Add requires_brctl and requries_tc decorators .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9211cb491b1b6f5e7a8880559ec1e1ca3804e92a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip hosted engine stats processing when it is not configured
Sandro Bonazzola has posted comments on this change. Change subject: Skip hosted engine stats processing when it is not configured .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: remove legacy code for uuid
automat...@ovirt.org has posted comments on this change. Change subject: utils: remove legacy code for uuid .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1834eba15c7e5517a7aa62e1f32874244375036e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Move call to refreshStorage
Freddy Rolland has posted comments on this change. Change subject: fc-connect-server: Move call to refreshStorage .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8ac84cc2bfd3490f3da41f0bc79fc372495a5a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Support FCP on connect server
Nir Soffer has posted comments on this change. Change subject: fc-connect-server: Support FCP on connect server .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Add FcpConnection class
Nir Soffer has posted comments on this change. Change subject: fc-connect-server: Add FcpConnection class .. Patch Set 3: Code-Review+1 Please check the jenkins errors. -- To view, visit https://gerrit.ovirt.org/44010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip hosted engine stats processing when it is not configured
automat...@ovirt.org has posted comments on this change. Change subject: Skip hosted engine stats processing when it is not configured .. Patch Set 2: * Update tracker::#1248539::OK * Check Bug-Url::OK * Check Public Bug::#1248539::OK, public bug * Check Product::#1248539::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip hosted engine stats processing when it is not configured
automat...@ovirt.org has posted comments on this change. Change subject: Skip hosted engine stats processing when it is not configured .. Patch Set 1: * Update tracker::#1248539::OK * Check Bug-Url::OK * Check Public Bug::#1248539::OK, public bug * Check Product::#1248539::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip hosted engine stats processing when it is not configured
Martin Sivák has uploaded a new change for review. Change subject: Skip hosted engine stats processing when it is not configured .. Skip hosted engine stats processing when it is not configured This changes the data collecting to ignore hosted engine when the host id is reported as None or 0. Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248539 Signed-off-by: Martin Sivak --- M vdsm.spec.in M vdsm/API.py M vdsm/logger.conf.in 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/44354/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index fd21bc1..a3de25c 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -188,7 +188,7 @@ Requires: fence-agents-all Requires: kernel >= 3.15.0 # Subprocess and thread bug was found on python 2.7.2 -Requires: python >= 2.7.3 +Requires: python >= 2.7.3t Requires: initscripts >= 9.42.2-1 Requires: device-mapper-multipath >= 0.4.9-56 Requires: e2fsprogs >= 1.41.14 diff --git a/vdsm/API.py b/vdsm/API.py index 664ad05..8661db7 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1801,8 +1801,12 @@ try: instance = haClient.HAClient() host_id = instance.get_local_host_id() + # If a host id is available, consider HA configured -i['configured'] = True +if host_id: +i['configured'] = True +else: +return i stats = instance.get_all_stats() if 0 in stats: diff --git a/vdsm/logger.conf.in b/vdsm/logger.conf.in index 617c175..e2b1763 100644 --- a/vdsm/logger.conf.in +++ b/vdsm/logger.conf.in @@ -1,5 +1,5 @@ [loggers] -keys=root,vds,Storage,virt,ovirt_hosted_engine_ha,IOProcess,connectivity +keys=root,vds,Storage,virt,ovirt_hosted_engine_ha,ovirt_hosted_engine_ha_config,IOProcess,connectivity [handlers] keys=console,syslog,logfile,connlogfile @@ -30,6 +30,12 @@ qualname=ovirt_hosted_engine_ha propagate=1 +[logger_ovirt_hosted_engine_ha_config] +level=ERROR +handlers= +qualname=ovirt_hosted_engine_ha.config +propagate=0 + [logger_IOProcess] level=INFO handlers=logfile -- To view, visit https://gerrit.ovirt.org/44354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7b49fa02ae8035c1eb98582299260a59d3bba0e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable vhostmd on non-koji Fedora builds
Yaniv Bronhaim has posted comments on this change. Change subject: spec: Enable vhostmd on non-koji Fedora builds .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/44350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable vhostmd on non-koji Fedora builds
Yaniv Bronhaim has posted comments on this change. Change subject: spec: Enable vhostmd on non-koji Fedora builds .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Add FcpConnection class
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Add FcpConnection class .. Patch Set 3: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Support FCP on connect server
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Support FCP on connect server .. Patch Set 3: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Move call to refreshStorage
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Move call to refreshStorage .. Patch Set 2: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8ac84cc2bfd3490f3da41f0bc79fc372495a5a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable vhostmd on non-koji Fedora builds
Dan Kenigsberg has uploaded a new change for review.
Change subject: spec: Enable vhostmd on non-koji Fedora builds
..
spec: Enable vhostmd on non-koji Fedora builds
with_vhostmd is configurable since vhostmd is missing from Centos 6/7 +
EPEL. For everywhere else, we want to set with_vhostmd=1
Recently, we've added
http://jenkins.ovirt.org/job/vhostmd_create-rpms_el6/
http://jenkins.ovirt.org/job/vhostmd_create-rpms_el7/
which let us ship vhostmd within oVirt repos.
So basically, we can take vhostmd if it's not el, or if it's built out of koji.
Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a
Signed-off-by: Dima Kuznetsov
Reviewed-on: http://gerrit.ovirt.org/36316
Reviewed-by: Yaniv Bronhaim
Reviewed-by: Dan Kenigsberg
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/44350/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 8a54ed8..9d68e9b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -39,7 +39,7 @@
%global with_gluster 1
%endif
-%if ! 0%{?rhel}
+%if ! 0%{?rhel} || ! 0%{fedora_koji_build}
%global with_vhostmd 1
%endif
--
To view, visit https://gerrit.ovirt.org/44350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable vhostmd on non-koji Fedora builds
automat...@ovirt.org has posted comments on this change. Change subject: spec: Enable vhostmd on non-koji Fedora builds .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/44350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nettestlib: Remove unneeded hack for improving randomness
Nir Soffer has posted comments on this change. Change subject: nettestlib: Remove unneeded hack for improving randomness .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/44216/2//COMMIT_MSG Commit Message: Line 7: nettestlib: Remove unneeded hack for improving randomness Line 8: Line 9: Python seed the random number generator from os.urandom() on startup, so Line 10: different processes do not use the same seed, and produce different Line 11: sequences of pseudo random numbers by default. > I had a feeling (somewhat fact-based) that this is not the case when tests Do you suspect that mock is using fake /dev/urandom producing same sequence of random numbers? Do you have a proof that this is the case? Line 12: Line 13: Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b -- To view, visit https://gerrit.ovirt.org/44216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: wait for a bridge to appear before disabling IPv6 o...
Dan Kenigsberg has posted comments on this change. Change subject: network: wait for a bridge to appear before disabling IPv6 on it .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5292e5a297ff50a0e82ba0781333e21fd9dd7f3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow "Replica" 1 domains
Allon Mureinik has posted comments on this change. Change subject: gluster: Allow "Replica" 1 domains .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia571d333e27357c3de825aaf29202cd4d1c4106a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Support FCP on connect server
Freddy Rolland has posted comments on this change. Change subject: fc-connect-server: Support FCP on connect server .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Support FCP on connect server
Freddy Rolland has posted comments on this change.
Change subject: fc-connect-server: Support FCP on connect server
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44011/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 239: cred = iscsi.ChapCredentials(username, password)
Line 240:
Line 241: params = storageServer.IscsiConnectionParameters(target,
iface, cred)
Line 242: elif typeName == 'fcp':
Line 243: params = storageServer.FcpConnectionParameters('fcp')
> Please remove type argument.
Fixed with empty nametuple
Line 244: else:
Line 245: raise se.StorageServerActionError()
Line 246:
Line 247: return storageServer.ConnectionInfo(typeName, params)
--
To view, visit https://gerrit.ovirt.org/44011
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Add FcpConnection class
Freddy Rolland has posted comments on this change.
Change subject: fc-connect-server: Add FcpConnection class
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/44010/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 68: NfsConnectionParameters = namedtuple("NfsConnectionParameters",
Line 69: "export, retrans, timeout,
version, "
Line 70: "extraOptions")
Line 71:
Line 72: FcpConnectionParameters = namedtuple("FcpConnectionParameters", "type")
> Actually I think we can remove this, and use None or empty tuple when creat
I used an empty namestuple, as in the flow it is converted to a dictionary
using __fields_
Line 73:
Line 74: ConnectionInfo = namedtuple("ConnectionInfo", "type, params")
Line 75:
Line 76:
Line 550: return hsh
Line 551:
Line 552:
Line 553: class FcpConnection(object):
Line 554: def __init__(self, type):
> I think you don't need type, so __init__ is not needed. There is no need to
Done
Line 555: pass
Line 556:
Line 557: def connect(self):
Line 558: pass
Line 560: def disconnect(self):
Line 561: pass
Line 562:
Line 563: def isConnected(self):
Line 564: pass
> Should return always True
Done
Line 565:
Line 566: def __eq__(self, other):
Line 567: return self.__class__ == other.__class
Line 568:
Line 563: def isConnected(self):
Line 564: pass
Line 565:
Line 566: def __eq__(self, other):
Line 567: return self.__class__ == other.__class
> Implement also __ne__
Done
Line 568:
Line 569: def __hash__(self):
Line 570: return hash(type(self))
Line 571:
Line 566: def __eq__(self, other):
Line 567: return self.__class__ == other.__class
Line 568:
Line 569: def __hash__(self):
Line 570: return hash(type(self))
> Use self.__class__ for consistency with __eq__
Done
Line 571:
Line 572:
Line 573: class LocalDirectoryConnection(object):
Line 574: @property
--
To view, visit https://gerrit.ovirt.org/44010
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Add FcpConnection class
Freddy Rolland has posted comments on this change. Change subject: fc-connect-server: Add FcpConnection class .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Add FcpConnection class
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Add FcpConnection class .. Patch Set 2: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fc-connect-server: Support FCP on connect server
automat...@ovirt.org has posted comments on this change. Change subject: fc-connect-server: Support FCP on connect server .. Patch Set 2: * Update tracker::#1242200::OK * Check Bug-Url::OK * Check Public Bug::#1242200::OK, public bug * Check Product::#1242200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: use node name and fqdn when needed
Dan Kenigsberg has submitted this change and it was merged. Change subject: register: use node name and fqdn when needed .. register: use node name and fqdn when needed Currently, we collect host fqdn before registering but it's not required. This patch make registration be triggered without setting host fqdn, it will use node IP address. Change-Id: I91c834e10cade4878791be43201ab0966bf251b4 Signed-off-by: Douglas Schilling Landgraf Reviewed-on: https://gerrit.ovirt.org/44221 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/register.py 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91c834e10cade4878791be43201ab0966bf251b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: use node name and fqdn when needed
automat...@ovirt.org has posted comments on this change. Change subject: register: use node name and fqdn when needed .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/44221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c834e10cade4878791be43201ab0966bf251b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
