Change in vdsm[ovirt-3.6]: automation: use proper repos
automat...@ovirt.org has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 3: * Update tracker::#1268229::OK * Set MODIFIED::bug 1268229#1268229IGNORE, not oVirt prod but vdsm -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
Francesco Romani has submitted this change and it was merged. Change subject: automation: use proper repos .. automation: use proper repos We should use 3.6 repos for 3.6 branch. Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Bug-Url: https://bugzilla.redhat.com/1268229 Signed-off-by: Petr Horáček Label: ovirt-3.6-only Reviewed-on: https://gerrit.ovirt.org/47680 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M automation/build-artifacts.repos.el7 M automation/build-artifacts.repos.fc21 M automation/build-artifacts.repos.fc22 M automation/check-patch.repos.el7 M automation/check-patch.repos.fc21 M automation/check-patch.repos.fc22 6 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
Francesco Romani has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't prepare image with illegal volumes
Adam Litke has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 3: rebased. -- To view, visit https://gerrit.ovirt.org/39302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't prepare image with illegal volumes
automat...@ovirt.org has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 3: * Update tracker::#1206722::OK * Check Bug-Url::OK * Check Public Bug::#1206722::OK, public bug * Check Product::#1206722::OK, Correct product oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hostdev: fix pep8 line length violation
Petr Horáček has posted comments on this change. Change subject: hostdev: fix pep8 line length violation .. Patch Set 1: Verified+1 PEP8 passed -- To view, visit https://gerrit.ovirt.org/47682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I493bb143e1ebdeb53821bf6ea8ca6cc6e7185aa0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
Petr Horáček has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 2: Verified+1 Mock runner passed build-only and patch-only on el7 fc21 fc22 -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
automat...@ovirt.org has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 2: * Update tracker::#1268229::OK * Check Bug-Url::OK * Check Public Bug::#1268229::OK, public bug * Check Product::#1268229::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add migrateChangeGlobalParams verb
Francesco Romani has posted comments on this change.
Change subject: migration: Add migrateChangeGlobalParams verb
..
Patch Set 6:
(3 comments)
The whole "dynamic semaphore" concept is a nice hack, but I'm not convinced it
is the best way forward.
https://gerrit.ovirt.org/#/c/47409/6/vdsm/API.py
File vdsm/API.py:
Line 1762: max_outgoing = params.get('maxOutgoingMigrations')
Line 1763: if max_outgoing is not None:
Line 1764: self.log('Updating maxOutgoingMigrations to %s',
Line 1765: max_outgoing)
Line 1766:
migration.SourceThread.ongoingMigrations.setValue(max_outgoing)
for another patch: let's move this sempahore in the module.
Line 1767:
Line 1768: max_incoming = params.get('maxIncomingMigrations')
Line 1769: if max_incoming is not None:
Line 1770: self.log('Updating maxIncomingMigrations to %s',
Line 1768: max_incoming = params.get('maxIncomingMigrations')
Line 1769: if max_incoming is not None:
Line 1770: self.log('Updating maxIncomingMigrations to %s',
Line 1771: max_incoming)
Line 1772: migration.incomingMigrations.setValue(max_incoming)
for another patch: once both semaphores are module variables, let's rename them
- migration.incoming
- migration.outgoing
Line 1773:
Line 1774: return response.success()
Line 1775: except migration.MigrationConfigurationError:
Line 1776: return response.error('migrateChangeParamsErr')
https://gerrit.ovirt.org/#/c/47409/6/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 160:
Line 161: return decorator
Line 162:
Line 163:
Line 164: class DynamicSemaphore(threading._Semaphore):
We learned the hard way from the cpopen saga that messing with python
implementation details is a bad idea.
Any other option to avoid this?
Line 165: """
Line 166: Extends standard semaphore with the ability to alter the current
"bound"
Line 167: by external actors.
Line 168:
--
To view, visit https://gerrit.ovirt.org/47409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6d1bcdc29f144d9fcf28a085b7014127cc4f41
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hostdev: fix pep8 line length violation
Hello Ido Barkan, Dan Kenigsberg, Martin Polednik, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/47682 to review the following change. Change subject: hostdev: fix pep8 line length violation .. hostdev: fix pep8 line length violation Change-Id: I493bb143e1ebdeb53821bf6ea8ca6cc6e7185aa0 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/47083 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg Bug-Url: https://bugzilla.redhat.com/1268229 --- M vdsm/hostdev.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/47682/1 diff --git a/vdsm/hostdev.py b/vdsm/hostdev.py index ae911da..e17a30a 100644 --- a/vdsm/hostdev.py +++ b/vdsm/hostdev.py @@ -56,7 +56,8 @@ def physical_function_net_name(pf_pci_name): -"""takes a pci path of a physical function (e.g. pci__02_00_0) and returns +""" +takes a pci path of a physical function (e.g. pci__02_00_0) and returns the network interface name associated with it (e.g. enp2s0f0) """ devices = list_by_caps() -- To view, visit https://gerrit.ovirt.org/47682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I493bb143e1ebdeb53821bf6ea8ca6cc6e7185aa0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hostdev: fix pep8 line length violation
automat...@ovirt.org has posted comments on this change. Change subject: hostdev: fix pep8 line length violation .. Patch Set 1: * Update tracker::#1268229::OK * Check Bug-Url::OK * Check Public Bug::#1268229::OK, public bug * Check Product::#1268229::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I493bb143e1ebdeb53821bf6ea8ca6cc6e7185aa0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add incoming migration semaphore
Francesco Romani has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/45954/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2759: usedTimeout = self._waitForUnderlyingMigration() Line 2760: self._attachLibvirtDomainAfterMigration( Line 2761: self._incomingMigrationFinished.isSet(), usedTimeout) Line 2762: finally: Line 2763: migration.incomingMigrations.release() > One approach that would solve this would be to free the incomingMigrations I'd start with simpler and easier-to-prove-correct approach first, unless that approach has obvious and blatant drawbacks. I'd be extra careful here because we are dealing with threads _and_ resource leaks. So let's try the simplest route first, please. Line 2764: # else domain connection already established earlier Line 2765: self._domDependentInit() Line 2766: del self.conf['migrationDest'] Line 2767: hooks.after_vm_migrate_destination(self._dom.XMLDesc(0), self.conf) -- To view, visit https://gerrit.ovirt.org/45954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: update testSetupNetworksAddDelDhcp
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: update testSetupNetworksAddDelDhcp
..
hooks: ovs: update testSetupNetworksAddDelDhcp
Test testSetupNetworksAddDelDhcp was changed in networkTests.py,
now its copy in networkTestsOVS.py is updated as well.
Change-Id: If4344c85d2f4c6ce07cf412749e32fd1c07be42c
Signed-off-by: Petr Horáček
---
M tests/functional/networkTestsOVS.py
1 file changed, 41 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/47681/1
diff --git a/tests/functional/networkTestsOVS.py
b/tests/functional/networkTestsOVS.py
index cd89a96..b8e915e 100644
--- a/tests/functional/networkTestsOVS.py
+++ b/tests/functional/networkTestsOVS.py
@@ -272,9 +272,42 @@
@cleanupNet
@RequireVethMod
def testSetupNetworksAddDelDhcp(self, bridged, families):
-""" Copied from networkTests.py, source_route checking changed from
+"""Copied from networkTests.py, source_route checking changed from
device_name to BRIDGE_NAME.
"""
+def _assert_applied(network_name, requested, reported):
+self.assertNetworkExists(network_name)
+reported_network = reported.networks[network_name]
+
+if requested['bridged']:
+self.assertEqual(reported_network['cfg']['BOOTPROTO'],
+ requested['bootproto'])
+reported_devices = reported.bridges
+device_name = network_name
+else:
+# CHANGED: always bridged
+pass
+self.assertIn(device_name, reported_devices)
+reported_device = reported_devices[device_name]
+
+requested_dhcpv4 = requested['bootproto'] == 'dhcp'
+self.assertEqual(reported_network['dhcpv4'], requested_dhcpv4)
+self.assertEqual(reported_network['dhcpv6'], requested['dhcpv6'])
+
+self.assertEqual(reported_device['cfg']['BOOTPROTO'],
+ requested['bootproto'])
+self.assertEqual(reported_device['dhcpv4'], requested_dhcpv4)
+self.assertEqual(reported_device['dhcpv6'], requested['dhcpv6'])
+
+if requested_dhcpv4:
+self.assertEqual(reported_network['gateway'], IP_GATEWAY)
+# TODO: source routing not ready for IPv6
+ip_addr = reported_network['addr']
+self.assertSourceRoutingConfiguration(BRIDGE_NAME, # CHANGED
+ ip_addr)
+return device_name, ip_addr
+return None, None
+
with veth_pair() as (left, right):
addrAdd(left, IP_ADDRESS, IP_CIDR)
addrAdd(left, IPv6_ADDRESS, IPv6_CIDR, 6)
@@ -290,42 +323,19 @@
try:
status, msg = self.setupNetworks(network, {}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
-self.assertNetworkExists(NETWORK_NAME)
-test_net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
-self.assertEqual(test_net['dhcpv4'], dhcpv4)
-self.assertEqual(test_net['dhcpv6'], dhcpv6)
-
-if bridged:
-self.assertEqual(test_net['cfg']['BOOTPROTO'],
- bootproto)
-devs = self.vdsm_net.netinfo.bridges
-device_name = NETWORK_NAME
-else:
-devs = self.vdsm_net.netinfo.nics
-device_name = right
-
-self.assertIn(device_name, devs)
-net_attrs = devs[device_name]
-self.assertEqual(net_attrs['cfg']['BOOTPROTO'], bootproto)
-self.assertEqual(net_attrs['dhcpv4'], dhcpv4)
-self.assertEqual(net_attrs['dhcpv6'], dhcpv6)
-
-if dhcpv4:
-self.assertEqual(test_net['gateway'], IP_GATEWAY)
-# TODO: source routing not ready for IPv6
-ip_addr = test_net['addr']
-self.assertSourceRoutingConfiguration(BRIDGE_NAME,
- ip_addr)
+device_name, ip_addr = _assert_applied(
+NETWORK_NAME, network[NETWORK_NAME],
+self.vdsm_net.netinfo)
# Do not report DHCP from (typically still valid) leases
network[NETWORK_NAME]['bootproto'] = 'none'
network[NETWORK_NAME]['dhcpv6'] = False
status, msg = self.setupNetworks(network, {}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
-test_net = self.vdsm_net.netinfo.networks[NETWOR
Change in vdsm[master]: hooks: ovs: update testSetupNetworksAddDelDhcp
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: update testSetupNetworksAddDelDhcp .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4344c85d2f4c6ce07cf412749e32fd1c07be42c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: update testSetupNetworksAddDelDhcp
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: update testSetupNetworksAddDelDhcp .. Patch Set 1: Verified+1 test passed. -- To view, visit https://gerrit.ovirt.org/47681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4344c85d2f4c6ce07cf412749e32fd1c07be42c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
Petr Horáček has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 1: -Verified Wrong tab, sorry. -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
Petr Horáček has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 1: Verified+1 Test passed. -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
automat...@ovirt.org has posted comments on this change. Change subject: automation: use proper repos .. Patch Set 1: * Update tracker::#1268229::OK * Check Bug-Url::OK * Check Public Bug::#1268229::OK, public bug * Check Product::#1268229::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: automation: use proper repos
Petr Horáček has uploaded a new change for review. Change subject: automation: use proper repos .. automation: use proper repos We should use 3.6 repos for 3.6 branch. Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Bug-Url: https://bugzilla.redhat.com/1268229 Signed-off-by: Petr Horáček Label: ovirt-3.6-only --- M automation/build-artifacts.repos.el7 M automation/build-artifacts.repos.fc21 M automation/build-artifacts.repos.fc22 M automation/check-patch.repos.el7 M automation/check-patch.repos.fc21 M automation/check-patch.repos.fc22 6 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/47680/1 diff --git a/automation/build-artifacts.repos.el7 b/automation/build-artifacts.repos.el7 index 8c8de34..df3164b 100644 --- a/automation/build-artifacts.repos.el7 +++ b/automation/build-artifacts.repos.el7 @@ -1,2 +1,2 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro +ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro ovirt-glusterfs-epel,http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-7/x86_64 diff --git a/automation/build-artifacts.repos.fc21 b/automation/build-artifacts.repos.fc21 index a80e9aa..81b658d 100644 --- a/automation/build-artifacts.repos.fc21 +++ b/automation/build-artifacts.repos.fc21 @@ -1,2 +1,2 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro +ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-21/x86_64 diff --git a/automation/build-artifacts.repos.fc22 b/automation/build-artifacts.repos.fc22 index 47b6979..ee3eda5 100644 --- a/automation/build-artifacts.repos.fc22 +++ b/automation/build-artifacts.repos.fc22 @@ -1,2 +1,2 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro +ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-22/x86_64 diff --git a/automation/check-patch.repos.el7 b/automation/check-patch.repos.el7 index 86aaf02..2c32820 100644 --- a/automation/check-patch.repos.el7 +++ b/automation/check-patch.repos.el7 @@ -1,4 +1,4 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro -ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro +ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro +ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-3.6-snapshot-static/rpm/$distro ovirt-glusterfs-epel,http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-7/x86_64 openstack-kilo,https://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/ diff --git a/automation/check-patch.repos.fc21 b/automation/check-patch.repos.fc21 index 16ae431..ec3fd1c 100644 --- a/automation/check-patch.repos.fc21 +++ b/automation/check-patch.repos.fc21 @@ -1,3 +1,3 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro -ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro +ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro +ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-3.6-snapshot-static/rpm/$distro ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-21/x86_64 diff --git a/automation/check-patch.repos.fc22 b/automation/check-patch.repos.fc22 index 01396e5..ed14b67 100644 --- a/automation/check-patch.repos.fc22 +++ b/automation/check-patch.repos.fc22 @@ -1,3 +1,3 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro -ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro +ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro +ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-3.6-snapshot-static/rpm/$distro ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-22/x86_64 -- To view, visit https://gerrit.ovirt.org/47680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e9233277885979f7aad7b5856e419778e7ac621 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Wait for udev events after unmounting
automat...@ovirt.org has posted comments on this change. Change subject: tests: Wait for udev events after unmounting .. Patch Set 4: * Update tracker::#1267851::OK * Set MODIFIED::bug 1267851#1267851IGNORE, not oVirt prod but vdsm -- To view, visit https://gerrit.ovirt.org/47040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bd2737dae37f944cb314077a77b29c27db44677 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Wait for udev events after unmounting
Francesco Romani has submitted this change and it was merged. Change subject: tests: Wait for udev events after unmounting .. tests: Wait for udev events after unmounting Even after fixing unmounting of loop mounts using the freeLoop parameter, we still have random mount failures like: File "/home/.../vdsm/storage/mount.py", line 241, in _runcmd raise MountError(rc, ";".join((out, err))) MountError: (32, ';mount: /tmp/vdsm-mkimage-tests.03sjxb/images/vmId_floppy...img: failed to setup loop device: No such file or directory\n') It seems that loop device detach is asynchronous, thanks to good old udev. Waiting until things settle down can avoid this issue. Change-Id: I4bd2737dae37f944cb314077a77b29c27db44677 Bug-Url: https://bugzilla.redhat.com/1267851 Signed-off-by: Nir Soffer Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/46702 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/47040 Continuous-Integration: Francesco Romani Tested-by: Francesco Romani --- M tests/mkimageTests.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Francesco Romani: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bd2737dae37f944cb314077a77b29c27db44677 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: profiling: move exceptions in a module
automat...@ovirt.org has posted comments on this change. Change subject: profiling: move exceptions in a module .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/47593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b12ea00b1613c028b0de2aeee9a9d3cc7a3b1e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: profiling: import yappi outside lock
automat...@ovirt.org has posted comments on this change. Change subject: profiling: import yappi outside lock .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/47591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31d69a70efce2348e2b74e5d8a20e81b2c598321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: WIP profiling: memory: port from dowser to tracemalloc
automat...@ovirt.org has posted comments on this change. Change subject: WIP profiling: memory: port from dowser to tracemalloc .. Patch Set 3: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::WARN, Still open on branches master * Check merged to previous::WARN, Still missing on branches ovirt-3.6 -- To view, visit https://gerrit.ovirt.org/47595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a3af13ea48bb75d40ed11e56de04d90452ff7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: profiling: disambiguate profile identifiers
automat...@ovirt.org has posted comments on this change. Change subject: profiling: disambiguate profile identifiers .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/47592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43159009318295313855a16688b249982e40b34 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: profiling: add support for memory profiling
automat...@ovirt.org has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/47594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: profile: transform into a subpackage
automat...@ovirt.org has posted comments on this change. Change subject: profile: transform into a subpackage .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/47590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd925e566a9af69d4b42a70fa835b072bb1f7a0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: retry when flushing socket
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: retry when flushing socket .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/47637/2/vdsm/rpc/bindingxmlrpc.py File vdsm/rpc/bindingxmlrpc.py: Line 299: # An final socket error may have occurred here, Line 300: # such as the local error ECONNABORTED. Line 301: break Line 302: except SSL.SSLError as e: Line 303: if e.message == 'bad write retry': > we don't have any other mean to do this check? an error code, maybe? As you see m2crypto is very good at giving us error code. (everything is in message). Line 304: continue Line 305: else: Line 306: break Line 307: -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: retry when flushing socket
Francesco Romani has posted comments on this change. Change subject: xmlrpc: retry when flushing socket .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/47637/2/vdsm/rpc/bindingxmlrpc.py File vdsm/rpc/bindingxmlrpc.py: Line 299: # An final socket error may have occurred here, Line 300: # such as the local error ECONNABORTED. Line 301: break Line 302: except SSL.SSLError as e: Line 303: if e.message == 'bad write retry': we don't have any other mean to do this check? an error code, maybe? Line 304: continue Line 305: else: Line 306: break Line 307: -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: retry when flushing socket
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: retry when flushing socket .. Patch Set 2: Verified+1 Verified on broken host when this error occurs. -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: retry when flushing socket
Piotr Kliczewski has uploaded a new change for review. Change subject: xmlrpc: retry when flushing socket .. xmlrpc: retry when flushing socket m2crypto requires retry of write and we need to make sure that we do it once flushing data before closing a socket. In order to do so we need to move original implementation to our code base. Bug-Url: https://bugzilla.redhat.com/1261255 Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Signed-off-by: pkliczewski --- M vdsm/rpc/bindingxmlrpc.py 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/47637/2 diff --git a/vdsm/rpc/bindingxmlrpc.py b/vdsm/rpc/bindingxmlrpc.py index c521cd8..9f77457 100644 --- a/vdsm/rpc/bindingxmlrpc.py +++ b/vdsm/rpc/bindingxmlrpc.py @@ -25,6 +25,7 @@ import libvirt import threading import re +import socket import sys from vdsm.password import (ProtectedPassword, @@ -33,6 +34,7 @@ from vdsm import utils from vdsm import xmlrpc from vdsm.define import doneCode, errCode +from vdsm.m2cutils import SSL from vdsm.netinfo import getDeviceByIP import API from vdsm.exception import VdsmException @@ -288,7 +290,23 @@ return r def finish(self): -xmlrpc.IPXMLRPCRequestHandler.finish(self) +if not self.wfile.closed: +while True: +try: +self.wfile.flush() +break +except socket.error: +# An final socket error may have occurred here, +# such as the local error ECONNABORTED. +break +except SSL.SSLError as e: +if e.message == 'bad write retry': +continue +else: +break + +self.wfile.close() +self.rfile.close() threadLocal.client = None threadLocal.server = None threadLocal.flowID = None -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: retry when flushing socket
automat...@ovirt.org has posted comments on this change. Change subject: xmlrpc: retry when flushing socket .. Patch Set 2: * Update tracker::#1261255::OK * Check Bug-Url::OK * Check Public Bug::#1261255::OK, public bug * Check Product::#1261255::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/43821/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-20 10:33:01 +0530 Line 4: Commit: Ramesh Nachimuthu Line 5: CommitDate: 2015-10-23 11:50:03 +0530 Line 6: Line 7: gluster: Added VDSM verb to stop gluster related processes > Is there a similar verb to start gluster processes? I dont think so. Line 8: Line 9: Added a verb which stops the gluster related process like Line 10: brick processes, gsyncd process. Line 11: This needs to be done as part of a host moving to maintenance https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 53: ) Line 54: Line 55: _stopAllProcessesPath = utils.CommandPath( Line 56: "stop-all-gluster-processes.sh", Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh", > Will this be the standard location in all deployments? I think so. But may be we should verify with gluster team as well. Line 58: ) Line 59: Line 60: Line 61: GLUSTER_RPM_PACKAGES = ( -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Sahina Bose has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/43821/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-20 10:33:01 +0530 Line 4: Commit: Ramesh Nachimuthu Line 5: CommitDate: 2015-10-23 11:50:03 +0530 Line 6: Line 7: gluster: Added VDSM verb to stop gluster related processes Is there a similar verb to start gluster processes? Line 8: Line 9: Added a verb which stops the gluster related process like Line 10: brick processes, gsyncd process. Line 11: This needs to be done as part of a host moving to maintenance https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 53: ) Line 54: Line 55: _stopAllProcessesPath = utils.CommandPath( Line 56: "stop-all-gluster-processes.sh", Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh", Will this be the standard location in all deployments? Is this provided as part of gluster rpm? Line 58: ) Line 59: Line 60: Line 61: GLUSTER_RPM_PACKAGES = ( -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: file: removing SP assumtion on getImagesList
automat...@ovirt.org has posted comments on this change. Change subject: storage: file: removing SP assumtion on getImagesList .. Patch Set 1: * Update tracker::#1274622::OK * Check Bug-Url::OK * Check Public Bug::#1274622::OK, public bug * Check Product::#1274622::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a4c4cd7a382bd4c9a2168f39022922f24891635 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: file: removing SP assumtion on getImagesList
Simone Tiraboschi has uploaded a new change for review. Change subject: storage: file: removing SP assumtion on getImagesList .. storage: file: removing SP assumtion on getImagesList Removing SP assumtion on getImagesList to avoid it raising if called on unconnected storageDomains Change-Id: I8a4c4cd7a382bd4c9a2168f39022922f24891635 Bug-Url: https://bugzilla.redhat.com/1274622 Signed-off-by: Simone Tiraboschi --- M vdsm/storage/fileSD.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/47676/1 diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index dc4a68e..9d2e65a 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -300,10 +300,12 @@ Fetch the set of the Image UUIDs in the SD. """ # Get Volumes of an image +pools = self.getPools() +pool = pools[0] if pools else sd.BLANK_UUID pattern = os.path.join(sd.storage_repository, # ISO domains don't have images, # we can assume single domain - self.getPools()[0], + pool, self.sdUUID, sd.DOMAIN_IMAGES) pattern = os.path.join(pattern, constants.UUID_GLOB_PATTERN) files = self.oop.glob.glob(pattern) -- To view, visit https://gerrit.ovirt.org/47676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a4c4cd7a382bd4c9a2168f39022922f24891635 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Fix pre-extension calculation for chunked drives
Francesco Romani has posted comments on this change. Change subject: Live Merge: Fix pre-extension calculation for chunked drives .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.ovirt.org/47589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Libvirt quering after disk detach operation addition.
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/47629/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4130: Currently we use virDomainDetachDevice. However- That
function behaves
Line 4131: the same in that matter. (Currently it is not documented at
libvirt's
Line 4132: API docs- but after contacting libvirt's guys it turned out
that this
Line 4133: is true. Bug 1257280 opened for fixing the documentation.)
Line 4134: TODO: remove this comment when the documentation will be
fixed.
> Again, this is a backport, lets keep it as is.
Fair point. Let's ignore my nitpicking.
Line 4135:
Line 4136: :param drive: The drive that should be detached.
Line 4137: """
Line 4138: self.log.debug("Waiting for hotunplug to finish")
--
To view, visit https://gerrit.ovirt.org/47629
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
