Change in vdsm[master]: build: makefile: ship new test data

[fromani]

Francesco Romani has posted comments on this change.

Change subject: build: makefile: ship new test data
..


Patch Set 1: Verified+1

verified running 'make rpm' (on EL7/FC22)

-- 
To view, visit https://gerrit.ovirt.org/47841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: after_network_setup_fail

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hook: after_network_setup_fail
..


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/45085/17/vdsm/API.py
File vdsm/API.py:

Line 1489: self._cif._netConfigDirty = True
Line 1490: 
Line 1491: with self._rollback() as rollbackCtx:
Line 1492: supervdsm.getProxy().setupNetworks(networks, 
bondings,
Line 1493:options)
> not part of this patch
Done
Line 1494: 
Line 1495: if rollbackCtx['status'] != doneCode:
Line 1496: _after_network_setup_fail(networks, bondings, 
options)
Line 1497: return rollbackCtx


-- 
To view, visit https://gerrit.ovirt.org/45085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: enable tests to run with OVS

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: tests: enable tests to run with OVS
..


Patch Set 6:

test
test
test

test

test

test



test
test
test
test

-- 
To view, visit https://gerrit.ovirt.org/44507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c62cb2357e20f1940a34fb230947d48da8f1fba
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: missing data file

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: build: missing data file
..


build: missing data file

My local build fails with missing data file.


Change-Id: Ic7090339bc9e951e9ae72501b51b4b78589d98d1
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/47815
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
---
M tests/devices/data/Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7090339bc9e951e9ae72501b51b4b78589d98d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: taskset: commands should run on all cpus

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: taskset: commands should run on all cpus
..


lib: taskset: commands should run on all cpus

The current affinity reset logic has a bug in the
case the sysadmin puts offline one or more cpu.
This is because we use the range notation, with
the upper limit given by sysconf('SC_NPROCESSORS_ONLN')-1

Let's say we have 16 cpus, and sysadmin puts offline
cpu #11. Now we will have 15 online cpus, so we'll
build our range as 0-14, which excludes the perfectly
fine cpu #15.
Note that the range still includes the offline CPU, but
it is safe to trust the kernel NOT to use it.
However, this buggy logic make VDSM rule out TWO cpus,
one implicitely (included in range, but offline), plus
the one erroneously excluded by the range.

To fix this, we simply always use SC_NPROCESSORS_CONF
to express the maximum physical range, and we let the
kernel handle the holes on this range.

Change-Id: I0d17ab063356bcfde1192d545a7d41114eeab0be
Backport-To: 3.6
Backport-To: 3.5
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/47801
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/cmdutils.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/47801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d17ab063356bcfde1192d545a7d41114eeab0be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: taskset: commands should run on all cpus

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: lib: taskset: commands should run on all cpus
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d17ab063356bcfde1192d545a7d41114eeab0be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: Fix logging in dispatch

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: bridge: Fix logging in dispatch
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053bb322143c260bd57102480655c7efe6d34c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
..


DynamicBridge: Log TypeError exceptions raised during dispatch

When dispatching via the DynamicBridge, the dispatched function may
raise a TypeError (typically due to a coding error).  Currently we
swallow the TypeError and raise InvalidCall instead.  This hides the
underlying problem making it harder to fix.  Keep the current behavior
but log the original exception too.

Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/47546
Reviewed-by: Greg Padgett 
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Adam Litke: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Greg Padgett: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: Fix logging in dispatch

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: bridge: Fix logging in dispatch
..


bridge: Fix logging in dispatch

The dispatch function in DynamicBridge tries to log using an
uninitialized instance variable.  Also, logging was not imported by this
module.  Fix both of these problems.

Change-Id: I6053bb322143c260bd57102480655c7efe6d34c0
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/47545
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Piotr Kliczewski 
---
M vdsm/rpc/Bridge.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/47545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6053bb322143c260bd57102480655c7efe6d34c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: fake sriov device hook
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: fake sriov device hook
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotunplug: Supporting lun and cinder disks fix.

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


hotunplug: Supporting lun and cinder disks fix.

While hotunplugging, VDSM queries libvirt for the unplugged disk to
verify it was removed. This check is in _isDriveAttached, which verifies
that the disk's serial is no longer among the VM's disks. As LUN disks
and Cinder disks currently do not have a serial specified in VDSM flows,
after unplugging, _isDriveAttached queries for empty disk serial to
detect whether the disk is still there, and returns true in case there
are disks with empty serials- such as CD-ROM disks.

This patch fixes _isDriveAttached to check the disk's presence by
verifying that the disk's path no longer exists in the xml, rather
than the serial- to make it return the right value when unplugging
LUN and Cinder disks.

Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Bug-Url: https://bugzilla.redhat.com/1270834
Signed-off-by: Amit Aviram 
Reviewed-on: https://gerrit.ovirt.org/47795
Continuous-Integration: Jenkins CI
Reviewed-by: Daniel Erez 
Tested-by: Daniel Erez 
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Daniel Erez: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Amit Aviram: Verified
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotunplug: Supporting lun and cinder disks fix.

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


Patch Set 4:

* Update tracker::#1270834::OK
* Set MODIFIED::bug 1270834#1270834IGNORE, not oVirt prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/47795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hotunplug: Supporting lun and cinder disks fix.

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: API: use modern locking around VM.destroy

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: API: use modern locking around VM.destroy
..


Patch Set 10:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/42889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799b3b0d3e992df988efc6ab8e9263909062db0c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: remove _reportError

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: vm: remove _reportError
..


Patch Set 42:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/38269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5
Gerrit-PatchSet: 42
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: recovery: split long recovery function

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: recovery: split long recovery function
..


Patch Set 10: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/45288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28350d4c41a93265b8e8045cf51b004179587bf9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: remove _reportError

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: remove _reportError
..


vm: remove _reportError

Vm._reportError was an early attempt to build what
we have now with response.error().

With the new code in place there is no more reason
to use it, so this patch removes it.

Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/38269
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 26 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/38269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5
Gerrit-PatchSet: 42
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP profiling: memory: profile snapshots in vdsClient

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: WIP profiling: memory: profile snapshots in vdsClient
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47625
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7c5a074953bd54a8c2704d8aa2b074e277fdde
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: profiling: memory: port from dowser to tracemalloc

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: WIP: profiling: memory: port from dowser to tracemalloc
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a3af13ea48bb75d40ed11e56de04d90452ff7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: daemon: tracemalloc: LD_PRELOAD support

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: daemon: tracemalloc: LD_PRELOAD support
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47623
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b26a4d156394631345b0a60f212effdaef48503
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: enable tests to run with OVS

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: tests: enable tests to run with OVS
..


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/44507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c62cb2357e20f1940a34fb230947d48da8f1fba
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: enable tests to run with OVS

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: tests: enable tests to run with OVS
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/44507
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1c62cb2357e20f1940a34fb230947d48da8f1fba
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: after_network_setup_fail

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: hook: after_network_setup_fail
..


Patch Set 18:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: makefile: ship new test data

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: build: makefile: ship new test data
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: API: use modern locking around VM.destroy

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: API: use modern locking around VM.destroy
..


API: use modern locking around VM.destroy

cleanup a bit VM.destroy() without functional changes:

- log outside the lock
- use context managers for lock

Change-Id: I799b3b0d3e992df988efc6ab8e9263909062db0c
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/42889
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/API.py
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/42889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I799b3b0d3e992df988efc6ab8e9263909062db0c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: service: change vdsm KillMode to mixed

[ykaplan]

Yeela Kaplan has posted comments on this change.

Change subject: service: change vdsm KillMode to mixed
..


Patch Set 6:

Yaniv,
If we set killmode to process: only the main process itself is killed.
Which means that we could end up with vdsm zombie children that won't be killed.

If we set killmode to mixed: 
the initial SIGTERM signal is sent to the main process (vdsm only). and after a 
delay if children processes still remain another signal this time: SIGKILL 
signal is sent to all remaining processes of the unit's control group.

This means that we get both benefits of using 'process' mode and 
'control-group' mode.

First of all we systemd will termainate only vdsm.

If, after a delay, its children did not terminate on their own, then a SIGKILL 
will be sent to them.

This way we make sure no zombies are left.

I believe it is our best option.

-- 
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..


Patch Set 7: Verified+1

Passed without a regression. test_keep_initial_bond_slaves_ip_config and 
test_remove_initial_network_nic_ip_config are now OK

-- 
To view, visit https://gerrit.ovirt.org/46692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: v2v: add test for commit f8127d8

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: tests: v2v: add test for commit f8127d8
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix shell_helper to install vdsm-api rpm

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: fix shell_helper  to install vdsm-api rpm
..


fix shell_helper  to install vdsm-api rpm

7553e6 added sa new rpm that needs to be explicitly installed by the
script.

Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/47830
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M contrib/shell_helper
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs: better rollback

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: ovs: better rollback
..


Patch Set 8:

(13 comments)

https://gerrit.ovirt.org/#/c/46907/8//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-10-22 18:31:05 +0200
Line 6: 
Line 7: net: ovs: better rollback
Line 8: 
Line 9: Untill now, OVS hook was not able to rollback after failed
> Until
Done
Line 10: setup of non-OVS networks.
Line 11: 
Line 12: Now it uses after_network_setup and after_network_setup_fail
Line 13: hook points to handle general rollback for all failtures


Line 9: Untill now, OVS hook was not able to rollback after failed
Line 10: setup of non-OVS networks.
Line 11: 
Line 12: Now it uses after_network_setup and after_network_setup_fail
Line 13: hook points to handle general rollback for all failtures
> failures
Done
Line 14: (both OVS and non-OVS).
Line 15: 
Line 16: Before OVS setup we save initial OVS configuration to a temporary
Line 17: file via pickle. If an exception occurs during setupNetworks,


Line 15: 
Line 16: Before OVS setup we save initial OVS configuration to a temporary
Line 17: file via pickle. If an exception occurs during setupNetworks,
Line 18: API.py does the standard rollback. Then after_network_setup_fail
Line 19: is executed and runs setupNetworks witch special option _inOVSRollback
> with a
Done
Line 20: which triggers OVS only rollback. OVS only rollback removes all
Line 21: OVS networks and recreates them according to configuration saved in
Line 22: the temprorary file. When everything is done, temporary file is
Line 23: removed.


https://gerrit.ovirt.org/#/c/46907/8/vdsm_hooks/ovs/README
File vdsm_hooks/ovs/README:

Line 61: 1) After ovs_before_network_setup.py:configure() calls 
prepare_libvirt() (which
Line 62:is the last safe moment before we touch any system configuration) 
we save
Line 63:initial network configuration into a temporary file.
Line 64: 2) If an error occurs during setupNetworks(), non-OVS rolls back to 
the state
Line 65:between OVS and non-OVS configuration. When this rollback finishes
> finishes,
Done
Line 66:ovs_after_network_setup_fail.py is executed. This scripts just 
executes
Line 67:setupNetworks command with special option _inOVSRollback which 
tells OVS
Line 68:hook to do a rollback.
Line 69: 2.1) If there is a temporary file containing initial network 
configuration,


Line 114:  |
Line 115:  V
Line 116:   
+---+
Line 117:   |  *API.setupNetworks()*
|
Line 118:   |  |If anything bad happen, it  
|
> happens
Done
Line 119:   | network setup   : will trigger non-OVS rollback 
(which|
Line 120:   |  |will be ignored by OVS). when 
it's done |
Line 121:   |  |it will continue with   
|
Line 122:   |  |after_network_setup_fail hook 
point.|


Line 132:      |Receives _inRollback=True 
and
Line 133:     *ovs_before_network_setup*  :  _inOVSRollback=True. If 
there   
Line 134:      |is no OVS init config, we   
 
Line 135:      |just log. If the file 
exists 
Line 136:      |we remove all OVS networks, 
  
> trailing space
Done
Line 137:      |and recreate networks   
 
Line 138:      |according to saved config.  
 
Line 139:      |Then we send empty 
configuration 
Line 140:      |back to VDSM, because of 
VDSM


https://gerrit.ovirt.org/#/c/46907/8/vdsm_hooks/ovs/ovs_after_get_stats.py
File vdsm_hooks/ovs/ovs_after_get_stats.py:

Line 1: #!/usr/bin/env python
> The file has a hashbang, but its mode changed to non-executable in this com
Makefile turns it into a executable. This test does not have embedded test, to 
it does not need x flag. But according to your patch comment, I'm changing it.
Line 2: # Copyright 2015 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/46907/8/vdsm_hooks/ovs/ovs_after_network_setup.py
File vdsm_hooks/ovs/ovs_after_network_setup.py:

Line 37: elif inRollback and inOVSRollback:
Line 38: hooking.log('OVS rollback is done. Removing OVS init_config 
backup.')
Line 39: remove_init_config()
Line 40: else:
Line 41: hooking.log('Network setup was successfull. 

Change in vdsm[master]: fix shell_helper to install vdsm-api rpm

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: fix shell_helper  to install vdsm-api rpm
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs: better rollback

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: ovs: better rollback
..


Patch Set 9:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46907
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: Adding dns as additional field for setupNetworks ifcfg:...

[gcheresh]

Genadi Chereshnya has uploaded a new change for review.

Change subject: api: Adding dns as additional field for setupNetworks ifcfg: 
Updating ifcfg file with DNSs
..

api: Adding dns as additional field for setupNetworks
ifcfg: Updating ifcfg file with DNSs

Adding DNSs to the setupNetwork command

With multiple paragraphs if necessary.

Change-Id: Ib9ea16d033cc07ef10c05868da3e6b4bcee56f74
Bug-Url: https://bugzilla.redhat.com/??
Signed-off-by: Genadi Chereshnya 
---
M vdsm/network/api.py
M vdsm/network/configurators/ifcfg.py
2 files changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/47843/1

diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index 4ed64f3..e3f8289 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -89,7 +89,7 @@
 ipv6addr=None, ipv6gateway=None, ipv6autoconf=None,
 dhcpv6=None, defaultRoute=None, _netinfo=None,
 configurator=None, blockingdhcp=None,
-implicitBonding=None, opts=None):
+implicitBonding=None, opts=None, dnss=None):
 """
 Constructs an object hierarchy that describes the network configuration
 that is passed in the parameters.
@@ -118,6 +118,7 @@
  routing table?
 :param opts: misc options received by the callee, e.g., {'stp': True}. this
  function can modify the dictionary.
+:param dnss: list of DNSs
 
 :returns: the top object of the hierarchy.
 """
@@ -249,7 +250,7 @@
 ipv6addr=None, ipv6gateway=None, ipv6autoconf=None,
 force=False, configurator=None, bondingOptions=None,
 bridged=True, _netinfo=None, hostQos=None,
-defaultRoute=None, blockingdhcp=False, **options):
+defaultRoute=None, blockingdhcp=False, dnss=None, **options):
 nics = nics or ()
 if _netinfo is None:
 _netinfo = netinfo.NetInfo()
@@ -311,7 +312,8 @@
 netmask=netmask, gateway=gateway, bootproto=bootproto, dhcpv6=dhcpv6,
 blockingdhcp=blockingdhcp, ipv6addr=ipv6addr, ipv6gateway=ipv6gateway,
 ipv6autoconf=ipv6autoconf, defaultRoute=defaultRoute,
-_netinfo=_netinfo, configurator=configurator, opts=options)
+_netinfo=_netinfo, configurator=configurator, opts=options, dnss=dnss
+)
 
 if bridged and network in _netinfo.bridges:
 net_ent_to_configure = net_ent.port
diff --git a/vdsm/network/configurators/ifcfg.py 
b/vdsm/network/configurators/ifcfg.py
index c2b0345..c342d90 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -503,7 +503,9 @@
 if self.unifiedPersistence and utils.isOvirtNode():
 node_fs.Config().persist(fileName)
 
-def _createConfFile(self, conf, name, ipv4, ipv6, mtu=None, **kwargs):
+def _createConfFile(
+self, conf, name, ipv4, ipv6, mtu=None, dnss=None, **kwargs
+):
 """ Create ifcfg-* file with proper fields per device """
 cfg = 'DEVICE=%s\n' % pipes.quote(name)
 cfg += conf
@@ -536,6 +538,10 @@
 elif ipv6.dhcpv6:
 cfg += 'DHCPV6C=yes\n'
 cfg += 'IPV6_AUTOCONF=%s\n' % _to_ifcfg_bool(ipv6.ipv6autoconf)
+if dnss:
+for i, dns in enumerate(dnss):
+cfg += 'DNS' + str(i+1) + '=%s\n' % dns
+
 BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'VLAN', 'bondingOptions',
  'force', 'blockingdhcp', 'custom',
  'connectivityCheck', 'connectivityTimeout',


-- 
To view, visit https://gerrit.ovirt.org/47843
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9ea16d033cc07ef10c05868da3e6b4bcee56f74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: Adding dns as additional field for setupNetworks ifcfg:...

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: api: Adding dns as additional field for setupNetworks ifcfg: 
Updating ifcfg file with DNSs
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47843
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9ea16d033cc07ef10c05868da3e6b4bcee56f74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: after_network_setup_fail

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hook: after_network_setup_fail
..


Patch Set 18: Verified+1

Verified with hook:

#!/bin/python
import hooking
with open('/tmp/test_hook', 'a') as f:
setup = hooking.read_json()
f.write(str(setup))
f.write('\n')


In [14]: from vdsm import vdscli

In [15]: c = vdscli.connect()

In [16]: !ip l add dummy_1 type dummy

In [17]: c.setupNetworks({'test-network1': {'nic': 'dummy_1'}}, {}, 
{'connectivityCheck': False})
Out[17]: {'status': {'code': 0, 'message': 'Done'}}

In [18]: c.setupNetworks({'test-network1': {'nic': 'dummy_2'}}, {}, 
{'connectivityCheck': False})
Out[18]: {'status': {'code': 23, 'message': 'unknown nic: dummy_2'}}

In [19]: !cat /tmp/test_hook
{u'request': {u'bondings': {}, u'networks': {u'test-network1': {u'nic': 
u'dummy_2'}}, u'options': {u'connectivityCheck': False}}}

-- 
To view, visit https://gerrit.ovirt.org/45085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: AsyncDispatcher tests suite

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: AsyncDispatcher tests suite
..


Patch Set 5: Code-Review+2

raising Yaniv's vote

-- 
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18a58d1d8ffe4f8ea2cd8dec9bb2e508c73c7f8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: fake sriov device hook
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[ibarkan]

Ido Barkan has uploaded a new change for review.

Change subject: net: fake sriov device hook
..

net: fake sriov device hook

This hook fakes both getVdsCaps and hostdevListByCaps to make VDSM
report devices and capabilities of an SR-IOV capable host.

Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Signed-off-by: Ido Barkan 
---
M configure.ac
M contrib/shell_helper
M vdsm.spec.in
M vdsm_hooks/Makefile.am
A vdsm_hooks/fakesriov/Makefile.am
A vdsm_hooks/fakesriov/after_get_caps.py
A vdsm_hooks/fakesriov/after_hostdev_list_by_caps.py
7 files changed, 185 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/47847/1

diff --git a/configure.ac b/configure.ac
index 068c4b5..e68f1b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -369,6 +369,7 @@
vdsm_hooks/diskunmap/Makefile
vdsm_hooks/ethtool_options/Makefile
vdsm_hooks/extnet/Makefile
+   vdsm_hooks/fakesriov/Makefile
vdsm_hooks/fakevmstats/Makefile
vdsm_hooks/faqemu/Makefile
vdsm_hooks/fileinject/Makefile
diff --git a/contrib/shell_helper b/contrib/shell_helper
index 7dc2984..6b6314a 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -10,7 +10,7 @@
 
 _latest_rpms() {
 local VERSION=$(_latest_version)
-find ~/rpmbuild/RPMS/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra"
+find ~/rpmbuild/RPMS/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra|api"
 }
 
 vdsm_configure_force() {
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 3d6b51a..3c49487 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -430,6 +430,14 @@
 To enable this hook on your host, set vars.fake_vmstats_enable=true in your
 /etc/vdsm/vdsm.conf.
 
+%package hook-fakesriov
+Summary:Generate fake SR-IOV dsvices
+Requires:   %{name}
+
+%description hook-fakesriov
+Hook intercepts reported host device by hostdevListByCaps and adds
+1 fake sriov devices and 2 fake virtual function devices
+
 %package hook-fileinject
 Summary:Allow uploading file to VMs disk
 Requires:   python-libguestfs
@@ -1273,6 +1281,11 @@
 %defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/after_get_all_vm_stats/10_fakevmstats
 
+%files hook-fakesriov
+%defattr(-, root, root, -)
+%{_libexecdir}/%{vdsm_name}/hooks/after_hostdev_list_by_caps/10_fakesriov
+%{_libexecdir}/%{vdsm_name}/hooks/after_get_caps/10_fakesriov
+
 %files hook-fileinject
 %defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_fileinject
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index 0573b2c..dda39bc 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -40,6 +40,7 @@
diskunmap \
extnet \
fileinject \
+   fakesriov \
fakevmstats \
floppy \
hostusb \
diff --git a/vdsm_hooks/fakesriov/Makefile.am b/vdsm_hooks/fakesriov/Makefile.am
new file mode 100644
index 000..2d6bc8d
--- /dev/null
+++ b/vdsm_hooks/fakesriov/Makefile.am
@@ -0,0 +1,40 @@
+#
+# Copyright 2015 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  
USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+include $(top_srcdir)/build-aux/Makefile.subs
+
+CLEANFILES = \
+   config.log
+
+EXTRA_DIST = \
+   after_hostdev_list_by_caps.py \
+   after_get_caps.py
+
+install-data-local:
+   $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_hostdev_list_by_caps
+   $(INSTALL_SCRIPT) $(srcdir)/after_hostdev_list_by_caps.py \
+   
$(DESTDIR)$(vdsmhooksdir)/after_hostdev_list_by_caps/10_fakesriov
+   $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_get_caps
+   $(INSTALL_SCRIPT) $(srcdir)/after_get_caps.py \
+   $(DESTDIR)$(vdsmhooksdir)/after_get_caps/10_fakesriov
+
+uninstall-local:
+   $(RM) $(DESTDIR)$(vdsmhooksdir)/after_hostdev_list_by_caps/10_fakesriov
+   $(RM) $(DESTDIR)$(vdsmhooksdir)/after_get_caps/10_fakesriov
diff --git a/vdsm_hooks/fakesriov/after_get_caps.py 
b/vdsm_hooks/fakesriov/after_get_caps.py
new file mode 100644
index 000..38dbb39
--- /dev/null
+++ b/vdsm_hooks/fakesriov/after_get_caps.py
@@ -0,0 +1,57 @@
+#!/usr/bin/python
+#

Change in vdsm[master]: tests: AsyncDispatcher tests suite

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: AsyncDispatcher tests suite
..


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18a58d1d8ffe4f8ea2cd8dec9bb2e508c73c7f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: AsyncDispatcher tests suite

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: AsyncDispatcher tests suite
..


tests: AsyncDispatcher tests suite

Change-Id: Ie18a58d1d8ffe4f8ea2cd8dec9bb2e508c73c7f8
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/43394
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
A tests/stompAsyncDispatcherTests.py
2 files changed, 169 insertions(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie18a58d1d8ffe4f8ea2cd8dec9bb2e508c73c7f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps.py: import rpm only if available

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: caps.py: import rpm only if available
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296dab1b3006a42bd04694e6872215e0d381815e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Erez Freiberger 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Erez Freiberger 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: v2v: refactor tests to make it extensible

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: tests: v2v: refactor tests to make it extensible
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0c2f9575debd328a2c8e0dacdb8e8dc845e340
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: missing data file

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: build: missing data file
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7090339bc9e951e9ae72501b51b4b78589d98d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: missing data file

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: build: missing data file
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7090339bc9e951e9ae72501b51b4b78589d98d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: fake sriov device hook
..


Patch Set 1:

shell_helper is here only until after https://gerrit.ovirt.org/#/c/44198/ will 
be merged and then the rebase will eliminate this.

-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: recovery: split long recovery function

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: recovery: split long recovery function
..


Patch Set 11:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/45288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28350d4c41a93265b8e8045cf51b004179587bf9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: recovery: split long recovery function

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: recovery: split long recovery function
..


recovery: split long recovery function

Split the long recovery function in clientif in subfunctions,
one for each recovery stage.

No planned change in functionality.

Change-Id: I28350d4c41a93265b8e8045cf51b004179587bf9
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/45288
Reviewed-by: Yaniv Bronhaim 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/clientIF.py
1 file changed, 39 insertions(+), 30 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/45288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28350d4c41a93265b8e8045cf51b004179587bf9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: makefile: ship new test data

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: build: makefile: ship new test data
..

build: makefile: ship new test data

In commit 3476258bf95b024ed769b09e43c5c4e78b445ebf
We added new test data, but we forgot to ship it as
data, breaking the rpm build phase.

This patch fixes that.

Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Signed-off-by: Francesco Romani 
---
M tests/devices/data/Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/47841/1

diff --git a/tests/devices/data/Makefile.am b/tests/devices/data/Makefile.am
index 6a5f543..040ab8e 100644
--- a/tests/devices/data/Makefile.am
+++ b/tests/devices/data/Makefile.am
@@ -34,6 +34,7 @@
scsi_host0.xml \
scsi_target0_0_0.xml \
testComplexVm.xml \
+   testSRiovVm.xml \
usb_1_1.xml \
usb_1_1_4.xml \
usb_usb1.xml \


-- 
To view, visit https://gerrit.ovirt.org/47841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: makefile: ship new test data

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: build: makefile: ship new test data
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..


Patch Set 6:

(9 comments)

https://gerrit.ovirt.org/#/c/46692/6/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File vdsm_hooks/ovs/ovs_before_network_setup_ip.py:

Line 89: _run_dhclient(iface, blockingdhcp, ipv6.defaultRoute, 6)
Line 90: iproute2._addSourceRoute(net_dev)
Line 91: 
Line 92: 
Line 93: def _remove_ip_config(iface, ipv4, ipv6, vdsm=True):
> such an awful arg name begs for a docstring
i forgot to remove this one, not needed
Line 94: net_dev = NetDevice(iface, iproute2, ipv4=ipv4, ipv6=ipv6)
Line 95: DynamicSourceRoute.addInterfaceTracking(net_dev)
Line 96: DhcpClient(iface).shutdown()
Line 97: iproute2._removeSourceRoute(net_dev, DynamicSourceRoute)


Line 100: ipwrapper.addrFlush(iface)
Line 101: 
Line 102: 
Line 103: def _drop_ip_config(iface):
Line 104: """Remove IP configuration of a new nic attached to VDSM"""
> nics are controlled by Vdsm, not attached to it.
Done
Line 105: if os.path.exists(os.path.join('/sys/class/net', iface)):
Line 106: kill_dhclient(iface, family=4)  # kill_dhclient flushes IP
Line 107: kill_dhclient(iface, family=6)
Line 108: 


Line 114: ipv4 = _get_ipv4_model(attrs)
Line 115: ipv6 = _get_ipv6_model(attrs)
Line 116: port = attrs.get('nic') or attrs.get('bonding')
Line 117: blocking_dhcp = 'blockingdhcp' in attrs
Line 118: return top_dev, ipv4, ipv6, port, blocking_dhcp
> Tuples are not bad by themselves, but I'd like to see a container object wi
Done
Line 119: 
Line 120: ip_config_to_set = {}
Line 121: ip_config_to_remove = {}
Line 122: 


Line 128: else:
Line 129: top_dev, ipv4, ipv6, port, blocking_dhcp = 
_gather_ip_config(attrs)
Line 130: 
Line 131: if net in init_nets:  # if network was edited
Line 132: init_top_dev, init_ipv4, init_ipv6, _, _ = \
> We can do without slashes.
Done
Line 133: _gather_ip_config(init_nets[net])
Line 134: 
Line 135: # drop IP of newly attached nics
Line 136: if init_nets[net].get('nic') != attrs.get('nic') is 
not None:


Line 132: init_top_dev, init_ipv4, init_ipv6, _, _ = \
Line 133: _gather_ip_config(init_nets[net])
Line 134: 
Line 135: # drop IP of newly attached nics
Line 136: if init_nets[net].get('nic') != attrs.get('nic') is 
not None:
> I failed to interpret this.
yourself or inside interpreter?

it means: (original nic is not the same as the new one) and (new nic is not 
None). = we changed nic, not just removed it.

In [1]: init_nets = {'net1': {'nic': 'dummy_1'}}

In [2]: init_nets['net1'].get('nic') != {'nic': 'dummy_1'}.get('nic') is 
not None
Out[2]: False

In [3]: init_nets['net1'].get('nic') != {'nic': None}.get('nic') is not None
Out[3]: False

In [4]: init_nets['net1'].get('nic') != {'nic': 'dummy_2'}.get('nic') is 
not None
Out[4]: True
Line 137: _drop_ip_config(attrs.get('nic'))
Line 138: 
Line 139: # if IP config is to be changed or net top device was 
changed,
Line 140: # remove initial configuration and set the new one if 
any


Line 135: # drop IP of newly attached nics
Line 136: if init_nets[net].get('nic') != attrs.get('nic') is 
not None:
Line 137: _drop_ip_config(attrs.get('nic'))
Line 138: 
Line 139: # if IP config is to be changed or net top device was 
changed,
> a network's top device?
Done
Line 140: # remove initial configuration and set the new one if 
any
Line 141: if (ipv4 != init_ipv4 or ipv6 != init_ipv6 or
Line 142: attrs.get('vlan') != 
init_nets[net].get('vlan')):
Line 143: ip_config_to_remove[init_top_dev] = ipv4, ipv6


Line 136: if init_nets[net].get('nic') != attrs.get('nic') is 
not None:
Line 137: _drop_ip_config(attrs.get('nic'))
Line 138: 
Line 139: # if IP config is to be changed or net top device was 
changed,
Line 140: # remove initial configuration and set the new one if 
any
> Please be more verbose. Is it "any configuration"?
Done
Line 141: if (ipv4 != init_ipv4 or ipv6 != init_ipv6 or
Line 142: attrs.get('vlan') != 
init_nets[net].get('vlan')):
Line 143: ip_config_to_remove[init_top_dev] = ipv4, ipv6
Line 144: if ipv4 or ipv6:


Line 146:  blocking_dhcp)
Line 147: else:  # if network was added
Line 148: # drop IP of newly attached nics
Line 149:  

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..


Patch Set 7:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: makefile: ship new test data

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: build: makefile: ship new test data
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/47841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: makefile: ship new test data

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: build: makefile: ship new test data
..


Abandoned

sorry, I've noticed https://gerrit.ovirt.org/47815 first.

-- 
To view, visit https://gerrit.ovirt.org/47841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hotunplug: Supporting lun and cinder disks fix.

[aaviram]

Hello Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/47846

to review the following change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..

hotunplug: Supporting lun and cinder disks fix.

While hotunplugging, VDSM queries libvirt for the unplugged disk to
verify it was removed. This check is in _isDriveAttached, which verifies
that the disk's serial is no longer among the VM's disks. As LUN disks
and Cinder disks currently do not have a serial specified in VDSM flows,
after unplugging, _isDriveAttached queries for empty disk serial to
detect whether the disk is still there, and returns true in case there
are disks with empty serials- such as CD-ROM disks.

This patch fixes _isDriveAttached to check the disk's presence by
verifying that the disk's path no longer exists in the xml, rather
than the serial- to make it return the right value when unplugging
LUN and Cinder disks.

Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Bug-Url: https://bugzilla.redhat.com/1270834
Signed-off-by: Amit Aviram 
Reviewed-on: https://gerrit.ovirt.org/47795
Continuous-Integration: Jenkins CI
Reviewed-by: Daniel Erez 
Tested-by: Daniel Erez 
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/47846/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 1cc44b6..a5eead1 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2691,7 +2691,11 @@
 
 def _isDriveAttached(self, drive):
 root = ET.fromstring(self._dom.XMLDesc(0))
-return bool(root.findall("./devices/disk[serial='%s']" % drive.serial))
+source_key = {DISK_TYPE.FILE: 'file',
+  DISK_TYPE.BLOCK: 'dev',
+  DISK_TYPE.NETWORK: 'name'}
+return bool(root.findall("./devices/disk/source[@%s='%s']" %
+ (source_key[drive.diskType], drive.path)))
 
 def _readPauseCode(self):
 state, reason = self._dom.state(0)


-- 
To view, visit https://gerrit.ovirt.org/47846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hotunplug: Supporting lun and cinder disks fix.

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


Patch Set 1:

* Update tracker::#1270834::OK
* Check Bug-Url::OK
* Check Public Bug::#1270834::OK, public bug
* Check Product::#1270834::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps.py: import rpm only if available

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: caps.py: import rpm only if available
..


Patch Set 4: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/47035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296dab1b3006a42bd04694e6872215e0d381815e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Erez Freiberger 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Erez Freiberger 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: fake sriov device hook
..


Patch Set 2: Code-Review-1

14:05:23 ./vdsm_hooks/fakesriov/after_get_caps.py:37:29: E128 continuation line 
under-indented for visual indent
14:05:23 ./vdsm_hooks/fakesriov/after_get_caps.py:38:29: E128 continuation line 
under-indented for visual indent
14:05:23 Makefile:1007: recipe for target 'pep8' failed

-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake sriov device hook

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: fake sriov device hook
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/47847/2/vdsm_hooks/fakesriov/after_hostdev_list_by_caps.py
File vdsm_hooks/fakesriov/after_hostdev_list_by_caps.py:

Line 22: import hooking
Line 23: 
Line 24: _FAKE_SRIOV = {
Line 25: # sriov device
Line 26: 'pci__02_00_0': {
can you use fancier PCI addresses (say, bus 22 instead of 02) so there is a 
lesser chance we would collide with a true device on a true host?
Line 27: 'params': {
Line 28: 'address': {'bus': '2', 'domain': '0', 'function': '0',
Line 29: 'slot': '0'},
Line 30: 'capability': 'pci', 'iommu_group': '15',


Line 32: 'product': '82576 Gigabit Network Connection',
Line 33: 'product_id': '0x10e7', 'totalvfs': 7,
Line 34: 'vendor': 'Intel Corporation', 'vendor_id': '0x8086'}},
Line 35: # sriov net device
Line 36: 'net_enp2s0f0_78_e7_d1_e4_8f_16': {
same request applies to nic names.
Line 37: 'params': {
Line 38: 'capability': 'net', 'interface': 'enp2s0f0',
Line 39: 'parent': 'pci__02_00_0'}},
Line 40: # vf1


Line 66: 'capability': 'net', 'interface': 'enp2s16f2',
Line 67: 'parent': 'pci__02_10_2'}}}
Line 68: 
Line 69: if __name__ == '__main__':
Line 70: host_devices = hooking.read_json()
people tend to install hooks automatically, and then complain that their host 
behaves in a silly way.

Please make this hook disabled by default (see https://gerrit.ovirt.org/43931 ) 
and add a little README file explaining for what is this hook good for (demoing 
and testing our new feature).
Line 71: host_devices.update(_FAKE_SRIOV)


-- 
To view, visit https://gerrit.ovirt.org/47847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661e152adf6365962b5d9fd215277b36bc49383
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps.py: import rpm only if available

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: caps.py: import rpm only if available
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296dab1b3006a42bd04694e6872215e0d381815e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Erez Freiberger 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Erez Freiberger 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps.py: import rpm only if available

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: caps.py: import rpm only if available
..


Patch Set 3: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/47035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296dab1b3006a42bd04694e6872215e0d381815e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Erez Freiberger 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Erez Freiberger 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hotunplug: Supporting lun and cinder disks fix.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM create inactive LV

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: FakeLVM create inactive LV
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304e00116c5dc4c98555eb3951fe8eb33d65da7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add FakeLVM LV properties tests

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Add FakeLVM LV properties tests
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bca30db49db84fc5d42ff8736a4c69f17b17247
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM add lvPath test

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: FakeLVM add lvPath test
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47863
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM support initialTag when creating LV

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: FakeLVM support initialTag when creating LV
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47861
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4da4bf5e36a9476ecf34b588a494f1839857291d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add initial FakeLVM tests and fix errors

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Add initial FakeLVM tests and fix errors
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1650b98f25df1a22ba2a0920b093e78fc2fdee88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add initial FakeLVM tests and fix errors

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add initial FakeLVM tests and fix errors
..

tests: Add initial FakeLVM tests and fix errors

The FakeLVM class inside storagefakelib.py is becoming increasingly
complex.  In order to ensure that FakeLVM is providing correct LVM
emulation we need to test its output against what a real LVM environment
would present.

This first patch introduces the new test module and adds some tests for
createVG and getVG.  We test that the VG properties and attributes
returned match a real LVM installation.  After writing these tests I
found and fixed several errors in the existing FakeLVM implementation.

Change-Id: I1650b98f25df1a22ba2a0920b093e78fc2fdee88
Signed-off-by: Adam Litke 
---
M tests/Makefile.am
M tests/storagefakelib.py
A tests/storagefakelibTests.py
3 files changed, 161 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/47857/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 1168862..e8b9d6e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -102,6 +102,7 @@
stompAdapterTests.py \
stompAsyncClientTests.py \
stompTests.py \
+   storagefakelibTests.py \
storageMailboxTests.py \
storageMonitorTests.py \
storageServerTests.py \
diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 11954d5..a60aaf5 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -26,19 +26,29 @@
 
 
 class FakeLVM(object):
-_PV_SIZE = 10 << 30  # We pretend all PVs contribute 10G of space
-
+_PV_SIZE = 10 << 30 # We pretend all PVs are 10G in size
+_PV_PE_SIZE = 128 << 20 # Found via inspection of real environment
+_PV_MDA_COUNT = 2   # The number of PEs used for metadata areas
+_PV_UNUSABLE = (_PV_PE_SIZE *   # 2 PE for metadata + 1 PE to hold a header
+(1 + _PV_MDA_COUNT))
 def __init__(self, root):
 self.root = root
 os.mkdir(os.path.join(self.root, 'dev'))
+self.pvmd = {}
 self.vgmd = {}
 self.lvmd = {}
 
 def createVG(self, vgName, devices, initialTag, metadataSize,
- extentsize=134217728, force=False):
-devices = [_fqpvname(dev) for dev in devices]
-size = self._PV_SIZE * len(devices)
-extent_count = size / extentsize
+ extentsize=128, force=False):
+# Convert params from MB to bytes to match other fields
+metadataSize <<= 20
+extentsize <<= 20
+
+for dev in devices:
+self._create_pv(dev, vgName, self._PV_SIZE)
+pv_name = tuple([_fqpvname(pdev) for pdev in _normalizeargs(devices)])
+extent_count = self._calc_vg_pe_count(vgName)
+size = extent_count * self._PV_PE_SIZE
 
 vg_attr = dict(permission='w',
resizeable='z',
@@ -49,17 +59,17 @@
 vg_md = dict(uuid=fake_lvm_uuid(),
  name=vgName,
  attr=vg_attr,
- size=size,
- free=size,
- extent_size=extentsize,
- extent_count=extent_count,
- free_count=extent_count,
- tags=[initialTag],
- vg_mda_size=metadataSize,
- vg_mda_free=metadataSize,
+ size=str(size),
+ free=str(size),
+ extent_size=str(extentsize),
+ extent_count=str(extent_count),
+ free_count=str(extent_count),
+ tags=(initialTag,),
+ vg_mda_size=str(metadataSize),
+ vg_mda_free=None,
  lv_count='0',
- pv_count=len(devices),
- pv_name=tuple(devices),
+ pv_count=str(len(devices)),
+ pv_name=pv_name,
  writeable=True,
  partial='OK')
 self.vgmd[vgName] = vg_md
@@ -123,7 +133,31 @@
 with open(volpath, "w") as f:
 f.truncate(int(self.lvmd[vg_name][lv_name]['size']))
 
+def _create_pv(self, pv_name, vg_name, size):
+# pe_start is difficult to calculate correctly but since it's not
+# currently needed by users of FakeLVM, set it to None.
+pe_start = None
+pe_count = (size - self._PV_UNUSABLE) / self._PV_PE_SIZE
+pv_md = dict(uuid=fake_lvm_uuid(),
+ name='/dev/mapper/%s' % pv_name,
+ guid=pv_name,
+ size=str(pe_count * self._PV_PE_SIZE),
+ vg_name=vg_name,
+ vg_uuid=None,  # This is calculated dynamically
+ pe_start=pe_start,
+ pe_count=str(pe_count),
+

Change in vdsm[master]: tests: FakeLVM test command failure

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: FakeLVM test command failure
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM add support for activateLVs

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: FakeLVM add support for activateLVs
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1e2aa609263a945a55d3bac271b600c7f32ab0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add FakeLVM PV properties tests

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add FakeLVM PV properties tests
..

tests: Add FakeLVM PV properties tests

When using the lvm module to create a VG from one or more devices, those
devices are converted into PVs implicitly.  The lvm module can return
information about these PVs.  Add some basic tests to verify the PV
properties against real lvm module output.

Change-Id: I629380923d4e3105a02b55df548d2a142c8def0a
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/47858/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index a60aaf5..1eb0c86 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -108,6 +108,12 @@
 def lvPath(self, vgName, lvName):
 return os.path.join(self.root, "dev", vgName, lvName)
 
+def getPV(self, pvName):
+md = deepcopy(self.pvmd[pvName])
+vg_name = md['vg_name']
+md['vg_uuid'] = self.vgmd[vg_name]['uuid']
+return real_lvm.PV(**md)
+
 def getVG(self, vgName):
 vg_md = deepcopy(self.vgmd[vgName])
 vg_attr = real_lvm.VG_ATTR(**vg_md['attr'])
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 8c73a54..549c0a4 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -108,3 +108,30 @@
 with self.base_config() as lvm:
 vg = lvm.getVG(self.VG_NAME)
 self.assertEqual(None, vg.vg_mda_free)
+
+@permutations([
+['name', '/dev/mapper/%s' % DEVICES[0]],
+['size', '10334765056'],
+['vg_name', VG_NAME],
+['pe_count', '77'],
+['pe_alloc_count', '0'],
+['mda_count', '2'],
+['dev_size', '10737418240'],
+['guid', DEVICES[0]],
+])
+def test_pv_properties(self, var, val):
+with self.base_config() as lvm:
+pv = lvm.getPV(self.DEVICES[0])
+self.assertEqual(val, getattr(pv, var))
+
+def test_pv_vg_uuid(self):
+with self.base_config() as lvm:
+vg = lvm.getVG(self.VG_NAME)
+pv = lvm.getPV(self.DEVICES[0])
+self.assertEqual(pv.vg_uuid, vg.uuid)
+
+def test_pv_pe_start(self):
+# As documented in FakeLVM, pe_start is not emulated and should be None
+with self.base_config() as lvm:
+pv = lvm.getPV(self.DEVICES[0])
+self.assertIsNone(pv.pe_start)


-- 
To view, visit https://gerrit.ovirt.org/47858
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I629380923d4e3105a02b55df548d2a142c8def0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add FakeLVM PV properties tests

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Add FakeLVM PV properties tests
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47858
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I629380923d4e3105a02b55df548d2a142c8def0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM add lvPath test

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeLVM add lvPath test
..

tests: FakeLVM add lvPath test

Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236
Signed-off-by: Adam Litke 
---
M tests/storagefakelibTests.py
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/47863/1

diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 55ed760..ca0d398 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -18,6 +18,7 @@
 #
 
 from contextlib import contextmanager
+import os
 
 from testlib import VdsmTestCase, namedTemporaryDir
 from testlib import permutations, expandPermutations
@@ -278,3 +279,14 @@
 lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
 self.assertTrue(lv.active)
 self.assertEqual('a', lv.attr.state)
+
+
+class FakeLVMGeneralTests(VdsmTestCase):
+
+def test_lvpath(self):
+with namedTemporaryDir() as tmpdir:
+lvm = FakeLVM(tmpdir)
+vg_name = 'foo'
+lv_name = 'bar'
+expected = os.path.join(tmpdir, 'dev', vg_name, lv_name)
+self.assertEqual(expected, lvm.lvPath(vg_name, lv_name))


-- 
To view, visit https://gerrit.ovirt.org/47863
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM create inactive LV

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeLVM create inactive LV
..

tests: FakeLVM create inactive LV

Test that the 'activate' argument of createLV results in the appropriate
values in the LV properties.

Change-Id: I304e00116c5dc4c98555eb3951fe8eb33d65da7f
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 30 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/47860/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 52dce33..3c20a7c 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -83,11 +83,12 @@
 # works the same as for LVM).  Since we don't need this value, use None
 devices = None
 
+state = 'a' if activate else '-'
 lv_attr = dict(voltype='-',
permission='w',
allocations='i',
fixedminor='-',
-   state='a',
+   state=state,
devopen='-',
target='-',
zero='-')
@@ -101,7 +102,7 @@
  tags=(),
  writeable=True,
  opened=False,
- active=True)
+ active=bool(activate))
 
 vg_dict = self.lvmd.setdefault(vgName, {})
 vg_dict[lvName] = lv_md
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index a80a9a2..7be6c10 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -195,3 +195,30 @@
 with self.base_config() as lvm:
 lv = self.lv_config(lvm)
 self.assertIsNone(lv.devices)
+
+def test_lv_no_activate(self):
+"""
+Create a logical volume with activate=False.
+
+lvm.createLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+ '54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+ '1024', activate=False)
+
+print lvm.getLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+'54e3378a-b2f6-46ff-b2da-a9c82522a55e')
+LV(uuid='dDbzkJ-RSAQ-0CdJ-1pTD-OdqZ-3my2-v3hSUT',
+   name='54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+   vg_name='1ffead52-7363-4968-a8c7-3bc34504d452',
+   attr=LV_ATTR(voltype='-', permission='w', allocations='i',
+fixedminor='-', state='-', devopen='-', target='-',
+zero='-'),
+   size='1073741824', seg_start_pe='0',
+   devices='/dev/mapper/360014054d75cb132d474c0eae9825766(0)', tags=(),
+   writeable=True, opened=False, active=False)
+"""
+with self.base_config() as lvm:
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB),
+ activate=False)
+lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
+self.assertFalse(lv.active)
+self.assertEqual('-', lv.attr.state)


-- 
To view, visit https://gerrit.ovirt.org/47860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I304e00116c5dc4c98555eb3951fe8eb33d65da7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM test command failure

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeLVM test command failure
..

tests: FakeLVM test command failure

Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 49 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/47864/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 1548ab9..9e2536f 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -23,6 +23,7 @@
 from copy import deepcopy
 
 from storage import lvm as real_lvm
+from storage import storage_exception as se
 
 
 class FakeLVM(object):
@@ -77,7 +78,10 @@
 def createLV(self, vgName, lvName, size, activate=True, contiguous=False,
  initialTag=None):
 # Size is expected as a string in MB, convert to a string in bytes.
-size = str(int(size) << 20)
+try:
+size = str(int(size) << 20)
+except ValueError:
+raise se.CannotCreateLogicalVolume(vgName, lvName)
 
 # devices is hard to emulate properly (must have a PE allocator that
 # works the same as for LVM).  Since we don't need this value, use None
@@ -105,36 +109,57 @@
  opened=False,
  active=bool(activate))
 
-vg_dict = self.lvmd.setdefault(vgName, {})
+try:
+vg_dict = self.lvmd.setdefault(vgName, {})
+lv_count = int(self.vgmd[vgName]['lv_count']) + 1
+except KeyError:
+raise se.CannotCreateLogicalVolume(vgName, lvName)
+
+if lvName in vg_dict:
+raise se.CannotCreateLogicalVolume(vgName, lvName)
+
 vg_dict[lvName] = lv_md
-lv_count = int(self.vgmd[vgName]['lv_count']) + 1
 self.vgmd[vgName]['lv_count'] = str(lv_count)
 
 def activateLVs(self, vgName, lvNames):
 for lv in lvNames:
-self.lvmd[vgName][lv]['active'] = True
-self.lvmd[vgName][lv]['attr']['state'] = 'a'
+try:
+self.lvmd[vgName][lv]['active'] = True
+self.lvmd[vgName][lv]['attr']['state'] = 'a'
+except KeyError as e:
+raise se.CannotActivateLogicalVolume(str(e))
 
 def addtag(self, vg, lv, tag):
-self.lvmd[vg][lv]['tags'] += (tag,)
+try:
+self.lvmd[vg][lv]['tags'] += (tag,)
+except KeyError:
+raise se.MissingTagOnLogicalVolume("%s/%s" % (vg, lv), tag)
 
 def lvPath(self, vgName, lvName):
 return os.path.join(self.root, "dev", vgName, lvName)
 
 def getPV(self, pvName):
-md = deepcopy(self.pvmd[pvName])
+try:
+md = deepcopy(self.pvmd[pvName])
+except KeyError:
+raise se.InaccessiblePhysDev((pvName,))
 vg_name = md['vg_name']
 md['vg_uuid'] = self.vgmd[vg_name]['uuid']
 return real_lvm.PV(**md)
 
 def getVG(self, vgName):
+if vgName not in self.vgmd:
+raise se.VolumeGroupDoesNotExist(vgName)
 vg_md = deepcopy(self.vgmd[vgName])
 vg_attr = real_lvm.VG_ATTR(**vg_md['attr'])
 vg_md['attr'] = vg_attr
 return real_lvm.VG(**vg_md)
 
 def _getLV(self, vgName, lvName):
-lv_md = deepcopy(self.lvmd[vgName][lvName])
+try:
+lv_md = deepcopy(self.lvmd[vgName][lvName])
+except KeyError:
+raise se.LogicalVolumeDoesNotExistError("%s/%s" % (vgName, lvName))
 lv_attr = real_lvm.LV_ATTR(**lv_md['attr'])
 lv_md['attr'] = lv_attr
 return real_lvm.LV(**lv_md)
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index ca0d398..c3712dd 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -25,6 +25,7 @@
 from storagefakelib import FakeLVM
 
 from storage import blockSD, blockVolume
+from storage import storage_exception as se
 
 
 @expandPermutations
@@ -281,6 +282,7 @@
 self.assertEqual('a', lv.attr.state)
 
 
+@expandPermutations
 class FakeLVMGeneralTests(VdsmTestCase):
 
 def test_lvpath(self):
@@ -290,3 +292,17 @@
 lv_name = 'bar'
 expected = os.path.join(tmpdir, 'dev', vg_name, lv_name)
 self.assertEqual(expected, lvm.lvPath(vg_name, lv_name))
+
+@permutations([
+[se.VolumeGroupDoesNotExist, 'getVG', ['vg']],
+[se.CannotActivateLogicalVolume, 'activateLVs', ['vg', ['lv']]],
+[se.MissingTagOnLogicalVolume, 'addtag', ['vg', 'lv', 'tag']],
+[se.CannotCreateLogicalVolume, 'createLV', ['vg', 'lv', '1024']],
+[se.LogicalVolumeDoesNotExistError, 'getLV', ['vg', 'lv']],
+[se.InaccessiblePhysDev, 'getPV', ['pv']],
+])
+def test_bad_args(self, exception, fn, args):
+with namedTemporaryDir() as tmpdir:
+ 

Change in vdsm[master]: tests: FakeLVM add support for activateLVs

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeLVM add support for activateLVs
..

tests: FakeLVM add support for activateLVs

Change-Id: Ic1e2aa609263a945a55d3bac271b600c7f32ab0f
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 33 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/47862/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 3755ec3..1548ab9 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -111,7 +111,9 @@
 self.vgmd[vgName]['lv_count'] = str(lv_count)
 
 def activateLVs(self, vgName, lvNames):
-pass
+for lv in lvNames:
+self.lvmd[vgName][lv]['active'] = True
+self.lvmd[vgName][lv]['attr']['state'] = 'a'
 
 def addtag(self, vg, lv, tag):
 self.lvmd[vg][lv]['tags'] += (tag,)
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 6da7190..55ed760 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -248,3 +248,33 @@
  initialTag=blockVolume.TAG_VOL_UNINIT)
 lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
 self.assertEqual((blockVolume.TAG_VOL_UNINIT,), lv.tags)
+
+def test_activatelv(self):
+"""
+Create an inactive LV and then activate it.
+
+lvm.createLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+ '54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+ '1024', activate=False)
+lvm.activateLVs('1ffead52-7363-4968-a8c7-3bc34504d452',
+['54e3378a-b2f6-46ff-b2da-a9c82522a55e'])
+
+print lvm.getLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+'54e3378a-b2f6-46ff-b2da-a9c82522a55e')
+LV(uuid='P8Y7p8-V13j-rWDp-FvGk-5AX1-zXhp-ZU4K2G',
+   name='54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+   vg_name='1ffead52-7363-4968-a8c7-3bc34504d452',
+   attr=LV_ATTR(voltype='-', permission='w', allocations='i',
+fixedminor='-', state='a', devopen='-', target='-',
+zero='-'),
+   size='1073741824', seg_start_pe='0',
+   devices='/dev/mapper/360014054d75cb132d474c0eae9825766(0)', tags=(),
+   writeable=True, opened=False, active=True)
+"""
+with self.base_config() as lvm:
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB),
+ activate=False)
+lvm.activateLVs(self.VG_NAME, [self.LV_NAME])
+lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
+self.assertTrue(lv.active)
+self.assertEqual('a', lv.attr.state)


-- 
To view, visit https://gerrit.ovirt.org/47862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1e2aa609263a945a55d3bac271b600c7f32ab0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add FakeLVM LV properties tests

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add FakeLVM LV properties tests
..

tests: Add FakeLVM LV properties tests

Building on the example environment in FakeLVMSimpleVGTests we create a
single logical volume.  We then verify that the properties and
attributes of that LV match what is returned by the real lvm module.
Some problems were found in FakeLVM and are resolved here.

Change-Id: I1bca30db49db84fc5d42ff8736a4c69f17b17247
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 72 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/47859/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 1eb0c86..52dce33 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -76,6 +76,13 @@
 
 def createLV(self, vgName, lvName, size, activate=True, contiguous=False,
  initialTag=None):
+# Size is expected as a string in MB, convert to a string in bytes.
+size = str(int(size) << 20)
+
+# devices is hard to emulate properly (must have a PE allocator that
+# works the same as for LVM).  Since we don't need this value, use None
+devices = None
+
 lv_attr = dict(voltype='-',
permission='w',
allocations='i',
@@ -90,20 +97,22 @@
  attr=lv_attr,
  size=str(size),
  seg_start_pe='0',
- devices='',
- tags=[],
+ devices=None,
+ tags=(),
  writeable=True,
  opened=False,
  active=True)
 
 vg_dict = self.lvmd.setdefault(vgName, {})
 vg_dict[lvName] = lv_md
+lv_count = int(self.vgmd[vgName]['lv_count']) + 1
+self.vgmd[vgName]['lv_count'] = str(lv_count)
 
 def activateLVs(self, vgName, lvNames):
 pass
 
 def addtag(self, vg, lv, tag):
-self.lvmd[vg][lv]['tags'].append(tag)
+self.lvmd[vg][lv]['tags'] += (tag,)
 
 def lvPath(self, vgName, lvName):
 return os.path.join(self.root, "dev", vgName, lvName)
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 549c0a4..a80a9a2 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -30,6 +30,8 @@
 class FakeLVMSimpleVGTests(VdsmTestCase):
 VG_NAME = '1ffead52-7363-4968-a8c7-3bc34504d452'
 DEVICES = ['360014054d75cb132d474c0eae9825766']
+LV_NAME = '54e3378a-b2f6-46ff-b2da-a9c82522a55e'
+LV_SIZE_MB = 1024
 
 @contextmanager
 def base_config(self):
@@ -68,6 +70,28 @@
  blockSD.STORAGE_UNREADY_DOMAIN_TAG,
  blockSD.VG_METADATASIZE)
 yield lvm
+
+def lv_config(self, lvm):
+"""
+Create a single logical volume on the base configuration.
+
+lvm.createLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+ '54e3378a-b2f6-46ff-b2da-a9c82522a55e', 1024)
+
+print lvm.getLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+'54e3378a-b2f6-46ff-b2da-a9c82522a55e')
+LV(uuid='89tSvh-HJl5-SO2K-O36t-3qkj-Zo2J-yugkjk',
+   name='54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+   vg_name='1ffead52-7363-4968-a8c7-3bc34504d452',
+   attr=LV_ATTR(voltype='-', permission='w', allocations='i',
+fixedminor='-', state='a', devopen='-', target='-',
+zero='-'),
+   size='1073741824', seg_start_pe='0',
+   devices='/dev/mapper/360014054d75cb132d474c0eae9825766(0)',
+   tags=(), writeable=True, opened=False, active=True)
+"""
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB))
+return lvm.getLV(self.VG_NAME, self.LV_NAME)
 
 @permutations([
 ['name', VG_NAME],
@@ -135,3 +159,39 @@
 with self.base_config() as lvm:
 pv = lvm.getPV(self.DEVICES[0])
 self.assertIsNone(pv.pe_start)
+
+@permutations([
+['name', LV_NAME],
+['vg_name', VG_NAME],
+['size', '1073741824'],
+['seg_start_pe', '0'],
+['tags', ()],
+['writeable', True],
+['opened', False],
+['active', True],
+])
+def test_lv_properties(self, var, val):
+with self.base_config() as lvm:
+lv = self.lv_config(lvm)
+self.assertEqual(val, getattr(lv, var))
+
+@permutations([
+['voltype', '-'],
+['permission', 'w'],
+['allocations', 'i'],
+['fixedminor', '-'],
+['state', 'a'],
+['devopen', '-'],
+['target', '-'],
+['zero', '-'],
+])
+def test_lv_attributes(self, var, val):
+with self.base_config() 

Change in vdsm[master]: tests: FakeLVM support initialTag when creating LV

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeLVM support initialTag when creating LV
..

tests: FakeLVM support initialTag when creating LV

Change-Id: I4da4bf5e36a9476ecf34b588a494f1839857291d
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 29 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/47861/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 3c20a7c..3755ec3 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -84,6 +84,7 @@
 devices = None
 
 state = 'a' if activate else '-'
+tags = (initialTag,) if initialTag is not None else ()
 lv_attr = dict(voltype='-',
permission='w',
allocations='i',
@@ -99,7 +100,7 @@
  size=str(size),
  seg_start_pe='0',
  devices=None,
- tags=(),
+ tags=tags,
  writeable=True,
  opened=False,
  active=bool(activate))
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 7be6c10..6da7190 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -23,7 +23,7 @@
 from testlib import permutations, expandPermutations
 from storagefakelib import FakeLVM
 
-from storage import blockSD
+from storage import blockSD, blockVolume
 
 
 @expandPermutations
@@ -222,3 +222,29 @@
 lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
 self.assertFalse(lv.active)
 self.assertEqual('-', lv.attr.state)
+
+def test_lv_initialtag(self):
+"""
+Create a logical volume with an initial tag.
+
+lvm.createLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+ '54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+ '1024', initialTag=blockVolume.TAG_VOL_UNINIT)
+
+print lvm.getLV('1ffead52-7363-4968-a8c7-3bc34504d452',
+'54e3378a-b2f6-46ff-b2da-a9c82522a55e')
+LV(uuid='yJngqd-2kRy-9ogk-D7Gk-v3b1-RDQm-cb1bJv',
+   name='54e3378a-b2f6-46ff-b2da-a9c82522a55e',
+   vg_name='1ffead52-7363-4968-a8c7-3bc34504d452',
+   attr=LV_ATTR(voltype='-', permission='w', allocations='i',
+fixedminor='-', state='a', devopen='-', target='-',
+zero='-'), size='1073741824', seg_start_pe='0',
+   devices='/dev/mapper/360014054d75cb132d474c0eae9825766(0)',
+   tags=('OVIRT_VOL_INITIALIZING',), writeable=True, opened=False,
+   active=True)
+"""
+with self.base_config() as lvm:
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB),
+ initialTag=blockVolume.TAG_VOL_UNINIT)
+lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
+self.assertEqual((blockVolume.TAG_VOL_UNINIT,), lv.tags)


-- 
To view, visit https://gerrit.ovirt.org/47861
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4da4bf5e36a9476ecf34b588a494f1839857291d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Report vg name in getDeviceList

[alitke]

Adam Litke has posted comments on this change.

Change subject: hsm: Report vg name in getDeviceList
..


Patch Set 3:

(1 comment)

One minor schema issue but otherwise looks ok.

https://gerrit.ovirt.org/#/c/45823/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1495:   'pathstatus': ['BlockDevicePathInfo'],
Line 1496:   'pathlist': ['IscsiSessionInfo'], 'logicalblocksize': 
'uint',
Line 1497:   'physicalblocksize': 'uint', 'partitioned': 'bool',
Line 1498:   'pvsize': 'uint', 'status': 'BlockDeviceStatus',
Line 1499:   'vgname': 'str'}}
The type should be UUID.
Line 1500: 
Line 1501: ##
Line 1502: # @Host.getDeviceList:
Line 1503: #


-- 
To view, visit https://gerrit.ovirt.org/45823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I116714cb5143ea92f5cb54c3f80f895c07ada536
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: scsi: Scan only the required domain type

[alitke]

Adam Litke has posted comments on this change.

Change subject: scsi: Scan only the required domain type
..


Patch Set 1:

This one worries me.  The sdCache has a state machine that assumes that we are 
not doing partial refreshes.  I'm concerned about the potential for race 
conditions where one thread refreshes some storage while another thread is 
blocked on refresh of the other type of storage.  Although I cannot see 
anything clearly wrong in this patch, I'm still not convinced it's correct.

-- 
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Reformat device info dict

[alitke]

Adam Litke has posted comments on this change.

Change subject: hsm: Reformat device info dict
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/45845
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic285575545ccdbe449d1c6b95f5874f8e15711ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: guest-agent: desktopLock exception on EBADF should be ignored
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/47404/4/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:

Line 377: if e.args[0] != errno.EBADF:
Line 378: self.log.warning("desktopLock failed", exc_info=True)
Line 379: except Exception:
Line 380: self.log.warning("desktopLock failed with unexpected 
exception",
Line 381:  exc_info=True)
We want to get rid of the non standard exc_info - and you are using 
self.log.exception elsewhere, so I would keep logging of unexpected exceptions 
like the other calls.

To filter only socket.error with EBADF, you can do:

except Exception as e:
if isintance(e, socket.error) and e.args[0] == errno.EBADF:
return  # Expected because ...
logging.exception("desktopLock failed")
Line 382: 
Line 383: def desktopLogin(self, domain, user, password):
Line 384: try:
Line 385: self.log.debug("desktopLogin called")


-- 
To view, visit https://gerrit.ovirt.org/47404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd032471396a97999c2cea5c88ae04ec8ca4028
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json cli: use ssl when creating a socket

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: json cli: use ssl when creating a socket
..


Patch Set 7:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45611
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa15584eed90945cdf2eb8cad17ed7697678932
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix shell_helper to install vdsm-api rpm

[ibarkan]

Ido Barkan has uploaded a new change for review.

Change subject: fix shell_helper  to install vdsm-api rpm
..

fix shell_helper  to install vdsm-api rpm

7553e6 added sa new rpm that needs to be explicitly installed by the
script.

Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Signed-off-by: Ido Barkan 
---
M contrib/shell_helper
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/47830/1

diff --git a/contrib/shell_helper b/contrib/shell_helper
index 7dc2984..6b6314a 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -10,7 +10,7 @@
 
 _latest_rpms() {
 local VERSION=$(_latest_version)
-find ~/rpmbuild/RPMS/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra"
+find ~/rpmbuild/RPMS/ -iname "*$VERSION*.rpm" | egrep 
"vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra|api"
 }
 
 vdsm_configure_force() {


-- 
To view, visit https://gerrit.ovirt.org/47830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix shell_helper to install vdsm-api rpm

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: fix shell_helper  to install vdsm-api rpm
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/47830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: functional - convert to run over jsonrpc

[ykaplan]

Yeela Kaplan has posted comments on this change.

Change subject: tests: functional - convert to run over jsonrpc
..


Patch Set 8:

(4 comments)

https://gerrit.ovirt.org/#/c/45789/8/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 59: 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
Line 60: 'setMOMPolicy': 'Host.setMOMPolicy',
Line 61: 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
Line 62: 'setupNetworks': 'Host.setupNetworks',
Line 63: 'updateVmPolicy': 'VM.updateVmPolicy',
> I guess there are many more verbs.. those are only the needed once for the 
Verbs can be added in one patch. 
But it is unrelated to this change which is about making the vdsm functional 
tests work over jsonrpc.

It can either be done all in one patch before this one.
Or add the remaining verbs in a following patch after this is merged.

Please choose your preference.
Line 64: }
Line 65: 
Line 66: 
Line 67: class _Server(object):


Line 93: timeout = kwargs.pop('longOp', CALL_TIMEOUT)
Line 94: 
Line 95: req = JsonRpcRequest(method, params, reqId=str(uuid4()))
Line 96: 
Line 97: responses = self._client.call(req, timeout=timeout)
> I'd split this additional timeout to another patch
I will add another patch to make this more coherent.
Line 98: if responses:
Line 99: resp = responses[0]
Line 100: else:
Line 101: raise JsonRpcNoResponseError(method)


Line 105:   resp.error["message"])
Line 106: 
Line 107: if not self._compat:
Line 108: return response.success_raw(resp.result)
Line 109: 
> need more info why or when to use compat=True.. I'd add this in separate pa
I will add another patch to make this more coherent.
Line 110: if resp.result and resp.result is not True:
Line 111: # None is translated to True inside our JSONRPC 
implementation
Line 112: return response.success(**resp.result)
Line 113: 


Line 120: 
Line 121: def create(self, params):
Line 122: return self._callMethod('create',
Line 123: params['vmId'],
Line 124: params)
> why those two are different from the others methods?
Please look at API and Bridge and the way it is parsed there.
Line 125: 
Line 126: def __getattr__(self, methodName):
Line 127: return partial(self._callMethod, methodName)
Line 128: 


-- 
To view, visit https://gerrit.ovirt.org/45789
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba1e2811f010e4509a658acef8040ad8f39cece
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: lvm: Use udev cache for obtaining device list

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
..


Patch Set 1:

now that jenkins' approved this patch, let's take it in.

-- 
To view, visit https://gerrit.ovirt.org/47810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: lvm: Use udev cache for obtaining device list

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: lvm: Use udev cache for obtaining device list
..


lvm: Use udev cache for obtaining device list

Due to udev issues, the udev cache was ignored when obtaining
the device list.
Since these issues are fixed in Fedora 21 and RHEL 7, the lvm
configuration can be reverted to use the udev cache.

Original bug : https://bugzilla.redhat.com/1014942

Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Bug-Url: https://bugzilla.redhat.com/1272027
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/47430
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47810
Reviewed-by: Allon Mureinik 
Reviewed-by: Francesco Romani 
---
M vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/47810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: lvm: Use udev cache for obtaining device list

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
..


Patch Set 2:

* Update tracker::#1272027::OK
* Set MODIFIED::bug 1272027#1272027IGNORE, not oVirt prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/47810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: support iperf3 for performance tests

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: tests: support iperf3 for performance tests
..


Patch Set 21:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test tc upper limit using iperf

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: net: tests: test tc upper limit using iperf
..


Patch Set 21:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9348a09e331195695c16862ef986df3b4abfa991
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test tc upper limit using iperf

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: tests: test tc upper limit using iperf
..


Patch Set 20:

(3 comments)

https://gerrit.ovirt.org/#/c/46449/20/tests/tcTests.py
File tests/tcTests.py:

Line 37: vlan_device, requires_tc,
   : veth_pair, IperfServer, IperfClient, 
requires_iperf3,
   : requires_tun, bridge_device, network_namespace
> I prefer the order Classes, functions, alphabetically.
Done


Line 45: vdsm.utils
> utils goes after libvirtconnection (yeah, vdsm.constants and network.tc are
Done


Line 489:  \
> We can do without slashes :-)
not sure how


-- 
To view, visit https://gerrit.ovirt.org/46449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9348a09e331195695c16862ef986df3b4abfa991
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix shell_helper to install vdsm-api rpm

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: fix shell_helper  to install vdsm-api rpm
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied72a4d0496d5d08e9698cde52e91e5d3b71673c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: lvm: Use udev cache for obtaining device list

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lvm: Use udev cache for obtaining device list
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia67fc82a519275324dcf34e954ae126df7895bf6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ssl: change default protocol

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: ssl: change default protocol
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/43457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40267cb07b19d444c7d85aba6d1160c27e8fe3a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ssl: change default protocol

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: ssl: change default protocol
..


Patch Set 3:

* Update tracker::#1229765::OK
* Check Bug-Url::OK
* Check Public Bug::#1229765::OK, public bug
* Check Product::#1229765::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40267cb07b19d444c7d85aba6d1160c27e8fe3a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: taskset: commands should run on all cpus

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: lib: taskset: commands should run on all cpus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d17ab063356bcfde1192d545a7d41114eeab0be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotunplug: Supporting lun and cinder disks fix.

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


Patch Set 3:

Verified on Cinder, Direct LUN, File+Block disks. both successful and 
unsuccessful unplugging.

-- 
To view, visit https://gerrit.ovirt.org/47795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotunplug: Supporting lun and cinder disks fix.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: Supporting lun and cinder disks fix.
..


Patch Set 3:

How did you check unsuccessful unplug?

-- 
To view, visit https://gerrit.ovirt.org/47795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I826eba42903167988da1d02b916feb8fcd19258e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches