Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 3: * #1279740::Update tracker: OK * #1279740::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279740::OK, public bug * Check Public Bug::#1279740::OK, public bug * Check Product::#1279740::OK, Correct classification oVirt * Check Product::#1279740::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: scheduler: use single instance
automat...@ovirt.org has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 2: * #1279740::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279740::OK, public bug * Check Product::#1279740::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 2: bug created + commit message updated. -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 2: * #1279740::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279740::OK, public bug * Check Product::#1279740::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 2: any way to trigger CI? I don't see it running at all on this patch... -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Collect stats from online cpu cores only
automat...@ovirt.org has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 10: * #1264003::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1264003::OK, public bug * Check Product::#1264003::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v
automat...@ovirt.org has posted comments on this change. Change subject: v2v: add fake virt-v2v process for testing without virt-v2v .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: remove redundant tabs from vdsmd init script
Yeela Kaplan has posted comments on this change. Change subject: remove redundant tabs from vdsmd init script .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c09fb78b14bf2184c69f01bed34333d9fc43eed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use {name} instead of explicit vdsm
Yeela Kaplan has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use {name} instead of explicit vdsm
Yaniv Bronhaim has uploaded a new change for review.
Change subject: spec: use {name} instead of explicit vdsm
..
spec: use {name} instead of explicit vdsm
Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Signed-off-by: Yaniv Bronhaim
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/48323/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 22f91d6..15e3f12 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -286,7 +286,7 @@
Requires: %{name}-python = %{version}-%{release}
Requires: %{name}-api = %{version}-%{release}
Requires: %{name}-yajsonrpc = %{version}-%{release}
-Obsoletes: vdsm-api < 4.16
+Obsoletes: %{name}-api < 4.16
%description jsonrpc
A Json-based RPC interface that serves as the protocol for libvdsm.
--
To view, visit https://gerrit.ovirt.org/48323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use {name} instead of explicit vdsm
automat...@ovirt.org has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/48323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: use {name} instead of explicit vdsm
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: use {name} instead of explicit vdsm
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic91ac5dddc595f87b23c04071f3c2e0e66b1f738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Ramesh N has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: zombiereaper is not removed on vdsm upgrade
Yaniv Bronhaim has posted comments on this change. Change subject: spec: zombiereaper is not removed on vdsm upgrade .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I039ca8102ed910f9be890e3b7fff5375a0105467 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: utils: replace import for persist/unpersist
Yaniv Bronhaim has submitted this change and it was merged. Change subject: utils: replace import for persist/unpersist .. utils: replace import for persist/unpersist Use the new ovirt-node Config class for persist/unpersist commands. The previous persist/unpersist provider uses /tmp/ovirt.log and might affect the vdsm start as missing ownership of file. Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1274063 Signed-off-by: Douglas Schilling Landgraf Reviewed-on: https://gerrit.ovirt.org/47829 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch Reviewed-by: Dan Kenigsberg (cherry picked from commit f754d1de8f4458a7f482f6509e57aa2087c50ff0) Reviewed-on: https://gerrit.ovirt.org/47968 Reviewed-by: Yaniv Bronhaim Continuous-Integration: Yaniv Bronhaim --- M lib/vdsm/utils.py 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Yaniv Bronhaim: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: utils: replace import for persist/unpersist
automat...@ovirt.org has posted comments on this change. Change subject: utils: replace import for persist/unpersist .. Patch Set 2: * #1274063::Update tracker: OK * Set MODIFIED::bug 1274063#1274063IGNORE, not oVirt prod but vdsm -- To view, visit https://gerrit.ovirt.org/47968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: utils: replace import for persist/unpersist
Yaniv Bronhaim has posted comments on this change. Change subject: utils: replace import for persist/unpersist .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/47968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: ova should support zip and extracted directory formats
Shahar Havivi has posted comments on this change. Change subject: v2v: ova should support zip and extracted directory formats .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/48129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I494b88709c4c23fd39690b589eff1134e74f81ba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Ramesh N has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 274: @makePublic Line 275: def stopProcesses(): Line 276: command = ["/bin/sh", _stopAllProcessesPath.cmd] Line 277: rc, out, err = utils.execCmd(command) Line 278: if rc: > Looking at the schema file I can see that we return true or false depending Looks like all gluster functions are returning exceptions instead of false. We have to fix all of them and that requires change in the engine as well. Can we live with exceptions for the time being?. Line 279: raise ge.GlusterStopProcessesFailedException(rc) Line 280: return True Line 281: Line 282: Line 771: stopProcesses(sel > Please change the name as ProcessesStop to be consistent with other verbs. Done. Changed this to ProcessesStop in all the places. -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Set mount path based on gluster volume info .. Patch Set 3: * #1278880::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1278880::OK, public bug * Check Product::#1278880::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Ramesh N has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 4: Code-Review-1 Marking it as -1 since the dependent gluster patch is not yet merged. -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/48308/2/tests/storageServerTests.py
File tests/storageServerTests.py:
Line 148: self.assertEquals(gluster.options,
Line 149:
"backup-volfile-servers=192.168.122.2:192.168.122.3")
Line 150:
Line 151: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
Line 152: def
test_gluster_mount_options_when_gluster_provided_server_not_in_volinfo(self):
This name his way too long - this break the test report visually.
The word gluster is redundant, this is the GlusterFSConnectionTests. (Should be
fixed also in other tests later).
Use shorter name like "test_unknown_server" or "test_server_not_in_volinfo"
If needed add a comment giving more context; test names are not short stories.
Line 153: def glusterVolumeInfo(volname=None, volfileServer=None):
Line 154: return {'music': {'brickCount': '3',
Line 155: 'bricks': ['192.168.122.5:/tmp/music',
Line 156: '192.168.122.2:/tmp/music',
https://gerrit.ovirt.org/#/c/48308/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 310
Line 311
Line 312
Line 313
Line 314
Keep the old code for now.
Line 337: raise
se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 338:
Line 339: def _get_backup_servers_option(self):
Line 340: servers = [brick.split(":")[0] for brick in
self.volinfo['bricks']]
Line 341: self._volfileserver = servers.pop(0)
There is a major issue with this change.
If a user has an old mount, it will use the user server:/volname. Using new
semantics, we try to mount the same volume under possibly different mountpoint,
mounting the same domain twice, and possibly causing data corruption or other
severe trouble.
So we cannot use bricks[0] as the server.
We can do this:
if self._volfileserver in servers:
server.remove(self._volfileserver)
else:
self.log.warning("gluster server 'foo' not in bricks, using possibly
duplicate backup server ['bar', 'baz', 'dup']")
So we always connect the gluster server that the user configured, and we keep
compatibility with older versions.
If the user have two names for the one of the servers, she will have 3 backup
servers - hopefully this works with gluster, if not, the user must fix the
configuration.
Sahina, what do you think?
Line 342: if not servers:
Line 343: return ""
Line 344:
Line 345: return "backup-volfile-servers=" + ":".join(servers)
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Pull some vars into the class
Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Pull some vars into the class .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/46977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1601ec61a30971f175630013023e8be2de77da17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Pull some vars into the class
automat...@ovirt.org has posted comments on this change. Change subject: register: Pull some vars into the class .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1601ec61a30971f175630013023e8be2de77da17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: Ensure that the vdsm uuid is a string
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: Ensure that the vdsm uuid is a string .. Patch Set 1: Code-Review-1 Make sense dan's comment, moving to -1 as well. -- To view, visit https://gerrit.ovirt.org/46970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1f341dd66a468cf704158789e158f6d61f1d98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...
Ondřej Svoboda has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 4: Verified+1 The test runs now (with the other formerly unrecognized option). I also made sure that 'primary' is recognized by VDSM, even though it failed to be set by initscripts due to the kernel bug or my misunderstanding. -- To view, visit https://gerrit.ovirt.org/48008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2bbd778bb151e4671cc5d3d70ce898e48125331 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Collect stats from online cpu cores only
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File tests/hoststatsTests.py:
Line 107:
Line 108:
Line 109: class HostStatsThreadTests(TestCaseBase):
Line 110:
Line 111: def _expectedResult(self, node_index=0):
Having default value only make the tests harder to understand.
Better require all caller to specify the node_index, will make the tests more
readable.
Also _expectedResult is meaningless, isn't this cpuStats dict?
Line 112: return {
Line 113: str(node_index): {
Line 114: 'cpuIdle': '100.00',
Line 115: 'cpuSys': '0.00',
Line 125: },
Line 126: 1: {
Line 127: 'cpus': [1]
Line 128: }
Line 129: }
Why is this so verbose? What is wrong with:
{0: {'cpus': [0]}, 1: {'cpus': [1]}}
And why do we need a function to return this in tests?
Line 130:
Line 131: def testCpuCoreStats(self):
Line 132: cpu_sample = {'user': 1.0, 'sys': 2.0}
Line 133:
Line 137: with MonkeyPatchScope([(caps, 'getNumaTopology',
Line 138: self._fakeNumaTopology)]):
Line 139: result = hoststats._get_cpu_core_stats(first_sample,
last_sample)
Line 140: self.assertEqual(result['0'], self._expectedResult()['0'])
Line 141: self.assertEqual(result['1'],
self._expectedResult(1)['1'])
You are using only one dict in each assert, so I don't understand why
_expectedResults is needed at all.
This is much more clear:
expected = {'cpuIdle': 100.0, ...}
self.assertEqual(result['1'], expected)
Line 142:
Line 143: def testSkipStatsOnMissingFirstSample(self):
Line 144: cpu_sample = {'user': 1.0, 'sys': 2.0}
Line 145:
Line 149: with MonkeyPatchScope([(caps, 'getNumaTopology',
Line 150: self._fakeNumaTopology)]):
Line 151: self.assertEqual(
Line 152: hoststats._get_cpu_core_stats(first_sample,
last_sample),
Line 153: self._expectedResult())
Again we are using one dict, better inline it.
Line 154:
Line 155: def testSkipStatsOnMissingLastSample(self):
Line 156: cpu_sample = {'user': 1.0, 'sys': 2.0}
Line 157:
Line 161: with MonkeyPatchScope([(caps, 'getNumaTopology',
Line 162: self._fakeNumaTopology)]):
Line 163: self.assertEqual(
Line 164: hoststats._get_cpu_core_stats(first_sample,
last_sample),
Line 165: self._expectedResult())
Same
Line 166:
Line 167: def testOutputWithNoSamples(self):
Line 168: expected = {
Line 169: 'cpuIdle': 100.0,
https://gerrit.ovirt.org/#/c/46269/9/vdsm/virt/hoststats.py
File vdsm/virt/hoststats.py:
Line 103: last_sample.cpuCores.getCoreSample(cpu_core)[mode] -
Line 104: first_sample.cpuCores.getCoreSample(cpu_core)[mode]
Line 105: ) % JIFFIES_BOUND
Line 106: return ("%.2f" % (jiffies / interval))
Line 107: except TypeError:
> this is the only thing that bothers me in this patch. We spent some time re
Please never check None with TypeError - write code that reveal your intent.
Line 108: return None
Line 109:
Line 110: cpu_core_stats = {}
Line 111: for node_index, numa_node in
six.iteritems(caps.getNumaTopology()):
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Roman Mohr
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 336
Line 337
Line 338
Line 339
Line 340
> We know that this is the first server, so we should remove using pop(0), or
Done
Line 335: if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 336: raise
se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 337:
Line 338: def _get_backup_servers_option(self):
Line 339: self._volfileserver = self.volinfo['bricks'][0].split(":")[0]
> This is messy. You start with value A, then you switch to value B.
Done
Line 340: servers = [brick.split(":")[0] for brick in
self.volinfo['bricks']]
Line 341: servers.remove(self._volfileserver)
Line 342: if not servers:
Line 343: return ""
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Set mount path based on gluster volume info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...
Ondřej Svoboda has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 4: It is all the same problem, and initscripts are not to blame. It is either me or the kernel on F22 at least. 'primary' is supposed to be set after slaves are attached. And so initscripts were patched to do set 'primary' later than other options. In any case, under any mode or link state or the presence of slaves, trying to modify 'primary' gives an error "Permission denied". Since we need to fix our bug, I replaced 'primary' in a test with 'arp_ip_target', which is the other bonding option that would not be recognized before. -- To view, visit https://gerrit.ovirt.org/48008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2bbd778bb151e4671cc5d3d70ce898e48125331 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bonding defaults: for validation, we need to be aware of all...
automat...@ovirt.org has posted comments on this change. Change subject: bonding defaults: for validation, we need to be aware of all options .. Patch Set 4: * #1262496::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1262496::OK, public bug * Check Product::#1262496::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2bbd778bb151e4671cc5d3d70ce898e48125331 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration added migrateChangeParams verb
Francesco Romani has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 7:
(2 comments)
another note in schema, otherwise seems ok
https://gerrit.ovirt.org/#/c/46934/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 7754: {'command': {'class': 'VM', 'name': 'migrateCancel'},
Line 7755: 'data': {'vmID': 'UUID'}}
Line 7756:
Line 7757: ##
Line 7758: # @MigrateChangeParamsParams:
feels to java-ish :)
What about just
"MigrationParameters"
?
Line 7759: #
Line 7760: # Parameters for @VM.migrateChangeParams
Line 7761: #
Line 7762: # @maxBandwidth:#optional the new bandwidth
https://gerrit.ovirt.org/#/c/46934/7/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 408: self._raiseAbortError()
Line 409:
Line 410: def set_max_bandwidth(self, bandwidth):
Line 411: self._vm.log.debug('setting migration max bandwidth to %d',
bandwidth)
Line 412: self._maxBandwidth = bandwidth
> It is set by the constructor and than used in _perform_migration.
OK, seems that killing it is more trouble than keeping it, so let's keep it.
Line 413: self._vm._dom.migrateSetMaxSpeed(bandwidth)
Line 414:
Line 415: def stop(self):
Line 416: # if its locks we are before the migrateToURI3()
--
To view, visit https://gerrit.ovirt.org/46934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52219c0e1f7d619dd30441dd4c70bd401f91e56d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add support for max migration bandwidth setting
Francesco Romani has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 8: Code-Review-1
(3 comments)
two minor nits in the schema, should be trivial to fix. Otherwise seems fine.
-1 for visibility.
https://gerrit.ovirt.org/#/c/46846/8/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 7708: # @compressed: #optional Compress repeated pages during live
migration.
Line 7709: # (new in version 4.17.0)
Line 7710: #
Line 7711: # @autoConverge:#optional Force convergence during live
migration.
Line 7712: # (new in version 4.17.0)
please add a newline here
Line 7713: # @maxBandwidth:#optional maximal bandwidth used by the
migration (MiB/s)
Line 7714: # ((new in version 4.18.0)
Line 7715: #
Line 7716: # Since: 4.10.0
Line 7710: #
Line 7711: # @autoConverge:#optional Force convergence during live
migration.
Line 7712: # (new in version 4.17.0)
Line 7713: # @maxBandwidth:#optional maximal bandwidth used by the
migration (MiB/s)
Line 7714: # ((new in version 4.18.0)
spurious extra (
Line 7715: #
Line 7716: # Since: 4.10.0
Line 7717: ##
Line 7718: {'type': 'MigrateParams',
https://gerrit.ovirt.org/#/c/46846/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 94: self._downtime = kwargs.get('downtime') or \
Line 95: config.get('vars', 'migration_downtime')
Line 96: self._maxBandwidth = int(
Line 97: kwargs.get('maxBandwidth') or
Line 98: config.getint('vars', 'migration_max_bandwidth')
note to self: for a (far) future patch:
let's move all the migration* tunables on a separate section.
Line 99: )
Line 100: self._autoConverge = autoConverge
Line 101: self._compressed = compressed
Line 102: self.status = {
--
To view, visit https://gerrit.ovirt.org/46846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d99e488a9e8bb80b0c3c069628171c666f3bf4b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Francesco Romani has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 1: Code-Review+1 looks fine, but we need a BZ for patches for stable branches. -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Collect stats from online cpu cores only
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9: Code-Review-1
(1 comment)
unfortunately has to be -1. I'm actually fine with all of this patch except one
implementation detail.
I'm fully aware that EAFP vs LBYL is mostly matter of taste (and that the first
is actually more pythonic), nevertheless the stats subsystem is heavily LBYL,
and I'd like to keep it that way, OR to change all of it at once.
For the near/mid term we chosse the LBYL way, hence the score and the
requirement.
https://gerrit.ovirt.org/#/c/46269/9/vdsm/virt/hoststats.py
File vdsm/virt/hoststats.py:
Line 103: last_sample.cpuCores.getCoreSample(cpu_core)[mode] -
Line 104: first_sample.cpuCores.getCoreSample(cpu_core)[mode]
Line 105: ) % JIFFIES_BOUND
Line 106: return ("%.2f" % (jiffies / interval))
Line 107: except TypeError:
this is the only thing that bothers me in this patch. We spent some time
removing except TypError and except AttributeError, and I'd like to avoid to
reintroduce them so early, and without a very good reason to do so.
I believe that here we can make the code a little less dense and increase a bit
in clarity, adding a few ifs to guard for None.
Line 108: return None
Line 109:
Line 110: cpu_core_stats = {}
Line 111: for node_index, numa_node in
six.iteritems(caps.getNumaTopology()):
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Roman Mohr
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: scheduler: use single instance
Francesco Romani has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 1: Code-Review+1 looks fine, but we need a BZ for patches for stable branches. -- To view, visit https://gerrit.ovirt.org/48287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
Adam Litke has posted comments on this change. Change subject: tests: FakeLVM add lvPath test .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/47863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM test command failure
Nir Soffer has posted comments on this change. Change subject: tests: FakeLVM test command failure .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/47864/8/tests/storagefakelib.py File tests/storagefakelib.py: Line 115: opened=False, Line 116: active=bool(activate)) Line 117: Line 118: try: Line 119: lv_count = int(self.vgmd[vgName]['lv_count']) + 1 Seems that you missed my comment about missing 'lv_count', would be hidden as missing vg. Should separate getting the vg from modifying it. Line 120: except KeyError: Line 121: raise se.CannotCreateLogicalVolume(vgName, lvName) Line 122: Line 123: if (vgName, lvName) in self.lvmd: -- To view, visit https://gerrit.ovirt.org/47864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM test command failure
Nir Soffer has posted comments on this change. Change subject: tests: FakeLVM test command failure .. Patch Set 8: Jenkins complains about this: 00:04:33.872 ./tests/storagefakelibTests.py:290:1: W391 blank line at end of file -- To view, visit https://gerrit.ovirt.org/47864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: FakeLVM: Simplify storage of lv metadata
Nir Soffer has posted comments on this change. Change subject: FakeLVM: Simplify storage of lv metadata .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6c0c9af11ecdc88d294848cf244d0d639ec65d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/47863/7/tests/storagefakelib.py
File tests/storagefakelib.py:
Line 34:
Line 35: def __init__(self, root):
Line 36: self.root = root
Line 37: os.mkdir(os.path.join(self.root, 'dev'))
Line 38:
Unintended I guess?
Line 39: self.pvmd = {}
Line 40: self.vgmd = {}
Line 41: self.lvmd = {}
Line 42:
--
To view, visit https://gerrit.ovirt.org/47863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM test command failure
automat...@ovirt.org has posted comments on this change. Change subject: tests: FakeLVM test command failure .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
automat...@ovirt.org has posted comments on this change. Change subject: tests: FakeLVM add lvPath test .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: FakeLVM: Simplify storage of lv metadata
automat...@ovirt.org has posted comments on this change. Change subject: FakeLVM: Simplify storage of lv metadata .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6c0c9af11ecdc88d294848cf244d0d639ec65d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: FakeLVM: Simplify storage of lv metadata
Nir Soffer has posted comments on this change. Change subject: FakeLVM: Simplify storage of lv metadata .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48215/2/tests/storagefakelib.py File tests/storagefakelib.py: Line 147: Line 148: def getLV(self, vgName, lvName=None): Line 149: if lvName is None: Line 150: return [self._getLV(vgName, lv) Line 151: for (vg, lv) in self.lvmd.keys() if vg == vgName] Should be: for vg, lv, in self.lvmd if vg == vgName Line 152: else: Line 153: return self._getLV(vgName, lvName) Line 154: Line 155: def fake_lv_symlink_create(self, vg_name, lv_name): -- To view, visit https://gerrit.ovirt.org/48215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6c0c9af11ecdc88d294848cf244d0d639ec65d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
automat...@ovirt.org has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 1: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#1279555::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
automat...@ovirt.org has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 1: * #1279555::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/48316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3739585879f09ec8a3502a783efec96c0ffb7bb9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
Fabian Deutsch has abandoned this change. Change subject: vdsm.conf: Add drop-in dir .. Abandoned -- To view, visit https://gerrit.ovirt.org/48316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3739585879f09ec8a3502a783efec96c0ffb7bb9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
automat...@ovirt.org has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 1: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#1279555::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3739585879f09ec8a3502a783efec96c0ffb7bb9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
Fabian Deutsch has uploaded a new change for review.
Change subject: vdsm.conf: Add drop-in dir
..
vdsm.conf: Add drop-in dir
A drop-in dir allows the user to put partial configurations
into a drop-in directory for the vdsm configuration.
Change-Id: I3739585879f09ec8a3502a783efec96c0ffb7bb9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279555
Signed-off-by: Fabian Deutsch
---
M lib/vdsm/config.py.in
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/48316/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 83dcdb4..9f9a307 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -22,6 +22,7 @@
import os
import textwrap
import ConfigParser
+from glob import glob
parameters = [
# Section: [vars]
@@ -455,5 +456,9 @@
set_defaults(config)
config.read([os.path.join('@CONFDIR@', 'vdsm.conf')])
+dropindir = [os.path.join('@CONFDIR@', 'vdsm.conf.d')])
+if os.path.exists(dropindir):
+config.read(sorted(glob(dropindir + "/*.conf")))
+
if __name__ == '__main__':
print_config()
--
To view, visit https://gerrit.ovirt.org/48316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3739585879f09ec8a3502a783efec96c0ffb7bb9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Adam Litke has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: Code-Review+2 Talked with Nir and I now understand the scenario completely. OK. -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Nir Soffer has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48217/1//COMMIT_MSG Commit Message: Line 8: Line 9: When attaching hosted engine storage domain, sanlock is already Line 10: maintaining a lockspace on the domain, and releasing the host id would Line 11: cause sanlock to kill the hosted engine vm. Line 12: > Does Sanlock kill the hosted engine VM or does it kill vdsm on the host? I According to Roy, sanlock is killing the qemu process running the hosted engine vm. It seems that hosted engine vm and vdsm are sharing the same lockspace (where host ids are registered). Vdsm may keep a resource in for the domain lock, and hosted engine is keeping a resource for the engine vm. When you release the host id, sanlock is releasing the reosurces associated with the same lockspace, and the vm is killed. I'm not sure if vdsm did create the host id used by hosted engine - if this is the case, than using reference counting on the cluster lock would solve this issue as well. Line 13: Now we acquire and release the host id during attach only if needed, Line 14: keeping hosted engine vm alive. Line 15: Line 16: Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: Allow attaching hosted engine sd
Adam Litke has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48217/1//COMMIT_MSG Commit Message: Line 8: Line 9: When attaching hosted engine storage domain, sanlock is already Line 10: maintaining a lockspace on the domain, and releasing the host id would Line 11: cause sanlock to kill the hosted engine vm. Line 12: Does Sanlock kill the hosted engine VM or does it kill vdsm on the host? I just want to make sure I'm clear on what is happening here. If Sanlock kills the VM (qemu process) how is this set up? Line 13: Now we acquire and release the host id during attach only if needed, Line 14: keeping hosted engine vm alive. Line 15: Line 16: Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v
Nir Soffer has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 8: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/47738/8/tests/Makefile.am
File tests/Makefile.am:
Line 197: dist_vdsmtests_PYTHON = \
Line 198: $(test_modules) \
Line 199: apiData.py \
Line 200: hookValidation.py \
Line 201: fake-virt-v2v.py \
This is really a script, not a python module, so we can drop the .py suffix
(fake-virt-v2v).
Line 202: monkeypatch.py \
Line 203: nettestlib.py \
Line 204: storagefakelib.py \
Line 205: storagetestlib.py \
https://gerrit.ovirt.org/#/c/47738/8/tests/v2vTests.py
File tests/v2vTests.py:
Line 308: '----0002'},
Line 309: {'imageID':
Line 310: '----0003',
Line 311: 'volumeID':
Line 312: '----0004'}]}
Should be class or module constant, used in two tests.
Line 313: url =
'vpx://adminr%40vsphere@0.0.0.0/ovirt/0.0.0.0?no_verify=1'
Line 314: ivm = v2v.ImportVm.from_libvirt(url, 'root', 'mypassword',
vminfo,
Line 315: _JOB_ID, FakeIRS())
Line 316: ivm._import()
Line 309: {'imageID':
Line 310: '----0003',
Line 311: 'volumeID':
Line 312: '----0004'}]}
Line 313: url =
'vpx://adminr%40vsphere@0.0.0.0/ovirt/0.0.0.0?no_verify=1'
Should be class or module constant, used in two tests.
Line 314: ivm = v2v.ImportVm.from_libvirt(url, 'root', 'mypassword',
vminfo,
Line 315: _JOB_ID, FakeIRS())
Line 316: ivm._import()
Line 317:
Line 311: 'volumeID':
Line 312: '----0004'}]}
Line 313: url =
'vpx://adminr%40vsphere@0.0.0.0/ovirt/0.0.0.0?no_verify=1'
Line 314: ivm = v2v.ImportVm.from_libvirt(url, 'root', 'mypassword',
vminfo,
Line 315: _JOB_ID, FakeIRS())
This can be in a test setUp() method, same instance is used in two tests.
Line 316: ivm._import()
Line 317:
Line 318: @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
Line 319: def testV2VOutput(self):
Line 312: '----0004'}]}
Line 313: url =
'vpx://adminr%40vsphere@0.0.0.0/ovirt/0.0.0.0?no_verify=1'
Line 314: ivm = v2v.ImportVm.from_libvirt(url, 'root', 'mypassword',
vminfo,
Line 315: _JOB_ID, FakeIRS())
Line 316: ivm._import()
Please verify the job status after import finished.
Line 317:
Line 318: @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
Line 319: def testV2VOutput(self):
Line 320: '''
Line 337: '----0004'}]}
Line 338: url =
'vpx://adminr%40vsphere@0.0.0.0/ovirt/0.0.0.0?no_verify=1'
Line 339: ivm = v2v.ImportVm.from_libvirt(url, 'root', 'mypassword',
vminfo,
Line 340: _JOB_ID, FakeIRS())
Line 341: ivm._import()
Why do we need to run _import() here?
I think we should avoid all this setup and use a hardcoded command line for
fake-virt-v2v.
This test is for fake-virt-v2v, not for ImportVm class, but it may fail because
of changes in ImportVm.
Line 342:
Line 343: rc, output, error = execCmd(ivm._from_libvirt_command(),
raw=True)
Line 344: self.assertEqual(rc, 0)
Line 345:
--
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM test command failure
Nir Soffer has posted comments on this change. Change subject: tests: FakeLVM test command failure .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/47864/7/tests/storagefakelib.py File tests/storagefakelib.py: Line 118: opened=False, Line 119: active=bool(activate)) Line 120: Line 121: try: Line 122: lv_count = int(self.vgmd[vgName]['lv_count']) + 1 This still hides missing 'lv_count' key, will raise se.CannotCreateLogicalVolume, as if the vg does not exists. Please separate modification and access. This line is doing too much. Line 123: except KeyError: Line 124: raise se.CannotCreateLogicalVolume(vgName, lvName) Line 125: Line 126: if (vgName, lvName) in self.lvmd: -- To view, visit https://gerrit.ovirt.org/47864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47863/6/tests/storagefakelib.py
File tests/storagefakelib.py:
Line 35: def __init__(self, root=None):
Line 36: if root:
Line 37: os.mkdir(os.path.join(root, 'dev'))
Line 38: else:
Line 39: root = '/'
This may cause tests running as root to dirty the real host. I don't think we
need a default, using None will just cause lvm.root related operations to fail.
If we must have a root directory, we should create the directory in __enter__
and delete it in __exit__, so you can do this:
with FakeLVM() as lvm:
...
Test code that need access to lvm tempoary diretory can access lvm.root.
Line 40: self.root = root
Line 41:
Line 42: self.pvmd = {}
Line 43: self.vgmd = {}
--
To view, visit https://gerrit.ovirt.org/47863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 336
Line 337
Line 338
Line 339
Line 340
We know that this is the first server, so we should remove using pop(0), or use
a slice: servers[1:]
And of course we don't have any test for this change - we should start with a
failing test.
Line 335: if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 336: raise
se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 337:
Line 338: def _get_backup_servers_option(self):
Line 339: self._volfileserver = self.volinfo['bricks'][0].split(":")[0]
This is messy. You start with value A, then you switch to value B.
Please change the name of the instance variable to reflect the fact that this
is the server we connect to get the gluster volume info, but the gluster
volfileserver may be another server.
Also you are spliting the bricks list twice, duplicating the code bellow.
Line 340: servers = [brick.split(":")[0] for brick in
self.volinfo['bricks']]
Line 341: servers.remove(self._volfileserver)
Line 342: if not servers:
Line 343: return ""
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM test command failure
Adam Litke has posted comments on this change. Change subject: tests: FakeLVM test command failure .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/47864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
Adam Litke has posted comments on this change. Change subject: tests: FakeLVM add lvPath test .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/47863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: FakeLVM: Simplify storage of lv metadata
automat...@ovirt.org has posted comments on this change. Change subject: FakeLVM: Simplify storage of lv metadata .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6c0c9af11ecdc88d294848cf244d0d639ec65d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
Adam Litke has posted comments on this change. Change subject: tests: FakeLVM add lvPath test .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47863/5/tests/storagefakelibTests.py File tests/storagefakelibTests.py: Line 264: class FakeLVMGeneralTests(VdsmTestCase): Line 265: Line 266: def test_lvpath(self): Line 267: with namedTemporaryDir() as tmpdir: Line 268: lvm = FakeLVM(tmpdir) > Are we going to avoid the temporary directory here? ah right. I can move that snippet here. Line 269: vg_name = 'foo' Line 270: lv_name = 'bar' Line 271: expected = os.path.join(tmpdir, 'dev', vg_name, lv_name) -- To view, visit https://gerrit.ovirt.org/47863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM test command failure
automat...@ovirt.org has posted comments on this change. Change subject: tests: FakeLVM test command failure .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: FakeLVM add lvPath test
automat...@ovirt.org has posted comments on this change. Change subject: tests: FakeLVM add lvPath test .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46be518e68069412199dfb7ee44c7b7a8a207236 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Set mount path based on gluster volume info .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Set mount path based on gluster volume info
Ala Hino has uploaded a new change for review.
Change subject: gluster: Set mount path based on gluster volume info
..
gluster: Set mount path based on gluster volume info
There are cases where gluter server and ovirt are configured
differently regarding ip addresses and domain names. To avoid
any issues that could happen due to this misconfiguration, we
have to use info retuned from gluster volume info to set the
mount path as well as the backup-volfile-servers.
Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Signed-off-by: Ala Hino
---
M vdsm/storage/storageServer.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/48308/1
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 6636bd8..a6fe39b 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -336,6 +336,7 @@
raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
def _get_backup_servers_option(self):
+self._volfileserver = self.volinfo['bricks'][0].split(":")[0]
servers = [brick.split(":")[0] for brick in self.volinfo['bricks']]
servers.remove(self._volfileserver)
if not servers:
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: utils: replace import for persist/unpersist
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: replace import for persist/unpersist .. Patch Set 1: jenkins url not found, not related to the patch. -- To view, visit https://gerrit.ovirt.org/47968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: daemon: enable cpu affinity by default
Francesco Romani has uploaded a new change for review.
Change subject: daemon: enable cpu affinity by default
..
daemon: enable cpu affinity by default
To run VDSM with CPU affinity enabled provided only
(huge) benefits in the tests performed so far, so let's
enable it by default.
Change-Id: I9a00926926bb4075e17b69f633bf31b5389eefc1
Bug-Url: https://bugzilla.redhat.com/1279431
Backport-To: 3.6
Signed-off-by: Francesco Romani
---
M lib/vdsm/config.py.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/48296/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 203d292..6775ba8 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -211,10 +211,10 @@
('connection_stats_timeout', '3600',
'Time in seconds defining how frequently we log transport stats'),
-('cpu_affinity', '',
+('cpu_affinity', '1',
'Comma separated whitelist of CPU cores on which VDSM is allowed '
-'to run. The default is "", meaning VDSM can be scheduled by '
-' the OS to run on any core. '
+'to run. The default is "1", meaning VDSM can be scheduled by '
+' the OS to run on the second core of the system. '
'Valid examples: "1", "0,1", "0,2,3"'),
('ssl_implementation', '@SSL_IMPLEMENTATION@',
--
To view, visit https://gerrit.ovirt.org/48296
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a00926926bb4075e17b69f633bf31b5389eefc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: daemon: enable cpu affinity by default
automat...@ovirt.org has posted comments on this change. Change subject: daemon: enable cpu affinity by default .. Patch Set 1: * #1279431::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279431::OK, public bug * Check Product::#1279431::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a00926926bb4075e17b69f633bf31b5389eefc1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 1: Verified+1 Verified on master -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: scheduler: use single instance
Piotr Kliczewski has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 1: Verified+1 Verified on master. -- To view, visit https://gerrit.ovirt.org/48287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: executor based thread factory
..
jsonrpc: executor based thread factory
Creating new thread for every request is not efficient so we introduce
usage of the executor for request processing.
Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970
Signed-off-by: pkliczewski
Reviewed-on: https://gerrit.ovirt.org/43759
---
M lib/vdsm/config.py.in
M tests/integration/jsonRpcHelper.py
M tests/integration/jsonRpcTests.py
M vdsm/clientIF.py
M vdsm/rpc/bindingjsonrpc.py
M vdsm/vdsm
6 files changed, 70 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/48293/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 9ed11ff..3c53e5f 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -219,6 +219,18 @@
'There are 2 options: '
'"m2c" to use the m2crypto module '
'"ssl" to use the standard python ssl module'),
+
+]),
+
+# Section: [rpc]
+('rpc', [
+
+('worker_threads', '8',
+'Number of worker threads to serve jsonrpc server.'),
+
+('tasks_per_worker', '10',
+'Max number of tasks which can be queued per workers.'),
+
]),
# Section: [mom]
diff --git a/tests/integration/jsonRpcHelper.py
b/tests/integration/jsonRpcHelper.py
index 3abbfbc..b88189c 100644
--- a/tests/integration/jsonRpcHelper.py
+++ b/tests/integration/jsonRpcHelper.py
@@ -37,6 +37,7 @@
from protocoldetector import MultiProtocolAcceptor
from rpc.bindingjsonrpc import BindingJsonRpc
from vdsm.config import config
+from vdsm import schedule
from vdsm import utils
if config.get('vars', 'ssl_implementation') == 'm2c':
@@ -92,7 +93,11 @@
0,
sslctx,
)
-json_binding = BindingJsonRpc(jsonBridge, defaultdict(list), 60)
+
+scheduler = schedule.Scheduler(name="test.Scheduler",
+ clock=utils.monotonic_time)
+scheduler.start()
+json_binding = BindingJsonRpc(jsonBridge, defaultdict(list), 60, scheduler)
json_binding.start()
cif = FakeClientIf(json_binding, dest)
@@ -118,6 +123,7 @@
acceptor.stop()
json_binding.stop()
xml_binding.stop()
+scheduler.stop(wait=False)
@contextmanager
diff --git a/tests/integration/jsonRpcTests.py
b/tests/integration/jsonRpcTests.py
index b7fd97d..16e7607 100644
--- a/tests/integration/jsonRpcTests.py
+++ b/tests/integration/jsonRpcTests.py
@@ -23,6 +23,7 @@
from contextlib import contextmanager
from monkeypatch import MonkeyPatch
from testValidation import slowtest
+from vdsm import executor
from testlib import VdsmTestCase as TestCaseBase, \
expandPermutations, \
@@ -78,6 +79,10 @@
def getInstance():
return FakeClientIf()
+
+
+def dispatch(callable, timeout=None):
+raise executor.TooManyTasks
@expandPermutations
@@ -222,3 +227,20 @@
self.assertEquals(cm.exception.code,
JsonRpcNoResponseError().code)
+
+@MonkeyPatch(clientIF, 'getInstance', getInstance)
+@MonkeyPatch(executor.Executor, 'dispatch', dispatch)
+@permutations(PERMUTATIONS)
+def testFullExecutor(self, ssl, type):
+bridge = _DummyBridge()
+with constructClient(self.log, bridge, ssl, type) as clientFactory:
+with self._client(clientFactory) as client:
+if type == "xml":
+# TODO start using executor for xmlrpc
+pass
+else:
+with self.assertRaises(JsonRpcError) as cm:
+self._callTimeout(client, "no_method", [], CALL_ID)
+
+self.assertEquals(cm.exception.code,
+ JsonRpcInternalError().code)
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index a7a0c66..918ca8b 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -71,7 +71,7 @@
_instance = None
_instanceLock = threading.Lock()
-def __init__(self, irs, log):
+def __init__(self, irs, log, scheduler):
"""
Initialize the (single) clientIF instance
@@ -95,6 +95,7 @@
self.bindings = {}
self._broker_client = None
self._subscriptions = defaultdict(list)
+self._scheduler = scheduler
if _glusterEnabled:
self.gluster = gapi.GlusterApi(self, log)
else:
@@ -182,14 +183,14 @@
vmObj.cont()
@classmethod
-def getInstance(cls, irs=None, log=None):
+def getInstance(cls, irs=None, log=None, scheduler=None):
with cls._instanceLock:
if cls._instance is None:
if log is None:
raise Exception("Logging facility is required to create "
"the single clientIF instance")
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: drop gcc dependency
Piotr Kliczewski has posted comments on this change. Change subject: janitorial: drop gcc dependency .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3014578fe5b7833a1ee6dda6e774976d9968278c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: scheduler: use single instance
automat...@ovirt.org has posted comments on this change. Change subject: scheduler: use single instance .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: scheduler: use single instance
Piotr Kliczewski has uploaded a new change for review.
Change subject: scheduler: use single instance
..
scheduler: use single instance
We used to have one instance of a scheduler used for periodic
operations. With this patch we prepare code for using single scheduler
in more places like jsonrpc server.
Change-Id: If83eded458f8304d802fcd75839e7a916146918b
Signed-off-by: pkliczewski
Reviewed-on: https://gerrit.ovirt.org/43825
---
M vdsm/vdsm
M vdsm/virt/periodic.py
2 files changed, 19 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/48287/1
diff --git a/vdsm/vdsm b/vdsm/vdsm
index a793622..5f7b39e 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -32,6 +32,7 @@
import warnings
from vdsm import constants
+from vdsm import schedule
from vdsm import utils
from vdsm.config import config
from vdsm import libvirtconnection
@@ -63,6 +64,7 @@
def serve_clients(log):
cif = None
irs = None
+scheduler = None
running = [True]
def sigtermHandler(signum, frame):
@@ -96,8 +98,11 @@
install_manhole({'irs': irs, 'cif': cif})
+scheduler = schedule.Scheduler(name="vdsm.Scheduler",
+ clock=utils.monotonic_time)
+scheduler.start()
cif.start()
-periodic.start(cif)
+periodic.start(cif, scheduler)
try:
while running[0]:
sigutils.wait_for_signal()
@@ -106,6 +111,7 @@
finally:
periodic.stop()
cif.prepareForShutdown()
+scheduler.stop()
finally:
libvirtconnection.stop_event_loop(wait=False)
diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py
index 632674f..b0190fb 100644
--- a/vdsm/virt/periodic.py
+++ b/vdsm/virt/periodic.py
@@ -27,9 +27,7 @@
from vdsm import executor
from vdsm import libvirtconnection
-from vdsm import schedule
from vdsm.config import config
-from vdsm.utils import monotonic_time
from . import sampling
@@ -41,14 +39,8 @@
_TASKS = _WORKERS * _TASK_PER_WORKER
-_scheduler = schedule.Scheduler(name="periodic-sched",
-clock=monotonic_time)
-
-_executor = executor.Executor(name="periodic",
- workers_count=_WORKERS,
- max_tasks=_TASKS,
- scheduler=_scheduler)
_operations = []
+_executor = None
def _timeout_from(interval):
@@ -58,16 +50,20 @@
return interval / 2.
-def start(cif):
+def start(cif, scheduler):
global _operations
+global _executor
-_scheduler.start()
+_executor = executor.Executor(name="periodic",
+ workers_count=_WORKERS,
+ max_tasks=_TASKS,
+ scheduler=scheduler)
_executor.start()
def per_vm_operation(func, period):
disp = VmDispatcher(
cif.getVMs, _executor, func, _timeout_from(period))
-return Operation(disp, period)
+return Operation(disp, period, scheduler)
_operations = [
# needs dispatching becuse updating the volume stats needs the
@@ -94,7 +90,8 @@
libvirtconnection.get(cif),
cif.getVMs,
sampling.stats_cache),
-config.getint('vars', 'vm_sample_interval')),
+config.getint('vars', 'vm_sample_interval'),
+scheduler),
# we do this only until we get high water mark notifications
# from qemu. Access storage and/or qemu monitor, so can block,
@@ -114,7 +111,6 @@
op.stop()
_executor.stop(wait=False)
-_scheduler.stop(wait=False)
class Operation(object):
@@ -128,8 +124,7 @@
_log = logging.getLogger("virt.periodic.Operation")
-def __init__(self, func, period, timeout=0,
- scheduler=None, executor=None):
+def __init__(self, func, period, scheduler, timeout=0, executor=None):
"""
parameters:
@@ -144,7 +139,7 @@
self._func = func
self._period = period
self._timeout = _timeout_from(period) if timeout == 0 else timeout
-self._scheduler = _scheduler if scheduler is None else scheduler
+self._scheduler = scheduler
self._executor = _executor if executor is None else executor
self._lock = threading.Lock()
self._running = False
--
To view, visit https://gerrit.ovirt.org/48287
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: remove unused parameter
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: remove unused parameter .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix getVdsCaps and getVdsStats
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: fix getVdsCaps and getVdsStats .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc8298a737fccea626b4419bd7d462cc830afc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: better rollback
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: use six.iteritems and six.itervalues
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: use six.iteritems and six.itervalues .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d098a3142f61e927e047058424d2bd6f6955145 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: add script name to log
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: add script name to log .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e40406fb2dfce6099a2c288b5d3c37ceec839d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding python3 run for nosetests
Yaniv Bronhaim has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 8: (4 comments) sandro - can you help with the missing packages over el7? 08:56:59 Error: No Package found for python3-nose 08:56:59 Error: No Package found for python3-six what do I miss? https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: import os Line 23: from six.moves import configparser as ConfigParser > Don't keep the old ugly name, do: starting with the minimal change first Line 24: import textwrap Line 25: Line 26: parameters = [ Line 27: # Section: [vars] https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 32: from fnmatch import fnmatch Line 33: try: Line 34: from StringIO import StringIO Line 35: except ImportError: Line 36: from io import StringIO > Can't we always use io.StringIO? no, it doesn't include len attr for example Line 37: from weakref import proxy Line 38: from .compat import pickle Line 39: import distutils.spawn Line 40: import errno Line 633: """ Line 634: Line 635: # Moving import here so that import utils over python3 will work. Once Line 636: # python3-cpopen will be available this import should return to top Line 637: from cpopen import CPopen > Better move cpopen to compat, so we can do this everywhere: keep it minimal for now - but I'll use the compat trick in following patch about the umask we opened https://bugzilla.redhat.com/show_bug.cgi?id=1278414 for followup Line 638: Line 639: command = cmdutils.wrap_command(command, with_ioclass=ioclass, Line 640: ioclassdata=ioclassdata, with_nice=nice, Line 641: with_setsid=setsid, with_sudo=sudo, https://gerrit.ovirt.org/#/c/48051/8/vdsm.spec.in File vdsm.spec.in: Line 93 Line 94 Line 95 Line 96 Line 97 > Lets seprate python3 group with an empty line and a comment. yes? why? -- To view, visit https://gerrit.ovirt.org/48051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: executor based thread factory .. jsonrpc: executor based thread factory Creating new thread for every request is not efficient so we introduce usage of the executor for request processing. Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/43759 Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI --- M lib/vdsm/config.py.in M tests/integration/jsonRpcHelper.py M tests/integration/jsonRpcTests.py M vdsm/clientIF.py M vdsm/rpc/bindingjsonrpc.py M vdsm/vdsm 6 files changed, 70 insertions(+), 16 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: executor based thread factory
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added fc23 repos to the automation scripts
Sandro Bonazzola has posted comments on this change. Change subject: Added fc23 repos to the automation scripts .. Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/48180/3/automation/build-artifacts.repos.fc23 File automation/build-artifacts.repos.fc23: Line 1: # TODO: change once there are fc23 repos available fc23 repos are now available Line 2: ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc22 https://gerrit.ovirt.org/#/c/48180/3/automation/check-patch.packages.fc23 File automation/check-patch.packages.fc23: Line 1: autoconf Line 2: automake Line 3: gcc > I bet we no longer need gcc. it should be dropped from the spec and from he I guess you'll need it for configure if you're using gettext unless you fixed configure.ac for not requiring it Line 4: git Line 5: libguestfs-tools-c Line 6: m2crypto Line 7: make https://gerrit.ovirt.org/#/c/48180/3/automation/check-patch.repos.fc23 File automation/check-patch.repos.fc23: Line 1: # TODO: change once there are fc23 repos available fc23 repo is now available Line 2: ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc22 Line 3: ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/fc22 -- To view, visit https://gerrit.ovirt.org/48180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie64c291a55c8e5790effac48ae33c12b822a1259 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration added migrateChangeParams verb
Tomas Jelinek has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46934/7/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 408: self._raiseAbortError()
Line 409:
Line 410: def set_max_bandwidth(self, bandwidth):
Line 411: self._vm.log.debug('setting migration max bandwidth to %d',
bandwidth)
Line 412: self._maxBandwidth = bandwidth
> ok, this was introduced by parent patch. Still, is it of any use once the m
It is set by the constructor and than used in _perform_migration.
Technically, here this line could be avoided, but we would end up in a
situation that the self._maxBandwidth would be different than the actual
maxSpeed on the VM. Currently it would not mean any issues, but it would be
disproportional (e.g. if you set the bandwidth in initialization it sets it to
self but if you update it using set_max_bandwidth than not). It could cause
confusion later when someone expects that this field is correct...
Line 413: self._vm._dom.migrateSetMaxSpeed(bandwidth)
Line 414:
Line 415: def stop(self):
Line 416: # if its locks we are before the migrateToURI3()
--
To view, visit https://gerrit.ovirt.org/46934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52219c0e1f7d619dd30441dd4c70bd401f91e56d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v
Shahar Havivi has posted comments on this change. Change subject: v2v: add fake virt-v2v process for testing without virt-v2v .. Patch Set 7: patch fix CI error regarding fake-virt-v2v.output, rename fake-virt-v2v.output to fake-virt-v2v.out to match other resources pattern. -- To view, visit https://gerrit.ovirt.org/47738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v
automat...@ovirt.org has posted comments on this change. Change subject: v2v: add fake virt-v2v process for testing without virt-v2v .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: after_network_setup_fail
Dan Kenigsberg has posted comments on this change. Change subject: hooks: after_network_setup_fail .. Patch Set 21: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add support for max migration bandwidth setting
Martin Betak has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d99e488a9e8bb80b0c3c069628171c666f3bf4b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: David Caro Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: fix getVdsCaps and getVdsStats
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs: fix getVdsCaps and getVdsStats .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc8298a737fccea626b4419bd7d462cc830afc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: David Caro Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: grub2 module
automat...@ovirt.org has posted comments on this change. Change subject: lib: grub2 module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e7e0b327882f64196a71fe20dcbd99017b80800 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests
automat...@ovirt.org has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
