Change in vdsm[master]: vmstats: remove _diff helper
gerrit-hooks has posted comments on this change. Change subject: vmstats: remove _diff helper .. Patch Set 7: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0621d99b4d6a63ad68ed7374f4614b98a080a4e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: from EAFP to LBYL
gerrit-hooks has posted comments on this change. Change subject: vmstats: from EAFP to LBYL .. Patch Set 7: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 11: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for vmstats.cpu()
Francesco Romani has posted comments on this change. Change subject: tests: add tests for vmstats.cpu() .. Patch Set 4: Verified+1 copied score -- To view, visit https://gerrit.ovirt.org/53777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for vmstats.cpu()
gerrit-hooks has posted comments on this change. Change subject: tests: add tests for vmstats.cpu() .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: disable on migration destination
gerrit-hooks has posted comments on this change. Change subject: virt: periodic: disable on migration destination .. Patch Set 8: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: from EAFP to LBYL
Francesco Romani has posted comments on this change. Change subject: vmstats: from EAFP to LBYL .. Patch Set 7: Verified+1 changes since last verification are trivial (either docs or test code helpers). Copied score. -- To view, visit https://gerrit.ovirt.org/53613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: disable on migration destination
Francesco Romani has posted comments on this change. Change subject: virt: periodic: disable on migration destination .. Patch Set 8: verification: migrating VMs back and forth. Pending: hibernation. Early results shows no regressions. Still working on. -- To view, visit https://gerrit.ovirt.org/53539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move blkid to lib
gerrit-hooks has posted comments on this change. Change subject: move blkid to lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move blkid to lib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: move blkid to lib
..
move blkid to lib
Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017
Signed-off-by: Yaniv Bronhaim
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/Makefile.am
R lib/vdsm/blkid.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/clientIF.py
7 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/53872/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 35ee322..3bf64e1 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -2,6 +2,7 @@
./usr/bin/vdsm-tool
./usr/lib/python2.7/dist-packages/vdsm/__init__.py
./usr/lib/python2.7/dist-packages/vdsm/alignmentScan.py
+./usr/lib/python2.7/dist-packages/vdsm/blkid.py
./usr/lib/python2.7/dist-packages/vdsm/cmdutils.py
./usr/lib/python2.7/dist-packages/vdsm/compat.py
./usr/lib/python2.7/dist-packages/vdsm/concurrent.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 7ebf3da..9e9482f 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -34,7 +34,6 @@
./usr/libexec/vdsm/wait_for_ipv4s
./usr/share/man/man8/vdsmd.8
./usr/share/vdsm/API.py
-./usr/share/vdsm/blkid.py
./usr/share/vdsm/caps.py
./usr/share/vdsm/clientIF.py
./usr/share/vdsm/daemonAdapter
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 74f89de..effd523 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -24,6 +24,7 @@
dist_vdsmpylib_PYTHON = \
__init__.py \
alignmentScan.py \
+ blkid.py \
cmdutils.py \
compat.py \
commands.py \
diff --git a/vdsm/blkid.py b/lib/vdsm/blkid.py
similarity index 97%
rename from vdsm/blkid.py
rename to lib/vdsm/blkid.py
index b6f746d..3713949 100644
--- a/vdsm/blkid.py
+++ b/lib/vdsm/blkid.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
+
from vdsm import constants
from vdsm import commands
diff --git a/vdsm.spec.in b/vdsm.spec.in
index bf2b891..a5d300b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -843,7 +843,6 @@
%dir %{_datadir}/%{vdsm_name}/virt
%dir %{_datadir}/%{vdsm_name}/virt/vmdevices
%dir %{_datadir}/%{vdsm_name}/rpc
-%{_datadir}/%{vdsm_name}/blkid.py*
%{_datadir}/%{vdsm_name}/caps.py*
%{_datadir}/%{vdsm_name}/clientIF.py*
%{_datadir}/%{vdsm_name}/daemonAdapter
@@ -1082,6 +1081,7 @@
%dir %{python_sitelib}/%{vdsm_name}/tc
%{python_sitelib}/%{vdsm_name}/__init__.py*
%{python_sitelib}/%{vdsm_name}/alignmentScan.py*
+%{python_sitelib}/%{vdsm_name}/blkid.py*
%{python_sitelib}/%{vdsm_name}/cmdutils.py*
%{python_sitelib}/%{vdsm_name}/compat.py*
%{python_sitelib}/%{vdsm_name}/commands.py*
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index a61c749..9ebecf5 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -24,7 +24,6 @@
dist_vdsm_PYTHON = \
API.py \
- blkid.py \
caps.py \
clientIF.py \
hooking.py \
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 7f15eb0..e0fe2fd 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -38,12 +38,12 @@
from vdsm.sslcompat import sslutils
import libvirt
from vdsm import alignmentScan
+from vdsm import blkid
from vdsm import libvirtconnection
from vdsm import concurrent
from vdsm import utils
from vdsm import supervdsm
import caps
-import blkid
from protocoldetector import MultiProtocolAcceptor
from virt import migration
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move hostdev to lib
gerrit-hooks has posted comments on this change. Change subject: move hostdev to lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic37e635ce027496f112272a313732baf20b44997 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move hostdev to lib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: move hostdev to lib
..
move hostdev to lib
Change-Id: Ic37e635ce027496f112272a313732baf20b44997
Signed-off-by: Yaniv Bronhaim
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/Makefile.am
R lib/vdsm/hostdev.py
M tests/hostdevTests.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/Makefile.am
M vdsm/vdsm-restore-net-config
M vdsm/virt/vm.py
10 files changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/53873/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 3bf64e1..b882c4d 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -16,6 +16,7 @@
./usr/lib/python2.7/dist-packages/vdsm/executor.py
./usr/lib/python2.7/dist-packages/vdsm/health.py
./usr/lib/python2.7/dist-packages/vdsm/hooks.py
+./usr/lib/python2.7/dist-packages/vdsm/hostdev.py
./usr/lib/python2.7/dist-packages/vdsm/ipwrapper.py
./usr/lib/python2.7/dist-packages/vdsm/jsonrpcvdscli.py
./usr/lib/python2.7/dist-packages/vdsm/kernelconfig.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 9e9482f..2041fd1 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -43,7 +43,6 @@
./usr/share/vdsm/gluster/cli.py
./usr/share/vdsm/gluster/exception.py
./usr/share/vdsm/hooking.py
-./usr/share/vdsm/hostdev.py
./usr/share/vdsm/jobs.py
./usr/share/vdsm/kaxmlrpclib.py
./usr/share/vdsm/logUtils.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index effd523..4180eba 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -38,6 +38,7 @@
health.py \
hooks.py \
host.py \
+ hostdev.py \
ipwrapper.py \
jobs.py \
jsonrpcvdscli.py \
diff --git a/vdsm/hostdev.py b/lib/vdsm/hostdev.py
similarity index 99%
rename from vdsm/hostdev.py
rename to lib/vdsm/hostdev.py
index 89c5366..5ab5ba8 100644
--- a/vdsm/hostdev.py
+++ b/lib/vdsm/hostdev.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
+
import xml.etree.ElementTree as etree
diff --git a/tests/hostdevTests.py b/tests/hostdevTests.py
index 02518fe..f28a446 100644
--- a/tests/hostdevTests.py
+++ b/tests/hostdevTests.py
@@ -19,7 +19,6 @@
#
-import hostdev
import vmfakelib as fake
from virt.vmdevices import hostdevice, network, hwclass
@@ -29,6 +28,7 @@
from monkeypatch import MonkeyClass
from vdsm import hooks
+from vdsm import hostdev
from vdsm import libvirtconnection
_PCI_DEVICES = ['pci__00_1a_0', 'pci__00_1f_2', 'pci__00_02_0',
diff --git a/vdsm.spec.in b/vdsm.spec.in
index a5d300b..e56ed5e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -848,7 +848,6 @@
%{_datadir}/%{vdsm_name}/daemonAdapter
%{_datadir}/%{vdsm_name}/API.py*
%{_datadir}/%{vdsm_name}/hooking.py*
-%{_datadir}/%{vdsm_name}/hostdev.py*
%{_datadir}/%{vdsm_name}/mk_sysprep_floppy
%{_datadir}/%{vdsm_name}/parted_utils.py*
%{_datadir}/%{vdsm_name}/mkimage.py*
@@ -1098,6 +1097,7 @@
%{python_sitelib}/%{vdsm_name}/health.py*
%{python_sitelib}/%{vdsm_name}/hooks.py*
%{python_sitelib}/%{vdsm_name}/host.py*
+%{python_sitelib}/%{vdsm_name}/hostdev.py*
%{python_sitelib}/%{vdsm_name}/ipwrapper.py*
%{python_sitelib}/%{vdsm_name}/jobs.py*
%{python_sitelib}/%{vdsm_name}/jsonrpcvdscli.py*
diff --git a/vdsm/API.py b/vdsm/API.py
index 479c00b..0155ca4 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -37,6 +37,7 @@
from vdsm import constants
from vdsm import exception
from vdsm import hooks
+from vdsm import hostdev
from vdsm import response
from vdsm import supervdsm
from vdsm import jobs
@@ -56,7 +57,6 @@
from vdsm.define import doneCode, errCode, Kbytes, Mbytes
import caps
from vdsm.config import config
-import hostdev
from caps import PAGE_SIZE_BYTES
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 9ebecf5..6249030 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -27,7 +27,6 @@
caps.py \
clientIF.py \
hooking.py \
- hostdev.py \
kaxmlrpclib.py \
logUtils.py \
mkimage.py \
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index 76e2d4b..bea37c2 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -30,6 +30,7 @@
from vdsm.config import config
from vdsm import ipwrapper
+from vdsm import hostdev
from vdsm.netinfo import nics, misc
from vdsm.netinfo.cache import CachingNetInfo
from vdsm import kernelconfig
@@ -37,7 +38,6 @@
from vdsm.netconfpersistence import RunningConfig, PersistentConfig, \
CONF_PERSIST_DIR, BaseConfig
from vdsm.utils import monotonic_time
-import hostdev
# Ifcfg persistence restoration
from vdsm.network.configurators import ifcfg
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index df58d1b..7dfaf51 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/vir
Change in vdsm[master]: tests: add tests for vmstats.cpu()
Dan Kenigsberg has posted comments on this change. Change subject: tests: add tests for vmstats.cpu() .. Patch Set 4: Code-Review+2 I managed to confuse myself ;-) -- To view, visit https://gerrit.ovirt.org/53777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for vmstats.cpu()
gerrit-hooks has posted comments on this change. Change subject: tests: add tests for vmstats.cpu() .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/53777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add tests for vmstats.cpu()
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: add tests for vmstats.cpu() .. tests: add tests for vmstats.cpu() Add tests for vmstats.cpu(). The reference data was taken either by libvirt (virsh -r domstats) or from a log-enhanced running Vdsm. Along the way, we also add the docstring for the vmstats.cpu() function. Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/53777 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/vmStatsTests.py M vdsm/virt/vmstats.py 2 files changed, 60 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/53777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d8fe466a351335922f31b7ae264d2a870a30edb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: initial support
gerrit-hooks has posted comments on this change. Change subject: containers: initial support .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e4b0552613ee160760a5a9bb4b27e0ae1f5d2f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vmfex hook: remove filter from directly-attached vnics
gerrit-hooks has posted comments on this change. Change subject: vmfex hook: remove filter from directly-attached vnics .. Patch Set 2: * #1308839::Update tracker: OK * Set MODIFIED::bug 1308839#1308839OK -- To view, visit https://gerrit.ovirt.org/53632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47f38a76b06c4d8e8dd14adb7e9c0a1eb6e3ad9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vmfex hook: remove filter from directly-attached vnics
Francesco Romani has posted comments on this change. Change subject: vmfex hook: remove filter from directly-attached vnics .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47f38a76b06c4d8e8dd14adb7e9c0a1eb6e3ad9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: Clean net & bond after functional test.
Francesco Romani has posted comments on this change. Change subject: net tests: Clean net & bond after functional test. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e835275596929c7136cb788f087a6afcce2c6fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vmfex hook: remove filter from directly-attached vnics
Francesco Romani has submitted this change and it was merged. Change subject: vmfex hook: remove filter from directly-attached vnics .. vmfex hook: remove filter from directly-attached vnics It seems that libvirt has become more strict, and would not accept a filterref that it cannot enforce. This patch makes the hook drop the element that is added by Vdsm. Change-Id: I47f38a76b06c4d8e8dd14adb7e9c0a1eb6e3ad9e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308839 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/53571 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas Reviewed-by: Ondřej Svoboda (cherry picked from commit 3b81a65ad0d95145e85fc11e96828465cbb0d446) Reviewed-on: https://gerrit.ovirt.org/53632 Reviewed-by: Francesco Romani --- M vdsm_hooks/vmfex_dev/vmfex_vnic.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Passed CI tests Francesco Romani: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47f38a76b06c4d8e8dd14adb7e9c0a1eb6e3ad9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: Clean net & bond after functional test.
gerrit-hooks has posted comments on this change. Change subject: net tests: Clean net & bond after functional test. .. Patch Set 2: * #1310410::Update tracker: OK * Set MODIFIED::bug 1310410#1310410IGNORE, not all related patches are closed, check 53763 -- To view, visit https://gerrit.ovirt.org/53770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e835275596929c7136cb788f087a6afcce2c6fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: Clean net & bond after functional test.
Francesco Romani has submitted this change and it was merged. Change subject: net tests: Clean net & bond after functional test. .. net tests: Clean net & bond after functional test. testSetupNetworksEmergencyDevicesCleanupBondOverwrite now removes the network & bond. Keeping them around causes the failure of the subsequent test. Change-Id: I4e835275596929c7136cb788f087a6afcce2c6fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310410 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/53769 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg (cherry picked from commit f52f43f56cc407c22db278bceb08f462be42b061) Reviewed-on: https://gerrit.ovirt.org/53770 Reviewed-by: Francesco Romani --- M tests/functional/networkTests.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/53770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e835275596929c7136cb788f087a6afcce2c6fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...
Ondřej Svoboda has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 7: Verified+1 Verified again on Fedora 22. -- To view, visit https://gerrit.ovirt.org/53683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Make VM domain descriptor accessible
Francesco Romani has posted comments on this change. Change subject: virt: Make VM domain descriptor accessible .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dacec299fd6176b10b4180e2737d6b2f59ccbc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add retry logic for incoming limit
Martin Betak has abandoned this change. Change subject: migration: Add retry logic for incoming limit .. Abandoned superceeded by I988fa2e501eb77d121668b22cc533b744a3dc755 -- To view, visit https://gerrit.ovirt.org/46971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icabe79dfccb61ce43489a9a242a5390e73979649 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add retry logic for incoming limit
gerrit-hooks has posted comments on this change. Change subject: migration: Add retry logic for incoming limit .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icabe79dfccb61ce43489a9a242a5390e73979649 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add migrateChangeGlobalParams verb
gerrit-hooks has posted comments on this change. Change subject: migration: Add migrateChangeGlobalParams verb .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/47409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f6d1bcdc29f144d9fcf28a085b7014127cc4f41 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add migrateChangeGlobalParams verb
Martin Betak has abandoned this change. Change subject: migration: Add migrateChangeGlobalParams verb .. Abandoned superceeded by I79ab97f15788e4024c94d051e4aade713d760acf -- To view, visit https://gerrit.ovirt.org/47409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4f6d1bcdc29f144d9fcf28a085b7014127cc4f41 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: netinfo: do not mistake a veth device for a VLAN in ifaceUsed
Edward Haas has posted comments on this change. Change subject: netinfo: do not mistake a veth device for a VLAN in ifaceUsed .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/53818 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee3b45fb38f136bf69c175cbd745c89f80c299cf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: make functional tests run again with persistence=...
Dan Kenigsberg has posted comments on this change. Change subject: net tests: make functional tests run again with persistence=ifcfg .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I849172cdab80e760a65ac19d367064b1dbf81b03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. net: also disable IPv6 on bridges not using it, after unified restoration This is a follow-up work to disallow VM-host communication over IPv6 (using e.g. link-local addresses) in the case when networking on the host was configured without IPv6. This covers the reboot scenario, in addition to the previously implemented disablement of IPv6 during network configuration through setupNetworks. Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Bug-Url: https://bugzilla.redhat.com/1219363 Signed-off-by: Ondřej Svoboda Reviewed-on: https://gerrit.ovirt.org/53683 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg --- M vdsm/vdsm-restore-net-config 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Make VM domain descriptor accessible
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Make VM domain descriptor accessible .. virt: Make VM domain descriptor accessible Change-Id: I58dacec299fd6176b10b4180e2737d6b2f59ccbc Signed-off-by: Martin Betak Reviewed-on: https://gerrit.ovirt.org/53371 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58dacec299fd6176b10b4180e2737d6b2f59ccbc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Make VM domain descriptor accessible
gerrit-hooks has posted comments on this change. Change subject: virt: Make VM domain descriptor accessible .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/53371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dacec299fd6176b10b4180e2737d6b2f59ccbc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...
Dan Kenigsberg has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...
gerrit-hooks has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 8: * #1219363::Update tracker: OK * Set MODIFIED::bug 1219363#1219363IGNORE, not all related patches are closed, check 46985 -- To view, visit https://gerrit.ovirt.org/53683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: remove _delNonVdsmNetwork
Petr Horáček has posted comments on this change. Change subject: net: api: remove _delNonVdsmNetwork .. Patch Set 1: They are not, only two occurences of this functions (definition and _delNetwork() call are removed) -- To view, visit https://gerrit.ovirt.org/53761 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a57e28328edc0dc8da76efb1fd935dffad01092 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage
gerrit-hooks has posted comments on this change. Change subject: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic159cb84049d90cdb2a4279a34145462c8ee6be4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: recovery: tests: exercise more recovery code
Milan Zamazal has posted comments on this change. Change subject: virt: recovery: tests: exercise more recovery code .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieaf829c5f306a576c2bf5b8776bb5c0784ca3ca1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: also disable IPv6 on bridges not using it, after unifie...
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/53882
to review the following change.
Change subject: net: also disable IPv6 on bridges not using it, after unified
restoration
..
net: also disable IPv6 on bridges not using it, after unified restoration
This is a follow-up work to disallow VM-host communication over IPv6
(using e.g. link-local addresses) in the case when networking on the host
was configured without IPv6.
This covers the reboot scenario, in addition to the previously implemented
disablement of IPv6 during network configuration through setupNetworks.
Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963
Bug-Url: https://bugzilla.redhat.com/1219363
Signed-off-by: Ondřej Svoboda
Reviewed-on: https://gerrit.ovirt.org/53683
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas
Reviewed-by: Dan Kenigsberg
---
M vdsm/vdsm-restore-net-config
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/53882/1
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index 7ede6f0..1074d11 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -28,12 +28,16 @@
import time
import errno
+import six
+
from vdsm.config import config
from vdsm import ipwrapper
from vdsm import netinfo
+from vdsm.netinfo import ipv6_supported
from vdsm.constants import P_VDSM_RUN
from vdsm.netconfpersistence import RunningConfig, PersistentConfig, \
KernelConfig, CONF_PERSIST_DIR, BaseConfig
+from vdsm import sysctl
from vdsm.utils import monotonic_time
import hostdev
@@ -132,6 +136,8 @@
logging.debug('Calling setupNetworks with networks (%s) '
'and bond (%s).', nets, bonds)
setupNetworks(nets, bonds, connectivityCheck=False, _inRollback=True)
+if ipv6_supported():
+_restore_disable_ipv6(nets)
def _verify_all_devices_are_up(owned_ifcfg_files):
@@ -341,6 +347,18 @@
not l.oper_up)
+def _restore_disable_ipv6(networks):
+"""
+Disable IPv6 on bridges with no IPv6 configuration, after networks have
+been restored. This is implemented for unified persistence only.
+"""
+for net, net_attr in six.iteritems(networks):
+if net_attr.get('bridged') and not net_attr.get('ipv6addr') and not (
+net_attr.get('ipv6autoconf')) and not net_attr.get('dhcpv6'):
+# _wait_for_for_all_devices_up has already run, so assuming up
+sysctl.disable_ipv6(net)
+
+
def _owned_ifcfg(link_name):
return _ifcfg_predicate(link_name, _owned_ifcfg_content)
--
To view, visit https://gerrit.ovirt.org/53882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: also disable IPv6 on bridges not using it, after unifie...
gerrit-hooks has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 1: * #1219363::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1219363::OK, public bug * Check Product::#1219363::OK, Correct classification oVirt * Check TM::#1219363::OK, correct target milestone ovirt-3.6.5 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/53882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Hello Nir Soffer, Adam Litke, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/53883 to review the following change. Change subject: Live Merge: Skip initial extension when base is raw .. Live Merge: Skip initial extension when base is raw When starting a live merge we pre-extend the base volume in order to accomodate the data that will be merged into the base volume. This is only necessary for thinly provisioned block volumes. Check to make sure that the base volume is eligible for extension before extending it. Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Bug-Url: https://bugzilla.redhat.com/1301709 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/53318 Reviewed-by: Nir Soffer Continuous-Integration: Nir Soffer Reviewed-by: Allon Mureinik Reviewed-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/53883/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 4111c2f..bb0c31c 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -4891,7 +4891,7 @@ # the worst case, the allocated size of 'base' should be increased by # the allocated size of 'top' plus one additional chunk to accomodate # additional writes to 'top' during the live merge operation. -if drive.chunked: +if drive.chunked and baseInfo['format'] == 'COW': capacity, alloc, physical = self._getExtendInfo(drive) baseSize = int(baseInfo['apparentsize']) topSize = int(topInfo['apparentsize']) -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 1: * #1301709::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301709::OK, public bug * Check Product::#1301709::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Allon Mureinik has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 1: Verified+1 Same as the 3.6 patch -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Nir Soffer has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Yaniv Bronhaim has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Francesco Romani has submitted this change and it was merged. Change subject: Live Merge: Skip initial extension when base is raw .. Live Merge: Skip initial extension when base is raw When starting a live merge we pre-extend the base volume in order to accomodate the data that will be merged into the base volume. This is only necessary for thinly provisioned block volumes. Check to make sure that the base volume is eligible for extension before extending it. Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Bug-Url: https://bugzilla.redhat.com/1301709 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/53318 Reviewed-by: Nir Soffer Continuous-Integration: Nir Soffer Reviewed-by: Allon Mureinik Reviewed-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/53883 Tested-by: Allon Mureinik Reviewed-by: Yaniv Bronhaim Continuous-Integration: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Verified Francesco Romani: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Move network tests to its own folder
Edward Haas has posted comments on this change. Change subject: tests: Move network tests to its own folder .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/53704/5/tests/network/tc_filter_show.out File tests/network/tc_filter_show.out: Line 31: > one more trailing white space This is an empty line between the action/s. -- To view, visit https://gerrit.ovirt.org/53704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 2: * #1301709::Update tracker: OK * Set MODIFIED::bug 1301709#1301709IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Francesco Romani has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 1: Continuous-Integration+1 run CI scripts locally and manually: http://www.ovirt.org/develop/dev-process/build-and-test-standards/ -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw
Francesco Romani has posted comments on this change. Change subject: Live Merge: Skip initial extension when base is raw .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: recovery: tests: exercise more recovery code
Dan Kenigsberg has posted comments on this change. Change subject: virt: recovery: tests: exercise more recovery code .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieaf829c5f306a576c2bf5b8776bb5c0784ca3ca1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: recovery: tests: exercise more recovery code
gerrit-hooks has posted comments on this change. Change subject: virt: recovery: tests: exercise more recovery code .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/53690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieaf829c5f306a576c2bf5b8776bb5c0784ca3ca1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: recovery: tests: exercise more recovery code
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: recovery: tests: exercise more recovery code .. virt: recovery: tests: exercise more recovery code Add more tests for the new recovery.py module. We exercise existing functions and methods. Change-Id: Ieaf829c5f306a576c2bf5b8776bb5c0784ca3ca1 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/53690 Continuous-Integration: Jenkins CI Reviewed-by: Milan Zamazal Reviewed-by: Dan Kenigsberg --- M tests/vmRecoveryTests.py 1 file changed, 59 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieaf829c5f306a576c2bf5b8776bb5c0784ca3ca1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Don't fail connect server when getting volume info`
gerrit-hooks has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info` .. Patch Set 3: * #1303977::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303977::OK, public bug * Check Product::#1303977::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add incoming migration semaphore
gerrit-hooks has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 32: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/45954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Make run() return status
gerrit-hooks has posted comments on this change. Change subject: vm: Make run() return status .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/53745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia21eefb7ff9ccb144c000c620788567692489f11 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Make run() return status
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Make run() return status .. vm: Make run() return status Change-Id: Ia21eefb7ff9ccb144c000c620788567692489f11 Signed-off-by: Martin Betak Reviewed-on: https://gerrit.ovirt.org/53745 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Francesco Romani --- M vdsm/clientIF.py M vdsm/virt/vm.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia21eefb7ff9ccb144c000c620788567692489f11 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add incoming migration semaphore
Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: Add incoming migration semaphore .. migration: Add incoming migration semaphore Added throttling of incoming migrations. 'migrationCreate' verb can now return new error status `migrationLimit` to report full occupation. Wiki: http://www.ovirt.org/Features/Migration_Enhancements Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e Signed-off-by: Martin Betak Reviewed-on: https://gerrit.ovirt.org/45954 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/config.py.in M lib/vdsm/define.py M vdsm/virt/migration.py M vdsm/virt/vm.py 4 files changed, 28 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8952f732033ed160292b11fbc0c4deac099b2b3e Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: remove _diff helper
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmstats: remove _diff helper .. vmstats: remove _diff helper the _diff helper is pretty pointless: makes the code harder to follow, not easier. This patch drops it without changes in behaviour. Change-Id: Ic0621d99b4d6a63ad68ed7374f4614b98a080a4e Bug-Url: https://bugzilla.redhat.com/1299480 Backport-To: 3.6 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/53612 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vmstats.py 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/53612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0621d99b4d6a63ad68ed7374f4614b98a080a4e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: remove _diff helper
Dan Kenigsberg has posted comments on this change. Change subject: vmstats: remove _diff helper .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0621d99b4d6a63ad68ed7374f4614b98a080a4e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: remove _diff helper
gerrit-hooks has posted comments on this change. Change subject: vmstats: remove _diff helper .. Patch Set 8: * #1299480::Update tracker: OK * Set MODIFIED::bug 1299480#1299480IGNORE, not all related patches are closed, check 53056 -- To view, visit https://gerrit.ovirt.org/53612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0621d99b4d6a63ad68ed7374f4614b98a080a4e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Don't fail connect server when getting volume info`
gerrit-hooks has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info` .. Patch Set 4: * #1303977::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303977::OK, public bug * Check Product::#1303977::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Move network tests to its own folder
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/53704/5/vdsm.spec.in
File vdsm.spec.in:
Line 1226: %{_datadir}/%{vdsm_name}/tests/ip_route_show_table_all.out
Line 1227: %{_datadir}/%{vdsm_name}/tests/iscsiadm_-m_iface.out
Line 1228:
%{_datadir}/%{vdsm_name}/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out
Line 1229: %{_datadir}/%{vdsm_name}/tests/mem_info.out
Line 1230: %{_datadir}/%{vdsm_name}/tests/network/*.py*
I'd prefer to have a line for each file to avoid mistakes at least in spec
Line 1231: %{_datadir}/%{vdsm_name}/tests/network/netmaskconversions
Line 1232: %{_datadir}/%{vdsm_name}/tests/network/tc_filter_show.out
Line 1233: %{_datadir}/%{vdsm_name}/tests/run_tests.sh
Line 1234: %{_datadir}/%{vdsm_name}/tests/toolTests_empty.conf
--
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move hostdev to lib
gerrit-hooks has posted comments on this change. Change subject: move hostdev to lib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic37e635ce027496f112272a313732baf20b44997 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move logUtils to lib
gerrit-hooks has posted comments on this change. Change subject: move logUtils to lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move logUtils to lib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: move logUtils to lib
..
move logUtils to lib
Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365
Signed-off-by: Yaniv Bronhaim
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/Makefile.am
R lib/vdsm/logUtils.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
M vdsm/storage/resourceManager.py
M vdsm/storage/task.py
M vdsm/virt/vm.py
11 files changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/53889/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index b882c4d..c7e99af 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -20,6 +20,7 @@
./usr/lib/python2.7/dist-packages/vdsm/ipwrapper.py
./usr/lib/python2.7/dist-packages/vdsm/jsonrpcvdscli.py
./usr/lib/python2.7/dist-packages/vdsm/kernelconfig.py
+./usr/lib/python2.7/dist-packages/vdsm/logUtils.py
./usr/lib/python2.7/dist-packages/vdsm/libvirtconnection.py
./usr/lib/python2.7/dist-packages/vdsm/netconfpersistence.py
./usr/lib/python2.7/dist-packages/vdsm/netinfo/__init__.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 2041fd1..6b5926e 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -45,7 +45,6 @@
./usr/share/vdsm/hooking.py
./usr/share/vdsm/jobs.py
./usr/share/vdsm/kaxmlrpclib.py
-./usr/share/vdsm/logUtils.py
./usr/share/vdsm/mk_sysprep_floppy
./usr/share/vdsm/mkimage.py
./usr/share/vdsm/momIF.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 4180eba..72607b1 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -44,6 +44,7 @@
jsonrpcvdscli.py \
kernelconfig.py \
libvirtconnection.py \
+ logUtils.py \
m2cutils.py \
netconfpersistence.py \
panic.py \
diff --git a/vdsm/logUtils.py b/lib/vdsm/logUtils.py
similarity index 99%
rename from vdsm/logUtils.py
rename to lib/vdsm/logUtils.py
index f3847ed..5a651c9 100644
--- a/vdsm/logUtils.py
+++ b/lib/vdsm/logUtils.py
@@ -17,6 +17,7 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
import grp
import logging
diff --git a/vdsm.spec.in b/vdsm.spec.in
index e56ed5e..2f60cbf 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -899,7 +899,6 @@
%{_sysconfdir}/sudoers.d/50_vdsm
%{_sysconfdir}/cron.hourly/vdsm-logrotate
%{_sysconfdir}/libvirt/hooks/qemu
-%{_datadir}/%{vdsm_name}/logUtils.py*
%{_libexecdir}/%{vdsm_name}/curl-img-wrap
%{_libexecdir}/%{vdsm_name}/fc-scan
%{_libexecdir}/%{vdsm_name}/persist-vdsm-hooks
@@ -1102,6 +1101,7 @@
%{python_sitelib}/%{vdsm_name}/jobs.py*
%{python_sitelib}/%{vdsm_name}/jsonrpcvdscli.py*
%{python_sitelib}/%{vdsm_name}/kernelconfig.py*
+%{python_sitelib}/%{vdsm_name}/logUtils.py*
%{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
%{python_sitelib}/%{vdsm_name}/m2cutils.py*
%{python_sitelib}/%{vdsm_name}/netinfo/__init__.py*
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 6249030..a292f56 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -28,7 +28,6 @@
clientIF.py \
hooking.py \
kaxmlrpclib.py \
- logUtils.py \
mkimage.py \
momIF.py \
numaUtils.py \
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 27c9950..019fb8c 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -37,6 +37,7 @@
import stat
from vdsm import concurrent
+from vdsm import logUtils
from vdsm.config import config
import sp
from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS
@@ -67,7 +68,6 @@
import resourceManager as rm
from resourceFactories import IMAGE_NAMESPACE
import devicemapper
-import logUtils
import mount
import dispatcher
import storageServer
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index f9b3865..c9508d2 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -49,9 +49,9 @@
from vdsm import commands
from vdsm import concurrent
from vdsm import constants
+from vdsm import logUtils
from vdsm import utils
import storage_exception as se
-import logUtils
from storage.constants import SECTOR_SIZE
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 0b9f848..7365833 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -29,7 +29,7 @@
import storage_exception as se
import misc
-from logUtils import SimpleLogAdapter
+from vdsm.logUtils import SimpleLogAdapter
from vdsm import concurrent
from vdsm import utils
diff --git a/vdsm/storage/task.py b/vdsm/storage/task.py
index c558e0e..a4cc97e 100644
--- a/vdsm/storage/task.py
+++ b/vdsm/storage/task.py
@@ -60,8 +60,8 @@
from weakref import proxy
from vdsm import concurrent
from vdsm.config import config
+from vdsm.logUtils import SimpleLogAdapter
import outOfProcess as oop
-from
Change in vdsm[master]: utils: Add @throttle decorator
gerrit-hooks has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab4cf387f77a9b720afb7794e27ed54efa0d3e3c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: from EAFP to LBYL
Dan Kenigsberg has posted comments on this change. Change subject: vmstats: from EAFP to LBYL .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53613/7/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 125: make types uniform (e.g. all str) cpuUsage should have the same type as cpuUser and cpuSys we may block the str() when xmlrpc is deserted. -- To view, visit https://gerrit.ovirt.org/53613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: disable on migration destination
Dan Kenigsberg has posted comments on this change. Change subject: virt: periodic: disable on migration destination .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add @throttle decorator
Martin Betak has abandoned this change. Change subject: utils: Add @throttle decorator .. Abandoned -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iab4cf387f77a9b720afb7794e27ed54efa0d3e3c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: also disable IPv6 on bridges not using it, after unifie...
Dan Kenigsberg has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: make functional tests run again with persistence=...
Francesco Romani has posted comments on this change. Change subject: net tests: make functional tests run again with persistence=ifcfg .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I849172cdab80e760a65ac19d367064b1dbf81b03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: api: use running config only with unified persistence
gerrit-hooks has posted comments on this change. Change subject: net: api: use running config only with unified persistence .. Patch Set 4: * #1310410::Update tracker: OK * Set MODIFIED::bug 1310410#1310410IGNORE, not all related patches are closed, check 53818 -- To view, visit https://gerrit.ovirt.org/53763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b6c13f97be58a7ad41268a44dee27241c8d2ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: make functional tests run again with persistence=...
Francesco Romani has submitted this change and it was merged. Change subject: net tests: make functional tests run again with persistence=ifcfg .. net tests: make functional tests run again with persistence=ifcfg We have multiple users that use net_persistence=ifcfg. We must make sure that Vdsm does not inadvertently breaks them. This patch only makes the tests run again, after recent changes assuming unified persistence. Change-Id: I849172cdab80e760a65ac19d367064b1dbf81b03 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310410 Signed-off-by: Dan Kenigsberg Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/53713 Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/53775 Reviewed-by: Francesco Romani --- M tests/functional/networkTests.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/53775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I849172cdab80e760a65ac19d367064b1dbf81b03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: api: use running config only with unified persistence
Francesco Romani has submitted this change and it was merged. Change subject: net: api: use running config only with unified persistence .. net: api: use running config only with unified persistence configurator.runningConfig should be used only when unified persistence is used. If we call it with ifcfg persistence, vdsm explodes. This patch fixes testBrokenNetworkReplacement. Change-Id: I76b6c13f97be58a7ad41268a44dee27241c8d2ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310410 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/53744 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/53763 Reviewed-by: Francesco Romani --- M vdsm/network/api.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Edward Haas: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76b6c13f97be58a7ad41268a44dee27241c8d2ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net tests: make functional tests run again with persistence=...
gerrit-hooks has posted comments on this change. Change subject: net tests: make functional tests run again with persistence=ifcfg .. Patch Set 2: * #1310410::Update tracker: OK * Set MODIFIED::bug 1310410#1310410IGNORE, not all related patches are closed, check 53763 -- To view, visit https://gerrit.ovirt.org/53775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I849172cdab80e760a65ac19d367064b1dbf81b03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Move network tests to its own folder
Edward Haas has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/53704/5/vdsm.spec.in
File vdsm.spec.in:
Line 1226: %{_datadir}/%{vdsm_name}/tests/ip_route_show_table_all.out
Line 1227: %{_datadir}/%{vdsm_name}/tests/iscsiadm_-m_iface.out
Line 1228:
%{_datadir}/%{vdsm_name}/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out
Line 1229: %{_datadir}/%{vdsm_name}/tests/mem_info.out
Line 1230: %{_datadir}/%{vdsm_name}/tests/network/*.py*
> I'd prefer to have a line for each file to avoid mistakes at least in spec
I think that forgetting to add a file here can be a more common mistake.
This way we deploy everything and won't miss.
Line 1231: %{_datadir}/%{vdsm_name}/tests/network/netmaskconversions
Line 1232: %{_datadir}/%{vdsm_name}/tests/network/tc_filter_show.out
Line 1233: %{_datadir}/%{vdsm_name}/tests/run_tests.sh
Line 1234: %{_datadir}/%{vdsm_name}/tests/toolTests_empty.conf
--
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: api: use running config only with unified persistence
Francesco Romani has posted comments on this change. Change subject: net: api: use running config only with unified persistence .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b6c13f97be58a7ad41268a44dee27241c8d2ab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move parted_utils to lib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: move parted_utils to lib
..
move parted_utils to lib
Change-Id: I07e2a7aa70bdd7ad1f3bfca9b83c192545d24693
Signed-off-by: Yaniv Bronhaim
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/Makefile.am
R lib/vdsm/parted_utils.py
M tests/parted_utils_tests.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/supervdsmServer
8 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/53897/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index c7e99af..d3ad2af 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -42,6 +42,7 @@
./usr/lib/python2.7/dist-packages/vdsm/netlink/monitor.py
./usr/lib/python2.7/dist-packages/vdsm/netlink/route.py
./usr/lib/python2.7/dist-packages/vdsm/panic.py
+./usr/lib/python2.7/dist-packages/vdsm/parted_utils.py
./usr/lib/python2.7/dist-packages/vdsm/password.py
./usr/lib/python2.7/dist-packages/vdsm/ppc64HardwareInfo.py
./usr/lib/python2.7/dist-packages/vdsm/profiling/__init__.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 6b5926e..aab7844 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -69,7 +69,6 @@
./usr/share/vdsm/network/tc/qdisc.py
./usr/share/vdsm/network/utils.py
./usr/share/vdsm/numaUtils.py
-./usr/share/vdsm/parted_utils.py
./usr/share/vdsm/protocoldetector.py
./usr/share/vdsm/rpc/__init__.py
./usr/share/vdsm/rpc/bindingjsonrpc.py
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 72607b1..8b578ba 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -48,6 +48,7 @@
m2cutils.py \
netconfpersistence.py \
panic.py \
+ parted_utils.py \
password.py \
ppc64HardwareInfo.py \
pthread.py \
diff --git a/vdsm/parted_utils.py b/lib/vdsm/parted_utils.py
similarity index 100%
rename from vdsm/parted_utils.py
rename to lib/vdsm/parted_utils.py
diff --git a/tests/parted_utils_tests.py b/tests/parted_utils_tests.py
index bd9d4b6..f113404 100644
--- a/tests/parted_utils_tests.py
+++ b/tests/parted_utils_tests.py
@@ -29,7 +29,7 @@
from vdsm import commands
try:
-import parted_utils as putils
+from vdsm import parted_utils as putils
except Exception:
raise SkipTest("unable to import pyparted modules.")
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 2f60cbf..939b2bb 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -849,7 +849,6 @@
%{_datadir}/%{vdsm_name}/API.py*
%{_datadir}/%{vdsm_name}/hooking.py*
%{_datadir}/%{vdsm_name}/mk_sysprep_floppy
-%{_datadir}/%{vdsm_name}/parted_utils.py*
%{_datadir}/%{vdsm_name}/mkimage.py*
%{_datadir}/%{vdsm_name}/numaUtils.py*
%{_datadir}/%{vdsm_name}/protocoldetector.py*
@@ -1139,6 +1138,7 @@
%{python_sitelib}/%{vdsm_name}/network/utils.py*
%{python_sitelib}/%{vdsm_name}/password.py*
%{python_sitelib}/%{vdsm_name}/panic.py*
+%{python_sitelib}/%{vdsm_name}/parted_utils.py
%{python_sitelib}/%{vdsm_name}/ppc64HardwareInfo.py*
%{python_sitelib}/%{vdsm_name}/profiling/__init__.py*
%{python_sitelib}/%{vdsm_name}/profiling/cpu.py*
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index a292f56..cde02e2 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -31,7 +31,6 @@
mkimage.py \
momIF.py \
numaUtils.py \
- parted_utils.py \
protocoldetector.py \
sitecustomize.py \
$(NULL)
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index a829b98..46850b6 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -63,7 +63,7 @@
from vdsm import utils
from vdsm import sysctl
from vdsm.supervdsm import _SuperVdsmManager
-from parted_utils import getDevicePartedInfo as _getDevicePartedInfo
+from vdsm.parted_utils import getDevicePartedInfo as _getDevicePartedInfo
from vdsm.network import sourceroutethread
--
To view, visit https://gerrit.ovirt.org/53897
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07e2a7aa70bdd7ad1f3bfca9b83c192545d24693
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move parted_utils to lib
gerrit-hooks has posted comments on this change. Change subject: move parted_utils to lib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e2a7aa70bdd7ad1f3bfca9b83c192545d24693 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: add in-place sparsify support
Shahar Havivi has uploaded a new change for review.
Change subject: virt-sparsify: add in-place sparsify support
..
virt-sparsify: add in-place sparsify support
Change-Id: Icef4021567df5da1cd5b74a94c2d76fefcde3aba
Signed-off-by: Shahar Havivi
---
M lib/api/vdsmapi-schema.json
M lib/vdsm/virtsparsify.py
M vdsm/API.py
3 files changed, 69 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/53900/1
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index 69a6802..b5812b7 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -8307,6 +8307,25 @@
'data': {'vmID': 'UUID', 'drive': 'DriveSpecVolume', 'baseVolUUID': 'UUID',
'topVolUUID': 'UUID', '*bandwidth': 'int', '*jobUUID': 'UUID'}}
+##
+# @VM.sparsifyInplace:
+#
+# Perform an in-place sparse (e.g. not creating a new image) on given volume
+#
+# @vmID: The UUID of the VM
+#
+# @drive:A @DriveSpecVolume structure representing the disk
+#
+# @topVolUUID: The UUID of the sparsed volume
+#
+# @jobUUID: #optional Assign a UUID to this operation which can be used
+#to identify it in @VmStats
+#
+# Since: 4.15.0
+##
+{'command': {'class': 'VM', 'name': 'sparsifyInplace'},
+ 'data': {'vmID': 'UUID', 'drive': 'DriveSpecVolume', 'baseVolUUID': 'UUID',
+ 'topVolUUID': 'UUID', '*bandwidth': 'int', '*jobUUID': 'UUID'}}
## Category: @Volume ##
##
diff --git a/lib/vdsm/virtsparsify.py b/lib/vdsm/virtsparsify.py
index c4a63e5..6ba3fd5 100644
--- a/lib/vdsm/virtsparsify.py
+++ b/lib/vdsm/virtsparsify.py
@@ -20,9 +20,12 @@
from __future__ import absolute_import
import signal
+from uuid import uuid4
from . import cmdutils
from . import commands
+from . import concurrent
+from . import jobs
from . import utils
# Fedora, EL6
@@ -55,3 +58,44 @@
if rc != 0:
raise cmdutils.Error(cmd, rc, out, err)
+
+
+def inplace(self, vol):
+"""
+Sparsify the volume in place
+(instead of copying from an input disk to an output disk)
+"""
+job = InplaceJob()
+job.start()
+jobs.add(job)
+
+
+def delete_inplace_job(job_id):
+return jobs.delete(job_id)
+
+
+def abort_inplace_job(job_id):
+return jobs.abort(job_id)
+
+
+class InplaceJob(jobs.Job):
+def __init__(self):
+self._id = uuid()
+self._thread = None
+
+def start(self):
+self._thread = concurrent.thread(self._run)
+self.jobs.add(self._id)
+self._thread.start()
+
+def _run(self):
+cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', vol]
+return execCmd(cmd,
+ sync=False,
+ deathSignal=signal.SIGTERM,
+ env={'LIBGUESTFS_BACKEND': 'direct'})
+self._proc = commands.execCmd(cmd,
+ env={'LIBGUESTFS_BACKEND': 'direct'})
+
+if rc != 0:
+raise cmdutils.Error(cmd, rc, out, err)
diff --git a/vdsm/API.py b/vdsm/API.py
index 2f7d04d..e843c96 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -809,6 +809,12 @@
return errCode['noVM']
return v.merge(drive, baseVolUUID, topVolUUID, bandwidth, jobUUID)
+def sparsifyInplace(self, drive, volUUID, jobUUID=None):
+v = self._cif.vmContainer.get(self._UUID)
+if not v:
+return errCode['noVM']
+return v.sparsifyInplace(drive, volUUID, jobUUID)
+
class Volume(APIBase):
ctorArgs = ['volumeID', 'storagepoolID', 'storagedomainID', 'imageID']
--
To view, visit https://gerrit.ovirt.org/53900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icef4021567df5da1cd5b74a94c2d76fefcde3aba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: rename sparsify method to more descriptive
Shahar Havivi has uploaded a new change for review.
Change subject: virt-sparsify: rename sparsify method to more descriptive
..
virt-sparsify: rename sparsify method to more descriptive
Change-Id: Ibcef55a584b387e3c29e584027e05d41a06bb8af
Signed-off-by: Shahar Havivi
---
M lib/vdsm/virtsparsify.py
M tests/sparsifyTests.py
M vdsm/storage/image.py
3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/53899/1
diff --git a/lib/vdsm/virtsparsify.py b/lib/vdsm/virtsparsify.py
index 44ed778..c4a63e5 100644
--- a/lib/vdsm/virtsparsify.py
+++ b/lib/vdsm/virtsparsify.py
@@ -30,7 +30,7 @@
"/usr/bin/virt-sparsify",)
-def sparsify(src_vol, tmp_vol, dst_vol, src_format=None, dst_format=None):
+def to_new_image(src_vol, tmp_vol, dst_vol, src_format=None, dst_format=None):
"""
Sparsify the 'src_vol' volume (src_format) to 'dst_vol' volume (dst_format)
using libguestfs virt-sparsify
diff --git a/tests/sparsifyTests.py b/tests/sparsifyTests.py
index f99b0c8..b8d58c4 100644
--- a/tests/sparsifyTests.py
+++ b/tests/sparsifyTests.py
@@ -35,7 +35,7 @@
class VirtSparsifyTests(TestCaseBase):
-@MonkeyPatch(virtsparsify, '_VIRTSPARSIFY', FakeCommand())
+@MonkeyPatch(virtsparsify.to_new_image, '_VIRTSPARSIFY', FakeCommand())
def test_raise_error_on_failure(self):
self.assertRaises(cmdutils.Error,
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index a5c088d..4f74b0b 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -633,11 +633,11 @@
srcFormat = volume.fmt2str(srcVolume.getFormat())
dstFormat = volume.fmt2str(dstVolume.getFormat())
-virtsparsify.sparsify(srcVolume.getVolumePath(),
- tmpVolume.getVolumePath(),
- dstVolume.getVolumePath(),
- src_format=srcFormat,
- dst_format=dstFormat)
+virtsparsify.to_new_image(srcVolume.getVolumePath(),
+ tmpVolume.getVolumePath(),
+ dstVolume.getVolumePath(),
+ src_format=srcFormat,
+ dst_format=dstFormat)
except Exception:
self.log.exception('Unexpected error sparsifying %s',
tmpVolUUID)
--
To view, visit https://gerrit.ovirt.org/53899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcef55a584b387e3c29e584027e05d41a06bb8af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: add in-place sparsify support
gerrit-hooks has posted comments on this change. Change subject: virt-sparsify: add in-place sparsify support .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icef4021567df5da1cd5b74a94c2d76fefcde3aba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move parted_utils to lib
gerrit-hooks has posted comments on this change. Change subject: move parted_utils to lib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e2a7aa70bdd7ad1f3bfca9b83c192545d24693 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: use new jobs infrastructure
gerrit-hooks has posted comments on this change. Change subject: v2v: use new jobs infrastructure .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac71559e02502580de9c2e537733ec7286682050 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: rename sparsify method to more descriptive
gerrit-hooks has posted comments on this change. Change subject: virt-sparsify: rename sparsify method to more descriptive .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcef55a584b387e3c29e584027e05d41a06bb8af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: rename sparsify method to more descriptive
Shahar Havivi has posted comments on this change. Change subject: virt-sparsify: rename sparsify method to more descriptive .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/53899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcef55a584b387e3c29e584027e05d41a06bb8af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: add in-place sparsify support
Shahar Havivi has posted comments on this change. Change subject: virt-sparsify: add in-place sparsify support .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/53900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icef4021567df5da1cd5b74a94c2d76fefcde3aba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move parted_utils to lib
gerrit-hooks has posted comments on this change. Change subject: move parted_utils to lib .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e2a7aa70bdd7ad1f3bfca9b83c192545d24693 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: rename sparsify method to more descriptive
Shahar Havivi has posted comments on this change. Change subject: virt-sparsify: rename sparsify method to more descriptive .. Patch Set 1: Code-Review-1 Verified-1 -- To view, visit https://gerrit.ovirt.org/53899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcef55a584b387e3c29e584027e05d41a06bb8af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt-sparsify: add in-place sparsify support
Shahar Havivi has posted comments on this change. Change subject: virt-sparsify: add in-place sparsify support .. Patch Set 1: Code-Review-1 Verified-1 -- To view, visit https://gerrit.ovirt.org/53900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icef4021567df5da1cd5b74a94c2d76fefcde3aba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move hostdev to lib
Martin Polednik has posted comments on this change. Change subject: move hostdev to lib .. Patch Set 2: Code-Review+1 great job, thanks! -- To view, visit https://gerrit.ovirt.org/53873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic37e635ce027496f112272a313732baf20b44997 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move blkid to lib
Dan Kenigsberg has posted comments on this change. Change subject: move blkid to lib .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 12: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: from EAFP to LBYL
gerrit-hooks has posted comments on this change. Change subject: vmstats: from EAFP to LBYL .. Patch Set 8: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix import error
Yaniv Bronhaim has uploaded a new change for review. Change subject: fix import error .. fix import error Change-Id: I5884052df7c6cb07d8322ab22f62657961352098 Signed-off-by: Yaniv Bronhaim --- M init/wait_for_ipv4s 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/53901/1 diff --git a/init/wait_for_ipv4s b/init/wait_for_ipv4s index b690bd5..0cfffb4 100755 --- a/init/wait_for_ipv4s +++ b/init/wait_for_ipv4s @@ -12,7 +12,8 @@ from vdsm.netinfo.addresses import getIpInfo from vdsm.netlink import monitor -from vdsm.network.configurators.ifcfg import NET_CONF_DIR, CONFFILE_HEADER_BASE +from vdsm.network.configurators.ifcfg import NET_CONF_DIR +from vdsm.network.configurators.ifcfg import ConfigWriter def _get_vdsm_ip_onboot_devs(): @@ -23,7 +24,7 @@ for ifcfg in ifcfgs: with open(join(NET_CONF_DIR, ifcfg)) as f: config = f.read() -if (config.startswith(CONFFILE_HEADER_BASE) and +if (config.startswith(ConfigWriter.CONFFILE_HEADER_BASE) and '\nONBOOT=yes\n' in config and '\nIPADDR=' in config): vdsm_ip_onboot_devs.add(ifcfg[6:]) return vdsm_ip_onboot_devs -- To view, visit https://gerrit.ovirt.org/53901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5884052df7c6cb07d8322ab22f62657961352098 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix import error
gerrit-hooks has posted comments on this change. Change subject: fix import error .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5884052df7c6cb07d8322ab22f62657961352098 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: periodic: disable on migration destination
gerrit-hooks has posted comments on this change. Change subject: virt: periodic: disable on migration destination .. Patch Set 9: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug * Check Product::#1299480::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move logUtils to lib
gerrit-hooks has posted comments on this change. Change subject: move logUtils to lib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move parted_utils to lib
gerrit-hooks has posted comments on this change. Change subject: move parted_utils to lib .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07e2a7aa70bdd7ad1f3bfca9b83c192545d24693 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
