Change in vdsm[master]: repoplot: Add qemu-img operation for pre 4.0 logs
Nir Soffer has posted comments on this change. Change subject: repoplot: Add qemu-img operation for pre 4.0 logs .. Patch Set 3: Example plots: - https://bugzilla.redhat.com/attachment.cgi?id=1130967 - https://bugzilla.redhat.com/attachment.cgi?id=1130968 - https://bugzilla.redhat.com/attachment.cgi?id=1130982 - https://bugzilla.redhat.com/attachment.cgi?id=1130983 - https://bugzilla.redhat.com/attachment.cgi?id=1130984 (with https://gerrit.ovirt.org/53395) -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation graph
Nir Soffer has posted comments on this change. Change subject: repoplot: Add qemu-img operation graph .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fe479d56537c37b4e0e813ef83ea686a7de94a8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reppolot: Add mailbox dd commands graph
Nir Soffer has posted comments on this change. Change subject: reppolot: Add mailbox dd commands graph .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa6a0783b66959bc1a8dfb0abd4cae57b42c2af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add LVM commands graph
Nir Soffer has posted comments on this change. Change subject: repoplot: Add LVM commands graph .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/54080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831e81dd6cb04607fc31579e45792d851fb45e29 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add storage domains monitors commands
Nir Soffer has posted comments on this change. Change subject: repoplot: Add storage domains monitors commands .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b84bf4b9ef7518bbf08675f3dd1a0557c524f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reppolot: Add mailbox dd commands graph
gerrit-hooks has posted comments on this change. Change subject: reppolot: Add mailbox dd commands graph .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa6a0783b66959bc1a8dfb0abd4cae57b42c2af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add LVM commands graph
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add LVM commands graph .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831e81dd6cb04607fc31579e45792d851fb45e29 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Prepare for collecting other commands
gerrit-hooks has posted comments on this change. Change subject: repoplot: Prepare for collecting other commands .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib553d3653230f1eb4a4ed950021e6d95cbbf0a49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Make it easier to add new graphs
gerrit-hooks has posted comments on this change. Change subject: repoplot: Make it easier to add new graphs .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e48b19ff744cc9b478abba0ea61b1da49c02463 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation for pre 4.0 logs
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add qemu-img operation for pre 4.0 logs .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation graph
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add qemu-img operation graph .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fe479d56537c37b4e0e813ef83ea686a7de94a8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add storage domains monitors commands
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add storage domains monitors commands .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b84bf4b9ef7518bbf08675f3dd1a0557c524f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation for pre 4.0 logs
Nir Soffer has posted comments on this change. Change subject: repoplot: Add qemu-img operation for pre 4.0 logs .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation for pre 4.0 logs
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add qemu-img operation for pre 4.0 logs .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation graph
Nir Soffer has posted comments on this change. Change subject: repoplot: Add qemu-img operation graph .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fe479d56537c37b4e0e813ef83ea686a7de94a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add storage domains monitors commands
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Add storage domains monitors commands
..
repoplot: Add storage domains monitors commands
The time to read from storage is already reported in the repostat
"delay" graph. This graphs show the time to run the dd command. We have
seen cases where the delay was very fast, but running dd command took 15
seconds. I suspect that this issue was caused by overloaded vdsm on
machine with many cores, and should be fixed by using cpu_affinity.
Change-Id: I48b84bf4b9ef7518bbf08675f3dd1a0557c524f9
Relates-To: https://bugzilla.redhat.com/1081962
Signed-off-by: Nir Soffer
---
M contrib/repoplot
1 file changed, 28 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/54107/1
diff --git a/contrib/repoplot b/contrib/repoplot
index 3595282..18a8c77 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -61,10 +61,10 @@
parser.add_argument("--width", "-x", dest="width", type=int,
help="output file width in inches (default 20)")
parser.add_argument("--height", "-y", dest="height", type=int,
-help="output file height in inches (default 20)")
+help="output file height in inches (default 25)")
parser.add_argument("files", nargs="+",
help="vdsm log files to process")
-parser.set_defaults(name=None, format="pdf", width=20, height=20)
+parser.set_defaults(name=None, format="pdf", width=20, height=25)
return parser.parse_args(args)
@@ -76,6 +76,7 @@
self.repostats = defaultdict(DomainStats)
self.lvm_commands = defaultdict(CommandStats)
self.mailbox_commands = defaultdict(CommandStats)
+self.monitor_commands = defaultdict(CommandStats)
class DomainStats(object):
@@ -103,6 +104,20 @@
# repoStats, Return response: ...
(add_repostats, "Run and protect: repoStats, Return response:",
"repostats"),
+
+# Match storage domains getReadDelay commands.
+#
+# Begin:
+# Thread-16::DEBUG::2016-02-17
+# 20:14:37,049::blockSD::436::Storage.Misc.excCmd::(getReadDelay)
+# /usr/bin/taskset --cpu-list 0-7 /usr/bin/dd ...
+#
+# End:
+# Thread-16::DEBUG::2016-02-17
+# 20:14:37,061::blockSD::436::Storage.Misc.excCmd::(getReadDelay)
+# SUCCESS: ...
+(add_command, "::Storage.Misc.excCmd::(getReadDelay)",
+"monitor_commands"),
# Match LVM commands begin or end logs.
#
@@ -202,7 +217,7 @@
def plot(stats, filename, size):
-rows = 4
+rows = 5
columns = 1
pyplot.figure(figsize=size, dpi=300)
@@ -257,6 +272,16 @@
for thread, cs in stats.mailbox_commands.iteritems():
pyplot.plot(cs.timestamp, cs.runtime)
+pyplot.subplot(rows, columns, 5)
+pyplot.title("Storage domain monitor commands")
+pyplot.ylabel("runtime (seconds)")
+pyplot.xlabel("time")
+pyplot.grid(True)
+pyplot.axis([lastcheck.index[0], lastcheck.index[-1], 0, 10])
+
+for thread, cs in stats.monitor_commands.iteritems():
+pyplot.plot(cs.timestamp, cs.runtime)
+
pyplot.savefig(filename, bbox_inches="tight")
--
To view, visit https://gerrit.ovirt.org/54107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48b84bf4b9ef7518bbf08675f3dd1a0557c524f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation graph
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Add qemu-img operation graph
..
repoplot: Add qemu-img operation graph
Parse and display qemu-img operations (4.0 only). These operations
generate lots of io, which can effect storage domains monitoring.
Change-Id: I8fe479d56537c37b4e0e813ef83ea686a7de94a8
Signed-off-by: Nir Soffer
---
M contrib/repoplot
1 file changed, 53 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/54108/1
diff --git a/contrib/repoplot b/contrib/repoplot
index 18a8c77..f9e555f 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -61,10 +61,10 @@
parser.add_argument("--width", "-x", dest="width", type=int,
help="output file width in inches (default 20)")
parser.add_argument("--height", "-y", dest="height", type=int,
-help="output file height in inches (default 25)")
+help="output file height in inches (default 30)")
parser.add_argument("files", nargs="+",
help="vdsm log files to process")
-parser.set_defaults(name=None, format="pdf", width=20, height=25)
+parser.set_defaults(name=None, format="pdf", width=20, height=30)
return parser.parse_args(args)
@@ -77,6 +77,7 @@
self.lvm_commands = defaultdict(CommandStats)
self.mailbox_commands = defaultdict(CommandStats)
self.monitor_commands = defaultdict(CommandStats)
+self.qemuimg_operations = defaultdict(CommandStats)
class DomainStats(object):
@@ -145,6 +146,21 @@
# SUCCESS: ...
(add_command, "::Storage.Misc.excCmd::(_checkForMail)",
"mailbox_commands"),
+
+# Match qemu-img operation used for copying images in 4.0.
+#
+# Begin:
+# 10db509a-d5e4-41e8-8751-1305f0852d68::DEBUG::2016-02-17
+#
19:32:49,865::image::137::Storage.Image::(_wait_for_qemuimg_operation)
+# waiting for qemu-img operation to complete
+#
+# End:
+# 10db509a-d5e4-41e8-8751-1305f0852d68::DEBUG::2016-02-17
+#
19:40:14,134::image::146::Storage.Image::(_wait_for_qemuimg_operation)
+# qemu-img operation has completed
+(add_qemuimg_operation,
+"::Storage.Image::(_wait_for_qemuimg_operation)",
+"qemuimg_operations"),
]
stats = Stats()
@@ -193,6 +209,30 @@
cs.runtime.append(0)
+def add_qemuimg_operation(operations, log):
+"""
+Add qemu-img operations start and stop events
+"""
+cs = operations[log.thread]
+if "waiting for qemu-img operation" in log.text:
+cs.running = True
+cs.timestamp.append(log.timestamp)
+cs.runtime.append(0)
+elif "operation has completed" in log.text:
+if not cs.running:
+return
+cs.running = False
+timedelta = log.timestamp - cs.timestamp[-1]
+cs.timestamp.append(log.timestamp)
+cs.runtime.append(timedelta.total_seconds())
+# Add zero in the same timestamp, to get nicer triangles in the plots.
+cs.timestamp.append(log.timestamp)
+cs.runtime.append(0)
+else:
+# Ignore periodic progress reports
+pass
+
+
def parse_log(line):
# MainThread::DEBUG::2016-02-17
# 19:26:03,875::sp::398::Storage.StoragePool::(cleanupMasterMount) ...
@@ -217,7 +257,7 @@
def plot(stats, filename, size):
-rows = 5
+rows = 6
columns = 1
pyplot.figure(figsize=size, dpi=300)
@@ -282,6 +322,16 @@
for thread, cs in stats.monitor_commands.iteritems():
pyplot.plot(cs.timestamp, cs.runtime)
+pyplot.subplot(rows, columns, 6)
+pyplot.title("qemu-img operations")
+pyplot.ylabel("runtime (seconds)")
+pyplot.xlabel("time")
+pyplot.grid(True)
+pyplot.xlim(lastcheck.index[0], lastcheck.index[-1])
+
+for thread, cs in stats.qemuimg_operations.iteritems():
+pyplot.plot(cs.timestamp, cs.runtime)
+
pyplot.savefig(filename, bbox_inches="tight")
--
To view, visit https://gerrit.ovirt.org/54108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fe479d56537c37b4e0e813ef83ea686a7de94a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation for 3.6
Nir Soffer has uploaded a new change for review. Change subject: repoplot: Add qemu-img operation for 3.6 .. repoplot: Add qemu-img operation for 3.6 Add matches to support the messy logging in 3.6. Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Signed-off-by: Nir Soffer --- M contrib/repoplot 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/54109/1 diff --git a/contrib/repoplot b/contrib/repoplot index f9e555f..0ebd9ac 100755 --- a/contrib/repoplot +++ b/contrib/repoplot @@ -161,6 +161,23 @@ (add_qemuimg_operation, "::Storage.Image::(_wait_for_qemuimg_operation)", "qemuimg_operations"), + +# Match qemu-img convert used for copying images in 3.6. This matches +# the start of the command (3.6 logging is messy). +# +# ffe3217e-6a91-4499-910b-cab975c5a3e4::DEBUG::2016-02-20 +# 20:57:47,772::utils::671::root::(execCmd) /usr/bin/taskset --cpu-list +# 0-63 /usr/bin/nice -n 19 /usr/bin/ionice -c 3 /usr/bin/qemu-img +# convert ... +(start_qemuimg_operation_36, "::root::(execCmd)", "qemuimg_operations"), + +# Match qemu-img convert used for copying images in 3.6. This matches +# the end of the command (3.6 logging is messy). +# +# End: +# ffe3217e-6a91-4499-910b-cab975c5a3e4::DEBUG::2016-02-20 +# 21:10:00,808::utils::718::root::(watchCmd) SUCCESS: ... +(end_qemuimg_operation_36, "::root::(watchCmd)", "qemuimg_operations"), ] stats = Stats() @@ -233,6 +250,34 @@ pass +def start_qemuimg_operation_36(operations, log): +""" +Add qemu-img operations start events on 3.6 +""" +if "/usr/bin/qemu-img convert " not in log.text: +return +cs = operations[log.thread] +cs.running = True +cs.timestamp.append(log.timestamp) +cs.runtime.append(0) + + +def end_qemuimg_operation_36(operations, log): +""" +Add qemu-img operations stop events on 3.6 +""" +cs = operations[log.thread] +if not cs.running: +return +cs.running = False +timedelta = log.timestamp - cs.timestamp[-1] +cs.timestamp.append(log.timestamp) +cs.runtime.append(timedelta.total_seconds()) +# Add zero in the same timestamp, to get nicer triangles in the plots. +cs.timestamp.append(log.timestamp) +cs.runtime.append(0) + + def parse_log(line): # MainThread::DEBUG::2016-02-17 # 19:26:03,875::sp::398::Storage.StoragePool::(cleanupMasterMount) ... -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation for 3.6
Nir Soffer has posted comments on this change. Change subject: repoplot: Add qemu-img operation for 3.6 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Make it easier to add new graphs
Nir Soffer has posted comments on this change. Change subject: repoplot: Make it easier to add new graphs .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e48b19ff744cc9b478abba0ea61b1da49c02463 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reppolot: Add mailbox dd commands graph
Nir Soffer has posted comments on this change. Change subject: reppolot: Add mailbox dd commands graph .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa6a0783b66959bc1a8dfb0abd4cae57b42c2af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add storage domains monitors commands
Nir Soffer has posted comments on this change. Change subject: repoplot: Add storage domains monitors commands .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b84bf4b9ef7518bbf08675f3dd1a0557c524f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Prepare for collecting other commands
Nir Soffer has posted comments on this change. Change subject: repoplot: Prepare for collecting other commands .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib553d3653230f1eb4a4ed950021e6d95cbbf0a49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add LVM commands graph
Nir Soffer has posted comments on this change. Change subject: repoplot: Add LVM commands graph .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831e81dd6cb04607fc31579e45792d851fb45e29 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Consider sub-seconds in timestamps
Nir Soffer has posted comments on this change. Change subject: repoplot: Consider sub-seconds in timestamps .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdb98fa743d671c4ee246b0858edeee7dd08f557 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reppolot: Add mailbox dd commands graph
gerrit-hooks has posted comments on this change. Change subject: reppolot: Add mailbox dd commands graph .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa6a0783b66959bc1a8dfb0abd4cae57b42c2af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add storage domains monitors commands
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add storage domains monitors commands .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b84bf4b9ef7518bbf08675f3dd1a0557c524f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Prepare for collecting other commands
gerrit-hooks has posted comments on this change. Change subject: repoplot: Prepare for collecting other commands .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib553d3653230f1eb4a4ed950021e6d95cbbf0a49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation for 3.6
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add qemu-img operation for 3.6 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c78426ab092271afb2cbb28d04969fd95716e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Make it easier to add new graphs
gerrit-hooks has posted comments on this change. Change subject: repoplot: Make it easier to add new graphs .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e48b19ff744cc9b478abba0ea61b1da49c02463 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add qemu-img operation graph
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add qemu-img operation graph .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fe479d56537c37b4e0e813ef83ea686a7de94a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reppolot: Add mailbox dd commands graph
Nir Soffer has uploaded a new change for review.
Change subject: reppolot: Add mailbox dd commands graph
..
reppolot: Add mailbox dd commands graph
Storage mailbox check for mail dd commands are performed only on the
master domain, but since they are run every 3 seconds, they are good
indicator for storage issues in the master domain.
Checking logs for copy disk flow show that SPM check for mail commands
become very slow (up to 6 seconds per command). This may cause extend
operations slow down leading to pausing of a vm.
Change-Id: I0fa6a0783b66959bc1a8dfb0abd4cae57b42c2af
Relates-To: https://bugzilla.redhat.com/1295208
Signed-off-by: Nir Soffer
---
M contrib/repoplot
1 file changed, 29 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/54106/1
diff --git a/contrib/repoplot b/contrib/repoplot
index 2c3c6ae..3595282 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -61,10 +61,10 @@
parser.add_argument("--width", "-x", dest="width", type=int,
help="output file width in inches (default 20)")
parser.add_argument("--height", "-y", dest="height", type=int,
-help="output file height in inches (default 15)")
+help="output file height in inches (default 20)")
parser.add_argument("files", nargs="+",
help="vdsm log files to process")
-parser.set_defaults(name=None, format="pdf", width=20, height=15)
+parser.set_defaults(name=None, format="pdf", width=20, height=20)
return parser.parse_args(args)
@@ -75,6 +75,7 @@
def __init__(self):
self.repostats = defaultdict(DomainStats)
self.lvm_commands = defaultdict(CommandStats)
+self.mailbox_commands = defaultdict(CommandStats)
class DomainStats(object):
@@ -114,6 +115,21 @@
# Thread-57::DEBUG::2016-02-17
# 19:26:33,933::lvm::286::Storage.Misc.excCmd::(cmd) SUCCESS: ...
(add_command, "::Storage.Misc.excCmd::(cmd)", "lvm_commands"),
+
+# Match mailbox monitor check for mail dd commands (master domain
+# only).
+#
+# Begin:
+# mailbox.SPMMonitor::DEBUG::2016-02-17
+#
20:15:24,521::storage_mailbox::731::Storage.Misc.excCmd::(_checkForMail)
+# /usr/bin/taskset --cpu-list 0-7 dd ...
+#
+# End:
+# mailbox.SPMMonitor::DEBUG::2016-02-17
+#
20:15:24,547::storage_mailbox::731::Storage.Misc.excCmd::(_checkForMail)
+# SUCCESS: ...
+(add_command, "::Storage.Misc.excCmd::(_checkForMail)",
+"mailbox_commands"),
]
stats = Stats()
@@ -186,7 +202,7 @@
def plot(stats, filename, size):
-rows = 3
+rows = 4
columns = 1
pyplot.figure(figsize=size, dpi=300)
@@ -231,6 +247,16 @@
for thread, cs in stats.lvm_commands.iteritems():
pyplot.plot(cs.timestamp, cs.runtime)
+pyplot.subplot(rows, columns, 4)
+pyplot.title("Mailbox commands")
+pyplot.ylabel("runtime (seconds)")
+pyplot.xlabel("time")
+pyplot.grid(True)
+pyplot.axis([lastcheck.index[0], lastcheck.index[-1], 0, 10])
+
+for thread, cs in stats.mailbox_commands.iteritems():
+pyplot.plot(cs.timestamp, cs.runtime)
+
pyplot.savefig(filename, bbox_inches="tight")
--
To view, visit https://gerrit.ovirt.org/54106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fa6a0783b66959bc1a8dfb0abd4cae57b42c2af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Consider sub-seconds in timestamps
gerrit-hooks has posted comments on this change. Change subject: repoplot: Consider sub-seconds in timestamps .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdb98fa743d671c4ee246b0858edeee7dd08f557 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Add LVM commands graph
gerrit-hooks has posted comments on this change. Change subject: repoplot: Add LVM commands graph .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831e81dd6cb04607fc31579e45792d851fb45e29 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Prepare for collecting other commands
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Prepare for collecting other commands
..
repoplot: Prepare for collecting other commands
Change add_lvm_command to generic add_command, so we can use the same
logic for detecting start and stop of a command for collecting other
commands statistics.
Change-Id: Ib553d3653230f1eb4a4ed950021e6d95cbbf0a49
Signed-off-by: Nir Soffer
---
M contrib/repoplot
1 file changed, 13 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/54104/1
diff --git a/contrib/repoplot b/contrib/repoplot
index baaa326..eda5f40 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -100,7 +100,8 @@
# jsonrpc.Executor/5::INFO::2016-02-17
# 19:26:33,837::logUtils::51::dispatcher::(wrapper) Run and protect:
# repoStats, Return response: ...
-(add_repostats, "Run and protect: repoStats, Return response:"),
+(add_repostats, "Run and protect: repoStats, Return response:",
+"repostats"),
# Match LVM commands begin or end logs.
#
@@ -112,35 +113,39 @@
# End:
# Thread-57::DEBUG::2016-02-17
# 19:26:33,933::lvm::286::Storage.Misc.excCmd::(cmd) SUCCESS: ...
-(add_lvm_command, "::Storage.Misc.excCmd::(cmd)"),
+(add_command, "::Storage.Misc.excCmd::(cmd)", "lvm_commands"),
]
stats = Stats()
for line in fileinput.input(files):
-for func, pattern in patterns:
+for func, pattern, name in patterns:
if pattern in line:
log = parse_log(line)
-func(stats, log)
+substats = getattr(stats, name)
+func(substats, log)
return stats
-def add_repostats(stats, log):
+def add_repostats(repostats, log):
"""
Add repostats samples from repoStats response line
"""
start = log.text.find("{")
response = eval(log.text[start:])
for uuid, info in response.items():
-ds = stats.repostats[uuid]
+ds = repostats[uuid]
ds.timestamp.append(log.timestamp)
ds.lastcheck.append(float(info["lastCheck"]))
ds.delay.append(float(info["delay"]))
-def add_lvm_command(stats, log):
-cs = stats.lvm_commands[log.thread]
+def add_command(commands, log):
+"""
+Add commands start and stop events from execCmd calls
+"""
+cs = commands[log.thread]
if " SUCCESS:" in log.text or " ERROR:" in log.text:
if not cs.running:
return
--
To view, visit https://gerrit.ovirt.org/54104
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib553d3653230f1eb4a4ed950021e6d95cbbf0a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Prepare for matching multiple patterns
gerrit-hooks has posted comments on this change. Change subject: repoplot: Prepare for matching multiple patterns .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0fbf7bfdf73d0f8088afe459124272782396ede Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Make it easier to add new graphs
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Make it easier to add new graphs
..
repoplot: Make it easier to add new graphs
Adding new subplot does not require modifyng other plots now.
Change-Id: I8e48b19ff744cc9b478abba0ea61b1da49c02463
Signed-off-by: Nir Soffer
---
M contrib/repoplot
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/54105/1
diff --git a/contrib/repoplot b/contrib/repoplot
index eda5f40..2c3c6ae 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -186,9 +186,12 @@
def plot(stats, filename, size):
+rows = 3
+columns = 1
+
pyplot.figure(figsize=size, dpi=300)
-pyplot.subplot(311)
+pyplot.subplot(rows, columns, 1)
pyplot.title("lastCheck")
pyplot.ylabel("lastCheck (seconds)")
pyplot.xlabel("time")
@@ -203,7 +206,7 @@
# non-operational.
pyplot.axis([lastcheck.index[0], lastcheck.index[-1], 0, 330])
-pyplot.subplot(312)
+pyplot.subplot(rows, columns, 2)
pyplot.title("read delay")
pyplot.ylabel("delay (seconds)")
pyplot.xlabel("time")
@@ -218,7 +221,7 @@
# warning in engine log.
pyplot.axis([lastcheck.index[0], lastcheck.index[-1], 0, 10])
-pyplot.subplot(313)
+pyplot.subplot(rows, columns, 3)
pyplot.title("LVM commands")
pyplot.ylabel("runtime (seconds)")
pyplot.xlabel("time")
--
To view, visit https://gerrit.ovirt.org/54105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e48b19ff744cc9b478abba0ea61b1da49c02463
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoplot: Consider sub-seconds in timestamps
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Consider sub-seconds in timestamps
..
repoplot: Consider sub-seconds in timestamps
Previously timestamps were truncated, which is fine when we look at
timeouts of many seconds, but there are cases where we like to see
values which are less than 1 seconds.
Change-Id: Ibdb98fa743d671c4ee246b0858edeee7dd08f557
Signed-off-by: Nir Soffer
---
M contrib/repoplot
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/54103/1
diff --git a/contrib/repoplot b/contrib/repoplot
index b6c1d35..4aadaf1 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -114,7 +114,7 @@
def parse_timestamp(line):
timestamp = line.split("::", 3)[2]
-timestamp, millis = timestamp.split(",", 1)
+timestamp = timestamp.replace(",", ".")
return pandas.Timestamp(timestamp)
--
To view, visit https://gerrit.ovirt.org/54103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdb98fa743d671c4ee246b0858edeee7dd08f557
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
gerrit-hooks has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Artyom Lukianov has uploaded a new change for review.
Change subject: hooks:checkips: add checkips hook
..
hooks:checkips: add checkips hook
Give possibilty to check connectivity between host and given addresses.
Update network stats with state of addresses.
Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Signed-off-by: Lukianov Artyom
---
M configure.ac
M vdsm_hooks/Makefile.am
A vdsm_hooks/checkips/Makefile.am
A vdsm_hooks/checkips/README
A vdsm_hooks/checkips/after_get_stats.py
5 files changed, 177 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/54102/1
diff --git a/configure.ac b/configure.ac
index 51cc514..d3c5282 100644
--- a/configure.ac
+++ b/configure.ac
@@ -380,6 +380,7 @@
vdsm/virt/vmdevices/Makefile
vdsm_hooks/Makefile
vdsm_hooks/allocate_net/Makefile
+ vdsm_hooks/checkips/Makefile
vdsm_hooks/checkimages/Makefile
vdsm_hooks/diskunmap/Makefile
vdsm_hooks/ethtool_options/Makefile
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index d23fb1c..478fcd3 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -35,6 +35,7 @@
if HOOKS
SUBDIRS += \
allocate_net \
+ checkips \
checkimages \
diskunmap \
extnet \
diff --git a/vdsm_hooks/checkips/Makefile.am b/vdsm_hooks/checkips/Makefile.am
new file mode 100644
index 000..0ec1cbf
--- /dev/null
+++ b/vdsm_hooks/checkips/Makefile.am
@@ -0,0 +1,30 @@
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+#
+EXTRA_DIST = \
+ after_get_stats.py
+
+install-data-local:
+ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_get_stats
+ $(INSTALL_SCRIPT) $(srcdir)/after_get_stats.py \
+ $(DESTDIR)$(vdsmhooksdir)/after_get_stats/10_checkips
+
+uninstall-local:
+ $(RM) $(DESTDIR)$(vdsmhooksdir)/after_get_stats/10_checkips
diff --git a/vdsm_hooks/checkips/README b/vdsm_hooks/checkips/README
new file mode 100644
index 000..5a68b20
--- /dev/null
+++ b/vdsm_hooks/checkips/README
@@ -0,0 +1,6 @@
+check_ips vdsm hook
+=
+This hook check connectivity from host to given addresses
+
+This hook is useful in cases where you need to check connectivity from host to
+specific vlan, before you start vm on it.
diff --git a/vdsm_hooks/checkips/after_get_stats.py
b/vdsm_hooks/checkips/after_get_stats.py
new file mode 100644
index 000..586718a
--- /dev/null
+++ b/vdsm_hooks/checkips/after_get_stats.py
@@ -0,0 +1,139 @@
+#!/usr/bin/env python
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+import os
+import sys
+import socket
+import hooking
+import traceback
+
+CHECK_IPS = 'checkips'
+HELP_ARG = "-h"
+TEST_ARG = "-t"
+HELP_TEXT = """usage: %(prog)s [%(help)s] [%(test)s]
+
+Check connectivity from host to specific address via ping
+
+optional arguments:
+ %(help)s show this help message and exit
+ %(test)s run a dry test for the hook
+""" % {
+'help': HELP_ARG,
+'test': TEST_ARG,
+'prog': sys.argv[0]
+}
+
+
+def _parse_addresses():
+return [address for address in os.environ[CHECK_IPS].split(',')]
+
+
+def _is_ipv4_address(address):
+try:
+socket.inet_pton(socket.AF_INET, address)
+except socket.error: # not a valid address
+return False
+return True
+
+
+def _is_address_connective(address):
+ping = 'pin
Change in vdsm[master]: net: api: drop connectivity_check_networks
Petr Horáček has posted comments on this change.
Change subject: net: api: drop connectivity_check_networks
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54070/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 693: return int(options.get('connectivityTimeout',
Line 694:CONNECTIVITY_TIMEOUT_DEFAULT))
Line 695:
Line 696:
Line 697: def _check_connectivity(networks, bondings, options, logger):
> I think we should pass connectivityCheck and connectivityTimeout instead of
Good points! But I would definitely do that in another patch - I'm lazy, it
feels right to have it in a separate patch and I'd like to have this merged
together with the module split ASAP.
Line 698: if utils.tobool(options.get('connectivityCheck', True)):
Line 699: logger.debug('Checking connectivity...')
Line 700: if not _clientSeen(_get_connectivity_timeout(options)):
Line 701: logger.info('Connectivity check failed, rolling back')
--
To view, visit https://gerrit.ovirt.org/54070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbfe2705c7165381a353d7d3effb493a1738631
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: return networks to connectivity check from setup
gerrit-hooks has posted comments on this change. Change subject: net: api: return networks to connectivity check from setup .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/53757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57b557442fe6b2324cda19a8d3917cb8221268a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move netinfo update and save one call
gerrit-hooks has posted comments on this change. Change subject: net: api: move netinfo update and save one call .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/53760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4dd7572986ffee5a2060470d904116d04e80c97 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: return networks to connectivity check from setup
Petr Horáček has abandoned this change. Change subject: net: api: return networks to connectivity check from setup .. Abandoned -- To view, visit https://gerrit.ovirt.org/53757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I57b557442fe6b2324cda19a8d3917cb8221268a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move netinfo update and save one call
Petr Horáček has abandoned this change. Change subject: net: api: move netinfo update and save one call .. Abandoned -- To view, visit https://gerrit.ovirt.org/53760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic4dd7572986ffee5a2060470d904116d04e80c97 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move native linux network handling to a separate m...
gerrit-hooks has posted comments on this change. Change subject: net: api: move native linux network handling to a separate module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move native linux network handling to a separate m...
gerrit-hooks has posted comments on this change. Change subject: net: api: move native linux network handling to a separate module .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move native linux network handling to a separate m...
gerrit-hooks has posted comments on this change. Change subject: net: api: move native linux network handling to a separate module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move native linux network handling to a separate m...
gerrit-hooks has posted comments on this change. Change subject: net: api: move native linux network handling to a separate module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: drop connectivity_check_networks
Edward Haas has posted comments on this change.
Change subject: net: api: drop connectivity_check_networks
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/54070/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 693: return int(options.get('connectivityTimeout',
Line 694:CONNECTIVITY_TIMEOUT_DEFAULT))
Line 695:
Line 696:
Line 697: def _check_connectivity(networks, bondings, options, logger):
I think we should pass connectivityCheck and connectivityTimeout instead of
options.
(not sure if in this patch or not)
On another patch we should pass connectivityCheck and connectivityTimeout
through a new canonize_options() func (like canonize_networks()).
Taking this opportunity to suggest making logger a module level object. Passing
it as an argument to so many functions feels wrong.
Line 698: if utils.tobool(options.get('connectivityCheck', True)):
Line 699: logger.debug('Checking connectivity...')
Line 700: if not _clientSeen(_get_connectivity_timeout(options)):
Line 701: logger.info('Connectivity check failed, rolling back')
--
To view, visit https://gerrit.ovirt.org/54070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bbfe2705c7165381a353d7d3effb493a1738631
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: models: move models to configurators folder
gerrit-hooks has posted comments on this change. Change subject: net: models: move models to configurators folder .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59f9b829e393fbac4bea3e72ed5b5bd6196968fd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: unbreak oper_up
Edward Haas has posted comments on this change. Change subject: ipwrapper: unbreak oper_up .. Patch Set 1: Code-Review+1 I would expect Link class to fully represent the link and 'cache' its status. -- To view, visit https://gerrit.ovirt.org/54054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move native linux network handling to a separate m...
gerrit-hooks has posted comments on this change. Change subject: net: api: move native linux network handling to a separate module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
This is a preparation step for the next round of moving device handling
code out of Vm class. We want to move Vm._getUnderlying* methods out of
Vm, but not all at once. Most of the methods use
_getUnderlyingDeviceAddress() so we need to have this functionality
available in both Vm and the moved code and this is the reason for
having this preparation step.
Change-Id: Ib9868ca1df6650b1262e6f30d639a08b1f38304d
Signed-off-by: Milan Zamazal
---
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
2 files changed, 33 insertions(+), 33 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/53615/5
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c23f710..5833147 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4011,22 +4011,6 @@
self.log.exception("Operation failed")
return response.error(key, msg)
-def _getUnderlyingDeviceAddress(self, devXml, index=0):
-"""
-Obtain device's address from libvirt
-"""
-address = {}
-adrXml = devXml.getElementsByTagName('address')[index]
-# Parse address to create proper dictionary.
-# Libvirt device's address definition is:
-# PCI = {'type':'pci', 'domain':'0x', 'bus':'0x00',
-#'slot':'0x0c', 'function':'0x0'}
-# IDE = {'type':'drive', 'controller':'0', 'bus':'0', 'unit':'0'}
-for key in adrXml.attributes.keys():
-address[key.strip()] = adrXml.getAttribute(key).strip()
-
-return address
-
def _getUnderlyingUnknownDeviceInfo(self):
"""
Obtain unknown devices info from libvirt.
@@ -4048,7 +4032,7 @@
alias = x.getElementsByTagName('alias')[0].getAttribute('name')
if not isKnownDevice(alias):
-address = self._getUnderlyingDeviceAddress(x)
+address = vmxml.device_address(x)
# I general case we assume that device has attribute 'type',
# if it hasn't getAttribute returns ''.
device = x.getAttribute('type')
@@ -4073,7 +4057,7 @@
index = x.getAttribute('index')
# Get controller address
-address = self._getUnderlyingDeviceAddress(x)
+address = vmxml.device_address(x)
# In case the controller has index and/or model, they
# are compared. Currently relevant for USB controllers.
@@ -4112,7 +4096,7 @@
if not x.getElementsByTagName('address'):
address = None
else:
-address = self._getUnderlyingDeviceAddress(x)
+address = vmxml.device_address(x)
alias = x.getElementsByTagName('alias')[0].getAttribute('name')
for dev in self._devices[hwclass.BALLOON]:
@@ -4152,7 +4136,7 @@
if not x.getElementsByTagName('address'):
continue
-address = self._getUnderlyingDeviceAddress(x)
+address = vmxml.device_address(x)
alias = x.getElementsByTagName('alias')[0].getAttribute('name')
for dev in self._devices[hwclass.SMARTCARD]:
@@ -4171,7 +4155,7 @@
Obtain rng device info from libvirt.
"""
for rng in self._domain.get_device_elements('rng'):
-address = self._getUnderlyingDeviceAddress(rng)
+address = vmxml.device_address(rng)
alias = rng.getElementsByTagName('alias')[0].getAttribute('name')
source = rng.getElementsByTagName('backend')[0].firstChild.\
nodeValue
@@ -4193,7 +4177,7 @@
def _getUnderlyingHostDeviceUSBInfo(self, x):
alias = x.getElementsByTagName('alias')[0].getAttribute('name')
-address = self._getUnderlyingDeviceAddress(x)
+address = vmxml.device_address(x)
# The routine is quite unusual because we cannot directly reconstruct
# the unique name. Therefore, we first look up correspondoing device
@@ -4222,16 +4206,16 @@
self._getUnderlyingHostDeviceUSBInfo(x)
continue
alias = x.getElementsByTagName('alias')[0].getAttribute('name')
-address = self._getUnderlyingDeviceAddress(x)
+address = vmxml.device_address(x)
source = x.getElementsByTagName('source')[0]
device = hostdev.pci_address_to_name(
-**self._getUnderlyingDeviceAddress(source))
+**vmxml.device_address(source))
# We can assume the device name to be correct since we're
# inspecting source element. For the address, we may look at
# both addresses and determine the correct one.
if (hostdev.pci_address_to_name(**address) ==
Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50d160317f91db92bb6a8ae22a45d9574d1434b3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53679/1/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: Line 792: underlying_devices_info > this is probably the only bit which really belongs to __init__.py. Yes, fixed by moving it to a new file vmdevices/common.py. -- To view, visit https://gerrit.ovirt.org/53679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/53618/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1563: self.conf['memSize'] = domain.get_memory_size() > probably this change alone deserves a patch on its own No longer needed as we pass whole `vm' to the moved method now. So I discarded this piece of change. -- To view, visit https://gerrit.ovirt.org/53618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d627a50c1ed52c584a834fb2f9066ac1ab6ac68 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm
Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm .. Patch Set 7: Yes, the methods should be generalized, yes, only after the move. I split the patch to one patch per device class. -- To view, visit https://gerrit.ovirt.org/53617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b742e181eb56db6ccf19a3ab162349be96853e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm
Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm .. Patch Set 2: underlying* methods renamed, docstring moved to a base method. @classmethod retained. -- To view, visit https://gerrit.ovirt.org/53616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05cb24e0a9776e21bd2546d62a56554d74559c61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move legacy sound conf from Vm to vmdevices
gerrit-hooks has posted comments on this change. Change subject: virt: Move legacy sound conf from Vm to vmdevices .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5076938905fd39ecf5eed81500744c9a1547698 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move graphics legacy conf processing out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move graphics legacy conf processing out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6dbaa9aceae1c4b6da4bd81598873fac261cfc0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move controller legacy conf out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move controller legacy conf out of Vm .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9135e6524fe2566d1cf2c3cc4664fefe18995635 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Storage device legacy conf processing moved out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Storage device legacy conf processing moved out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36ccbeabf86ccb2db5f2135244e2699f43d7a495 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingWatchdogDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingWatchdogDeviceInfo() out of Vm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54094 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b799ab2177828ded9b4e670f48bbecdf055c281 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move video legacy conf out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move video legacy conf out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2794d85a2508500ad1b9004bd502652f0cc71e39 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move network legacy conf processing out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move network legacy conf processing out of Vm .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I189d0f7d86fb1e8d54adc96450fd0f92be4dd5c1 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08d8e96657299f9730741fb5e97d4cfb9dfce28a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4a8c14da22db5fd1091dde0f6e9c4d3a2dd8b40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d627a50c1ed52c584a834fb2f9066ac1ab6ac68 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04cbe440e7301021878aed6905443cf7326c798d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50d160317f91db92bb6a8ae22a45d9574d1434b3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3658e0ddc79721fb9f52b7d03464fcc3b74e540 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b742e181eb56db6ccf19a3ab162349be96853e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move graphics legacy conf processing out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move graphics legacy conf processing out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6dbaa9aceae1c4b6da4bd81598873fac261cfc0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move video legacy conf out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move video legacy conf out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2794d85a2508500ad1b9004bd502652f0cc71e39 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Storage device legacy conf processing moved out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Storage device legacy conf processing moved out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36ccbeabf86ccb2db5f2135244e2699f43d7a495 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move legacy sound conf from Vm to vmdevices
gerrit-hooks has posted comments on this change. Change subject: virt: Move legacy sound conf from Vm to vmdevices .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5076938905fd39ecf5eed81500744c9a1547698 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move controller legacy conf out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move controller legacy conf out of Vm .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9135e6524fe2566d1cf2c3cc4664fefe18995635 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move network legacy conf processing out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move network legacy conf processing out of Vm .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I189d0f7d86fb1e8d54adc96450fd0f92be4dd5c1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04cbe440e7301021878aed6905443cf7326c798d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d627a50c1ed52c584a834fb2f9066ac1ab6ac68 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08d8e96657299f9730741fb5e97d4cfb9dfce28a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: New method Vm.get_devices
gerrit-hooks has posted comments on this change. Change subject: virt: New method Vm.get_devices .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a7c32806501df8672718c588b2f62087ff4e085 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingVideoDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingVideoDeviceInfo() out of Vm .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eca5c6fa4931b81fcde23fe24ac8c94efc8693c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3658e0ddc79721fb9f52b7d03464fcc3b74e540 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4a8c14da22db5fd1091dde0f6e9c4d3a2dd8b40 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
