Change in vdsm[master]: tests: fix integration tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: fix integration tests
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/55871/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-04-08 16:05:24 +0200
Line 4: Commit: pkliczewski 
Line 5: CommitDate: 2016-04-08 16:05:24 +0200
Line 6: 
Line 7: tests: fix integration tests
explain .. what is this dispatch method?
Line 8: 
Line 9: 
Line 10: Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd


-- 
To view, visit https://gerrit.ovirt.org/55871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: monitoring: Port vdsm.storage.check to python 3
..


Patch Set 2:

although, it could be done directly in the initial check module introduction 
patch (https://gerrit.ovirt.org/#/c/54757/34)..

-- 
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: monitoring: Port vdsm.storage.check to python 3
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: move rget to utils

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: move rget to utils
..


Patch Set 2: Code-Review-1

where is the remove part of the move?

-- 
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93ae32e5ffbfa20a79081aea330e3df3663c3966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schedule: Port schedule module to Python 3

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: schedule: Port schedule module to Python 3
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d20fe1a1d262d5489be5bedba929709fa59e35
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm arch specific package

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Make vdsm arch specific package
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/42490/5/vdsm.spec.in
File vdsm.spec.in:

Line 45: %global _udevrulesdir /usr/lib/udev/rules.d/
Line 46: %global _udevexecdir /usr/lib/udev/
Line 47: 
Line 48: # Disable debuginfo package, since vdsm is a meta-package
Line 49: %global debug_package %{nil}
does it disable it only to main package or to all sub packages as well?
Line 50: 
Line 51: Name:   %{vdsm_name}
Line 52: Version:@PACKAGE_VERSION@
Line 53: Release:@PACKAGE_RELEASE@%{?dist}%{?extra_release}


-- 
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Move vdsm package contents to vdsm-deamon

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Move vdsm package contents to vdsm-deamon
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/42491/7/vdsm.spec.in
File vdsm.spec.in:

Line 255: Requires: genisoimage
Line 256: Requires: libselinux-python
Line 257: 
Line 258: # Vdsm required sub packages
Line 259: Requires: %{name}-daemon = %{version}-%{release}
main package should require only vdsm-daemon as well
Line 260: Requires: %{name}-hook-vmfex-dev = %{version}-%{release}
Line 261: Requires: %{name}-infra = %{version}-%{release}
Line 262: Requires: %{name}-jsonrpc = %{version}-%{release}
Line 263: Requires: %{name}-python = %{version}-%{release}


-- 
To view, visit https://gerrit.ovirt.org/42491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58b0b0e7461f9ac10a189dd8ca6715d02183ad21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nelly Credi 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cache: Add caching decorator with invalidation

[nsoffer]

Nir Soffer has restored this change.

Change subject: cache: Add caching decorator with invalidation
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Memoize _supports_qcow2_compat

[nsoffer]

Nir Soffer has restored this change.

Change subject: qemuimg: Memoize _supports_qcow2_compat
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/34711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ic63f5e8c06993df8e4066bf7ac2dabfb4b4bdbfb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()

[nsoffer]

Nir Soffer has restored this change.

Change subject: cache: Replace utils.memoized with cache.memoized()
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/34710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I12e2f2919cf92ff7d0758d70e2ed40523d66174f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: scsi: Scan only the required domain type

[nsoffer]

Nir Soffer has restored this change.

Change subject: scsi: Scan only the required domain type
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdc: Rename method to make it less confusing

[nsoffer]

Nir Soffer has restored this change.

Change subject: sdc: Rename method to make it less confusing
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/47916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I2c67ae0ddc98857e406fec62be0cbcf817213236
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysprep hook: unconfigure a vm clone

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: sysprep hook: unconfigure a vm clone
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/26886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I447a4b01b86b17289030b71264d5d4218c2aa1e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: simplify getNetworksAndVlansForIface

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: netinfo: simplify getNetworksAndVlansForIface
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/46765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib2718e1a1d2799edbd9ad91d42f90c2c9c3d9397
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/45095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: use a Link object in vlanSpeed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfo: use a Link object in vlanSpeed
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/46770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I347fbc6b361cf95a8115c32cdec364c6c7b53692
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: prepareForShutdown - operations order

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: hsm: prepareForShutdown - operations order
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/36162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9edd84317b08a17db80e265053edaf69582c2a51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Memoize _supports_qcow2_compat

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Memoize _supports_qcow2_compat
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/34711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic63f5e8c06993df8e4066bf7ac2dabfb4b4bdbfb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: prepareForShutdown - operations order

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: prepareForShutdown - operations order
..


Patch Set 5:

* #1161934::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/36162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9edd84317b08a17db80e265053edaf69582c2a51
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/45112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdc: Rename method to make it less confusing

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: sdc: Rename method to make it less confusing
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/47916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2c67ae0ddc98857e406fec62be0cbcf817213236
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cache: Replace utils.memoized with cache.memoized()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/34710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12e2f2919cf92ff7d0758d70e2ed40523d66174f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/14237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Guglielmi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Memoize _supports_qcow2_compat

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: qemuimg: Memoize _supports_qcow2_compat
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/34711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic63f5e8c06993df8e4066bf7ac2dabfb4b4bdbfb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/14237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Guglielmi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: simplify getNetworksAndVlansForIface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: netinfo: simplify getNetworksAndVlansForIface
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/46765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2718e1a1d2799edbd9ad91d42f90c2c9c3d9397
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: use a Link object in vlanSpeed

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: netinfo: use a Link object in vlanSpeed
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/46770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I347fbc6b361cf95a8115c32cdec364c6c7b53692
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: configfile: remove no longer used methods.  vdsm is no 
longer involved in libvirt log rotation since 33925 and  we can remove 
prefixLines and prependSection.
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/36324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-Reviewer: mooli tayer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdc: Rename method to make it less confusing

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdc: Rename method to make it less confusing
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/47916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c67ae0ddc98857e406fec62be0cbcf817213236
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysprep hook: unconfigure a vm clone

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sysprep hook: unconfigure a vm clone
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/26886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447a4b01b86b17289030b71264d5d4218c2aa1e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: scsi: Scan only the required domain type

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: scsi: Scan only the required domain type
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cache: Add caching decorator with invalidation

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: cache: Add caching decorator with invalidation
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: scsi: Scan only the required domain type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: scsi: Scan only the required domain type
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cache: Add caching decorator with invalidation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cache: Add caching decorator with invalidation
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd8fb29d94286e3e3a3e29b8218501cbdc5c018
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vitor de Lima 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: cache: Replace utils.memoized with cache.memoized()
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/34710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I12e2f2919cf92ff7d0758d70e2ed40523d66174f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configfile: remove no longer used methods.  vdsm is no 
longer involved in libvirt log rotation since 33925 and  we can remove 
prefixLines and prependSection.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/36324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: Prettify netinfo_test mocks

[edwardh]

Edward Haas has posted comments on this change.

Change subject: test: Prettify netinfo_test mocks
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85b89eae71366f7cf3a331b54635483bb5cf9f51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]: ovs switch skeleton

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]: ovs switch skeleton
..


Patch Set 10:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056fcf8c0d36625328a90a339d4a09658683056
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2]: split ovs and legacy networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [2]: split ovs and legacy networks
..


Patch Set 6:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/55309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib78057445c38da542450b4ab8d79ea049a9c17f1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2]: split ovs and legacy networks

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: native ovs [2]: split ovs and legacy networks
..


Abandoned

rget moved elsewhere, is_ovs_* is not needed with canonicalization

-- 
To view, visit https://gerrit.ovirt.org/55309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib78057445c38da542450b4ab8d79ea049a9c17f1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]: ovs switch skeleton

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]: ovs switch skeleton
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic056fcf8c0d36625328a90a339d4a09658683056
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example

[automation]

gerrit-hooks has posted comments on this change.

Change subject: test: Replacing MonkeyPatch with mock.patch example
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55603
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: Prettify netinfo_test mocks

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: test: Prettify netinfo_test mocks
..

test: Prettify netinfo_test mocks

Change-Id: I85b89eae71366f7cf3a331b54635483bb5cf9f51
Signed-off-by: Edward Haas 
---
M tests/network/netinfo_test.py
1 file changed, 74 insertions(+), 75 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/55900/1

diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index 5ee8012..7b1ef15 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -60,13 +60,12 @@
 with namedTemporaryDir() as temp_dir:
 file_path = os.path.join(temp_dir, 'resolv.conf')
 
-for content in (RESOLV_CONF, RESOLV_CONF + '\n'):
-with mock.patch('vdsm.netinfo.dns.DNS_CONF_FILE', file_path):
+with mock.patch('vdsm.netinfo.dns.DNS_CONF_FILE', file_path):
+for content in (RESOLV_CONF, RESOLV_CONF + '\n'):
 with open(file_path, 'w') as file_object:
 file_object.write(content)
 
-self.assertEqual(
-dns.get_host_nameservers(), dnss)
+self.assertEqual(dns.get_host_nameservers(), dnss)
 
 def testNetmaskConversions(self):
 path = os.path.join(os.path.dirname(__file__), "netmaskconversions")
@@ -90,7 +89,9 @@
 self.assertFalse(s < 0)
 self.assertTrue(s in ETHTOOL_SPEEDS or s == 0)
 
-def testValidNicSpeed(self):
+@mock.patch('vdsm.netinfo.nics.operstate')
+@mock.patch('vdsm.netinfo.nics.io.open')
+def testValidNicSpeed(self, mock_io_open, mock_operstate):
 values = ((0,   nics.OPERSTATE_UP, 0),
   (-10, nics.OPERSTATE_UP, 0),
   (2 ** 16 - 1, nics.OPERSTATE_UP, 0),
@@ -101,11 +102,10 @@
   (123, 'unknown',0))
 
 for passed, operstate, expected in values:
-with mock.patch('vdsm.netinfo.nics.io.open',
-lambda x: io.BytesIO(str(passed))), \
-mock.patch('vdsm.netinfo.nics.operstate',
-   lambda x: operstate):
-self.assertEqual(nics.speed('fake_nic'), expected)
+mock_io_open.return_value = io.BytesIO(str(passed))
+mock_operstate.return_value = operstate
+
+self.assertEqual(nics.speed('fake_nic'), expected)
 
 @mock.patch('vdsm.netinfo.cache.netinfo.networks',
 lambda: {'fake': {'bridged': True}})
@@ -115,9 +115,9 @@
 # it should.
 get()
 
-@mock.patch('vdsm.netinfo.cache.getLinks', lambda: [])
-@mock.patch('vdsm.netinfo.cache.netinfo.networks', lambda: {})
-def testGetEmpty(self):
+@mock.patch('vdsm.netinfo.cache.getLinks')
+@mock.patch('vdsm.netinfo.cache.netinfo.networks')
+def testGetEmpty(self, mock_networks, mock_getLinks):
 result = {}
 result.update(get())
 self.assertEqual(result['networks'], {})
@@ -142,78 +142,77 @@
 addr['label'],
 addresses.getDeviceByIP(addr['address'].split('/')[0]))
 
-def _testNics(self):
-"""Creates a test fixture so that nics() reports:
-physical nics: em, me, me0, me1, hid0 and hideous
-dummies: fake and fake0
-bonds: jbond (over me0 and me1)"""
-return [ipwrapper.Link(address='f0:de:f1:da:aa:e7', index=2,
-   linkType=ipwrapper.LinkType.NIC, mtu=1500,
-   name='em', qdisc='pfifo_fast', state='up'),
-ipwrapper.Link(address='ff:de:f1:da:aa:e7', index=3,
-   linkType=ipwrapper.LinkType.NIC, mtu=1500,
-   name='me', qdisc='pfifo_fast', state='up'),
-ipwrapper.Link(address='ff:de:fa:da:aa:e7', index=4,
-   linkType=ipwrapper.LinkType.NIC, mtu=1500,
-   name='hid0', qdisc='pfifo_fast', state='up'),
-ipwrapper.Link(address='ff:de:11:da:aa:e7', index=5,
-   linkType=ipwrapper.LinkType.NIC, mtu=1500,
-   name='hideous', qdisc='pfifo_fast', state='up'),
-ipwrapper.Link(address='66:de:f1:da:aa:e7', index=6,
-   linkType=ipwrapper.LinkType.NIC, mtu=1500,
-   name='me0', qdisc='pfifo_fast', state='up',
-   master='jbond'),
-ipwrapper.Link(address='66:de:f1:da:aa:e7', index=7,
-   linkType=ipwrapper.LinkType.NIC, mtu=1500,
-   name='me1', qdisc='pfifo_fast', state='up',
-   master='jbond'),
-

Change in vdsm[master]: test: Prettify netinfo_test mocks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: test: Prettify netinfo_test mocks
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85b89eae71366f7cf3a331b54635483bb5cf9f51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: port test models_test.py to python 3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: port test models_test.py to python 3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib72655a50f0a85fcb25fb895b8b12056bf618b7f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lihi Wishnitzer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: report network iface expeted by engine

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hook: ovs: report network iface expeted by engine
..


Patch Set 1:

if you won't mind, i'd use your code with native, but now let's do it stupid 
(and have less work with backporting)

-- 
To view, visit https://gerrit.ovirt.org/55892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9825ed7861d7baf68d78b00559909e8a30aad53f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hook: ovs: report ip info on expected top device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: ovs: report ip info on expected top device
..


Patch Set 3: Verified-1

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/55895
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f124c303a00e7829cb30c51e505c6bcf158cea3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: report ip info on expected top device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: ovs: report ip info on expected top device
..


Patch Set 3:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f124c303a00e7829cb30c51e505c6bcf158cea3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: report ip info on expected top device

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hook: ovs: report ip info on expected top device
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/55893/2/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 176: ovs_bonding_caps[bonding] = net_info
Line 177: return ovs_bonding_caps
Line 178: 
Line 179: 
Line 180: def update_expected_ip_info(caps, running_config):
> as a helper function, please name it with a leading underscore.
Done
Line 181: """
Line 182: If a network is marked as bridgeless and untagged, we have to 
report its IP
Line 183: info on attached nic/bond.
Line 184: """


PS2, Line 187: keys
> KEYS
Done


Line 190: destination[key] = source[key]
Line 191: 
Line 192: for network, attrs in iter_ovs_nets(running_config.networks):
Line 193: if not attrs.get('bridged', True) and 'vlan' not in attrs:
Line 194: bond = attrs.get('bond')
> reminds me a bit of get_engine_expected_top_dev logic...
yup, but here we need type of the device. we can create a function which would 
return both, but i'd prefer to do some stupid scripting and get back to native 
ovs.
Line 195: nic = attrs.get('nic')
Line 196: if bond is not None:
Line 197: copy_net_info(
Line 198: caps['networks'][network], caps['bondings'][bond])


-- 
To view, visit https://gerrit.ovirt.org/55893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f124c303a00e7829cb30c51e505c6bcf158cea3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: find toplevel iterface name based on net attributes

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: find toplevel iterface name based on net attributes
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb6ec043091eed6b3b0d8b3b66924aed66af3e12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: find toplevel iterface name based on net attributes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: find toplevel iterface name based on net attributes
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb6ec043091eed6b3b0d8b3b66924aed66af3e12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..

net tests: Clean netinfo_test from uneeded mocks

Removing mockey patches that are no longer needed.

They have been probably left in the tests unintentionally after the
production code have been modified.
This presents a general maintanance issue with mocks that do not varify
their usage.

Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Signed-off-by: Edward Haas 
---
M tests/network/netinfo_test.py
1 file changed, 0 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/55898/1

diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index c8395dd..5f75f8c 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -81,14 +81,10 @@
 self.assertRaises(ValueError, addresses.prefix2netmask, -1)
 self.assertRaises(ValueError, addresses.prefix2netmask, 33)
 
-@MonkeyPatch(ipwrapper.Link, '_detectType',
- partial(_fakeTypeDetection, ipwrapper.Link))
 def testSpeedInvalidNic(self):
 nicName = '0' * 20  # devices can't have so long names
 self.assertEqual(nics.speed(nicName), 0)
 
-@MonkeyPatch(ipwrapper.Link, '_detectType',
- partial(_fakeTypeDetection, ipwrapper.Link))
 def testSpeedInRange(self):
 for d in nics.nics():
 s = nics.speed(d)
@@ -112,10 +108,7 @@
 lambda x: operstate)]):
 self.assertEqual(nics.speed('fake_nic'), expected)
 
-@MonkeyPatch(ipwrapper.Link, '_detectType',
- partial(_fakeTypeDetection, ipwrapper.Link))
 @MonkeyPatch(netinfo, 'networks', lambda: {'fake': {'bridged': True}})
-@MonkeyPatch(bonding, '_getBondingOptions', lambda x: {})
 def testGetNonExistantBridgeInfo(self):
 # Getting info of non existing bridge should not raise an exception,
 # just log a traceback. If it raises an exception the test will fail as
@@ -270,20 +263,12 @@
 finally:
 bonds.write('-' + bondName)
 
-@MonkeyPatch(bonding, 'BONDING_NAME2NUMERIC_PATH',
- bonding.BONDING_NAME2NUMERIC_PATH
- if os.path.exists(bonding.BONDING_NAME2NUMERIC_PATH)
- else '../vdsm/bonding-name2numeric.json')
 def test_get_bonding_option_numeric_val_exists(self):
 mode_num = bonding.BONDING_MODES_NAME_TO_NUMBER["balance-rr"]
 self.assertNotEqual(bonding.get_bonding_option_numeric_val(
 mode_num, "ad_select", "stable"),
 None)
 
-@MonkeyPatch(bonding, 'BONDING_NAME2NUMERIC_PATH',
- bonding.BONDING_NAME2NUMERIC_PATH
- if os.path.exists(bonding.BONDING_NAME2NUMERIC_PATH)
- else '../vdsm/bonding-name2numeric.json')
 def test_get_bonding_option_numeric_val_does_not_exists(self):
 mode_num = bonding.BONDING_MODES_NAME_TO_NUMBER["balance-rr"]
 self.assertEqual(bonding.get_bonding_option_numeric_val(


-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Clean netinfo_test from uneeded mocks
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9e1f4dc160fb24233ea260d7f897df9abb4c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: persist bonding 'switch' parameter

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: persist bonding 'switch' parameter
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica95fc047c7338f5745f490cd262f016d193562d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Fix FakeLVM lv creation size

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Fix FakeLVM lv creation size
..


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/55888/1/tests/storagetestlib.py
File tests/storagetestlib.py:

Line 28: 
Line 29: 
Line 30: NR_PVS = 2   # The number of fake PVs we use to make a fake VG by 
default
Line 31: MDSIZE = 524288  # The size (in bytes) of fake metadata files
Line 32: MB = 1048576 # Used to convert bytes to MB
:-)

I would use the more clear 1024 * 1024 or 1024**2
Line 33: 
Line 34: 
Line 35: class FakeEnv(object):
Line 36: def __init__(self, sd_manifest, lvm=None):


Line 156: sduuid = sd_manifest.sdUUID
Line 157: image_manifest = image.ImageManifest(sd_manifest.getRepoPath())
Line 158: imagedir = image_manifest.getImageDir(sduuid, imguuid)
Line 159: os.makedirs(imagedir)
Line 160: size_mb = (size + MB - 1) / MB
Use utils.round
Line 161: lvm.createLV(sduuid, voluuid, size_mb)
Line 162: with sd_manifest.acquireVolumeMetadataSlot(
Line 163: voluuid, blockVolume.VOLUME_MDNUMBLKS) as slot:
Line 164: lvm.addtag(sduuid, voluuid, "%s%s" % 
(blockVolume.TAG_PREFIX_MD, slot))


Line 172: (sduuid, slot),
Line 173: sduuid,
Line 174: imguuid,
Line 175: parent_vol_id,
Line 176: size_mb * MB / volume.BLOCK_SIZE,
Lets make this more clear by adding an explaining variable:

size_blk = size_mb * MB / volume.BLOCK_SIZE

and use this variable in the call.
Line 177: volume.type2name(vol_format),
Line 178: volume.type2name(prealloc),
Line 179: volume.type2name(volume.LEAF_VOL),
Line 180: disk_type,


-- 
To view, visit https://gerrit.ovirt.org/55888
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I975b35d4e386e23e3b58ede6314939f1ad293619
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: convert 'bridge' attr to boolean

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: convert 'bridge' attr to boolean
..


Patch Set 2: Verified+1

Caps handling is working now.

-- 
To view, visit https://gerrit.ovirt.org/55890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09eb7c92a2952e18828a3f0f9887b1b2c5457c91
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: convert 'bridge' attr to boolean

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: convert 'bridge' attr to boolean
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55890/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

PS1, Line 26: tobool
> importing from vdsm in hooks is evil. let's do it as little as we can. plea
Done


-- 
To view, visit https://gerrit.ovirt.org/55890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09eb7c92a2952e18828a3f0f9887b1b2c5457c91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: convert 'bridge' attr to boolean

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: convert 'bridge' attr to boolean
..


Patch Set 2: Verified-1

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09eb7c92a2952e18828a3f0f9887b1b2c5457c91
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Create block metadata file with correct size

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Create block metadata file with correct size
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/55887/1/tests/storagetestlib.py
File tests/storagetestlib.py:

Line 90: 
Line 91: # Create the metadata LV for storing volume metadata
Line 92: metafile_path = fake_lvm.lvPath(sduuid, sd.METADATA)
Line 93: make_file(metafile_path,
Line 94:   blockSD.BlockStorageDomainManifest.metaSize(sduuid) * MB)
For another patch, we must rename the methods returning size in sectors so it 
is clear that they return number of sectors, or change them to return bytes.
Line 95: 
Line 96: # Create the rest of the special LVs
Line 97: for metafile, sizemb in sd.SPECIAL_VOLUME_SIZES_MIB.iteritems():
Line 98: fake_lvm.createLV(sduuid, metafile, sizemb)


-- 
To view, visit https://gerrit.ovirt.org/55887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfd1459022d69e4d4fec6ab443adca37e570a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use VG tags to store fake block domain md

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Use VG tags to store fake block domain md
..


Patch Set 3: Code-Review-1

(1 comment)

Need to assert about the domain version.

https://gerrit.ovirt.org/#/c/55705/3/tests/storagetestlib.py
File tests/storagetestlib.py:

Line 96: # Create the rest of the special LVs
Line 97: for metafile, sizemb in sd.SPECIAL_VOLUME_SIZES_MIB.iteritems():
Line 98: fake_lvm.createLV(sduuid, metafile, sizemb)
Line 99: 
Line 100: # We'll store the domain metadata in the VG's tags
This method is used when creating newer domains, lest make sure that the 
version of this domain is correct, and that you cannot create fake domain with 
old version (assert about the version).
Line 101: metadata = blockSD.TagBasedSDMetadata(sduuid)
Line 102: metadata.update(make_sd_metadata(sduuid))
Line 103: 
Line 104: manifest = blockSD.BlockStorageDomainManifest(sduuid, metadata)


-- 
To view, visit https://gerrit.ovirt.org/55705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ecba0eba2375f2ce971b9951e35202093c83c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: storagetestlib: Set fake block domain mountpoint

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: storagetestlib: Set fake block domain mountpoint
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icebd6a317b2044cebbee937ee26ed89252833c7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Create fake block volume metadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Create fake block volume metadata
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be6abe9cc8217f9b825a45051dd40a4f86717f4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Test storagetestlib FakeEnv functions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Test storagetestlib FakeEnv functions
..


Patch Set 1: Code-Review-1

(9 comments)

Nice!

https://gerrit.ovirt.org/#/c/55889/1/tests/storagetestlibTests.py
File tests/storagetestlibTests.py:

Line 65: with fake_file_env() as env:
Line 66: set_domain_metaparams(env.sd_manifest,
Line 67:   {sd.DMDK_DESCRIPTION: 'foo'})
Line 68: self.assertEqual('foo',
Line 69:  
env.sd_manifest.getMetaParam(sd.DMDK_DESCRIPTION))
I'm not sure what do you test here - is this related to the fake env?
Line 70: 
Line 71: # Test that metadata is persisted to our temporary storage 
area
Line 72: domain_dir = env.sd_manifest.domaindir
Line 73: manifest = fileSD.FileStorageDomainManifest(domain_dir)


Line 70: 
Line 71: # Test that metadata is persisted to our temporary storage 
area
Line 72: domain_dir = env.sd_manifest.domaindir
Line 73: manifest = fileSD.FileStorageDomainManifest(domain_dir)
Line 74: self.assertEqual('foo', 
manifest.getMetaParam(sd.DMDK_DESCRIPTION))
Do you want to test that our fake domain looks like a real domain?
Line 75: 
Line 76: def test_volume_metadata_io(self):
Line 77: with fake_file_env() as env:
Line 78: size = 1 * MB


Line 78: size = 1 * MB
Line 79: img_id, vol_id = 
make_file_volume(env.sd_manifest.domaindir, size)
Line 80: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 81: vol.setDescription('foo')
Line 82: self.assertEqual('foo', vol.getDescription())
Why do we need this assert? we are not testing the storage domain manifest here.
Line 83: 
Line 84: # Test that metadata is persisted to our temporary storage 
area
Line 85: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 86: self.assertEqual('foo', vol.getDescription())


Line 82: self.assertEqual('foo', vol.getDescription())
Line 83: 
Line 84: # Test that metadata is persisted to our temporary storage 
area
Line 85: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 86: self.assertEqual('foo', vol.getDescription())
I would be nice to use a constant for 'foo', same for the previous test.
Line 87: 
Line 88: 
Line 89: class FakeBlockEnvTests(VdsmTestCase):
Line 90: 


Line 98: md_path = env.lvm.lvPath(vg_name, sd.METADATA)
Line 99: self.assertTrue(os.path.exists(md_path))
Line 100: 
Line 101: # Check that the domain's special LVs can be found via LVM
Line 102: special_lvs = sd.SPECIAL_VOLUME_SIZES_MIB.keys() + 
[sd.METADATA]
Unneeded
Line 103: for lv in special_lvs:
Line 104: self.assertEqual(lv, env.lvm.getLV(vg_name, lv).name)
Line 105: 
Line 106: images_dir = os.path.join(env.sd_manifest.domaindir, 
vg_name,


Line 99: self.assertTrue(os.path.exists(md_path))
Line 100: 
Line 101: # Check that the domain's special LVs can be found via LVM
Line 102: special_lvs = sd.SPECIAL_VOLUME_SIZES_MIB.keys() + 
[sd.METADATA]
Line 103: for lv in special_lvs:
for lv in blockSD.SPECIAL_LVS:
Line 104: self.assertEqual(lv, env.lvm.getLV(vg_name, lv).name)
Line 105: 
Line 106: images_dir = os.path.join(env.sd_manifest.domaindir, 
vg_name,
Line 107:   sd.DOMAIN_IMAGES)


Line 118: self.assertEqual(vol_id, env.lvm.getLV(sd_id, 
vol_id).name)
Line 119: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 120: self.assertEqual(size / volume.BLOCK_SIZE, vol.getSize())
Line 121: vol.setDescription('foo')
Line 122: self.assertEqual('foo', vol.getDescription())
This test the volume class, we don't need to test it here.
Line 123: 
Line 124: # Test that metadata is persisted to our temporary 
storage area
Line 125: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 126: self.assertEqual('foo', vol.getDescription())


Line 122: self.assertEqual('foo', vol.getDescription())
Line 123: 
Line 124: # Test that metadata is persisted to our temporary 
storage area
Line 125: vol = env.sd_manifest.produceVolume(img_id, vol_id)
Line 126: self.assertEqual('foo', vol.getDescription())
Use constant for 'foo'
Line 127: 
Line 128: def test_domain_metadata_io(self):
Line 129: with fake_block_env() as env:
Line 130: set_domain_metaparams(env.sd_manifest,


Line 129: with fake_block_env() as env:
Line 130: set_domain_metaparams(env.sd_manifest,
Line 131:   

Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: disconnectStorageServer verb
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix a bad value in KSM test

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix a bad value in KSM test
..


Fix a bad value in KSM test

The merge across nodes allows only 0,1,2,3 values.

Change-Id: I31b68eb60c5df43995cd0297548b44d8221e2908
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/55691
Reviewed-by: Yaniv Bronhaim 
Continuous-Integration: Jenkins CI
Tested-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M tests/functional/supervdsmFuncTests.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31b68eb60c5df43995cd0297548b44d8221e2908
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix a bad value in KSM test

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix a bad value in KSM test
..


Patch Set 1: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31b68eb60c5df43995cd0297548b44d8221e2908
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix a bad value in KSM test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Fix a bad value in KSM test
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31b68eb60c5df43995cd0297548b44d8221e2908
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lvm: Remove args hack for activateLVs and deactivateLVs

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f23f5b21217373bd79abdcfe3d4f8cf233b9e90
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: set OVS devices UP

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: set OVS devices UP

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
..


Patch Set 2:

I utterly forgot about this one!

-- 
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeVGTags support

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: FakeLVM: Add changeVGTags support
..


FakeLVM: Add changeVGTags support

changeVGTags support is needed to properly emulate tag-based block
storage domain metadata.  The functionality works identically to the
changeLVTags function which is already implemented.

Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/55703
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Tested-by: Nir Soffer 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 21 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeVGTags support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: Add changeVGTags support
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 4: Verified+1

Tests pass

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: FakeLVM: Add changeLVTags
..


FakeLVM: Add changeLVTags

The BlockVolumeArtifacts code needs to use changeLVTags during volume
creation.  Since we will want to test that code, add support for
changeLVTags in FakeLVM.

Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/49546
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
Tested-by: Nir Soffer 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeVGTags support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: FakeLVM: Add changeVGTags support
..


Patch Set 3: Verified+1

Tests pass

-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 4: Continuous-Integration+1

Jenkins build succeeded, but for some reason it did not marked this as verified.

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeVGTags support

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: FakeLVM: Add changeVGTags support
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: move rget to utils

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: utils: move rget to utils
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55860/2/tests/utilsTests.py
File tests/utilsTests.py:

Line 341: def test_unique(self, iterable, unique_items):
Line 342: self.assertEquals(utils.unique(iterable,), unique_items)
Line 343: 
Line 344: def test_rget(self):
Line 345: self.assertEqual(
> this assertion would  be more readable if placed in its own method e.g. tes
(It really took me too much time to understand what is tested here. please 
place the two methods in their own test case.
Line 346: utils.rget({'a': {'b': 'hello'}}, ('a', 'b')),
Line 347: 'hello')
Line 348: self.assertEqual(
Line 349: utils.rget({'a': {'b': 'hello'}}, ('a', 'c'), 
default='bye'),


-- 
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93ae32e5ffbfa20a79081aea330e3df3663c3966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: move rget to utils

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: utils: move rget to utils
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/55860/2/tests/utilsTests.py
File tests/utilsTests.py:

Line 341: def test_unique(self, iterable, unique_items):
Line 342: self.assertEquals(utils.unique(iterable,), unique_items)
Line 343: 
Line 344: def test_rget(self):
Line 345: self.assertEqual(
this assertion would  be more readable if placed in its own method e.g. 
test_exists() and later a test_missing().
Line 346: utils.rget({'a': {'b': 'hello'}}, ('a', 'b')),
Line 347: 'hello')
Line 348: self.assertEqual(
Line 349: utils.rget({'a': {'b': 'hello'}}, ('a', 'c'), 
default='bye'),


PS2, Line 346: {'a': {'b': 'hello'}}
a dictionary used twice seems to merit a name.


-- 
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93ae32e5ffbfa20a79081aea330e3df3663c3966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: move rget to utils

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: utils: move rget to utils
..


Patch Set 2:

lib/vdsm/utils.py is - by definition - a function junkyard. I'd rather not add 
more stuff onto it before understanding that indeed it has out-of-ovs-hook 
usages in our code - so please state them in the commit message.

-- 
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93ae32e5ffbfa20a79081aea330e3df3663c3966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: move rget to utils

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: move rget to utils
..


Patch Set 2:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93ae32e5ffbfa20a79081aea330e3df3663c3966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: canonicalize switch type from custom options

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: canonicalize switch type from custom options
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2451a7fbd19e33f6d2dcd9fcc93adbf6e06ab24
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: convert 'bridge' attr to boolean

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: convert 'bridge' attr to boolean
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/55890/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

PS1, Line 26: tobool
importing from vdsm in hooks is evil. let's do it as little as we can. please 
import this bloke from hooking.


-- 
To view, visit https://gerrit.ovirt.org/55890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09eb7c92a2952e18828a3f0f9887b1b2c5457c91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: report ip info on expected top device

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hook: ovs: report ip info on expected top device
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/55893/2/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 176: ovs_bonding_caps[bonding] = net_info
Line 177: return ovs_bonding_caps
Line 178: 
Line 179: 
Line 180: def update_expected_ip_info(caps, running_config):
as a helper function, please name it with a leading underscore.
Line 181: """
Line 182: If a network is marked as bridgeless and untagged, we have to 
report its IP
Line 183: info on attached nic/bond.
Line 184: """


PS2, Line 187: keys
KEYS


Line 190: destination[key] = source[key]
Line 191: 
Line 192: for network, attrs in iter_ovs_nets(running_config.networks):
Line 193: if not attrs.get('bridged', True) and 'vlan' not in attrs:
Line 194: bond = attrs.get('bond')
reminds me a bit of get_engine_expected_top_dev logic...
Line 195: nic = attrs.get('nic')
Line 196: if bond is not None:
Line 197: copy_net_info(
Line 198: caps['networks'][network], caps['bondings'][bond])


-- 
To view, visit https://gerrit.ovirt.org/55893
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f124c303a00e7829cb30c51e505c6bcf158cea3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: move parse_bond_options to netinfo.bonding

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: move parse_bond_options to netinfo.bonding
..


Patch Set 2:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4619dad642facfb2dc154251412fd434d934e817
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: report network iface expeted by engine

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hook: ovs: report network iface expeted by engine
..


Patch Set 1: Code-Review+1

(1 comment)

your code seems right, but I'd like it even better if you adopt mine.

https://gerrit.ovirt.org/#/c/55892/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 91: 
Line 92: def networks_caps(running_config):
Line 93: 
Line 94: def get_engine_expected_top_dev(net, attrs):
Line 95: """Return top device (iface) expected by Engine."""
shameless plug: https://gerrit.ovirt.org/#/c/55323/
Line 96: nic_bond = attrs.get('bonding') or attrs.get('nic')
Line 97: vlan = attrs.get('vlan')
Line 98: return (net if attrs.get('bridged', True)
Line 99: else '%s.%s' % (nic_bond, vlan) if vlan is not None


-- 
To view, visit https://gerrit.ovirt.org/55892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9825ed7861d7baf68d78b00559909e8a30aad53f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: monitoring: Port vdsm.storage.check to python 3
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: port test models_test.py to python 3

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: port test models_test.py to python 3
..


Patch Set 1:

Thanks. Would you please add it to the py3 list in tests/Makefile.am, so your 
fixes are not broken in the future?

-- 
To view, visit https://gerrit.ovirt.org/55896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib72655a50f0a85fcb25fb895b8b12056bf618b7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lihi Wishnitzer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: set OVS devices UP

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: set OVS devices UP

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
..


Patch Set 2: -Verified

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: set OVS devices UP

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: set OVS devices UP
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af77c136a8f27d980f94647f78570b3da1e611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches