date:20160503

Change in vdsm[master]: v2v: Detect VM with snapshots

2016-05-03 Thread Tomas Golembiovsky

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
..


Patch Set 5: Verified-1

The API is not supported in libvirt+Xen on RHEL5. Wi will have to make the 
check for VMware only.

-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add vlan tag to libvirt network def

2016-05-03 Thread edwardh

Edward Haas has posted comments on this change.

Change subject: net: add vlan tag to libvirt network def
..


Patch Set 5: Code-Review-1

Basically the same comments as in https://gerrit.ovirt.org/#/c/56828

There is however a general question that comes to mind: Why do we really need 
it? When is this value used exactly?
In a VM migration or when adding a new VM, we do not really need it.. It can be 
specified in the domxml of the VM.
And we need to do some clever thing over there (with the domxml) due to the 
graphics listen address.
Just raising this because it will be preferred to think of limiting the 
dependency on the libvirt network DB, so we can remove it completely in the 
near future.

-- 
To view, visit https://gerrit.ovirt.org/56829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68451e3a4206afdfbb34752cbb73ebacaf1f5563
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-03 Thread ishaby

Idan Shaby has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 6: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/35629/5/tests/Makefile.am
File tests/Makefile.am:

Line 69: 
Line 70: test_modules = \
Line 71:alignmentScanTests.py \
Line 72:virt_api_test.py \
Line 73:blocksdTests.py \
> Please name this storage_blkdiscard_test.py - this is our new convention.
Done
Line 74:blockVolumeTests.py \
Line 75:bridgeTests.py \
Line 76:bulk_sampling_test.py \
Line 77:cPopenTests.py \


-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: monitor: Convert valid to read-only property
..


Patch Set 6: Continuous-Integration+1

Jenkins failed to build this after rebase - ignoring it.

-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 26:

Piotr, did you check this?
https://pypi.python.org/pypi/jsonschema
https://github.com/Julian/jsonschema

Looks like popular and mature library, support anything we need (types, ranges, 
container sizes, etc.).

-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blkid: Remove leftovers

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: blkid: Remove leftovers
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7926096840ee17c9da040bd1d0141d924804fd21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Convert valid to read-only property

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: monitor: Convert valid to read-only property
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff27081041bbaa1e319539df67abb31f38367e7d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Detach read delay from storage domain

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: monitor: Detach read delay from storage domain
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56826
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a687f70c220a86e538bf1cee500aa8b6028eff1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Use module logger

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: monitor: Use module logger
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35954fe676388247164c8c62fa0744ffcc14006f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Rename storage.monitor test module

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: tests: Rename storage.monitor test module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0cf3ac326d8e50950771870c76d7b309514ffb6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cdrom: API change: require index

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: cdrom: API change: require index
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py
File vdsm/API.py:

Line 112: def __init__(self, UUID):
Line 113: APIBase.__init__(self)
Line 114: self._UUID = UUID
Line 115: 
Line 116: def changeCD(self, interface, index, driveSpec):
> This was my initial idea, there is one annoying problem though: driveSpec i
I'm not sure that we actually support all these.

- DriveSpecVolume - vdsm image (PDIV)
- DriveSpecGUID - direct lun
- DriveSpecPayload - used for cdrom/floppy (not storage) 
- DriveSpecPath - we have support for vdsm, but engine does not used this (not 
storage). I think we should remove this.
- DriveSpecUUID was never used by engine, and the support in vdsm was removed 
recently https://gerrit.ovirt.org/56478. This type is removed by 
https://gerrit.ovirt.org/56992.

These parameters should appear in the all the relevant types. We probably 
should find a better way to specify this without duplicating the schema.
Line 117: """
Line 118: Change the CD in the specified VM.
Line 119: 
Line 120: :param vmId: uuid of specific VM.


-- 
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blkid: Remove leftovers

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: blkid: Remove leftovers
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7926096840ee17c9da040bd1d0141d924804fd21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blkid: Remove leftovers

2016-05-03 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: blkid: Remove leftovers
..

blkid: Remove leftovers

We removed support for local disks using disk UUID in commit
160de740e766 (drop unused blkid external binary), but left the
DriveSpecUUID in the schema.

Change-Id: I7926096840ee17c9da040bd1d0141d924804fd21
Signed-off-by: Nir Soffer 
---
M lib/api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/56992/1

diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index 4325906..425e858 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -6416,17 +6416,6 @@
 {'type', 'DriveSpecGUID', 'data': {'GUID': 'str'}}
 
 ##
-# @DriveSpecUUID:
-#
-# A drive specification using a blkid UUID.
-#
-# @UUID:  The device blkid
-#
-# Since: 4.10.0
-##
-{'type', 'DriveSpecUUID', 'data': {'UUID': 'UUID'}}
-
-##
 # @DriveVmPayload:
 #
 # Directly specified data to be inserted into a VM.
@@ -6484,8 +6473,8 @@
 ##
 {'type': 'DriveSpec',
  'data': {},
- 'union': ['DriveSpecVolume', 'DriveSpecGUID', 'DriveSpecUUID',
-  'DriveSpecPayload', 'DriveSpecPath']}
+ 'union': ['DriveSpecVolume', 'DriveSpecGUID', 'DriveSpecPayload',
+   'DriveSpecPath']}
 
 ##
 # @VM.changeCD:


-- 
To view, visit https://gerrit.ovirt.org/56992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7926096840ee17c9da040bd1d0141d924804fd21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report ovs network with nics, vlan tag and bond

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: report ovs network with nics, vlan tag and bond
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56991
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I844c2ef948cbb1a37ffb64f0e4bc2eac11c17fdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report ovs network with nics, vlan tag and bond

2016-05-03 Thread phoracek

Petr Horáček has uploaded a new change for review.

Change subject: net: report ovs network with nics, vlan tag and bond
..

net: report ovs network with nics, vlan tag and bond

Report nics, bond and vlan tag connected with network in OVS NetInfo
networks. This will be used in kernelconfig.

Change-Id: I844c2ef948cbb1a37ffb64f0e4bc2eac11c17fdb
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/kernelconfig.py
M lib/vdsm/network/ovs/info.py
2 files changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/56991/1

diff --git a/lib/vdsm/kernelconfig.py b/lib/vdsm/kernelconfig.py
index f335e7e..3eb7cc4 100644
--- a/lib/vdsm/kernelconfig.py
+++ b/lib/vdsm/kernelconfig.py
@@ -27,6 +27,7 @@
 from .netinfo import bonding
 from .netinfo import bridges
 from vdsm.network.netconfpersistence import BaseConfig
+from vdsm.network.ovs.switch import SWITCH_TYPE as OVS_SWITCH_TYPE
 
 
 class KernelConfig(BaseConfig):
@@ -70,8 +71,13 @@
 
 
 def _translate_netinfo_net(net, net_attr, netinfo_):
-nics, _, vlan_id, bond = \
-netinfo_.getNicsVlanAndBondingForNetwork(net)
+if net_attr['switch'] == OVS_SWITCH_TYPE:
+nics = net_attr['nics']
+vlan_id = net_attr['vlanid']
+bond = net_attr['bond']
+else:
+nics, _, vlan_id, bond = \
+netinfo_.getNicsVlanAndBondingForNetwork(net)
 attributes = {}
 _translate_bridged(attributes, net_attr)
 _translate_mtu(attributes, net_attr)
diff --git a/lib/vdsm/network/ovs/info.py b/lib/vdsm/network/ovs/info.py
index 24a83e6..8165fe5 100644
--- a/lib/vdsm/network/ovs/info.py
+++ b/lib/vdsm/network/ovs/info.py
@@ -248,9 +248,16 @@
 port_info = EMPTY_PORT_INFO
 
 if port.is_northbound:
+bond = (souhbound.name if souhbound.bond_info is not None
+else '')
+nics = ([souhbound.name] if souhbound.bond_info is None
+else souhbound.bond_info.slaves)
 network_info = {
 'iface': port.name,
 'bridged': True,
+'vlanid': port.tag,
+'bond': bond,
+'nics': nics,
 'ports': get_fake_ports(bridge, port, souhbound),
 'stp': bridge.stp,
 'switch': 'ovs',


-- 
To view, visit https://gerrit.ovirt.org/56991
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I844c2ef948cbb1a37ffb64f0e4bc2eac11c17fdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmdevices: make disk's makeName public

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vmdevices: make disk's makeName public
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e11c52f86a4ed7155118607723e9e7712a08e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add block device naming tests

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: storage: add block device naming tests
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I492a1849109b6f852ccd015d487c6cb7441febdb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Detect VM with snapshots

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
..


Patch Set 5: Code-Review+1

Waiting for Francesco ack.

-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add virtual port to libvirt network def

2016-05-03 Thread edwardh

Edward Haas has posted comments on this change.

Change subject: net: add virtual port to libvirt network def
..


Patch Set 5: Code-Review-1

(3 comments)

Sorry for not raising these in the last review.

https://gerrit.ovirt.org/#/c/56828/5/lib/vdsm/network/configurators/libvirt.py
File lib/vdsm/network/configurators/libvirt.py:

Line 78: if bridged:
Line 79: root.append(EtreeElement('bridge', name=network))
Line 80: else:
Line 81: forwardElem.append(EtreeElement('interface', dev=iface))
Line 82: if virtualport:
Is it legal to have this scenario: bridged=False, virtualport='openvswitch'?

And I think the API should become something more focused on what the caller 
wants:
createNetworkDef(network, type, iface=None)
Where type can be: bridged, bridgless, ovs
Line 83: root.append(EtreeElement('virtualport', type=virtualport))
Line 84: return etree.tostring(root)
Line 85: 
Line 86: 


https://gerrit.ovirt.org/#/c/56828/5/tests/network/conf_test.py
File tests/network/conf_test.py:

PS5, Line 160: test_create_net_xml_virtualport
Looks like we test an ovs bride here, so why not explicitly describe it in the 
test name?
Like: test_create_ovs__net_xml?


PS5, Line 161: expectedDoc
Camel case again, sorry.
How about: expected_net_domxml?

(same for the actual* variable)


-- 
To view, visit https://gerrit.ovirt.org/56828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d081cb51d9f01eccbe28ced62e8bed07ac12396
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

2016-05-03 Thread ybronhei

Yaniv Bronhaim has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 38: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 38
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

2016-05-03 Thread ybronhei

Yaniv Bronhaim has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 22: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/35629/5/tests/Makefile.am
File tests/Makefile.am:

Line 69: 
Line 70: test_modules = \
Line 71:alignmentScanTests.py \
Line 72:virt_api_test.py \
Line 73:blkdiscardTests.py \
Please name this storage_blkdiscard_test.py - this is our new convention.
Line 74:blocksdTests.py \
Line 75:blockVolumeTests.py \
Line 76:bridgeTests.py \
Line 77:bulk_sampling_test.py \


-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: v2v: add support for importing kvm based vms from libvirt
..


Patch Set 4: Code-Review+1

Waiting for Francesco ack.

-- 
To view, visit https://gerrit.ovirt.org/56459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: kvm2ovirt: tool for copying images from libvirt
..


Patch Set 7: Code-Review+1

Waiting for Francesco ack.

-- 
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli

2016-05-03 Thread osvoboda

Ondřej Svoboda has posted comments on this change.

Change subject: tests: let VDSM consume a bond created by nmcli
..


Patch Set 9:

(7 comments)

I addressed some of the comments and I am leaving two of them for the patch set 
11.

https://gerrit.ovirt.org/#/c/56059/9/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2957: for nic in nics:
Line 2958: self.assertNotIn('ad_aggregator_id', nic_caps[nic])
Line 2959: 
Line 2960: @cleanupNet
Line 2961: @permutations([['none'], ['ipv4'], ['dhcpv4']])
> Lets try and loose the permutations...
Done
Line 2962: @ValidateRunningAsRoot
Line 2963: def test_consume_nm_bond(self, ip_config):
Line 2964: options = dict(bond_mode='802.3ad', miimon='200')
Line 2965: vdsm_network = {'bonding': BONDING_NAME, 'bridged': True,


PS9, Line 2966: 'dhcp' if ip_config == 'dhcpv4' else
  : 'none'
> Please take it out to its own variable (bootproto) so it will be more reada
Done


Line 2980:dhcp_range_from=DHCP_RANGE_FROM,
Line 2981:dhcp_range_to=DHCP_RANGE_TO,
Line 2982:ipv4_gateway=IP_GATEWAY)
Line 2983: 
Line 2984: with nm_controlled_bond(BONDING_NAME, **options) as 
(conn_name,
> From the usage, I'm not clear why a contextmanager is used.
For querying information about the returned connection conn_name could be 
useful, but not now.

The contextmananger ensures that ifcfg files created by NetworkManager (with 
different, incompatible names to those initscripts/VDSM create) are removed 
after the test finishes.

I also had it set up the environment for the DHCP variant of the test, but 
since I am splitting the test into three, I will clean up this contextmanager, 
but not in the next iteration.
Line 2985:  slaves):
Line 2986: self.vdsm_net.refreshNetinfo()
Line 2987: self.assertBondExists(BONDING_NAME, slaves,
Line 2988:   'mode=4 miimon=200',


https://gerrit.ovirt.org/#/c/56059/9/tests/network/nettestlib.py
File tests/network/nettestlib.py:

Line 414: return wrapper
Line 415: 
Line 416: 
Line 417: @contextmanager
Line 418: def wait_for_address(iface, families=None, wait_for_scopes=None, 
timeout=20):
> This change seems to belong to a separate patch.
Done
Line 419: """
Line 420: Wait for the iface to get IP addresses of a specified family with 
netlink
Line 421: Monitor.
Line 422: """


PS9, Line 423: if not families:
 : families = (6,)
> What about setting this default at the func signature?
Done


PS9, Line 427: link
> For IPv4, usually there will be no link scope.
I plan to focus on scopes when testing this branch as I have also been 
concerned about IPv4LL.


https://gerrit.ovirt.org/#/c/56059/9/tests/network/networkmanager.py
File tests/network/networkmanager.py:

PS9, Line 31: nettestlib
> nm_controlled_bond is a test-only creature, that should move to nettestlib.
Done


-- 
To view, visit https://gerrit.ovirt.org/56059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let VDSM consume a bond created by NetworkManager

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: tests: let VDSM consume a bond created by NetworkManager
..


Patch Set 10:

* #1304509::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1304509::OK, public bug
* Check Product::#1304509::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: generalize wait_for_ipv6() into wait_for_address()

2016-05-03 Thread osvoboda

Ondřej Svoboda has uploaded a new change for review.

Change subject: tests: generalize wait_for_ipv6() into wait_for_address()
..

tests: generalize wait_for_ipv6() into wait_for_address()

Change-Id: Iefe2632973e13db07309bdedde20227de06bd17a
Signed-off-by: Ondřej Svoboda 
---
M tests/network/netinfo_test.py
M tests/network/nettestlib.py
2 files changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/56983/1

diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index ea65bb3..b96effc 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -36,7 +36,7 @@
 from .ipwrapper_test import _fakeTypeDetection
 from modprobe import RequireBondingMod
 from monkeypatch import MonkeyPatch, MonkeyPatchScope
-from .nettestlib import dnsmasq_run, dummy_device, veth_pair, wait_for_ipv6
+from .nettestlib import dnsmasq_run, dummy_device, veth_pair, wait_for_address
 from testlib import VdsmTestCase as TestCaseBase, namedTemporaryDir
 from testValidation import ValidateRunningAsRoot
 from testValidation import brokentest
@@ -412,7 +412,7 @@
 with veth_pair() as (server, client):
 with dnsmasq_run([server],
  ipv6_slaac_prefix=IPV6_NETADDRESS + '::'):
-with wait_for_ipv6(client):
+with wait_for_address(client):
 ipwrapper.linkSet(client, ['up'])
 ipwrapper.linkSet(server, ['up'])
 ipwrapper.addrAdd(server, IPV6_NETADDRESS + '::1',
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index b1a026c..465c354 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -415,12 +415,16 @@
 
 
 @contextmanager
-def wait_for_ipv6(iface, wait_for_scopes=None):
-"""Wait for iface to get their IPv6 addresses with netlink Monitor"""
+def wait_for_address(iface, families=(6,), wait_for_scopes=None, timeout=20):
+"""
+Wait for the iface to get IP addresses of a specified family with netlink
+Monitor.
+"""
+event_types = ['ipv{}-ifaddr'.format(family) for family in families]
 if not wait_for_scopes:
 wait_for_scopes = ['global', 'link']
 try:
-with monitor.Monitor(groups=('ipv6-ifaddr',), timeout=20) as mon:
+with monitor.Monitor(groups=event_types, timeout=timeout) as mon:
 yield
 for event in mon:
 dev_name = event.get('label')
@@ -434,7 +438,8 @@
 
 except monitor.MonitorError as e:
 if e[0] == monitor.E_TIMEOUT:
-raise Exception('IPv6 addresses has not been caught within the '
-'given timeout.\n')
+raise Exception('IPv{} addresses have not been caught within the '
+'given timeout.\n'.format(
+'/'.join(str(family) for family in families)))
 else:
 raise


-- 
To view, visit https://gerrit.ovirt.org/56983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefe2632973e13db07309bdedde20227de06bd17a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: generalize wait_for_ipv6() into wait_for_address()

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: tests: generalize wait_for_ipv6() into wait_for_address()
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe2632973e13db07309bdedde20227de06bd17a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 10:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS Info to Vdsm Netinfo logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS Info to Vdsm Netinfo logic
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS as bridgeless in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS as bridgeless in caps
..


Patch Set 6:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS as bridgeless in caps

2016-05-03 Thread phoracek

Petr Horáček has abandoned this change.

Change subject: net: fake OVS as bridgeless in caps
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS as bridgeless in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS as bridgeless in caps
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: get_external_vms return format for KVM images

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: v2v: get_external_vms return format for KVM images
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56912/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 935: driver = disk.find('./driver/[@type]')
Line 936: if driver is not None:
Line 937: format = driver.get('type')
Line 938: if format.lower().startswith('qcow'):
Line 939: d['format'] = 'cow'
Few issues here:

- Better return the format to engine for both raw and qcow2 formats, not only 
for qcow2
- We don't support qcow*, only qcow2, don't try to support stuff we don't 
support
- What we support is defined in storage.volume.FMT2STR.values()
- You should return the type name as defined in storage.volume.FMT2STR.keys()

What need is to add a function like storage.volume.fmt2str, taking the format 
name as returned from libvirt, and converting it to the storage term used in 
vdsm and engine.

Assuming we have this function, we should do:

from storage import volume
...
if driver is not None:
format = driver.get("type")
try:
d["format"] = volume.str2fmt(format)
except KeyError as e:
logging.warning("Disk %s has unsupported format: %r", d, format)

Engine can treat disks without a format as unsupported. For disks with a 
format, engine can use the format as reported by vdsm.

fmt2str is quite bad name but it matches str2fmt, we will improve both names 
later.

A simpler alternative, is to return the value reported from libvirt as is, and 
let engine do the filtering, warning etc. This way you can show the disk format 
in the ui, and you can mark it as unsupported in the ui (e.g. gray it). This 
seems to be the way you handle other values here.
Line 940: params['disks'].append(d)
Line 941: 
Line 942: 
Line 943: def _add_networks(root, params):


-- 
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

2016-05-03 Thread phoracek

Petr Horáček has uploaded a new change for review.

Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..

net: include OVS Netinfo in netinfo/cache.py:_get()

Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/netinfo/cache.py
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/56980/1

diff --git a/lib/vdsm/netinfo/cache.py b/lib/vdsm/netinfo/cache.py
index 7709317..6dc7ff3 100644
--- a/lib/vdsm/netinfo/cache.py
+++ b/lib/vdsm/netinfo/cache.py
@@ -26,6 +26,7 @@
 import six
 
 from vdsm.network.netconfpersistence import RunningConfig
+from vdsm.network.ovs.info import get_ovs_netinfo
 from ..ipwrapper import getLinks
 from ..netlink import link as nl_link
 
@@ -99,6 +100,12 @@
 report_network_qos(networking)
 networking['supportsIPv6'] = ipv6_supported()
 
+ovs_networks, ovs_bridges, ovs_vlans, ovs_bonds = get_ovs_netinfo()
+networking['networks'].update(ovs_networks)
+networking['bridges'].update(ovs_bridges)
+networking['vlans'].update(ovs_vlans)
+networking['bonds'].update(ovs_bonds)
+
 return networking
 
 


-- 
To view, visit https://gerrit.ovirt.org/56980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS as bridgeless in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS as bridgeless in caps
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS Info to Vdsm Netinfo logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS Info to Vdsm Netinfo logic
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 13:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

2016-05-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 14:

(5 comments)

https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:

Line 1114: 
Line 1115: with fake.VM(self.conf, create_device_objects=True) as 
testvm:
Line 1116: testvm._devices[hwclass.GENERAL] = devices
Line 1117: self.assertRaises(ExpectedError, testvm._setup_devices)
Line 1118: self.assertEqual(devices[0].state, fake.SETUP)
Now we have the decide - if setup fails, do we teardown the device?

If we don't, setup must leave the device in consistent state, even if something 
raises during setup. This is the behavior in unittest setUp(), and it makes it 
quite hard to use setup and teardown for resource management.

If we do, setup can fail, leaving the device in inconsistent state, and 
teardown must know how to handle a partly setup device.

The change in the code is simple, add the device to the setup devices list 
before calling setup instead of after, or add it in the exception handler.

Francesco, thoughts?
Line 1119: self.assertEqual(devices[1].state, fake.CREATED)
Line 1120: self.assertEqual(devices[2].state, fake.CREATED)
Line 1121: 
Line 1122: def test_device_setup_fail_second(self):


Line 1167: self.assertEqual(devices[1].state, fake.TEARDOWN)
Line 1168: self.assertEqual(devices[2].state, fake.TEARDOWN)
Line 1169: 
Line 1170: def test_device_teardown_fail_all(self):
Line 1171: devices = [fake.Device('device_{}'.format(i), 
fail_teardown=True)
fail_teardown=UnexpectedError
Line 1172:for i in range(3)]
Line 1173: 
Line 1174: with fake.VM(self.conf, create_device_objects=True) as 
testvm:
Line 1175: testvm._devices[hwclass.GENERAL] = devices


https://gerrit.ovirt.org/#/c/55135/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1719: for dev_object in dev_objects[:]:
Line 1720: try:
Line 1721: dev_object.teardown()
Line 1722: except Exception:
Line 1723: self.log.exception("Failed to teardown device")
This repeats the code in _teardown_setup_devices, with different log - aren't 
these devices left in inconsistent state here as well?
Line 1724: 
Line 1725: def _cleanupRecoveryFile(self):
Line 1726: self._recovery_file.cleanup()
Line 1727: 


Line 1867: """
Line 1868: done = []
Line 1869: 
Line 1870: for dev_objects in self._devices.values():
Line 1871: for dev_object in dev_objects[:]:
This code is repeated in both setup_devices and here.

We can make it nicer if we add a method returning an iterator over all devices:

def _iter_devices(self):
for devices in self._devices.values():
for device in devices[:]:
yield device

Now we can do:

done = []
for device in self._iter_devices():
try:
device.setup()
except Exception:
log ...
self._teardown_devices(done)
raise
done.add(device)

_teardown_devices can use optional parameter to teardown only certain devices, 
and if none, teardown all.
Line 1872: try:
Line 1873: dev_object.setup()
Line 1874: except Exception:
Line 1875: self.log.exception("Failed to setup device %s",


Line 1884: try:
Line 1885: dev_object.teardown()
Line 1886: except Exception:
Line 1887: self.log.exception('Failed to tear down device %s, 
device in '
Line 1888:'inconsistent state', 
dev_object.device)
This repeats the code in _teardown_devices.
Line 1889: 
Line 1890: def _run(self):
Line 1891: self.log.info("VM wrapper has started")
Line 1892: dev_spec_map = self._devSpecMapFromConf()


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: store constants in init

2016-05-03 Thread phoracek

Petr Horáček has abandoned this change.

Change subject: net: native ovs: store constants in __init__
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 12:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: reserve ovsbr0 network name
..


Patch Set 8:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: store constants in init

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: store constants in __init__
..


Patch Set 10:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS networks in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS networks in caps
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS netinfo to Vdsm network logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS netinfo to Vdsm network logic
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-05-03 Thread phoracek

Petr Horáček has abandoned this change.

Change subject: net: native ovs: reserve ovsbr0 network name
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: use Transaction for rollback triggering

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: use Transaction for rollback triggering
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ea7e4c7c47591650c31f84f0aac40c8a7f4c842
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add virtual port to libvirt network def

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: add virtual port to libvirt network def
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d081cb51d9f01eccbe28ced62e8bed07ac12396
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS networks in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS networks in caps
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS networks in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS networks in caps
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS networks in caps

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS networks in caps
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a43096440c44e10f80af1c0a492fe255c4f22e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS netinfo to Vdsm network logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS netinfo to Vdsm network logic
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 11:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS netinfo to Vdsm network logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS netinfo to Vdsm network logic
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotunplug

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add support for hotunplug
..


Patch Set 22:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hotplug via vdsClient

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose hotplug via vdsClient
..


Patch Set 20:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: use device setup instead of detach

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hostdev/sr-iov: use device setup instead of detach
..


Patch Set 16:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add vdsClient hotunplug command

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add vdsClient hotunplug command
..


Patch Set 20:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00e5510b5306d689536b24091411332c8b80e75
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose parameters needed to support hotunplug

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose parameters needed to support hotunplug
..


Patch Set 20:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS netinfo to Vdsm network logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS netinfo to Vdsm network logic
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 10:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: disable hyperv for gpu passthrough

2016-05-03 Thread mpolednik

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: disable hyperv for gpu passthrough
..

hostdev: disable hyperv for gpu passthrough

We know that NVIDIA GPUs work fine in passthrough for Linux guests, but
there is an issue with Windows guests. If NVIDIA proprietary driver
detects that it is running in virtualized environment, it fails to
initialize with code 43.

This patch only appends hyperv enlightenments iff NVIDIA device is not
present.

Change-Id: I5955e683c2a3d02aa6992e3ab5898f275997f3b7
Signed-off-by: Martin Polednik 
---
M tests/vmTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
3 files changed, 48 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/56975/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 6a0c555..35254c6 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -277,6 +277,18 @@
 xml = find_xml_element(domxml.dom.toxml(), './features')
 self.assertXMLEqual(xml, featuresXML)
 
+def testFeaturesHyperVXMLGpuPassthrough(self):
+featuresXML = """
+
+  
+"""
+conf = {'hypervEnable': 'true'}
+conf.update(self.conf)
+domxml = vmxml.Domain(conf, self.log, cpuarch.X86_64)
+domxml.appendFeatures(gpu_passthrough=True)
+xml = find_xml_element(domxml.dom.toxml(), './features')
+self.assertXMLEqual(xml, featuresXML)
+
 def testSysinfoXML(self):
 sysinfoXML = """
 
@@ -393,6 +405,20 @@
 xml = find_xml_element(domxml.dom.toxml(), './clock')
 self.assertXMLEqual(xml, clockXML)
 
+def testHyperVClockXMLGpuPassthrough(self):
+clockXML = """
+
+
+
+
+"""
+conf = {'timeOffset': '-3600', 'hypervEnable': 'true'}
+conf.update(self.conf)
+domxml = vmxml.Domain(conf, self.log, cpuarch.X86_64)
+domxml.appendClock(gpu_passthrough=True)
+xml = find_xml_element(domxml.dom.toxml(), './clock')
+self.assertXMLEqual(xml, clockXML)
+
 def testCpuXML(self):
 cpuXML = """
   
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 41b18c3..2df719e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1688,10 +1688,12 @@
 for leaseElement in drive.getLeasesXML():
 domxml._devices.appendChild(leaseElement)
 
-domxml.appendClock()
+gpu_passthrough = self._uses_gpu_passthrough()
+
+domxml.appendClock(gpu_passthrough)
 
 if cpuarch.is_x86(self.arch):
-domxml.appendFeatures()
+domxml.appendFeatures(gpu_passthrough)
 
 return domxml.toxml()
 
@@ -4729,6 +4731,16 @@
 "Unable to set volume size to %s for domain %s volume %s" %
 (size, domainID, volumeID))
 
+def _uses_gpu_passthrough(self):
+for device in self._devices[hwclass.HOSTDEV][:]:
+try:
+if device._deviceParams['vendor_id'] == '0x10de':
+return True
+except KeyError:
+continue
+
+return False
+
 
 class LiveMergeCleanupThread(threading.Thread):
 def __init__(self, vm, job, drive, doPivot):
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index bc46b05..d5d4b24 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -201,7 +201,7 @@
 
 self.appendMetadata()
 
-def appendClock(self):
+def appendClock(self, gpu_passthrough=False):
 """
 Add  element to domain:
 
@@ -218,7 +218,8 @@
 
 m = Element('clock', offset='variable',
 adjustment=str(self.conf.get('timeOffset', 0)))
-if utils.tobool(self.conf.get('hypervEnable', 'false')):
+if (not gpu_passthrough and
+utils.tobool(self.conf.get('hypervEnable', 'false'))):
 m.appendChildWithArgs('timer', name='hypervclock', present='yes')
 m.appendChildWithArgs('timer', name='rtc', tickpolicy='catchup')
 m.appendChildWithArgs('timer', name='pit', tickpolicy='delay')
@@ -340,7 +341,7 @@
 appendEntry('serial', serialNumber)
 appendEntry('uuid', self.conf['vmId'])
 
-def appendFeatures(self):
+def appendFeatures(self, gpu_passthrough=False):
 """
 Add machine features to domain xml.
 
@@ -357,15 +358,16 @@
 
 
 """
-
 if (utils.tobool(self.conf.get('acpiEnable', 'true')) or
-   utils.tobool(self.conf.get('hypervEnable', 'false'))):
+(not gpu_passthrough and
+utils.tobool(self.conf.get('hypervEnable', 'false':
 features = self.dom.appendChildWithArgs('features')
 
 if utils.tobool(self.conf.get('acpiEnable', 'true')):
 features.appendChildWithArgs('acpi')
 
-if

Change in vdsm[master]: hostdev: disable hyperv for gpu passthrough

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hostdev: disable hyperv for gpu passthrough
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56975
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5955e683c2a3d02aa6992e3ab5898f275997f3b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: delay appendFeatures and appendClock

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: virt: delay appendFeatures and appendClock
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c3a719b57978a7f7adc0f0845c706e3c525574b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: delay appendFeatures and appendClock

2016-05-03 Thread mpolednik

Martin Polednik has uploaded a new change for review.

Change subject: virt: delay appendFeatures and appendClock
..

virt: delay appendFeatures and appendClock

This patch itself does not provide much value, but it is a preparation
for upcoming change. We move appendFeatures and appendClock to the
bottom of domain XML building to have all devices setup by the time we
get there.

That means, flags/timers depending on device configuration can
access the created device objects.

Change-Id: I4c3a719b57978a7f7adc0f0845c706e3c525574b
Signed-off-by: Martin Polednik 
---
M tests/vmTestsData.py
M vdsm/virt/vm.py
2 files changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/56974/1

diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py
index 00f39e2..d039095 100644
--- a/tests/vmTestsData.py
+++ b/tests/vmTestsData.py
@@ -68,6 +68,13 @@
 %(vmId)s
 
 
+
+
+qemu64
+
+
+
+
 
 
 
@@ -76,13 +83,6 @@
 
 
 
-
-
-qemu64
-
-
-
-
 
 """, )]
 
@@ -127,16 +127,16 @@
 
 hvm
 
-
-
-
-
 
 
 POWER8
 
 
 
+
+
+
+
 
 """, )]
 
@@ -198,6 +198,10 @@
 %(vmId)s
 
 
+
+SandyBridge
+
+
 
 
 
@@ -206,10 +210,6 @@
 
 
 
-
-SandyBridge
-
-
 
 """, )]
 
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8ac6242..41b18c3 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1661,11 +1661,6 @@
 osversion=osVersion,
 serialNumber=serialNumber)
 
-domxml.appendClock()
-
-if cpuarch.is_x86(self.arch):
-domxml.appendFeatures()
-
 domxml.appendCpu()
 
 domxml.appendNumaTune()
@@ -1693,6 +1688,11 @@
 for leaseElement in drive.getLeasesXML():
 domxml._devices.appendChild(leaseElement)
 
+domxml.appendClock()
+
+if cpuarch.is_x86(self.arch):
+domxml.appendFeatures()
+
 return domxml.toxml()
 
 def _cleanup(self):


-- 
To view, visit https://gerrit.ovirt.org/56974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c3a719b57978a7f7adc0f0845c706e3c525574b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmtests: use assertXMLEqual in assertBuildCmdline

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: vmtests: use assertXMLEqual in assertBuildCmdline
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38342d837374c51a862814288803915e4ac3f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vmtests: use assertXMLEqual in assertBuildCmdline

2016-05-03 Thread mpolednik

Martin Polednik has uploaded a new change for review.

Change subject: vmtests: use assertXMLEqual in assertBuildCmdline
..

vmtests: use assertXMLEqual in assertBuildCmdline

Test method assertBuildCmdline worked around whitespace in it's own
way. We have AssertXMLEqual for that, leading to a more consistent code.

Change-Id: If38342d837374c51a862814288803915e4ac3f07
Signed-off-by: Martin Polednik 
---
M tests/vmTests.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/56973/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 1e45fda..6a0c555 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -117,9 +117,7 @@
 
 output = testVm._buildDomainXML()
 
-self.assertEqual(
-re.sub('\n\s*', ' ', output.strip(' ')),
-re.sub('\n\s*', ' ', expectedXML.strip(' ')))
+self.assertXMLEqual(output, expectedXML)
 
 def testDomXML(self):
 expectedXML = """


-- 
To view, visit https://gerrit.ovirt.org/56973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If38342d837374c51a862814288803915e4ac3f07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS netinfo to Vdsm network logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS netinfo to Vdsm network logic
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: map OVS netinfo to Vdsm network logic

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: map OVS netinfo to Vdsm network logic
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix python-blivet dependency issue for python3

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix python-blivet dependency issue for python3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56945
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3d89d6daf667a9a505f27e7a1570a6e93696a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-03 Thread ishaby

Idan Shaby has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs bondings netinfo

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: ovs bondings netinfo
..


Patch Set 3:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56913
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd38dd8b75a1b4025f093c4c33ffcdd9f9c128b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: ovs bondings netinfo

2016-05-03 Thread phoracek

Petr Horáček has abandoned this change.

Change subject: net: ovs bondings netinfo
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56913
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iddd38dd8b75a1b4025f093c4c33ffcdd9f9c128b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS fake netinfo

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS fake netinfo
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS networks info

2016-05-03 Thread phoracek

Petr Horáček has posted comments on this change.

Change subject: net: OVS networks info
..


Patch Set 7:

[root@centos7-vdsmbox ~]# ovs-vsctl show
f5246890-7eea-4d7d-ba5c-ce3d9bf0fd41
Bridge "br0"
Port test-network
tag: 10
Interface test-network
type: internal
Port "dummy_3"
Interface "dummy_3"
Port "test-network-10"
tag: 10
Interface "test-network-10"
type: internal
Port "bond1"
Interface "dummy_1"
Interface "dummy_2"
Port "br0"
Interface "br0"
type: internal
ovs_version: "2.4.0"


Is shown as:

In [2]: ni.OvsNetinfo().bridges
Out[2]: [Bridge(name=u'br0', ports=[Port(name=u'test-network', 
ip_info=IpInfo(mtu=1500, ipv4addr='', ipv4addrs=[], ipv4gateway='', 
ipv4netmask='', dhcpv4=False, ipv6addrs=[], ipv6gateway='::', 
ipv6autoconf=True, dhcpv6=False), bond_info=None, tag=10, is_southbound=False, 
is_northbound=True), Port(name=u'dummy_3', ip_info=IpInfo(mtu=1500, 
ipv4addr='192.168.1.55', ipv4addrs=['192.168.1.55/24'], ipv4gateway='', 
ipv4netmask='255.255.255.0', dhcpv4=False, ipv6addrs=[], ipv6gateway='::', 
ipv6autoconf=True, dhcpv6=False), bond_info=None, tag=[], is_southbound=True, 
is_northbound=False), Port(name=u'test-network-10', ip_info=IpInfo(mtu=1500, 
ipv4addr='', ipv4addrs=[], ipv4gateway='', ipv4netmask='', dhcpv4=False, 
ipv6addrs=[], ipv6gateway='::', ipv6autoconf=True, dhcpv6=False), 
bond_info=None, tag=10, is_southbound=False, is_northbound=True), 
Port(name=u'bond1', ip_info=None, bond_info=BondInfo(slaves=[u'dummy_1', 
u'dummy_2'], active_slave=None, mode=None, lacp=None), tag=[], is_sou!
 thbound=True, is_northbound=False), Port(name=u'br0', ip_info=IpInfo(mtu=1500, 
ipv4addr='', ipv4addrs=[], ipv4gateway='', ipv4netmask='', dhcpv4=False, 
ipv6addrs=[], ipv6gateway='::', ipv6autoconf=True, dhcpv6=False), 
bond_info=None, tag=[], is_southbound=False, is_northbound=False)])]

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread danken

Dan Kenigsberg has submitted this change and it was merged.

Change subject: test: validate that OVS tests runs as root
..


test: validate that OVS tests runs as root

Move OVS service handling to class level, as they it is not needed
for all classes (TestOvsVsctlCommand).

This patch is needed to fix non-root RPM builds on docker.

Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/56952
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M tests/network/ovs_driver_test.py
1 file changed, 14 insertions(+), 12 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/56952/1/tests/network/ovs_driver_test.py
File tests/network/ovs_driver_test.py:

Line 223: self.ovsdb.add_br(TEST_BRIDGE).execute()
Line 224: 
Line 225: def tearDown(self):
Line 226: self.ovsdb.del_br(TEST_BRIDGE).execute()
Line 227: self.ovs_service.teardown()
this has adds needless slowdown when running all tests, but let us first 
unbreak master.
Line 228: 
Line 229: def test_create_vlan_as_fake_bridge(self):
Line 230: with self.ovsdb.transaction() as t:
Line 231: t.add(self.ovsdb.add_vlan(TEST_BRIDGE, 100))


-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

1 2 >

1 - 100 of 113 matches

Mail list logo