Change in vdsm[master]: spec: Make vdsm-api noarch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Make vdsm-api noarch
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm-api noarch

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: spec: Make vdsm-api noarch
..

spec: Make vdsm-api noarch

vdsm-api package was not marked as noarch by mistake in commit
f684e7527cf3f (spec: Make vdsm arch specific package).

Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Signed-off-by: Nir Soffer 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/57157/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 074502b..21a82b8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -288,7 +288,8 @@
 ovirt-engine and vdsClient.
 
 %package api
-Summary:   VDSM API
+Summary:VDSM API
+BuildArch:  noarch
 
 %description api
 Contains api schema files


-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: dispatcher can return empty string

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: dispatcher can return empty string
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 20: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: yml: generate api doc from the schema

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: generate api doc from the schema
..


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56387/6/automation/index.html
File automation/index.html:

Line 2: 
Line 3: VDSM Project Automation Build Reports
Line 4: Coverage Report
Line 5: 
Line 6: Api exposed by vdsm
it should be only vdsm-api.html - check the link - Problem accessing 
/job/vdsm_master_check-patch-fc23-x86_64/681/artifact/exported-artifacts/lib/api/vdsm-api.html.
 Reason:

Not Found
Line 7: 
Line 8: Functional Tests Over Fedora 
23
Line 9: 
Line 10: Download Logs


-- 
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: yml: generate api doc from the schema

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: generate api doc from the schema
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 26: Code-Review-1

(7 comments)

https://gerrit.ovirt.org/#/c/56972/26/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

Line 109: 
Line 110: return {'slaves': slaves, 'active_slave': active_slave,
Line 111: 'fake_iface': fake_iface, 'mode': mode, 'lacp': lacp}
Line 112: 
Line 113: def southbound_port(self, bridge):
Perhaps we should cache this info at the bridge level with a 'southbond' key?
Does not need to be in this patch..

Hmm.. would it fit as a bridge property instead of a port level?
Line 114: for port, attrs in 
six.iteritems(self.bridges[bridge]['ports']):
Line 115: if attrs['level'] == SOUTHBOUND:
Line 116: return port
Line 117: return None


Line 184: }
Line 185: return bond_info
Line 186: 
Line 187: 
Line 188: def get_netinfo(ovs_info=None):
Sorry for this nit, but could you please order the funcs from top to bottom 
(public first and so on..)
Line 189: 
Line 190: if ovs_info is None:
Line 191: ovs_info = OvsInfo()
Line 192: 


PS26, Line 190: if ovs_info is None:
  : ovs_info = OvsInfo()
Why would we need a default for this?
IMO instantiating an object like this better be controlled by the caller.. less 
surprises.


PS26, Line 201: for port, port_attrs in six.iteritems(ports):
  : if port_attrs['level'] == NORTHBOUND:
For southbound we use ovs_info.southbound_port and for northbound we use this?


PS26, Line 203: port
Really confusing... this is the northbound port name that represents the 
network name.
That needs to be expressed somehow...


https://gerrit.ovirt.org/#/c/56972/26/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

PS26, Line 208: @MonkeyPatch(info.OvsInfo, '__init__', mocked_OvsInfo_init)
This requires mocking the OvsInfo object, not its __init__.
But a proper test should have mocked the driver.
(Because we should have unit tested OvsDB by mocking the driver, testing 
OvsInfo using the same mock and so on...


PS26, Line 209: _get_iface_info
I understand that it is easier to monkeypatch it like this, but it is a bad 
practice to patch/mock private funcs/methods.
It makes the test strongly coupled to the CUD.

You should mock/patch only public modules/classes/funcs, preferably not the 
ones from the same module you test.

In this case, I guess you need to monkeypatch all the funcs called to process 
the info.
This is also the reason why IP related stuff should have been done outside the 
info module.


-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 23:

(3 comments)

Question: When creating northbound interfaces bind to ovs ports, are these 
cleaned up when removing the bridge?

Not sure why CI tests fail, I ran the tests on Centos7 and all passes.

https://gerrit.ovirt.org/#/c/56901/23/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

PS23, Line 61: t.add(self.ovsdb.add_bond(
 : TEST_BRIDGE, TEST_BOND, [self.nic1_name, 
self.nic2_name]))
 : t.add(self.ovsdb.set_port_attr(
 : TEST_BOND, 'bond_mode', 'active-backup'))
 : t.add(self.ovsdb.set_port_attr(
 : TEST_BOND, 'other_config:vdsm_level', 
info.SOUTHBOUND))
This block describes one entity creation, placing it in its own helper 
contextmanager is preferred.
Note that there is a need to cleanup after adding the ports/interfaces, 
something that is missing at the moment.

This is also specific to the test itself and not the test class, I guess with a 
contextmanager and the need to cleanup if there is a problem in the middle, 
will require moving it to the test method.


PS23, Line 68: t.add(self.ovsdb.add_port(TEST_BRIDGE, TEST_NETWORK))
 : t.add(self.ovsdb.set_port_attr(TEST_NETWORK, 'tag', 
TEST_VLAN))
 : t.add(self.ovsdb.set_port_attr(
 : TEST_NETWORK, 'other_config:vdsm_level', 
info.NORTHBOUND))
 : t.add(self.ovsdb.set_interface_attr(
 : TEST_NETWORK, 'type', 'internal'))
Same here


PS23, Line 97: south
Ah... nit: consider 'southbound'.


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[prasanna . kalever]

Prasanna Kumar Kalever has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 8: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dhclient: consider NetworkManager lease files for DUID too

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: dhclient: consider NetworkManager lease files for DUID too
..

dhclient: consider NetworkManager lease files for DUID too

If a device to be replaced by our bridge is owned by NetworkManager,
its lease file lies in /var/lib/NetworkManager. In that case dhclient
would not reuse DUID and get a different lease.

A new function now looks in /var/lib/dhclient for initscripts-written
ifcfg file, and in the above directory, and returns the name of a lease
file with the most recent DUID for the given device.

Change-Id: I62a102a2964ed5e5864ff516c71752a23c4c55cf
Signed-off-by: Ondřej Svoboda 
---
M lib/vdsm/network/configurators/dhclient.py
M lib/vdsm/network/configurators/ifcfg.py
2 files changed, 35 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/57151/1

diff --git a/lib/vdsm/network/configurators/dhclient.py 
b/lib/vdsm/network/configurators/dhclient.py
index eb4c99b..b7921b7 100644
--- a/lib/vdsm/network/configurators/dhclient.py
+++ b/lib/vdsm/network/configurators/dhclient.py
@@ -20,6 +20,7 @@
 
 from __future__ import absolute_import
 import errno
+from glob import iglob
 import logging
 import os
 import subprocess
@@ -35,6 +36,8 @@
 DHCLIENT_CGROUP = 'vdsm-dhclient'
 LEASE_DIR = '/var/lib/dhclient'
 LEASE_FILE = os.path.join(LEASE_DIR, 'dhclient{0}--{1}.lease')
+NM_LEASE_FILE_GLOB = os.path.join('/var/lib/NetworkManager',
+  'dhclient{0}-*-{1}.lease')
 
 
 class DhcpClient(object):
@@ -46,7 +49,7 @@
 self.family = family
 self.default_route = default_route
 self.duid_source_file = None if duid_source is None else (
-LEASE_FILE.format('' if family == 4 else '6', duid_source))
+find_newest_lease_file(duid_source, family))
 self.pidFile = self.PID_FILE % (family, self.iface)
 if not os.path.exists(LEASE_DIR):
 os.mkdir(LEASE_DIR)
@@ -138,3 +141,32 @@
 
 _, err = probe.communicate()
 return '-df' in err
+
+
+def find_newest_lease_file(device_name, ip_family):
+"""
+Return the path to the most recent lease file for a given device name and
+IP family.
+
+Lease files written both by initscripts and NetworkManager are considered.
+"""
+dhclient_suffix = '' if ip_family == 4 else '6'
+lease_file_names = [LEASE_FILE.format(dhclient_suffix, device_name)]
+lease_file_names.extend(
+iglob(NM_LEASE_FILE_GLOB.format(dhclient_suffix, device_name)))
+dated_lease_file_names = []
+for name in lease_file_names:
+try:
+modified_date = os.stat(name).st_mtime
+except OSError as e:
+if e.errno == errno.ENOENT:
+continue
+else:
+raise
+dated_lease_file_names.append((modified_date, name))
+
+if dated_lease_file_names:
+dated_lease_file_names.sort(reverse=True)
+return dated_lease_file_names[0][1]
+else:
+return None
diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index baf3d8d..265c64b 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -562,8 +562,8 @@
 conf += 'STP=%s\n' % ('on' if bridge.stp else 'off')
 conf += 'ONBOOT=yes\n'
 if bridge.duid_source and dhclient.supports_duid_file():
-duid_source_file = dhclient.LEASE_FILE.format(
-'', bridge.duid_source)
+duid_source_file = dhclient.find_newest_lease_file(
+bridge.duid_source, 4)
 conf += 'DHCLIENTARGS="-df %s"\n' % duid_source_file
 
 if 'custom' in opts and 'bridge_opts' in opts['custom']:


-- 
To view, visit https://gerrit.ovirt.org/57151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62a102a2964ed5e5864ff516c71752a23c4c55cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dhclient: consider NetworkManager lease files for DUID too

[automation]

gerrit-hooks has posted comments on this change.

Change subject: dhclient: consider NetworkManager lease files for DUID too
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a102a2964ed5e5864ff516c71752a23c4c55cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 26:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeStorageDomainCache

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: FakeStorageDomainCache
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Prepare for COW_FORMAT test permutations
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6010b62291d7ce1e7e993de80d8c8dd50c2c08fe
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Create repo image directory when creating block volumes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Create repo image directory when creating block volumes
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42ba107215e6b0316f41dfd9222b474a97b0755f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: snapshot wip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: snapshot wip
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57057
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3649ef8d87522105b645f249f2bc35f7db7e3e29
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: VolumeArtifacts COW base volume support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: VolumeArtifacts COW base volume support
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If31e013187830322d4c9ebf0d76b4d6d4d81445d
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add lvsByTag to FakeLVM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add lvsByTag to FakeLVM
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87826f624ce6edaf40e7f86657c4c824aa480b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm_indirection: move Volume prepare and teardown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm_indirection: move Volume prepare and teardown
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica933a9fb17450babc02e1d71c2164942e0efe70
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56936/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 218: with self.fake_env() as env:
Line 219: artifacts = env.sd_manifest.get_volume_artifacts(
Line 220: self.img_id, self.vol_id)
Line 221: with MonkeyPatchScope([
Line 222: [artifacts, '_create_volume_file', failure]
> OK, can you add a comment about this - why we cannot monkeypatch the underl
sure.
Line 223: ]):
Line 224: self.assertRaises(ExpectedFailure, artifacts.create,
Line 225:   *BASE_RAW_PARAMS)
Line 226: self.validate_new_image_path(artifacts,


-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 25: Verified+1

(4 comments)

Passed ovs_info_test.py

https://gerrit.ovirt.org/#/c/56972/24/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

Line 161: nics = ([southbound] if not ports[southbound]['bond']
Line 162: else ports[southbound]['bond']['slaves'])
Line 163: network_info = {
Line 164: 'iface': port,
Line 165: 'bridged': True,
> get info is expected to be called quite often. can we define these function
Done
Line 166: 'vlanid': port_attrs['tag'],
Line 167: 'bond': bond,
Line 168: 'nics': nics,
Line 169: 'ports': _get_net_ports(bridge, port, southbound, ports),


Line 182:  bond_attrs['slaves'][0]),
Line 183: 'opts': _to_bond_opts(bond_attrs['mode'], bond_attrs['lacp']),
Line 184: 'switch': 'ovs'
Line 185: }
Line 186: if bond_attrs['fake_iface']:
> Seems to me that you can move the ip tree here directly, without the need t
Done
Line 187: bond_info.update(_get_iface_info(port, addresses, routes))
Line 188: else:
Line 189: bond_info.update(EMPTY_PORT_INFO)
Line 190: return bond_info


PS24, Line 199: es(
> Do we need to support the 'cfg' portion? I think we deprecated it.
Done


PS24, Line 186: if bond_attrs['fake_iface']:
  : bond_info.update(_get_iface_info(port, addresses, 
routes))
  : else:
  : bond_info.update(EMPTY_PORT_INFO)
  : return bond_info
  : 
  : 
  : def get_netinfo(ovs_info=None):
  : 
  : if ovs_info is None:
  : ovs_info = OvsInfo()
  : 
  : addresses = getIpAddrs()
  : routes = get_routes()
  : 
  : networking = {'networks': {}, 'bondings': {}}
  : 
  : for bridge, bridge_attrs in six.iterite
> can you factor this (and other similar stanzas) out to a little helper func
Done


-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 23: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 25:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 23:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let VDSM consume a bond created by NetworkManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: let VDSM consume a bond created by NetworkManager
..


Patch Set 13:

* #1304509::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1304509::OK, public bug
* Check Product::#1304509::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: introduce the networkmanager module, with an integration 
test
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id83fa34f9ca7ca910f705e5c360ad420c7a0dcfc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 22:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 22: Verified+1

(1 comment)

Passed ovs_info_test.py

https://gerrit.ovirt.org/#/c/56901/21/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

PS21, Line 149: (
> nit: The plural version is deprecated.
Done


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

[jniederm]

Jakub Niedermertl has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches