Change in vdsm[master]: [wip] Adding report_stats to host.api

2016-05-07 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: [wip] Adding report_stats to host.api
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56880/2/lib/vdsm/common/host/api.py
File lib/vdsm/common/host/api.py:

Line 201: report.send('.memory.free', stats['memFree'])
Line 202: report.send('.memory.swap_total', stats['swapTotal'])
Line 203: report.send('.memory.swap_free', stats['swapFree'])
Line 204: report.send('.virt.active_vms', stats['vmActive'])
Line 205: report.send('.virt.total_vms', stats['vmCount'])
I think this code worth a class. this should be called from sampling each 
periodic interval (based on host_sample_stats_interval config value). also, 
getStats can memoized the output if this interval is not passed yet. passing 
irs, cif, haClient should happen once on startup.


-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move hoststats code to host package

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Move hoststats code to host package
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] Adding report_stats to host.api

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: [wip] Adding report_stats to host.api
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move code of the host stats dict creation from API.py to hos...

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Move code of the host stats dict creation from API.py to 
host.api module
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding reportStats

2016-05-07 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding reportStats
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 455: """
Line 456: Send gauge values to statsd
Line 457: The format
Line 458: """
Line 459: report = statsd.Gauge(".host." + uuid())
> Isn't this a Client? Why not call it client?
keeping engine's terms
Line 460: report.send('memAvailable', _current_stats['memAvailable'])
Line 461: report.send('memCommitted', _current_stats['memCommitted'])
Line 462: report.send('memFree', _current_stats['memFree'])
Line 463: report.send('swapTotal', _current_stats['swapTotal'])


Line 456: Send gauge values to statsd
Line 457: The format
Line 458: """
Line 459: report = statsd.Gauge(".host." + uuid())
Line 460: report.send('memAvailable', _current_stats['memAvailable'])
> Lets use only lowercase and nice names, no shortcuts, and plural when we ta
yes, that is the plan
Line 461: report.send('memCommitted', _current_stats['memCommitted'])
Line 462: report.send('memFree', _current_stats['memFree'])
Line 463: report.send('swapTotal', _current_stats['swapTotal'])
Line 464: report.send('swapFree', _current_stats['swapFree'])


https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

PS1, Line 551: reportStats
> How can we specify the interval when report is sent?
the intention is to call it after each sample, same interval


-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move hoststats code to host package

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Move hoststats code to host package
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move code of the host stats dict creation from API.py to hos...

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Move code of the host stats dict creation from API.py to 
host.api module
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce vdsm.common.host package for all host related code

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Introduce vdsm.common.host package for all host related code
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a17a743835bf57c5c594bdfe8c05550942fa657
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce vdsm.common.host package for all host related code

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Introduce vdsm.common.host package for all host related code
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a17a743835bf57c5c594bdfe8c05550942fa657
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce vdsm.common.host package for all host related code

2016-05-07 Thread ybronhei 
Yaniv Bronhaim has uploaded a new change for review.

Change subject: Introduce vdsm.common.host package for all host related code
..

Introduce vdsm.common.host package for all host related code

Change-Id: I7a17a743835bf57c5c594bdfe8c05550942fa657
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/Makefile.am
A lib/vdsm/common/host/Makefile.am
A lib/vdsm/common/host/__init__.py
M lib/vdsm/tool/register.py
M lib/vdsm/tool/vdsm-id.py
M tests/vmTests.py
M vdsm.spec.in
M vdsm/caps.py
M vdsm/virt/vm.py
9 files changed, 96 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/57172/1

diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 30183c0..faca64b 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -35,7 +35,6 @@
executor.py \
health.py \
hooks.py \
-   host.py \
hostdev.py \
ipwrapper.py \
jobs.py \
diff --git a/lib/vdsm/common/host/Makefile.am b/lib/vdsm/common/host/Makefile.am
new file mode 100644
index 000..e2e7a2f
--- /dev/null
+++ b/lib/vdsm/common/host/Makefile.am
@@ -0,0 +1,22 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+include $(top_srcdir)/build-aux/Makefile.subs
+
+vdsmcommonhostdir = $(vdsmpylibdir)/common/host
+dist_vdsmcommonhost_PYTHON = *.py
diff --git a/lib/vdsm/common/host/__init__.py b/lib/vdsm/common/host/__init__.py
new file mode 100644
index 000..27da570
--- /dev/null
+++ b/lib/vdsm/common/host/__init__.py
@@ -0,0 +1,67 @@
+#
+# Copyright 2008-2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+
+import os
+import logging
+from vdsm.utils import memoized
+from vdsm.commands import execCmd
+from vdsm import constants
+from vdsm import cpuarch
+
+
+@memoized
+def uuid():
+host_UUID = None
+
+try:
+if os.path.exists(constants.P_VDSM_NODE_ID):
+with open(constants.P_VDSM_NODE_ID) as f:
+host_UUID = f.readline().replace("\n", "")
+else:
+arch = cpuarch.real()
+if cpuarch.is_x86(arch):
+ret, out, err = execCmd([constants.EXT_DMIDECODE,
+ "-s",
+ "system-uuid"],
+raw=True,
+sudo=True)
+out = '\n'.join(line for line in out.splitlines()
+if not line.startswith('#'))
+
+if ret == 0 and 'Not' not in out:
+# Avoid error string - 'Not Settable' or 'Not Present'
+host_UUID = out.strip()
+else:
+logging.warning('Could not find host UUID.')
+elif cpuarch.is_ppc(arch):
+# eg. output IBM,03061C14A
+try:
+with open('/proc/device-tree/system-id') as f:
+systemId = f.readline()
+host_UUID = systemId.rstrip('\0').replace(',', '')
+except IOError:
+logging.warning('Could not find host UUID.')
+
+except:
+logging.error("Error retrieving host UUID", exc_info=True)
+
+return host_UUID
diff --git a/lib/vdsm/tool/register.py b/lib/vdsm/tool/register.py
index dcd9d19..17acabe 100644
---

Change in vdsm[master]: net: Move tc under vdsm.network

2016-05-07 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: Move tc under vdsm.network
..


Patch Set 1: Verified+1

Unit and Functional tests are passing

-- 
To view, visit https://gerrit.ovirt.org/57171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b43b8bb38c16e6a352b9b0ab28ac26e0dea0cdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Move tc under vdsm.network

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Move tc under vdsm.network
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b43b8bb38c16e6a352b9b0ab28ac26e0dea0cdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Move tc under vdsm.network

2016-05-07 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Move tc under vdsm.network
..

net: Move tc under vdsm.network

Change-Id: I3b43b8bb38c16e6a352b9b0ab28ac26e0dea0cdd
Signed-off-by: Edward Haas 
---
M configure.ac
M lib/vdsm/Makefile.am
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/network/netinfo/qos.py
R lib/vdsm/network/tc/Makefile.am
R lib/vdsm/network/tc/__init__.py
R lib/vdsm/network/tc/_parser.py
R lib/vdsm/network/tc/_wrapper.py
R lib/vdsm/network/tc/cls.py
R lib/vdsm/network/tc/filter.py
R lib/vdsm/network/tc/qdisc.py
M tests/functional/networkTests.py
M tests/network/qos_test.py
M tests/network/tc_test.py
M vdsm.spec.in
M vdsm/supervdsm_api/network.py
17 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/57171/1

diff --git a/configure.ac b/configure.ac
index c43ab5d..4845f54 100644
--- a/configure.ac
+++ b/configure.ac
@@ -399,9 +399,9 @@
lib/vdsm/network/netlink/Makefile
lib/vdsm/network/ovs/Makefile
lib/vdsm/network/ovs/driver/Makefile
+   lib/vdsm/network/tc/Makefile
lib/vdsm/rpc/Makefile
lib/vdsm/storage/Makefile
-   lib/vdsm/tc/Makefile
lib/vdsm/virt/Makefile
tests/Makefile
tests/common/Makefile
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 7696bd1..3d08be7 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -19,7 +19,7 @@
 #
 include $(top_srcdir)/build-aux/Makefile.subs
 
-SUBDIRS=common tool infra profiling rpc tc network virt storage
+SUBDIRS=common tool infra profiling rpc network virt storage
 
 dist_vdsmpylib_PYTHON = \
__init__.py \
diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index e0fc55f..eb50931 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -17,7 +17,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
-SUBDIRS = configurators ip netinfo netlink ovs
+SUBDIRS = configurators ip netinfo netlink ovs tc
 
 include $(top_srcdir)/build-aux/Makefile.subs
 
diff --git a/lib/vdsm/network/configurators/qos.py 
b/lib/vdsm/network/configurators/qos.py
index 6a520eb..dfbff9a 100644
--- a/lib/vdsm/network/configurators/qos.py
+++ b/lib/vdsm/network/configurators/qos.py
@@ -21,9 +21,9 @@
 import os
 from distutils.version import StrictVersion
 
+from vdsm.network import tc
 from vdsm.network.netinfo.cache import ifaceUsed
 from vdsm.network.netinfo import qos as netinfo_qos
-from vdsm import tc
 
 _ROOT_QDISC_HANDLE = '%x:' % 5001  # Leave 0 free for leaf qdisc of vlan tag 0
 _FAIR_QDISC_KIND = 'fq_codel' if (StrictVersion(os.uname()[2].split('-')[0]) >
diff --git a/lib/vdsm/network/netinfo/qos.py b/lib/vdsm/network/netinfo/qos.py
index 7741118..6268587 100644
--- a/lib/vdsm/network/netinfo/qos.py
+++ b/lib/vdsm/network/netinfo/qos.py
@@ -21,7 +21,7 @@
 
 from collections import defaultdict
 
-from vdsm import tc
+from vdsm.network import tc
 
 NON_VLANNED_ID = 5000
 DEFAULT_CLASSID = '%x' % NON_VLANNED_ID
diff --git a/lib/vdsm/tc/Makefile.am b/lib/vdsm/network/tc/Makefile.am
similarity index 95%
rename from lib/vdsm/tc/Makefile.am
rename to lib/vdsm/network/tc/Makefile.am
index 80a8db8..66a2af4 100644
--- a/lib/vdsm/tc/Makefile.am
+++ b/lib/vdsm/network/tc/Makefile.am
@@ -19,7 +19,7 @@
 
 include $(top_srcdir)/build-aux/Makefile.subs
 
-vdsmnetworktcdir = $(vdsmpylibdir)/tc
+vdsmnetworktcdir = $(vdsmpylibdir)/network/tc
 dist_vdsmnetworktc_PYTHON = \
__init__.py \
_parser.py \
diff --git a/lib/vdsm/tc/__init__.py b/lib/vdsm/network/tc/__init__.py
similarity index 100%
rename from lib/vdsm/tc/__init__.py
rename to lib/vdsm/network/tc/__init__.py
diff --git a/lib/vdsm/tc/_parser.py b/lib/vdsm/network/tc/_parser.py
similarity index 100%
rename from lib/vdsm/tc/_parser.py
rename to lib/vdsm/network/tc/_parser.py
diff --git a/lib/vdsm/tc/_wrapper.py b/lib/vdsm/network/tc/_wrapper.py
similarity index 100%
rename from lib/vdsm/tc/_wrapper.py
rename to lib/vdsm/network/tc/_wrapper.py
diff --git a/lib/vdsm/tc/cls.py b/lib/vdsm/network/tc/cls.py
similarity index 100%
rename from lib/vdsm/tc/cls.py
rename to lib/vdsm/network/tc/cls.py
diff --git a/lib/vdsm/tc/filter.py b/lib/vdsm/network/tc/filter.py
similarity index 100%
rename from lib/vdsm/tc/filter.py
rename to lib/vdsm/network/tc/filter.py
diff --git a/lib/vdsm/tc/qdisc.py b/lib/vdsm/network/tc/qdisc.py
similarity index 100%
rename from lib/vdsm/tc/qdisc.py
rename to lib/vdsm/network/tc/qdisc.py
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 3fb9797..21062b8 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -48,9 +48,9 @@
 from vdsm.network import errors
 from vdsm.network import legacy_switch
 from vdsm.network import sourceroute
+from vdsm.network

Change in vdsm[master]: net: Move netlink under vdsm.network

2016-05-07 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: Move netlink under vdsm.network
..


Patch Set 1: Verified+1

Unit and Functional tests are passing

-- 
To view, visit https://gerrit.ovirt.org/57170
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97559234dc5595fe90d5258c31450858560246ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Move netlink under vdsm.network

2016-05-07 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Move netlink under vdsm.network
..

net: Move netlink under vdsm.network

Change-Id: I97559234dc5595fe90d5258c31450858560246ce
Signed-off-by: Edward Haas 
---
M configure.ac
M init/wait_for_ipv4s
M lib/vdsm/Makefile.am
M lib/vdsm/ipwrapper.py
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/netinfo/addresses.py
M lib/vdsm/network/netinfo/cache.py
M lib/vdsm/network/netinfo/routes.py
M lib/vdsm/network/netinfo/vlans.py
R lib/vdsm/network/netlink/Makefile.am
R lib/vdsm/network/netlink/__init__.py
R lib/vdsm/network/netlink/addr.py
R lib/vdsm/network/netlink/link.py
R lib/vdsm/network/netlink/monitor.py
R lib/vdsm/network/netlink/route.py
M tests/functional/networkTests.py
M tests/network/ipwrapper_test.py
M tests/network/link_test.py
M tests/network/netinfo_test.py
M tests/network/nettestlib.py
M vdsm.spec.in
23 files changed, 33 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/57170/1

diff --git a/configure.ac b/configure.ac
index 5a076c9..c43ab5d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -382,7 +382,6 @@
lib/vdsm/Makefile
lib/vdsm/common/Makefile
lib/vdsm/common/network/Makefile
-   lib/vdsm/netlink/Makefile
lib/vdsm/profiling/Makefile
lib/vdsm/tool/Makefile
lib/vdsm/tool/configurators/Makefile
@@ -397,6 +396,7 @@
lib/vdsm/network/configurators/Makefile
lib/vdsm/network/ip/Makefile
lib/vdsm/network/netinfo/Makefile
+   lib/vdsm/network/netlink/Makefile
lib/vdsm/network/ovs/Makefile
lib/vdsm/network/ovs/driver/Makefile
lib/vdsm/rpc/Makefile
diff --git a/init/wait_for_ipv4s b/init/wait_for_ipv4s
index bf75acb..3d04ee8 100755
--- a/init/wait_for_ipv4s
+++ b/init/wait_for_ipv4s
@@ -10,10 +10,10 @@
 from os.path import isfile, join
 import sys
 
-from vdsm.network.netinfo.addresses import getIpInfo
-from vdsm.netlink import monitor
 from vdsm.network.configurators.ifcfg import NET_CONF_DIR
 from vdsm.network.configurators.ifcfg import ConfigWriter
+from vdsm.network.netinfo.addresses import getIpInfo
+from vdsm.network.netlink import monitor
 
 
 def _get_vdsm_ip_onboot_devs():
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 6f38995..7696bd1 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -19,7 +19,7 @@
 #
 include $(top_srcdir)/build-aux/Makefile.subs
 
-SUBDIRS=common netlink tool infra profiling rpc tc network virt storage
+SUBDIRS=common tool infra profiling rpc tc network virt storage
 
 dist_vdsmpylib_PYTHON = \
__init__.py \
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 499fa42..d9f52b9 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -31,11 +31,12 @@
 from netaddr import IPAddress
 from netaddr import IPNetwork
 
+from vdsm.network.netlink import link
+
 from .config import config
 from .utils import anyFnmatch
 from .utils import CommandPath
 from .commands import execCmd
-from .netlink import link
 
 _IP_BINARY = CommandPath('ip', '/sbin/ip')
 
diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index ca5deab..e0fc55f 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -17,7 +17,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
-SUBDIRS = configurators ip netinfo ovs
+SUBDIRS = configurators ip netinfo netlink ovs
 
 include $(top_srcdir)/build-aux/Makefile.subs
 
diff --git a/lib/vdsm/network/configurators/__init__.py 
b/lib/vdsm/network/configurators/__init__.py
index 8472f2d..6246c1a 100644
--- a/lib/vdsm/network/configurators/__init__.py
+++ b/lib/vdsm/network/configurators/__init__.py
@@ -23,9 +23,9 @@
 
 from vdsm.config import config
 from vdsm import ipwrapper
-from vdsm.network.netinfo import mtus
-from vdsm.netlink import monitor
 from vdsm.network.netconfpersistence import RunningConfig
+from vdsm.network.netinfo import mtus
+from vdsm.network.netlink import monitor
 
 from .dhclient import DhcpClient
 from ..errors import ConfigNetworkError, RollbackIncomplete, ERR_FAILED_IFUP
diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index baf3d8d..1b7f7d1 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -41,18 +41,19 @@
 from vdsm import dsaversion
 from vdsm import hooks
 from vdsm import ipwrapper
+from vdsm import sysctl
+from vdsm import utils
+
+from vdsm.network.ip.address import IPv4, IPv6
+from vdsm.network.netconfpersistence import RunningConfig, PersistentConfig
 from vdsm.network.netinfo import (bonding as netinfo_bonding, mtus, nics,
   vlans, misc, NET_PATH)
 from vdsm.network.netinfo.cache import

Change in vdsm[master]: net: Move netlink under vdsm.network

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Move netlink under vdsm.network
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57170
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97559234dc5595fe90d5258c31450858560246ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/57108/1/lib/vdsm/network/netinfo/nics.py
File lib/vdsm/network/netinfo/nics.py:

PS1, Line 44: 0 otherwise
this needs to be updated.


-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1:

please explain (in the commit message) what would happen on Engine side when 
this patch is applied

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

2016-05-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: m2c: get more information about ssl connection
..


m2c: get more information about ssl connection

Sometimes during runtime we see in the logs: "M2Crypto.SSL.SSLError:
unexpected eof". In order to understand the state of the connection we
want temporarily print ssl session information.

This patch provides a configuration flag to enable/disable logging.


Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/57016
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/config.py.in
M lib/vdsm/m2cutils.py
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 3: Code-Review+2

raise

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 4:

* #1321325::Update tracker: OK
* Set MODIFIED::bug 1321325#1321325OK

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: dispatcher can return empty string

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: stomp: dispatcher can return empty string
..


Patch Set 4:

* #1321325::Update tracker: OK
* Set MODIFIED::bug 1321325#1321325IGNORE, not all related patches are 
closed, check 56997

-- 
To view, visit https://gerrit.ovirt.org/56996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: dispatcher can return empty string

2016-05-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: dispatcher can return empty string
..


stomp: dispatcher can return empty string

Based on logs provided for BZ I see that dispatcher#recv can return an
empty string which makes parser not to process message and as a result
we get:

exceptions.AttributeError: 'NoneType' object has no attribute 'command'

We need to make sure that we do not attempt to parse the data.


Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Signed-off-by: pkliczewski 
Bug-Url: https://bugzilla.redhat.com/1321325
Reviewed-on: https://gerrit.ovirt.org/56996
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/yajsonrpc/stomp.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: make sure to handle eagain
..


stomp: make sure to handle eagain

Checking asyncore documentation I noticed that we do not process recv
properly. I found that:

Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK

betterAsyncore code was based on asyncore.dispatcher so the issue was
duplicated. We need to make sure to handle errors properly. We base our
errnos on asynchat which include: EAGAIN, EALREADY, EINPROGRESS,
EWOULDBLOCK.


Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Signed-off-by: pkliczewski 
Bug-Url: https://bugzilla.redhat.com/1321325
Related-To: https://bugs.python.org/issue16133
Reviewed-on: https://gerrit.ovirt.org/56997
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: dispatcher can return empty string

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: stomp: dispatcher can return empty string
..


Patch Set 3: Code-Review+2

raise

-- 
To view, visit https://gerrit.ovirt.org/56996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm-api noarch

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: spec: Make vdsm-api noarch
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm-api noarch

2016-05-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: Make vdsm-api noarch
..


spec: Make vdsm-api noarch

vdsm-api package was not marked as noarch by mistake in commit
f684e7527cf3f (spec: Make vdsm arch specific package).

Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/57157
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm-api noarch

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: spec: Make vdsm-api noarch
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: introduce the networkmanager module, with an integration 
test
..


Patch Set 3: Code-Review-1

need to add nmcli to *.packages

-- 
To view, visit https://gerrit.ovirt.org/57062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id83fa34f9ca7ca910f705e5c360ad420c7a0dcfc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm-api noarch

2016-05-07 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: spec: Make vdsm-api noarch
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm-api noarch

2016-05-07 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Make vdsm-api noarch
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff437e8e7c310fe458ddee3094ea30084569216
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches