Change in vdsm[master]: ovs: use ovsdb factory
Petr Horáček has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 5: Verified+1 Passed network/*_test.py OK -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use ovsdb factory
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use ovsdb factory
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use ovsdb factory
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use ovsdb factory
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire external ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 13: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use Setup class directly
Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60405/2/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 154: # We should implement editation. Line 155: nets2add.update(nets2edit) Line 156: nets2remove.update(nets2edit) Line 157: Line 158: ovsdb = ovs_driver.create() > I'd prefer to call stages directly from here. Calling a function which crea Ok, call the stages from here, just hide the driver inside the factory then. You should introduce the factory in this patch, so it will glue the needed to return a Setup instance. Line 159: Line 160: with Transaction(in_rollback=in_rollback) as config: Line 161: with ovs_switch.Setup(ovsdb, _ovs_info) as s: Line 162: s.remove_nets(nets2remove) -- To view, visit https://gerrit.ovirt.org/60405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa674f479d569356775812931c832ef37f1fe2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Support multiple FakeResourceManager usage patterns
gerrit-hooks has posted comments on this change. Change subject: tests: Support multiple FakeResourceManager usage patterns .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdb851f0e66b8c880761ffddd126d2e52c2e30e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: copy_data locking
gerrit-hooks has posted comments on this change. Change subject: wip: copy_data locking .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44e1f1709ee81c14b3d165bbf3a6597ac50b68e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Implement SDM.copy_data
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff635c0c73f67b296033b4a506fc3b9ededfbe Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: copy_data locking
Adam Litke has uploaded a new change for review.
Change subject: wip: copy_data locking
..
wip: copy_data locking
Change-Id: Ie44e1f1709ee81c14b3d165bbf3a6597ac50b68e
Signed-off-by: Adam Litke
---
M tests/storage_sdm_copy_data_test.py
M vdsm/storage/sdm/api/copy_data.py
2 files changed, 94 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/60825/1
diff --git a/tests/storage_sdm_copy_data_test.py
b/tests/storage_sdm_copy_data_test.py
index 3e90778..b6e2f98 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -37,6 +37,11 @@
import storage.sdm.api.copy_data
+class FakeTaskContext(object):
+def getSharedLock(*args):
+pass
+
+
@expandPermutations
class CopyDataTests(VdsmTestCase):
SIZE = 1048576
@@ -54,8 +59,11 @@
with make_env() as env:
rm = FakeResourceManager()
+fake_task_ctx = FakeTaskContext()
with MonkeyPatchScope([
+(storage.sdm.api.copy_data, 'rmanager', rm),
(storage.sdm.api.copy_data, 'sdCache', env.sdcache),
+(storage.sdm.api.copy_data.vars, 'task', fake_task_ctx),
(blockVolume, 'rmanager', rm),
]):
src_img_id = str(uuid.uuid4())
diff --git a/vdsm/storage/sdm/api/copy_data.py
b/vdsm/storage/sdm/api/copy_data.py
index 82e0e61..5956477 100644
--- a/vdsm/storage/sdm/api/copy_data.py
+++ b/vdsm/storage/sdm/api/copy_data.py
@@ -19,6 +19,7 @@
#
from __future__ import absolute_import
+from collections import namedtuple
from contextlib import contextmanager
import logging
@@ -26,11 +27,19 @@
from vdsm import properties
from vdsm import qemuimg
from vdsm.storage import constants as sc
+from vdsm.storage.threadlocal import vars
-from storage import volume
+from storage import resourceManager as rm
+from storage import sd, volume
+from storage.resourceFactories import IMAGE_NAMESPACE
from storage.sdc import sdCache
from . import base
+
+rmanager = rm.ResourceManager.getInstance()
+
+
+DivEndpointImageLock = namedtuple('DivEndpointImageLock', 'ns, img, type')
class Job(base.Job):
@@ -43,8 +52,13 @@
def __init__(self, job_id, host_id, source, destination):
super(Job, self).__init__(job_id, 'copy_data', host_id)
self._operation = None
+self._sorted_domain_locks = []
+self._sorted_image_locks = []
+
self.source = _create_endpoint(source)
self.destination = _create_endpoint(destination)
+self._determine_vdsm_locks()
+self._acquire_vdsm_domains()
@property
def progress(self):
@@ -54,22 +68,78 @@
if self._operation:
self._operation.abort()
-def _run(self):
-# TODO: LOCKING!
-with self.source.prepare(), \
-self.destination.prepare(writable=True):
-# Do not start copying if we have already been aborted
-if self._status == jobs.STATUS.ABORTED:
-return
+def _determine_vdsm_locks(self):
+# Locks taken:
+# - Domain (one shared lock per domain involved in the operation)
+# - Image (shared on source, exclusive on destination):
+# - Activates logical volumes when using block storage
+# - Protects source image against modification on this host
+# - Reserves destination image for exclusive access on this host
+# Locking convention:
+# - All domain locks must be taken before any image locks.
+# - Locks must be taken in sorted order to prevent deadlock.
+# Caveats:
+# - These locks don't block other hosts. We would need to use
+# volume leases for all operations to get this protection. For now
+# engine is responsible for avoiding conflicting commands.
+# - Taking an exclusive lock on the destination image prevents
+# concurrent copy_data operations from taking place on the same host.
+# To allow this, we'll need to lock the destination image in shared
+# mode and the destination volume in exclusive mode. This requires
+# changes to the resourceManager.
+domain_locks = set()
+image_locks = list()
+if isinstance(self.source, CopyDataDivEndpoint):
+domain_locks.add(self.source.sd_id)
+img_res_ns = sd.getNamespace(self.source.sd_id, IMAGE_NAMESPACE)
+lock = DivEndpointImageLock(img_res_ns, self.source.img_id,
+rm.LockType.shared)
+image_locks.append(lock)
+if isinstance(self.destination, CopyDataDivEndpoint):
+domain_locks.add(self.destination.sd_id)
+img_res_ns = sd.getNamespace(self.destination.sd_id,
+ IMAGE_NAMESPACE)
+lock = DivEndpointImageLock
Change in vdsm[master]: ovs: use Setup class directly
Petr Horáček has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60405/2/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 154: # We should implement editation. Line 155: nets2add.update(nets2edit) Line 156: nets2remove.update(nets2edit) Line 157: Line 158: ovsdb = ovs_driver.create() > I think I found where you tried to use it. I'd prefer to call stages directly from here. Calling a function which creates an instance of an object, calls some methods and returns instance feels strange. Factory function is introduced in following patch. Line 159: Line 160: with Transaction(in_rollback=in_rollback) as config: Line 161: with ovs_switch.Setup(ovsdb, _ovs_info) as s: Line 162: s.remove_nets(nets2remove) -- To view, visit https://gerrit.ovirt.org/60405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa674f479d569356775812931c832ef37f1fe2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use ovsdb factory
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: use ovsdb factory
Petr Horáček has uploaded a new change for review. Change subject: ovs: use ovsdb factory .. ovs: use ovsdb factory Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček --- M lib/vdsm/network/netswitch.py M lib/vdsm/network/ovs/switch.py 2 files changed, 18 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/60824/1 diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py index 954bd46..b0dac9a 100644 --- a/lib/vdsm/network/netswitch.py +++ b/lib/vdsm/network/netswitch.py @@ -155,10 +155,8 @@ nets2add.update(nets2edit) nets2remove.update(nets2edit) -ovsdb = ovs_driver.create() - with Transaction(in_rollback=in_rollback) as config: -with ovs_switch.Setup(ovsdb, _ovs_info) as s: +with ovs_switch.Setup(_ovs_info) as s: s.remove_nets(nets2remove) s.remove_bonds(bonds2remove) s.edit_bonds(bonds2edit) diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py index 37c8652..a591061 100644 --- a/lib/vdsm/network/ovs/switch.py +++ b/lib/vdsm/network/ovs/switch.py @@ -46,16 +46,30 @@ bond, attrs, nets, _netinfo['networks'], kernel_nics) +class OvsDbFactory(object): + +def __init__(self): +self.ovsdb = None + +def call(self): +if not self.ovsdb: +self.ovsdb = driver.create() +return self.ovsdb + + +ovsdb_factory = OvsDbFactory() + + def cleanup(): -ovsdb = driver.create() +ovsdb = ovsdb_factory() with ovsdb.transaction() as t: t.add(*_cleanup_unused_bridges(ovsdb)) # TODO: We could move all setup() code into __init__ and __exit__. class Setup(object): -def __init__(self, ovsdb, ovs_info): -self._ovsdb = ovsdb +def __init__(self, ovs_info): +self._ovsdb = ovsdb_factory() self._transaction = self._ovsdb.transaction() self._ovs_info = ovs_info self._bridges_by_sb = ovs_info.bridges_by_sb -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1fd847d4eeb6309c4978810a903ba1accc8b92fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Support multiple FakeResourceManager usage patterns
Adam Litke has uploaded a new change for review.
Change subject: tests: Support multiple FakeResourceManager usage patterns
..
tests: Support multiple FakeResourceManager usage patterns
ResourceManager locks can be taken using a with statement or with explicit
calls to rm.acquireResource and rm.releaseResource. Enhance our Fake to allow
both types of calls.
Change-Id: Ifcdb851f0e66b8c880761ffddd126d2e52c2e30e
Signed-off-by: Adam Litke
---
M tests/storage_sdm_create_volume_test.py
M tests/storagefakelib.py
M tests/storagefakelibTests.py
3 files changed, 52 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/60823/1
diff --git a/tests/storage_sdm_create_volume_test.py
b/tests/storage_sdm_create_volume_test.py
index b367dbc..4bdbd7a 100644
--- a/tests/storage_sdm_create_volume_test.py
+++ b/tests/storage_sdm_create_volume_test.py
@@ -125,10 +125,12 @@
# Verify that the image resource was locked and released
image_ns = sd.getNamespace(job.sd_manifest.sdUUID, IMAGE_NAMESPACE)
-rm_args = (image_ns, job.vol_info.img_id, rm.LockType.exclusive)
-self.assertEqual([('acquireResource', rm_args, {}),
- ('releaseResource', rm_args, {})],
- self.rm.__calls__)
+self.assertEqual([
+('acquireResource',
+ (image_ns, job.vol_info.img_id, rm.LockType.exclusive), {}),
+('releaseResource',
+ (image_ns, job.vol_info.img_id), {})],
+self.rm.__calls__)
def test_create_volume_domainlock_contended(self):
def error(*args):
diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 7ea0cee..2e3d65e 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -20,7 +20,6 @@
import os
import string
import random
-from contextlib import contextmanager
from copy import deepcopy
from testlib import make_file, recorded
@@ -278,16 +277,34 @@
class FakeResourceManager(object):
-@recorded
-@contextmanager
-def acquireResource(self, *args, **kwargs):
-try:
-yield
-finally:
-self.releaseResource(*args, **kwargs)
+def __init__(self):
+self.resources = {}
+
+class FakeResource(object):
+def __init__(self, ns, name, rm):
+self.ns = ns
+self.name = name
+self._rm = rm
+self.acquired = True
+
+def __enter__(self):
+return self
+
+def __exit__(self, exc_type, exc_value, traceback):
+self.release()
+
+def release(self):
+self._rm.releaseResource(self.ns, self.name)
+self.acquired = False
@recorded
-def releaseResource(self, *args, **kwargs):
+def acquireResource(self, namespace, name, lockType, timeout=None):
+res = self.FakeResource(namespace, name, self)
+self.resources[(namespace, name)] = res
+return res
+
+@recorded
+def releaseResource(self, namespace, name):
pass
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 2913eff..8253e2b 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -362,16 +362,28 @@
class FakeResourceManagerTests(VdsmTestCase):
-def test_acquire_contextmanager(self):
-expected_calls = []
-rm = FakeResourceManager()
-acquire_args = ('ns', 'name', 'locktype')
-with rm.acquireResource(*acquire_args):
-expected_calls.append(('acquireResource', acquire_args, {}))
-self.assertEqual(expected_calls, rm.__calls__)
-expected_calls.append(('releaseResource', acquire_args, {}))
+def _check_calls(self, rm):
+expected_calls = [
+('acquireResource', ('ns', 'name', 'locktype'), {}),
+('releaseResource', ('ns', 'name'), {})
+]
self.assertEqual(expected_calls, rm.__calls__)
+def test_acquire_contextmanager(self):
+rm = FakeResourceManager()
+with rm.acquireResource('ns', 'name', 'locktype') as res:
+self.assertTrue(res.acquired)
+self.assertFalse(res.acquired)
+self._check_calls(rm)
+
+def test_acquire_release(self):
+rm = FakeResourceManager()
+res = rm.acquireResource('ns', 'name', 'locktype')
+self.assertTrue(res.acquired)
+res.release()
+self.assertFalse(res.acquired)
+self._check_calls(rm)
+
class TestFakeStorageDomainCache(VdsmTestCase):
--
To view, visit https://gerrit.ovirt.org/60823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcdb851f0e66b8c880761ffddd126d2e52c2e30e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vds
Change in vdsm[master]: Implement SDM.copy_data
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff635c0c73f67b296033b4a506fc3b9ededfbe Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Support multiple FakeResourceManager usage patterns
gerrit-hooks has posted comments on this change. Change subject: tests: Support multiple FakeResourceManager usage patterns .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdb851f0e66b8c880761ffddd126d2e52c2e30e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Implement SDM.copy_data
Adam Litke has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/60420/6/vdsm/storage/sdm/api/copy_data.py File vdsm/storage/sdm/api/copy_data.py: Line 59: def _abort(self): Line 60: if self._operation: Line 61: self._operation.abort() Line 62: Line 63: def _acquire(self): > Lets rename to _acquire_domain? sure. Line 64: # Acquire any needed locks before the job is scheduled to run. For Line 65: # vdsm (div) endpoints we must acquire a shared lock on the domain. Line 66: Line 67: # TODO: Move these details into CopyDataDivEndpoint while still Line 66: Line 67: # TODO: Move these details into CopyDataDivEndpoint while still Line 68: # preventing duplicate locking Line 69: domains = set() Line 70: if isinstance(self.source, CopyDataDivEndpoint): > Instead of type check, we can do: I thought of that too, but I still think using the type is better. We should only apply this operation to 'div' endpoints, not any random endpoint type which happens to have an sd_id key. Line 71: domains.add(self.source.sd_id) Line 72: if isinstance(self.destination, CopyDataDivEndpoint): Line 73: domains.add(self.destination.sd_id) Line 74: for domain in sorted(list(domains)): Line 135: return None Line 136: return sc.fmt2str(parent_vol.getFormat()) Line 137: Line 138: @contextmanager Line 139: def protect_image(self, exclusive=False): > This makes sense only for vdsm volume. Yeah, unfortunately the idea of a type agnostic _run() method is seeming not so realistic. We have type-specific _acquire_domain and this is going to have to move to a top-level helper too in order to do the lock sorting you request below. Line 140: # Locks taken: Line 141: # - Image (shared on source, exclusive on destination): Line 142: # - Activates logical volumes when using block storage Line 143: # - Protects source image against modification on this host Line 153: # changes to the resourceManager. Line 154: res_ns = sd.getNamespace(self.sd_id, IMAGE_NAMESPACE) Line 155: lock_type = rm.LockType.exclusive if exclusive else rm.LockType.shared Line 156: with rmanager.acquireResource(res_ns, self.img_id, lock_type): Line 157: yield > We need lock by sorted order, not src and then destination. Is it enough to sort by img_id or must we include the 02c598d8-fc59-4678-9ab6-0b6db3f095e6_imageNS and img_id? Line 158: Line 159: @contextmanager Line 160: def prepare(self, writable=False): Line 161: dom = sdCache.produce_manifest(self.sd_id) -- To view, visit https://gerrit.ovirt.org/60420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff635c0c73f67b296033b4a506fc3b9ededfbe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices.
Francesco Romani has uploaded a new change for review.
Change subject: network: filter out 'veth' devices.
..
network: filter out 'veth' devices.
The `rkt' networking uses a pair of veth for its networking needs;
this configuration step should not be disabled, because it covers
an internal use case, as detailed in
https://coreos.com/rkt/docs/latest/networking/overview.html#the-default-network
This patch makes the Vdsm code ignore this veth pair.
Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Signed-off-by: Francesco Romani
---
M lib/vdsm/network/netinfo/qos.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/60821/1
diff --git a/lib/vdsm/network/netinfo/qos.py b/lib/vdsm/network/netinfo/qos.py
index 6268587..90ee72d 100644
--- a/lib/vdsm/network/netinfo/qos.py
+++ b/lib/vdsm/network/netinfo/qos.py
@@ -36,7 +36,8 @@
iface = attrs['iface']
if iface in netinfo['bridges']:
host_ports = [port for port in attrs['ports'] if
- not port.startswith('vnet')]
+ (not port.startswith('vnet') and
+ not port.startswith('veth'))]
if not host_ports: # Port-less bridge
continue
iface, = host_ports
--
To view, visit https://gerrit.ovirt.org/60821
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: storage: drop legacy drive config support
Francesco Romani has posted comments on this change. Change subject: vm: storage: drop legacy drive config support .. Patch Set 6: So I did additional research navigating Engine 3.6 sources. We use the "drives" field only for cluster version < 3.1. (see CreateVdsCommand.java, VmDeviceCommonUtils.java) In Engine 4.0 this code doesn't exist anymore. I think we are good to go. -- To view, visit https://gerrit.ovirt.org/60323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7f719c8e89fd976cbccdc6e93d124b5e34c9ce7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices.
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Send vm info report each sampling interval from HostMonitor
Francesco Romani has posted comments on this change. Change subject: Send vm info report each sampling interval from HostMonitor .. Patch Set 3: Code-Review-1 name clash still not solved -- To view, visit https://gerrit.ovirt.org/59523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding report_stats to virt.stats
Francesco Romani has posted comments on this change. Change subject: Adding report_stats to virt.stats .. Patch Set 8: Code-Review-1 (1 comment) the more I see translation patches like this, the more I wonder if we should not just passthrough bulk stats. However, another naming comment inside. Besides that, looks ok. https://gerrit.ovirt.org/#/c/59066/8/lib/vdsm/virt/vmstats.py File lib/vdsm/virt/vmstats.py: PS8, Line 244: rx_bytes you accepted my rename suggestion, so, let's make everything consistent and let's name this rx.bytes - same for tx_bytes -> tx.bytes. -- To view, visit https://gerrit.ovirt.org/59066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf494c6a3087d04c12731c587b619f253dd51165 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding report_stats to virt.stats
Francesco Romani has posted comments on this change. Change subject: Adding report_stats to virt.stats .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/59066/8/lib/vdsm/virt/vmstats.py File lib/vdsm/virt/vmstats.py: PS8, Line 214: vm_disk Do you have a document about how the keys should be named? It seems pretty free form now. A convention about naming and a more consistent naming could help later on. I don't really require this, or to have it for this patch, just for discussion. -- To view, visit https://gerrit.ovirt.org/59066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf494c6a3087d04c12731c587b619f253dd51165 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move master to fc24
Sandro Bonazzola has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: It's a matter of jenkins resources, there's not enough to keep building more than one fedora release per ovirt branch. And fedora 23 will be EOL for 4.1 GA. -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: always expect Vm devices to be sent
Francesco Romani has posted comments on this change. Change subject: vm: always expect Vm devices to be sent .. Patch Set 6: fc24 slave broken? ./automation/check-patch.sh: line 7: easy_install: command not found -- To view, visit https://gerrit.ovirt.org/60322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d0b413d77bb908df218e3e009977f928a432b9d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: graphics: report display info from device
Francesco Romani has posted comments on this change. Change subject: vm: graphics: report display info from device .. Patch Set 6: fc24 slave broken? 00:01:08.385 ./automation/check-patch.sh: line 7: easy_install: command not found -- To view, visit https://gerrit.ovirt.org/60320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f501addd40458887ae27cd9615a8856a02d8967 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: graphics: drop legacy configuration support
Francesco Romani has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 6: fc24 slave broken? ./automation/check-patch.sh: line 7: easy_install: command not found -- To view, visit https://gerrit.ovirt.org/60321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d38380032ba78384cc55f48bb0d4d322dc4993 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move master to fc24
Francesco Romani has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: Code-Review+1 looks like our fedora jenkins slave are only on fc24. So we don't actually need fc23 back compatibility, at least not now. Please ignore my last comment. -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move master to fc24
Francesco Romani has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: I'd keep fc23, us dev (for whatever reason) don't jump on fedora.next so often, so keeping fedora.prev around for a while is needed. So: - rename existing lists fc23->fc24, so duplication doesn't get worse, like you did already - symlink new fc24 to fc23, to give people more time to upgrade. TL;DR: add a few symlinks and that's it, should be simple and effective. -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: network: drop legacy network config support
Edward Haas has posted comments on this change. Change subject: vm: network: drop legacy network config support .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13eefe3503cd4e0d942f146b220522e3a9199f9e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding report_stats to virt.stats
gerrit-hooks has posted comments on this change. Change subject: Adding report_stats to virt.stats .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf494c6a3087d04c12731c587b619f253dd51165 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Modify reports to metrics
Yaniv Bronhaim has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Send vm info report each sampling interval from HostMonitor
gerrit-hooks has posted comments on this change. Change subject: Send vm info report each sampling interval from HostMonitor .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: supervdsm: configure container networks
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 29: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: virt: add optional container support
gerrit-hooks has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 36: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: utils: add is_kvm helper
gerrit-hooks has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: split guest agent init from domDependentInit
gerrit-hooks has posted comments on this change. Change subject: vm: split guest agent init from domDependentInit .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: core: containers: add the container support module
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vmxml: move namespace declaration
gerrit-hooks has posted comments on this change. Change subject: vmxml: move namespace declaration .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33d816707cc76d4cce61a7d61d42a4304737ee6 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: supervdsm: expose systemd utilities
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vmxml: export container metadata
gerrit-hooks has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: reorder operations in _domDependentInit
gerrit-hooks has posted comments on this change. Change subject: vm: reorder operations in _domDependentInit .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
gerrit-hooks has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: enhance systemd_run
gerrit-hooks has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: reorder sampling initialization
gerrit-hooks has posted comments on this change. Change subject: vm: reorder sampling initialization .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59815 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77e9575ade075d21b36f72915e4d4f2bf5badf92 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: split vcpu settings from domDependentInit
gerrit-hooks has posted comments on this change. Change subject: vm: split vcpu settings from domDependentInit .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9907a428b00d5851ece0037acfcc1ad72442ae46 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: split device init from domDependentInit
gerrit-hooks has posted comments on this change. Change subject: vm: split device init from domDependentInit .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: docs: add README about logging configuration
Michal Skrivanek has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/60533/1/README.logging File README.logging: Line 36: Line 37: Examples of runtime tuning of logging Line 38: - Line 39: Line 40: WRITEME how about just "vdsClient -s 0 setLogLevel DEBUG"?:) Line 41: Line 42: Notes Line 43: - Line 44: -- To view, visit https://gerrit.ovirt.org/60533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move master to fc24
Sandro Bonazzola has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: Verified+1 build works: http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-fc24-x86_64/6/console -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: storage: drop legacy drive config support
Milan Zamazal has posted comments on this change. Change subject: vm: storage: drop legacy drive config support .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7f719c8e89fd976cbccdc6e93d124b5e34c9ce7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: network: drop legacy network config support
gerrit-hooks has posted comments on this change. Change subject: vm: network: drop legacy network config support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13eefe3503cd4e0d942f146b220522e3a9199f9e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: drop legacy device config support
gerrit-hooks has posted comments on this change. Change subject: virt: drop legacy device config support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29b633877a476bbfe707ea83e438095b175ac5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: graphics: report display info from device
gerrit-hooks has posted comments on this change. Change subject: vm: graphics: report display info from device .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f501addd40458887ae27cd9615a8856a02d8967 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: graphics: drop legacy graphics config support
gerrit-hooks has posted comments on this change. Change subject: vm: graphics: drop legacy graphics config support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26cb3f984eb847d6b11871b7245b3508b02f71dc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: graphics: drop legacy configuration support
gerrit-hooks has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d38380032ba78384cc55f48bb0d4d322dc4993 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: always expect Vm devices to be sent
gerrit-hooks has posted comments on this change. Change subject: vm: always expect Vm devices to be sent .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d0b413d77bb908df218e3e009977f928a432b9d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: storage: drop legacy drive config support
gerrit-hooks has posted comments on this change. Change subject: vm: storage: drop legacy drive config support .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7f719c8e89fd976cbccdc6e93d124b5e34c9ce7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: storage: drop legacy graphics config support
Francesco Romani has posted comments on this change. Change subject: vm: storage: drop legacy graphics config support .. Patch Set 5: Right, fixed. -- To view, visit https://gerrit.ovirt.org/60325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26cb3f984eb847d6b11871b7245b3508b02f71dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: remft: Add online help
Francesco Romani has posted comments on this change. Change subject: remft: Add online help .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: remft: Add online help
Francesco Romani has posted comments on this change. Change subject: remft: Add online help .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: refmt: Use more standard main() function
Francesco Romani has posted comments on this change. Change subject: refmt: Use more standard main() function .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: storage: drop legacy network config support
Francesco Romani has posted comments on this change. Change subject: vm: storage: drop legacy network config support .. Patch Set 5: Right, fixed. -- To view, visit https://gerrit.ovirt.org/60324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13eefe3503cd4e0d942f146b220522e3a9199f9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move master to fc24
Sandro Bonazzola has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: Removed fc23 duplication since fc23 is not supported anymore on master. -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: automation: move master to fc24
gerrit-hooks has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: stomp: make client user aware that no connection available
Sandro Bonazzola has posted comments on this change. Change subject: stomp: make client user aware that no connection available .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/58029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c0a2b2df9ac6e9f6e75a8af0f0f3a36990c2462 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: replace vdscli with jsonrpcvdscli
Nir Soffer has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/60605/3/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 128
Line 129
Line 130
Line 131
Line 132
I don't think we need this - jsonrpc probably return list of strings. This code
seem to handle the "human" readable format generated by vdsClient.
Line 122: requestQueue = requestQueues.split(",")[0]
Line 123: cli = jsonrpcvdscli.connect(requestQueue=requestQueue,)
Line 124:
Line 125: self.addStringAsFile(
Line 126: json.dumps(cli.getVdsCapabilities()),
'cli.getVdsCapabilities')
Why do we need the "cli." prefix?
Line 127: self.addStringAsFile(
Line 128: json.dumps(cli.getAllVmStats()), 'cli.getAllVmStats')
Line 129: self.addStringAsFile(json.dumps(cli.list()), 'cli.list')
Line 130: self.addStringAsFile(
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc1ba745dad6d3eba9f480830ea01774eb4db71
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: removed call to vdsClient getVGList
Nir Soffer has posted comments on this change. Change subject: sos report: removed call to vdsClient getVGList .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c39da7b1b87dd00be3e4302e8f7d7dba76faf0d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos: added full module name to _importVdsmPylibModule
Nir Soffer has posted comments on this change.
Change subject: sos: added full module name to _importVdsmPylibModule
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/60627/4/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 43
Line 44
Line 45
Line 46
Line 47
Looking at the non-standard class name, it seem that the class name should be
"vdsm", not the module name. I bet that sos is importing files in some
directory, and looking for Plugin subclasses.
Please check this with sos maintainer.
Line 30:
Line 31:
Line 32: # This is hack for import vdsm modules. because this plugin's name was
Line 33: # same with vdsm module, so it can not import vdsm modules directly.
And we
Line 34: # keep plugin's name for compatibility.
Please check if we really have to keep the plugin plugin name, maybe this
comment is outdated and we can rename this file, eliminating the need for
complex hacks.
Line 35: def _importVdsmPylibModule(modName):
Line 36: import imp
Line 37: from distutils.sysconfig import get_python_lib
Line 38: modFile, modPath, modDesc = imp.find_module(
Line 39: modName, [os.path.join(get_python_lib(False), "vdsm")])
Line 40: fullName = os.path.splitext(modPath)[0].replace(os.path.sep, '.')
Line 41: index = fullName.find("vdsm")
Line 42: fullName = fullName[index:]
Line 43: mod = imp.load_module(fullName, modFile, modPath, modDesc)
Testing with other modules show that we need the qualified name
of a module.
But the manipulation you suggest is complex and not complete -
when we import "pkg1.pkg2.module", we need to import first "pkg1",
then "pkg1.pkg2" and finally "pkg1.pkg2.module".
Also the file returned from find_module must be closed.
See https://docs.python.org/2/library/imp.html#imp.find_module.
This is a more complete version:
def import_from_sitelib(full_name):
parts = full_name.split(".")
search = get_python_sitelib(False)
full_name = ""
for name in parts:
if full_name:
full_name += "."
full_name += name
f, path, desc = imp.find_module(name, [search])
try:
module = imp.load_module(full_name, f, path, desc)
finally:
if f:
f.close()
search = os.path.join(search, name)
return module
Tested with vdsm.config, vdsm.jsonrpcvdcli and vdsm.storage.constants.
Line 44: return mod
Line 45:
Line 46:
Line 47: config = _importVdsmPylibModule('config').config
--
To view, visit https://gerrit.ovirt.org/60627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: added getAllTasksInfo verb
Nir Soffer has posted comments on this change. Change subject: jsonrpcvdscli: added getAllTasksInfo verb .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c02c3aeb35b1b6dbddbdce66f8112aa281a0bc6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos: added full module name to _importVdsmPylibModule
Nir Soffer has posted comments on this change.
Change subject: sos: added full module name to _importVdsmPylibModule
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/60627/4/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 33
Line 34
Line 35
Line 36
Line 37
This code works for me, without the changes that you suggest:
>>> file, path, desc = imp.find_module("config",
>>> ["/home/nsoffer/src/vdsm/lib/vdsm"])
>>> file
>>> path
'/home/nsoffer/src/vdsm/lib/vdsm/config.py'
>>> imp.load_module("config", file, path, desc)
Maybe you are trying to run this code when vdsm package is not installed,
or you are searching in the wrong python site packages?
--
To view, visit https://gerrit.ovirt.org/60627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: refmt: Use more standard main() function
Nir Soffer has posted comments on this change. Change subject: refmt: Use more standard main() function .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: remft: Add online help
Nir Soffer has posted comments on this change. Change subject: remft: Add online help .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: refmt: Use more standard main() function
Nir Soffer has uploaded a new change for review.
Change subject: refmt: Use more standard main() function
..
refmt: Use more standard main() function
There is no need to make main() private.
Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb
Signed-off-by: Nir Soffer
---
M contrib/refmt
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/60769/1
diff --git a/contrib/refmt b/contrib/refmt
index ba72666..f5bc32d 100755
--- a/contrib/refmt
+++ b/contrib/refmt
@@ -66,7 +66,7 @@
import sys
-def _main():
+def main():
parser = argparse.ArgumentParser(description='Reformat python literals')
parser.add_argument("file", nargs="*",
help="Files to reformat, nothing to process stdin")
@@ -77,4 +77,4 @@
if __name__ == '__main__':
-_main()
+main()
--
To view, visit https://gerrit.ovirt.org/60769
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: remft: Add online help
gerrit-hooks has posted comments on this change. Change subject: remft: Add online help .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: refmt: Use more standard main() function
gerrit-hooks has posted comments on this change. Change subject: refmt: Use more standard main() function .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: remft: Add online help
Nir Soffer has uploaded a new change for review.
Change subject: remft: Add online help
..
remft: Add online help
Example:
$ contrib/refmt -h
usage: refmt [-h] [file [file ...]]
Reformat python literals
positional arguments:
fileFiles to reformat, nothing to process stdin
optional arguments:
-h, --help show this help message and exit
Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc
Signed-off-by: Nir Soffer
---
M contrib/refmt
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/60768/1
diff --git a/contrib/refmt b/contrib/refmt
index fc59126..ba72666 100755
--- a/contrib/refmt
+++ b/contrib/refmt
@@ -60,12 +60,17 @@
#'valid': True,
#'version': 3}}
+import argparse
import fileinput
import pprint
import sys
def _main():
+parser = argparse.ArgumentParser(description='Reformat python literals')
+parser.add_argument("file", nargs="*",
+help="Files to reformat, nothing to process stdin")
+parser.parse_args()
for line in fileinput.input():
obj = eval(line)
pprint.pprint(obj)
--
To view, visit https://gerrit.ovirt.org/60768
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
