Change in vdsm[master]: v2v: add test for Xen block device
Shahar Havivi has posted comments on this change. Change subject: v2v: add test for Xen block device .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/63022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Define netlink netdev flags constants under netlink.link
Edward Haas has posted comments on this change. Change subject: net: Define netlink netdev flags constants under netlink.link .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/63040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338c3ad27426fcd67457026c84565a59bf2a6e77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Set dummy ifaces up by default.
Edward Haas has posted comments on this change. Change subject: net tests: Set dummy ifaces up by default. .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/62834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Introduce waitfor_link method and use it in iface module
Edward Haas has posted comments on this change. Change subject: net: Introduce waitfor_link method and use it in iface module .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3808ef0b6dc086ad2770524f60c0d54b101d3383 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: For IP-less networks, wait for link-up on ifup execution
Edward Haas has posted comments on this change. Change subject: net: For IP-less networks, wait for link-up on ifup execution .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id489fb3b021e6b0658691b1a9a6d6652e75c22ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: ifcfg - dhclient should always be stopped
Edward Haas has posted comments on this change. Change subject: net: ifcfg - dhclient should always be stopped .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/62832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.
Edward Haas has posted comments on this change. Change subject: net func tests: Cleanup ifcfg files after each func test. .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/62833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Link setup module - includes bond setup logic.
Edward Haas has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 7: Verified+1 (2 comments) https://gerrit.ovirt.org/#/c/62831/1/lib/vdsm/network/link/setup.py File lib/vdsm/network/link/setup.py: Line 25: Line 26: from .bond import Bond Line 27: Line 28: Line 29: class SetupBonds(object): > will there be a Transaction? I haven't seen a need for now, if you do, please let me know. Line 30: def __init__(self, bonds2add, bonds2edit, bonds2remove): Line 31: self._bonds2add = bonds2add Line 32: self._bonds2edit = bonds2edit Line 33: self._bonds2remove = bonds2remove PS1, Line 44: set > frozenset? Interesting what is the result of operations between a set and a frozenset.. -- To view, visit https://gerrit.ovirt.org/62831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Expose disable IPv6 through ip.address module
Edward Haas has posted comments on this change. Change subject: net: Expose disable IPv6 through ip.address module .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/62830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding bond api with sysfs driver under link
Edward Haas has posted comments on this change. Change subject: net: Adding bond api with sysfs driver under link .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/62828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: dhclient command - iface name should appear at the tail
Edward Haas has posted comments on this change. Change subject: net: dhclient command - iface name should appear at the tail .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/62829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Relocating wait-for-event under its own module.
Edward Haas has posted comments on this change. Change subject: net: Relocating wait-for-event under its own module. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/62876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie99c93083fd4db7a2d20518c06e70da5bc333a71 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding the 'link' package with an iface module
Edward Haas has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/62827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Introduce waitfor_link method and use it in iface module
gerrit-hooks has posted comments on this change. Change subject: net: Introduce waitfor_link method and use it in iface module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3808ef0b6dc086ad2770524f60c0d54b101d3383 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: For IP-less networks, wait for link-up on ifup execution
gerrit-hooks has posted comments on this change. Change subject: net: For IP-less networks, wait for link-up on ifup execution .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id489fb3b021e6b0658691b1a9a6d6652e75c22ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Expose disable IPv6 through ip.address module
gerrit-hooks has posted comments on this change. Change subject: net: Expose disable IPv6 through ip.address module .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: dhclient command - iface name should appear at the tail
gerrit-hooks has posted comments on this change. Change subject: net: dhclient command - iface name should appear at the tail .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding bond api with sysfs driver under link
gerrit-hooks has posted comments on this change. Change subject: net: Adding bond api with sysfs driver under link .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: ifcfg - dhclient should always be stopped
gerrit-hooks has posted comments on this change. Change subject: net: ifcfg - dhclient should always be stopped .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Define netlink netdev flags constants under netlink.link
gerrit-hooks has posted comments on this change. Change subject: net: Define netlink netdev flags constants under netlink.link .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338c3ad27426fcd67457026c84565a59bf2a6e77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.
gerrit-hooks has posted comments on this change. Change subject: net func tests: Cleanup ifcfg files after each func test. .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding the 'link' package with an iface module
gerrit-hooks has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Link setup module - includes bond setup logic.
gerrit-hooks has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Relocating wait-for-event under its own module.
gerrit-hooks has posted comments on this change. Change subject: net: Relocating wait-for-event under its own module. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie99c93083fd4db7a2d20518c06e70da5bc333a71 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: For IP-less networks, wait for link-up on ifup execution
Edward Haas has uploaded a new change for review. Change subject: net: For IP-less networks, wait for link-up on ifup execution .. net: For IP-less networks, wait for link-up on ifup execution Change-Id: Id489fb3b021e6b0658691b1a9a6d6652e75c22ad Signed-off-by: Edward Haas --- M lib/vdsm/network/configurators/ifcfg.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/63043/1 diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py index 9632e89..93a5088 100644 --- a/lib/vdsm/network/configurators/ifcfg.py +++ b/lib/vdsm/network/configurators/ifcfg.py @@ -876,7 +876,8 @@ with wait_for_ip(iface.name): _exec_ifup(iface, cgroup) else: -_exec_ifup(iface, cgroup) +with waitfor.waitfor_linkup(iface.name): +_exec_ifup(iface, cgroup) def _restore_default_bond_options(bond_name, desired_options): -- To view, visit https://gerrit.ovirt.org/63043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id489fb3b021e6b0658691b1a9a6d6652e75c22ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Introduce waitfor_link method and use it in iface module
Edward Haas has uploaded a new change for review.
Change subject: net: Introduce waitfor_link method and use it in iface module
..
net: Introduce waitfor_link method and use it in iface module
Change-Id: I3808ef0b6dc086ad2770524f60c0d54b101d3383
Signed-off-by: Edward Haas
---
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netlink/waitfor.py
2 files changed, 29 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/63042/1
diff --git a/lib/vdsm/network/link/iface.py b/lib/vdsm/network/link/iface.py
index b345ed7..9769f16 100644
--- a/lib/vdsm/network/link/iface.py
+++ b/lib/vdsm/network/link/iface.py
@@ -18,11 +18,9 @@
#
from __future__ import absolute_import
-import logging
-
from vdsm.network import ipwrapper
from vdsm.network.netlink import link
-from vdsm.network.netlink.monitor import Monitor
+from vdsm.network.netlink.waitfor import waitfor_linkup
STATE_UP = 'up'
@@ -64,13 +62,5 @@
def _up_blocking(dev, link_blocking):
-iface_up_check = is_link_up if link_blocking else is_up
-with Monitor(groups=('link',), timeout=2, silent_timeout=True) as mon:
+with waitfor_linkup(dev, link_blocking):
ipwrapper.linkSet(dev, [STATE_UP])
-if iface_up_check(dev):
-return
-mon_device = (e for e in mon if e.get('name') == dev)
-for event in mon_device:
-logging.info('Monitor event: %s', event)
-if link.is_link_up(event.get('flags', 0), link_blocking):
-return
diff --git a/lib/vdsm/network/netlink/waitfor.py
b/lib/vdsm/network/netlink/waitfor.py
index 2b8a138..ad5f247 100644
--- a/lib/vdsm/network/netlink/waitfor.py
+++ b/lib/vdsm/network/netlink/waitfor.py
@@ -22,7 +22,23 @@
from contextlib import contextmanager
import logging
+from . import link
from . import monitor
+
+
+@contextmanager
+def waitfor_linkup(iface, link_blocking=True, timeout=10):
+iface_up_check = _is_link_up if link_blocking else _is_admin_up
+with monitor.Monitor(groups=('link',), timeout=timeout,
+ silent_timeout=True) as mon:
+try:
+yield
+finally:
+if iface_up_check(iface):
+return
+for event in (e for e in mon if e.get('name') == iface):
+if link.is_link_up(event.get('flags', 0), link_blocking):
+return
@contextmanager
@@ -55,8 +71,9 @@
except monitor.MonitorError as e:
if e[0] == monitor.E_TIMEOUT:
logging.warning('Expected event "%s" of interface "%s" '
-'was not caught within the given timeout. '
-'Caught events: %s', expected_event, iface,
+'was not caught within %ssec. '
+'Caught events: %s',
+expected_event, iface, timeout,
caught_events)
else:
raise
@@ -65,3 +82,11 @@
def _is_subdict(subdict, superdict):
return all(item in frozenset(superdict.items())
for item in frozenset(subdict.items()))
+
+
+def _is_admin_up(iface):
+return link.is_link_up(link.get_link(iface)['flags'], check_link=False)
+
+
+def _is_link_up(iface):
+return link.is_link_up(link.get_link(iface)['flags'], check_link=True)
--
To view, visit https://gerrit.ovirt.org/63042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3808ef0b6dc086ad2770524f60c0d54b101d3383
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Set dummy ifaces up by default.
gerrit-hooks has posted comments on this change. Change subject: net tests: Set dummy ifaces up by default. .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Require sanlock version handling EINTR
Nir Soffer has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 9: The fedora version was pushed today to stable, should be available tomorrow. https://bodhi.fedoraproject.org/updates/?packages=sanlock The RHEL version will be available in the next 7.2.z update. -- To view, visit https://gerrit.ovirt.org/61200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Define netlink netdev flags constants under netlink.link
Edward Haas has uploaded a new change for review.
Change subject: net: Define netlink netdev flags constants under netlink.link
..
net: Define netlink netdev flags constants under netlink.link
Add all supported flags and point all usages to the netlink.link module.
Change-Id: I338c3ad27426fcd67457026c84565a59bf2a6e77
Signed-off-by: Edward Haas
---
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netlink/link.py
M tests/network/ipwrapper_test.py
4 files changed, 27 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/63040/1
diff --git a/lib/vdsm/network/ipwrapper.py b/lib/vdsm/network/ipwrapper.py
index 5eb72d6..2f9cb9a 100644
--- a/lib/vdsm/network/ipwrapper.py
+++ b/lib/vdsm/network/ipwrapper.py
@@ -97,8 +97,6 @@
_hiddenBonds = config.get('vars', 'hidden_bonds').split(',')
_hiddenNics = config.get('vars', 'hidden_nics').split(',')
_hiddenVlans = config.get('vars', 'hidden_vlans').split(',')
-IFF_RUNNING = 1 << 6
-IFF_PROMISC = 1 << 8
def __init__(self, address, index, linkType, mtu, name, qdisc, state,
vlanid=None, vlanprotocol=None, master=None, device=None,
@@ -225,10 +223,10 @@
@property
def oper_up(self):
-return bool(link.get_link(self.name)['flags'] & self.IFF_RUNNING)
+return bool(link.get_link(self.name)['flags'] & link.IFF_RUNNING)
def get_promisc(self):
-return bool(link.get_link(self.name)['flags'] & self.IFF_PROMISC)
+return bool(link.get_link(self.name)['flags'] & link.IFF_PROMISC)
def set_promisc(self, value):
"""Takes a boolean to enable/disable Link promiscuity"""
diff --git a/lib/vdsm/network/link/iface.py b/lib/vdsm/network/link/iface.py
index a4be512..0a62d60 100644
--- a/lib/vdsm/network/link/iface.py
+++ b/lib/vdsm/network/link/iface.py
@@ -25,10 +25,6 @@
from vdsm.network.netlink.monitor import Monitor
-IFF_UP = 1 << 0
-IFF_RUNNING = 1 << 6
-IFF_PROMISC = 1 << 8
-
STATE_UP = 'up'
STATE_DOWN = 'down'
@@ -64,7 +60,7 @@
def is_promisc(dev):
-return bool(link.get_link(dev)['flags'] & IFF_PROMISC)
+return bool(link.get_link(dev)['flags'] & link.IFF_PROMISC)
def _up_blocking(dev, link_blocking):
@@ -81,7 +77,7 @@
def _is_iface_up(link_flags, check_link):
-iface_up = link_flags & IFF_UP
+iface_up = link_flags & link.IFF_UP
if check_link:
-iface_up = iface_up and (link_flags & IFF_RUNNING)
+iface_up = iface_up and (link_flags & link.IFF_RUNNING)
return bool(iface_up)
diff --git a/lib/vdsm/network/netlink/link.py b/lib/vdsm/network/netlink/link.py
index 10d7807..39f1d13 100644
--- a/lib/vdsm/network/netlink/link.py
+++ b/lib/vdsm/network/netlink/link.py
@@ -29,6 +29,26 @@
from . import LIBNL_ROUTE, _nl_geterror, _pool, _none_proto
from . import _addr_to_str, CHARBUFFSIZE
+IFF_UP = 1 << 0
+IFF_BROADCAST = 1 << 1
+IFF_DEBUG = 1 << 2
+IFF_LOOPBACK = 1 << 3
+IFF_POINTOPOINT = 1 << 4
+IFF_NOTRAILERS = 1 << 5
+IFF_RUNNING = 1 << 6
+IFF_NOARP = 1 << 7
+IFF_PROMISC = 1 << 8
+IFF_ALLMULTI = 1 << 9
+IFF_MASTER = 1 << 10
+IFF_SLAVE = 1 << 11
+IFF_MULTICAST = 1 << 12
+IFF_PORTSEL = 1 << 13
+IFF_AUTOMEDIA = 1 << 14
+IFF_DYNAMIC = 1 << 15
+IFF_LOWER_UP = 1 << 16
+IFF_DORMANT = 1 << 17
+IFF_ECHO = 1 << 18
+
def get_link(name):
"""Returns the information dictionary of the name specified link."""
diff --git a/tests/network/ipwrapper_test.py b/tests/network/ipwrapper_test.py
index 3d9992a..7e7556b 100644
--- a/tests/network/ipwrapper_test.py
+++ b/tests/network/ipwrapper_test.py
@@ -28,6 +28,7 @@
from vdsm.network.ipwrapper import Route
from vdsm.network.ipwrapper import Rule
from vdsm.network.netlink import monitor
+from vdsm.network.netlink.link import IFF_PROMISC
from .nettestlib import Bridge, requires_brctl
from testlib import VdsmTestCase as TestCaseBase
@@ -134,7 +135,7 @@
link.promisc = True
for event in mon:
if (event['event'] == 'new_link' and
-event.get('flags', 0) & ipwrapper.Link.IFF_PROMISC):
+event.get('flags', 0) & IFF_PROMISC):
return
self.fail("Could not enable promiscuous mode.")
--
To view, visit https://gerrit.ovirt.org/63040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I338c3ad27426fcd67457026c84565a59bf2a6e77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Define netlink netdev flags constants under netlink.link
gerrit-hooks has posted comments on this change. Change subject: net: Define netlink netdev flags constants under netlink.link .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338c3ad27426fcd67457026c84565a59bf2a6e77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Require sanlock version handling EINTR
gerrit-hooks has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 9: * #1356676::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356676::OK, public bug * Check Product::#1356676::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2
gerrit-hooks has posted comments on this change. Change subject: spec: Require ioprocess 0.15.2 .. Patch Set 1: Verified-1 * #1370564::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1370564::OK, public bug * Check Product::#1370564::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1370564::ERROR, wrong target milestone for stable branch, ovirt-4.0.4 should match ^.*3.6.* * Check merged to previous::WARN, Still missing on branches ovirt-4.0, master -- To view, visit https://gerrit.ovirt.org/63038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2
Nir Soffer has uploaded a new change for review.
Change subject: spec: Require ioprocess 0.15.2
..
spec: Require ioprocess 0.15.2
The first time IOProcess.truncate() or IOProcess.touch() is called,
ioprocess keep the file open and will never close it.
Typically when using with vdsm, ioprocess will keep the
__DIRECT_IO_TEST__ file open on shared storage, since the first thing
vdsm does is touching this file.
Keeping open files on shared storage may prevent activation of a storage
domain after it was deactivated.
This is a 3.6 only patch, 4.0 already requires ioprocess 0.16.1
containing this fix.
Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Bug-Url: https://bugzilla.redhat.com/1370564
Signed-off-by: Nir Soffer
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/63038/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index eaa7089..28188ac 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -90,7 +90,7 @@
BuildRequires: psmisc
BuildRequires: python-cpopen >= 1.3
BuildRequires: python-inotify
-BuildRequires: python-ioprocess >= 0.15.0-4
+BuildRequires: python-ioprocess >= 0.15.2
BuildRequires: python-pthreading
BuildRequires: qemu-img
BuildRequires: rpm-python
@@ -122,7 +122,7 @@
Requires: python-inotify
Requires: python-argparse
Requires: python-cpopen >= 1.3
-Requires: python-ioprocess >= 0.15.0-4
+Requires: python-ioprocess >= 0.15.2
Requires: python-pthreading >= 0.1.3-3
Requires: python-six
Requires: python-requests
@@ -311,7 +311,7 @@
Requires: %{name}-infra = %{version}-%{release}
Requires: python-cpopen >= 1.2.3-5
Requires: m2crypto
-Requires: python-ioprocess >= 0.15.0-4
+Requires: python-ioprocess >= 0.15.2
%description python
Shared libraries between the various VDSM packages.
--
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding build-artifacts-manual.sh script
Sharon Naftaly has posted comments on this change. Change subject: Adding build-artifacts-manual.sh script .. Patch Set 7: > I see https://gerrit.ovirt.org/#/c/62779/1 is not helping :\ > Still, the failure seems very much unrelated to your patch. > Can you reproduce the jenkins failure locally (e.g. on your dev. > PC)? > Can you verify in a different way? The two issues seem independent > (Of course we need to fix both). @fromani, I think I understand what happens. build-artifacts-manual is using a tarball I uploaded from a recent build-artifacts job. This tarball contains a test folder that has the code without your change, and therfore it failes. Could you please supply a tarball that contains your patch and I'll test it? -- To view, visit https://gerrit.ovirt.org/62560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Edward Haas has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: remove deprecated BuildRoot macro
gerrit-hooks has posted comments on this change. Change subject: spec: remove deprecated BuildRoot macro .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/62164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: remove deprecated BuildRoot macro
Dan Kenigsberg has posted comments on this change. Change subject: spec: remove deprecated BuildRoot macro .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: remove deprecated BuildRoot macro
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: remove deprecated BuildRoot macro .. spec: remove deprecated BuildRoot macro Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6 Signed-off-by: Douglas Schilling Landgraf Reviewed-on: https://gerrit.ovirt.org/62164 Reviewed-by: Nir Soffer Reviewed-by: Yaniv Bronhaim Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Edward Haas has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 2: -Code-Review Verified+1 -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Edward Haas has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/62995/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1429: self.vdsm_net.save_config() Line 1430: Line 1431: # Terminate the dhclient spawned by the setup to avoid a race Line 1432: # with the source route thread. Line 1433: dhclient.kill(client) > if this is a bug in VDSM, please add a temporary TODO. Done Line 1434: Line 1435: with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO, Line 1436: DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY): Line 1437: with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir: -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Petr Horáček has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
gerrit-hooks has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Petr Horáček has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/62995/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1429: self.vdsm_net.save_config() Line 1430: Line 1431: # Terminate the dhclient spawned by the setup to avoid a race Line 1432: # with the source route thread. Line 1433: dhclient.kill(client) if this is a bug in VDSM, please add a temporary TODO. Line 1434: Line 1435: with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO, Line 1436: DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY): Line 1437: with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir: -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding the 'link' package with an iface module
Petr Horáček has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding bond api with sysfs driver under link
Petr Horáček has posted comments on this change. Change subject: net: Adding bond api with sysfs driver under link .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Vdsm supports only x86, ppc and ppc64
Yaniv Kaul has posted comments on this change. Change subject: Vdsm supports only x86, ppc and ppc64 .. Patch Set 2: Do we have any reason to block building (upstream) on ARM and other interesting platforms? What is the advantage (or does it fail on them and Koji is upset?) -- To view, visit https://gerrit.ovirt.org/62465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6f7a7d9aac6033b60fe592749bab2613b62466a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: implementing StorageDomain.movePV
gerrit-hooks has posted comments on this change. Change subject: implementing StorageDomain.movePV .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74183d13061d114a59da23874c86186457046e94 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: switch type switch
gerrit-hooks has posted comments on this change. Change subject: net: switch type switch .. Patch Set 7: * #1362399::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1362399::OK, public bug * Check Product::#1362399::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: StorageDomain.getInfo - report metadata device for block sd
gerrit-hooks has posted comments on this change. Change subject: StorageDomain.getInfo - report metadata device for block sd .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32c847ae89b9f8f512c3dd8a0fff96fbc753ee5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Define the StorageDomain.reduce API
gerrit-hooks has posted comments on this change. Change subject: Define the StorageDomain.reduce API .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5e41b9fa2df4ffef1f3cbb9fbfc57022ffedd9a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: implementing StorageDomain.reduce
gerrit-hooks has posted comments on this change. Change subject: implementing StorageDomain.reduce .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c68f64b6c90f0af4d3fa4da94d5747b4ad9cfd6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: **WIP** tool: reconfigure containers networks
gerrit-hooks has posted comments on this change. Change subject: **WIP** tool: reconfigure containers networks .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: supervdsm: configure container networks
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 41: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: enhance systemd_run
gerrit-hooks has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 28: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: virt: add optional container support
gerrit-hooks has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 48: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: core: containers: add the container support module
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 30: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: supervdsm: expose systemd utilities
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 28: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: utils: add is_kvm helper
gerrit-hooks has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 32: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vmxml: export container metadata
gerrit-hooks has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
gerrit-hooks has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: filter out Xen VMs with block storage
Francesco Romani has posted comments on this change. Change subject: v2v: filter out Xen VMs with block storage .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: add test for Xen block device
gerrit-hooks has posted comments on this change. Change subject: v2v: add test for Xen block device .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: filter out Xen VMs with block storage
Shahar Havivi has posted comments on this change. Change subject: v2v: filter out Xen VMs with block storage .. Patch Set 3: > OK, I'll bump to +2 as soon as the new patch is posted! sent at https://gerrit.ovirt.org/#/c/63022 -- To view, visit https://gerrit.ovirt.org/62368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: filter out Xen VMs with block storage
gerrit-hooks has posted comments on this change. Change subject: v2v: filter out Xen VMs with block storage .. Patch Set 3: * #1365411::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1365411::OK, public bug * Check Product::#1365411::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: add test for Xen block device
Shahar Havivi has posted comments on this change. Change subject: v2v: add test for Xen block device .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/63022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: add test for Xen block device
gerrit-hooks has posted comments on this change. Change subject: v2v: add test for Xen block device .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: add test for Xen block device
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: add test for Xen block device
..
v2v: add test for Xen block device
Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Signed-off-by: Shahar Havivi
---
M tests/v2vTests.py
1 file changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/63022/1
diff --git a/tests/v2vTests.py b/tests/v2vTests.py
index 013a56a..7c1d5a9 100644
--- a/tests/v2vTests.py
+++ b/tests/v2vTests.py
@@ -84,6 +84,7 @@
self._id = id
self._active = active
self._has_snapshots = has_snapshots
+self._disk_type = 'file'
def name(self):
return self._name
@@ -106,6 +107,9 @@
def isActive(self):
return self._active
+def setDiskType(self, disk_type):
+self._disk_type = disk_type
+
def XMLDesc(self, flags=0):
return """
@@ -122,7 +126,7 @@
restart
destroy
-
+
@@ -140,6 +144,7 @@
""".format(
name=self._name,
uuid=self._uuid,
+disk_type=self._disk_type,
mac=self._mac_address)
def hasCurrentSnapshot(self):
@@ -151,12 +156,16 @@
def __init__(self, vms):
self._vms = vms
+self._type = 'ESX'
def close(self):
pass
+def setType(self, type_name):
+self._type = type_name
+
def getType(self):
-return "ESX"
+return self._type
def listAllDomains(self):
return [vm for vm in self._vms]
@@ -512,6 +521,23 @@
def testSuccessfulXenImport(self):
self._commonConvertExternalVM(self.xen_url)
+def testXenBlockDevice(self):
+def _connect(uri, username, passwd):
+self._vms[0].setDiskType('block')
+conn = MockVirConnect(vms=self._vms)
+conn.setType('Xen')
+return conn
+
+with MonkeyPatchScope([(libvirtconnection, 'open_connection',
+_connect)]):
+vms = v2v.get_external_vms(self.xen_url, 'user',
+ ProtectedPassword('password'),
+ None)['vmList']
+
+self._vms[0].setDiskType('block')
+print '\n>>> %r\n' % self._vms[0]
+self.assertEqual(len(vms), len(VM_SPECS) - 1)
+
@MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
@MonkeyPatch(v2v, '_LOG_DIR', None)
def testSuccessfulImportOVA(self):
--
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: remove deprecated BuildRoot macro
gerrit-hooks has posted comments on this change. Change subject: spec: remove deprecated BuildRoot macro .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Vdsm supports only x86, ppc and ppc64
Dan Kenigsberg has posted comments on this change.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62465/2/vdsm.spec.in
File vdsm.spec.in:
Line 57: Url:http://www.ovirt.org/develop/developer-guide/vdsm/vdsm/
Line 58: Source0:%{vdsm_name}-%{version}.tar.gz
Line 59: BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Line 60:
Line 61: ExclusiveArch: x86_64 ppc ppc64
> I don't recall why, but before https://gerrit.ovirt.org/40738 we had a diff
answering myself: Fedora requires building on all its supported archs.
http://gerrit.ovirt.org/33368 introduced this. If we want to break this rule,
we should "blame" the other packages missing on non-intel archs in the commit
message.
Line 62:
Line 63: %{!?_licensedir:%global license %%doc}
Line 64:
Line 65: BuildRequires: cyrus-sasl-lib
--
To view, visit https://gerrit.ovirt.org/62465
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f7a7d9aac6033b60fe592749bab2613b62466a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Expose disable IPv6 through ip.address module
gerrit-hooks has posted comments on this change. Change subject: net: Expose disable IPv6 through ip.address module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: ifcfg - dhclient should always be stopped
gerrit-hooks has posted comments on this change. Change subject: net: ifcfg - dhclient should always be stopped .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: dhclient command - iface name should appear at the tail
gerrit-hooks has posted comments on this change. Change subject: net: dhclient command - iface name should appear at the tail .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied08e77816633c8595482909ef0d5ceb62405dd9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding the 'link' package with an iface module
gerrit-hooks has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Edward Haas has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding bond api with sysfs driver under link
gerrit-hooks has posted comments on this change. Change subject: net: Adding bond api with sysfs driver under link .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Link setup module - includes bond setup logic.
gerrit-hooks has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net func tests: Cleanup ifcfg files after each func test.
gerrit-hooks has posted comments on this change. Change subject: net func tests: Cleanup ifcfg files after each func test. .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Relocating wait-for-event under its own module.
gerrit-hooks has posted comments on this change. Change subject: net: Relocating wait-for-event under its own module. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie99c93083fd4db7a2d20518c06e70da5bc333a71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Set dummy ifaces up by default.
gerrit-hooks has posted comments on this change. Change subject: net tests: Set dummy ifaces up by default. .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I217645d2f3a06adec28d3bb30b9cd12f290e2914 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding bond api with sysfs driver under link
Edward Haas has posted comments on this change.
Change subject: net: Adding bond api with sysfs driver under link
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/62828/5/lib/vdsm/network/link/bond.py
File lib/vdsm/network/link/bond.py:
Line 132: f.write('-%s' % slave)
Line 133: self._slaves.remove(slave)
Line 134:
Line 135: def set_options(self, options):
Line 136: self._options.update(options)
> With this we are not going for result state. We must remove (or set to defa
Done
Line 137: for key, value in options:
Line 138: with open(self.BONDING_OPT % (self._master, key), 'w') as
f:
Line 139: f.write(value)
Line 140:
https://gerrit.ovirt.org/#/c/62828/5/tests/network/link_bond_test.py
File tests/network/link_bond_test.py:
Line 68: @contextmanager
Line 69: def bond_device(prefix='bond_', max_length=11):
Line 70: bond_name = random_iface_name(prefix, max_length)
Line 71: bond = Bond(bond_name)
Line 72: bond.create()
> this fails CI randomly in following patches with
In current CI state, the 'root' is faked, and in most cases we do not have real
root permissions.
I will mark them so CI will not run it.
Line 73: try:
Line 74: yield bond
Line 75: finally:
--
To view, visit https://gerrit.ovirt.org/62828
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: cmdutils: enhance systemd_run
Francesco Romani has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 24: (1 comment) https://gerrit.ovirt.org/#/c/56474/24/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py: PS24, Line 80: if accounting: : command.extend([ : '--property=CPUAccounting=1', : '--property=MemoryAccounting=1', : '--property=BlockIOAccounting=1', : ]) > I wasn't really questioning the usage of cgroupfs, rather the code itself. Sorry for the long wait. Good point. Implemented. -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
gerrit-hooks has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 18: * #1364087::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364087::OK, public bug * Check Product::#1364087::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: switch type switch
gerrit-hooks has posted comments on this change. Change subject: net: switch type switch .. Patch Set 6: * #1362399::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1362399::OK, public bug * Check Product::#1362399::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: check-merged: switch fc24 to el7
Yaniv Bronhaim has posted comments on this change. Change subject: check-merged: switch fc24 to el7 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: test ovs: dhclient integration test
gerrit-hooks has posted comments on this change. Change subject: test ovs: dhclient integration test .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d379b0ea680332794becb5900d29f927a85a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vm: avoid mark unresponsive on startup
gerrit-hooks has posted comments on this change. Change subject: vm: avoid mark unresponsive on startup .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieff034814d5cda4414052349a0a403b8dcea7a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Adding the 'link' package with an iface module
Edward Haas has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/62827/4/lib/vdsm/network/link/iface.py File lib/vdsm/network/link/iface.py: Line 32: STATE_UP = 'up' Line 33: STATE_DOWN = 'down' Line 34: Line 35: Line 36: def up(dev, admin_blocking=True, link_blocking=False): > please add a doctext for admin_blocking and link_blocking. Done Line 37: if admin_blocking: Line 38: _up_blocking(dev, link_blocking) Line 39: else: Line 40: ipwrapper.linkSet(dev, [STATE_UP]) PS4, Line 47: is_up > is_admin_up? i don't like the name but it would be less confusing. I think 'is_admin_up' is more confusing in this regard. But I can add it and leave this one as an alias. The default is 'admin' state, I will add a doctext for it. Line 71: Line 72: def _is_iface_up(link_flags, check_link): Line 73: iface_up = link_flags & IFF_UP Line 74: if check_link: Line 75: iface_up = iface_up and (link_flags & IFF_RUNNING) > iface_up &= link_flags & IFF_RUNNING You are confusing bitwise operand with a logical one. -- To view, visit https://gerrit.ovirt.org/62827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb723b8d893575ef14e71cacb6b6e391a6a84831 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: test ovs: dhclient integration test
Petr Horáček has uploaded a new change for review.
Change subject: test ovs: dhclient integration test
..
test ovs: dhclient integration test
Change-Id: If6d379b0ea680332794becb5900d29f927a85a0b
Signed-off-by: Petr Horáček
---
A tests/network/ovs_dhclient_test.py
1 file changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/63006/1
diff --git a/tests/network/ovs_dhclient_test.py
b/tests/network/ovs_dhclient_test.py
new file mode 100644
index 000..95fbc10
--- /dev/null
+++ b/tests/network/ovs_dhclient_test.py
@@ -0,0 +1,72 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+from nose.plugins.attrib import attr
+
+from .nettestlib import veth_pair, dnsmasq_run
+from .ovsnettestlib import OvsService, TEST_BRIDGE
+from testValidation import ValidateRunningAsRoot
+from testlib import VdsmTestCase
+
+from vdsm.network.ip import dhclient
+from vdsm.network.ipwrapper import linkSet, addrAdd
+from vdsm.network.ovs.driver import create
+
+TEST_NETWORK = 'test-network'
+
+IPv4_ADDRESS = '192.0.3.1'
+IPv4_PREFIX_LEN = '24'
+
+DHCPv4_RANGE_FROM = '192.0.3.2'
+DHCPv4_RANGE_TO = '192.0.3.253'
+
+
+@attr(type='integration')
+class TestOvsDhclient(VdsmTestCase):
+
+@ValidateRunningAsRoot
+def setUp(self):
+self.ovs_service = OvsService()
+self.ovs_service.setup()
+self.ovsdb = create()
+
+def tearDown(self):
+self.ovsdb.del_br(TEST_BRIDGE, if_exists=True).execute()
+self.ovs_service.teardown()
+
+def test_run_dhclient_on_ovs_iface(self):
+with veth_pair() as (server, client):
+with self.ovsdb.transaction() as t:
+t.add(self.ovsdb.add_br(TEST_BRIDGE))
+t.add(self.ovsdb.add_port(TEST_BRIDGE, client))
+t.add(self.ovsdb.add_port(TEST_BRIDGE, TEST_NETWORK))
+t.add(self.ovsdb.set_interface_attr(
+TEST_NETWORK, 'type', 'internal'))
+
+addrAdd(server, IPv4_ADDRESS, IPv4_PREFIX_LEN)
+linkSet(server, ['up'])
+with dnsmasq_run(server, DHCPv4_RANGE_FROM, DHCPv4_RANGE_TO):
+linkSet(TEST_NETWORK, ['up'])
+dhclient.run(TEST_NETWORK, blocking_dhcp=True)
+# TODO: assert network is there
+import os
+os.system('ovs-vsctl show')
+os.system('ip a')
+raise Exception()
--
To view, visit https://gerrit.ovirt.org/63006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6d379b0ea680332794becb5900d29f927a85a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: test ovs: dhclient integration test
gerrit-hooks has posted comments on this change. Change subject: test ovs: dhclient integration test .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d379b0ea680332794becb5900d29f927a85a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: early IP+link setup
Petr Horáček has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 17: Verified+1 Able to restore OVS network DHCP config. Such network is not restored again by vdsm-network.service. -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: dup commands.execCmd to allow redirection
gerrit-hooks has posted comments on this change. Change subject: v2v: dup commands.execCmd to allow redirection .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/60660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9df138e2a64cbc2fd3f3c26363d1584d571983f2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: dup commands.execCmd to allow redirection
Francesco Romani has abandoned this change. Change subject: v2v: dup commands.execCmd to allow redirection .. Abandoned -- To view, visit https://gerrit.ovirt.org/60660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9df138e2a64cbc2fd3f3c26363d1584d571983f2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: dup commands.execCmd to allow redirection
Francesco Romani has uploaded a new change for review.
Change subject: v2v: dup commands.execCmd to allow redirection
..
v2v: dup commands.execCmd to allow redirection
***WIP*** - discussion material, not merge material.
Change-Id: I9df138e2a64cbc2fd3f3c26363d1584d571983f2
Signed-off-by: Francesco Romani
---
M lib/vdsm/v2v.py
1 file changed, 45 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/60660/2
diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index c6a9943..5a53a92 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -32,7 +32,7 @@
import logging
import os
import re
-import signal
+import subprocess
import tarfile
import threading
import xml.etree.ElementTree as ET
@@ -40,12 +40,13 @@
import libvirt
-from vdsm.commands import execCmd
+from vdsm.commands import AsyncProc, execCmd
from vdsm.common import zombiereaper
+from vdsm.compat import CPopen
from vdsm.constants import P_VDSM_RUN, EXT_KVM_2_OVIRT
from vdsm.define import errCode, doneCode
-from vdsm import libvirtconnection, response, concurrent
-from vdsm.utils import traceback, CommandPath, NICENESS, IOCLASS
+from vdsm import libvirtconnection, response, concurrent, cmdutils
+from vdsm.utils import terminating, traceback, CommandPath, NICENESS, IOCLASS
try:
import ovirt_imageio_common
@@ -389,12 +390,11 @@
raise NotImplementedError("Subclass must implement this")
def _start_helper(self):
-return execCmd(self._command(),
- sync=False,
- deathSignal=signal.SIGTERM,
- nice=NICENESS.HIGH,
- ioclass=IOCLASS.IDLE,
- env=self._environment())
+return _exec_cmd(self._command(),
+ sync=False,
+ nice=NICENESS.HIGH,
+ ioclass=IOCLASS.IDLE,
+ env=self._environment())
def _get_disk_format(self):
fmt = self._vminfo.get('format', 'raw').lower()
@@ -1139,3 +1139,38 @@
else:
net['type'] = 'interface'
vm['networks'].append(net)
+
+
+# FIXME: hack until we fix the main execCmd
+def _exec_cmd(command, raw=False, env=None, sync=True, nice=None, ioclass=None,
+ stdout=subprocess.PIPE, stderr=subprocess.PIPE):
+"""
+Dumbed version of commands.execCmd, until the proper refactoring is
+completed.
+"""
+command = cmdutils.wrap_command(command, with_ioclass=ioclass,
+ioclassdata=None, with_nice=nice,
+with_setsid=False, with_sudo=False,
+reset_cpu_affinity=True)
+
+logging.debug(cmdutils.command_log_line(command, cwd=None))
+
+p = CPopen(command, close_fds=True, cwd=None, env=env,
+ stdout=stdout, stderr=stderr)
+if not sync:
+return AsyncProc(p)
+
+with terminating(p):
+(out, err) = p.communicate(None)
+
+if out is None:
+# Prevent splitlines() from barfing later on
+out = ""
+
+logging.debug(cmdutils.retcode_log_line(p.returncode, err=err))
+
+if not raw:
+out = out.splitlines(False)
+err = err.splitlines(False)
+
+return p.returncode, out, err
--
To view, visit https://gerrit.ovirt.org/60660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9df138e2a64cbc2fd3f3c26363d1584d571983f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: filter out Xen VMs with block storage
Francesco Romani has posted comments on this change. Change subject: v2v: filter out Xen VMs with block storage .. Patch Set 2: OK, I'll bump to +2 as soon as the new patch is posted! -- To view, visit https://gerrit.ovirt.org/62368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: filter out Xen VMs with block storage
Shahar Havivi has posted comments on this change. Change subject: v2v: filter out Xen VMs with block storage .. Patch Set 2: > thanks, looks nice. Is this covered by tests? > If not, any plan to make it so? Yep, I will send a new patch that will handle the disk type that is missing (file and block) -- To view, visit https://gerrit.ovirt.org/62368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84512f54f9949640a568a444dd7eeb78db852134 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Using %{?_smp_mflags} for make calls
Milan Zamazal has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in
File vdsm.spec.in:
Line 743: %endif
Line 744: --with-qemu-kvm='@QEMU_KVM_PKG@' \
Line 745: --with-qemu-img='@QEMU_IMG_PKG@'
Line 746:
Line 747: make %{?_smp_mflags}
> this works, but change the spec with the above flag and then run make rpm.
When I download this patch tree and run autogen.sh and then `make rpm' in it,
it works fine. Do I miss something? Maybe you could post the error you receive
somewhere?
Line 748: # Setting software_version and software_revision in dsaversion.py
Line 749: baserelease=`echo "%{release}" | sed
's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'`
Line 750: baseversion=`echo "%{version}" | sed
's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'`
Line 751: rawversion=%{version}-%{release}
--
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
gerrit-hooks has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: sourceroute thread crashes due to a test race
Edward Haas has uploaded a new change for review. Change subject: net test: sourceroute thread crashes due to a test race .. net test: sourceroute thread crashes due to a test race testRestoreToBlockingDHCP has caused sourceroute thread to crash. Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Signed-off-by: Edward Haas --- M tests/functional/networkTests.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/62995/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 833e46f..a76e0db 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -1428,6 +1428,10 @@ self.vdsm_net.save_config() +# Terminate the dhclient spawned by the setup to avoid a race +# with the source route thread. +dhclient.kill(client) + with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO, DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, IP_GATEWAY): with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir: -- To view, visit https://gerrit.ovirt.org/62995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Adding build-artifacts-manual.sh script
Sharon Naftaly has posted comments on this change. Change subject: Adding build-artifacts-manual.sh script .. Patch Set 7: > I see https://gerrit.ovirt.org/#/c/62779/1 is not helping :\ > Still, the failure seems very much unrelated to your patch. > Can you reproduce the jenkins failure locally (e.g. on your dev. > PC)? > Can you verify in a different way? The two issues seem independent > (Of course we need to fix both). @fromani, I tried testing it locally inside mock for el7, using the same tarball and mock confs, and the tests passed locally. I'm not sure why there is a difference.. -- To view, visit https://gerrit.ovirt.org/62560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
