Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt net: Disable special OVS handling for exteranal network
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63621/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 85: def _set_bridge_interfaces(devices, target_vm_conf):
Line 86: target_vm_nets_by_vnic_mac = {dev['macAddr']: dev['network']
Line 87:   for dev in target_vm_conf['devices']
Line 88:   if dev.get('type') == 'interface'}
Line 89: exernal_by_mac = {dev['macAddr']: dev.get('custom').
> I understand the need, but it looks so strange mixing this into this whole 
For the first time, we are now modifying incoming domxml. Most hooks depend on 
domxml *not* changing. So we should provide them with a means to signal "it is 
ok to modify domxml" (for backward compat).

Also we need a new hook point placed here, where hook scripts can control how 
each device is modified. I'm only short of a good name for the hook point. I 
think that before_device_libvirt_migration_destination is *way* too bad.
Line 90:   get('provider_type') == EXTERNAL_NETWORK
Line 91:   for dev in target_vm_conf['devices']
Line 92:   if dev.get('type') == 'interface' and 
dev.get('custom')}
Line 93: 


-- 
To view, visit https://gerrit.ovirt.org/63621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0aa5846040a80773a65a14d3e93624e4491c229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: net test: test_ip_info - wait for IP settings with address
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: test_ip_info - wait for IP settings with address
..


Patch Set 2:

This is the 1st attempt: https://gerrit.ovirt.org/#/c/63516

-- 
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: test_ip_info - wait for IP settings with address
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: util: NoIntrPoll - replace time() with monotonic_time()

[edwardh]

Edward Haas has posted comments on this change.

Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15dc7cc82ec196644612a1199d372c70913f41b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: util: NoIntrPoll - replace time() with monotonic_time()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15dc7cc82ec196644612a1199d372c70913f41b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: util: NoIntrPoll - replace time() with monotonic_time()

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..

util: NoIntrPoll - replace time() with monotonic_time()

Change-Id: I15dc7cc82ec196644612a1199d372c70913f41b2
Signed-off-by: Edward Haas 
---
M lib/vdsm/utils.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/63661/1

diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 0ff1a3c..a428c8e 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -267,7 +267,7 @@
 """
 # When the timeout < 0 we shouldn't compute a new timeout after an
 # interruption.
-endtime = None if timeout < 0 else time.time() + timeout
+endtime = None if timeout < 0 else monotonic_time() + timeout
 
 while True:
 try:
@@ -277,7 +277,7 @@
 raise
 
 if endtime is not None:
-timeout = max(0, endtime - time.time())
+timeout = max(0, endtime - monotonic_time())
 
 
 class CommandStream(object):


-- 
To view, visit https://gerrit.ovirt.org/63661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15dc7cc82ec196644612a1199d372c70913f41b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: test_ip_info - wait for IP settings with address
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: test_ip_info - Wait for IP settingi with address

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net test: test_ip_info - Wait for IP settingi with address
..

net test: test_ip_info - Wait for IP settingi with address

This is a second attempt to handle the random failing test on CI run.
This time, we are more specific in the 'waiting' statement, and include
the expected address part.

It is suspected that multiple duplicate netlink events are arriving,
causing a false waiting.

Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/netlink/waitfor.py
M tests/network/netinfo_test.py
2 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/63660/1

diff --git a/lib/vdsm/network/netlink/waitfor.py 
b/lib/vdsm/network/netlink/waitfor.py
index 170e00f..0880244 100644
--- a/lib/vdsm/network/netlink/waitfor.py
+++ b/lib/vdsm/network/netlink/waitfor.py
@@ -42,15 +42,19 @@
 
 
 @contextmanager
-def waitfor_ipv4_addr(iface, timeout=10):
+def waitfor_ipv4_addr(iface, address=None, timeout=10):
 expected_event = {'label': iface, 'family': 'inet', 'scope': 'global'}
+if address:
+expected_event.update(address=address)
 with _wait_for_event(iface, expected_event, timeout):
 yield
 
 
 @contextmanager
-def waitfor_ipv6_addr(iface, timeout=10):
+def waitfor_ipv6_addr(iface, address=None, timeout=10):
 expected_event = {'label': iface, 'family': 'inet6', 'scope': 'global'}
+if address:
+expected_event.update(address=address)
 with _wait_for_event(iface, expected_event, timeout):
 yield
 
diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index 799f9b4..1a6ef22 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -333,41 +333,41 @@
 PREFIX_LENGTH = 24
 IPV6_PREFIX_LENGTH = 64
 IP_ADDR_CIDR = self._cidr_form(IP_ADDR, PREFIX_LENGTH)
-IP_ADDR_SECOND_CIDR = self._cidr_form(IP_ADDR_SECOND, PREFIX_LENGTH)
+IP_ADDR_2ND_CIDR = self._cidr_form(IP_ADDR_SECOND, PREFIX_LENGTH)
 IP_ADDR2_CIDR = self._cidr_form(IP_ADDR2, PREFIX_LENGTH)
 IP_ADDR3_CIDR = self._cidr_form(IP_ADDR3, 32)
 IPV6_ADDR_CIDR = self._cidr_form(IPV6_ADDR, IPV6_PREFIX_LENGTH)
 with dummy_device() as device:
-with waitfor.waitfor_ipv4_addr(device):
+with waitfor.waitfor_ipv4_addr(device, address=IP_ADDR_CIDR):
 ipwrapper.addrAdd(device, IP_ADDR, PREFIX_LENGTH)
-with waitfor.waitfor_ipv4_addr(device):
+with waitfor.waitfor_ipv4_addr(device, address=IP_ADDR_2ND_CIDR):
 ipwrapper.addrAdd(device, IP_ADDR_SECOND, PREFIX_LENGTH)
-with waitfor.waitfor_ipv4_addr(device):
+with waitfor.waitfor_ipv4_addr(device, address=IP_ADDR2_CIDR):
 ipwrapper.addrAdd(device, IP_ADDR2, PREFIX_LENGTH)
-with waitfor.waitfor_ipv6_addr(device):
+with waitfor.waitfor_ipv6_addr(device, address=IPV6_ADDR_CIDR):
 ipwrapper.addrAdd(
 device, IPV6_ADDR, IPV6_PREFIX_LENGTH, family=6)
 # 32 bit addresses are reported slashless by netlink
-with waitfor.waitfor_ipv4_addr(device):
+with waitfor.waitfor_ipv4_addr(device, address=IP_ADDR3):
 ipwrapper.addrAdd(device, IP_ADDR3, 32)
 
 self.assertEqual(
 get_ip_info(device),
 (IP_ADDR, NET_MASK,
  [IP_ADDR_CIDR, IP_ADDR2_CIDR, IP_ADDR3_CIDR,
-  IP_ADDR_SECOND_CIDR],
+  IP_ADDR_2ND_CIDR],
  [IPV6_ADDR_CIDR]))
 self.assertEqual(
 get_ip_info(device, ipv4_gateway=IP_ADDR_GW),
 (IP_ADDR, NET_MASK,
  [IP_ADDR_CIDR, IP_ADDR2_CIDR, IP_ADDR3_CIDR,
-  IP_ADDR_SECOND_CIDR],
+  IP_ADDR_2ND_CIDR],
  [IPV6_ADDR_CIDR]))
 self.assertEqual(
 get_ip_info(device, ipv4_gateway=IP_ADDR2_GW),
 (IP_ADDR2, NET_MASK,
  [IP_ADDR_CIDR, IP_ADDR2_CIDR, IP_ADDR3_CIDR,
-  IP_ADDR_SECOND_CIDR],
+  IP_ADDR_2ND_CIDR],
  [IPV6_ADDR_CIDR]))
 
 def test_netinfo_ignoring_link_scope_ip(self):


-- 
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: test_ip_info - Wait for IP settingi with address

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: test_ip_info - Wait for IP settingi with address
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c2832c1ec7614e1df9c291a9f3ab2e4a1134242
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 3:

(2 comments)

Thanks for the review!
Regarding the general comment, the change at constants.py.in is needed to 
prevent the upgrade to fail with the reason that the Host does not support this 
version.
The change at sd.py is also being used once we upgrade the DC

https://gerrit.ovirt.org/#/c/63547/3/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 337
Line 338
Line 339
Line 340
Line 341
> We need 2 blank lines between function in a module to make pep8 tool happy.
Done


Line 342: def v4DomainConverter(repoPath, hostId, domain, isMsd):
Line 343: targetVersion = 4
Line 344: domain.setMetaParam(sd.DMDK_VERSION, targetVersion)
Line 345: log.debug("Conversion of domain %s to version = %s has been 
completed."
Line 346:   ,domain.sdUUID, targetVersion)
> Please put the "," at the end of the message.
Done
Line 347: 
Line 348: 
Line 349: _IMAGE_REPOSITORY_CONVERSION_TABLE = {
Line 350: ('0', '2'): v2DomainConverter,


-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 3:

(2 comments)

What we see in the patch look mostly ok, not sure if we need more changes in 
other files.

https://gerrit.ovirt.org/#/c/63547/3/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 337
Line 338
Line 339
Line 340
Line 341
We need 2 blank lines between function in a module to make pep8 tool happy.


Line 342: def v4DomainConverter(repoPath, hostId, domain, isMsd):
Line 343: targetVersion = 4
Line 344: domain.setMetaParam(sd.DMDK_VERSION, targetVersion)
Line 345: log.debug("Conversion of domain %s to version = %s has been 
completed."
Line 346:   ,domain.sdUUID, targetVersion)
Please put the "," at the end of the message.
Line 347: 
Line 348: 
Line 349: _IMAGE_REPOSITORY_CONVERSION_TABLE = {
Line 350: ('0', '2'): v2DomainConverter,


-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Don't un-escape mount options

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: mount: Don't un-escape mount options
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: introducting broken_on_ci decorator

[edwardh]

Edward Haas has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Run mount tests multiple times

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Run mount tests multiple times
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idaed2e8e1c5b2bd04c412233d94e94005c23189c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: build net tests: Create a test target for networking tests.
..

build net tests: Create a test target for networking tests.

It is usefull to run only the networking test during development,
speeding the test run and allowing the developer to run them frequently
in a few seconds.

Before pushing changes, all tests should be run, including functional
ones.

Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Signed-off-by: Edward Haas 
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/63649/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 2ff09a4..35c7b25 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -374,6 +374,10 @@
 check-recursive:
@true
 
+check-net:
+   @echo '*** Running networking tests. ***'
+   @$(top_srcdir)/tests/run_tests_local.sh $(args) $(network_modules)
+
 # crossImportsTests.py has to be run separate due to different tests which
 # load modules first, making the env dirty. Unloading python modules
 # is not supported, see http://bugs.python.org/issue9072 .


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Wait for systemd temporary mount unit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Wait for systemd temporary mount unit
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0318eb534f781f127882983527e1a221820478
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 1: Code-Review+1

Looks ok, but need testing with 3.6.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: add more info to NFS SD getInfo

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add more info to NFS SD getInfo
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63636/2/vdsm/storage/nfsSD.py
File vdsm/storage/nfsSD.py:

Line 128: # First call parent getInfo() - it fills in all the common 
details
Line 129: info = fileSD.FileStorageDomain.getInfo(self)
Line 130: # Now add nfsSD specific data
Line 131: try:
Line 132: mntrcd = 
mount.getMountFromTarget(self.mountpoint).getRecord()
> getMountFromTarget iterate over all records, getRecord will iterate again o
If you do any change in mount module, please rebase on 
https://gerrit.ovirt.org/56551
Line 133: info['vfsType'] = mntrcd.fs_vfstype
Line 134: info['mountOptions'] = mntrcd.fs_mntops
Line 135: except mount.MountError:
Line 136: return info


-- 
To view, visit https://gerrit.ovirt.org/63636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove EL 6 /etc/mtab support
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Fix un-escaping of spaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Fix un-escaping of spaces
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaddcb8c023f80d4284b28ad070fd833374c3e857
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Simplify deleted suffix stripping

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Simplify deleted suffix stripping
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add tests for un-escaping spaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add tests for un-escaping spaces
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I772b7e7e48f888f9b9790cd6963d65cd86912699
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mounts: Use more meaningful names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mounts: Use more meaningful names
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac1ba474856c9cf9f66d05dcce7ed152cbe2147b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add mount.isMounted() timing tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add mount.isMounted() timing tests
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84396450abaa17fee402d024e0ae99c36b68ce4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Don't un-escape mount options

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Don't un-escape mount options
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f666a565b9db9e4a713516f96a61aab535c596
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add missing test for deleted mounts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add missing test for deleted mounts
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id280a9e8e3d6db273eb3398dd38e4553750c4631
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Unify stoage logger name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Unify stoage logger name
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve logging when receiving signals

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: logging: Improve logging when receiving signals
..


logging: Improve logging when receiving signals

Log INFO message when receiving signals, explaining the action taken.

Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/61289
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/vdsm
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Remove unused variable and evil thread

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: sd: Remove unused variable and evil thread
..


sd: Remove unused variable and evil thread

If storage domain had a non-null start instance variable, we used to
start a thread stopping this stat object in __del__(!). Fortunately,
stat is always None, so we don't need to stop it.

Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63520
Reviewed-by: Ala Hino 
Reviewed-by: Freddy Rolland 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M tests/sdm_indirection_tests.py
M vdsm/storage/sd.py
2 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve logging when receiving signals

[automation]

gerrit-hooks has posted comments on this change.

Change subject: logging: Improve logging when receiving signals
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Proving that error_code job is useless

[nsoffer]

Nir Soffer has abandoned this change.

Change subject: build: Proving that error_code job is useless
..


Abandoned

Not needed now

-- 
To view, visit https://gerrit.ovirt.org/61056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaf4148cdf286ac694d0aa5fa96e6b302a0fefad9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Proving that error_code job is useless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Proving that error_code job is useless
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/61056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf4148cdf286ac694d0aa5fa96e6b302a0fefad9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve logging when receiving signals

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: logging: Improve logging when receiving signals
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Remove unused variable and evil thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Remove unused variable and evil thread
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Draft for showing client address in rpc logs

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Draft for showing client address in rpc logs
..


Patch Set 1:

ping

-- 
To view, visit https://gerrit.ovirt.org/61437
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf59361d9224e5133b990e295616363422b2f5c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Remove unused variable and evil thread

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: sd: Remove unused variable and evil thread
..


Patch Set 3: Code-Review+2

should have been gone with 75ddec022648ec1a01bc8185e3f7541f9e6dbf4f

-- 
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve logging when receiving signals

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: Improve logging when receiving signals
..


Patch Set 1:

Whos is approving this?

-- 
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: build tests: Disable the builtin check target.
..

build tests: Disable the builtin check target.

There is no need to recursively check the tests/ folder for check-local
targets as there are none.

Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Signed-off-by: Edward Haas 
---
M tests/Makefile.am
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/63646/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index ae671c9..2ff09a4 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -370,10 +370,14 @@
 run_modules += $(device_modules)
 run_modules += $(common_modules)
 
+# Disable builtin (recursive) check target.
+check-recursive:
+   @true
+
 # crossImportsTests.py has to be run separate due to different tests which
 # load modules first, making the env dirty. Unloading python modules
 # is not supported, see http://bugs.python.org/issue9072 .
-check-local:
+check:
@echo '*** Running tests.  To skip this step place NOSE_EXCLUDE=.* ***'
@echo '*** into your environment.  Do not submit untested code!***'
$(top_srcdir)/tests/run_tests_local.sh $(args) crossImportsTests.py


-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Rename event threads to event/N

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: misc: Rename event threads to event/N
..


Patch Set 4: Continuous-Integration+1

CI failures not relevant.

-- 
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:

Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
Line 258: if config.getboolean('devel', 'python_warnings_enable'):
> This is very ugly we should kill this option instead.
i guess we shouldn't want this config value if we don't use the broken python 
warning module anymore


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: vdscli: switch to the new devel_warn helper

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: lib: vdscli: switch to the new devel_warn helper
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/62211/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 139: 
Line 140: 
Line 141: devel_warn
Line 142: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 143: "vdsm.jsonrpcvdscli")
> We don't need this warning, adding a comment that the module is deprecated 
Dan requested for that, and I agree that it helps to notice when vdscli is 
being used.
Line 144: 
Line 145: 
Line 146: if __name__ == '__main__':
Line 147: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1189097826e79290cb996657ccf34a7c2b611ee0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 2: Code-Review+1

We need to clean also testrunner.

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: vdscli: switch to the new devel_warn helper

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: vdscli: switch to the new devel_warn helper
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62211/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 139: 
Line 140: 
Line 141: devel_warn
Line 142: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please 
use "
Line 143: "vdsm.jsonrpcvdscli")
We don't need this warning, adding a comment that the module is deprecated is 
good enough.
Line 144: 
Line 145: 
Line 146: if __name__ == '__main__':
Line 147: print('connecting to %s:%s ssl %s ts %s' % (


-- 
To view, visit https://gerrit.ovirt.org/62211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1189097826e79290cb996657ccf34a7c2b611ee0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: add more info to NFS SD getInfo

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add more info to NFS SD getInfo
..


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/63636/2//COMMIT_MSG
Commit Message:

Line 19: 'wsize=1048576', 'namlen=255', 'soft', 
'nosharecache',
Line 20: 'proto=tcp', 'timeo=600', 'retrans=6', 'sec=sys',
Line 21: 'mountaddr=10.35.0.181', 'mountvers=3',
Line 22: 'mountport=20048', 'mountproto=udp',
Line 23: 'local_lock=none', 'addr=10.35.0.181']
This include options that vdsm (see stoageServer.py) adds and were not sent by 
engine. This may cause trouble if engine use this options to create a new 
storage domain.

Since vdsm adds these options, I think it should also remove them when 
reporting mount options to engine. Otherwise, we will have to keep the list of 
default options in both vdsm and engine to create storage domain from existing 
mount.

I think our goal is to restore a storage domain in engine from the existing 
mount in vdsm.
Line 24: type = NFS
Line 25: class = Data
Line 26: pool = ['0001-0001-0001-0001-0325']
Line 27: name = NFSSD


https://gerrit.ovirt.org/#/c/63636/2/vdsm/storage/nfsSD.py
File vdsm/storage/nfsSD.py:

Line 128: # First call parent getInfo() - it fills in all the common 
details
Line 129: info = fileSD.FileStorageDomain.getInfo(self)
Line 130: # Now add nfsSD specific data
Line 131: try:
Line 132: mntrcd = 
mount.getMountFromTarget(self.mountpoint).getRecord()
getMountFromTarget iterate over all records, getRecord will iterate again over 
all records so this code is not efficient.

Even worse, you may get a Mont object that its getRecord will raise! since 
getRecord require that both fs_spec and fs_file match, but getMountFromTarget 
does not.

We need to improve the mount infrastructure before we can depend on it for a 
new feature.

"mntrcd" is too cryptic, "record" would be better, matching the api.
Line 133: info['vfsType'] = mntrcd.fs_vfstype
Line 134: info['mountOptions'] = mntrcd.fs_mntops
Line 135: except mount.MountError:
Line 136: return info


Line 130: # Now add nfsSD specific data
Line 131: try:
Line 132: mntrcd = 
mount.getMountFromTarget(self.mountpoint).getRecord()
Line 133: info['vfsType'] = mntrcd.fs_vfstype
Line 134: info['mountOptions'] = mntrcd.fs_mntops
These must be documented in the schema.
Line 135: except mount.MountError:
Line 136: return info
Line 137: 
Line 138: return info


Line 132: mntrcd = 
mount.getMountFromTarget(self.mountpoint).getRecord()
Line 133: info['vfsType'] = mntrcd.fs_vfstype
Line 134: info['mountOptions'] = mntrcd.fs_mntops
Line 135: except mount.MountError:
Line 136: return info
Please log the error here instead of returning the info, the info is returned 
anyway below.
Line 137: 
Line 138: return info
Line 139: 
Line 140: 


-- 
To view, visit https://gerrit.ovirt.org/63636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Rename event threads to event/N

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: misc: Rename event threads to event/N
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Rename event threads to event/N

[automation]

gerrit-hooks has posted comments on this change.

Change subject: misc: Rename event threads to event/N
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check: Rename check event loop thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: check: Rename check event loop thread
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I927659479d3be888d2e38bd30c6c13e924b2745f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: Rename storage domain upgrade threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: Rename storage domain upgrade threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5410d468448cee91a245937a5012fd50d473423
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hsm: Rename init thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: Rename init thread
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc0eea14385ca5405784a51dd93b86cea62f6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Rename cleanup threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Rename cleanup threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5139ff3331daba9155037dba4bab64298a64943f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Remove unused variable and evil thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Remove unused variable and evil thread
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: fc-scan: Rename host scanning threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fc-scan: Rename host scanning threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4394b352d29f3fd297cbf795f0a5f691bbc9e542
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mailbox: Rename storage mailbox threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mailbox: Rename storage mailbox threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife5246ea36a0646f62416f1fdcbaf617fe85bf70
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: task: Rename cleanup threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: task: Rename cleanup threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63526
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9585432fb0e290befdc37282dd1db3db7d2ba68f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

[edwardh]

Edward Haas has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..

build tests: Require NOSE 1.3.7 and up for running tests

On RHEL7/Centos7 the provided NOSE version is 1.3.0.
CI runs the tests with 1.3.7.

To be consistent and avoid different behaviours, assure that the tests
are running with a minimum nose version of 1.3.7.

Specifically, between 1.3.0 and 1.3.7 a bug has been resolved regarding
test labeling and its support with test class inheritance.

Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Signed-off-by: Edward Haas 
---
M Makefile.am
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/63638/1

diff --git a/Makefile.am b/Makefile.am
index 40ddeb8..64cd9a0 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -138,7 +138,12 @@
 
 .PHONY: tests
 tests:
-   $(MAKE) -C tests/ check
+   @version=`nosetests --version | cut -d' ' -f3`; \
+   if build-aux/vercmp $$version "1.3.7"; then \
+ echo "Error: NOSE is too old, please install NOSE 1.3.7 or later"; \
+ exit 1; \
+   fi
+   @$(MAKE) -C tests/ check
 
 all-local: \
vdsm.spec


-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Unify stoage logger name

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Unify stoage logger name
..


Patch Set 1:

ping

-- 
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I653c41301393b5450de4ac6dee92b606a5f64838
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: formatConverter: Use module logger

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: formatConverter: Use module logger
..


Patch Set 1: Code-Review+1

Looks fine, but please rebase on https://gerrit.ovirt.org/61261, that patch 
must be merged before this patch.

-- 
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b55237a22f13151e391116ba8ee7a7183e31ca2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: use the new response handling

[nsoffer]

Nir Soffer has restored this change.

Change subject: vm: use the new response handling
..


Restored

Still needed

-- 
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: debug: Add virt-alignment-scan.debug tool

[nsoffer]

Nir Soffer has restored this change.

Change subject: debug: Add virt-alignment-scan.debug tool
..


Restored

Still needed

-- 
To view, visit https://gerrit.ovirt.org/40896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 3: Verified+1

Verified upgrade storage pool with NFS and iSCSI.
Version format in the metadata changed to 4

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: api: use the new devel_warn helper

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: api: use the new devel_warn helper
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/62210/2/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 44
Line 45
Line 46
Line 47
Line 48
We use developer warnings only in this module, so better localize the solution 
here.

We can create the devel logger:

_devel = logging.getLogger("devel")


Line 172: def _report_inconsistency(self, message):
Line 173: if self._strict_mode:
Line 174: raise JsonRpcInvalidParamsError(message)
Line 175: else:
Line 176: devel_warn(message)
We can use the _devel logger here:

_devel.warning(message)
Line 177: 
Line 178: def verify_args(self, rep, args):
Line 179: try:
Line 180: # check whether there are extra parameters


-- 
To view, visit https://gerrit.ovirt.org/62210
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc85dde59e09a5882e9d586fb0d37d2434f0a351
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: add more info to NFS SD getInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add more info to NFS SD getInfo
..


Patch Set 2:

* #1373930::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373930::OK, public bug
* Check Product::#1373930::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: fileUtils: drop redundant warning

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 2: Code-Review+1

We need to remove also the redundant warning in outOfProcess:

warn("Renaming a non-empty directory is not an atomic operation",
 DeprecationWarning)

-- 
To view, visit https://gerrit.ovirt.org/62208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: add more info to NFS SD getInfo

[rgolan]

Roy Golan has posted comments on this change.

Change subject: storage: add more info to NFS SD getInfo
..


Patch Set 1:

(1 comment)

- can this reveal secure info of some sort?
- Thinking on the client side, the engine should consume that and possibly 
store that as the mount option on that domain and obviously not all the info is 
relevant. Maor, Liron how do you see this?

https://gerrit.ovirt.org/#/c/63636/1/vdsm/storage/nfsSD.py
File vdsm/storage/nfsSD.py:

Line 131: try:
Line 132: mntrcd = 
mount.getMountFromTarget(self.mountpoint).getRecord()
Line 133: info['vfsType'] = mntrcd.fs_vfstype
Line 134: info['mountOptions']  = mntrcd.fs_mntops
Line 135: except mount.MountError:
log the err?
Line 136: return info
Line 137: 
Line 138: return info
Line 139: 


-- 
To view, visit https://gerrit.ovirt.org/63636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: fileUtils: drop redundant warning

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: fileUtils: drop redundant warning
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/62208/2/lib/vdsm/storage/fileUtils.py
File lib/vdsm/storage/fileUtils.py:

Line 205
Line 206
Line 207
Line 208
Line 209
This would log a warning for the caller of this function (stacklevel=2), not 
the same as the debug message above. But I agree that it is not very useful.


-- 
To view, visit https://gerrit.ovirt.org/62208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ae070aa613b63897b140837cb68c1a6134947a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: logUtils: add devel_warn function

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: logUtils: add devel_warn function
..


Patch Set 2: Code-Review-1

(2 comments)

I think we should use the standard logging configuration.

- Add devel logger in logger.conf, set level to ERROR. Developers can change 
the log level of this logger using logger.conf or setLogLevel api. 

- Use this logger when we want to log developer warnings

logging.getLogger('devel').warning(...)

- Not sure we need the devel_warn helper, if you add it, it should provide the 
same signature as Logger.warning.

https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:

Line 253: 
Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
This is not useful logger interface,  we want to use the same format provided 
by standard logger (log.XXX(fmt, *args)).
Line 258: if config.getboolean('devel', 'python_warnings_enable'):


Line 254: _devlog = logging.getLogger('devel')
Line 255: 
Line 256: 
Line 257: def devel_warn(message):
Line 258: if config.getboolean('devel', 'python_warnings_enable'):
This is very ugly we should kill this option instead.


-- 
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: add more info to NFS SD getInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add more info to NFS SD getInfo
..


Patch Set 1:

* #1373930::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373930::OK, public bug
* Check Product::#1373930::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: add more info to NFS SD getInfo

[frolland]

Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/63636

to review the following change.

Change subject: storage: add more info to NFS SD getInfo
..

storage: add more info to NFS SD getInfo

Adding vfs type and mount options to getInfo for NFS storage domains.

vdsClient -s 0 getStorageDomainInfo aca80499-88a3-42e8-ab38-4552a554d715

vfsType = nfs
uuid = aca80499-88a3-42e8-ab38-4552a554d715
version = 3
role = Master
remotePath = 10.35.0.181:/home/storage_domains/sd1
mountOptions = ['rw', 'relatime', 'vers=3', 'rsize=1048576',
'wsize=1048576', 'namlen=255', 'soft', 'nosharecache',
'proto=tcp', 'timeo=600', 'retrans=6', 'sec=sys',
'mountaddr=10.35.0.181', 'mountvers=3',
'mountport=20048', 'mountproto=udp',
'local_lock=none', 'addr=10.35.0.181']
type = NFS
class = Data
pool = ['0001-0001-0001-0001-0325']
name = NFSSD

Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Bug-Url: https://bugzilla.redhat.com/1373930
Signed-off-by: Fred Rolland 
---
M vdsm/storage/nfsSD.py
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/63636/1

diff --git a/vdsm/storage/nfsSD.py b/vdsm/storage/nfsSD.py
index 07d0a41..1861319 100644
--- a/vdsm/storage/nfsSD.py
+++ b/vdsm/storage/nfsSD.py
@@ -121,6 +121,22 @@
 except mount.MountError:
 return ""
 
+def getInfo(self):
+"""
+Get storage domain info
+"""
+# First call parent getInfo() - it fills in all the common details
+info = fileSD.FileStorageDomain.getInfo(self)
+# Now add nfsSD specific data
+try:
+mntrcd = mount.getMountFromTarget(self.mountpoint).getRecord()
+info['vfsType'] = mntrcd.fs_vfstype
+info['mountOptions']  = mntrcd.fs_mntops
+except mount.MountError:
+return info
+
+return info
+
 
 def findDomain(sdUUID):
 return NfsStorageDomain(NfsStorageDomain.findDomainPath(sdUUID))


-- 
To view, visit https://gerrit.ovirt.org/63636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Rename event threads to event/N

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: misc: Rename event threads to event/N
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/63521/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: misc: Rename event threads to event/N
Line 8: 
Line 9: Each time we submit an event using storage.misc.Event, we start one or
Line 10: tow threads. Until now, the thread were using the default Thread-N
> ->two
Fixed
Line 11: names.
Line 12: 
Line 13: This patch renames these threads to event/N, matching other thread
Line 14: names, and making it easier to detect these threads in system commands


-- 
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 2: Verified-1

Will upload another verified patch soon

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Hello Nir Soffer, Ala Hino,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/63634

to review the following change.

Change subject: Live Merge: Refresh base volume before live merge
..

Live Merge: Refresh base volume before live merge

When live merging raw base volume, engine extends the base volume
if it is smaller than the top volume. However, on the host running
the vm, the lv is already active and does not reflect the new size
until we refresh it.  During the merge we don't know whether base
volume extended, so we always refresh it.

Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Bug-Url: https://bugzilla.redhat.com/1367281
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/63454
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/virt/vm.py
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/63634/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f50aa16..d719f1e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4947,6 +4947,25 @@
 if not self._can_merge_into(drive, baseInfo, topInfo):
 return errCode['destVolumeTooSmall']
 
+# If the base volume format is RAW and its size is smaller than its
+# capacity (this could happen because the engine extended the base
+# volume), we have to refresh the volume to cause lvm to get current lv
+# size from storage, and update the kernel so the lv reflects the real
+# size on storage. Not refreshing the volume may fail live merge.
+# This could happen if disk extended after taking a snapshot but before
+# performing the live merge.  See https://bugzilla.redhat.com/1367281
+if (drive.chunked and
+baseInfo['format'] == 'RAW' and
+int(baseInfo['apparentsize']) < int(baseInfo['capacity'])):
+self.log.info("Refreshing raw volume %r (apparentsize=%s, "
+  "capacity=%s)",
+  baseVolUUID, baseInfo['apparentsize'],
+  baseInfo['capacity'])
+self.__refreshDriveVolume({
+'domainID': drive.domainID, 'poolID': drive.poolID,
+'imageID': drive.imageID, 'volumeID': baseVolUUID,
+})
+
 # Take the jobs lock here to protect the new job we are tracking from
 # being cleaned up by queryBlockJobs() since it won't exist right away
 with self._jobsLock:


-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 1: Verified-1

* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK, public bug
* Check Product::#1367281::OK, Correct classification oVirt
* Check TM::#1367281::ERROR, wrong target milestone for stable branch, 
ovirt-4.0.5 should match ^.*3.6.*
* Check merged to previous::WARN, Still open on branches ovirt-4.0

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Allow tox to run all checkers in one shot.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: build: Allow tox to run all checkers in one shot.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6e2d6318841892f3cf5bfa27a621922ed025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Allow tox to run all checkers in one shot.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Allow tox to run all checkers in one shot.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6e2d6318841892f3cf5bfa27a621922ed025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build: Allow tox to run all checkers in one shot.

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: build: Allow tox to run all checkers in one shot.
..

build: Allow tox to run all checkers in one shot.

tox has been called for each checker (pep8, pyflakes), with this patch
it is called once and runs all checkers.

Change-Id: I3efc6e2d6318841892f3cf5bfa27a621922ed025
Signed-off-by: Edward Haas 
---
M Makefile.am
M tox.sh
2 files changed, 24 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/63633/1

diff --git a/Makefile.am b/Makefile.am
index aefd2b3..40ddeb8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -84,6 +84,12 @@
echo "Missing absolute_import in $$f"; exit 1; fi; \
done;
 
+PYTHON_CHECKERS = pyflakes pep8
+
+.PHONY: py_checkers
+py_checkers:
+   tox -- $(PYTHON_CHECKERS)
+
 .PHONY: pyflakes
 pyflakes: tox
tox -- pyflakes
@@ -117,7 +123,7 @@
fi
 
 # Note: dependencies ordered by time needed to run them
-check: gitignore abs_imports python3 pyflakes pep8 tests
+check: gitignore abs_imports python3 py_checkers tests
 
 check-recursive:
@true
diff --git a/tox.sh b/tox.sh
index 59bc92a..f85c013 100755
--- a/tox.sh
+++ b/tox.sh
@@ -24,20 +24,20 @@
 vdsm.py \
)
 
-if [ 'pyflakes' = "$1" ]; then
-(find . -path './.tox' -prune -type f -o \
--path './.git' -prune -type f -o \
--path './.ropeproject' -prune -type f -o \
--name '*.py' && echo "${WHITELIST[@]}") | \
-xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \
-while read LINE; do echo "$LINE"; false; done
-fi
-
-if [ 'pep8' = "$1" ]; then
-for x in ${PEP8_BLACKLIST[@]}; do \
-exclude="${exclude},${x}" ; \
-done ; \
-pep8 --exclude="${exclude},.tox,.ropeproject" \
---filename '*.py' . \
-"${WHITELIST[@]}"
-fi
+for checker in "$@"; do
+if [ 'pyflakes' = "$checker" ]; then
+(find . -path './.tox' -prune -type f -o \
+-path './.git' -prune -type f -o \
+-path './.ropeproject' -prune -type f -o \
+-name '*.py' && echo "${WHITELIST[@]}") | \
+xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \
+while read LINE; do echo "$LINE"; false; done
+elif [ 'pep8' = "$checker" ]; then
+for x in ${PEP8_BLACKLIST[@]}; do \
+exclude="${exclude},${x}" ; \
+done ; \
+pep8 --exclude="${exclude},.tox,.ropeproject" \
+--filename '*.py' . \
+"${WHITELIST[@]}"
+fi
+done


-- 
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3efc6e2d6318841892f3cf5bfa27a621922ed025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[automation]

gerrit-hooks has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15:

* #1365007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365007::OK, public bug
* Check Product::#1365007::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/62324/14/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 121: 
Line 122: 
Line 123: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 124: res = _call_server(
Line 125: server.getVolumeInfo, vol_uuid, sp_uuid, sd_uuid, img_uuid)
> why do you change this line? please mention it in the commit msg .
Done
Line 126: return res['info']
Line 127: 
Line 128: 
Line 129: def _get_volumes_chains(server, sd_uuid):


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/62628/5/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 57
Line 58
Line 59
Line 60
Line 61
how is this removal related to the use of dump-volume-chains?


Line 126: self.collectExtOutput("/usr/bin/iostat")
Line 127: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 128: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 129: 
Line 130: with closing(jsonrpcvdscli.connect()) as cli:
this change can be done in different patch
Line 131: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 132: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
Line 133: self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")
Line 134: self.addObjectAsFile(cli.list(), "list")


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 22: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 22:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/62324/14/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 121: 
Line 122: 
Line 123: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 124: res = _call_server(
Line 125: server.getVolumeInfo, vol_uuid, sp_uuid, sd_uuid, img_uuid)
why do you change this line? please mention it in the commit msg .
Line 126: return res['info']
Line 127: 
Line 128: 
Line 129: def _get_volumes_chains(server, sd_uuid):


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org