Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host
Dan Kenigsberg has posted comments on this change. Change subject: net: Ignore missing graphics from VM conf on target host .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest-lvs when deactivating lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Deactivate guest-lvs when deactivating lvs .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
gerrit-hooks has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 4: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 7: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Deactivate guest lvs during bootstrap .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 8: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add loop module
gerrit-hooks has posted comments on this change. Change subject: tests: Add loop module .. Patch Set 4: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Skip foreign vgs during bootstrap .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest-lvs when deactivating lvs
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Deactivate guest-lvs when deactivating lvs .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Deactivate guest lvs during bootstrap .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Skip foreign vgs during bootstrap .. Patch Set 1: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Skip foreign vgs during bootstrap .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 6: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest-lvs when deactivating lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Deactivate guest-lvs when deactivating lvs .. Patch Set 1: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 7: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Deactivate guest lvs during bootstrap .. Patch Set 1: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap
Nir Soffer has uploaded a new change for review.
Change subject: guest-lvs: Deactivate guest lvs during bootstrap
..
guest-lvs: Deactivate guest lvs during bootstrap
Add a new pass during deactivation, detecting open lvs used by other
lvs, and deactivate the guest lvs using them. After deactivating the
guest lvs the host lvs are invalidated.
If the lvs are still open in the next pass, they are likely used by a
vm. We don't have enough information at this point so we skip them. If
the lvs are closed, they will be deactivated.
Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784
Bug-Url: https://bugzilla.redhat.com/1374545
Signed-off-by: Nir Soffer
---
M lib/vdsm/storage/devicemapper.py
M vdsm/storage/lvm.py
2 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/64368/1
diff --git a/lib/vdsm/storage/devicemapper.py b/lib/vdsm/storage/devicemapper.py
index 90ba81a..c5d061c 100644
--- a/lib/vdsm/storage/devicemapper.py
+++ b/lib/vdsm/storage/devicemapper.py
@@ -117,7 +117,10 @@
def removeMapping(deviceName):
-return getProxy().removeDeviceMapping(deviceName)
+if os.geteuid() == 0:
+return _removeMapping(deviceName)
+else:
+return getProxy().removeDeviceMapping(deviceName)
def _removeMapping(deviceName):
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 68d3d98..c501105 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -654,12 +654,17 @@
refresh = []
for lv in _lvminfo.getLv(vg.name):
+if lv.opened and lv.name not in refreshlvs:
+_remove_lv_holders(vg.name, lv.name)
+
+for lv in _lvminfo.getLv(vg.name):
if lv.active:
if lv.name in refreshlvs:
refresh.append(lv.name)
elif lv.opened:
-log.debug("Skipping open lv: vg=%s lv=%s", vg.name,
- lv.name)
+# This LV may be used by a vm, we don't have enough
+# information about that at this point.
+log.debug("Skipping open lv %s/%s", vg.name, lv.name)
else:
deactivate.append(lv.name)
@@ -680,6 +685,27 @@
except se.LogicalVolumeRefreshError:
log.error("Error refreshing lvs: vg=%s lvs=%s", vg.name,
refresh)
+
+
+def _remove_lv_holders(vg_name, lv_name):
+"""
+This may be needed when a raw volume is used as a pv in the guest without
+creating partition table. LVM scans active lvs and activate guest lvs on
+the host. Active guest lvs allow unwanted access to guest data on the
+host, and prevent deactivation of the host lvs.
+
+See https://bugzilla.redhat.com/1374545
+"""
+dm_name = getLvDmName(vg_name, lv_name)
+holders = devicemapper.getHolders(dm_name)
+if holders:
+devices = [devicemapper.getDevName(dev) for dev in holders]
+log.info("LV %s/%s is used by %s, removing mappings",
+ vg_name, lv_name, devices)
+for dev in devices:
+devicemapper.removeMapping(dev)
+# This invalidates lv.attr, force reload on next access.
+_lvminfo._invalidatelvs(vg_name, [lv_name])
def invalidateCache():
@@ -742,7 +768,7 @@
def getLvDmName(vgName, lvName):
-return "%s-%s" % (vgName.replace("-", "--"), lvName)
+return "%s-%s" % (vgName.replace("-", "--"), lvName.replace("-", "--"))
def removeVgMapping(vgName):
--
To view, visit https://gerrit.ovirt.org/64368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap
Nir Soffer has uploaded a new change for review.
Change subject: guest-lvs: Skip foreign vgs during bootstrap
..
guest-lvs: Skip foreign vgs during bootstrap
Previously we tried to deactivate any lv in any vg backed by multipath
device. This may clash with non-ovirt vgs created on a multipath device.
We use now the STORAGE_DOMAIN_TAG to detect oVirt vgs and ignore other
vgs during bootstrap.
Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706
Bug-Url: https://bugzilla.redhat.com/1374545
Signed-off-by: Nir Soffer
---
M tests/storage_lvm_test.py
M vdsm/storage/hsm.py
M vdsm/storage/lvm.py
3 files changed, 25 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/64370/1
diff --git a/tests/storage_lvm_test.py b/tests/storage_lvm_test.py
index d4a1952..98f5b7e 100644
--- a/tests/storage_lvm_test.py
+++ b/tests/storage_lvm_test.py
@@ -67,13 +67,28 @@
run("lvcreate", "-n", "ovirt-lv-1", "-L", "128m", "ovirt-vg")
run("lvcreate", "-n", "ovirt-lv-2", "-L", "128m", "ovirt-vg")
try:
-lvm.bootstrap()
+lvm.bootstrap(blockSD.STORAGE_DOMAIN_TAG)
# ovirt-lv must be inactive
self.assertEqual(self.find_active_lvs("ovirt-vg"), [])
finally:
run("vgchange", "-an", "ovirt-vg")
-# TODO: do not modify vgs without STORAGE_DOMAIN_TAG
+@ValidateRunningAsRoot
+def test_skip_foreign_vgs(self):
+with fake_env() as env:
+log.debug("Creating ovirt lvs")
+run("pvcreate", "-ff", env.device)
+# This is not ovirt-vg - no STORAGE_DOMAIN_TAG
+run("vgcreate", "foreign-vg", env.device)
+run("lvcreate", "-n", "foreign-lv-1", "-L", "128m", "foreign-vg")
+run("lvcreate", "-n", "foreign-lv-2", "-L", "128m", "foreign-vg")
+try:
+lvm.bootstrap(blockSD.STORAGE_DOMAIN_TAG)
+# foreign lvs should not be modified
+self.assertEqual(self.find_active_lvs("foreign-vg"),
+ ["foreign-lv-1", "foreign-lv-2"])
+finally:
+run("vgchange", "-an", "foreign-vg")
@ValidateRunningAsRoot
def test_deactivate_unused_ovirt_lv_with_guest_lvs(self):
@@ -94,7 +109,7 @@
run("lvcreate", "--config", config, "-n", "guest-lv-2",
"-L", "128m", "guest-vg")
try:
-lvm.bootstrap()
+lvm.bootstrap(blockSD.STORAGE_DOMAIN_TAG)
# ovirt-lv must be inactive
self.assertEqual(self.find_active_lvs("ovirt-vg"), [])
except AssertionError:
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index d1b50d2..38d8d14 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -372,7 +372,8 @@
def storageRefresh():
sdCache.refreshStorage()
-lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
+lvm.bootstrap(blockSD.STORAGE_DOMAIN_TAG,
+ refreshlvs=blockSD.SPECIAL_LVS)
self._ready = True
self.log.debug("HSM is ready")
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index eadf11d..5e0ce2a 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -638,7 +638,7 @@
_lvminfo = LVMCache()
-def bootstrap(refreshlvs=()):
+def bootstrap(vg_tag, refreshlvs=()):
"""
Bootstrap lvm module
@@ -650,6 +650,10 @@
refreshlvs = set(refreshlvs)
for vg in _lvminfo.getAllVgs():
+if vg_tag not in vg.tags:
+log.info("Skipping foreign vg %s", vg.name)
+continue
+
deactivate = []
refresh = []
--
To view, visit https://gerrit.ovirt.org/64370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Deactivate guest-lvs when deactivating lvs
Nir Soffer has uploaded a new change for review.
Change subject: guest-lvs: Deactivate guest-lvs when deactivating lvs
..
guest-lvs: Deactivate guest-lvs when deactivating lvs
Before deactivating lvs (e.g. when shuting down a vm), remove holders
that may keep the lv open and prevent deactivation. This patch fixes
this error seen when a raw volume was used as a pv in the guest:
CannotDeactivateLogicalVolume: Cannot deactivate Logical Volume:
('General Storage Exception: ("5 [] [\' Logical volume
5f35b5c0-17d7-4475-9125-e97f1cdb06f9/17e03f6d-008a-45ed-8c73-d9b22430cd6a
is used by another device.\']
Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a
Bug-Url: https://bugzilla.redhat.com/1374545
Signed-off-by: Nir Soffer
---
M tests/storage_lvm_test.py
M vdsm/storage/lvm.py
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/64369/1
diff --git a/tests/storage_lvm_test.py b/tests/storage_lvm_test.py
index c5d2af1..d4a1952 100644
--- a/tests/storage_lvm_test.py
+++ b/tests/storage_lvm_test.py
@@ -103,6 +103,31 @@
finally:
run("vgchange", "-an", "ovirt-vg")
+@ValidateRunningAsRoot
+def test_deactivate_ovirt_lv_with_guest_lvs(self):
+with fake_env() as env:
+log.debug("Creating host lv")
+run("pvcreate", "-ff", env.device)
+run("vgcreate", "ovirt-vg", env.device)
+run("lvcreate", "-n", "ovirt-lv", "-L", "512m", "ovirt-vg")
+try:
+log.debug("Creating guest-lv")
+guest_pv = "/dev/ovirt-vg/ovirt-lv"
+config = "devices {filter=['a|%s|']}" % guest_pv
+run("pvcreate", "--config", config, "-ff", "-y", guest_pv)
+run("vgcreate", "--config", config, "guest-vg", guest_pv)
+run("lvcreate", "--config", config, "-n", "guest-lv",
+"-L", "128m", "guest-vg")
+try:
+lvm.deactivateLVs("ovirt-vg", ["ovirt-lv"])
+# ovirt-lv must be inactive
+self.assertEqual(self.find_active_lvs("ovirt-vg"), [])
+except AssertionError:
+run("vgchange", "--config", config, "-an", "guest-vg")
+raise
+finally:
+run("vgchange", "-an", "ovirt-vg")
+
def find_active_lvs(self, vgname):
out = run("lvs", "--noheadings", "-o", "name",
"--select", "lv_active=active", vgname)[0]
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index c501105..eadf11d 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1260,6 +1260,8 @@
def deactivateLVs(vgName, lvNames):
toDeactivate = [lvName for lvName in lvNames
if _isLVActive(vgName, lvName)]
+for lvName in toDeactivate:
+_remove_lv_holders(vgName, lvName)
if toDeactivate:
log.info("Deactivating lvs: vg=%s lvs=%s", vgName, toDeactivate)
_setLVAvailability(vgName, toDeactivate, "n")
--
To view, visit https://gerrit.ovirt.org/64369
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 12:
(4 comments)
https://gerrit.ovirt.org/#/c/64169/12/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 110: cmd.extend(("-f", format))
Line 111: if format == FORMAT.QCOW2:
Line 112: if qcow2_compat is None:
Line 113: qcow2_compat = default_qcow2_compat()
Line 114: if qcow2_compat in ("0.10", "1.1"):
> We have a constant for this.
Done
Line 115: cmd.extend(('-o', 'compat=' + qcow2_compat))
Line 116: else:
Line 117: raise ValueError("Invalid compat version '%s'" %
qcow2_compat)
Line 118:
Line 113: qcow2_compat = default_qcow2_compat()
Line 114: if qcow2_compat in ("0.10", "1.1"):
Line 115: cmd.extend(('-o', 'compat=' + qcow2_compat))
Line 116: else:
Line 117: raise ValueError("Invalid compat version '%s'" %
qcow2_compat)
> Use %r instead of '%s'.
Done
Line 118:
Line 119: if backing:
Line 120: if not os.path.isabs(backing):
Line 121: cwdPath = os.path.dirname(image)
Line 176: qcow2_compat = default_qcow2_compat()
Line 177: if qcow2_compat in ("0.10", "1.1"):
Line 178: cmd.extend(('-o', 'compat=' + qcow2_compat))
Line 179: else:
Line 180: raise ValueError("Invalid compat version '%s'" %
qcow2_compat)
> We do this logic twice - maybe extract a little helper for this, so we can
Done
Line 181:
Line 182: if backing:
Line 183: if not os.path.isabs(backing):
Line 184: cwdPath = os.path.dirname(srcImage)
https://gerrit.ovirt.org/#/c/64169/12/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 170: qemuimg.create('image', format='qcow2')
Line 171:
Line 172: def test_qcow2_compat_invalid(self):
Line 173: with self.assertRaises(ValueError):
Line 174: qemuimg.create('image', format='qcow2',
qcow2_compat='1.11')
> Nice!
"None" is already being tested (for example test_qcow2_compat tests it since it
does not send any value)
Regarding the other tests - done
Line 175:
Line 176: def test_invalid_config(self):
Line 177: config = make_config([('irs', 'qcow2_compat', '1.2')])
Line 178: with MonkeyPatchScope([(qemuimg, 'config', config)]):
--
To view, visit https://gerrit.ovirt.org/64169
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable
gerrit-hooks has posted comments on this change. Change subject: tests: Make the run_tests*.sh scripts readable .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff09b1e71e2ca91ec3ef01490d019a893ff55b23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Make unit tests the default
gerrit-hooks has posted comments on this change. Change subject: tests: Make unit tests the default .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94751f8f3e3d4849f61ea11718afda5b1484c28f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError
gerrit-hooks has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/34364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf1564f81f4c1fbf77ccaff6d93c047a02d946da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError
Jenkins CI RO has abandoned this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/34364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icf1564f81f4c1fbf77ccaff6d93c047a02d946da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Make unit tests the default
Jenkins CI RO has abandoned this change. Change subject: tests: Make unit tests the default .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/55728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I94751f8f3e3d4849f61ea11718afda5b1484c28f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable
Jenkins CI RO has abandoned this change. Change subject: tests: Make the run_tests*.sh scripts readable .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/55729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iff09b1e71e2ca91ec3ef01490d019a893ff55b23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: Use new concurrent.thread() utility
Jenkins CI RO has abandoned this change. Change subject: network: Use new concurrent.thread() utility .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/45553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I62e809354d3173cce631ed5579532cf7cdcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: Use new concurrent.thread() utility
gerrit-hooks has posted comments on this change. Change subject: network: Use new concurrent.thread() utility .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62e809354d3173cce631ed5579532cf7cdcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 6: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 5: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 5: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 4: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 4: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
gerrit-hooks has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 3: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add loop module
gerrit-hooks has posted comments on this change. Change subject: tests: Add loop module .. Patch Set 3: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
Nir Soffer has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 3: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
Nir Soffer has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add loop module
Nir Soffer has posted comments on this change. Change subject: tests: Add loop module .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/64329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
Nir Soffer has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 3: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add lvm bootstrap tests .. Patch Set 1: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add failing test for guest lvs
gerrit-hooks has posted comments on this change. Change subject: guest-lvs: Add failing test for guest lvs .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
gerrit-hooks has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add loop module
gerrit-hooks has posted comments on this change. Change subject: tests: Add loop module .. Patch Set 2: * #1374545::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374545::OK, public bug * Check Product::#1374545::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests
Nir Soffer has uploaded a new change for review.
Change subject: guest-lvs: Add lvm bootstrap tests
..
guest-lvs: Add lvm bootstrap tests
Add fake_env for creating lvm tests using loop devices instead of shared
storage, and start lvm.bootstrap tests.
The first test is verifying that unused ovirt lvs are deactivated.
Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Bug-Url: https://bugzilla.redhat.com/1374545
Signed-off-by: Nir Soffer
---
M tests/storage_lvm_test.py
1 file changed, 86 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/64367/1
diff --git a/tests/storage_lvm_test.py b/tests/storage_lvm_test.py
index 6792266..67ed799 100644
--- a/tests/storage_lvm_test.py
+++ b/tests/storage_lvm_test.py
@@ -19,9 +19,25 @@
# Refer to the README and COPYING files for full details of the license
#
-from testlib import VdsmTestCase as TestCaseBase
+import collections
+import os
+import logging
-import storage.lvm as lvm
+from contextlib import contextmanager
+
+from vdsm import commands
+from vdsm import cmdutils
+
+from storage import blockSD
+from storage import lvm
+
+import loop
+from monkeypatch import MonkeyPatchScope
+from testlib import VdsmTestCase as TestCaseBase
+from testlib import namedTemporaryDir
+from testValidation import ValidateRunningAsRoot
+
+log = logging.getLogger("test")
class LvmTests(TestCaseBase):
@@ -37,3 +53,71 @@
"x22x28|\', \'r|.*|\' ]"
)
self.assertEqual(expectedFilter, filter)
+
+
+class TestBootstrap(TestCaseBase):
+
+@ValidateRunningAsRoot
+def test_deactivate_unused_ovirt_lvs(self):
+with fake_env() as env:
+log.debug("Creating ovirt lvs")
+run("pvcreate", "-ff", env.device)
+run("vgcreate", "ovirt-vg", env.device)
+run("vgchange", "--addtag", blockSD.STORAGE_DOMAIN_TAG)
+run("lvcreate", "-n", "ovirt-lv-1", "-L", "128m", "ovirt-vg")
+run("lvcreate", "-n", "ovirt-lv-2", "-L", "128m", "ovirt-vg")
+try:
+lvm.bootstrap()
+# ovirt-lv must be inactive
+self.check_no_active_lvs("ovirt-vg")
+finally:
+run("lvchange", "-an", "ovirt-vg")
+
+# TODO: do not modify vgs without STORAGE_DOMAIN_TAG
+
+def check_no_active_lvs(self, vgname):
+out = run("lvs", "--noheadings", "-o", "name",
+ "--select", "lv_active=active", vgname)[0]
+lvs = [line.strip() for line in out.splitlines()]
+self.assertEqual(lvs, [])
+
+
+Env = collections.namedtuple("Env", "tmpdir, device")
+
+
+@contextmanager
+def fake_env():
+"""
+Create test environment for lvm tests.
+"""
+with namedTemporaryDir() as tmpdir:
+backing_file = os.path.join(tmpdir, "backing_file")
+truncate(backing_file, 1024**3)
+with loop.Device(backing_file) as device:
+log.debug("Using loop device %s", device.path)
+with MonkeyPatchScope([
+# Created during bootstrap.
+(lvm, "VDSM_LVM_SYSTEM_DIR", os.path.join(tmpdir, "lvm")),
+# Saved each time conf is changed.
+(lvm, "VDSM_LVM_CONF", os.path.join(tmpdir, "lvm",
"lvm.conf")),
+# Allow detection of test device, otherwise only
+# /dev/mapper/guid devices are detected.
+(lvm, "USER_DEV_LIST", [device.path]),
+]):
+try:
+yield Env(tmpdir, device.path)
+finally:
+# Update lvmetad to keep the environment sane
+run("pvscan", "--cache")
+
+
+def run(*cmd):
+rc, out, err = commands.execCmd(cmd, raw=True)
+if rc != 0:
+raise cmdutils.Error(cmd, rc, out, err)
+return out, err
+
+
+def truncate(path, size):
+with open(path, "w") as f:
+f.truncate(size)
--
To view, visit https://gerrit.ovirt.org/64367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sos: collect 'nodectl info' output
Irit Goihman has posted comments on this change. Change subject: sos: collect 'nodectl info' output .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/63775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sos: collect 'nodectl info' output
Dan Kenigsberg has posted comments on this change. Change subject: sos: collect 'nodectl info' output .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net test: shared nic between bond and network
Dan Kenigsberg has submitted this change and it was merged. Change subject: net test: shared nic between bond and network .. net test: shared nic between bond and network Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/64206 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/network/func_net_with_bond_test.py 1 file changed, 31 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net test: shared nic between bond and network
gerrit-hooks has posted comments on this change. Change subject: net test: shared nic between bond and network .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net test: shared nic between bond and network
Dan Kenigsberg has posted comments on this change. Change subject: net test: shared nic between bond and network .. Patch Set 4: Code-Review+2 rasing -- To view, visit https://gerrit.ovirt.org/64206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: remove capsTests from blacklist
Dan Kenigsberg has posted comments on this change. Change subject: py3: remove capsTests from blacklist .. Patch Set 2: Verified+1 capsTests pass on both py2 and py3 -- To view, visit https://gerrit.ovirt.org/64363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49264d5eaa19bb957c69461dfb1cdfe641294037 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
Dan Kenigsberg has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 15: Code-Review+2 raising score. please backport! -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 16: * #1372798::Update tracker: OK * Set MODIFIED::bug 1372798#1372798::IGNORE, skipping for branch 'master' -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: edit bond detached from bridge but still attached to a vlan .. net: edit bond detached from bridge but still attached to a vlan Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Signed-off-by: Petr Horáček Bug-Url: https://bugzilla.redhat.com/1372798 Reviewed-on: https://gerrit.ovirt.org/63723 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/configurators/ifcfg.py A tests/network/func_net_with_bond_test.py 2 files changed, 102 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: remove capsTests from blacklist
gerrit-hooks has posted comments on this change. Change subject: py3: remove capsTests from blacklist .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49264d5eaa19bb957c69461dfb1cdfe641294037 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
