Change in vdsm[ovirt-3.6]: network: replace NM_CONTROLLED=no with 'yes'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: replace NM_CONTROLLED=no with 'yes'
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/56447
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f94f15b2d1c63d4eab61bc05e31e3bf1426953
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: network: replace NM_CONTROLLED=no with 'yes'

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: network: replace NM_CONTROLLED=no with 'yes'
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/56447
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie7f94f15b2d1c63d4eab61bc05e31e3bf1426953
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: replace NM_CONTROLLED=no with 'yes'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: replace NM_CONTROLLED=no with 'yes'
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/56443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f94f15b2d1c63d4eab61bc05e31e3bf1426953
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: replace NM_CONTROLLED=no with 'yes'

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: network: replace NM_CONTROLLED=no with 'yes'
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/56443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie7f94f15b2d1c63d4eab61bc05e31e3bf1426953
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add qcow2_compat on create

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 20: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Calculate qcow volume size on import.

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: image: Calculate qcow volume size on import.
..

image: Calculate qcow volume size on import.

Estimating qcow2 file size when converting from raw to
qcow.

The calculation is as follow:
min_allocation = (used_blocks * block_size) +
(virtual_size / cluster_size * 64 bit L2 table entry) +
extra Gib e to avoid instant extend.

Change-Id: Ia87df2b0d5378f93c5cb2cc68a37458fe3b4467b
Bug-Url: https://bugzilla.redhat.com/1358717
Signed-off-by: Maor Lipchuk 
---
M vdsm/storage/image.py
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/65039/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index ccaf971..274f438 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -45,6 +45,11 @@
 log = logging.getLogger('storage.Image')
 rmanager = rm.ResourceManager.getInstance()
 
+# Pre-configured QCOW volume size.
+CLUSTER_SIZE = 65536
+BLOCK_SIZE = sc.BLOCK_SIZE
+GIB_BLOCK = 10 ** 9 / BLOCK_SIZE  # GiB
+
 # Disk type
 UNKNOWN_DISK_TYPE = 0
 SYSTEM_DISK_TYPE = 1
@@ -842,7 +847,17 @@
 if dstVolFormat == sc.RAW_FORMAT:
 newsize = volParams['size']
 else:
-newsize = volParams['apparentsize']
+# Estimating qcow2 file size when converting from raw to
+# qcow. The calculation is as follow: min_allocation =
+# (used_blocks * block_size) +
+# (virtual_size / cluster_size * 64 bit L2 table entry) +
+# 1 extra Gib e to avoid instant extend.
+newsize = ((volParams['truesize'] * BLOCK_SIZE) +
+   (volParams['size'] / CLUSTER_SIZE * 8) +
+   GIB_BLOCK)
+self.log.info("qcow volume size to be copied is %i",
+  newsize)
+
 dstVol.extend(newsize)
 dstPath = dstVol.getVolumePath()
 # Change destination volume metadata back to the original size.


-- 
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia87df2b0d5378f93c5cb2cc68a37458fe3b4467b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: image: Calculate qcow volume size on import.

[mlipchuk]

Maor Lipchuk has posted comments on this change.

Change subject: image: Calculate qcow volume size on import.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia87df2b0d5378f93c5cb2cc68a37458fe3b4467b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Add qcow2_compat on create
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: copy_data: Add qcow2_compat on convert.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: copy_data: Add qcow2_compat on convert.
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume_artifacts: Add qcow2_compat on create.
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add qcow2_compat on create

[automation]

gerrit-hooks has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Make ResourceMananger private

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Make ResourceMananger private
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35c3cffb4e1af8aa0f238c3501a82b975d56c2c3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rsourceFactories: Use new resourceManager module api

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rsourceFactories: Use new resourceManager module api
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdb30f34257f31622a87d1f496b3f516803eeda8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Get rid of getInstance

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Get rid of getInstance
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I136ab52f15332f43f2b0ecd9e9a2ff7b558df87a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Add module api

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Add module api
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie315f10bacdf49f1023d1991811afec28ed0d7f9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourcemanager: Use new module api

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourcemanager: Use new module api
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33d9fad90551a0c2e9b1e8a89c5f9f920681c6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rsourceFactories: Use new resourceManager module api

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: rsourceFactories: Use new resourceManager module api
..

rsourceFactories: Use new resourceManager module api

Replace usage of getInstance with direct module access.

Change-Id: Icdb30f34257f31622a87d1f496b3f516803eeda8
Signed-off-by: Nir Soffer 
---
M vdsm/storage/resourceFactories.py
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/65036/1

diff --git a/vdsm/storage/resourceFactories.py 
b/vdsm/storage/resourceFactories.py
index bf8e498..4126db8 100644
--- a/vdsm/storage/resourceFactories.py
+++ b/vdsm/storage/resourceFactories.py
@@ -31,8 +31,6 @@
 import sd
 import image
 
-rmanager = rm.ResourceManager.getInstance()
-
 log = logging.getLogger('storage.ResourcesFactories')
 
 
@@ -152,12 +150,12 @@
 try:
 if template:
 if len(volUUIDChain) > 0:
-volRes = rmanager.acquireResource(
+volRes = rm.acquireResource(
 self.volumeResourcesNamespace,
 template, rm.SHARED,
 timeout=self.resource_default_timeout)
 else:
-volRes = rmanager.acquireResource(
+volRes = rm.acquireResource(
 self.volumeResourcesNamespace,
 template, lockType,
 timeout=self.resource_default_timeout)
@@ -165,7 +163,7 @@
 
 # Acquire 'lockType' volume locks
 for volUUID in volUUIDChain:
-volRes = rmanager.acquireResource(
+volRes = rm.acquireResource(
 self.volumeResourcesNamespace,
 volUUID, lockType,
 timeout=self.resource_default_timeout)


-- 
To view, visit https://gerrit.ovirt.org/65036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icdb30f34257f31622a87d1f496b3f516803eeda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Make ResourceMananger private

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Make ResourceMananger private
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35c3cffb4e1af8aa0f238c3501a82b975d56c2c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Get rid of getInstance

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Get rid of getInstance
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I136ab52f15332f43f2b0ecd9e9a2ff7b558df87a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rsourceFactories: Use new resourceManager module api

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rsourceFactories: Use new resourceManager module api
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdb30f34257f31622a87d1f496b3f516803eeda8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Make ResourceMananger private

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Make ResourceMananger private
..

resourceManager: Make ResourceMananger private

Just to make sure that nobody will try to create its own instance
somewhere.

Change-Id: I35c3cffb4e1af8aa0f238c3501a82b975d56c2c3
Signed-off-by: Nir Soffer 
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/resourceManager.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/65038/1

diff --git a/tests/storage_resourcemanager_test.py 
b/tests/storage_resourcemanager_test.py
index 5859f61..d324670 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -115,9 +115,9 @@
 
 def manager():
 """
-Create fresh ResourceManager instance for testing.
+Create fresh _ResourceManager instance for testing.
 """
-manager = rm.ResourceManager()
+manager = rm._ResourceManager()
 manager.registerNamespace("storage", rm.SimpleResourceFactory())
 manager.registerNamespace("null", NullResourceFactory())
 manager.registerNamespace("string", StringResourceFactory())
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index a3b0c0e..20aa06c 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -330,7 +330,7 @@
 repr(self.__wrappedObject) if self.isValid else None)
 
 
-class ResourceManager(object):
+class _ResourceManager(object):
 """
 Manages all the resources in the application.
 
@@ -1007,7 +1007,7 @@
 
 
 # The single resource manager - this instance is monkeypatched by the tests.
-_manager = ResourceManager()
+_manager = _ResourceManager()
 
 
 # Public api - client should use only these to manage resources.


-- 
To view, visit https://gerrit.ovirt.org/65038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35c3cffb4e1af8aa0f238c3501a82b975d56c2c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Get rid of getInstance

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Get rid of getInstance
..

resourceManager: Get rid of getInstance

The single instance of ResourceManager is created in import time,
eliminating the clumsy getInstance mechanism.

Internal callers in the resourceManager module are using now the module
interface directly.

Change-Id: I136ab52f15332f43f2b0ecd9e9a2ff7b558df87a
Signed-off-by: Nir Soffer 
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/resourceManager.py
2 files changed, 57 insertions(+), 87 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/65037/1

diff --git a/tests/storage_resourcemanager_test.py 
b/tests/storage_resourcemanager_test.py
index 8ff65c8..5859f61 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -130,19 +130,13 @@
 
 class ResourceManagerTests(TestCaseBase):
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testErrorInFactory(self):
 req = rm._registerResource(
 "error", "resource", rm.EXCLUSIVE, lambda req, res: 1)
 self.assertTrue(req.canceled())
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
-def testSingleton(self):
-a = rm.ResourceManager.getInstance()
-b = rm.ResourceManager.getInstance()
-self.assertEquals(id(a), id(b))
-
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testRegisterInvalidNamespace(self):
 try:
 rm.registerNamespace("I.HEART.DOTS", rm.SimpleResourceFactory())
@@ -151,7 +145,7 @@
 
 self.fail("Managed to register an invalid namespace")
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testFailCreateAfterSwitch(self):
 resources = []
 
@@ -166,30 +160,30 @@
 self.assertTrue(sharedReq1.canceled())
 self.assertEquals(resources[0], None)
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testReregisterNamespace(self):
 self.assertRaises((ValueError, KeyError), rm.registerNamespace,
   "storage", rm.SimpleResourceFactory())
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testResourceSwitchLockTypeFail(self):
 self.testResourceLockSwitch("switchfail")
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testRequestInvalidResource(self):
 self.assertRaises(ValueError, rm.acquireResource,
   "storage", "DOT.DOT", rm.SHARED)
 self.assertRaises(ValueError, rm.acquireResource,
   "DOT.DOT", "resource", rm.SHARED)
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testReleaseInvalidResource(self):
 self.assertRaises(ValueError, rm.releaseResource,
   "DONT_EXIST", "resource")
 self.assertRaises(ValueError, rm.releaseResource, "storage",
   "DOT")
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testResourceWrapper(self):
 s = StringIO
 with rm.acquireResource("string", "test", rm.EXCLUSIVE) as resource:
@@ -198,7 +192,7 @@
 continue
 self.assertTrue(hasattr(resource, attr))
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testAccessAttributeNotExposedByWrapper(self):
 with rm.acquireResource("string", "test", rm.EXCLUSIVE) as resource:
 try:
@@ -212,7 +206,7 @@
 
 self.fail("Managed to access an attribute not exposed by wrapper")
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testAccessAttributeNotExposedByRequestRef(self):
 resources = []
 
@@ -233,7 +227,7 @@
 
 self.fail("Managed to access an attribute not exposed by wrapper")
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testRequestRefStr(self):
 resources = []
 
@@ -247,7 +241,7 @@
 req.wait()
 resources[0].release()
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, "_manager", manager())
 def testRequestRefCmp(self):
 resources = []
 requests = []
@@ -278,7 +272,7 @@
 
 self.assertNotEqual(req1, "STUFF")
 
-@MonkeyPatch(rm.ResourceManager, "_instance", manager())
+@MonkeyPatch(rm, 

Change in vdsm[master]: resourcemanager: Use new module api

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourcemanager: Use new module api
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33d9fad90551a0c2e9b1e8a89c5f9f920681c6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Add module api

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Add module api
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie315f10bacdf49f1023d1991811afec28ed0d7f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Add module api

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Add module api
..

resourceManager: Add module api

resourceManager has a Java like verbose api that make it hard to use and
is not safe. Add module api hiding the single ResourceManager instance.

Instead of this:

manager = rm.ResourceManager.getInstance()
manager.acquireResource("mamespace", "name", rm.SHRARED)

Or this wrong usage:

manager = ResourceManager()
manager.acquireResource("mamespace", "name", rm.SHRARED)

We can use now this:

rm.acquireResource("mamespace", "name", rm.SHRARED)

This is the simplest and safest way to implement a singleton in Python,
a module.

This patch adds the new api and update the tests to use this api.

Change-Id: Ie315f10bacdf49f1023d1991811afec28ed0d7f9
Signed-off-by: Nir Soffer 
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/resourceManager.py
2 files changed, 96 insertions(+), 102 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/65034/1

diff --git a/tests/storage_resourcemanager_test.py 
b/tests/storage_resourcemanager_test.py
index 307fea5..8ff65c8 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -132,9 +132,8 @@
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testErrorInFactory(self):
-manager = rm.ResourceManager.getInstance()
-req = manager.registerResource("error", "resource", rm.EXCLUSIVE,
-   lambda req, res: 1)
+req = rm._registerResource(
+"error", "resource", rm.EXCLUSIVE, lambda req, res: 1)
 self.assertTrue(req.canceled())
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
@@ -145,10 +144,8 @@
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testRegisterInvalidNamespace(self):
-manager = rm.ResourceManager.getInstance()
 try:
-manager.registerNamespace("I.HEART.DOTS",
-  rm.SimpleResourceFactory())
+rm.registerNamespace("I.HEART.DOTS", rm.SimpleResourceFactory())
 except ValueError:
 return
 
@@ -161,10 +158,9 @@
 def callback(req, res):
 resources.append(res)
 
-manager = rm.ResourceManager.getInstance()
-exclusive1 = manager.acquireResource(
+exclusive1 = rm.acquireResource(
 "failAfterSwitch", "resource", rm.EXCLUSIVE)
-sharedReq1 = manager.registerResource(
+sharedReq1 = rm._registerResource(
 "failAfterSwitch", "resource", rm.SHARED, callback)
 exclusive1.release()
 self.assertTrue(sharedReq1.canceled())
@@ -172,8 +168,7 @@
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testReregisterNamespace(self):
-manager = rm.ResourceManager.getInstance()
-self.assertRaises((ValueError, KeyError), manager.registerNamespace,
+self.assertRaises((ValueError, KeyError), rm.registerNamespace,
   "storage", rm.SimpleResourceFactory())
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
@@ -182,27 +177,22 @@
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testRequestInvalidResource(self):
-manager = rm.ResourceManager.getInstance()
-self.assertRaises(ValueError, manager.acquireResource,
+self.assertRaises(ValueError, rm.acquireResource,
   "storage", "DOT.DOT", rm.SHARED)
-self.assertRaises(ValueError, manager.acquireResource,
+self.assertRaises(ValueError, rm.acquireResource,
   "DOT.DOT", "resource", rm.SHARED)
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testReleaseInvalidResource(self):
-manager = rm.ResourceManager.getInstance()
-self.assertRaises(ValueError, manager.releaseResource,
+self.assertRaises(ValueError, rm.releaseResource,
   "DONT_EXIST", "resource")
-self.assertRaises(ValueError, manager.releaseResource, "storage",
+self.assertRaises(ValueError, rm.releaseResource, "storage",
   "DOT")
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testResourceWrapper(self):
-manager = rm.ResourceManager.getInstance()
 s = StringIO
-with manager.acquireResource(
-"string", "test",
-rm.EXCLUSIVE) as resource:
+with rm.acquireResource("string", "test", rm.EXCLUSIVE) as resource:
 for attr in dir(s):
 if attr == "close":
 continue
@@ -210,10 +200,7 @@
 
 @MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testAccessAttributeNotExposedByWrapper(self):
-manager = 

Change in vdsm[master]: resourcemanager: Use new module api

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourcemanager: Use new module api
..

resourcemanager: Use new module api

Replace client code to use the resourceManager module directly instead
of using ResourceManager.getInstance().

After this patch only the resourceManager and resourceFactories are
using the old getInstance api.

Tests that used to mock modules "rmanager" variable are mocking the "rm"
variable, and storagefakelib.FakeResourceManager implements now the
resourceManager module api instead of the
resourceManager.ResourceManager class. This seems to be the quickest
solution for keeping these tests working, but we may use differnet way
later.

Change-Id: Ib33d9fad90551a0c2e9b1e8a89c5f9f920681c6b
Signed-off-by: Nir Soffer 
---
M tests/storage_sdm_copy_data_test.py
M tests/storage_sdm_create_volume_test.py
M tests/storagefakelib.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sd.py
M vdsm/storage/sdm/api/create_volume.py
M vdsm/storage/sp.py
M vdsm/storage/volume.py
11 files changed, 73 insertions(+), 91 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/65035/1

diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index db4d99e..d60936a 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -82,7 +82,7 @@
 with MonkeyPatchScope([
 (guarded, 'context', fake_guarded_context()),
 (storage.sdm.api.copy_data, 'sdCache', env.sdcache),
-(blockVolume, 'rmanager', rm),
+(blockVolume, 'rm', rm),
 ]):
 src_vols = make_qemu_chain(env, size, src_fmt, chain_length)
 dst_vols = make_qemu_chain(env, size, dst_fmt, chain_length)
diff --git a/tests/storage_sdm_create_volume_test.py 
b/tests/storage_sdm_create_volume_test.py
index 9c9295f..0fb7e4b 100644
--- a/tests/storage_sdm_create_volume_test.py
+++ b/tests/storage_sdm_create_volume_test.py
@@ -103,7 +103,7 @@
 @contextmanager
 def _fake_env(self):
 self.rm = FakeResourceManager()
-with MonkeyPatchScope([(storage.sdm.api.create_volume, 'rmanager',
+with MonkeyPatchScope([(storage.sdm.api.create_volume, 'rm',
 self.rm)]):
 yield
 
diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 7ea0cee..3fff119 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -30,6 +30,7 @@
 from vdsm import utils
 
 from storage import lvm as real_lvm
+from storage import resourceManager as rm
 
 
 class FakeLVM(object):
@@ -278,6 +279,9 @@
 
 class FakeResourceManager(object):
 
+SHARED = rm.SHARED
+EXCLUSIVE = rm.EXCLUSIVE
+
 @recorded
 @contextmanager
 def acquireResource(self, *args, **kwargs):
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 0f094fd..f39d41a 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -862,15 +862,13 @@
 """
 sd.StorageDomain._registerResourceNamespaces(self)
 
-rmanager = rm.ResourceManager.getInstance()
 # Register lvm activation resource namespace for the underlying VG
 lvmActivationFactory = resourceFactories.LvmActivationFactory(
 self.sdUUID)
 lvmActivationNamespace = sd.getNamespace(sc.LVM_ACTIVATION_NAMESPACE,
  self.sdUUID)
 try:
-rmanager.registerNamespace(lvmActivationNamespace,
-   lvmActivationFactory)
+rm.registerNamespace(lvmActivationNamespace, lvmActivationFactory)
 except KeyError:
 self.log.info("Resource namespace %s already registered",
   lvmActivationNamespace)
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 6d68d26..c6d128a 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -60,7 +60,6 @@
 RESERVED_LEASES = 100
 
 log = logging.getLogger('storage.Volume')
-rmanager = rm.ResourceManager.getInstance()
 
 
 class BlockVolumeManifest(volume.VolumeManifest):
@@ -372,8 +371,8 @@
 if setrw:
 self.setrw(rw=rw)
 access = rm.EXCLUSIVE if rw else rm.SHARED
-activation = rmanager.acquireResource(self.lvmActivationNamespace,
-  self.volUUID, access)
+activation = rm.acquireResource(self.lvmActivationNamespace,
+self.volUUID, access)
 activation.autoRelease = False
 
 @classmethod
@@ -387,7 +386,7 @@
  % (sdUUID, volUUID, justme))
 lvmActivationNamespace = sd.getNamespace(sc.LVM_ACTIVATION_NAMESPACE,
  

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during deactivation

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during deactivation
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: guest-lvs: Skip foreign vgs during bootstrap
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add failing test for guest lvs

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: guest-lvs: Add failing test for guest lvs
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add loopback module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add loopback module
..


Patch Set 7: Verified+1

This version address the issue I mention in the previous version.

-- 
To view, visit https://gerrit.ovirt.org/64329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: guest-lvs: Add lvm bootstrap tests
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Rename lvmTests to new naming convention

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Rename lvmTests to new naming convention
..


Patch Set 6: Continuous-Integration+1

Network tests failing on python 3

-- 
To view, visit https://gerrit.ovirt.org/64328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during deactivation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during deactivation
..


Patch Set 6:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add failing test for guest lvs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Add failing test for guest lvs
..


Patch Set 11:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Skip foreign vgs during bootstrap
..


Patch Set 6:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during bootstrap
..


Patch Set 5:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Add lvm bootstrap tests
..


Patch Set 10:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add loopback module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add loopback module
..


Patch Set 7:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: core: Expose API for qemuimg commit
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/64222/9/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 380: (2, qemuimg.FORMAT.QCOW2, "0.10", True),
Line 381: (4, qemuimg.FORMAT.RAW, "1.1", True),
Line 382: (4, qemuimg.FORMAT.RAW, "0.10", True),
Line 383: (4, qemuimg.FORMAT.QCOW2, "1.1", True),
Line 384: (4, qemuimg.FORMAT.QCOW2, "0.10", True)
In all these options, we merge entire chain. It would be nice to test merge of 
a sub chain.

For example, create chain of 4 volumes:

vol0, vol1, vol2, vol3

And merge vol3 into vol1.

I would create the same chain in all the tests (4 volumes), and check different 
merges, so the permutations can be:

# base_format, qcow2_compat, top, base
("raw", "0.10", 3, 2),

This will merge chain[3] into chain[2].

For verification, you can check that chain[2] contains the entire data, and 
that chain[3] blocks count did not change.
Line 385: ])
Line 386: def test_commit(self, chain_len, base_format, qcow2_compat,
Line 387: use_base=True):
Line 388: size = 1048576


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Expose API for qemuimg commit

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: core: Expose API for qemuimg commit
..


Patch Set 9:

(5 comments)

https://gerrit.ovirt.org/#/c/64222/9/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 391: parent = None
Line 392: for i in range(chain_len):
Line 393: vol = os.path.join(tmpdir, "vol%d.img" % i)
Line 394: format = base_format if i == 0 else 
qemuimg.FORMAT.QCOW2
Line 395: make_image(vol, size, format, i, qcow2_compat, parent)
We can take the size of each volume here:

blocks = os.stat(vol).st_blocks

And append tuples (vol, blocks):

chain.append((vol, blocks))
Line 396: chain.append(vol)
Line 397: parent = vol
Line 398: 
Line 399: op = qemuimg.commit(chain[-1], 
topFormat=qemuimg.FORMAT.QCOW2,


Line 399: op = qemuimg.commit(chain[-1], 
topFormat=qemuimg.FORMAT.QCOW2,
Line 400: base=chain[0] if use_base else None)
Line 401: op.wait_for_completion()
Line 402: 
Line 403: for i, vol in enumerate(chain):
If we stored tuples, we get back:

for i, (vol, blocks) in enumerate(chain):
...
Line 404: offset = "{}k".format(i)
Line 405: pattern = 0xf0 + (i)
Line 406: qemu_pattern_verify(chain[0], base_format, 
offset=offset,
Line 407: len='1k', pattern=pattern)


Line 401: op.wait_for_completion()
Line 402: 
Line 403: for i, vol in enumerate(chain):
Line 404: offset = "{}k".format(i)
Line 405: pattern = 0xf0 + (i)
Why (i)? This is same as i.
Line 406: qemu_pattern_verify(chain[0], base_format, 
offset=offset,
Line 407: len='1k', pattern=pattern)
Line 408: qemu_pattern_verify(vol, qemuimg.FORMAT.QCOW2, 
offset=offset,
Line 409: len='1k', pattern=pattern)


Line 403: for i, vol in enumerate(chain):
Line 404: offset = "{}k".format(i)
Line 405: pattern = 0xf0 + (i)
Line 406: qemu_pattern_verify(chain[0], base_format, 
offset=offset,
Line 407: len='1k', pattern=pattern)
We need to explain this:

# The base volume must have the data from all the volumes merged into it.
check base...
Line 408: qemu_pattern_verify(vol, qemuimg.FORMAT.QCOW2, 
offset=offset,
Line 409: len='1k', pattern=pattern)
Line 410: 
Line 411: def test_commit_progress(self):


Line 405: pattern = 0xf0 + (i)
Line 406: qemu_pattern_verify(chain[0], base_format, 
offset=offset,
Line 407: len='1k', pattern=pattern)
Line 408: qemu_pattern_verify(vol, qemuimg.FORMAT.QCOW2, 
offset=offset,
Line 409: len='1k', pattern=pattern)
This check will always succeed, even if you forget to add the -d flag (try it).
When you verify a volume, you see the data in the base.

We can compare instead the number of used blocks on each file:

if i > 0:
# internal and top volumes should keep the data, we may want to
# wipe this data when deleting the volumes later.
self.assertEqual(os.stat(vol).st_blocks, blocks)
Line 410: 
Line 411: def test_commit_progress(self):
Line 412: with namedTemporaryDir() as tmpdir:
Line 413: size = 1048576


-- 
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during bootstrap
..


Patch Set 4:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Skip foreign vgs during bootstrap
..


Patch Set 5:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during deactivation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during deactivation
..


Patch Set 5:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add failing test for guest lvs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Add failing test for guest lvs
..


Patch Set 10:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Rename lvmTests to new naming convention

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Rename lvmTests to new naming convention
..


Patch Set 6:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Add lvm bootstrap tests
..


Patch Set 9:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add loopback module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add loopback module
..


Patch Set 6:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Ignore missing graphics from VM conf on target host
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64300/1//COMMIT_MSG
Commit Message:

PS1, Line 10: fir
> ?
Done


-- 
To view, visit https://gerrit.ovirt.org/64300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Ignore missing graphics from VM conf on target host
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Ignore missing graphics from VM conf on target host
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 82: raise VmMigrationHookError('No devices entity in VM conf')
Line 83: 
Line 84: try:
Line 85: _set_graphics(devices, target_vm_conf)
Line 86: except VmMigrationMissingDisplayConf:
> Add TODO to drop the code when we stop supporting version ?
I am not sure if that will be even correct.
Has the fix in Engine took care of upgrades? (Upon upgrade, fix the VM conf)
Or has it just made sure a new VM is correctly configured?
Line 87: # Due to a bug in Engine, there can be a scenario where the 
domxml
Line 88: # includes a graphics section, however, the VM config on 
target does
Line 89: # not. In such cases, ignore and do not touch this section.
Line 90: pass


-- 
To view, visit https://gerrit.ovirt.org/64300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org