date:20161009

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: dockerfile: Add Fedora dockerfile
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/63966/4/configure.ac
File configure.ac:

Line 307
Line 308
Line 309
Line 310
Line 311
> Right, but don't we want to check it in an early stage of the test anyway?
We cannot check in configure since configure is run during make rpm.

We have a check in make tests - if you run "make check" or "make tests" and you 
don't have nose or have an older version, your build will fail.


-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread edwardh

Edward Haas has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/63966/4/configure.ac
File configure.ac:

Line 307
Line 308
Line 309
Line 310
Line 311
> We cannot use this check since nose is not installed at this point, it is i
Right, but don't we want to check it in an early stage of the test anyway?
I guess it does not matter much, it would just be a nice to have: explicitly 
warn that nose is missing if a test run is attempted.


-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 13:

From the discussion with Richard and Kevin, we learned that we can use this 
only on the top volume in an image. We need to validate that the volume 
requested by the caller is the leaf volume, and fail the request if not.

We also must prevent usage of this verb on a template image used by any other 
image. Doing this check safely may be hard since it can be done only on the spm.

Finally we must protect the image during the operation using volume generation 
and mark the image as illegal, so another host cannot consume this image while 
we are sparsifying it. See the latest version of copy_data for the details how 
it is done.

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Revert "build tests: Require NOSE 1.3.7 and up for running t...

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running 
tests"
..


Patch Set 2: -Code-Review

We can keep the nose check if we take https://gerrit.ovirt.org/63966.

-- 
To view, visit https://gerrit.ovirt.org/64035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I175c0752a5929d1b644cd41cf8d111bcce10f32d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/63966/4/configure.ac
File configure.ac:

Line 298
Line 299
Line 300
Line 301
Line 302
> Right, I'll leave this line as is.
Fixed in current version.


-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/63966/4/configure.ac
File configure.ac:

Line 298
Line 299
Line 300
Line 301
Line 302
> If we have not touched nose for py3, why not leaving this check in?
Right, I'll leave this line as is.


Line 307
Line 308
Line 309
Line 310
Line 311
> I guess the check should now move the the makefile.
We cannot use this check since nose is not installed at this point, it is 
installed later during make check.


-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread edwardh

Edward Haas has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/63966/4/configure.ac
File configure.ac:

Line 298
Line 299
Line 300
Line 301
Line 302
If we have not touched nose for py3, why not leaving this check in?


Line 307
Line 308
Line 309
Line 310
Line 311
I guess the check should now move the the makefile.
This check is now covered by the nose minimum version validation?


-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Separate Fedora and Centos builds

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: travis: Separate Fedora and Centos builds
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/65284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe524df5f4baf4f3c24f8da56c30d52ee22f8b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Add Fedora 24 build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: travis: Add Fedora 24 build
..


Patch Set 3: Verified+1

See https://travis-ci.org/nirs/vdsm/builds/166263228

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Add Fedora 24 build

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: travis: Add Fedora 24 build
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Separate Fedora and Centos builds

2016-10-09 Thread nsoffer

Nir Soffer has abandoned this change.

Change subject: travis: Separate Fedora and Centos builds
..


Abandoned

Squashed into the previous patch.

-- 
To view, visit https://gerrit.ovirt.org/65284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0fe524df5f4baf4f3c24f8da56c30d52ee22f8b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Separate Fedora and Centos builds

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: travis: Separate Fedora and Centos builds
..


Patch Set 1:

Check https://travis-ci.org/nirs/vdsm/builds/166259313

Both builds were running concurrently, finished in 3:44. about 5 time faster 
than jenkins :-)

Jenkins jobs:
- http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/3168/ 
finishe in 15 minutes (python 2 only)
- 
http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/3168/consoleFull
 finished in 19 minutes.

-- 
To view, visit https://gerrit.ovirt.org/65284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe524df5f4baf4f3c24f8da56c30d52ee22f8b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Separate Fedora and Centos builds

2016-10-09 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: travis: Separate Fedora and Centos builds
..

travis: Separate Fedora and Centos builds

Add build matrix, creating two sub-build for each build, one using the
Fedora image and the other the CentOS image.

Change-Id: I0fe524df5f4baf4f3c24f8da56c30d52ee22f8b1
Signed-off-by: Nir Soffer 
---
M .travis.yml
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/65284/1

diff --git a/.travis.yml b/.travis.yml
index f167e8d..c5d2ec3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,11 +7,14 @@
 git:
   depth: 999
 
+env:
+  matrix:
+- DOCKER_IMAGE=nirs/vdsm-centos
+- DOCKER_IMAGE=nirs/vdsm-fedora
+
 before_install:
   - docker --version
-  - docker pull nirs/vdsm-centos
-  - docker pull nirs/vdsm-fedora
+  - docker pull $DOCKER_IMAGE
 
 script:
-  - docker run --privileged --rm -it -v `pwd`:/vdsm:Z nirs/vdsm-centos bash -c 
"cd /vdsm && ./autogen.sh --system && make && make check"
-  - docker run --privileged --rm -it -v `pwd`:/vdsm:Z nirs/vdsm-fedora bash -c 
"cd /vdsm && ./autogen.sh --system && make && make check"
+  - docker run --privileged --rm -it -v `pwd`:/vdsm:Z $DOCKER_IMAGE bash -c 
"cd /vdsm && ./autogen.sh --system && make && make check"


-- 
To view, visit https://gerrit.ovirt.org/65284
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fe524df5f4baf4f3c24f8da56c30d52ee22f8b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker images

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dockerfile: Minimize docker images
..


Patch Set 2: Verified+1

Verified using docker cloud, both images built succesfully and are much smaller 
now.

-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Add Fedora docker run

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: travis: Add Fedora docker run
..


Patch Set 2: Verified+1

Both centos and fedora are running now:
https://travis-ci.org/nirs/vdsm/builds/166247365

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker images

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: dockerfile: Minimize docker images
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: dockerfile: Add Fedora dockerfile
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: github: Add travis build status image

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: github: Add travis build status image
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib375ce277e7f2777a7c494e940a5a8cabe8a5540
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Add Fedora docker run

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: travis: Add Fedora docker run
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: github: Add travis build status image

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: github: Add travis build status image
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65261/2/README.md
File README.md:

Line 2: 
Line 3: [![Build Status](https://travis-ci.org/nirs/vdsm.svg?branch=master)]
Line 4: (https://travis-ci.org/nirs/vdsm)
Line 5: 
Line 6: The Vdsm service exposes an API for managing virtualization
> gerrit syntax highlighting is confused by this text. Any idea why?
Probably gerrit does not support markdown properly.
Line 7: hosts running the KVM hypervisor technology. Vdsm manages and monitors
Line 8: the host's storage, memory and networks as well as virtual machine
Line 9: creation, other host administration tasks, statistics gathering, and
Line 10: log collection.


-- 
To view, visit https://gerrit.ovirt.org/65261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib375ce277e7f2777a7c494e940a5a8cabe8a5540
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Switch to Fedora docker image

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: travis: Switch to Fedora docker image
..


Patch Set 1:

Yes, we can run both in the same build, but since we run privileged docker and 
test changes in the kernel (e.g. adding and removing devices), the first docker 
run can effect the second run.

The best would be to create a matrix running 2 builds, one with the centos 
image, and one with the fedora image. I could not find how to configure this 
yet.

I'll add the fedora run after the centos run instead of replacing it.

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker image

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dockerfile: Minimize docker image
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65271/1/contrib/Dockerfile.fedora
File contrib/Dockerfile.fedora:

Line 41: which \
Line 42: && \
Line 43:   easy_install pip && \
Line 44:   pip install nose==1.3.7 tox==2.1.1 && \
Line 45:   dnf clean all
> the danger of having two dockerfiles: I guess that the same thing applies t
The centos image is much smaller without this change, but I will apply the same 
change there.


-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

See also https://github.com/oVirt/ovirt-site/pull/516, updating developer 
documentation.

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooks: avoid redundant temporary list

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: avoid redundant temporary list
..


Patch Set 1: Verified+1

function covered by unit tests

-- 
To view, visit https://gerrit.ovirt.org/65273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker image

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: dockerfile: Minimize docker image
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/65271/1/contrib/Dockerfile.fedora
File contrib/Dockerfile.fedora:

Line 41: which \
Line 42: && \
Line 43:   easy_install pip && \
Line 44:   pip install nose==1.3.7 tox==2.1.1 && \
Line 45:   dnf clean all
the danger of having two dockerfiles: I guess that the same thing applies to 
the centos image.


-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dokerfile: Rename Dockerfile to Dockerfile.centos

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: dokerfile: Rename Dockerfile to Dockerfile.centos
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dokerfile: Rename Dockerfile to Dockerfile.centos

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: dokerfile: Rename Dockerfile to Dockerfile.centos
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Switch to Fedora docker image

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: travis: Switch to Fedora docker image
..


Patch Set 1: Code-Review-1

I'd love to cover Python 3, it's an important future-facing effort. But keeping 
an eye open over CentOS is even more important. After all, some %90 of our 
install base use el7.

Can github be asked to run both?

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dokerfile: Rename Dockerfile to Dockerfile.centos

2016-10-09 Thread danken

Dan Kenigsberg has submitted this change and it was merged.

Change subject: dokerfile: Rename Dockerfile to Dockerfile.centos
..


dokerfile: Rename Dockerfile to Dockerfile.centos

We need another dockerfile for Fedora.

Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65269
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
R contrib/Dockerfile.centos
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/65269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: github: Add travis build status image

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: github: Add travis build status image
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65261/2/README.md
File README.md:

Line 2: 
Line 3: [![Build Status](https://travis-ci.org/nirs/vdsm.svg?branch=master)]
Line 4: (https://travis-ci.org/nirs/vdsm)
Line 5: 
Line 6: The Vdsm service exposes an API for managing virtualization
gerrit syntax highlighting is confused by this text. Any idea why?
Line 7: hosts running the KVM hypervisor technology. Vdsm manages and monitors
Line 8: the host's storage, memory and networks as well as virtual machine
Line 9: creation, other host administration tasks, statistics gathering, and
Line 10: log collection.


-- 
To view, visit https://gerrit.ovirt.org/65261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib375ce277e7f2777a7c494e940a5a8cabe8a5540
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Convert to markdown format

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: readme: Convert to markdown format
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Convert to markdown format

2016-10-09 Thread danken

Dan Kenigsberg has submitted this change and it was merged.

Change subject: readme: Convert to markdown format
..


readme: Convert to markdown format

Markdown is nicer to work with and render nicer in github.

Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65260
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M Makefile.am
R README.md
M vdsm.spec.in
3 files changed, 26 insertions(+), 25 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Convert to markdown format

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: readme: Convert to markdown format
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Convert to markdown format

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: readme: Convert to markdown format
..


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/65260/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-10-09 00:49:47 +0300
Line 4: Commit: Dan Kenigsberg 
Line 5: CommitDate: 2016-10-09 13:42:46 -0400
Line 6: 
Line 7: readme: Convert to markdown format
we're open source. no covert operations allowed.
Line 8: 
Line 9: Markdown is nicer to work with and render nicer in github.
Line 10: 
Line 11: Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1


-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

This version leaves python3-nose as is.

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: build: Disable tests during build
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: fix abort to raise

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: fix abort to raise
..


Patch Set 1: Code-Review-1

See comments.

-- 
To view, visit https://gerrit.ovirt.org/65147
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5efe2319d023bd813777c76a0bbaa0b9576281f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: api: Speed up schema loading
..


Patch Set 1:

* #1208141::Update tracker: OK
* #1381899::Update tracker: OK
* #65230::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1381899::OK, public bug
* Check Product::#1208141::IGNORE, not relevant for classification: Red Hat
* Check Product::#1381899::OK, product: vdsm
* Check Product::#65230::IGNORE, not relevant for classification: Retired
* Check TM::#1381899::ERROR, wrong target milestone for stable branch, 
ovirt-4.1.0-alpha should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/65274
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: api: Speed up schema loading
..


Patch Set 1: Verified+1

Verified on master and by users:
- http://lists.ovirt.org/pipermail/users/2016-October/043349.html
- http://lists.ovirt.org/pipermail/users/2016-October/043354.html

-- 
To view, visit https://gerrit.ovirt.org/65274
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-09 Thread nsoffer

Hello Piotr Kliczewski,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65274

to review the following change.

Change subject: api: Speed up schema loading
..

api: Speed up schema loading

Use yaml.CLoader for 13x speedup in vdsm schema loading.

Here is a comparison with other formats:

$ python bench.py

  yaml: 1.053720 seconds per load
 cyaml: 0.086472 seconds per load
  json: 0.049521 seconds per load
pickle: 0.001516 seconds per load

$ python3 bench.py

  yaml: 1.340607 seconds per load
 cyaml: 0.100010 seconds per load
  json: 0.026627 seconds per load
pickle: 0.002153 seconds per load

$ grep 'model name' /proc/cpuinfo | head -n1
model name  : Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Clearly the best format is pickle, 700X times faster on python 2 and
638X times faster on python 3. However loading the schema in 100
milliseconds seems to be good enough for now.

The benchmark script:
https://bugzilla.redhat.com/attachment.cgi?id=1208141

Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Bug-Url: https://bugzilla.redhat.com/1381899
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65230
Reviewed-by: Simone Tiraboschi 
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Tested-by: Simone Tiraboschi 
---
M lib/api/vdsmapi.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/65274/1

diff --git a/lib/api/vdsmapi.py b/lib/api/vdsmapi.py
index b340f73..635aedf 100755
--- a/lib/api/vdsmapi.py
+++ b/lib/api/vdsmapi.py
@@ -92,7 +92,7 @@
 try:
 for path in paths:
 with open(path) as f:
-loaded_schema = yaml.load(f)
+loaded_schema = yaml.load(f, Loader=yaml.CLoader)
 
 types = loaded_schema.pop('types')
 self._types.update(types)


-- 
To view, visit https://gerrit.ovirt.org/65274
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add wrapper to execute command
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add wrapper to execute command
..


Patch Set 7: Code-Review+2

Lets move faster, If Adam has issues with this we will enhance this later.

-- 
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-09 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Introduce InvalidOutput exception
..


qemuimg: Introduce InvalidOutput exception

Raised when qemu-img command succeeded, but its output cannot be parsed
or missing required properties.  In this case we know that rc is 0, and
stderr is probably empty, so including it in the error is not very
useful.

Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/65208
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/vdsm/qemuimg.py
1 file changed, 23 insertions(+), 7 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-09 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Add wrapper to execute command
..


qemuimg: Add wrapper to execute command

Add wrapper to execute qemuimg command and raise QImgError if error
encountered.

Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/65178
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/vdsm/qemuimg.py
1 file changed, 11 insertions(+), 16 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3483a202f9543098ad75e8be8bf4b398d26c8e4a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add the command to QImgError
..


Patch Set 6:

Lets move faster, If Adam has issues with this we will enhance this later.

-- 
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Introduce InvalidOutput exception
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Add the command to QImgError
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Introduce InvalidOutput exception
..


Patch Set 6:

Lets move faster, If Adam has issues with this we will enhance this later.

-- 
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-09 Thread nsoffer

Nir Soffer has submitted this change and it was merged.

Change subject: qemuimg: Add the command to QImgError
..


qemuimg: Add the command to QImgError

Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/65179
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M lib/vdsm/qemuimg.py
1 file changed, 25 insertions(+), 18 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Introduce InvalidOutput exception
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f801f05f130c2417e4946877e31030260269a1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Add the command to QImgError
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Expose API for qemuimg map

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: core: Expose API for qemuimg map
..


Patch Set 2:

(8 comments)

Nice!

https://gerrit.ovirt.org/#/c/65112/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 219: 
Line 220: try:
Line 221: return json.loads(out)
Line 222: except ValueError:
Line 223: raise QImgError(rc, out, err, "Failed to process qemuimg map 
output")
Please base this on https://gerrit.ovirt.org/65178 so we can use the new shiny 
infrastrcutrue you added there.
Line 224: 
Line 225: 
Line 226: class QemuImgOperation(object):
Line 227: REGEXPR = re.compile(r'\s*\(([\d.]+)/100%\)\s*')


https://gerrit.ovirt.org/#/c/65112/2/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 459: # Empty run
Line 460: run = img_map[0]
Line 461: self.assertEqual(run["length"], size)
Line 462: self.assertFalse(run["data"])
Line 463: self.assertTrue(run["zero"])
Lets use assertEqual to match the next tests. Using assertTrue and assertFalse 
is usually prefered, but in this case we llke to see list of expected keys and 
values.
Line 464: 
Line 465: @permutations([
Line 466: # offset, length, expected_offset, expected_length, 
qcow2_compat
Line 467: (64 * 1024, 4 * 1024, 65536, 65536, "0.10"),


Line 466: # offset, length, expected_offset, expected_length, 
qcow2_compat
Line 467: (64 * 1024, 4 * 1024, 65536, 65536, "0.10"),
Line 468: (64 * 1024, 4 * 1024, 65536, 65536, "1.1"),
Line 469: (64 * 1024, 72 * 1024, 65536, 131072, "0.10"),
Line 470: (64 * 1024, 72 * 1024, 65536, 131072, "1.1"),
offset and expected_offset are always the same - are you sure we need both?
Line 471: ])
Line 472: def test_one_block_qcow2(self, offset, length, expected_offset,
Line 473:  expected_length, qcow2_compat):
Line 474: with namedTemporaryDir() as tmpdir:


Line 498: run = img_map[2]
Line 499: self.assertEqual(run["length"],
Line 500:  size-expected_offset-expected_length)
Line 501: self.assertEqual(run["data"], False)
Line 502: self.assertEqual(run["zero"], True)
Lets apply the same comments from the raw version to this test.
Line 503: 
Line 504: @permutations([
Line 505: # offset, qcow2_compat
Line 506: (4 * 1024, "0.10"),


Line 507: (4 * 1024, "1.1"),
Line 508: (64 * 1024, "0.10"),
Line 509: (64 * 1024, "1.1"),
Line 510: ])
Line 511: def test_one_block_raw(self, length, qcow2_compat):
Put the raw test before the qcow2 tests since it is the simpler case.
Line 512: with namedTemporaryDir() as tmpdir:
Line 513: image = os.path.join(tmpdir, "base.img")
Line 514: fmt = qemuimg.FORMAT.RAW
Line 515: size = 1048576


Line 513: image = os.path.join(tmpdir, "base.img")
Line 514: fmt = qemuimg.FORMAT.RAW
Line 515: size = 1048576
Line 516: qemuimg.create(image, size=size, format=fmt)
Line 517: offset = 64 * 1024
Lets put the size and the offset at the top of the tests, since they are used 
for the entire test. Easier to understand when we define them first.

Creating a variable just before you need it is good when you don't have to 
access it later.
Line 518: qemu_pattern_write(image, fmt, offset=offset, len=length,
Line 519:pattern=0xf0)
Line 520: 
Line 521: img_map = qemuimg.map(image)


Line 534: self.assertEqual(run["zero"], False)
Line 535: 
Line 536: # Empty run
Line 537: run = img_map[2]
Line 538: self.assertEqual(run["length"], size-offset-length)
Use space between binary operators:

size - offset - length
Line 539: self.assertEqual(run["data"], False)
Line 540: self.assertEqual(run["zero"], True)
Line 541: 
Line 542: 


Line 536: # Empty run
Line 537: run = img_map[2]
Line 538: self.assertEqual(run["length"], size-offset-length)
Line 539: self.assertEqual(run["data"], False)
Line 540: self.assertEqual(run["zero"], True)
I wonder if we can simplify the tests like this:

expected = [
# run 1 - empty
{
"data": True,
"zero": False,
"length": offset,
"start": ...
"offset": ...
},
# run 2 - data
{
"data": True,
"zero": False,
"length": length,
"start": ...
"offset": ...
},
# run 3 - empty
{
"data": True,
"zero": False,
"length": size - offset - length,
"start": ...
"offset": ...
},
]

And

Change in vdsm[master]: hooks: avoid redundant temporary list

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: hooks: avoid redundant temporary list
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: hooks: avoid redundant temporary list

2016-10-09 Thread danken

Dan Kenigsberg has uploaded a new change for review.

Change subject: hooks: avoid redundant temporary list
..

hooks: avoid redundant temporary list

No functional change is expected.

Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/hooks.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/65273/1

diff --git a/lib/vdsm/hooks.py b/lib/vdsm/hooks.py
index 96969fd..777b4ee 100644
--- a/lib/vdsm/hooks.py
+++ b/lib/vdsm/hooks.py
@@ -453,8 +453,8 @@
 
 
 def _getHookInfo(dir):
-return dict([(os.path.basename(script), _getScriptInfo(script))
- for script in _scriptsPerDir(dir)])
+return dict((os.path.basename(script), _getScriptInfo(script))
+for script in _scriptsPerDir(dir))
 
 
 def installed():


-- 
To view, visit https://gerrit.ovirt.org/65273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Switch to Fedora docker image

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: travis: Switch to Fedora docker image
..


Patch Set 1: Verified+1

Verified using travis.

- All python 2 tests pass
- 795 python 3 tests pass
- 2 python 3 tests error - I believe the tests are bad, running them on a 
container revel the issue

See https://travis-ci.org/nirs/vdsm/builds/166142758

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: github: Add travis build status image

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: github: Add travis build status image
..


Patch Set 2:

See https://github.com/nirs/vdsm/blob/github/README.md

-- 
To view, visit https://gerrit.ovirt.org/65261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib375ce277e7f2777a7c494e940a5a8cabe8a5540
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Covert to markdown format

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: readme: Covert to markdown format
..


Patch Set 2:

See https://github.com/nirs/vdsm/blob/github/README.md

-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Covert to markdown format

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: readme: Covert to markdown format
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65260/1/README.md
File README.md:

Line 21: In order to start vdsm at first try, please perform:
Line 22: 
Line 23: vdsm-tool configure [--force]
Line 24: 
Line 25: --force flag will override old conf files with vdsm defaults and 
restart
> `--force` maybe?
Updated in currnet version.
Line 26: services that were configured (if were already running)
Line 27: 
Line 28: 
Line 29: ## Packaging


-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Covert to markdown format

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: readme: Covert to markdown format
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dockerfile: Add Fedora dockerfile
..


Patch Set 1:

Verified using travis:
https://travis-ci.org/nirs/vdsm/builds/166142758

-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker image

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dockerfile: Minimize docker image
..


Patch Set 1: Verified+1

Verified using travis:
https://travis-ci.org/nirs/vdsm/builds/166142758

-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dockerfile: Add Fedora dockerfile
..


Patch Set 1:

See https://cloud.docker.com/app/nirs/repository/docker/nirs/vdsm-fedora/general

-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dockerfile: Add Fedora dockerfile
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dokerfile: Rename Dockerfile to Dockerfile.centos

2016-10-09 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: dokerfile: Rename Dockerfile to Dockerfile.centos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dokerfile: Rename Dockerfile to Dockerfile.centos

2016-10-09 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: dokerfile: Rename Dockerfile to Dockerfile.centos
..

dokerfile: Rename Dockerfile to Dockerfile.centos

We need another dockerfile for Fedora.

Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Signed-off-by: Nir Soffer 
---
R contrib/Dockerfile.centos
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/65269/1

diff --git a/contrib/Dockerfile b/contrib/Dockerfile.centos
similarity index 100%
rename from contrib/Dockerfile
rename to contrib/Dockerfile.centos


-- 
To view, visit https://gerrit.ovirt.org/65269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: dockerfile: Add Fedora dockerfile
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dokerfile: Rename Dockerfile to Dockerfile.centos

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: dokerfile: Rename Dockerfile to Dockerfile.centos
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8245d5a5f7eabe01b8f33ab1e4210d3edf3777
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Add Fedora dockerfile

2016-10-09 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: dockerfile: Add Fedora dockerfile
..

dockerfile: Add Fedora dockerfile

The Fedora image should run the the python 3 tests that cannot run on
CentOS because of missing packages.

We probably want to have a matrix with two builds, one using CentOS
image running only python 2 tests, and one using Fedora image running
all tests.

Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Signed-off-by: Nir Soffer 
---
A contrib/Dockerfile.fedora
1 file changed, 44 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/65270/1

diff --git a/contrib/Dockerfile.fedora b/contrib/Dockerfile.fedora
new file mode 100644
index 000..5eaa12d
--- /dev/null
+++ b/contrib/Dockerfile.fedora
@@ -0,0 +1,44 @@
+FROM fedora:24
+RUN dnf install -y 
http://resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm && \
+  dnf update -y && \
+  dnf install -y \
+PyYAML \
+autoconf \
+automake \
+bridge-utils \
+dosfstools \
+e2fsprogs \
+genisoimage \
+git \
+libselinux-python \
+libselinux-python3 \
+libvirt-python \
+libvirt-python3 \
+make \
+mom \
+openvswitch \
+psmisc \
+python-cpopen \
+python-decorator \
+python-devel \
+python-inotify \
+python-ioprocess \
+python-netaddr \
+python-pthreading \
+python-setuptools \
+python-six \
+python2-mock \
+python3 \
+python3-decorator \
+python3-netaddr \
+python3-nose \
+python3-six \
+python3-yaml \
+sanlock-python \
+sudo \
+systemd \
+systemd-udev \
+which \
+&& \
+  easy_install pip && \
+  pip install nose==1.3.7 tox==2.1.1


-- 
To view, visit https://gerrit.ovirt.org/65270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie14526fdda539a53785ec3c91fae23996f7b3bcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker image

2016-10-09 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: dockerfile: Minimize docker image
..

dockerfile: Minimize docker image

Cleaning dnf caches remove 145MiB of useless data slowing down pushing
and pulling the image:

# du -sh /var/cache/*
145M/var/cache/dnf
20K /var/cache/ldconfig
0   /var/cache/libvirt

# dnf clean all
72 files removed

# du -sh /var/cache/*
12K /var/cache/dnf
20K /var/cache/ldconfig
0   /var/cache/libvirt

Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Signed-off-by: Nir Soffer 
---
M contrib/Dockerfile.fedora
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/65271/1

diff --git a/contrib/Dockerfile.fedora b/contrib/Dockerfile.fedora
index 5eaa12d..6495167 100644
--- a/contrib/Dockerfile.fedora
+++ b/contrib/Dockerfile.fedora
@@ -41,4 +41,5 @@
 which \
 && \
   easy_install pip && \
-  pip install nose==1.3.7 tox==2.1.1
+  pip install nose==1.3.7 tox==2.1.1 && \
+  dnf clean all


-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dockerfile: Minimize docker image

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: dockerfile: Minimize docker image
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e3d606b20a086ef0d2da443a35182d64c3b880c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Switch to Fedora docker image

2016-10-09 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: travis: Switch to Fedora docker image
..

travis: Switch to Fedora docker image

The previous CentOS image cannot run the python 3 tests because some
packages are missing; use Fedora image instead.

We should check later how to configure multiple builds with both CentOS
and Fedora images.

Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Signed-off-by: Nir Soffer 
---
M .travis.yml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/65268/1

diff --git a/.travis.yml b/.travis.yml
index 96dd9c3..666b020 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -9,7 +9,7 @@
 
 before_install:
   - docker --version
-  - docker pull nirs/vdsm-centos
+  - docker pull nirs/vdsm-fedora
 
 script:
-  - docker run --privileged --rm -it -v `pwd`:/vdsm:Z nirs/vdsm-centos bash -c 
"cd /vdsm && ./autogen.sh --system && make; make check"
+  - docker run --privileged --rm -it -v `pwd`:/vdsm:Z nirs/vdsm-fedora bash -c 
"cd /vdsm && ./autogen.sh --system && make && make check"


-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: travis: Switch to Fedora docker image

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: travis: Switch to Fedora docker image
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d05f380faf9ef4b16685b1853a114adb54836
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: github: Add travis build status image

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: github: Add travis build status image
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib375ce277e7f2777a7c494e940a5a8cabe8a5540
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: readme: Covert to markdown format

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: readme: Covert to markdown format
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74ce4bcb8bb276e98fc6466ace7709733dd809c1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: procwatch: Move CommandStream to new module

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: procwatch: Move CommandStream to new module
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65072
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I045569d350aad19049a8a72b59e68ba91e5b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: procwatch: Rename CommandStream to ProcessWatcher

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: procwatch: Rename CommandStream to ProcessWatcher
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13981d80786bda2f185851febfd40754a38282a8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: procwatch: There is no need for _private helpers

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: procwatch: There is no need for _private helpers
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65074
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54c7acf9c599716527ae3b4919fc19bdbe7de5c1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: core: Expose API for qemuimg map

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: core: Expose API for qemuimg map
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54d6c936239d3dcc7a3d236dbaab0a93501ada8c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: separate ifcfg and libvirt unit tests
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/65090/5/tests/network/libvirt_test.py
File tests/network/libvirt_test.py:

Line 38: 
Line 39: aXml = ET.tostring(ET.fromstring(a))
Line 40: bXml = ET.tostring(ET.fromstring(b))
Line 41: 
Line 42: aXmlNrml = re.sub('>\s*\n\s*<', '><', aXml).strip()
> this module would pass under py3 if you mark these strings as bytearrays (n
just rebase my merged https://gerrit.ovirt.org/64928
Line 43: bXmlNrml = re.sub('>\s*\n\s*<', '><', bXml).strip()
Line 44: 
Line 45: self.assertEqual(aXmlNrml, bXmlNrml, msg)
Line 46: 


-- 
To view, visit https://gerrit.ovirt.org/65090
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieca34a3f361586346d76ec22b11554c4a7c6e84d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make network/conf_test pass

2016-10-09 Thread automation

gerrit-hooks has posted comments on this change.

Change subject: py3: make network/conf_test pass
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcab2d6f1f88b04d849156915a89c4cc8589
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make network/conf_test pass

2016-10-09 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: py3: make network/conf_test pass
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcab2d6f1f88b04d849156915a89c4cc8589
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make network/conf_test pass

2016-10-09 Thread danken

Dan Kenigsberg has submitted this change and it was merged.

Change subject: py3: make network/conf_test pass
..


py3: make network/conf_test pass

re.sub should not mix strings and byte arrays.

Change-Id: Idcab2d6f1f88b04d849156915a89c4cc8589
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/64928
Continuous-Integration: Jenkins CI
Reviewed-by: Leon Goldberg 
---
M tests/Makefile.am
M tests/network/conf_test.py
2 files changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Leon Goldberg: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcab2d6f1f88b04d849156915a89c4cc8589
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net libvirt: make network/libvirt.py suitable for OVS

2016-10-09 Thread edwardh

Edward Haas has posted comments on this change.

Change subject: net libvirt: make network/libvirt.py suitable for OVS
..


Patch Set 8: Code-Review-1

(8 comments)

https://gerrit.ovirt.org/#/c/65065/8/lib/vdsm/network/libvirt.py
File lib/vdsm/network/libvirt.py:

PS8, Line 45: bridge
There is a hidden assumption now for the caller: If bridge is not None, then 
network == bridge.
I guess with the suggestion from line 62, this can be treated.


Line 58: determines respectively the presence of bridge element
Line 59: or interface subelement.
Line 60: """
Line 61: 
Line 62: if bridge and iface:
It will be cleaner to just have two funcs then, one for bridged and one for 
iface, extracting the common code to their own funcs.
Line 63: raise AttributeError('Cannot set both bridge and iface at 
once')
Line 64: 
Line 65: netName = LIBVIRT_NET_PREFIX + network
Line 66: 


https://gerrit.ovirt.org/#/c/65065/8/tests/network/libvirt_test.py
File tests/network/libvirt_test.py:

PS8, Line 41: Unit
How about 'CreateXml' ?


PS8, Line 101: Integration
How about 'CreateNetwork'?


Line 100: @attr(type='integration')
Line 101: class LibvirtIntegrationTests(TestCaseBase):
Line 102: 
Line 103: @ValidateRunningAsRoot
Line 104: def _test_create_net(self, **net_attrs):
Private funcs/methods at the bottom please.
Line 105: net_def = libvirt.createNetworkDef(NETWORK, **net_attrs)
Line 106: with libvirt_net(NETWORK, net_def):
Line 107: nets = libvirt.networks()
Line 108: self.assertIn(NETWORK, nets)


Line 106: with libvirt_net(NETWORK, net_def):
Line 107: nets = libvirt.networks()
Line 108: self.assertIn(NETWORK, nets)
Line 109: self.assertEqual(nets[NETWORK], net_attrs)
Line 110: nets = libvirt.networks()
Why do you need to check it is cleaned all the time?
I think a single test that checks that the removal is successful is enough, all 
others can assume it is fine.
Line 111: self.assertNotIn(NETWORK, nets)
Line 112: 
Line 113: def test_create_net_with_bridge(self):
Line 114: self._test_create_net(


Line 131: 
Line 132: @contextmanager
Line 133: def libvirt_net(net, net_def):
Line 134: try:
Line 135: libvirt.createNetwork(net_def)
If it failed during creation, what is there to remove?
Or can it fail and leave leftovers?
Line 136: yield
Line 137: finally:


https://gerrit.ovirt.org/#/c/65065/8/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Even with https://gerrit.ovirt.org/#/c/65098 , the displayNetwork will be 
broken now.
1. We cannot use IP address anymore for binding, as the addresses are different 
from host to host.
2. As far as I remember, the libvirt translation between network/bridge name to 
an IP address is not working with OVS bridges (please correct me by checking 
this), so the display network cannot be resolved when using OVS libvirt network.
It was one of the reasons we convinced ourself that dropping libvirt db is a 
good step.
Line 1: #
Line 2: # Copyright 2008-2014 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


-- 
To view, visit https://gerrit.ovirt.org/65065
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6de49e456d8c49f0309690a7fc2bee995f9846bb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Remove vol_extend_policy option
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65053
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib067c09a985a633a452c476e21d8c2c073e6ca50
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Streamline acquiring of multiple images locks
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20bcebeb11f3ccbe10b029a424f4c27a890eea8c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Do not use rm.acquireResource return value
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff5653f0b15861d2034011f7fccc76bf25788f6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Streamline building domains list for upgrade
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2be0a4816d733fdae13bcb933201b1ede795ca68
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Remove useless continuation to a commented line
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65044
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8a0f989fbd55280163c54481f1748bcfff7b6a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Simplify long lines using continuation \
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51fc21b452f2f1d920ad1353d2b14067d432a837
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Fix domain.produceVolume calling convention
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65046
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id804b4754507f1c6bf4e85f006f6db6fdda2e330
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Streamline calls to volume methods
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbdfbd5cf6a4a7345c350359e76c2156720c683
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Fix positional args calling convention
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65048
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d73df3daa59efb512bfdc9f6e400bacb3c08c49
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Streamline usage of image.Image class
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9de180542cd81a6d563d52b4b30b9520046469
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: pep8 1.6.2 fix

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: pep8 1.6.2 fix
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e561da219c31aa26d32dcb615eacf223050f5c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sp: Remove double dict key

2016-10-09 Thread frolland

Freddy Rolland has posted comments on this change.

Change subject: sp: Remove double dict key
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05f6aeda1858e85b8660d972593e82bcb7e3bff3
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

1 2 >

1 - 100 of 110 matches

Mail list logo