Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::OK * Check Public Bug::#1373832::OK, public bug * Check Product::IGNORE, no bug url/s found * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: Fix return value names for VM.ioTune calls
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::OK * Check Public Bug::#1373832::OK, public bug * Check Product::IGNORE, no bug url/s found * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: Add all MOM calls to jsonrpc client
Hello Piotr Kliczewski, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65378
to review the following change.
Change subject: Add all MOM calls to jsonrpc client
..
Add all MOM calls to jsonrpc client
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Signed-off-by: Andrej Krejcir
Reviewed-on: https://gerrit.ovirt.org/60492
Reviewed-by: Francesco Romani
Tested-by: Andrej Krejcir
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski
Reviewed-on: https://gerrit.ovirt.org/63479
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
2 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/65378/1
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index caffb9a..1854869 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -60,6 +60,8 @@
'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
'getDeviceList': 'Host.getDeviceList',
'getImagesList': 'StorageDomain.getImages',
+'getIoTunePolicy': 'VM.getIoTunePolicy',
+'getIoTune': 'VM.getIoTune',
'getSpmStatus': 'StoragePool.getSpmStatus',
'getStorageDomainInfo': 'StorageDomain.getInfo',
'getStorageDomainsList': 'Host.getStorageDomains',
@@ -93,10 +95,12 @@
'setBalloonTarget': 'VM.setBalloonTarget',
'setCpuTunePeriod': 'VM.setCpuTunePeriod',
'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+'setKsmTune': 'Host.setKsmTune',
'setMOMPolicy': 'Host.setMOMPolicy',
'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
'setupNetworks': 'Host.setupNetworks',
'setVmTicket': 'VM.setTicket',
+'setIoTune': 'VM.setIoTune',
'setVolumeDescription': 'Volume.setDescription',
'shutdown': 'VM.shutdown',
'spmStart': 'StoragePool.spmStart',
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 273bd2e..192de42 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -349,7 +349,7 @@
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
'Host_setupNetworks': {'ret': 'status'},
-'Host_setKsmTune': {'ret': 'taskStatus'},
+'Host_setKsmTune': {'ret': 'status'},
'Image_cloneStructure': {'ret': 'uuid'},
'Image_delete': {'ret': 'uuid'},
'Image_deleteVolumes': {'ret': 'uuid'},
@@ -402,11 +402,12 @@
'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
'VM_getMigrationStatus': {'ret': 'migrationStats'},
'VM_pause': {'ret': VM_running_state_change_Ret},
-'VM_setCpuTunePeriod': {'ret': 'taskStatus'},
-'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
+'VM_setCpuTunePeriod': {'ret': 'status'},
+'VM_setCpuTuneQuota': {'ret': 'status'},
'VM_hotplugMemory': {'ret': 'vmList'},
'VM_setNumberOfCpus': {'ret': 'vmList'},
-'VM_setIoTune': {'ret': 'taskStatus'},
+'VM_setIoTune': {'ret': 'status'},
+'VM_setBalloonTarget': {'ret': 'status'},
'VM_updateDevice': {'ret': 'vmList'},
'Volume_copy': {'ret': 'uuid'},
'Volume_create': {'ret': 'uuid'},
--
To view, visit https://gerrit.ovirt.org/65378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Andrej Krejcir
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::bug 1373832#1373832IGNORE, not all related patches are closed, check 63479 -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 3: please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 - otherwise will be in 4.0.6 and onwards. -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client
Francesco Romani has submitted this change and it was merged. Change subject: Add all MOM calls to jsonrpc client .. Add all MOM calls to jsonrpc client Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Signed-off-by: Andrej Krejcir Reviewed-on: https://gerrit.ovirt.org/60492 Reviewed-by: Francesco Romani Tested-by: Andrej Krejcir Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski Reviewed-on: https://gerrit.ovirt.org/63479 --- M lib/vdsm/jsonrpcvdscli.py M lib/vdsm/rpc/Bridge.py 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 3: please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 - otherwise will be in 4.0.6 and onwards. -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::bug 1373832#1373832::SKIPPED, The branch 'ovirt-4.0.5' for the current target milestone 'ovirt-4.0.5' exists. -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls
Francesco Romani has submitted this change and it was merged. Change subject: Fix return value names for VM.ioTune calls .. Fix return value names for VM.ioTune calls Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Signed-off-by: Andrej Krejcir Reviewed-on: https://gerrit.ovirt.org/60513 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/63478 Reviewed-by: Piotr Kliczewski --- M tests/vmTests.py M vdsm/virt/vm.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client
Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls
Francesco Romani has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make gluster_cli_tests pass
Ramesh N has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
Piotr Kliczewski has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Piotr Kliczewski has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Fix abort race in SDM.copy_data
gerrit-hooks has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c7d9aadb981e8b851a70c7ad0fdc0d75b46dc51 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jobs: Fix abort semantics
gerrit-hooks has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Explicit run semantics for QemuImgOperation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Explicit run semantics for QemuImgOperation .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e427c909a8dffc3ba2a5c838c7d1e7ce7cce55d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jobs: Fix abort semantics
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: (6 comments) https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 146 Line 147 Line 148 Line 149 Line 150 > We can log here that we are starting the job. Done Line 132: if self.status == STATUS.PENDING: Line 133: # Autodelete should only be handled here for pending state. Line 134: # There is no operation running so we can go straight to Line 135: # aborted state. In all other cases, autodelete is handled as Line 136: # the _run method finishes. > +1 (for consistency purposes from my POV) Done Line 137: self._status = STATUS.ABORTED Line 138: if self.autodelete: Line 139: self._autodelete() Line 140: elif self.status == STATUS.RUNNING: Line 148: raise JobNotActive() Line 149: Line 150: def run(self): Line 151: if not self._may_run(): Line 152: return > We need log info for starting the job - maybe inside _may_run? Done Line 153: try: Line 154: self._run() Line 155: except exception.ActionStopped: Line 156: self._abort_completed() Line 155: except exception.ActionStopped: Line 156: self._abort_completed() Line 157: except Exception as e: Line 158: self._run_failed(e) Line 159: else: > For extra consistency, we can introduce _run_completed() for these lines. Done Line 160: with self._status_lock: Line 161: self._status = STATUS.DONE Line 162: finally: Line 163: if self.autodelete: Line 157: except Exception as e: Line 158: self._run_failed(e) Line 159: else: Line 160: with self._status_lock: Line 161: self._status = STATUS.DONE > What we miss in the successful case ia log info about job completing. Done Line 162: finally: Line 163: if self.autodelete: Line 164: self._autodelete() Line 165: PS4, Line 177: _abort_completed > perhaps _run_aborted(self) could be a bit clearer? I prefer the current name but I'll add some docstrings to these methods to make their scope and function more clear. -- To view, visit https://gerrit.ovirt.org/65102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: support for block devices
Francesco Romani has posted comments on this change. Change subject: v2v: support for block devices .. Patch Set 4: Code-Review-1 Ooops, good catch Tomas. -- To view, visit https://gerrit.ovirt.org/64272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f7a85715764efded7b296e858b130a05fe10f2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2v: support for block devices
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Code-Review-1
(1 comment)
As pointed out by a user on ML the change breaks engine. VDSM fails to fetch
disk size and logs an exception. Although the the disk size field is marked as
optional in the scheme engine does not consider the size opotional aparently.
Maybe we should provide an alternative logic of fetching disk size for block
devices. Adding -1 for the moment.
https://gerrit.ovirt.org/#/c/64272/2/tests/v2vTests.py
File tests/v2vTests.py:
PS2, Line 130: {dis
> yes,
Are you sure? Based on what I see in docs it's more like file attribute is for
file and dev attribute is for block.
--
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7a85715764efded7b296e858b130a05fe10f2a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Tomas Golembiovsky
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: canonicalize IPv4 prefix to netmask
Petr Horáček has posted comments on this change. Change subject: net: canonicalize IPv4 prefix to netmask .. Patch Set 3: Verified+1 (1 comment) Passed network/*_test.py and functional/networkTests.py OK. I added task to implement unit tests for canonicalization. https://gerrit.ovirt.org/#/c/64507/2//COMMIT_MSG Commit Message: Line 11: canonicalize.py. Line 12: Line 13: It also adds missing 'prefix' to setupNetworks documentation. Line 14: Line 15: Change-Id: I344eef120b4c19f90d4dd20c7857bb73ab259e9b > Missing some lines to indicate it is a backport. Done Line 16: Bug-Url: https://bugzilla.redhat.com/1374194 Line 17: Signed-off-by: Petr Horáček Line 18: Reviewed-on: https://gerrit.ovirt.org/64494 Line 19: Continuous-Integration: Jenkins CI -- To view, visit https://gerrit.ovirt.org/64507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344eef120b4c19f90d4dd20c7857bb73ab259e9b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options
gerrit-hooks has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 2: * #1380822::Update tracker: OK * Set MODIFIED::bug 1380822#1380822OK -- To view, visit https://gerrit.ovirt.org/65307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options
Francesco Romani has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Don't crash in migration progress on compression bytes
gerrit-hooks has posted comments on this change. Change subject: virt: Don't crash in migration progress on compression bytes .. Patch Set 2: * #1380822::Update tracker: OK * Set MODIFIED::bug 1380822#1380822IGNORE, not all related patches are closed, check 65307 -- To view, visit https://gerrit.ovirt.org/65306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Don't crash in migration progress on compression bytes
Francesco Romani has submitted this change and it was merged. Change subject: virt: Don't crash in migration progress on compression bytes .. virt: Don't crash in migration progress on compression bytes If compression is not enabled for a migration then compression stats are not provided by libvirt. So when we try to retrieve them in migration Progress, we must not expect their presence, otherwise we crash there. Backport-To: 4.0 Bug-Url: https://bugzilla.redhat.com/1380822 Change-Id: I1885940843d705ead161c13258f1979025a03873 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/64468 Reviewed-by: Michal Skrivanek Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/64499 Reviewed-on: https://gerrit.ovirt.org/65306 Tested-by: Francesco Romani Continuous-Integration: Francesco Romani --- M vdsm/virt/migration.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Francesco Romani: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: spec: Require selinux-policy-targeted for CephFS
gerrit-hooks has posted comments on this change. Change subject: spec: Require selinux-policy-targeted for CephFS .. Patch Set 2: * #1365640::Update tracker: OK * #1303550::Update tracker: OK * Set MODIFIED::bug 1303550#1303550OK, already on MODIFIED -- To view, visit https://gerrit.ovirt.org/65305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88fed5ee17a7f7f12cb4c442671c5d28dc83626e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options
Francesco Romani has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Continuous-Integration+1 run 'make check' locally and independently -- To view, visit https://gerrit.ovirt.org/65307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options
Francesco Romani has submitted this change and it was merged. Change subject: virt: Make boolean values from boolean migration options .. virt: Make boolean values from boolean migration options `compressed' and `autoConverge' migration options have boolean values in the string form. They must be converted to actual booleans before they are checked. Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Bug-Url: https://bugzilla.redhat.com/1380822 Backport-To: 4.0 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/65007 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/65108 Reviewed-on: https://gerrit.ovirt.org/65307 Continuous-Integration: Francesco Romani --- M vdsm/virt/migration.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Francesco Romani: Looks good to me, approved; Passed CI tests Milan Zamazal: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: net: Consume ifcfg files that have a non vdsm standard name
Francesco Romani has submitted this change and it was merged. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. net: Consume ifcfg files that have a non vdsm standard name VDSM assumes that the ifcfg files which represent network devices are named in the following format: ifcfg- If the host is set initially by Network Manager, the names of the files do no correspond to the expected format. This patch adjusts the ifcfg file name to the mentioned format and erases any other ifcfg files that correspond to the same device. This is not a NM friendly patch, it assumes that NM is not active while setupNetworks is issued. Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Bug-Url: https://bugzilla.redhat.com/1367378 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/64096 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/65304 Reviewed-by: Francesco Romani Tested-by: Francesco Romani Continuous-Integration: Francesco Romani --- M lib/vdsm/network/configurators/ifcfg.py M tests/network/func_net_basic_test.py 2 files changed, 70 insertions(+), 0 deletions(-) Approvals: Francesco Romani: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: spec: Require selinux-policy-targeted for CephFS
Francesco Romani has submitted this change and it was merged. Change subject: spec: Require selinux-policy-targeted for CephFS .. spec: Require selinux-policy-targeted for CephFS RHEL bug https://bugzilla.redhat.com/1365640 describes an selinux denial encountered when attempting to use CephFS as a POSIX storage domain in oVirt. This patch requires selinux-policy-3.13.1-60 which solves that issue. Change-Id: I88fed5ee17a7f7f12cb4c442671c5d28dc83626e Bug-Url: https://bugzilla.redhat.com/1303550 Signed-off-by: Allon Mureinik Reviewed-on: https://gerrit.ovirt.org/64505 Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland Reviewed-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/65054 Reviewed-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/65305 Tested-by: Francesco Romani Continuous-Integration: Francesco Romani --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Francesco Romani: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88fed5ee17a7f7f12cb4c442671c5d28dc83626e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: net: Consume ifcfg files that have a non vdsm standard name
gerrit-hooks has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 2: * #1367378::Update tracker: OK * Set MODIFIED::bug 1367378#1367378OK, already on MODIFIED -- To view, visit https://gerrit.ovirt.org/65304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: net ifcfg: fix bond rollback
gerrit-hooks has posted comments on this change. Change subject: net ifcfg: fix bond rollback .. Patch Set 2: * #1374194::Update tracker: OK * Set MODIFIED::bug 1374194#1374194IGNORE, not all related patches are closed, check 64507 -- To view, visit https://gerrit.ovirt.org/65303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cea6ec71c913d74d95317ff7318259d64b40969 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: net ifcfg: fix bond rollback
Francesco Romani has submitted this change and it was merged. Change subject: net ifcfg: fix bond rollback .. net ifcfg: fix bond rollback When setupNetworks(NET, BOND) fails on NET configuration, BOND ifcfg file is removed, but it still exists in the system. We have to remove it manually like we do in removeBonding(). This must be backported to fix new functional tests on 4.0. Change-Id: I5cea6ec71c913d74d95317ff7318259d64b40969 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/59940 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Bug-Url: https://bugzilla.redhat.com/1374194 Reviewed-on: https://gerrit.ovirt.org/64509 Reviewed-on: https://gerrit.ovirt.org/65303 Reviewed-by: Francesco Romani Tested-by: Francesco Romani Continuous-Integration: Francesco Romani --- M lib/vdsm/network/configurators/ifcfg.py 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Francesco Romani: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cea6ec71c913d74d95317ff7318259d64b40969 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options
Milan Zamazal has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Code-Review+1 Verified+1 Verified that migration still works and the options values are set as requested. -- To view, visit https://gerrit.ovirt.org/65307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: canonicalize IPv4 prefix to netmask
gerrit-hooks has posted comments on this change. Change subject: net: canonicalize IPv4 prefix to netmask .. Patch Set 3: * #1374194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374194::OK, public bug * Check Product::#1374194::WARN, wrong product: ovirt-engine * Check TM::#1374194::OK, correct target milestone ovirt-4.0.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/64507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344eef120b4c19f90d4dd20c7857bb73ab259e9b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net tests: minor libvirt_tests style refactoring
Petr Horáček has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 6: Verified+1 libvirt test passed OK -- To view, visit https://gerrit.ovirt.org/65091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64dedb9859d204082a1516574e9b8650a3e4ffe5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests
Petr Horáček has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 6: Verified+1 (2 comments) Both tests passed. https://gerrit.ovirt.org/#/c/65090/5/tests/Makefile.am File tests/Makefile.am: Line 195: network/iproute2_test.py \ Line 196: network/ipwrapper_test.py \ Line 197: network/link_iface_test.py \ Line 198: network/netlink_test.py \ Line 199: network/netinfo_test.py \ > link_bond is not related to this patch. Done Line 200: network/ovs_driver_test.py \ Line 201: network/ovs_info_test.py \ Line 202: network/ovs_test.py \ Line 203: network/tc_test.py \ https://gerrit.ovirt.org/#/c/65090/5/tests/network/libvirt_test.py File tests/network/libvirt_test.py: Line 38: Line 39: aXml = ET.tostring(ET.fromstring(a)) Line 40: bXml = ET.tostring(ET.fromstring(b)) Line 41: Line 42: aXmlNrml = re.sub(b'>\s*\n\s*<', b'><', aXml).strip() > just rebase my merged https://gerrit.ovirt.org/64928 Done Line 43: bXmlNrml = re.sub(b'>\s*\n\s*<', b'><', bXml).strip() Line 44: Line 45: self.assertEqual(aXmlNrml, bXmlNrml, msg) Line 46: -- To view, visit https://gerrit.ovirt.org/65090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieca34a3f361586346d76ec22b11554c4a7c6e84d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan
Petr Horáček has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: I tried to, but it does not fail with dummy (only with system NIC), I don't know why, i tried to precreate ifcfg config for the dummy but it did not help. -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan
Dan Kenigsberg has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: api: Speed up schema loading
Francesco Romani has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: assuming yaml.CLoader is available in the package we already depend on - some packagers may want to split into a subpackage. -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: api: Speed up schema loading
Francesco Romani has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: api: Speed up schema loading
Dan Kenigsberg has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230fb88c279973f542f6e1cac17f43ff6f0d2f62 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: protocoldetector: Fix random double close
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:
Line 206: self._handlers.append(detector)
Line 207:
Line 208: def stop(self):
Line 209: self.log.debug("Stopping Acceptor")
Line 210: self._acceptor.close()
> No, this creates broken stop method that stop the reactor instead of the ac
what is your definition of broken because it seems I have a different one.
Line 211: self._reactor.stop()
Line 212:
Line 213:
Line 214: class _CannotDetectProtocol(Exception):
--
To view, visit https://gerrit.ovirt.org/65187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cec41c4baebcc620b70e19e62febed5dc9c542d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: clientIF: Fix reactor life cycle
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 110: self.acceptor_address = None Line 111: Line 112: def tearDown(self): Line 113: if self.acceptor: Line 114: self.acceptor.stop() > If we don't call acceptor close, and later we change the test so we don't c What hidden dependencies? Is it possible to use acceptor without reactor? Line 115: if self.reactor: Line 116: self.reactor.stop() Line 117: Line 118: # Testing -- To view, visit https://gerrit.ovirt.org/65188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319d06e8cffd86f87417053137f94eab90a4998d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
