Change in vdsm[master]: vdsm: virt: add optional container support
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 63: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/53820/18//COMMIT_MSG Commit Message: Line 6: Line 7: vdsm: virt: add optional container support Line 8: Line 9: We add an additional pluggable package for Line 10: container support in Vdsm. put a nice explanation to convirt, including a github link. Line 11: Line 12: Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 63 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Add working import check
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Add working import check .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/66479/4/tests/check_imports.py File tests/check_imports.py: PS4, Line 35: Modiles typo Line 52: for _, name, _ in pkgutil.walk_packages(vdsm_pkg.__path__, Line 53: prefix="vdsm.", Line 54: onerror=error): Line 55: if name in skip: Line 56: continue don't you want to skip this only if the dependant module is missing on the test platform? Line 57: if name in bad: Line 58: name = pytest.mark.xfail(name) Line 59: yield name Line 60: -- To view, visit https://gerrit.ovirt.org/66479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e4433a7c35e39374999d2a45260b55a8ca1f217 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: handle unavailability of resolv.conf
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: handle unavailability of resolv.conf .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/66481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e8ebd7043715d0c624572c933b7d1fbf01deb9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: tighten exception handling in getIfaceCfg
From Dan Kenigsberg :
Dan Kenigsberg has posted comments on this change.
Change subject: net: tighten exception handling in getIfaceCfg
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/66320/7/lib/vdsm/network/netinfo/misc.py
File lib/vdsm/network/netinfo/misc.py:
PS7, Line 50: ifcfg file {} not found
how about including the specific exception object? this can be raised also when
the file exists, but has wrong permissions, or due to a disk error. so the text
should be more general, too.
--
To view, visit https://gerrit.ovirt.org/66320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fc3b58e99e4e045e6f2b1b6afe75fd46a48d0c5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: doc: Remove unused _static directory
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: doc: Remove unused _static directory .. doc: Remove unused _static directory Change-Id: Ia4442d5e6c38dea2c622f344bf7e8cab743ad0d0 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/66441 Reviewed-by: Milan Zamazal Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- D doc/_static/keep M doc/conf.py 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4442d5e6c38dea2c622f344bf7e8cab743ad0d0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: doc: Remove unused _static directory
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: doc: Remove unused _static directory .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4442d5e6c38dea2c622f344bf7e8cab743ad0d0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: janitorial: remove hook_ovs_test from blacklist
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: janitorial: remove hook_ovs_test from blacklist .. janitorial: remove hook_ovs_test from blacklist commit 8d8e3fe0 dropped the test module, but did not remove it from the blacklist. Change-Id: Ic2c21febf3e978d9c8262e01a66d7938f5d887a2 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/66448 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI --- M tests/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2c21febf3e978d9c8262e01a66d7938f5d887a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: janitorial: remove hook_ovs_test from blacklist
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: janitorial: remove hook_ovs_test from blacklist .. Patch Set 2: Code-Review+2 Verified+1 CI still passes -- To view, visit https://gerrit.ovirt.org/66448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2c21febf3e978d9c8262e01a66d7938f5d887a2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: py3 tests: ported imagetickets_test.py to python3 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59859/2/tests/Makefile.am File tests/Makefile.am: Line 178 Line 179 Line 180 Line 181 Line 182 even if we keep this module blacklisted, it's worth to take httplib from six (just a tiny step forward). -- To view, visit https://gerrit.ovirt.org/59859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: tighten exception handling in getIfaceCfg
From Dan Kenigsberg :
Dan Kenigsberg has posted comments on this change.
Change subject: net: tighten exception handling in getIfaceCfg
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/66320/3/lib/vdsm/network/netinfo/misc.py
File lib/vdsm/network/netinfo/misc.py:
PS3, Line 50: IOError
IOError is the right exception
https://www.python.org/dev/peps/pep-3151/
but this is such a mess, so I prefer using EnvironmentError
Line 47: if k in _IFCFG_ZERO_SUFFIXED:
Line 48: k = k[:-1]
Line 49: ifaceCfg[k] = v
Line 50: except IOError as e:
Line 51: if e.errno == errno.ENONET:
let's anticipate Eddy's review and add two tests: one that shows that a missing
file results with an empty dict; a second test that other errors are raised.
Line 52: logging.warning('ifcfg file {} not
found'.format(ifcfg_file))
Line 53: else:
Line 54: raise
Line 55: return ifaceCfg
--
To view, visit https://gerrit.ovirt.org/66320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fc3b58e99e4e045e6f2b1b6afe75fd46a48d0c5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: exception: Fix bad error code
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: exception: Fix bad error code .. exception: Fix bad error code A comma sneaked after the error code, making the error code a tuple instead of int. The error was introduced in commit e84aaadc3c9e (exception: Add exceptions for vdsm.define errors). Change-Id: I2ffd86997c6bf7ef55f58eed8bf37315501f3b87 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/66443 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/common/exception.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ffd86997c6bf7ef55f58eed8bf37315501f3b87 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network/conf_test: no need to reinvent six.StringIO
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: network/conf_test: no need to reinvent six.StringIO .. network/conf_test: no need to reinvent six.StringIO Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/66449 Reviewed-by: Edward Haas Tested-by: Edward Haas Continuous-Integration: Jenkins CI --- M tests/network/conf_test.py 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network/conf_test: no need to reinvent six.StringIO
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network/conf_test: no need to reinvent six.StringIO .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2vTests: janitorial: use string literals
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: v2vTests: janitorial: use string literals .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/66447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7074238220738316f536c725474d767b82c3b31 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network/conf_test: no need to reinvent six.StringIO
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network/conf_test: no need to reinvent six.StringIO .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/66449/1/tests/network/conf_test.py File tests/network/conf_test.py: PS1, Line 31: # Due to shlex, we are forced to choose the stream type per the python version. : # It is used to mock the returned 'file' from open() which shlex consumes. : # On PY2, shlex can consume a (byte) string and not a unicode (opposite on PY3) > this can also go... I do not like this six.StringIO, I feel compelled to apologize for using it. -- To view, visit https://gerrit.ovirt.org/66449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: tests: renamed tests signatures to undercores
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: tests: renamed tests signatures to undercores .. net: tests: renamed tests signatures to undercores Change-Id: If0cf62b3eda8a63ca69f6150b35ef41ce97e7946 Signed-off-by: Leon Goldberg Reviewed-on: https://gerrit.ovirt.org/66388 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg --- M tests/network/netinfo_test.py 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Leon Goldberg: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0cf62b3eda8a63ca69f6150b35ef41ce97e7946 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network/conf_test: no need to reinvent six.StringIO
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network/conf_test: no need to reinvent six.StringIO .. Patch Set 1: Code-Review-1 oops, better test before posting. -- To view, visit https://gerrit.ovirt.org/66449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network/conf_test: no need to reinvent six.StringIO
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network/conf_test: no need to reinvent six.StringIO .. Patch Set 1: Following Leon's https://gerrit.ovirt.org/#/c/66387/ -- To view, visit https://gerrit.ovirt.org/66449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: tests: renamed tests signatures to undercores
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: tests: renamed tests signatures to undercores .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cf62b3eda8a63ca69f6150b35ef41ce97e7946 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: tests: mock resolv.conf
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: tests: mock resolv.conf .. net: tests: mock resolv.conf testGetHostNameservers to use a mocked resolv.conf over a temp file; function renamed to underscores Change-Id: Icd75bfe1284baf3922428c2415ff52691d686286 Signed-off-by: Leon Goldberg Reviewed-on: https://gerrit.ovirt.org/66387 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M tests/network/netinfo_test.py 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd75bfe1284baf3922428c2415ff52691d686286 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: tests: mock resolv.conf
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: tests: mock resolv.conf .. Patch Set 5: Code-Review+2 Verified+1 (1 comment) Still passes the test https://gerrit.ovirt.org/#/c/66387/5/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 57: 'nameserver 8.8.8.8\n' Line 58: 'nameserver 8.8.4.4\n' Line 59: ) Line 60: expected_nameservers = ['192.168.0.100', '8.8.8.8', '8.8.4.4'] Line 61: resolv_conf_stream = six.StringIO(RESOLV_CONF) Thanks for teaching me about six.StringIO. I think that we'd better also fix the tested code, so that it uses io.open so that we know if we're handling bytes or strings. Line 62: mock_open.return_value.__enter__.return_value = resolv_conf_stream Line 63: Line 64: resulted_nameservers = dns.get_host_nameservers() Line 65: -- To view, visit https://gerrit.ovirt.org/66387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd75bfe1284baf3922428c2415ff52691d686286 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: doc: Speed up "make html"
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: doc: Speed up "make html" .. doc: Speed up "make html" Using parallel builds with 4 workers speed up the build from 21 seconds to 13. Change-Id: I4a51a8556ca5d8b338c9ff8d85dc7eb153209477 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/66440 Continuous-Integration: Jenkins CI Reviewed-by: Milan Zamazal Reviewed-by: Dan Kenigsberg --- M doc/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a51a8556ca5d8b338c9ff8d85dc7eb153209477 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: broker cleanup
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: broker cleanup .. stomp: broker cleanup We can remove engine 3.5 supported queue names since we do not support this version anymore. Change-Id: I972268a72f51975eb78c6bac926e29ac53178dea Signed-off-by: Piotr Kliczewski Reviewed-on: https://gerrit.ovirt.org/66300 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Reviewed-by: Nir Soffer --- M lib/yajsonrpc/stomp.py M lib/yajsonrpc/stompreactor.py M tests/integration/jsonRpcHelper.py M tests/stompAdapterTests.py 4 files changed, 11 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: doc: Speed up "make html"
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: doc: Speed up "make html" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/66440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a51a8556ca5d8b338c9ff8d85dc7eb153209477 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network/conf_test: no need to reinvent six.StringIO
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: network/conf_test: no need to reinvent six.StringIO .. network/conf_test: no need to reinvent six.StringIO Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Signed-off-by: Dan Kenigsberg --- M tests/network/conf_test.py 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/66449/1 diff --git a/tests/network/conf_test.py b/tests/network/conf_test.py index 59c29fd..e24f13d 100644 --- a/tests/network/conf_test.py +++ b/tests/network/conf_test.py @@ -31,11 +31,7 @@ # Due to shlex, we are forced to choose the stream type per the python version. # It is used to mock the returned 'file' from open() which shlex consumes. # On PY2, shlex can consume a (byte) string and not a unicode (opposite on PY3) -import six -if six.PY2: -from io import BytesIO as Stream -else: -from io import StringIO as Stream +from six import StringIO from vdsm.network import libvirt from vdsm.network.configurators import ifcfg @@ -186,7 +182,7 @@ mock_list_files, mock_rename, mock_rmfile): -mock_open.return_value.__enter__.side_effect = lambda: Stream( +mock_open.return_value.__enter__.side_effect = lambda: StringIO( IFCFG_ETH_CONF) mock_list_files.return_value = ['filename1'] @@ -200,7 +196,7 @@ mock_list_files, mock_rename, mock_rmfile): -mock_open.return_value.__enter__.side_effect = lambda: Stream( +mock_open.return_value.__enter__.side_effect = lambda: StringIO( IFCFG_ETH_CONF) mock_list_files.return_value = ['filename1', 'filename2'] -- To view, visit https://gerrit.ovirt.org/66449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I67d842e8cd07f57a0a32f919b6d24e5428f787b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: handle unavailability of resolv.conf
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: handle unavailability of resolv.conf .. Patch Set 11: Code-Review+2 Thanks, Leon. Please backport this to the ovirt-4.0 branch. -- To view, visit https://gerrit.ovirt.org/66311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e87724b836b1ed1d49e6f6fff723e3b627412a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: handle unavailability of resolv.conf
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. Change subject: net: handle unavailability of resolv.conf .. net: handle unavailability of resolv.conf get_host_nameservers to return an empty list on failure to read from /etc/resolv.conf Bug-Url: https://bugzilla.redhat.com/1392989 Change-Id: Ia6e87724b836b1ed1d49e6f6fff723e3b627412a Signed-off-by: Leon Goldberg Reviewed-on: https://gerrit.ovirt.org/66311 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/netinfo/dns.py M tests/network/netinfo_test.py 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Leon Goldberg: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6e87724b836b1ed1d49e6f6fff723e3b627412a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: v2vTests: janitorial: use string literals
From Dan Kenigsberg :
Dan Kenigsberg has uploaded a new change for review.
Change subject: v2vTests: janitorial: use string literals
..
v2vTests: janitorial: use string literals
The code is nicer and shorter if we avoid the call to str.join().
Change-Id: Ic7074238220738316f536c725474d767b82c3b31
Signed-off-by: Dan Kenigsberg
---
M tests/v2vTests.py
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/66447/1
diff --git a/tests/v2vTests.py b/tests/v2vTests.py
index 5f85b84..5b7db9f 100644
--- a/tests/v2vTests.py
+++ b/tests/v2vTests.py
@@ -445,18 +445,18 @@
)
def testOutputParser(self):
-output = ''.join(['[ 0.0] Opening the source -i libvirt ://roo...\n',
- '[ 1.0] Creating an overlay to protect the f...\n',
- '[ 88.0] Copying disk 1/2 to /tmp/v2v/000...\n',
- '(0/100%)\r',
- '(50/100%)\r',
- '(100/100%)\r',
- '[ 180.0] Copying disk 2/2 to /tmp/v2v/10-...\n',
- '(0/100%)\r',
- '(50/100%)\r',
- '(100/100%)\r',
- '[ 256.0] Creating output metadata',
- '[ 256.0] Finishing off'])
+output = ('[ 0.0] Opening the source -i libvirt ://roo...\n'
+ '[ 1.0] Creating an overlay to protect the f...\n'
+ '[ 88.0] Copying disk 1/2 to /tmp/v2v/000...\n'
+ '(0/100%)\r'
+ '(50/100%)\r'
+ '(100/100%)\r'
+ '[ 180.0] Copying disk 2/2 to /tmp/v2v/10-...\n'
+ '(0/100%)\r'
+ '(50/100%)\r'
+ '(100/100%)\r'
+ '[ 256.0] Creating output metadata'
+ '[ 256.0] Finishing off')
parser = v2v.OutputParser()
events = list(parser.parse(StringIO(output)))
--
To view, visit https://gerrit.ovirt.org/66447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7074238220738316f536c725474d767b82c3b31
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: hooks: tighten exception handling
From Dan Kenigsberg :
Dan Kenigsberg has uploaded a new change for review.
Change subject: hooks: tighten exception handling
..
hooks: tighten exception handling
Catch-all "pass:" is evil. _getScriptInfo should return an empty
hexdigest only if the underlying hook is not readable. It should not
ignore other exceptions.
EnvironmentError was chosen instead of OSError because the former one
behaves the same on Python 3 and Python 2.
Change-Id: I80cf67b2750170060d79a9b0a3effe68401c9593
Signed-off-by: Dan Kenigsberg
---
M lib/vdsm/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/66446/1
diff --git a/lib/vdsm/hooks.py b/lib/vdsm/hooks.py
index 777b4ee..03eec53 100644
--- a/lib/vdsm/hooks.py
+++ b/lib/vdsm/hooks.py
@@ -422,7 +422,7 @@
try:
with open(path) as f:
md5 = hashlib.md5(f.read()).hexdigest()
-except:
+except EnvironmentError:
md5 = ''
return {'md5': md5}
--
To view, visit https://gerrit.ovirt.org/66446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80cf67b2750170060d79a9b0a3effe68401c9593
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: janitorial: remove hook_ovs_test from blacklist
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: janitorial: remove hook_ovs_test from blacklist .. janitorial: remove hook_ovs_test from blacklist commit 8d8e3fe0 dropped the test module, but did not remove it from the blacklist. Change-Id: Ic2c21febf3e978d9c8262e01a66d7938f5d887a2 Signed-off-by: Dan Kenigsberg --- M tests/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/66448/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index e96f226..5448b41 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -187,7 +187,6 @@ momTests.py \ monkeypatchTests.py \ mountTests.py \ - network/hook_ovs_test.py \ network/iproute2_test.py \ network/ipwrapper_test.py \ network/link_iface_test.py \ -- To view, visit https://gerrit.ovirt.org/66448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2c21febf3e978d9c8262e01a66d7938f5d887a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
