Change in vdsm[master]: vm: consider 'action' when handling I/O errors
David Gibson has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 4: Code-Review-1 The else clause looks as though it could give a really misleading error if qemu/libvirt ever added an action type other than the current stop/report/ignore. Better to just print "unexpected error action: " or something, maybe? -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
David Gibson has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 Looks good to me now. -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
David Gibson has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 3: Changed 1 to True as requested. I'm not sure what you mean "import only what needed". What's being imported that's not needed? I'm having trouble parsing the last paragraph of Yaniv's last comment. But if I understand it correctly, it's not merely a question of altering multiprocessings logging configuration. Unless multiprocessing.get_logger() is called at least once to instantiate the logger multiprocessing *will not log* at all, regardless of any other logger configuration. So 17199 won't remove the necessity for this patch. -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
David Gibson has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
David Gibson has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: Saggi, I'm not sure what information you're after. multiprocessing uses the logging facilities from the logging module in the normal way. The one caveat is that it always effectively does: if logger: log_something() So the logger must be instantiated elsewhere for anything to happen. -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
David Gibson has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: Supervdsm doesn't share logging with vdsm - it logs to supervdsm.log seperately from the rest. At least in the 3.2 era, I gather things have changed a bit in 3.3 -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
