Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 2: verified by 1. sanity - use a payload with a long file name and make sure it's not displayed properly on windows. 2. apply patch and verify the file name is displayed correctly on both linux and windows systems (one from each). -- To view, visit https://gerrit.ovirt.org/39900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has uploaded a new change for review. Change subject: vm payload: Add Joliet FS support .. vm payload: Add Joliet FS support Current payload ISO only uses Rock Ridge extension, as a result Windows VMs can't use payloads with long filenames. This fix adds the Joliet extension to the generated ISO. Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Bug-Url: https://bugzilla.redhat.com/1205058 Signed-off-by: Eldan Shachar --- M vdsm/mkimage.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/40534/1 diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py index 2b69a18..7633662 100644 --- a/vdsm/mkimage.py +++ b/vdsm/mkimage.py @@ -123,7 +123,7 @@ _decodeFilesIntoDir(files, dirname) isopath = _getFileName(vmId, files) -command = [EXT_MKISOFS, '-R', '-o', isopath] +command = [EXT_MKISOFS, '-R', '-J', '-o', isopath] if volumeName is not None: command.extend(['-V', volumeName]) command.extend([dirname]) -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has abandoned this change. Change subject: vm payload: Add Joliet FS support .. Abandoned -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: sure I'll cherry-pick after it will be merged in master, because it was a small change I did it manually and forgot about the change-id. -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm payload: Add Joliet FS support
Eldan Shachar has uploaded a new change for review. Change subject: vm payload: Add Joliet FS support .. vm payload: Add Joliet FS support Current payload ISO only uses Rock Ridge extension, as a result Windows VMs can't use payloads with long filenames. This fix adds the Joliet extension to the generated ISO. Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Bug-Url: https://bugzilla.redhat.com/1205058 Signed-off-by: Eldan Shachar --- M vdsm/mkimage.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/39900/1 diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py index 2b69a18..7633662 100644 --- a/vdsm/mkimage.py +++ b/vdsm/mkimage.py @@ -123,7 +123,7 @@ _decodeFilesIntoDir(files, dirname) isopath = _getFileName(vmId, files) -command = [EXT_MKISOFS, '-R', '-o', isopath] +command = [EXT_MKISOFS, '-R', '-J', '-o', isopath] if volumeName is not None: command.extend(['-V', volumeName]) command.extend([dirname]) -- To view, visit https://gerrit.ovirt.org/39900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eldan Shachar ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has uploaded a new change for review. Change subject: vm payload: Add Joliet FS support .. vm payload: Add Joliet FS support Current payload ISO only uses Rock Ridge extension, as a result Windows VMs can't use payloads with long filenames. This fix adds the Joliet extension to the generated ISO. Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Bug-Url: https://bugzilla.redhat.com/1205058 Signed-off-by: Eldan Shachar --- M vdsm/mkimage.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/39898/1 diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py index 2b69a18..7633662 100644 --- a/vdsm/mkimage.py +++ b/vdsm/mkimage.py @@ -123,7 +123,7 @@ _decodeFilesIntoDir(files, dirname) isopath = _getFileName(vmId, files) -command = [EXT_MKISOFS, '-R', '-o', isopath] +command = [EXT_MKISOFS, '-R', '-J', '-o', isopath] if volumeName is not None: command.extend(['-V', volumeName]) command.extend([dirname]) -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches