Change in vdsm[master]: spec: bump libvirt requirement
Omer Frenkel has posted comments on this change. Change subject: spec: bump libvirt requirement .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3451736271ff6d2d499387a4de5063efa28d9fa4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: bump libvirt requirement
Omer Frenkel has posted comments on this change. Change subject: spec: bump libvirt requirement .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45509/1//COMMIT_MSG Commit Message: Line 11: Libvirt >= 1.2.13 at least (probably earlier) is fixed already, Line 12: so CentOS/RHEL 7.2 will be fine. Line 13: We must make sure that CentOS/RHEL 7.1 depend on the fixed libvirt. Line 14: Line 15: https://bugzilla.redhat.com/1258349 should be: Bug-Url: ... so automation would be able to parse it and update the bug Line 16: Line 17: Change-Id: I3451736271ff6d2d499387a4de5063efa28d9fa4 -- To view, visit https://gerrit.ovirt.org/45509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3451736271ff6d2d499387a4de5063efa28d9fa4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: StoragePool_removeVM
Omer Frenkel has posted comments on this change. Change subject: jsonrpc: StoragePool_removeVM .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/44321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16acb11982e70ff7f8a05ac816d36b2aa34caea0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: StoragePool_updateVMs
Omer Frenkel has posted comments on this change. Change subject: jsonrpc: StoragePool_updateVMs .. Patch Set 2: Verified+1 verified updateVM is working -- To view, visit https://gerrit.ovirt.org/44271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f7011b633c289f0d36bfd987f9392d2edf10f8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: StoragePool_updateVMs
Omer Frenkel has posted comments on this change.
Change subject: jsonrpc: StoragePool_updateVMs
..
Patch Set 2:
i verified this fix the issue on my host (rhel 6.6 with latest 3.5) for
updateVMs but there is still (the same) issue with removeVM :
Thread-161::DEBUG::2015-08-03
15:50:12,438::__init__::481::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'StoragePool.removeVM' in bridge with {'vmUUID':
'9de42bc7-e81a-4efd-bf81-ebb1f74fd6e1', 'storagepoolID':
'0002-0002-0002-0002-033d'}
Thread-161::ERROR::2015-08-03
15:50:12,440::__init__::506::jsonrpc.JsonRpcServer::(_serveRequest) Internal
server error
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/yajsonrpc/__init__.py", line 501, in
_serveRequest
res = method(**params)
File "/usr/share/vdsm/rpc/Bridge.py", line 273, in _dynamicMethod
raise InvalidCall(fn, methodArgs, e)
InvalidCall: Attempt to call function: > with arguments:
('9de42bc7-e81a-4efd-bf81-ebb1f74fd6e1',) error: removeVM() takes exactly
3 arguments (2 given)
so please update this patch or send another for remove
--
To view, visit https://gerrit.ovirt.org/44271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26f7011b633c289f0d36bfd987f9392d2edf10f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Maor Lipchuk
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: send status event on pause and resume
Omer Frenkel has posted comments on this change. Change subject: vm: event: send status event on pause and resume .. Patch Set 14: Verified+1 verified with latest engine using start on pause and then resume. events sent and looks ok -- To view, visit https://gerrit.ovirt.org/43376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da5e2c8e183e05a7a795ee129984b214fff60ac Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Change state of the agent only after heartbeat processing
Omer Frenkel has posted comments on this change. Change subject: virt: Change state of the agent only after heartbeat processing .. Patch Set 1: Verified+1 verified with latest engine - up event contains guest agent data -- To view, visit https://gerrit.ovirt.org/43859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I541d3a4ad2930715d38c8908e2c5d6543ad72037 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: events: skip event after failed migration
Omer Frenkel has posted comments on this change. Change subject: vm: events: skip event after failed migration .. Patch Set 2: patch for backend handling: https://gerrit.ovirt.org/#/c/43904/ -- To view, visit https://gerrit.ovirt.org/43750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59ee80e6e59093be37bc022a77325b6775770ec9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: events: skip event after destroy
Omer Frenkel has posted comments on this change. Change subject: vm: events: skip event after destroy .. Patch Set 5: patch for backend handling of the down event: https://gerrit.ovirt.org/#/c/43905/ -- To view, visit https://gerrit.ovirt.org/43668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia67abcf7af4d81451e47eb39bff2bbd8baccfbfa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: event: status is an enumeration, not as tuple
Omer Frenkel has posted comments on this change. Change subject: vm: event: status is an enumeration, not as tuple .. Patch Set 3: Code-Review+1 looks ok to me, this is relevant only for events, right? did you check engine handles the change? -- To view, visit https://gerrit.ovirt.org/43413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b24c95209a22747e30367c1ef03377dac08b78 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: 'device' property for RNG device
Omer Frenkel has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b5b8a9c908b1d3588a32fbd3e2197fe4926bfa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: 'device' property for RNG device
Omer Frenkel has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 1: how this would affect new vdsm on old (not fixed) engine? -- To view, visit https://gerrit.ovirt.org/43166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b5b8a9c908b1d3588a32fbd3e2197fe4926bfa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: memory hotplug for vm
Omer Frenkel has posted comments on this change. Change subject: virt: memory hotplug for vm .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: memory hotplug for vm
Omer Frenkel has posted comments on this change.
Change subject: virt: memory hotplug for vm
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/40549/7/vdsm/vdsmd.8.in
File vdsm/vdsmd.8.in:
Line 134: The environment of hooks specific to devices:
Line 135: before_nic_hotplug, after_nic_hotplug, after_nic_hotplug_fail,
Line 136: before_nic_hotunplug, after_nic_hotunplug,
after_nic_hotunplug_fail,
Line 137: before_update_device, after_update_device,
after_update_device_fail,
Line 138: before_disk_hotplug, after_disk_hotplug,
> I think that your new memory hooks should be added here, too. right?
Done
Line 139: before_disk_hotunplug, after_disk_hotunplug,
Line 140: before_device_create, after_device_create,
Line 141: before_device_destroy, after_device_destroy,
Line 142: before_device_migrate_source, after_device_migrate_source,
https://gerrit.ovirt.org/#/c/40549/7/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 65: return elements[0] if elements else None
Line 66:
Line 67: def get_memory_size(self):
Line 68: """
Line 69: Return the vm memory from xml in mb
> mb -> MiB
Done
Line 70: """
Line 71: memory = self._first_element_by_tag_name("memory")
Line 68: """
Line 69: Return the vm memory from xml in mb
Line 70: """
Line 71: memory = self._first_element_by_tag_name("memory")
Line 72: return long(memory.firstChild.nodeValue) / 1024 if memory else
None
> 'long' is probably unneeded.
Done
https://gerrit.ovirt.org/#/c/40549/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2210: self._devices[hwclass.MEMORY].append(device)
Line 2211: with self._confLock:
Line 2212: self.conf['devices'].append(memParams)
Line 2213: self._updateDomainDescriptor()
Line 2214: self._getUnderlyingMemoryDeviceInfo()
> Please add a comment:
Done
Line 2215: self.saveState()
Line 2216:
Line 2217: hooks.after_memory_hotplug(deviceXml)
Line 2218:
--
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: virt: add support for memory hotplug
Omer Frenkel has abandoned this change. Change subject: hooks: virt: add support for memory hotplug .. Abandoned this is implemented together with hot plug memory patch please review: https://gerrit.ovirt.org/#/c/40549/ -- To view, visit https://gerrit.ovirt.org/40548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: memory hotplug for vm
Omer Frenkel has posted comments on this change.
Change subject: virt: memory hotplug for vm
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40549/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2175: self._devices[hwclass.MEMORY].append(device)
Line 2176: with self._confLock:
Line 2177: self.conf['devices'].append(memParams)
Line 2178: self.saveState()
Line 2179: self._getUnderlyingMemoryDeviceInfo()
> maybe not.
verified in both case updated information returned from libvirt
Line 2180:
Line 2181: hooks.after_memory_hotplug(deviceXml)
Line 2182:
Line 2183: return {'status': doneCode, 'vmList': self.status()}
--
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: memory hotplug for vm
Omer Frenkel has posted comments on this change. Change subject: virt: memory hotplug for vm .. Patch Set 6: changes in this patchset: * merged with hooks patchset so it would be clear where and how the hooks are used * after hotplug also updating the 'memSize' in the config to the new memory. verified this is updated correctly and also the recovery file is updated. -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: memory hotplug for vm
Omer Frenkel has posted comments on this change. Change subject: virt: memory hotplug for vm .. Patch Set 5: @fromani checked vdsm restart flow, looks ok: no errors in the vdsm log full list verb returns the device as expected engine didnt recognize any change in vm or device state -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: memory hotplug for vm
Omer Frenkel has posted comments on this change. Change subject: virt: memory hotplug for vm .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add support for specifying vm maximum memory
Omer Frenkel has posted comments on this change. Change subject: virt: add support for specifying vm maximum memory .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/40547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: virt: add support for memory hotplug
Omer Frenkel has posted comments on this change. Change subject: hooks: virt: add support for memory hotplug .. Patch Set 3: ping -- To view, visit https://gerrit.ovirt.org/40548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Memory hotunplug
Omer Frenkel has posted comments on this change. Change subject: virt: Memory hotunplug .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c878711b9015129f525970f6cc1f11f89998b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
Omer Frenkel has posted comments on this change.
Change subject: Memory Hotplug for vm
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/40549/3/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:
Line 239:
Line 240: def __init__(self, conf, log, **kwargs):
Line 241: super(Memory, self).__init__(conf, log, **kwargs)
Line 242: # we get size in mb and send in kb
Line 243: self.size = int(kwargs.get('size')) * 1024
> I think you mentioned that due some limitation down the stack, each size sh
256mb, enforced by the backend, you can see this at
https://gerrit.ovirt.org/#/c/35081/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java
[line 84]
Line 244: self.node = kwargs.get('node')
Line 245:
Line 246: def getXML(self):
Line 247: """
Line 242: # we get size in mb and send in kb
Line 243: self.size = int(kwargs.get('size')) * 1024
Line 244: self.node = kwargs.get('node')
Line 245:
Line 246: def getXML(self):
> can you please add one unit test for getXML (in tests/deviceTests.py) ?
Done
Line 247: """
Line 248:
Line 249:
Line 250: 524287
--
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Hooks for Memory Hotplug
Omer Frenkel has posted comments on this change. Change subject: Hooks for Memory Hotplug .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40548/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-04-29 18:07:42 +0300 Line 4: Commit: Omer Frenkel Line 5: CommitDate: 2015-05-06 13:30:24 +0300 Line 6: Line 7: Hooks for Memory Hotplug > plase reformat to: Done Line 8: Line 9: This patch introduce vdsm hooks for memory hot plug. Line 10: the hooks will be called before and after memory hotplug is performed in Line 11: libvirt. -- To view, visit https://gerrit.ovirt.org/40548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
Omer Frenkel has posted comments on this change.
Change subject: Add support for specifying vm maximum memory
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40547/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-05-04 14:07:41 +0300
Line 4: Commit: Omer Frenkel
Line 5: CommitDate: 2015-05-06 13:25:09 +0300
Line 6:
Line 7: Add support for specifying vm maximum memory
> please reformat to:
Done
Line 8:
Line 9: Added new parameter 'maxMemSize' to VM
Line 10: this parameter is sent from engine backend and passed to libvirt xml
Line 11: with the mandatory 'slots' attribute.
https://gerrit.ovirt.org/#/c/40547/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3586: # @maxMemSize:#optional The maximum amount of memory
that can be
Line 3587: # assigned to the VM in MB
Line 3588: #
Line 3589: # @maxMemSlots: #optional Maximum number of memory slots
available
Line 3590: # This is the upper boundry for hot plug
memory action
> s/boundry/boundary/
Done
Line 3591: #
Line 3592: # Since: 4.10.0
Line 3593: ##
Line 3594: {'type': 'VmDefinition',
https://gerrit.ovirt.org/#/c/40547/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 168: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 169: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 170: if 'maxMemSize' in self.conf:
Line 171: maxMemSizeKB = str(int(self.conf['maxMemSize']) * 1024)
Line 172: maxMemSlots = str(self.conf.get('maxMemSlots', '16'))
> document "16" at least in the schema...or here...either way it does deserve
Done
Line 173: self.dom.appendChildWithArgs('maxMemory',
text=maxMemSizeKB,
Line 174: slots=maxMemSlots)
Line 175: vcpu = self.dom.appendChildWithArgs('vcpu',
text=self._getMaxVCpus())
Line 176: vcpu.setAttrs(**{'current': self._getSmp()})
--
To view, visit https://gerrit.ovirt.org/40547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Hooks for Memory Hotplug
Omer Frenkel has posted comments on this change.
Change subject: Hooks for Memory Hotplug
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40548/2/vdsm/hooks.py
File vdsm/hooks.py:
Line 322: return _runHooksDir(None, 'after_set_num_of_cpus', vmconf=vmconf,
Line 323: params=params, raiseError=False)
Line 324:
Line 325:
Line 326: def before_memory_hotplug(domxml, vmconf={}, params={}):
> I don't understand this patch. You seem to be adding a hook point, but you
the hooks are called on the next patch, where support to hotplug mem is added.
i followed the example of hot plug nic and disk, since these are adding a vm
device (like memory) and cpu is not a vm device.
so i wanted to have the same behaviour with other hot plugged devices.
you think i should use the same signature as set_..cpus ?
Line 327: return _runHooksDir(domxml, 'before_memory_hotplug',
vmconf=vmconf,
Line 328: params=params)
Line 329:
Line 330:
--
To view, visit https://gerrit.ovirt.org/40548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
Omer Frenkel has posted comments on this change. Change subject: Memory Hotplug for vm .. Patch Set 3: Verified+1 verified using engine: successfully hot plugged memory and observed it inside the guest. also observed the device sent and saved back in the engine db. -- To view, visit https://gerrit.ovirt.org/40549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
Omer Frenkel has posted comments on this change. Change subject: Add support for specifying vm maximum memory .. Patch Set 2: Verified+1 verified: * using engine that doesnt support this value: attribute wasn't sent to libvirt - vm works as expected * using supporting engine - values from engine added in libvirt xml, as expected -- To view, visit https://gerrit.ovirt.org/40547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Detect RNG device by type
Omer Frenkel has posted comments on this change.
Change subject: vm: Detect RNG device by type
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40095/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4174: dev.address = address
Line 4175: dev.alias = alias
Line 4176:
Line 4177: for dev in self.conf['devices']:
Line 4178: if dev['device'] == hwclass.SMARTCARD and \
i think smartcard has the same issue
Line 4179: not dev.get('address'):
Line 4180: dev['address'] = address
Line 4181: dev['alias'] = alias
Line 4182:
--
To view, visit https://gerrit.ovirt.org/40095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Shmuel Leib Melamud
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
Omer Frenkel has posted comments on this change.
Change subject: Add support for specifying vm maximum memory
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/40547/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3582: # @serial:#optional Serial number for the VM.
Line 3583: #
Line 3584: # @numOfIoThreads:#optional The num of iothreads qemu
allocates
Line 3585: #
Line 3586: # @maxMemSize:The maximum amount of memory that can be
assigned
> isn't this optional? If this is mandatory, new VDSMs will not work with old
Done
Line 3587: # to the VM in MB
Line 3588: #
Line 3589: # Since: 4.10.0
Line 3590: ##
Line 3601: '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint',
Line 3602: 'status': 'VmStatus', 'timeOffset': 'uint',
Line 3603: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 3604: 'vmType': 'VmType', '*exitCode': 'int', '*exitMessage':
'str',
Line 3605: '*serial': 'str', '*numOfIoThreads': 'uint', 'maxMemSize':
'uint'}}
> if this is indeed optional, don't forget to update here as well.
Done
Line 3606:
Line 3607: ##
Line 3608: # @VmParameters:
Line 3609: #
https://gerrit.ovirt.org/#/c/40547/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 169: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 170: if 'maxMemSize' in self.conf:
Line 171: maxMemSizeKB = str(int(self.conf['maxMemSize']) * 1024)
Line 172: self.dom.appendChildWithArgs('maxMemory',
text=maxMemSizeKB,
Line 173: slots=self._getMaxVCpus())
> is the usage of _getMaxVCpus() intentional?
you are right this is wrong, i will change it to be sent from the engine as well
Line 174: vcpu = self.dom.appendChildWithArgs('vcpu',
text=self._getMaxVCpus())
Line 175: vcpu.setAttrs(**{'current': self._getSmp()})
Line 176:
Line 177: self._devices = Element('devices')
--
To view, visit https://gerrit.ovirt.org/40547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Memory Hotplug for vm
Omer Frenkel has uploaded a new change for review.
Change subject: Memory Hotplug for vm
..
Memory Hotplug for vm
Introduces a new verb to hotplug memory to a running vm.
the memory is plugged to a guest NUMA node.
exposes it in the XML-RPC and JSON-RPC.
http://www.ovirt.org/Features/Memory_Hotplug
Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Signed-off-by: Omer Frenkel
---
M client/vdsClient.py
M lib/vdsm/define.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/core.py
M vdsm/virt/vmdevices/hwclass.py
9 files changed, 205 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/40549/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 375fa1a..687f33f 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -325,6 +325,13 @@
params = {'vmId': args[0], 'drive': drive}
return self.ExecAndExit(self.s.hotunplugDisk(params))
+def hotplugMemory(self, args):
+memory = self._parseDriveSpec(args[1])
+memory['type'] = 'memory'
+memory['device'] = 'memory'
+params = {'vmId': args[0], 'memory': memory}
+return self.ExecAndExit(self.s.hotplugMemory(params))
+
def setNumberOfCpus(self, args):
return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
@@ -2750,6 +2757,14 @@
' ',
'Extends the virtual size of a disk'
)),
+'hotplugMemory': (
+serv.hotplugMemory, (
+' ',
+'Hotplug memory to a running VM NUMA node',
+'memDeviceSpec parameters list: r=required, o=optional',
+'r size: memory size to plug in mb.',
+'r node: guest NUMA node id to plug into'
+)),
'setNumberOfCpus': (
serv.setNumberOfCpus, (
' ',
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index f725748..a1b32d2 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -150,6 +150,9 @@
'V2VConnection': {'status': {
'code': 65,
'message': 'error connecting to hypervisor'}},
+'hotplugMem': {'status': {
+'code': 66,
+'message': 'Failed to hotplug memory'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/vdsm/API.py b/vdsm/API.py
index 3cdc465..d3efaf9 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -470,6 +470,23 @@
return curVm.hotunplugDisk(params)
+def hotplugMemory(self, params):
+try:
+utils.validateMinimalKeySet(params, ('vmId', 'memory'))
+except ValueError:
+self.log.error('Missing one of required parameters: vmId, memory')
+return {'status': {'code': errCode['MissParam']['status']['code'],
+ 'message': 'Missing one of required '
+ 'parameters: vmId, memory'}}
+
+try:
+curVm = self._cif.vmContainer[self._UUID]
+except KeyError:
+self.log.warning("vm %s doesn't exist", self._UUID)
+return errCode['noVM']
+
+return curVm.hotplugMemory(params)
+
def setNumberOfCpus(self, numberOfCpus):
if self._UUID is None or numberOfCpus is None:
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 9a1da99..5fa511d 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -434,6 +434,10 @@
vm = API.VM(vmId)
return vm.updateDevice(params)
+def vmHotplugMemory(self, params):
+vm = API.VM(params['vmId'])
+return vm.hotplugMemory(params)
+
def vmSetNumberOfCpus(self, vmId, numberOfCpus):
vm = API.VM(vmId)
return vm.setNumberOfCpus(numberOfCpus)
@@ -1031,6 +1035,7 @@
(self.vmHotunplugNic, 'hotunplugNic'),
(self.vmUpdateDevice, 'vmUpdateDevice'),
(self.vmSetNumberOfCpus, 'setNumberOfCpus'),
+(self.vmHotplugMemory, 'hotplugMemory'),
(self.merge, 'merge'),
(self.vmUpdateVmPolicy, 'updateVmPolicy'),
(self.vmSetIoTune, 'setIoTune'),
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index cb149bc..d063e67 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -473,6 +473,7 @@
'VM_pause': {'ret': VM_running_state_change_Ret},
'VM_setCpuTunePeriod': {'ret': 'taskStatus'},
'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
+'VM_hotplugMemory': {'ret': 'vmList'},
'VM_setNumberOfCpus': {'ret': 'vmList'},
'VM_setIoTune': {'ret': 'taskStatus'},
'VM_updateDevice': {'ret': 'vmList'},
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index fa8f336..03f3cb0 100644
--- a/vdsm/rpc/v
Change in vdsm[master]: Hooks for Memory Hotplug
Omer Frenkel has uploaded a new change for review.
Change subject: Hooks for Memory Hotplug
..
Hooks for Memory Hotplug
This patch introduce vdsm hooks for memory hot plug.
the hooks will be called before and after memory hotplug is performed in
libvirt.
the hooks are used in a following patch that introduce memory hotplug
implementation.
http://www.ovirt.org/Features/Memory_Hotplug
Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Signed-off-by: Omer Frenkel
---
M debian/vdsm.dirs
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/vdsmd.8.in
M vdsm_hooks/Makefile.am
5 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/40548/1
diff --git a/debian/vdsm.dirs b/debian/vdsm.dirs
index 87703cd..4776f37 100644
--- a/debian/vdsm.dirs
+++ b/debian/vdsm.dirs
@@ -25,6 +25,7 @@
usr/libexec/vdsm/hooks/after_nic_hotunplug
usr/libexec/vdsm/hooks/after_nic_hotunplug_fail
usr/libexec/vdsm/hooks/after_set_num_of_cpus
+usr/libexec/vdsm/hooks/after_memory_hotplug
usr/libexec/vdsm/hooks/after_update_device
usr/libexec/vdsm/hooks/after_update_device_fail
usr/libexec/vdsm/hooks/after_vdsm_stop
@@ -50,6 +51,7 @@
usr/libexec/vdsm/hooks/before_nic_hotplug
usr/libexec/vdsm/hooks/before_nic_hotunplug
usr/libexec/vdsm/hooks/before_set_num_of_cpus
+usr/libexec/vdsm/hooks/before_memory_hotplug
usr/libexec/vdsm/hooks/before_update_device
usr/libexec/vdsm/hooks/before_vdsm_start
usr/libexec/vdsm/hooks/before_vm_cont
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 456a2d9..7f40c5a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1257,6 +1257,8 @@
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_network_setup
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_set_num_of_cpus
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_set_num_of_cpus
+%dir %{_libexecdir}/%{vdsm_name}/hooks/before_memory_hotplug
+%dir %{_libexecdir}/%{vdsm_name}/hooks/after_memory_hotplug
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_get_vm_stats
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_get_vm_stats
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_get_all_vm_stats
diff --git a/vdsm/hooks.py b/vdsm/hooks.py
index cedf2be..cb49859 100644
--- a/vdsm/hooks.py
+++ b/vdsm/hooks.py
@@ -323,6 +323,16 @@
params=params, raiseError=False)
+def before_memory_hotplug(domxml, vmconf={}, params={}):
+return _runHooksDir(domxml, 'before_memory_hotplug', vmconf=vmconf,
+params=params)
+
+
+def after_memory_hotplug(domxml, vmconf={}, params={}):
+return _runHooksDir(domxml, 'after_memory_hotplug', vmconf=vmconf,
+params=params, raiseError=False)
+
+
def before_vdsm_start():
return _runHooksDir(None, 'before_vdsm_start', raiseError=False)
diff --git a/vdsm/vdsmd.8.in b/vdsm/vdsmd.8.in
index f6e7158..0f5f5c1 100644
--- a/vdsm/vdsmd.8.in
+++ b/vdsm/vdsmd.8.in
@@ -61,7 +61,8 @@
before_set_num_of_cpus, after_set_num_of_cpus,
before_get_vm_stats, after_get_vm_stats,
before_get_all_vm_stats, after_get_all_vm_stats,
-before_get_caps, after_get_caps, after_hostdev_list_by_caps.
+before_get_caps, after_get_caps, after_hostdev_list_by_caps,
+before_memory_hotplug, after_memory_hotplug.
Each hook executes the scripts under
.FN /usr/libexec/vdsm/hooks//
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index 337284b..1971e75 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -125,6 +125,8 @@
before_get_caps \
after_get_caps \
after_hostdev_list_by_caps \
+ before_memory_hotplug \
+ after_memory_hotplug \
$(NULL)
all-local: \
--
To view, visit https://gerrit.ovirt.org/40548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add support for specifying vm maximum memory
Omer Frenkel has uploaded a new change for review.
Change subject: Add support for specifying vm maximum memory
..
Add support for specifying vm maximum memory
Added new parameter 'maxMemSize' to VM
this parameter is sent from engine backend and passed to libvirt xml
with the mandatory 'slots' attribute.
this parameter is mandatory for memory hotplug.
if this parameter is not passed, then it is not set in the libvirt xml,
and hotplug for this vm will not work.
Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Signed-off-by: Omer Frenkel
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vmxml.py
2 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/40547/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 0c73078..fa8f336 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3583,6 +3583,9 @@
#
# @numOfIoThreads:#optional The num of iothreads qemu allocates
#
+# @maxMemSize:The maximum amount of memory that can be assigned
+# to the VM in MB
+#
# Since: 4.10.0
##
{'type': 'VmDefinition',
@@ -3599,7 +3602,7 @@
'status': 'VmStatus', 'timeOffset': 'uint',
'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
'vmType': 'VmType', '*exitCode': 'int', '*exitMessage': 'str',
- '*serial': 'str', '*numOfIoThreads': 'uint'}}
+ '*serial': 'str', '*numOfIoThreads': 'uint', 'maxMemSize': 'uint'}}
##
# @VmParameters:
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index 02bbb52..ea5b34e 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -167,6 +167,10 @@
memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
self.dom.appendChildWithArgs('memory', text=memSizeKB)
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
+if 'maxMemSize' in self.conf:
+maxMemSizeKB = str(int(self.conf['maxMemSize']) * 1024)
+self.dom.appendChildWithArgs('maxMemory', text=maxMemSizeKB,
+ slots=self._getMaxVCpus())
vcpu = self.dom.appendChildWithArgs('vcpu', text=self._getMaxVCpus())
vcpu.setAttrs(**{'current': self._getSmp()})
--
To view, visit https://gerrit.ovirt.org/40547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54a698fbd45d6605f24b3641c541ff10a332d9f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: fix the Host.getVMList return value
Omer Frenkel has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified+1 please note that engine fix for this is posted: https://gerrit.ovirt.org/#/c/38271 i've tested this patch, without the engine fix, the meaning is ugly error in engine log, and engine will get updates for vms status change only on statistics cycle (getAllVmStats) and with the engine fix applied, this works well. -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: fix the Host.getVMList return value
Omer Frenkel has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: state change missing return value
Omer Frenkel has posted comments on this change. Change subject: vm: state change missing return value .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setNumberOfCpus marshalling issue
Omer Frenkel has posted comments on this change. Change subject: setNumberOfCpus marshalling issue .. Patch Set 2: Verified+1 i applied the patch locally, tried hot plug cpu with xml and then with json, both worked -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: setNumberOfCpus marshalling issue
Omer Frenkel has posted comments on this change. Change subject: setNumberOfCpus marshalling issue .. Patch Set 1: maybe remove from draft and get this in? i think we need it in 3.5 also if json is enabled there by default... -- To view, visit http://gerrit.ovirt.org/32414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refine calculation of cpu topology
Omer Frenkel has posted comments on this change. Change subject: refine calculation of cpu topology .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/30896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d71dfe98b67440c084b2a7bf8b292f6b9c3ae19 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Omer Frenkel has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Line 362: if not v:
Line 363: return errCode['noVM']
Line 364: stats = v.getStats().copy()
Line 365: if not stats:
Line 366: return errCode['down']
> I am not sure that this is the right response
from engine POV, if vdsm say vm is down, its down, and it can be run again.
if you are not sure, its better to return an error.
engine (now..) handles error in getVmStats by ignoring it, keeping old vm
state, and trying again on next monitoring cycle, so if this is a race, and on
next getVmStats vdsm will return the correct vm state, its better.
Line 367: stats['vmId'] = self._UUID
Line 368: return {'status': doneCode, 'statsList': [stats]}
Line 369:
Line 370: def hibernate(self, hibernationVolHandle):
--
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Omer Frenkel
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Expose a new argument for tunneled migration of a VM
Omer Frenkel has posted comments on this change. Change subject: Expose a new argument for tunneled migration of a VM .. Patch Set 4: Verified managed to migrate vm with tunnel option, used supporting engine and rest: http://gerrit.ovirt.org/#/c/11062 -- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Moti Asayag Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.2]: Integrate Smartcard support
Omer Frenkel has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 1: Verified; No score -- To view, visit http://gerrit.ovirt.org/10547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Tomas Jelinek ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.2]: Integrate Smartcard support
Omer Frenkel has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 1: Looks good to me, but someone else must approve verified by running a vm with smart card device and was able to see it with virsh (used supporting engine) -- To view, visit http://gerrit.ovirt.org/10547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Omer Frenkel Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Tomas Jelinek ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.2]: Integrate Smartcard support
Hello Tomas Jelinek, Antoni Segura Puimedon, Peter V. Saveliev,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/10547
to review the following change.
Change subject: Integrate Smartcard support
..
Integrate Smartcard support
This patch is a VDSM part of the integrating
the smartcard support to the ovirt:
This VDSM part integrates the smartcard in
a supported way, not just as an unsupported custom hook.
It also removes the smartcard hook itself.
Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b
Signed-off-by: Tomas Jelinek
Signed-off-by: Peter V. Saveliev
Signed-off-by: Antoni S. Puimedon
---
M configure.ac
M tests/libvirtvmTests.py
M vdsm.spec.in
M vdsm/libvirtvm.py
M vdsm/vm.py
M vdsm_api/vdsmapi-schema.json
M vdsm_hooks/Makefile.am
M vdsm_hooks/README
D vdsm_hooks/smartcard/Makefile.am
D vdsm_hooks/smartcard/README
D vdsm_hooks/smartcard/before_vm_start.py
11 files changed, 116 insertions(+), 77 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/10547/1
diff --git a/configure.ac b/configure.ac
index a6265b5..3489e38 100644
--- a/configure.ac
+++ b/configure.ac
@@ -209,7 +209,6 @@
vdsm_hooks/qos/Makefile
vdsm_hooks/qemucmdline/Makefile
vdsm_hooks/scratchpad/Makefile
- vdsm_hooks/smartcard/Makefile
vdsm_hooks/smbios/Makefile
vdsm_hooks/sriov/Makefile
vdsm_hooks/vhostmd/Makefile
diff --git a/tests/libvirtvmTests.py b/tests/libvirtvmTests.py
index 4ed7318..bd68f2a 100644
--- a/tests/libvirtvmTests.py
+++ b/tests/libvirtvmTests.py
@@ -91,6 +91,13 @@
domxml.appendOs()
self.assertXML(domxml.dom, xml, 'os')
+def testSmartcardXML(self):
+smartcardXML = ''
+dev = {'device': 'smartcard',
+ 'specParams': {'mode': 'passthrough', 'type': 'spicevmc'}}
+smartcard = libvirtvm.SmartCardDevice(self.conf, self.log, **dev)
+self.assertXML(smartcard.getXML(), smartcardXML)
+
def testFeaturesXML(self):
featuresXML = """
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 1978fa9..f9e238b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -353,14 +353,6 @@
the disk will be erased when the VM destroyed.
VM cannot be migrated when using scratchpad hook
-%package hook-smartcard
-Summary:Smartcard support for Spice protocol in VDSM
-BuildArch: noarch
-
-%description hook-smartcard
-Smartcard hook add support for spice in VDSM.
-Smartcard hook enable user to use its smartcard inside virtual machines.
-
%package hook-smbios
Summary:Adding custom smbios entries to libvirt domain via VDSM
BuildArch: noarch
@@ -886,10 +878,6 @@
%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_scratchpad
%{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_scratchpad
%{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_scratchpad
-
-%files hook-smartcard
-%defattr(-, root, root, -)
-%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_smartcard
%files hook-smbios
%defattr(-, root, root, -)
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 219e382..fe140ec 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1243,6 +1243,21 @@
return m
+class SmartCardDevice(LibvirtVmDevice):
+def getXML(self):
+"""
+Add smartcard section to domain xml
+
+
+
+
+"""
+card = self.createXmlElem(self.device, None, ['address'])
+card.setAttribute('mode', self.specParams['mode'])
+card.setAttribute('type', self.specParams['type'])
+return card
+
+
class RedirDevice(LibvirtVmDevice):
def getXML(self):
"""
@@ -1395,6 +1410,7 @@
self._getUnderlyingControllerDeviceInfo()
self._getUnderlyingBalloonDeviceInfo()
self._getUnderlyingWatchdogDeviceInfo()
+self._getUnderlyingSmartcardDeviceInfo()
# Obtain info of all unknown devices. Must be last!
self._getUnderlyingUnknownDeviceInfo()
@@ -1486,7 +1502,8 @@
vm.BALLOON_DEVICES: BalloonDevice,
vm.WATCHDOG_DEVICES: WatchdogDevice,
vm.REDIR_DEVICES: RedirDevice,
- vm.CONSOLE_DEVICES: ConsoleDevice}
+ vm.CONSOLE_DEVICES: ConsoleDevice,
+ vm.SMARTCARD_DEVICES: SmartCardDevice}
for devType, devClass in devMap.items():
for dev in devices[devType]:
@@ -2800,6 +2817,31 @@
dev['address'] = address
dev['alias'] = alias
+def _getUnderlyingSmartcardDeviceInfo(self):
+"""
+Obtain smartcard device info from libvirt.
+"""
+smartcardxml = _domParseStr(self._lastXMLDesc).childNodes[0].\
+getElementsByTagName('devices')[0].\
+getElementsByTagName('smartcard')
+for x in smartcardxml:
+if not
Change in vdsm[master]: Integrate Smartcard support
Omer Frenkel has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 22: Verified Rebased, verified: was able to start a vm with smart-card device, used engine that supports it as well, could see device created using virsh. -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cdaef420c8381d588f6215e66e6a80dd9d2e44b Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fenceNode API is missing the options argument
Omer Frenkel has posted comments on this change. Change subject: fenceNode API is missing the options argument .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
