Change in vdsm[master]: jsonrpcvdscli: add migrateStatus

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add migrateStatus
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: [wip] build: assumptions about the path do not work for 
distcheck
..


Patch Set 1:

Can you please rebase?

-- 
To view, visit https://gerrit.ovirt.org/52508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: automation: add a repo with a fresh nose

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1: Verified+1

Worked fine: 
http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-el7-x86_64/839/

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: bridge-utils are required for tests

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
..


Patch Set 1:

No magic automation I'm aware of.

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Obsolete actual vdsm-infra packages

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: Obsolete actual vdsm-infra packages
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a832fa02f0538ac9a22dfabfd291928ca4db7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Report the default gateway flag through caps

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: net: Report the default gateway flag through caps
..


Patch Set 13:

Chance that this patch will be merged soon? It's mentioned as required in 
https://gerrit.ovirt.org/#/c/58931/1/src/ovirt_hosted_engine_setup/vds_info.py 
and we're currently blocked on deploying hosted engine on Fedora 24.

-- 
To view, visit https://gerrit.ovirt.org/58351
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: fixing repos for standard ci

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: fixing repos for standard ci
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/62123/6/automation/check-patch.repos.el7
File automation/check-patch.repos.el7:

Line 1: 
ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
Line 2: 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
Line 3: 
centos-glusterfs,http://cbs.centos.org/repos/storage7-gluster-37-release/$basearch/os/
Line 4: 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
> http://cbs.centos.org/repos/virt7-ovirt-40-candidate/$basearch/os/
all vdsm deps and vdsm built: http://cbs.centos.org/koji/buildinfo?buildID=12038
Line 5: ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
Line 6: lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
Line 7: epel,http://download.fedoraproject.org/pub/epel/7/$basearch/


-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: fixing repos for standard ci

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: fixing repos for standard ci
..


Patch Set 6: -Code-Review

(3 comments)

https://gerrit.ovirt.org/#/c/62123/6/automation/check-patch.repos.el7
File automation/check-patch.repos.el7:

Line 1: 
ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
Line 2: 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
Line 3: 
centos-glusterfs,http://cbs.centos.org/repos/storage7-gluster-37-release/$basearch/os/
this should be gluster-38, need a rebase
Line 4: 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
Line 5: ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
Line 6: lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
Line 7: epel,http://download.fedoraproject.org/pub/epel/7/$basearch/


Line 1: 
ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
Line 2: 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
Line 3: 
centos-glusterfs,http://cbs.centos.org/repos/storage7-gluster-37-release/$basearch/os/
Line 4: 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
http://cbs.centos.org/repos/virt7-ovirt-40-candidate/$basearch/os/

we've almost finished to build all deps for ppc64le and aarch64, should be done 
by end of next week.
Line 5: ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
Line 6: lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
Line 7: epel,http://download.fedoraproject.org/pub/epel/7/$basearch/


Line 4: 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
Line 5: ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
Line 6: lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
Line 7: epel,http://download.fedoraproject.org/pub/epel/7/$basearch/
Line 8: centos-debuginfo,http://debuginfo.centos.org/7/x86_64/
do we really need debuginfo repo? can we drop it?


-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: bridge-utils are required for tests

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62612/1/vdsm.spec.in
File vdsm.spec.in:

Line 252
Line 253
Line 254
Line 255
Line 256
aren't these also needed at runtime?


-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: fix lago repo for fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: fix lago repo for fc24
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62248/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-08-11 15:44:16 +0200
Line 4: Commit: Sandro Bonazzola 
Line 5: CommitDate: 2016-08-11 15:44:16 +0200
Line 6: 
Line 7: automation: fix lago repo for fc24
> Can  you explain why this change is needed? why did we use fc23 before?
Because previously master was on fc23 and we didn't have a fc24 lago build?
Line 8: 
Line 9: Change-Id: Ie04335874206b7c0410534d2ac48317d954fffb4


-- 
To view, visit https://gerrit.ovirt.org/62248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04335874206b7c0410534d2ac48317d954fffb4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1:

merge?

-- 
To view, visit https://gerrit.ovirt.org/62268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Gil Shinar 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: fixing repos for standard ci

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: fixing repos for standard ci
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1: Verified+1

Users noticed the hook is missing: 
http://lists.ovirt.org/pipermail/users/2016-August/041794.html

-- 
To view, visit https://gerrit.ovirt.org/62268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Gil Shinar 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: build also vhostmd hook
..

automation: build also vhostmd hook

In 3.6 we shipped vdsm-hook-vhostmd as part of our VDSM releases.
In 4.0 this hook is missing from the build due to a bug in the
automation code which didn't configure the spec file for creating
the sub-package.

This patch address this regression, re-adding vdsm-hook-vhostmd to
the packages shipped within ovirt repos.

Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Signed-off-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/61984
Continuous-Integration: Jenkins CI
Reviewed-by: Gil Shinar 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Martin Polednik 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Nir Soffer 
(cherry picked from commit b9a2e7306e286708998d9035ffa08ffc9f26737c)
---
M automation/build-artifacts.sh
M automation/check-patch.sh
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/62268/1

diff --git a/automation/build-artifacts.sh b/automation/build-artifacts.sh
index 9576756..d81e2d7 100755
--- a/automation/build-artifacts.sh
+++ b/automation/build-artifacts.sh
@@ -10,7 +10,7 @@
 
 # autogen may already have been executed by check-patch.sh
 if [ ! -f Makefile ]; then
-  ./autogen.sh --system --enable-hooks
+  ./autogen.sh --system --enable-hooks --enable-vhostmd
 fi
 
 make
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 31007f3..02fc888 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -7,7 +7,7 @@
 easy_install pip
 pip install -U nose==1.3.7 tox==2.1.1
 
-./autogen.sh --system --enable-hooks
+./autogen.sh --system --enable-hooks --enable-vhostmd
 
 make check NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib"
 


-- 
To view, visit https://gerrit.ovirt.org/62268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: fix lago repo for fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: fix lago repo for fc24
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04335874206b7c0410534d2ac48317d954fffb4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: move glusterfs to 3.8

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move glusterfs to 3.8
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dac714919587dc6a1d82259a844672892bbe534
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 2:

so, 4 +1 have been collected, chance that someone add a +2 and merge?

-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Anton Marchukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gil Shinar 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: move glusterfs to 3.8

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: move glusterfs to 3.8
..

automation: move glusterfs to 3.8

Moving glusterfs to 3.8 since it's the default
for Fedora 24 and CentOS Storage SIG.

Issue: https://ovirt-jira.atlassian.net/browse/OVIRT-680
Change-Id: I7dac714919587dc6a1d82259a844672892bbe534
Signed-off-by: Sandro Bonazzola 
---
M automation/check-patch.repos.el7
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/62250/1

diff --git a/automation/check-patch.repos.el7 b/automation/check-patch.repos.el7
index d136062..7fe5fec 100644
--- a/automation/check-patch.repos.el7
+++ b/automation/check-patch.repos.el7
@@ -1,6 +1,6 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
-centos-glusterfs,http://mirror.centos.org/centos/7/storage/x86_64/gluster-3.7/
+centos-glusterfs,http://mirror.centos.org/centos/7/storage/x86_64/gluster-3.8/
 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro


-- 
To view, visit https://gerrit.ovirt.org/62250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dac714919587dc6a1d82259a844672892bbe534
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: fix lago repo for fc24

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: fix lago repo for fc24
..

automation: fix lago repo for fc24

Change-Id: Ie04335874206b7c0410534d2ac48317d954fffb4
Signed-off-by: Sandro Bonazzola 
---
M automation/check-patch.repos.fc24
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/62248/1

diff --git a/automation/check-patch.repos.fc24 
b/automation/check-patch.repos.fc24
index a5a6164..ae2bcb8 100644
--- a/automation/check-patch.repos.fc24
+++ b/automation/check-patch.repos.fc24
@@ -1,4 +1,4 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
-lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/fc23
+lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/fc24


-- 
To view, visit https://gerrit.ovirt.org/62248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie04335874206b7c0410534d2ac48317d954fffb4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: packaging: spec: update Url field

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: spec: update Url field
..

packaging: spec: update Url field

Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Signed-off-by: Sandro Bonazzola 
Reviewed-on: https://gerrit.ovirt.org/61883
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit 04b323f228925d6d4ae42f4655f5363f57121f74)
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/62245/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 8621ece..ecc70fc 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -55,7 +55,7 @@
 
 Group:  Applications/System
 License:GPLv2+
-Url:http://www.ovirt.org/wiki/Vdsm
+Url:http://www.ovirt.org/develop/developer-guide/vdsm/vdsm/
 Source0:%{vdsm_name}-%{version}.tar.gz
 BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 


-- 
To view, visit https://gerrit.ovirt.org/62245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: packaging: spec: update Url field

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: packaging: spec: update Url field
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: changing repos to be multi arch and support ppc64le

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: changing repos to be multi arch and support ppc64le
..


Patch Set 1: -Code-Review

(2 comments)

https://gerrit.ovirt.org/#/c/62123/1/automation/check-patch.repos.el7
File automation/check-patch.repos.el7:

PS1, Line 4: candidate
> @danken, @fromani - this repo doesn't exists for ppc64le.
I'm working with CentOS guy to get it there by bug 
https://bugs.centos.org/view.php?id=11222


PS1, Line 8: http://debuginfo.centos.org/7/$basearch/
> @sandro - we have an open ticket for centos for this right?
yes, see https://bugs.centos.org/view.php?id=11279


-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: changing repos to be multi arch and support ppc64le

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: changing repos to be multi arch and support ppc64le
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Ben Haim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/61984/1//COMMIT_MSG
Commit Message:

Line 4: Commit: Sandro Bonazzola 
Line 5: CommitDate: 2016-08-05 16:12:48 +0200
Line 6: 
Line 7: automation: build also vhostmd hook
Line 8: 
> Please add more info about why it is needed.
ok
Line 9: Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb


-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Anton Marchukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gil Shinar 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: packaging: spec: drop default defattr

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: packaging: spec: drop default defattr
..


Patch Set 4:

Guys, 2 weeks for reviewing this patch? Seriously?

-- 
To view, visit https://gerrit.ovirt.org/61384
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a86bb5ebe09aa4ae273f44bf5230b60790e9225
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1:

Michal, if it's not working for ppc64le it should be dropped at spec level, not 
at automation.

-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Anton Marchukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gil Shinar 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: use 3.6 repos
..


Patch Set 1:

any other review? can we have this merged so jenkins stop failing?

-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: use 4.0 repos
..


Patch Set 1:

any other review? can we have this merged so jenkins stop failing?

-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: build also vhostmd hook
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: build also vhostmd hook

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: build also vhostmd hook
..

automation: build also vhostmd hook

Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Signed-off-by: Sandro Bonazzola 
---
M automation/build-artifacts.sh
M automation/check-patch.sh
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/61984/1

diff --git a/automation/build-artifacts.sh b/automation/build-artifacts.sh
index 9576756..d81e2d7 100755
--- a/automation/build-artifacts.sh
+++ b/automation/build-artifacts.sh
@@ -10,7 +10,7 @@
 
 # autogen may already have been executed by check-patch.sh
 if [ ! -f Makefile ]; then
-  ./autogen.sh --system --enable-hooks
+  ./autogen.sh --system --enable-hooks --enable-vhostmd
 fi
 
 make
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 5f37792..383fbc3 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -7,7 +7,7 @@
 easy_install pip
 pip install -U nose==1.3.7 tox==2.1.1
 
-./autogen.sh --system --enable-hooks
+./autogen.sh --system --enable-hooks --enable-vhostmd
 
 debuginfo-install -y python
 


-- 
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: use 3.6 repos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: use 3.6 repos
..

automation: use 3.6 repos

Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Signed-off-by: Sandro Bonazzola 
---
M automation/build-artifacts.repos.fc23
M automation/check-patch.repos.fc23
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/61970/1

diff --git a/automation/build-artifacts.repos.fc23 
b/automation/build-artifacts.repos.fc23
index c169fde..dc9188b 100644
--- a/automation/build-artifacts.repos.fc23
+++ b/automation/build-artifacts.repos.fc23
@@ -1 +1 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro
diff --git a/automation/check-patch.repos.fc23 
b/automation/check-patch.repos.fc23
index c02ee8e..addb75e 100644
--- a/automation/check-patch.repos.fc23
+++ b/automation/check-patch.repos.fc23
@@ -1,2 +1,2 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-3.6-snapshot/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-3.6-snapshot-static/rpm/$distro


-- 
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: use 4.0 repos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: use 4.0 repos
..

automation: use 4.0 repos

Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Signed-off-by: Sandro Bonazzola 
---
M automation/check-patch.repos.el7
M automation/check-patch.repos.fc23
M automation/reposync-config.repo.tpl
3 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/61969/1

diff --git a/automation/check-patch.repos.el7 b/automation/check-patch.repos.el7
index 0f388a1..614506b 100644
--- a/automation/check-patch.repos.el7
+++ b/automation/check-patch.repos.el7
@@ -1,5 +1,5 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-4.0-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-4.0-snapshot-static/rpm/$distro
 centos-glusterfs,http://mirror.centos.org/centos/7/storage/x86_64/gluster-3.7/
 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
diff --git a/automation/check-patch.repos.fc23 
b/automation/check-patch.repos.fc23
index e516ed6..1cd44cf 100644
--- a/automation/check-patch.repos.fc23
+++ b/automation/check-patch.repos.fc23
@@ -1,4 +1,4 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-4.0-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-4.0-snapshot-static/rpm/$distro
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
diff --git a/automation/reposync-config.repo.tpl 
b/automation/reposync-config.repo.tpl
index d6172d7..e7e40e9 100644
--- a/automation/reposync-config.repo.tpl
+++ b/automation/reposync-config.repo.tpl
@@ -7,16 +7,16 @@
 enabled=1
 gpgcheck=0
 
-[ovirt-master-snapshot-fc23]
+[ovirt-4.0-snapshot-fc23]
 name=oVirt Master Nightly Test Releases
-baseurl=http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/fc23/
+baseurl=http://resources.ovirt.org/pub/ovirt-4.0-snapshot/rpm/fc23/
 exclude=vdsm-* ovirt-node-* *-debuginfo ovirt-engine-appliance ovirt*engine* 
*win* *jboss*
 enabled=0
 gpgcheck=0
 
-[ovirt-master-snapshot-static-fc23]
+[ovirt-4.0-snapshot-static-fc23]
 name=oVirt Master Nightly Statics
-baseurl=http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/fc23/
+baseurl=http://resources.ovirt.org/pub/ovirt-4.0-snapshot-static/rpm/fc23/
 exclude=jasperreports-server ovirt-guest-tools-iso ovirt-engine-jboss-as 
*wildfly*
 enabled=0
 gpgcheck=0


-- 
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: packaging: spec: update Url field

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: packaging: spec: update Url field
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/61883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: packaging: spec: update Url field

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: spec: update Url field
..

packaging: spec: update Url field

Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Signed-off-by: Sandro Bonazzola 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/61883/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 1bc718b..af59b65 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -55,7 +55,7 @@
 
 Group:  Applications/System
 License:GPLv2+
-Url:http://www.ovirt.org/wiki/Vdsm
+Url:http://www.ovirt.org/develop/developer-guide/vdsm/vdsm/
 Source0:%{vdsm_name}-%{version}.tar.gz
 BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 


-- 
To view, visit https://gerrit.ovirt.org/61883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: packaging: spec: drop default defattr

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: spec: drop default defattr
..

packaging: spec: drop default defattr

Dropping default defattr, not needed since EPEL 6.
Part of Fedora 24 spec file change:
  commit 36ee23731c8bac6f426688ecfa57f41b09003383
  Author: Dennis Gilmore 
  Date:   Fri Mar 11 15:18:50 2016 -0600

Change-Id: I2a86bb5ebe09aa4ae273f44bf5230b60790e9225
Signed-off-by: Sandro Bonazzola 
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/61384/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index dba1f33..8bcb694 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -898,7 +898,6 @@
 exit 0
 
 %files
-%defattr(-, root, root, -)
 %doc README lib/vdsm/vdsm.conf.sample
 %license COPYING
 /usr/lib/systemd/systemd-vdsmd
@@ -1133,7 +1132,6 @@
 %{_datadir}/%{vdsm_name}/bonding-name2numeric.json
 
 %files python
-%defattr(-, root, root, -)
 %{_mandir}/man1/vdsm-tool.1*
 %{_bindir}/vdsm-tool
 %dir %{python_sitelib}/%{vdsm_name}
@@ -1310,7 +1308,6 @@
 
 %files tests
 %doc %{_datadir}/%{vdsm_name}/tests/README
-%defattr(-, root, root, -)
 %dir %{_datadir}/%{vdsm_name}
 %dir %{_datadir}/%{vdsm_name}/tests
 %dir %{_datadir}/%{vdsm_name}/tests/common
@@ -1379,7 +1376,6 @@
 %{_datadir}/%{vdsm_name}/tests/integration/*.py*
 
 %files hook-openstacknet
-%defattr(-, root, root, -)
 %{_sysconfdir}/sudoers.d/50_vdsm_hook_openstacknet
 %{_libexecdir}/%{vdsm_name}/hooks/after_device_create/50_openstacknet
 %{_libexecdir}/%{vdsm_name}/hooks/after_device_create/openstacknet_utils.py*
@@ -1401,7 +1397,6 @@
 %{_libexecdir}/%{vdsm_name}/hooks/before_nic_hotplug/openstacknet_utils.py*
 
 %files hook-ovs
-%defattr(-, root, root, -)
 %{_sysconfdir}/sudoers.d/50_vdsm_hook_ovs
 %{_libexecdir}/%{vdsm_name}/ovs_migrate.py*
 %{_libexecdir}/%{vdsm_name}/ovs_utils.py*
@@ -1425,14 +1420,12 @@
 %{_libexecdir}/%{vdsm_name}/hooks/after_network_setup_fail/ovs_utils.py*
 
 %files hook-macspoof
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_macspoof
 %{_libexecdir}/%{vdsm_name}/hooks/before_device_create/50_macspoof
 %{_libexecdir}/%{vdsm_name}/hooks/before_nic_hotplug/50_macspoof
 
 %if 0%{?with_vhostmd}
 %files hook-vhostmd
-%defattr(-, root, root, -)
 %license COPYING
 %{_sysconfdir}/sudoers.d/50_vdsm_hook_vhostmd
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_vhostmd
@@ -1448,156 +1441,124 @@
 %endif
 
 %files hook-qemucmdline
-%defattr(-, root, root, -)
 %license COPYING
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_qemucmdline
 
 %files hook-ethtool-options
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/after_network_setup/30_ethtool_options
 
 %files hook-ipv6
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_network_setup/50_ipv6
 
 %files hook-vmfex-dev
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_device_create/50_vmfex
 %{_libexecdir}/%{vdsm_name}/hooks/before_device_migrate_destination/50_vmfex
 %{_libexecdir}/%{vdsm_name}/hooks/before_nic_hotplug/50_vmfex
 
 %if 0%{?with_hooks}
 %files hook-allocate_net
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_device_create/10_allocate_net
 
 %files hook-checkimages
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/60_checkimages
 
 %files hook-fcoe
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_network_setup/50_fcoe
 
 %files hook-checkips
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/after_get_stats/10_checkips
 %{_libexecdir}/%{vdsm_name}/hooks/checkipsd
 %{_libexecdir}/%{vdsm_name}/hooks/after_get_stats/checkips_utils.py*
 %{_unitdir}/vdsm-checkips.service
 
 %files hook-extra-ipv4-addrs
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/after_network_setup/40_extra_ipv4_addrs
 
 %files hook-diskunmap
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_diskunmap
 
 %files hook-fakevmstats
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/after_get_all_vm_stats/10_fakevmstats
 
 %files hook-fakesriov
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/after_hostdev_list_by_caps/10_fakesriov
 %{_libexecdir}/%{vdsm_name}/hooks/after_get_caps/10_fakesriov
 
 %files hook-fileinject
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_fileinject
 
 %files hook-floppy
-%defattr(-, root, root, -)
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_floppy
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_floppy
 
 %files hook-hostusb
-%defattr(-, root, root, -)
 %{_sysconfdir}/sudoers.d/50_vdsm_hook_hostusb
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_hostusb
 %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_source/50_hostusb
 

Change in vdsm[ovirt-4.0]: automation: move master to fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move master to fc24
..


Patch Set 2:

my mistake then, fixing 4.0 branch to not use fc24.
you can abandon this patch.

-- 
To view, visit https://gerrit.ovirt.org/60852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: move master to fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move master to fc24
..


Patch Set 2:

What's the issue that suggested to backport this patch?

-- 
To view, visit https://gerrit.ovirt.org/60852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: move master to fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move master to fc24
..


Patch Set 2: Code-Review-1

For 4.0 we still need to build for fc23.

-- 
To view, visit https://gerrit.ovirt.org/60852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: move master to fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move master to fc24
..


Patch Set 2:

It's a matter of jenkins resources, there's not enough to keep building more 
than one fedora release per ovirt branch. And fedora 23 will be EOL for 4.1 GA.

-- 
To view, visit https://gerrit.ovirt.org/60725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: move master to fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move master to fc24
..


Patch Set 2: Verified+1

build works: 
http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-fc24-x86_64/6/console

-- 
To view, visit https://gerrit.ovirt.org/60725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: move master to fc24

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: move master to fc24
..


Patch Set 2:

Removed fc23 duplication since fc23 is not supported anymore on master.

-- 
To view, visit https://gerrit.ovirt.org/60725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: make client user aware that no connection available

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: stomp: make client user aware that no connection available
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0a2b2df9ac6e9f6e75a8af0f0f3a36990c2462
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: add fc24

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: add fc24
..

automation: add fc24

Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Signed-off-by: Sandro Bonazzola 
---
A automation/build-artifacts.packages.fc24
A automation/build-artifacts.repos.fc24
A automation/check-merged.packages.fc24
A automation/check-merged.repos.fc24
A automation/check-patch.packages.fc24
A automation/check-patch.repos.fc24
6 files changed, 73 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/60725/1

diff --git a/automation/build-artifacts.packages.fc24 
b/automation/build-artifacts.packages.fc24
new file mode 12
index 000..c5e146e
--- /dev/null
+++ b/automation/build-artifacts.packages.fc24
@@ -0,0 +1 @@
+check-merged.packages.fc24
\ No newline at end of file
diff --git a/automation/build-artifacts.repos.fc24 
b/automation/build-artifacts.repos.fc24
new file mode 12
index 000..0654839
--- /dev/null
+++ b/automation/build-artifacts.repos.fc24
@@ -0,0 +1 @@
+check-merged.repos.fc24
\ No newline at end of file
diff --git a/automation/check-merged.packages.fc24 
b/automation/check-merged.packages.fc24
new file mode 100644
index 000..4c8d12b
--- /dev/null
+++ b/automation/check-merged.packages.fc24
@@ -0,0 +1,35 @@
+autoconf
+automake
+git
+lago
+lago-ovirt
+libguestfs-tools-c
+libselinux-python3
+libvirt-python3
+m2crypto
+make
+mom
+openvswitch
+policycoreutils-python
+PyYAML
+python-blivet
+python-coverage
+python-devel
+python-inotify
+python-ioprocess
+python-mock
+python-netaddr
+python-nose
+python-pthreading
+python-rtslib
+python-six
+python3-netaddr
+python3-nose
+python3-six
+python3-yaml
+rpm-build
+sudo
+yum
+yum-utils
+# Needed by lago
+grubby
diff --git a/automation/check-merged.repos.fc24 
b/automation/check-merged.repos.fc24
new file mode 12
index 000..4b50a83
--- /dev/null
+++ b/automation/check-merged.repos.fc24
@@ -0,0 +1 @@
+check-patch.repos.fc24
\ No newline at end of file
diff --git a/automation/check-patch.packages.fc24 
b/automation/check-patch.packages.fc24
new file mode 100644
index 000..11b8154
--- /dev/null
+++ b/automation/check-patch.packages.fc24
@@ -0,0 +1,31 @@
+autoconf
+automake
+gdb
+git
+libguestfs-tools-c
+libselinux-python3
+libvirt-python3
+m2crypto
+make
+mom
+openvswitch
+policycoreutils-python
+PyYAML
+python-blivet
+python-coverage
+python-devel
+python-inotify
+python-ioprocess
+python-mock
+python-netaddr
+python-nose
+python-pthreading
+python-six
+python3-netaddr
+python3-nose
+python3-six
+python3-yaml
+rpm-build
+sudo
+yum
+yum-utils
diff --git a/automation/check-patch.repos.fc24 
b/automation/check-patch.repos.fc24
new file mode 100644
index 000..92bcace
--- /dev/null
+++ b/automation/check-patch.repos.fc24
@@ -0,0 +1,4 @@
+ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
+ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
+ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
+lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro


-- 
To view, visit https://gerrit.ovirt.org/60725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: getAllImages: Use manifest attributes when constructing glob 
pattern
..


Patch Set 3:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/49684
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e69d3096a1b4c20dcee33e96c8a7bdd1b8dcaa9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add additional verbs
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9c63a05d8354676e68418b08593ea830b42a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: readme: Simplify installation instructions

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: readme: Simplify installation instructions
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/48713/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: readme: Simplify installation instructions
Line 8: 
Line 9: We need to run ./autogen.sh, and configure is not needed usually, no
Line 10: need to make it look more complex then it is.
then -> than
Line 11: 
Line 12: The --force flag is a good idea in the first run, and it is better to
Line 13: show how to get more help than to duplicate the help in the readme.
Line 14: 


https://gerrit.ovirt.org/#/c/48713/1/README
File README:

Line 19: The Vdsm service can be used by following the standard autotools
Line 20: installation process, documented in the INSTALL file. As a quick
Line 21: start you can do
Line 22: 
Line 23:./autogen.sh --system
> So the current instaructions are good for users, and my version is for deve
> So the current instaructions are good for users, and my version is for 
> developers?


current instructions are good for those who download the released tarball and 
build from it. Your version is good for those who clone git repo and build from 
it.


> Do you think we should keep both in the readme, or only the user version?


I think you can keep both of them.
Line 24:make
Line 25:sudo make install
Line 26: 
Line 27: In order to start vdsm at first time, please perform:


-- 
To view, visit https://gerrit.ovirt.org/48713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I868a3de7991af5d9f39e9e489bf23587b13b1e58
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: code coverage: add coverage for supervdsmServer
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57735
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee3e6f3cc4838c676cef67e24f43d99dffe2ec3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: update glusterfs repos

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: update glusterfs repos
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29fc6b719a00ab5961df976df77e3a5071125975
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Anton Marchukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin 
Gerrit-Reviewer: Niels de Vos 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: update glusterfs repos

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: update glusterfs repos
..

automation: update glusterfs repos

- dropped Gluster community repo for Fedora23 (reposync included):
  the repo is empty and Gluster community is maintaining
  Fedora packages within Fedora repositories.
  For reference:
  
http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/What_About_Fedora_23.README
- on EL7 moved from Gluster community repo to CentOS
  Storage SIG repositories: we've been advised by Gluster community that
  their packaging effort is focused on CentOS Storage SIG
  and CentOS infrastructure is more reliable.

Change-Id: I29fc6b719a00ab5961df976df77e3a5071125975
Signed-off-by: Sandro Bonazzola 
---
M automation/check-patch.repos.el7
M automation/check-patch.repos.fc23
M automation/reposync-config.repo.tpl
3 files changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/56813/1

diff --git a/automation/check-patch.repos.el7 b/automation/check-patch.repos.el7
index 4e0b337..30e2ed2 100644
--- a/automation/check-patch.repos.el7
+++ b/automation/check-patch.repos.el7
@@ -1,6 +1,6 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
-ovirt-glusterfs-epel,http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-7/x86_64
+centos-glusterfs,http://mirror.centos.org/centos/7/storage/x86_64/gluster-3.7/
 
centos-ovirt40-candidate,http://cbs.centos.org/repos/virt7-ovirt-40-candidate/x86_64/os/
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
 epel,http://download.fedoraproject.org/pub/epel/7/x86_64
diff --git a/automation/check-patch.repos.fc23 
b/automation/check-patch.repos.fc23
index 9360e39..0b9c821 100644
--- a/automation/check-patch.repos.fc23
+++ b/automation/check-patch.repos.fc23
@@ -1,4 +1,3 @@
 ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
 
ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
-ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-23/x86_64
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
diff --git a/automation/reposync-config.repo.tpl 
b/automation/reposync-config.repo.tpl
index f35de03..d6172d7 100644
--- a/automation/reposync-config.repo.tpl
+++ b/automation/reposync-config.repo.tpl
@@ -20,9 +20,3 @@
 exclude=jasperreports-server ovirt-guest-tools-iso ovirt-engine-jboss-as 
*wildfly*
 enabled=0
 gpgcheck=0
-
-[glusterfs-fc23]
-name=GlusterFS repo
-baseurl=http://download.gluster.org/pub/gluster/glusterfs/nightly/glusterfs/fedora-23-x86_64/
-enabled=1
-gpgcheck=0


-- 
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29fc6b719a00ab5961df976df77e3a5071125975
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: client: do not protect requests on client side

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: client: do not protect requests on client side
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: client: do not protect requests on client side

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: client: do not protect requests on client side
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: Run make check over el7 in automation CI

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: Run make check over el7 in automation CI
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabbb09920de316a4e26447a0ca77ba9f30e517cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: remove model_tests.py form py3 tests

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: tests: remove model_tests.py form py3 tests
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44fc7e80fc01efe154c678aa1fc967314a090a33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: Use mock module for testing

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: test: Use mock module for testing
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/55342/7/tests/network/netswitch_test.py
File tests/network/netswitch_test.py:

Line 23: from nose.plugins.attrib import attr
Line 24: 
Line 25: from vdsm.network import netswitch
Line 26: 
Line 27: from testlib import mock
why do indirect import?
just replace above with:

 try:
 from unittest import mock
 except ImportError:  # py2
 import mock
Line 28: from testlib import VdsmTestCase
Line 29: 
Line 30: 
Line 31: @attr(type='unit')


https://gerrit.ovirt.org/#/c/55342/7/tests/testlib.py
File tests/testlib.py:

Line 38: try:
Line 39: from unittest import mock
Line 40: except ImportError:  # py2
Line 41: import mock
Line 42: mock
why do you import mock here if it's not needed?
Line 43: 
Line 44: from nose import config
Line 45: from nose import core
Line 46: from nose import result


-- 
To view, visit https://gerrit.ovirt.org/55342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

> not sure why they are defined as required on API.py level.

@Piotr are you going to fix API to make them optional?

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpc: set default timeout value

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpc: set default timeout value
..


Patch Set 2:

merge?

-- 
To view, visit https://gerrit.ovirt.org/55397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a8fd964fec20621cf4c13df49719b9a242854c1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: require python3 packages on fedora23

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: require python3 packages on fedora23
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4285a563891705c277e2d7e634e758da8e981b0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpc: set default timeout value

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpc: set default timeout value
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a8fd964fec20621cf4c13df49719b9a242854c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1: Verified-1

[ ERROR ] Failed to execute stage 'Misc configuration': Attempt to call 
function: > with arguments: (u'e37bf754-e0f3-4515-98b9-4e8b4572f33b', 
u'hosted_datacenter', u'b6fce4d5-f142-4e61-89c9-dd80c5930e7c', 
[u'b6fce4d5-f142-4e61-89c9-dd80c5930e7c', 
u'5d6d70e5-34ab-4654-8880-7297bab5b8e4'], 1) error: create() takes exactly 9 
arguments (6 given)

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add storage verbs
..


Patch Set 1:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 131, in 
_executeMethod
method['method']()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 1283, in _misc
self._createStorageDomain()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 857, in _createStorageDomain
raise RuntimeError(status['status']['message'])
RuntimeError: Invalid parameter: 'sdUUID=1


jsonrpc.Executor/4::INFO::2016-03-25 
16:54:55,132::logUtils::49::dispatcher::(wrapper) Run and protect: 
createStorageDomain(storageType=u'5d6d70e5-34ab-4654-8880-7297bab5b8e4', 
sdUUID=1, domainName=u'mididell.ho
me:/home/sata', typeSpecificArg=u'hosted_storage', domClass=1, domVersion=3, 
options=None)
jsonrpc.Executor/4::ERROR::2016-03-25 
16:54:55,133::task::868::Storage.TaskManager.Task::(_setError) 
Task=`c56872b6-90fb-4859-bdec-3373f2355176`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 875, in _run
return fn(*args, **kargs)
  File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 50, in wrapper
res = f(*args, **kwargs)
  File "/usr/share/vdsm/storage/hsm.py", line 2641, in createStorageDomain
misc.validateUUID(sdUUID, 'sdUUID')
  File "/usr/share/vdsm/storage/misc.py", line 430, in validateUUID
raise se.InvalidParameterException(name, uuid)
InvalidParameterException: Invalid parameter: 'sdUUID=1'
jsonrpc.Executor/4::DEBUG::2016-03-25 
16:54:55,133::task::887::Storage.TaskManager.Task::(_run) 
Task=`c56872b6-90fb-4859-bdec-3373f2355176`::Task._run: 
c56872b6-90fb-4859-bdec-3373f2355176 (u'5d6d70e5-34ab-4654-
8880-7297bab5b8e4', 1, u'mididell.home:/home/sata', u'hosted_storage', 1, 3) {} 
failed - stopping task


Looks again that vdscli and jsonrpcvdscli use different arguments ordering.

-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: add storage verbs
..

jsonrpcvdscli: add storage verbs

Add verbs used by ovirt-hosted-engine-setup for
handling the storage setup.

Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 27 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/55252/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 918b361..11738a2 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -39,18 +39,39 @@
 
 
 _COMMAND_CONVERTER = {
+'activateStorageDomain': 'StorageDomain.activate',
+'connectStoragePool': 'StoragePool.connect',
 'connectStorageServer': 'StoragePool.connectStorageServer',
 'create': 'VM.create',
+'createStorageDomain': 'StorageDomain.create',
+'createStoragePool': 'StoragePool.create',
+'createVG': 'LVMVolumeGroup.create',
 'destroy': 'VM.destroy',
+'destroyStoragePool': 'StoragePool.destroy',
+'detachStorageDomain': 'StorageDomain.detach',
+'disconnectStoragePool': 'StoragePool.disconnect',
 'disconnectStorageServer': 'StoragePool.disconnectStorageServer',
+'discoverSendTargets': 'ISCSIConnection.discoverSendTargets',
+'formatStorageDomain': 'StorageDomain.format',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
+'getDeviceList': 'Host.getDeviceList',
+'getStorageDomainInfo': 'StorageDomain.getInfo',
 'getStorageDomainsList': 'Host.getStorageDomains',
+'getStorageDomainStats': 'StorageDomain.getStats',
+'getStoragePoolInfo': 'StoragePool.getInfo',
+'getSpmStatus': 'StoragePool.getSpmStatus',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',
+'getVGInfo': 'LVMVolumeGroup.getInfo',
 'getVmStats': 'VM.getStats',
+'glusterVolumeCreate': 'GlusterVolume.create',
+'glusterVolumeSet': 'GlusterVolume.set',
+'glusterVolumesList': 'GlusterVolume.list',
+'glusterVolumeStart': 'GlusterVolume.start',
+'glusterTasksList': 'GlusterTask.list',
 'hotplugDisk': 'VM.hotplugDisk',
 'hotplugNic': 'VM.hotplugNic',
 'hotunplugDisk': 'VM.hotunplugDisk',
@@ -58,13 +79,19 @@
 'list': 'Host.getVMList',
 'migrationCreate': 'VM.migrationCreate',
 'ping': 'Host.ping',
+'repoStats': 'Host.getStorageRepoStats',
 'setBalloonTarget': 'VM.setBalloonTarget',
 'setCpuTunePeriod': 'VM.setCpuTunePeriod',
 'setCpuTuneQuota': 'VM.setCpuTuneQuota',
 'setMOMPolicy': 'Host.setMOMPolicy',
 'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
 'setupNetworks': 'Host.setupNetworks',
+'spmStart': 'StoragePool.spmStart',
+'spmStop': 'StoragePool.spmStop',
+'startMonitoringDomain': 'Host.startMonitoringDomain',
+'stopMonitoringDomain': 'Host.stopMonitoringDomain',
 'updateVmPolicy': 'VM.updateVmPolicy',
+'validateStorageDomain': 'StorageDomain.validate',
 }
 
 


-- 
To view, visit https://gerrit.ovirt.org/55252
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: disconnectStorageServer verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: disconnectStorageServer verb
..

jsonrpcvdscli: disconnectStorageServer verb

Add disconnectStorageServer used by ovirt-hoste-engine-setup.

Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/55250/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index af0e9d6..918b361 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -42,6 +42,7 @@
 'connectStorageServer': 'StoragePool.connectStorageServer',
 'create': 'VM.create',
 'destroy': 'VM.destroy',
+'disconnectStorageServer': 'StoragePool.disconnectStorageServer',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',


-- 
To view, visit https://gerrit.ovirt.org/55250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getStorageDomainsList verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: getStorageDomainsList verb
..

jsonrpcvdscli: getStorageDomainsList verb

Add getStorageDomainsList used by ovirt-hoste-engine-setup.

Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/55249/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 88e2cf5..af0e9d6 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -45,6 +45,7 @@
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
+'getStorageDomainsList': 'Host.getStorageDomains',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',


-- 
To view, visit https://gerrit.ovirt.org/55249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83012b2081c51f29b9a3da7b57fe6203c95d18d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Verified+1

Changed order between spUUID and type in the call and it worked.
Note that vdscli and jsonrpcvdscli are using different ordering.

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Verified-1

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: connectStorageServer verb
..


Patch Set 1: Verified+1

Arguments as in xmlrpc call are: arguments: (1, 
'----', [{'protocol_version': 3, 'connection': 
'mididell.home:/home/sata', 'user': 'kvm', 'id': 
'c0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}])


Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 131, in 
_executeMethod
method['method']()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 1267, in _late_customization
self._getExistingDomain()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 602, in _getExistingDomain
self._storageServerConnection()
  File 
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
 line 788, in _storageServerConnection
raise RuntimeError(status['status']['message'])
RuntimeError: Error storage server connection: 
(u"domType=----, spUUID=1, 
conList=[{u'protocol_version': 3, u'connection': u'mididell.home:/home/sata', 
u'user': u'kvm', u'id': u'c
0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}]",)


jsonrpc.Executor/4::INFO::2016-03-25 
14:49:20,087::logUtils::49::dispatcher::(wrapper) Run and protect: 
connectStorageServer(domType=u'----', spUUID=1, 
conList=[{u'protocol_version': 3, u'connection': u'mididell.home:/home/sata', 
u'user': u'kvm', u'id': u'c0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}], options=None)
jsonrpc.Executor/4::ERROR::2016-03-25 
14:49:20,087::task::868::Storage.TaskManager.Task::(_setError) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 875, in _run
return fn(*args, **kargs)
  File "/usr/lib/python2.7/site-packages/vdsm/logUtils.py", line 50, in wrapper
res = f(*args, **kwargs)
  File "/usr/share/vdsm/storage/hsm.py", line 2423, in connectStorageServer
conInfo = _connectionDict2ConnectionInfo(domType, conDef)
  File "/usr/share/vdsm/storage/hsm.py", line 193, in 
_connectionDict2ConnectionInfo
typeName = CON_TYPE_ID_2_CON_TYPE[conTypeId]
KeyError: u'----'
jsonrpc.Executor/4::DEBUG::2016-03-25 
14:49:20,087::task::887::Storage.TaskManager.Task::(_run) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::Task._run: 
81ff52b6-75f7-4996-a989-6d70a0937fd5 (u'----', 
1, [{u'protocol_version': 3, u'connection': u'mididell.home:/home/sata', 
u'user': u'kvm', u'id': u'c0fa7e2f-8b36-41c2-abac-6b8999b7c5d3'}]) {} failed - 
stopping task
jsonrpc.Executor/4::DEBUG::2016-03-25 
14:49:20,087::task::1248::Storage.TaskManager.Task::(stop) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::stopping in state preparing (force 
False)
jsonrpc.Executor/4::DEBUG::2016-03-25 
14:49:20,087::task::995::Storage.TaskManager.Task::(_decref) 
Task=`81ff52b6-75f7-4996-a989-6d70a0937fd5`::ref 1 aborting True

-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: connectStorageServer verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: connectStorageServer verb
..

jsonrpcvdscli: connectStorageServer verb

Add connectStorageServer used by ovirt-hoste-engine-setup.

Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/55247/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 6ad330a..88e2cf5 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -39,6 +39,7 @@
 
 
 _COMMAND_CONVERTER = {
+'connectStorageServer': 'StoragePool.connectStorageServer',
 'create': 'VM.create',
 'destroy': 'VM.destroy',
 'fullList': 'Host.getVMFullList',


-- 
To view, visit https://gerrit.ovirt.org/55247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b732f505b9c64c7403f05f5c2fc026a20f30a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: getConnectedStoragePoolsList verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: getConnectedStoragePoolsList verb
..

jsonrpcvdscli: getConnectedStoragePoolsList verb

Add getConnectedStoragePoolsList used by ovirt-hoste-engine-setup.

Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/55246/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 919e4bf..6ad330a 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -43,6 +43,7 @@
 'destroy': 'VM.destroy',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
+'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',


-- 
To view, visit https://gerrit.ovirt.org/55246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa1f4cf11c86e9b93adc77c6945045d87adc0e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..

jsonrpcvdscli: add getVdsHardwareInfo verb

Add getVdsHardwareInfo used by ovirt-hoste-engine-setup.

Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Related-To: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/55244/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index ada5ff5..919e4bf 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -44,6 +44,7 @@
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
 'getVdsCapabilities': 'Host.getCapabilities',
+'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',
 'getVmStats': 'VM.getStats',
 'hotplugDisk': 'VM.hotplugDisk',


-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jsonrpcvdscli: add getVdsHardwareInfo verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: jsonrpcvdscli: add getVdsHardwareInfo verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2f564147e53e0fe9bf51ae0279ee467347f305
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: createImageLinks: recreate if the link exists but it's broken

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: createImageLinks: recreate if the link exists but it's broken
..


Patch Set 7:

53680 has been merged.

-- 
To view, visit https://gerrit.ovirt.org/52937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eb50f57cf6f21496f7a8ef70f80693336ae803
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: remove unused sendKeys verb

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: vm: remove unused sendKeys verb
..


Patch Set 1: Code-Review+1

AFAIK neither host-deploy nor hosted engine are using that verb, so ok for 
removing it on my side.

-- 
To view, visit https://gerrit.ovirt.org/54514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I709610a43cdf58464147ed6c7167d93558e29451
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: repoplot: Distribute repoplot tool

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: repoplot: Distribute repoplot tool
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/53941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacdd1630c67d3efb8fff3e59388b89a2ea630fe8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Remove image run links in teardownImage

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: hsm: Remove image run links in teardownImage
..


Patch Set 3:

Please cherry-pick to 3.6 (and 3.6.3 if needed) branch.

-- 
To view, visit https://gerrit.ovirt.org/53298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4568aaac2ce26c67132a839d95b75dd97bb28f29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: createImageLinks: recreate if the link exists but it's broken

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: createImageLinks: recreate if the link exists but it's broken
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/52937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eb50f57cf6f21496f7a8ef70f80693336ae803
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: coverage: Add vdsm-coverage sub package
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/49807/5/vdsm.spec.in
File vdsm.spec.in:

Line 1499: %{_datadir}/%{vdsm_name}/gluster/tasks.py*
Line 1500: %endif
Line 1501: 
Line 1502: %files coverage
Line 1503: %defattr(-, root, root, -)
> We use this everywhere (e.g. line 1487) - why is this not needed?
since RPM 4.4 above line is set by default by rpm itself.
See for reference:
 - 
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions
 - https://fedorahosted.org/fpc/ticket/77

So unless you build for EPEL 4, the line can be omitted.
Line 1504: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/coverage.conf
Line 1505: %config(noreplace) %{_sysconfdir}/sysconfig/vdsm
Line 1506: 
Line 1507: %changelog


-- 
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: coverage: Add vdsm-coverage sub package
..


Patch Set 5:

(7 comments)

https://gerrit.ovirt.org/#/c/49807/5/Makefile.am
File Makefile.am:

Line 1: #
2008-2016
Line 2: # Copyright 2008-2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/49807/5/build-aux/Makefile.subs
File build-aux/Makefile.subs:

Line 1: #
2008-2016
Line 2: # Copyright 2008-2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/49807/5/configure.ac
File configure.ac:

Line 1: #
2008-2016
Line 2: # Copyright 2008-2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/49807/5/coverage/Makefile.am
File coverage/Makefile.am:

Line 1: #
Line 2: # Copyright 2015 Red Hat, Inc.
2015-2016
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/49807/5/coverage/README.md
File coverage/README.md:

Line 4: 
Line 5: ## Files
Line 6: 
Line 7: - /etc/vdsm/coverage.conf - coverage configuration file
Line 8: - /etc/sysconfig/vdsm - environment file for enabling coverage
is /etc/sysconfig/vdsm ok for debian as well?
Line 9: 
Line 10: ## Recording code coverage
Line 11: 
Line 12: 1.  Enable coverage in vdsm.conf:


https://gerrit.ovirt.org/#/c/49807/5/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 1: #
2011-2016
Line 2: # Copyright 2011-2013 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/49807/5/vdsm.spec.in
File vdsm.spec.in:

Line 1499: %{_datadir}/%{vdsm_name}/gluster/tasks.py*
Line 1500: %endif
Line 1501: 
Line 1502: %files coverage
Line 1503: %defattr(-, root, root, -)
above line is not useful if not building for epel5
Line 1504: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/coverage.conf
Line 1505: %config(noreplace) %{_sysconfdir}/sysconfig/vdsm
Line 1506: 
Line 1507: %changelog


-- 
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: drop fc21 support

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: drop fc21 support
..


Patch Set 2: Verified+1

Rebased

-- 
To view, visit https://gerrit.ovirt.org/53264
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f955e8f23c7ca99ba09f62db157375ffa27bb5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: drop fc21 support

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: automation: drop fc21 support
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53264
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f955e8f23c7ca99ba09f62db157375ffa27bb5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: storageServer: Normalize local path before escaping

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: storageServer: Normalize local path before escaping
..

storageServer: Normalize local path before escaping

Hosted engine setup does not normalize mount path, so hosted engine
storage domain with trailing slash:

/foo/

will be mounted at:

/rhev/data-center/mnt/_foo_

This is harmless until hosted engine try to import the hosted engine
storage domain, recreating the storage domain path from the storage
domain information, returning a normalized remote path. After importing
the domain, the host will have the same remote path mounted twice at
two different local paths:

/rhev/data-center/mnt/_foo
/rhev/data-center/mnt/_foo_

Mounting the same domain twice does not work, leading to failure.

Storage domains created in engine do not have this issue since engine
does not allow path with trailing slash.

We are normalizing mount remote and local path, both before mount, and
when reading mount information from /proc/mounts and /etc/mtab.
However, we were escaping slashes in the normal path *before*
normalizing it, so the normalization had no effect.

This patch normalize the local path before escaping slashes, to match
the intent of the original code, and avoid such issues in the future.

This change does not fix hosted engine system with unnormalized local
path. The only way to fix this is to disconnect the storage domain and
connect it again with a normalized path.

Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e
Bug-Url: https://bugzilla.redhat.com/1300749
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/52873
Continuous-Integration: Jenkins CI
Reviewed-by: Roy Golan 
Reviewed-by: Martin Sivák 
Reviewed-by: Simone Tiraboschi 
Reviewed-by: Sandro Bonazzola 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit b1b60ec663a8d599f3f889421bcc8bdd04030d9e)
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/53276/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 3ad5230..2e9b4a6 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -57,6 +57,7 @@
 self.assertEqual(str(errors), expected)
 
 
+@expandPermutations
 class MountConnectionTests(VdsmTestCase):
 
 def test_mountpoint(self):
@@ -64,6 +65,18 @@
 self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
 self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
 
+@permutations([
+# spec, localpath
+("/a/", "/tmp/_a"),
+("/a//", "/tmp/_a"),
+("/a/b", "/tmp/_a_b"),
+("/a//b", "/tmp/_a_b"),
+("/a/b_c", "/tmp/_a_b__c"),
+])
+def test_normalize_local_path(self, spec, localpath):
+con = MountConnection(spec, mountClass=FakeMount)
+self.assertEqual(con._mount.fs_file, localpath)
+
 
 @expandPermutations
 class TestMountConnectionEquality(VdsmTestCase):
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 25f0d46..a805f4e 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -206,7 +206,9 @@
 
 def __init__(self, spec, vfsType=None, options="", mountClass=mount.Mount):
 self._vfsType = vfsType
-self._remotePath = spec
+# Note: must be normalized before we escape "/" in _getLocalPath.
+# See https://bugzilla.redhat.com/1300749
+self._remotePath = normpath(spec)
 self._options = options
 self._mount = mountClass(spec, self._getLocalPath())
 


-- 
To view, visit https://gerrit.ovirt.org/53276
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6.3]: storageServer: Normalize local path before escaping

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: storageServer: Normalize local path before escaping
..

storageServer: Normalize local path before escaping

Hosted engine setup does not normalize mount path, so hosted engine
storage domain with trailing slash:

/foo/

will be mounted at:

/rhev/data-center/mnt/_foo_

This is harmless until hosted engine try to import the hosted engine
storage domain, recreating the storage domain path from the storage
domain information, returning a normalized remote path. After importing
the domain, the host will have the same remote path mounted twice at
two different local paths:

/rhev/data-center/mnt/_foo
/rhev/data-center/mnt/_foo_

Mounting the same domain twice does not work, leading to failure.

Storage domains created in engine do not have this issue since engine
does not allow path with trailing slash.

We are normalizing mount remote and local path, both before mount, and
when reading mount information from /proc/mounts and /etc/mtab.
However, we were escaping slashes in the normal path *before*
normalizing it, so the normalization had no effect.

This patch normalize the local path before escaping slashes, to match
the intent of the original code, and avoid such issues in the future.

This change does not fix hosted engine system with unnormalized local
path. The only way to fix this is to disconnect the storage domain and
connect it again with a normalized path.

Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e
Bug-Url: https://bugzilla.redhat.com/1300749
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/52873
Continuous-Integration: Jenkins CI
Reviewed-by: Roy Golan 
Reviewed-by: Martin Sivák 
Reviewed-by: Simone Tiraboschi 
Reviewed-by: Sandro Bonazzola 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit b1b60ec663a8d599f3f889421bcc8bdd04030d9e)
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/53277/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 3ad5230..2e9b4a6 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -57,6 +57,7 @@
 self.assertEqual(str(errors), expected)
 
 
+@expandPermutations
 class MountConnectionTests(VdsmTestCase):
 
 def test_mountpoint(self):
@@ -64,6 +65,18 @@
 self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
 self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
 
+@permutations([
+# spec, localpath
+("/a/", "/tmp/_a"),
+("/a//", "/tmp/_a"),
+("/a/b", "/tmp/_a_b"),
+("/a//b", "/tmp/_a_b"),
+("/a/b_c", "/tmp/_a_b__c"),
+])
+def test_normalize_local_path(self, spec, localpath):
+con = MountConnection(spec, mountClass=FakeMount)
+self.assertEqual(con._mount.fs_file, localpath)
+
 
 @expandPermutations
 class TestMountConnectionEquality(VdsmTestCase):
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 25f0d46..a805f4e 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -206,7 +206,9 @@
 
 def __init__(self, spec, vfsType=None, options="", mountClass=mount.Mount):
 self._vfsType = vfsType
-self._remotePath = spec
+# Note: must be normalized before we escape "/" in _getLocalPath.
+# See https://bugzilla.redhat.com/1300749
+self._remotePath = normpath(spec)
 self._options = options
 self._mount = mountClass(spec, self._getLocalPath())
 


-- 
To view, visit https://gerrit.ovirt.org/53277
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: drop fc21 support

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: automation: drop fc21 support
..

automation: drop fc21 support

Fedora 21 reached EOL long ago.
Dropping support for it

Change-Id: Ie3f955e8f23c7ca99ba09f62db157375ffa27bb5
Signed-off-by: Sandro Bonazzola 
---
D automation/build-artifacts.repos.fc21
D automation/check-merged.repos.fc21
D automation/check-patch.repos.fc21
3 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/53264/1

diff --git a/automation/build-artifacts.repos.fc21 
b/automation/build-artifacts.repos.fc21
deleted file mode 100644
index a80e9aa..000
--- a/automation/build-artifacts.repos.fc21
+++ /dev/null
@@ -1,2 +0,0 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
-ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-21/x86_64
diff --git a/automation/check-merged.repos.fc21 
b/automation/check-merged.repos.fc21
deleted file mode 12
index 2f02532..000
--- a/automation/check-merged.repos.fc21
+++ /dev/null
@@ -1 +0,0 @@
-check-patch.repos.fc21
\ No newline at end of file
diff --git a/automation/check-patch.repos.fc21 
b/automation/check-patch.repos.fc21
deleted file mode 100644
index 16ae431..000
--- a/automation/check-patch.repos.fc21
+++ /dev/null
@@ -1,3 +0,0 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
-ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
-ovirt-glusterfs-fedora,http://download.gluster.org/pub/gluster/glusterfs/LATEST/Fedora/fedora-21/x86_64


-- 
To view, visit https://gerrit.ovirt.org/53264
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3f955e8f23c7ca99ba09f62db157375ffa27bb5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: CI automation: Trigger post merge tests

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: CI automation: Trigger post merge tests
..


Patch Set 1: -Verified

-- 
To view, visit https://gerrit.ovirt.org/53263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a70a748ec607c0a273677a3368b832ce406cea2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: CI automation: Trigger post merge tests

[sbonazzo]

Sandro Bonazzola has uploaded a new change for review.

Change subject: CI automation: Trigger post merge tests
..

CI automation: Trigger post merge tests

Trigger tests execution after a merge.

Change-Id: I1a70a748ec607c0a273677a3368b832ce406cea2
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/52779
Continuous-Integration: Jenkins CI
Reviewed-by: Barak Korren 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit 4f1dd31ab3eb1424d4462bec656cf03fa3e59e56)
---
A automation/check-merged.packages
A automation/check-merged.repos.el7
A automation/check-merged.repos.fc21
A automation/check-merged.repos.fc22
A automation/check-merged.repos.fc23
A automation/check-merged.sh
6 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/53263/1

diff --git a/automation/check-merged.packages b/automation/check-merged.packages
new file mode 12
index 000..3858aae
--- /dev/null
+++ b/automation/check-merged.packages
@@ -0,0 +1 @@
+check-patch.packages
\ No newline at end of file
diff --git a/automation/check-merged.repos.el7 
b/automation/check-merged.repos.el7
new file mode 12
index 000..86000f8
--- /dev/null
+++ b/automation/check-merged.repos.el7
@@ -0,0 +1 @@
+check-patch.repos.el7
\ No newline at end of file
diff --git a/automation/check-merged.repos.fc21 
b/automation/check-merged.repos.fc21
new file mode 12
index 000..2f02532
--- /dev/null
+++ b/automation/check-merged.repos.fc21
@@ -0,0 +1 @@
+check-patch.repos.fc21
\ No newline at end of file
diff --git a/automation/check-merged.repos.fc22 
b/automation/check-merged.repos.fc22
new file mode 12
index 000..9add81b
--- /dev/null
+++ b/automation/check-merged.repos.fc22
@@ -0,0 +1 @@
+check-patch.repos.fc22
\ No newline at end of file
diff --git a/automation/check-merged.repos.fc23 
b/automation/check-merged.repos.fc23
new file mode 12
index 000..c6649a0
--- /dev/null
+++ b/automation/check-merged.repos.fc23
@@ -0,0 +1 @@
+check-patch.repos.fc23
\ No newline at end of file
diff --git a/automation/check-merged.sh b/automation/check-merged.sh
new file mode 12
index 000..a61652a
--- /dev/null
+++ b/automation/check-merged.sh
@@ -0,0 +1 @@
+check-patch.sh
\ No newline at end of file


-- 
To view, visit https://gerrit.ovirt.org/53263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a70a748ec607c0a273677a3368b832ce406cea2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: CI automation: Trigger post merge tests

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: CI automation: Trigger post merge tests
..


Patch Set 1: Verified+1 Code-Review+1

Jenkins is failing having check_merged not existing on 3.6 branch.

-- 
To view, visit https://gerrit.ovirt.org/53263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a70a748ec607c0a273677a3368b832ce406cea2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageServer: Normalize local path before escaping

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: storageServer: Normalize local path before escaping
..


Patch Set 1:

4 +1 and a +1 on both automated and manual testing, can we get this merged?

-- 
To view, visit https://gerrit.ovirt.org/52873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: createImageLinks: recreate if the link exists but it's broken

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: createImageLinks: recreate if the link exists but it's broken
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/52937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eb50f57cf6f21496f7a8ef70f80693336ae803
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageServer: Normalize local path before escaping

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: storageServer: Normalize local path before escaping
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/52873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4db1fb7dfe4627442f87502563a578bb1f184c1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] build: assumptions about the path do not work for dist...

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: [wip] build: assumptions about the path do not work for 
distcheck
..


Patch Set 1:

Nice start, you're on the right way.

-- 
To view, visit https://gerrit.ovirt.org/52508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If396ce1d8e2b4ce487c56044974ea71fa15e994f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 3: Code-Review+1

The new qemu-kvm-ev should be available on all supported repositories.

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: mark test_mkFloppyFs as broken

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: tests: mark test_mkFloppyFs as broken
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: build: Align Fedora and EL qemu requirements
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ef5ff5c70e9cd5979e34023f2bcf46787a8c07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/49974/3/vdsm.spec.in
File vdsm.spec.in:

Line 237
Line 238
Line 239
Line 240
Line 241
while aligning qemu versioning, is 2.1.3 enough for Fedora?


-- 
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: Align RHEL and CentOS qemu* requiments
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49974/3/vdsm.spec.in
File vdsm.spec.in:

Line 237
Line 238
Line 239
Line 240
Line 241
> Probably not a bad idea to bump the requirement, but let's do this in a sep
+1


-- 
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb1035641fd03ecd3c7b38f398a2b7679f4801
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches