Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[eedri]

Eyal Edri has abandoned this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Abandoned

already implemented. see danken comment.

-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 4: Code-Review-1

I believe that this has been fixed in https://gerrit.ovirt.org/46135 and other 
patches.

Please abandon.

-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[dcaroest]

David Caro has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.req
File automation/check-patch.req:

Line 1: yum
 Who will maintain the duplicate requirements?
Yep, if it's properly defined in the spec, you can build the rpm and install 
it, or similar to get the deps, but as long as it's not handled you will have 
to add it here too.

Until now we did it in the jenkins jobs directly, and that made patches break 
each time there was a new dep
Line 2: sudo
Line 3: dhclient
Line 4: autoreconf
Line 5: gettext-devel


https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.sh
File automation/check-patch.sh:

Line 1: #!/bin/bash -e
Line 2: #
Line 3: # Run on each patch to gerrit, should be faster than check-meged and 
require
Line 4: # less resources but thorough enough to provide relevant feedback
 David: we need more specific contract with the ci
Nop, there's only 0 or 1, if you don't want to fail the pass, return 0, if you 
do, return != 0. No need for a third state
Line 5: 
Line 6: echo Hello - ifra functional tests
Line 7: 
Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*


Line 5: 
Line 6: echo Hello - ifra functional tests
Line 7: 
Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*
Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm*
 Errors are ignored - we should check and handle error for each command.
set -e breaks execution if there are any failed commands
Line 10: 
Line 11: 
Line 12: vdsm-tool configure --force
Line 13: service vdsmd start


-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.req
File automation/check-patch.req:

Line 1: yum
 because this is how ci scripts currently work and I don't plan to parse the
Who will maintain the duplicate requirements?

Each time we add something the spec we must add it also here.
Line 2: sudo
Line 3: dhclient
Line 4: autoreconf
Line 5: gettext-devel


-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/41928/3/automation/check-patch.sh
File automation/check-patch.sh:

Line 4: # less resources but thorough enough to provide relevant feedback
Line 5: 
Line 6: echo Hello - ifra functional tests
Line 7: 
Line 8: ./autogen.sh --system; make rpm NOSE_EXCLUDE=.*
 wip , I know what I do and I need to update the commit message. the reason 
Makes sense, but not for each patch - this belongs to check-merge.sh.

Check done for each patch should be fast and reliable. Functional tests are too 
slow and fragile to run automatically for each test.
Line 9: yum install ~/rpmbuild/RPMS/noarch/vdsm*
Line 10: 
Line 11: 
Line 12: vdsm-tool configure --force


-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Caro dcaro...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches